reactos.git
8 years ago[RSYM]
Amine Khaldi [Sun, 1 Sep 2013 16:13:16 +0000 (16:13 +0000)]
[RSYM]
* Addendum to r59938.

svn path=/trunk/; revision=59948

8 years ago[FRAMEDYN]
Pierre Schweitzer [Sun, 1 Sep 2013 16:10:02 +0000 (16:10 +0000)]
[FRAMEDYN]
Remove operator LPWSTR() in favor of operator LPCWSTR() const (likely to fix its export ;-))
Add missing operators implementations as inline

svn path=/trunk/; revision=59947

8 years ago[FRAMEDYN]
Amine Khaldi [Sun, 1 Sep 2013 15:51:32 +0000 (15:51 +0000)]
[FRAMEDYN]
* Fix the MSVC build for real now, so that we don't keep fixing it bit by bit until r60000.

svn path=/trunk/; revision=59946

8 years ago[SAMSRV]
Eric Kohl [Sun, 1 Sep 2013 15:46:00 +0000 (15:46 +0000)]
[SAMSRV]
- Improve SamRegCloseKey and fix all calls to it accordingly. Also replace all calls to NtClose by calls to SampRegCloseKey.
- Add a resource to protect the Samr functions from concurrent access.

svn path=/trunk/; revision=59945

8 years ago[FRAMEDYN]
Pierre Schweitzer [Sun, 1 Sep 2013 15:44:17 +0000 (15:44 +0000)]
[FRAMEDYN]
Comment out exports that fail

svn path=/trunk/; revision=59944

8 years ago[FRAMEDYN]
Pierre Schweitzer [Sun, 1 Sep 2013 15:34:38 +0000 (15:34 +0000)]
[FRAMEDYN]
Don't export anything on MSVC yet.
Some symbols are not found. Dunno why.

svn path=/trunk/; revision=59943

8 years ago[FRAMEDYN]
Pierre Schweitzer [Sun, 1 Sep 2013 15:04:21 +0000 (15:04 +0000)]
[FRAMEDYN]
Fix typo

svn path=/trunk/; revision=59942

8 years ago[FRAMEDYN]
Pierre Schweitzer [Sun, 1 Sep 2013 14:54:33 +0000 (14:54 +0000)]
[FRAMEDYN]
Fix a typo (and so a bug), spotted by MSVC. I don't thank you G++...
Attempt to fix build with MSVC

svn path=/trunk/; revision=59941

8 years ago[FRAMEDYN]
Pierre Schweitzer [Sun, 1 Sep 2013 14:48:09 +0000 (14:48 +0000)]
[FRAMEDYN]
Partplement framedyn.dll
So far, only CHString class is implemented in it

Regarding CHString class implementation:
It has been implemented matching Windows behavior and bugs
It might not be really nice at some points but this ensures
compatibility with applications relying on it.
As a side note: this might explain why this API was abandonned after w2k3...

Regarding the DLL itself:
Its implementation into ReactOS allows systeminfo.exe application from w2k3 to
load and start initialization into ReactOS. It stops working later on with some
IDispatch error.
The DLL cannot be used to build any application against framedyn.dll with our "default" BE (read with G++).
Only MSVC mangled name are exported so far (as on Windows ;-)) thanks to aliasing. This is why there are two spec files.
This makes G++ unable to link with it though. This is the reason why there are no framedyn_apitests so far.
Furthermore, the DLL only have exports for x86 and none for x64 for the moment.

Any help is welcome for having exports for x64 target and to be able to have aliasing for G++ (from its mangled names
to MSVC ones).

svn path=/trunk/; revision=59940

8 years ago[PDSK]
Pierre Schweitzer [Sun, 1 Sep 2013 14:30:28 +0000 (14:30 +0000)]
[PDSK]
Add two headers: chstring.h and provexce.h
They are used for framedyn.dll stuff, for instance

So far, the CHString class is not fully populated. It is only
populated with exported stuff from framedyn.dll

svn path=/trunk/; revision=59939

8 years ago[RSYM]
Amine Khaldi [Sun, 1 Sep 2013 13:23:54 +0000 (13:23 +0000)]
[RSYM]
* Don't overwrite the MZ header when there are no long section names.
* Correct an error including 4 more bytes than needed in the coff strings.
* Brought to you by Arty.

svn path=/trunk/; revision=59938

8 years ago[APPWIZ]
Hermès Bélusca-Maïto [Sun, 1 Sep 2013 12:41:58 +0000 (12:41 +0000)]
[APPWIZ]
- Convert some language resource files into UTF-8 without BOM (aka. ANSI as UTF-8 with Notepad++).
- Improve some French translation.
- Fix Czech translation, thanks Radek :)
(Addendum to r59924 and r59925)

svn path=/trunk/; revision=59937

8 years ago[RSYM]
Amine Khaldi [Sun, 1 Sep 2013 11:17:36 +0000 (11:17 +0000)]
[RSYM]
* Fix long section names and correct some wrong use of ULONG_PTR. Brought to you by Arty.

svn path=/trunk/; revision=59936

8 years ago[DBGHELP]
Amine Khaldi [Sun, 1 Sep 2013 11:11:52 +0000 (11:11 +0000)]
[DBGHELP]
* Speedup dbghelp mainly for the x64 builds. Brought to you by Arty. Should be sent upstream.

svn path=/trunk/; revision=59935

8 years ago[NPFS/KERNEL32]
Amine Khaldi [Sun, 1 Sep 2013 10:16:29 +0000 (10:16 +0000)]
[NPFS/KERNEL32]
* Back out r59915 for a moment so we can use Patchbot.

svn path=/trunk/; revision=59934

8 years ago[CMAKE]: Fix a comment typo only.
Hermès Bélusca-Maïto [Sun, 1 Sep 2013 00:11:56 +0000 (00:11 +0000)]
[CMAKE]: Fix a comment typo only.
[NTDLL-KERNEL32-BASESRV-WINSRV]: Specify by hand (hackz for MSVC builds) that the dll will be a "Console DLL" (ie. not a native one nor a Gui DLL).
[BASESRV]: Explicitely set the DLL entry point to DllMain (unusued).
[WINSRV]: Explicitely set the DLL entry point to DllMain (unusued) AND REMOVE usage of msvcrt (that might pose problems when testing with Windows msvcrt etc...) and use libcntpr instead.

Thanks to Amine for having helped me in solving a problem with delayed imports.

svn path=/trunk/; revision=59933

8 years ago[KERNEL32]: Add a DPRINT1 when failing GetCPInfo in kernel32, to highlight the fact...
Alex Ionescu [Sat, 31 Aug 2013 19:24:54 +0000 (19:24 +0000)]
[KERNEL32]: Add a DPRINT1 when failing GetCPInfo in kernel32, to highlight the fact our MSVCRT is sending us bogus codepage/locale IDs.

svn path=/trunk/; revision=59930

8 years ago[RTL]
Hermès Bélusca-Maïto [Sat, 31 Aug 2013 17:34:37 +0000 (17:34 +0000)]
[RTL]
Implement RtlDefaultNpAcl, needed for giving a default security to named pipes. Makes Win2k3 kernel32 happy when one creates named pipes for SCM and so on.
Getting the SID of the caller is done as described in http://www.osronline.com/article.cfm?article=50 in "Extracting the SID from the Token".

svn path=/trunk/; revision=59928

8 years ago[browseui]
Giannis Adamopoulos [Sat, 31 Aug 2013 16:55:49 +0000 (16:55 +0000)]
[browseui]
- Improve the stub for CAddressEditBox::SetOwner to make the rest of browseui happy for now
- In CShellBrowser::Initialize browse to the pidl that is passed as parameter instead of always browsing to the desktop folder
- Fix a bug in atl class CContainedWindowT::DefWindowProc that was calling the window proc with an invalid hwnd.

svn path=/trunk/; revision=59927

8 years ago[NTOS/FSRTL]
Aleksey Bragin [Sat, 31 Aug 2013 16:36:34 +0000 (16:36 +0000)]
[NTOS/FSRTL]
- FsRtlCopyWrite: Fix typos in local var names and comments.
- FsRtlCopyWrite: Fix copypasta in a call to FastIoCheckIfPossible: wait flag shouldn't be always TRUE in this case (it's determined by Wait parameter).
- FsRtlCopyRead: Fix updating of CurrentByteOffset.
- FsRtlAcquireFileForCcFlushEx / FsRtlReleaseFileForCcFlush: Handle the case when FastIO callback may fail and FsRtl still needs to act as if FastIO callback would be missing at all.
- Implement FsRtlAcquireFileForModWriteEx / FsRtlReleaseFileForModWrite thanks to Rajeev Nagar's book.
- Now all necessary FsRtl locking/unlocking mechanisms exist.

svn path=/trunk/; revision=59926

8 years ago[APPWIZ]
Amine Khaldi [Sat, 31 Aug 2013 16:28:01 +0000 (16:28 +0000)]
[APPWIZ]
* Addendum to r59924. Radek please review.

svn path=/trunk/; revision=59925

8 years ago[APPWIZ]
Amine Khaldi [Sat, 31 Aug 2013 16:14:12 +0000 (16:14 +0000)]
[APPWIZ]
* Remove some Wine specific text and introduce a tiny update to the German translation. By zehnvor.
CORE-7221 #resolve #comment Committed in r59924. Danke.

svn path=/trunk/; revision=59924

8 years ago[NTOSKRNL]
Amine Khaldi [Sat, 31 Aug 2013 16:02:13 +0000 (16:02 +0000)]
[NTOSKRNL]
* Fix several print specifiers.
* Add some missing variables to debug prints.

svn path=/trunk/; revision=59923

8 years agoreally fix build
Giannis Adamopoulos [Sat, 31 Aug 2013 15:05:49 +0000 (15:05 +0000)]
really fix build

svn path=/trunk/; revision=59922

8 years ago[FREELDR-KDCOM-KDBG]
Hermès Bélusca-Maïto [Sat, 31 Aug 2013 15:01:50 +0000 (15:01 +0000)]
[FREELDR-KDCOM-KDBG]
Fix debugging issues.

svn path=/trunk/; revision=59921

8 years agoCode formatting only
Hermès Bélusca-Maïto [Sat, 31 Aug 2013 15:00:17 +0000 (15:00 +0000)]
Code formatting only

svn path=/trunk/; revision=59920

8 years ago[shell32]
Giannis Adamopoulos [Sat, 31 Aug 2013 14:59:45 +0000 (14:59 +0000)]
[shell32]
- Remove a line that shouldn't have been committed

svn path=/trunk/; revision=59919

8 years ago[shell32]
Giannis Adamopoulos [Sat, 31 Aug 2013 14:53:01 +0000 (14:53 +0000)]
[shell32]
- Halfplement CDesktopBrowser::BrowseObject. Now when the user tries to open a folder from the desktop we will try to create a new explorer window.
- ps: this affects only explorer_new and the rest of the shell is still not working well enough to actually show the new window

svn path=/trunk/; revision=59918

8 years ago[SAL]
Amine Khaldi [Sat, 31 Aug 2013 11:07:09 +0000 (11:07 +0000)]
[SAL]
* Forward __callback to __inner_callback now that wincrypt.h has the proper inclusion.

svn path=/trunk/; revision=59917

8 years ago[CONSRV]: One last fix to CONSRV_API_CONNECTINFO. We now have compatibility with...
Alex Ionescu [Sat, 31 Aug 2013 08:30:00 +0000 (08:30 +0000)]
[CONSRV]: One last fix to CONSRV_API_CONNECTINFO. We now have compatibility with Windows and kernel32 is much much happier.
[CONSRV]: Implement Case11 of BaseSrvNlsCreateSection, but we seem to be getting bogus locale IDs.

svn path=/trunk/; revision=59916

8 years agoCORE-2198 #resolve #time 15m #comment [NPFS/KERNEL32]: Always use the right semantics.
Alex Ionescu [Sat, 31 Aug 2013 07:29:26 +0000 (07:29 +0000)]
CORE-2198 #resolve #time 15m #comment [NPFS/KERNEL32]: Always use the right semantics.

svn path=/trunk/; revision=59915

8 years ago[NPFS]: Add support for a few more volume information classes, and disable APCs like...
Alex Ionescu [Sat, 31 Aug 2013 07:07:43 +0000 (07:07 +0000)]
[NPFS]: Add support for a few more volume information classes, and disable APCs like an FS should.

svn path=/trunk/; revision=59914

8 years ago[NTDLL]: Use NT-style calculation in CsrClientCallServer. In special cases, structure...
Alex Ionescu [Sat, 31 Aug 2013 02:19:36 +0000 (02:19 +0000)]
[NTDLL]: Use NT-style calculation in CsrClientCallServer. In special cases, structures can be padded at the end, causing the size of the structure - the size of last field, not to be equal to the offset of the last field. Doing math the NT way will, in some cases (if the CSR union is not 8-byte aligned), cause the TotalLength to be 4 bytes bigger than really needed.
[CSRSRV]: Increase the padding to 39*4 bytes, instead of 35, to match Windows.

svn path=/trunk/; revision=59913

8 years ago[CPORT]: We shouldn't be DPRINT1'ing from the library designed to DPRINT...
Alex Ionescu [Sat, 31 Aug 2013 02:16:04 +0000 (02:16 +0000)]
[CPORT]: We shouldn't be DPRINT1'ing from the library designed to DPRINT...

svn path=/trunk/; revision=59912

8 years agoconfigure: remove bashism.
Sylvain Petreolle [Sat, 31 Aug 2013 00:05:29 +0000 (00:05 +0000)]
configure: remove bashism.

svn path=/trunk/; revision=59910

8 years ago[NTOSKRNL]: Forcefully set IMAGE_DLLCHARACTERISTICS_NO_ISOLATION on all images. See...
Alex Ionescu [Fri, 30 Aug 2013 19:54:44 +0000 (19:54 +0000)]
[NTOSKRNL]: Forcefully set IMAGE_DLLCHARACTERISTICS_NO_ISOLATION on all images. See comment for more information. Windows' kernel32.dll now beautifully loads to the ReactOS winlogon screen (which nobody should ever see -- it's being shown because RtlDefaultNpAcl is not implemented in ReactOS, and thus all named pipes die (SCM, etc...)

svn path=/trunk/; revision=59909

8 years ago[HIVESYS]: Set Session Manager\AppCompatibility, DisableAppCompat = TRUE in ReactOS...
Alex Ionescu [Fri, 30 Aug 2013 19:37:03 +0000 (19:37 +0000)]
[HIVESYS]: Set Session Manager\AppCompatibility, DisableAppCompat = TRUE in ReactOS, which avoids Kernel32 from doing app compat stuff.

svn path=/trunk/; revision=59908

8 years ago[CONSRV]: Stubplement the remaining APIs needed for Windows kernel32.
Hermès Bélusca-Maïto [Fri, 30 Aug 2013 17:53:45 +0000 (17:53 +0000)]
[CONSRV]: Stubplement the remaining APIs needed for Windows kernel32.

svn path=/trunk/; revision=59907

8 years agoEnable the C_ASSERT that validates our CONSRV structure matches the expected size.
Alex Ionescu [Fri, 30 Aug 2013 17:32:10 +0000 (17:32 +0000)]
Enable the C_ASSERT that validates our CONSRV structure matches the expected size.

svn path=/trunk/; revision=59906

8 years ago[NTOSKRNL]: 903 was not supposed to have this change.
Alex Ionescu [Fri, 30 Aug 2013 17:28:45 +0000 (17:28 +0000)]
[NTOSKRNL]: 903 was not supposed to have this change.

svn path=/trunk/; revision=59905

8 years ago[CONSRV]: Reorganize/rename/add some fields to CONSRV_API_CONNECTINFO, partially...
Alex Ionescu [Fri, 30 Aug 2013 17:14:41 +0000 (17:14 +0000)]
[CONSRV]: Reorganize/rename/add some fields to CONSRV_API_CONNECTINFO, partially based on an MSDN page, and a little bit of RE, which makes it closer to the Windows structure. No behavioral change should have happened as a result of these changes.

svn path=/trunk/; revision=59904

8 years ago[RTL]: Make RtlUnhandledExceptionFilter show a stack trace, so at least we can see...
Alex Ionescu [Fri, 30 Aug 2013 15:37:10 +0000 (15:37 +0000)]
[RTL]: Make RtlUnhandledExceptionFilter show a stack trace, so at least we can see where the exception came from.

svn path=/trunk/; revision=59903

8 years ago[KERNEL32]
Amine Khaldi [Fri, 30 Aug 2013 14:16:47 +0000 (14:16 +0000)]
[KERNEL32]
* Fix yet another buggy DPRINT.

svn path=/trunk/; revision=59902

8 years ago[CONSRV]: Add some DPRINT1 information.
Hermès Bélusca-Maïto [Fri, 30 Aug 2013 11:36:22 +0000 (11:36 +0000)]
[CONSRV]: Add some DPRINT1 information.

svn path=/trunk/; revision=59901

8 years ago[USERSRV]: Stubplement all the APIs needed for Windows kernel32.
Hermès Bélusca-Maïto [Fri, 30 Aug 2013 11:33:25 +0000 (11:33 +0000)]
[USERSRV]: Stubplement all the APIs needed for Windows kernel32.

svn path=/trunk/; revision=59900

8 years ago[GDI32]
Amine Khaldi [Fri, 30 Aug 2013 10:51:12 +0000 (10:51 +0000)]
[GDI32]
* Fix some print specifiers.

svn path=/trunk/; revision=59899

8 years ago[USER32]
Amine Khaldi [Fri, 30 Aug 2013 10:25:16 +0000 (10:25 +0000)]
[USER32]
* Fix some print specifiers.

svn path=/trunk/; revision=59898

8 years ago[PSDK]
Amine Khaldi [Fri, 30 Aug 2013 10:17:22 +0000 (10:17 +0000)]
[PSDK]
* Annotate sspi.h.

svn path=/trunk/; revision=59897

8 years ago[CMAKE]
Amine Khaldi [Fri, 30 Aug 2013 10:09:56 +0000 (10:09 +0000)]
[CMAKE]
* Set the subsystem version as 5.01 for recent MSVC toolchains.

svn path=/trunk/; revision=59896

8 years ago[BASESRV]: Fix critical bug in BaseSrvNlsGetUserInfo.
Alex Ionescu [Fri, 30 Aug 2013 06:53:07 +0000 (06:53 +0000)]
[BASESRV]: Fix critical bug in BaseSrvNlsGetUserInfo.

svn path=/trunk/; revision=59895

8 years ago[NTDLL/RTL]: Stub and export all the routines that Kernel32 needs.
Alex Ionescu [Fri, 30 Aug 2013 06:34:16 +0000 (06:34 +0000)]
[NTDLL/RTL]: Stub and export all the routines that Kernel32 needs.

svn path=/trunk/; revision=59894

8 years ago[NTOS]
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 22:24:46 +0000 (22:24 +0000)]
[NTOS]
buzdelabuz2 !! We've unveiled who you are !!
Fix header information.

svn path=/trunk/; revision=59893

8 years ago[NTOS]
Aleksey Bragin [Thu, 29 Aug 2013 22:07:24 +0000 (22:07 +0000)]
[NTOS]
- Implement two types of FsRtl locking functions: exclusive lock and Cc flushing lock, along with their releasing counterparts, without the filter callbacks support. These functions are unused in trunk now but would be needed by proper Cc/Mm/IFS in future.

svn path=/trunk/; revision=59889

8 years ago[BASESRV]
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 21:37:22 +0000 (21:37 +0000)]
[BASESRV]
Fix the "fix" of r59887, i.e. add a stub for the unknown api.

svn path=/trunk/; revision=59888

8 years agoHere too ;)
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 21:29:33 +0000 (21:29 +0000)]
Here too ;)

svn path=/trunk/; revision=59887

8 years ago[BASESRV]: forgot to update the name table.
Alex Ionescu [Thu, 29 Aug 2013 21:27:18 +0000 (21:27 +0000)]
[BASESRV]: forgot to update the name table.

svn path=/trunk/; revision=59886

8 years agoPartially revert r59884 because of an enum name collision (which broke build).
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 21:23:46 +0000 (21:23 +0000)]
Partially revert r59884 because of an enum name collision (which broke build).

svn path=/trunk/; revision=59885

8 years ago[BASESRV]
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 21:14:49 +0000 (21:14 +0000)]
[BASESRV]
- Fix nls.c header information.
- Rename BasepUnknown to BasepDebugProcess according to j00ru's http://j00ru.vexillium.org/csrss_list/api_list.html#Windows_2k3 and what Alex_Ionescu committed in r59879 (deprecated api).

svn path=/trunk/; revision=59884

8 years ago[NTDLL]
Amine Khaldi [Thu, 29 Aug 2013 21:12:40 +0000 (21:12 +0000)]
[NTDLL]
* Fix several print specifiers.
* Add missing Status variable to a DPRINT1.

svn path=/trunk/; revision=59883

8 years ago[BASESRV]: Fix definition of NLS_USER_INFO so that it matches exactly that of Server...
Alex Ionescu [Thu, 29 Aug 2013 21:00:54 +0000 (21:00 +0000)]
[BASESRV]: Fix definition of NLS_USER_INFO so that it matches exactly that of Server 2003 (this now makes BASE_SERVER_STATIC_DATA correct too).
[BASESRV]: Implement BaseSrvNlsGetUserInfo.

svn path=/trunk/; revision=59882

8 years ago[KERNEL32]
Amine Khaldi [Thu, 29 Aug 2013 20:37:02 +0000 (20:37 +0000)]
[KERNEL32]
* Fix several print specifiers.

svn path=/trunk/; revision=59881

8 years ago[KERNEL32]: Passing flag 0 to QueryActCtx is valid, don't fail.
Alex Ionescu [Thu, 29 Aug 2013 20:14:43 +0000 (20:14 +0000)]
[KERNEL32]: Passing flag 0 to QueryActCtx is valid, don't fail.

svn path=/trunk/; revision=59880

8 years ago[BASESRV]: The last few APIs were off-by-one due to an unimplmented (in Windows)...
Alex Ionescu [Thu, 29 Aug 2013 20:13:31 +0000 (20:13 +0000)]
[BASESRV]: The last few APIs were off-by-one due to an unimplmented (in Windows) or deprecated api.c
[BASESRV]: Implement BaseSrvNlsCreateSection, which is needed by Windows kernel32.dll. Also implement the delay-loading functionality it needs.

svn path=/trunk/; revision=59879

8 years ago[NLS]. Add NLS files.
Alex Ionescu [Thu, 29 Aug 2013 19:07:10 +0000 (19:07 +0000)]
[NLS]. Add NLS files.

svn path=/trunk/; revision=59878

8 years agoFormatting fix only.
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 18:13:24 +0000 (18:13 +0000)]
Formatting fix only.

svn path=/trunk/; revision=59877

8 years agomoar failz
Alex Ionescu [Thu, 29 Aug 2013 17:46:26 +0000 (17:46 +0000)]
moar failz

svn path=/trunk/; revision=59875

8 years agofix a dprint
Alex Ionescu [Thu, 29 Aug 2013 17:44:34 +0000 (17:44 +0000)]
fix a dprint

svn path=/trunk/; revision=59874

8 years agoFix variable naming.
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 17:40:21 +0000 (17:40 +0000)]
Fix variable naming.

svn path=/trunk/; revision=59873

8 years ago[BASESRV]: Stubplement all the APIs so that our IDs match with Windows. Windows kerne...
Alex Ionescu [Thu, 29 Aug 2013 17:00:10 +0000 (17:00 +0000)]
[BASESRV]: Stubplement all the APIs so that our IDs match with Windows. Windows kernel32 now dies when calling NLSCreateSection.

svn path=/trunk/; revision=59872

8 years ago[KERNEL32]: Fix a bug in QueryActCtx
Alex Ionescu [Thu, 29 Aug 2013 16:42:14 +0000 (16:42 +0000)]
[KERNEL32]: Fix a bug in QueryActCtx

svn path=/trunk/; revision=59871

8 years ago[KERNEL32]
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 14:31:06 +0000 (14:31 +0000)]
[KERNEL32]
Use GetSystemDirectoryW for building the path to console.dll

svn path=/trunk/; revision=59870

8 years ago[KERNEL32]
Hermès Bélusca-Maïto [Thu, 29 Aug 2013 12:20:29 +0000 (12:20 +0000)]
[KERNEL32]
Fix some headers information.
CORE-7421 #resolve #comment Fixed in revision r59869, thanks :)

svn path=/trunk/; revision=59869

8 years agoCORE-6639 #resolve #time 1d #comment Guard pages now work ;-)
Alex Ionescu [Thu, 29 Aug 2013 07:33:10 +0000 (07:33 +0000)]
CORE-6639 #resolve #time 1d #comment Guard pages now work ;-)
[NDK]: Fix definition of a global flag.
[RTL]: RtlpCreateUserStack: 1) If the image is invalid, bail out. 2) If the stack commit is higher than reserve, adjust reserve. 3) After allocating a guard page, the stack limit is now ABOVE the guard page, not BELOW it (stack grows backward!).
[RTL]: Remove the hack which always Commited the "StackReserve" value. Threads now have a 4-64KB stack, instead of a 1MB stack.
[NTOSKRNL]: Implement MiAccessCheck and MiCheckForUserStackOverflow, which handle guard page + stack expansion.
[USER32]: Because threads now correctly run with a smaller stack than usual (and expand as needed), remove some checks in user-mode callbacks which forced larger stacks.

svn path=/trunk/; revision=59868

8 years ago[HIDPARSE]: Stop the HID debug spam.
Alex Ionescu [Thu, 29 Aug 2013 06:09:28 +0000 (06:09 +0000)]
[HIDPARSE]: Stop the HID debug spam.

svn path=/trunk/; revision=59867

8 years ago[NDK]: Add some RTL_ACTIVATION_CONTEXT flags from the ASSERTs in the checked ntdll...
Alex Ionescu [Thu, 29 Aug 2013 04:34:00 +0000 (04:34 +0000)]
[NDK]: Add some RTL_ACTIVATION_CONTEXT flags from the ASSERTs in the checked ntdll.dll. Guess some other ones based on what seems to be the naming pattern (can't find them on Google, so who knows).
[RTL]: Make the Wine RtlActivationContext* APIs use the native RTL flags, not the Win32 flags.
[KERNEL32]: Separate Wine-specific ActCtx code from NT-compatible ActCtx code, and reimplement the latter. Now all ActCtx APIs except CreateActCtx (which is a mess on Windows) are compatible with the real NT RtlActivationContext APIs in terms of flags.
[KERNEL32]: Fix the hacks which were sending Win32 flags to the NT Native Rtl* functions.

svn path=/trunk/; revision=59866

8 years ago[KERNEL32]: Implement BaseProcessInitPostImport. Windows NTDLL now loads much, much...
Alex Ionescu [Thu, 29 Aug 2013 00:07:00 +0000 (00:07 +0000)]
[KERNEL32]: Implement BaseProcessInitPostImport. Windows NTDLL now loads much, much further, all the way to lsass.exe now.

svn path=/trunk/; revision=59865

8 years ago[NTDLL]: Fix CsrpConnectToServer to use the correct CSR_API_CONNECTINFO structure.
Alex Ionescu [Thu, 29 Aug 2013 00:02:15 +0000 (00:02 +0000)]
[NTDLL]: Fix CsrpConnectToServer to use the correct CSR_API_CONNECTINFO structure.
[CSRSRV]: Fix definition of CSR_API_CONNECTINFO structure. It is now compatible with Server 2003. Also, set the DebugFlag.

svn path=/trunk/; revision=59864

8 years ago[WINHLP32]
Amine Khaldi [Wed, 28 Aug 2013 23:14:41 +0000 (23:14 +0000)]
[WINHLP32]
* Improve resource files layout to make it consistent with the rest of our codebase. By Erdem Ersoy.
CORE-7414 #resolve #comment Committed in r59863. Thanks.

svn path=/trunk/; revision=59863

8 years ago[NTDLL]: Don't give every process a KernelCallbackTable. Only GUI processes need...
Alex Ionescu [Wed, 28 Aug 2013 22:35:28 +0000 (22:35 +0000)]
[NTDLL]: Don't give every process a KernelCallbackTable. Only GUI processes need one.
[USER32]: Initialize the KernelCallbackTable when loaded in GUI process. Also, store it statically instead of requiring a heap allocation (just like Windows).

svn path=/trunk/; revision=59862

8 years ago[TRANSLATIONS]
Amine Khaldi [Wed, 28 Aug 2013 22:06:34 +0000 (22:06 +0000)]
[TRANSLATIONS]
* Turkish translation update and improvements by Erdem Ersoy.
CORE-7408 #resolve #comment Committed in r59861. Thanks.

svn path=/trunk/; revision=59861

8 years ago[CMAKE/VS]
Amine Khaldi [Wed, 28 Aug 2013 21:37:54 +0000 (21:37 +0000)]
[CMAKE/VS]
* Introduce the support for organizing the solution into a hierarchy of folders that matches our codebase layout.
* You can enable this feature by adding -DUSE_FOLDER_STRUCTURE=1 to your configure phase (the VSSolution one).
* Based on a patch by Yuntian Zhang with my improvements.
CORE-7412

svn path=/trunk/; revision=59860

8 years ago[NDK]: Fix Vista vs Server 2003 definition of SECTION_IMAGE_INFORMATION.
Alex Ionescu [Wed, 28 Aug 2013 21:09:16 +0000 (21:09 +0000)]
[NDK]: Fix Vista vs Server 2003 definition of SECTION_IMAGE_INFORMATION.
[NTOSKRNL]: Gut out almost all the fields in the ReactOS-specific MM_IMAGE_SECTION, and replace them with the NT SECTION_IMAGE_INFORMATION structure instead. Make NtQuerySection simply return a copy of these fields (as on Windows).
[NTOSKRNL]: Update the PE loader code to now store information in SECTION_IMAGE_INFORMATION. Also store LoaderFlags and DllCharacteristics, which were not stored/returned to users before (in NtQuerySection).
[NTOSKRNL]: An entrypoint of NULL should also set ImageContainsCode to FALSE.
[NTOSKRNL]: Implement MmGetImageInformation, which is used by NtQueryInformationProcess(ProcessImageInformation). Also implement this latter info class.
[NTOSKRNL]: Delete ps_i.h, nobody uses this anymore.

svn path=/trunk/; revision=59859

8 years agoJust fix a typo.
Hermès Bélusca-Maïto [Wed, 28 Aug 2013 20:12:35 +0000 (20:12 +0000)]
Just fix a typo.

svn path=/trunk/; revision=59858

8 years ago[RTL]: Correctly read PEB or Kernel Variables for Heap Tuning.
Alex Ionescu [Wed, 28 Aug 2013 18:57:29 +0000 (18:57 +0000)]
[RTL]: Correctly read PEB or Kernel Variables for Heap Tuning.
[NTOSKRNL]: MmCreatePeb should correctly fill out the Heap PEB parameters.
[NTOSKRNL]: MmInitSystem and mminit.c should correctly initialize and hold the Heap Tuning Parameters.
[NTOSKRNL]: CmControlVector should read the registry Heap Tuning Parameters into the real Mm variables, instaed of "Dummy".
This removes heap hacks and makes Windows NTDLL happy.

svn path=/trunk/; revision=59857

8 years ago[KERNEL32]
Hermès Bélusca-Maïto [Wed, 28 Aug 2013 13:23:09 +0000 (13:23 +0000)]
[KERNEL32]
- Add brackets around "case XXX:" so that I'm able to (un)fold regions of code when debugging and reading.
- Temporarily skip AppCompat functionality added by Alex, in order to "fix" (read: hack-fix) launch of .bat/.cmd files. Indeed, when .bat/.cmd files get started with the CreateProcess function, a call to NtCreateSection fails with status STATUS_INVALID_IMAGE_NOT_MZ, as expected (line 2952). But the new AppCompat code (lines 3028 and 3031-3033 and following, and 3114), executed whenever the status code from NtCreateSection is STATUS_SUCCESS or STATUS_INVALID_IMAGE_NOT_MZ or something else, overwrites the status code by other values, so that, after we return to the main code path (lines 3174 and following), the status code isn't STATUS_INVALID_IMAGE_NOT_MZ anymore but STATUS_SUCCESS or whatever, and then, we fail to run the .bat/.cmd file (that should be done at lines 3314-3316 and following).
To Alex_Ionescu: Have a look at this and fix it properly!!

svn path=/trunk/; revision=59855

8 years ago[CMAKE]
Amine Khaldi [Wed, 28 Aug 2013 12:32:09 +0000 (12:32 +0000)]
[CMAKE]
* Add the proper subsystem version when using a recent MSVC toolchain.

svn path=/trunk/; revision=59854

8 years ago[CRT]
Amine Khaldi [Wed, 28 Aug 2013 11:52:25 +0000 (11:52 +0000)]
[CRT]
* Annotate timeb_s.h.

svn path=/trunk/; revision=59853

8 years ago[PSDK]
Amine Khaldi [Wed, 28 Aug 2013 11:25:44 +0000 (11:25 +0000)]
[PSDK]
* Annotate imm.h.

svn path=/trunk/; revision=59852

8 years ago[SVCHOST]
Amine Khaldi [Wed, 28 Aug 2013 11:08:28 +0000 (11:08 +0000)]
[SVCHOST]
* Fix a typo.

svn path=/trunk/; revision=59851

8 years ago[SVCHOST]
Hermès Bélusca-Maïto [Wed, 28 Aug 2013 10:19:54 +0000 (10:19 +0000)]
[SVCHOST]
Fix debug prints.

svn path=/trunk/; revision=59850

8 years ago[KERNEL32]
Hermès Bélusca-Maïto [Wed, 28 Aug 2013 10:08:41 +0000 (10:08 +0000)]
[KERNEL32]
Cut a very loong DPRINT1 into pieces, to workaround the length limitation of debug strings I get.

svn path=/trunk/; revision=59849

8 years ago[SVCHOST]: Use ReactOS Linux-build compatible cases in the header files, which are...
Alex Ionescu [Wed, 28 Aug 2013 08:34:41 +0000 (08:34 +0000)]
[SVCHOST]: Use ReactOS Linux-build compatible cases in the header files, which are incompatible with Windows, and don't even matter on Windows, but hey, <3 Reactos + Linux.

svn path=/trunk/; revision=59848

8 years ago[SVCHOST]: Implement a Windows-compatible (5.2 SP1) SvcHost.exe process, which can...
Alex Ionescu [Wed, 28 Aug 2013 08:32:27 +0000 (08:32 +0000)]
[SVCHOST]: Implement a Windows-compatible (5.2 SP1) SvcHost.exe process, which can load Windows services according to the information at geoffchappell.com/studies/windows/win32/services/svchost/index.htm, using the same callbacks and registry settings, including support for RPC over NPIPE, NetBIOS and COM, with correct handling of Security, Threading, Locking and Stop Callbacks. Tested with the current BITS and DHCP services, which still work (although they don't take advantage of the new functionality).

svn path=/trunk/; revision=59847

8 years agoIt wants an EOF?
Alex Ionescu [Wed, 28 Aug 2013 07:42:09 +0000 (07:42 +0000)]
It wants an EOF?

svn path=/trunk/; revision=59846

8 years ago[UUID]: Add IID_IGlobalOptions and CLSID_GlobalOptions.
Alex Ionescu [Wed, 28 Aug 2013 07:39:58 +0000 (07:39 +0000)]
[UUID]: Add IID_IGlobalOptions and CLSID_GlobalOptions.

svn path=/trunk/; revision=59845

8 years ago[IDL]: Sync Objidl with http://www.winehq.org/pipermail/wine-patches/2012-November...
Alex Ionescu [Wed, 28 Aug 2013 07:15:12 +0000 (07:15 +0000)]
[IDL]: Sync Objidl with winehq.org/pipermail/wine-patches/2012-November/120299.html, which adds IGlobalOptions.

svn path=/trunk/; revision=59844

8 years ago[ADVAPI32/SERVICES]: Windows services (as per MSDN and testing) must always get at...
Alex Ionescu [Wed, 28 Aug 2013 05:04:36 +0000 (05:04 +0000)]
[ADVAPI32/SERVICES]: Windows services (as per MSDN and testing) must always get at least one parameter -- the service name, in the argument vector. However, in ReactOS, unless optional custom parameters were sent (when starting a service), services got 0 parameters and a NULL argument vector. Since services on Windows know this is impossible, many dereference the vector without checking for NULL (including Windows Svchost.exe). Either way, it's bogus for us not ever sending the name as the first parameter. So I fixed ScBuildUnicodeArgsVector to always either pre-pend the service name (if the caller gave us some parameters already), or do use the name as the sole parameter (if the caller sent none). This now works as on Windows, and should greately help with 3rd party service compatibility.
***NOTE THAT I ONLY DID THIS FOR UNICODE. I DID NOT BOTHER TO FIX THE ANSI VERSION. ERIC KOHL, PLEASE REVIEW & FIX AS APPROPRIATE***

svn path=/trunk/; revision=59843

8 years ago[ADVAPI32]
Eric Kohl [Tue, 27 Aug 2013 20:58:29 +0000 (20:58 +0000)]
[ADVAPI32]
GetSidSubAuthority and GetSidSubAuthorityCount: Set last error code to ERROR_SUCCESS before calling the Rtl function.

svn path=/trunk/; revision=59842

8 years ago[COM_APITEST]
Amine Khaldi [Tue, 27 Aug 2013 19:16:41 +0000 (19:16 +0000)]
[COM_APITEST]
* Fix build.

svn path=/trunk/; revision=59841

8 years ago[PSDK]: Add a bunch of missing RTL_ macros.
Alex Ionescu [Tue, 27 Aug 2013 18:28:47 +0000 (18:28 +0000)]
[PSDK]: Add a bunch of missing RTL_ macros.

svn path=/trunk/; revision=59840