James Tabor [Tue, 5 Mar 2019 23:05:23 +0000 (17:05 -0600)]
[NtGDI] Fix crash and simplify code.
Revert previous changes. simplify rendering check.
Fix missed unlocking which caused a crash.
James Tabor [Tue, 5 Mar 2019 22:03:31 +0000 (16:03 -0600)]
Merge branch 'master' of https://github.com/reactos/reactos
James Tabor [Tue, 5 Mar 2019 22:03:15 +0000 (16:03 -0600)]
[NtGDI] Change TextOut
Separate TextOut for internal use.
Use flTextAlign internally.
Not sure why GetDeviceCap was used for determining rendering. SVN commit
logs are unavailable. Include code from wine that might make more sense.
Hermès Bélusca-Maïto [Tue, 5 Mar 2019 21:33:35 +0000 (22:33 +0100)]
[BOOTDATA] Comment out (but still keep it for documentation purposes only) the overridden default user shell, since we use by default the one specified in HKLM Winlogon key.
If people want to override it for a given user, or at a global level, they can do it later.
See CORE-15807
Timo Kreuzer [Sun, 6 Jan 2019 22:14:09 +0000 (23:14 +0100)]
[REACTOS] Fix 64 bit issues
Timo Kreuzer [Sat, 5 Jan 2019 11:06:17 +0000 (12:06 +0100)]
[LIBTIRPC] Silence MSVC warnings
Timo Kreuzer [Sun, 13 Jan 2019 14:29:13 +0000 (15:29 +0100)]
[GDI32] Add casts to silence warnings on x64
The cast is required, because FARPROC is only compatible with function pointer types that return INT_PTR and the ones used return int/BOOL.
Timo Kreuzer [Sun, 13 Jan 2019 14:09:57 +0000 (15:09 +0100)]
[GDI32] Fix bDDCreateSurface
Timo Kreuzer [Sun, 6 Jan 2019 22:41:52 +0000 (23:41 +0100)]
[DXG] Fix 64 bit build
Timo Kreuzer [Sun, 13 Jan 2019 14:56:23 +0000 (15:56 +0100)]
[VGA_NEW] Fix 64 bit issues
Timo Kreuzer [Sun, 13 Jan 2019 18:23:41 +0000 (19:23 +0100)]
[SACDRV] Fix CHECK_PARAMETER_WITH_STATUS error handling macro
Timo Kreuzer [Mon, 7 Jan 2019 01:59:24 +0000 (02:59 +0100)]
[CDROM_NEW] Fix SLIST_ENTRY vs SINGLE_LIST_ENTRY issues
Timo Kreuzer [Tue, 8 Jan 2019 04:17:19 +0000 (05:17 +0100)]
[CLASSPNP] Fix SLIST_ENTRY vs SINGLE_LIST_ENTRY issues
Timo Kreuzer [Sun, 13 Jan 2019 12:35:51 +0000 (13:35 +0100)]
[NTOS:EX] Fix 64 bit issues in ExfWaitForRundownProtectionReleaseCacheAware
Timo Kreuzer [Sun, 13 Jan 2019 12:42:23 +0000 (13:42 +0100)]
[PSDK] Improve definition of CBR_BLOCK
The cast doesn't exist in native headers, but this causes warnings.
Timo Kreuzer [Mon, 7 Jan 2019 01:21:10 +0000 (02:21 +0100)]
[PSDK] Fix PRINTDLG structure definition
Timo Kreuzer [Sun, 6 Jan 2019 16:31:43 +0000 (17:31 +0100)]
[MKISOFS] Silence MSVC warnings
Timo Kreuzer [Sat, 2 Feb 2019 10:46:19 +0000 (11:46 +0100)]
[WIDL] Fix non-x86 builds
James Tabor [Mon, 4 Mar 2019 18:17:00 +0000 (12:17 -0600)]
[NtGDI] Use flag for text align mode.
Use the lTextAlign instead of the user one for internal use.
Eric Kohl [Mon, 4 Mar 2019 16:25:11 +0000 (17:25 +0100)]
[MSV1_0] Check logon hours and workstation names on logon. Also return the machine name on logon and fix the LOGONSERVER environment variable.
Ged Murphy [Mon, 4 Mar 2019 11:02:38 +0000 (11:02 +0000)]
[SHELL32] Implement SHTestTokenMembership and forward IsUserAnAdmin to it
Moved to the bottom of the file with the other ros functions to help keep wine syncs easier.
Eric Kohl [Mon, 4 Mar 2019 09:20:10 +0000 (10:20 +0100)]
[MSV1_0] Export LsaApLogonUserEx2 instead of LsaApLogonUser and remove the outdated logon functions.
Eric Kohl [Mon, 4 Mar 2019 00:35:26 +0000 (01:35 +0100)]
[LSASRV] LsapLogonUser: Support LsaTokenInformationNull logins.
Eric Kohl [Mon, 4 Mar 2019 00:31:20 +0000 (01:31 +0100)]
[MSV1_0] LsaApLogonUser: Pass the Authenticating Authority to the caller.
Pierre Schweitzer [Sun, 3 Mar 2019 22:14:07 +0000 (23:14 +0100)]
[DCOMLAUNCH][WMISVC] Stop busy waiting shutdown
Colin Finck [Fri, 1 Mar 2019 16:49:03 +0000 (17:49 +0100)]
Fix the MSVC version of ldexp filling up the FPU stack and bailing out with #IND after a few calls. Additionally, add it back to libcntpr.
MSVC was previously given a "result" variable to copy the fscale result from st(0). This led to another "fld" FPU stack push at the very end without popping the source value from the FPU stack.
Moreover, this copy isn't even needed: A simple "fstp st(1)" at the end pops an element from the FPU stack while effectively storing the result in st(0), the register used for returning a double value.
This problem didn't affect GCC, as it is only given the "fscale" instruction and does all necessary stack operations itself.
However, looking into the CRT sources, I found many other i386 implementations with inline assembly suffering from the same problem.
Fortunately, they have been replaced by pure assembly implementations a while ago, so it's time to finally remove them.
ldexp would have also been a candidate for a pure assembly implementation, but the required check for NaN and setting errno (verified on Win2003) already outweighs the benefits.
And we cannot just do a NaN check with FUCOMI as this is an i686/pentiumpro instruction while we're still targeting i586/pentium.
I'm also using this opportunity to clean up the ldexp.c header and only put in the remaining contributors as returned by "git blame".
Thanks to NightWolve1975 for reporting the problem! (https://twitter.com/nightwolve1975/status/
1099042477531643912)
Pierre Schweitzer [Sun, 3 Mar 2019 13:21:46 +0000 (14:21 +0100)]
[DCOMLAUNCH] Add a DcomLaunch service stub
This stub is responsible for providing the UUID seed to the kernel.
For now, it generates a purely random seed - MAC address support
is to be added.
Because it's purely random seed and local the machine (not tied
to the MAC address) it's made so that ExUuidCreate keeps returning
RPC_NT_UUID_LOCAL_ONLY. It won't fix failing test for now.
Nota: this service shouldn't exist as it. It should be implemented
though rpcss DLL for both rpcss service (network service) and
dcomlaunch service (local system service).
Because rpcss is EXE based and wine-synced for now, I prefered
stubbing a new service. This will have to be changed at some point.
Joachim Henze [Sun, 3 Mar 2019 01:23:34 +0000 (02:23 +0100)]
[SHELL32] Update all languages RCs to fix possible text truncation CORE-15765
IDD_BROWSE_FOR_FOLDER displays text controlled by the calling applications in
IDC_BROWSE_FOR_FOLDER_TITLE. Its old height could lead to text truncation
for existing 3rd party apps.
The new height value for IDC_BROWSE_FOR_FOLDER_TITLE
was inspired by IDC with the same from dialog IDD_BROWSE_FOR_FOLDER_NEW.
I could change all languages to the same height,
as dimensions of the dialog and surrounding controls were same.
Joachim Henze [Sun, 3 Mar 2019 00:26:59 +0000 (01:26 +0100)]
[MSI] In dialogs show titlebar buttons CORE-15301
Import the Wine fix
https://source.winehq.org/git/wine.git/?a=commit;h=
84e6b331918d57f39e20a3063b67eb7fc0876288
Many thanks to the fixes author Fabian Maurer.
Joachim Henze [Sat, 2 Mar 2019 23:46:23 +0000 (00:46 +0100)]
[TASKMGR] Update german rc to avoid text truncation in status-bar CORE-15615
which became a necessity after the second field was reduced in width
by commit 0.4.12-dev-363-g
473e0bfc838ddb7f84ebeaafc86acf3873d99c10
Eric Kohl [Sat, 2 Mar 2019 19:52:52 +0000 (20:52 +0100)]
[SETUPAPI] Implement CM_Next_Range()
Bișoc George [Fri, 1 Mar 2019 19:24:18 +0000 (20:24 +0100)]
[COVERITY][SETUPAPI] Release the blocks of memory when done
pRange variable allocates blocks of memory from the heap by HeapAlloc() although this resource is never freed afterwards.
COVERITY CID
1427056
jimtabor [Sat, 2 Mar 2019 17:30:21 +0000 (11:30 -0600)]
Use GDI Batch for PatBlt
This should increase speed a bit. Makes a good argument to use
PolyPatBlt for more than one call.
PolyPatBlt is not fully tested yet.
Pierre Schweitzer [Sat, 2 Mar 2019 10:10:37 +0000 (11:10 +0100)]
[NTOSKRNL] Fix MSVC2010 build
Pierre Schweitzer [Sat, 2 Mar 2019 09:45:34 +0000 (10:45 +0100)]
[NTOSKRNL] Fix ClockDiff aka fix MSVC build
Pierre Schweitzer [Sat, 2 Mar 2019 09:29:26 +0000 (10:29 +0100)]
[NTOSKRNL] Add a test for ExUuidCreate
Eric Kohl [Fri, 1 Mar 2019 21:01:14 +0000 (22:01 +0100)]
[SNDVOL32] In record mode, rename the 'Mute' autocheckbox to 'Select', turn it into a checkbox and make it behave like a radiobutton.
Pierre Schweitzer [Wed, 27 Feb 2019 20:12:32 +0000 (21:12 +0100)]
[NTOSKRNL] Rewrite/fix our UUID generation implementation
So that it matches Windows behavior
Also implement ExUuidCreate that will generate UUID version 1
The implementation is based on the RFC 4122
Pierre Schweitzer [Wed, 27 Feb 2019 08:02:30 +0000 (09:02 +0100)]
[NTOSKRNL] Introduce the UUID_CACHED_VALUES_STRUCT structure
Source: https://blog.48bits.com/el-codigo-ntoskvinci/
Pierre Schweitzer [Wed, 27 Feb 2019 07:54:48 +0000 (08:54 +0100)]
[NTOSKRNL] UuidMutex -> ExpUuidLock
Bișoc George [Sun, 24 Feb 2019 15:40:02 +0000 (16:40 +0100)]
[OSK] Implement "Use Click Sound" feature
- Implement the save/load handler for this feature
- Check the "Use Click Sound" item state accordingly depending if it's enabled or disabled
- Use PlaySoundW() to play the wave sound file from resource
- Add the WAV sound click file. The work is made thanks to Midori Mizuno
Thomas Faber [Wed, 27 Feb 2019 14:02:38 +0000 (15:02 +0100)]
[HDAUDBUS] Wait until the correct number of responses was received. CORE-15465
We previously only gave the device a hard-coded amount of time to respond,
which could lead to interpreting the contents of uninitialized memory as
a response. This would lead to an unreasonably large number of audio function
groups being detected.
A KSEMAPHORE mirrors what Haiku uses here, though it may not be the optimal
synchronization primitive for this case under Windows.
Thomas Faber [Wed, 27 Feb 2019 13:34:23 +0000 (14:34 +0100)]
[HDAUDBUS] Handle responses in a DPC instead of the ISR.
Thomas Faber [Wed, 27 Feb 2019 14:02:23 +0000 (15:02 +0100)]
[HDAUDBUS] Fix a DPRINT.
Thomas Faber [Wed, 27 Feb 2019 09:51:02 +0000 (10:51 +0100)]
[HDAUDBUS] Prevent overflow of the AudioGroups array. CORE-14153 CORE-15465
This protects against crashing in case of faulty/malicious hardware,
but also works around a bug in HDA_SendVerbs that causes it to return
invalid data, thereby suggesting more groups than are actually present.
Bișoc George [Tue, 26 Feb 2019 14:49:47 +0000 (15:49 +0100)]
[SNDVOL32] Small Italian translation update
Thomas Faber [Sun, 24 Feb 2019 11:29:34 +0000 (12:29 +0100)]
[HDAUDBUS] Implement HDA_Unload. Stub HDA_Power and HDA_SystemControl.
Thomas Faber [Mon, 25 Feb 2019 00:56:25 +0000 (01:56 +0100)]
[HDAUDBUS] Correctly mask register values.
See https://github.com/haiku/haiku/blob/master/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp
and https://github.com/haiku/haiku/blob/master/src/add-ons/kernel/drivers/audio/hda/driver.h#L118-L140
This fixes various device reset failures and probably other issues.
Thomas Faber [Mon, 25 Feb 2019 12:47:14 +0000 (13:47 +0100)]
[HDAUDBUS] Implement PDO removal. CORE-14617
Thomas Faber [Sun, 24 Feb 2019 13:33:41 +0000 (14:33 +0100)]
[HDAUDBUS] Implement FDO removal. CORE-14617
Thomas Faber [Sun, 24 Feb 2019 11:23:45 +0000 (12:23 +0100)]
[HDAUDBUS] Use IoForwardIrpSynchronously instead of HDA_SyncForwardIrp.
Thomas Faber [Mon, 25 Feb 2019 11:48:54 +0000 (12:48 +0100)]
[HDAUDBUS] Forward FDO requests instead of completing them.
Thomas Faber [Sat, 23 Feb 2019 20:52:21 +0000 (21:52 +0100)]
[HDAUDBUS] Use a switch for minor function codes.
Thomas Faber [Sat, 23 Feb 2019 20:50:05 +0000 (21:50 +0100)]
[HDAUDBUS] Split FDO/PDO PNP handling into separate functions.
Thomas Faber [Sat, 23 Feb 2019 08:55:57 +0000 (09:55 +0100)]
[HDAUDBUS] Minor fixes:
* Add some forward-declarations
* Add some annotations
* Improve a DPRINT
Pierre Schweitzer [Mon, 25 Feb 2019 21:33:31 +0000 (22:33 +0100)]
[MSAFD] Don't leak event while querying/setting socket options
Pierre Schweitzer [Mon, 25 Feb 2019 21:30:01 +0000 (22:30 +0100)]
[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF
Pierre Schweitzer [Mon, 25 Feb 2019 21:28:18 +0000 (22:28 +0100)]
[AFD_APITEST] Add apitest for AFD window size options
Pierre Schweitzer [Mon, 25 Feb 2019 21:27:00 +0000 (22:27 +0100)]
[AFD] Don't allow caller to set broken values to window sizes
This will avoid 0-sized allocations, or -1-sized allocations.
So far, it's maxed by hard value stored in TCPIP.sys. I believe
this is not right and would deserve a true fix
Pierre Schweitzer [Mon, 25 Feb 2019 21:25:03 +0000 (22:25 +0100)]
[AFD] Add default window sizes on socket creation
Mark Jansen [Sat, 23 Feb 2019 15:24:21 +0000 (16:24 +0100)]
[XDK] Remove _M_AMD64 special case
Mark Jansen [Mon, 11 Feb 2019 21:45:48 +0000 (22:45 +0100)]
[APPHELP] Implement SdbRegisterDatabase[Ex]
CORE-11301
Mark Jansen [Mon, 11 Feb 2019 21:44:30 +0000 (22:44 +0100)]
[APPHELP][APPHELP_APITEST] Implement SdbGetDatabaseInformation
CORE-11301
Mark Jansen [Sun, 6 Jan 2019 16:51:55 +0000 (17:51 +0100)]
[APPHELP] Implement ShimDumpCache and ShimFlushCache
These functions simply call into the Base* functions,
having a prototype that is compatible with rundll32
CORE-11301
Mark Jansen [Thu, 3 Jan 2019 22:24:54 +0000 (23:24 +0100)]
[SDB] Initial SdbRegisterDatabase stubs
CORE-11301
Mark Jansen [Fri, 23 Jun 2017 19:47:36 +0000 (21:47 +0200)]
[APPHELP_APITEST] Add a test for shim database registration
CORE-11301
Stanislav Motylkov [Mon, 25 Feb 2019 10:41:41 +0000 (13:41 +0300)]
[MODULES][WALLPAPERS] Fix build (#1375)
Some file names still contained space instead of underline. Addendum to
0760802.
Luo Yufan [Sun, 24 Feb 2019 23:36:53 +0000 (07:36 +0800)]
[TRANSLATION] Update Chinese and Traditional Chinese translations. (#1369)
Pierre Schweitzer [Sun, 24 Feb 2019 20:25:39 +0000 (21:25 +0100)]
[MSAFD] Make WSPSetSockOpt() SO_RCVBUF stub return success
Timo Kreuzer [Sun, 24 Feb 2019 12:24:26 +0000 (13:24 +0100)]
[NTOS::Mm] Fix inverted check in MiWriteProtectSystemImage
Dylan Navas [Sun, 24 Feb 2019 17:08:26 +0000 (14:08 -0300)]
[MODULES] Fix CMakeLists.txt for wallpapers module. (#1294)
* Add all wallpapers to the ISO and can look how enable the module in ReadMe.txt
* Remove blanks in name.
* Moving to folder with same wallpaper style.
* Adding and updating CMakeLists.txt.
* Update ReadMe.txt.
Serge Gautherie [Sun, 24 Feb 2019 16:53:39 +0000 (17:53 +0100)]
[KMTEST] Fix 3 Clang-Cl warnings about Status and Callbacks (#502)
* 1 "warning: variable 'Status' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]"
* 2 "warning: comparison of unsigned expression < 0 is always false [-Wtautological-unsigned-zero-compare]"
* Use a consistent type for "i" and fix a comment
* Also update licence header.
CORE-14306
Eric Kohl [Sun, 24 Feb 2019 16:15:13 +0000 (17:15 +0100)]
[MMSYS] Volume page: Initialize the volume trackbar before it might be disabled because the tick marks must be visible on a disabled trackbar.
Eric Kohl [Sun, 24 Feb 2019 15:56:55 +0000 (16:56 +0100)]
[MMSYS] Sounds page: Update the 'Play' button and the current item in the 'Program events' treeview when a sound is selected or deselected.
Eric Kohl [Sun, 24 Feb 2019 15:12:55 +0000 (16:12 +0100)]
[SNDVOL32] Disable only the 'Play' button, when no audio device is avaiblable.
Stanislav Motylkov [Sat, 23 Feb 2019 21:44:12 +0000 (00:44 +0300)]
[MSGINA] Add bar bitmap to logon and shutdown dialogs
Stanislav Motylkov [Sat, 23 Feb 2019 20:52:22 +0000 (23:52 +0300)]
[MSGINA] Improve Ctrl-Alt-Del invitation window
Stanislav Motylkov [Sat, 23 Feb 2019 20:34:22 +0000 (23:34 +0300)]
[MSGINA] Implement rotation bar animation
Based on initial work by Bisoc George. Rotation bar image by Zcooger. CORE-15215
Eric Kohl [Sun, 24 Feb 2019 14:35:36 +0000 (15:35 +0100)]
[MMSYS] Disable the 'Low' and 'High' text of the volume trackbar and the 'Place volume icon in the taskbar' checkbox when no sound device is available.
Raul Tambre [Sun, 24 Feb 2019 09:37:42 +0000 (11:37 +0200)]
[WINLOGON] Fix fallback keyboard layout flags
Eric Kohl [Sun, 24 Feb 2019 11:50:37 +0000 (12:50 +0100)]
[SNDVOL32] Advanced Controls dialog: Implemented the Bass and Treble trackbars.
Please check if they are working correctly. I have no way to check them myself.
Eric Kohl [Sat, 23 Feb 2019 16:26:48 +0000 (17:26 +0100)]
[SNDVOL32] Remove trailing whitespace
Eric Kohl [Sat, 23 Feb 2019 16:21:25 +0000 (17:21 +0100)]
[SNDVOL32] Resize the dialog and groupbox when there are two 'Other Controls'
Pierre Schweitzer [Sat, 23 Feb 2019 12:34:28 +0000 (13:34 +0100)]
[WS2_32] Use SEH in WSCGetProviderPath()
Eric Kohl [Sat, 23 Feb 2019 11:51:14 +0000 (12:51 +0100)]
[SNDVOL32] Advanced Controls dialog: Initialize the Other Controls
Pierre Schweitzer [Sat, 23 Feb 2019 09:57:06 +0000 (10:57 +0100)]
[WS2_32] Implement WSCGetProviderPath()
Eric Kohl [Fri, 22 Feb 2019 22:33:47 +0000 (23:33 +0100)]
[SNDVOL32] Advanced controls dialog: Remove the TBS_AUTOTICKS style from the trackbars and initialize them properly.
Eric Kohl [Thu, 21 Feb 2019 21:26:58 +0000 (22:26 +0100)]
[SNDVOL32] Move the advanced controls dialog to a separate file and update its title on creation.
Serge Gautherie [Wed, 20 Feb 2019 21:16:16 +0000 (22:16 +0100)]
[NDK] Fix 'DeletedChidren' typo (#1367)
On behalf of Vadim Galyant.
CORE-15769
Pierre Schweitzer [Wed, 20 Feb 2019 20:01:46 +0000 (21:01 +0100)]
[VIDEOPRT] Don't return uninitialized memory
Mark Jansen [Tue, 19 Feb 2019 20:32:51 +0000 (23:32 +0300)]
[SNDVOL32] Fix parsing dialog icons
Stanislav Motylkov [Tue, 19 Feb 2019 13:51:39 +0000 (16:51 +0300)]
[SNDVOL32] Add left and right balance icons
Thomas Faber [Wed, 20 Feb 2019 11:21:03 +0000 (12:21 +0100)]
[NTOS:PNP] Correctly respect data size in PnpRegSzToString. CORE-15766
Spotted by Vadim Galyant.
Thomas Faber [Wed, 20 Feb 2019 11:03:03 +0000 (12:03 +0100)]
[NTDLL_APITEST] Show that registry strings can be longer than MAXUSHORT.
Stanislav Motylkov [Tue, 19 Feb 2019 12:54:38 +0000 (15:54 +0300)]
[SNDVOL32] Add Russian translation
Addendum to
fe5c50e and
e6be187.
Michael Fritscher [Fri, 1 Feb 2019 19:14:00 +0000 (22:14 +0300)]
[FREELDR] PXE: Fix network packet size
1024 bytes should fit into a single network packet. CORE-15706
Eric Kohl [Mon, 18 Feb 2019 23:01:18 +0000 (00:01 +0100)]
[SNDVOL32] Add the 'Advanced Controls for Volume Control' dialog. It does nothing useful yet.
Mark Jansen [Sun, 17 Feb 2019 19:46:47 +0000 (20:46 +0100)]
[MSI] Prevent uninitialized variable usage
Mark Jansen [Sun, 17 Feb 2019 19:46:24 +0000 (20:46 +0100)]
[MSI] Do not leak rootkey
Mark Jansen [Sat, 16 Feb 2019 17:35:08 +0000 (18:35 +0100)]
[SHELL32] Abort change notifications on a nullptr
CORE-15703