reactos.git
13 months ago[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525)
Timo Kreuzer [Mon, 15 Apr 2019 11:29:33 +0000 (13:29 +0200)]
[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525)

13 months ago[CONSRV] Cache the console window system menu handle; simplify its initialization...
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 19:47:55 +0000 (21:47 +0200)]
[CONSRV] Cache the console window system menu handle; simplify its initialization code.

13 months ago[REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)
Serge Gautherie [Sun, 28 Apr 2019 19:19:42 +0000 (21:19 +0200)]
[REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)

No functional change otherwise.

13 months ago[ACCESS] Reposition the "ToggleKeys" group box control (#1541)
Bișoc George [Sun, 28 Apr 2019 18:21:38 +0000 (20:21 +0200)]
[ACCESS] Reposition the "ToggleKeys" group box control (#1541)

CORE-15383

13 months ago[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. ... 1065/head
Andrew Boyarshin [Mon, 26 Nov 2018 12:49:15 +0000 (19:49 +0700)]
[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. (#1065)

- The 2nd parameter is already passed in user-mode by GetThreadDesktop().
  It is then used by NtUserGetThreadDesktop() as a fallback for console
  threads.

- Lookup and validate the thread by using the IntTID2PTI() helper.
- Don't reference the desktop with too many access rights.
- Get rid of the old-school DECLARE_RETURN() & co. macros.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
13 months ago[WIN32SS][NTGDI] Fix wrong IN/OUT (#1539)
Katayama Hirofumi MZ [Sun, 28 Apr 2019 15:24:57 +0000 (00:24 +0900)]
[WIN32SS][NTGDI] Fix wrong IN/OUT (#1539)

13 months ago[POWERCFG] Fix minor power scheme issues
Eric Kohl [Sun, 28 Apr 2019 11:18:12 +0000 (13:18 +0200)]
[POWERCFG] Fix minor power scheme issues

- Really fix the exception that occurs on closing the property sheet.
- Use the correct scheme ID when the current power scheme is set.

13 months ago[ROSAUTOTEST] "Enforce" ending '\n' on C___Exception messages (#1533)
Serge Gautherie [Sun, 28 Apr 2019 10:20:37 +0000 (12:20 +0200)]
[ROSAUTOTEST] "Enforce" ending '\n' on C___Exception messages (#1533)

13 months ago[FORMATTING] appveyor.yml: Remove an extra space (#1538)
Serge Gautherie [Sun, 28 Apr 2019 01:23:27 +0000 (03:23 +0200)]
[FORMATTING] appveyor.yml: Remove an extra space (#1538)

Addendum to 48f98e88.

13 months ago[WINSRV] Implement SrvGetThreadConsoleDesktop(). CORE-13470
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 00:40:20 +0000 (02:40 +0200)]
[WINSRV] Implement SrvGetThreadConsoleDesktop(). CORE-13470

It retrieves the handle to the desktop assigned to the specified
thread belonging to a console application, which is going to be
where the input thread of this console is.

13 months ago[COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension
Katayama Hirofumi MZ [Sat, 27 Apr 2019 23:43:24 +0000 (08:43 +0900)]
[COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension

13 months ago[NFS] Fix a typo in the precompiled header.
Hermès Bélusca-Maïto [Sat, 27 Apr 2019 23:40:09 +0000 (01:40 +0200)]
[NFS] Fix a typo in the precompiled header.

13 months ago[POWERCFG] Fix an exception that occurs when the control panel is closed.
Eric Kohl [Sat, 27 Apr 2019 17:00:33 +0000 (19:00 +0200)]
[POWERCFG] Fix an exception that occurs when the control panel is closed.

13 months ago[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee().... 803/head
Hermès Bélusca-Maïto [Thu, 23 Aug 2018 19:30:56 +0000 (21:30 +0200)]
[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee(). (#803)

This should remove some of the "SetThreadStackGuarantee(): stub" messages in some simple cases.

13 months ago[MODERN.MSSTYLES] Remove trailing whitespace. 1527/head
Hermès Bélusca-Maïto [Sat, 27 Apr 2019 15:01:47 +0000 (17:01 +0200)]
[MODERN.MSSTYLES] Remove trailing whitespace.

13 months ago[THEMES] Reorganize files for future compatability.
Jake Collins [Tue, 23 Apr 2019 20:46:42 +0000 (21:46 +0100)]
[THEMES] Reorganize files for future compatability.

Moved current theme assets into their own dedicated
files in preparation for .theme support.

CORE-15970

13 months ago[COMDLG32] Save open/save location by extension (#1514)
Katayama Hirofumi MZ [Sat, 27 Apr 2019 14:02:34 +0000 (23:02 +0900)]
[COMDLG32] Save open/save location by extension (#1514)

Use the proper open/save initial folder for comdlg32.GetOpenFileName and comdlg32.GetSaveFileName. CORE-7114

13 months ago[SDK][INCLUDE] Use FALSE for BOOL in msgdump.h
Katayama Hirofumi MZ [Sat, 27 Apr 2019 13:06:37 +0000 (22:06 +0900)]
[SDK][INCLUDE] Use FALSE for BOOL in msgdump.h

13 months ago[CMAKE] Fix LINK_DEPENDS usage
Timo Kreuzer [Sat, 27 Apr 2019 09:26:03 +0000 (11:26 +0200)]
[CMAKE] Fix LINK_DEPENDS usage

Up to CMake 3.3 LINK_DEPENDS was ignored in non-Makefile generators. See also http://www.cmake.org/pipermail/cmake/2010-May/037206.html. Since CMake 3.4 it is no longer ignored, but requires CMP0005 policy to be set to NEW and it requires a full path which was already correctly used on GCC, but not on MSVC builds.

13 months ago[CMAKE] Use new policies for CMP0005 and CMP0018 (#1481)
Andrew Cook [Sat, 27 Apr 2019 09:33:37 +0000 (19:33 +1000)]
[CMAKE] Use new policies for CMP0005 and CMP0018 (#1481)

* [CMAKE] Fix for CMP0018
The new behaviour lets us explicitly disabling position independent code, avoiding the need to change undocumented variables

* LINK_DEPENDS is semicolon separated

* [CMAKE] Fix for CMP0005
it seems impossible to have cmake correct escape PROXY_CLSID_IS so move it to the header

13 months ago[SDK][INCLUDE] small fix for msgdump.h
Katayama Hirofumi MZ [Sat, 27 Apr 2019 09:30:29 +0000 (18:30 +0900)]
[SDK][INCLUDE] small fix for msgdump.h

13 months ago[WIN32SS][NTGDI] Use UNICODE_NULL for consistency
Katayama Hirofumi MZ [Sat, 27 Apr 2019 07:17:37 +0000 (16:17 +0900)]
[WIN32SS][NTGDI] Use UNICODE_NULL for consistency

13 months ago[WIN32SS][NTGDI] FireFox checkmark fix CORE-15303 (#1535)
Katayama Hirofumi MZ [Sat, 27 Apr 2019 00:38:01 +0000 (09:38 +0900)]
[WIN32SS][NTGDI] FireFox checkmark fix CORE-15303 (#1535)

The font size was a bit larger than expected. FireFox will show checkmarks correctly in View menu. CORE-15303

13 months ago[POWERCFG] Show the name of the power scheme in the delete confirmation message box
Eric Kohl [Fri, 26 Apr 2019 21:12:36 +0000 (23:12 +0200)]
[POWERCFG] Show the name of the power scheme in the delete confirmation message box

13 months ago[POWERCFG] Some small cleanup
Eric Kohl [Fri, 26 Apr 2019 19:51:48 +0000 (21:51 +0200)]
[POWERCFG] Some small cleanup

- Rename IDC_HYBERNATE... to IDC_HIBERNATE...
- Rename IDS_PORCENT to IDS_PERCENT
- Replace %1 by %s in IDS_CONFIG1 and IDS_CONFIG2

13 months ago[WIN32SS][NTGDI] Keep FontSubstitutes enumeration CORE-15785 (#1532)
Katayama Hirofumi MZ [Fri, 26 Apr 2019 12:56:36 +0000 (21:56 +0900)]
[WIN32SS][NTGDI] Keep FontSubstitutes enumeration CORE-15785 (#1532)

Fix CORE-15785. When LOGFONT.lfFaceName[0] == 0, then enumeration of font substitutes had failed. CORE-15785

13 months ago[ROSAUTOTEST] A timeout of 120 seconds kills the msi:action test prematurely, so...
Colin Finck [Fri, 26 Apr 2019 08:30:24 +0000 (10:30 +0200)]
[ROSAUTOTEST] A timeout of 120 seconds kills the msi:action test prematurely, so increase it to 170 seconds.

This is still below the 180 seconds before sysreg2 kills the entire VM.
I've added a comment to clarify that.

13 months ago[PSDK] Improve lmrepl.h
Timo Kreuzer [Sun, 21 Apr 2019 10:59:23 +0000 (12:59 +0200)]
[PSDK] Improve lmrepl.h

Added public domain header. This file was originally imported in r8283 from w32api where is has no copyright.

13 months ago[REGTEST] Add regtest.cmd to the Run key inside regtest.cmd, so we're also started...
Colin Finck [Wed, 24 Apr 2019 08:48:15 +0000 (10:48 +0200)]
[REGTEST] Add regtest.cmd to the Run key inside regtest.cmd, so we're also started on the next reboot in case ReactOS crashed *and* the registry has been saved.

unattend.inf only allows to add RunOnce entries, which are in theory only executed on the first boot after installation.
For almost a decade, this worked anyway to start regtest.cmd again after a ReactOS crash, because the registry and thus the deletion of the RunOnce entry wasn't stored on disk in case of a crash.
Thanks to Sylvain for the hint!

As Explorer processes the Run key right after RunOnce and therefore picks up regtest.cmd a second time during the first boot, exit the script just after adding the Run key.
Otherwise, rosautotest.exe would be started twice, with catastrophic results.

13 months ago[ROSAUTOTEST] Cache the result of GetLastError().
Colin Finck [Tue, 23 Apr 2019 09:37:58 +0000 (11:37 +0200)]
[ROSAUTOTEST] Cache the result of GetLastError().

13 months ago[ROSAUTOTEST] Implement a process activity timeout of 2 minutes. If there is no log...
Colin Finck [Tue, 23 Apr 2019 07:17:05 +0000 (09:17 +0200)]
[ROSAUTOTEST] Implement a process activity timeout of 2 minutes. If there is no log output within 2 minutes, the test process is killed, and we continue with the next test.

This is a rather graceful approach compared to sysreg2's 3 minute timeout before killing and restarting the entire VM.
Since we added autochk for FAT filesystems, the filesystem is often "fixed" after a reset with the consequence that ReactOS doesn't boot up anymore.
The sysreg2 restart code still remains for handling tests causing BSODs.

13 months ago[POWERCFG] Fix the initialization of the power schemes page
Eric Kohl [Thu, 25 Apr 2019 22:03:27 +0000 (00:03 +0200)]
[POWERCFG] Fix the initialization of the power schemes page

CORE-4995

13 months ago[DPNHPAST] Import dpnhpast.dll from Wine (Staging) 4.5
Oleg Dubinskiy [Sun, 14 Apr 2019 18:00:12 +0000 (21:00 +0300)]
[DPNHPAST] Import dpnhpast.dll from Wine (Staging) 4.5

13 months ago[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522) 1522/head
Jared Smudde [Tue, 23 Apr 2019 05:47:02 +0000 (00:47 -0500)]
[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522)

CORE-13516, CORE-13518

13 months ago[MPR] Implement the function WNetDisconnectDialog(). (#1522)
Jared Smudde [Tue, 23 Apr 2019 05:46:28 +0000 (00:46 -0500)]
[MPR] Implement the function WNetDisconnectDialog(). (#1522)

CORE-13516, CORE-13518

13 months ago[NETPLWIZ] Implement the Disconnect Network Drive dialog. (#1522)
Jared Smudde [Tue, 23 Apr 2019 05:45:49 +0000 (00:45 -0500)]
[NETPLWIZ] Implement the Disconnect Network Drive dialog. (#1522)

CORE-13516, CORE-13518

13 months ago[APPWIZ.CPL] Set a default shortcut-link description (#1520)
Katayama Hirofumi MZ [Wed, 24 Apr 2019 01:44:44 +0000 (10:44 +0900)]
[APPWIZ.CPL] Set a default shortcut-link description (#1520)

CORE-15511

13 months ago[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler...
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:41:41 +0000 (03:41 +0200)]
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry.

13 months ago[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure...
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:36:27 +0000 (03:36 +0200)]
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem().

13 months ago[SHELL32] Implement 'New Link' (Retrial of #1510), CORE-15511 (#1518) 1518/head
Katayama Hirofumi MZ [Tue, 23 Apr 2019 01:48:34 +0000 (10:48 +0900)]
[SHELL32] Implement 'New Link' (Retrial of #1510), CORE-15511 (#1518)

Correctly create cache about ".lnk" and handling in the member functions.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
13 months ago[MSPAINT] Set default extension .bmp (#1515)
Katayama Hirofumi MZ [Tue, 23 Apr 2019 05:25:18 +0000 (14:25 +0900)]
[MSPAINT] Set default extension .bmp (#1515)

Set the default extension of mspaint to .bmp. CORE-7114

13 months ago[STOBJECT] Store the "Show x icon in the taskbar" setting for the hotplug, power...
Eric Kohl [Mon, 22 Apr 2019 22:12:23 +0000 (00:12 +0200)]
[STOBJECT] Store the "Show x icon in the taskbar" setting for the hotplug, power and volume icons.

CORE-12365
CORE-12972
CORE-15234

13 months ago[POWERCFG] Fix indentation and coding style. No code changes!
Eric Kohl [Mon, 22 Apr 2019 22:09:10 +0000 (00:09 +0200)]
[POWERCFG] Fix indentation and coding style. No code changes!

13 months ago[STOBJECT][MMSYS][POWERCFG] Store the "Show x icon in the taskbar" setting for the...
Eric Kohl [Mon, 22 Apr 2019 22:04:01 +0000 (00:04 +0200)]
[STOBJECT][MMSYS][POWERCFG] Store the "Show x icon in the taskbar" setting for the hotplug, power and volume icons.

CORE-12365
CORE-12972
CORE-15234

13 months ago[EXPLORER] Minor cleanup/comment fixes.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 19:25:41 +0000 (21:25 +0200)]
[EXPLORER] Minor cleanup/comment fixes.

13 months ago[NTOS:CM] In CmpParseKey(), do not assert but instead correctly return failure if...
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 19:09:10 +0000 (21:09 +0200)]
[NTOS:CM] In CmpParseKey(), do not assert but instead correctly return failure if CmpHandleExitNode() doesn't return a valid node, or CmpCreateKeyControlBlock() fails.

13 months ago[NTOS] Fix typos.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 17:41:19 +0000 (19:41 +0200)]
[NTOS] Fix typos.

13 months ago[FREELDR] Add some missing UiDrawBackdrop() calls.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 17:33:20 +0000 (19:33 +0200)]
[FREELDR] Add some missing UiDrawBackdrop() calls.

13 months ago[OPENGL32] Fix the order of the specified callbacks for the DrvSetCallbackProcs(... 1499/head
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 16:29:43 +0000 (18:29 +0200)]
[OPENGL32] Fix the order of the specified callbacks for the DrvSetCallbackProcs() call.

References:
- https://github.com/OpenSWR/openswr/blob/master/ogldriver/wgl.cpp
- https://github.com/Igalia/mesa/blob/master/src/gallium/state_trackers/wgl/stw_icd.h
- "OpenGL Installable Client Driver, Version 1.101 -- Reference Guide" by Microsoft Corporation.

13 months ago[OPENGL32] Fix usage of TEB members.
Bernhard Feichtinger [Sat, 13 Apr 2019 21:24:21 +0000 (23:24 +0200)]
[OPENGL32] Fix usage of TEB members.

13 months ago[NTOS][USERSRV] Silence noisy debug output.
Bernhard Feichtinger [Sat, 13 Apr 2019 21:33:09 +0000 (23:33 +0200)]
[NTOS][USERSRV] Silence noisy debug output.

13 months ago[SYSSETUP] Fix a broken DPRINT
Mark Jansen [Mon, 22 Apr 2019 14:24:59 +0000 (16:24 +0200)]
[SYSSETUP] Fix a broken DPRINT
Thanks to Thomas for spotting it.

13 months ago[STOBJECT] Mark hotplug, power and volume context menu default items
Eric Kohl [Mon, 22 Apr 2019 08:36:17 +0000 (10:36 +0200)]
[STOBJECT] Mark hotplug, power and volume context menu default items

13 months ago[GDI32_APITEST] Fix build s/IGNORE/NO_CHECK/
Katayama Hirofumi MZ [Mon, 22 Apr 2019 05:20:42 +0000 (14:20 +0900)]
[GDI32_APITEST] Fix build s/IGNORE/NO_CHECK/

13 months ago[GDI32_APITEST] Rewrite DPtoLP testcase (#1509)
Katayama Hirofumi MZ [Mon, 22 Apr 2019 04:48:57 +0000 (13:48 +0900)]
[GDI32_APITEST] Rewrite DPtoLP testcase (#1509)

Sorry, I had to rewrite gdi32!DPtoLP testcase. ROSTESTS-319

13 months ago[GDI32_APITEST] Rewrite LPtoDP testcase (#1508)
Katayama Hirofumi MZ [Mon, 22 Apr 2019 04:48:14 +0000 (13:48 +0900)]
[GDI32_APITEST] Rewrite LPtoDP testcase (#1508)

Sorry, I had to rewrite gdi32!LPtoDP testcase. ROSTESTS-319

13 months ago[POWRPROF] EnumPwrSchemes: Fix callback string lengths
Eric Kohl [Sun, 21 Apr 2019 22:41:24 +0000 (00:41 +0200)]
[POWRPROF] EnumPwrSchemes: Fix callback string lengths

The callback routine should get the real lengths of the name and description strings in bytes instead of the buffer sizes in characters. This fixes buffer overflows in powercfg.cpl.

13 months ago[ACGENRAL] Fix MSVC warning C4090 "different 'const' qualifiers" about a ShimLib_Shim...
Serge Gautherie [Sun, 21 Apr 2019 19:15:11 +0000 (21:15 +0200)]
[ACGENRAL] Fix MSVC warning C4090 "different 'const' qualifiers" about a ShimLib_ShimFree() call (#1506)

Addendum to 007cc5cd.
CORE-7538

13 months ago[BOOTDATA] Add registry keys for ComDlg32 (#1511)
Katayama Hirofumi MZ [Sun, 21 Apr 2019 14:47:10 +0000 (23:47 +0900)]
[BOOTDATA] Add registry keys for ComDlg32 (#1511)

Add registry keys for ComDlg32. CORE-7114

13 months ago[NTOSKRNL] Revert f71588ff as it seems to break the tests
Eric Kohl [Sat, 20 Apr 2019 21:26:57 +0000 (23:26 +0200)]
[NTOSKRNL] Revert f71588ff as it seems to break the tests

13 months ago[POWERCFG] Use a list of power schemes (power policy, id, name and description) rathe...
Eric Kohl [Sat, 20 Apr 2019 20:48:38 +0000 (22:48 +0200)]
[POWERCFG] Use a list of power schemes (power policy, id, name and description) rather than a bare array of power policies. This will simplify adding and deleting schemes quite a lot.

13 months ago[POWERCFG] Fix the undue change of monitor switch off time
Eric Kohl [Sat, 20 Apr 2019 12:43:16 +0000 (14:43 +0200)]
[POWERCFG] Fix the undue change of monitor switch off time

CORE-12495

13 months ago[POWERCFG] Fix coding style and indentation. No code changes!
Eric Kohl [Sat, 20 Apr 2019 12:36:22 +0000 (14:36 +0200)]
[POWERCFG] Fix coding style and indentation. No code changes!

13 months ago[NTOSKRNL] Drop the useless Timestamp field
Pierre Schweitzer [Sat, 20 Apr 2019 09:31:59 +0000 (11:31 +0200)]
[NTOSKRNL] Drop the useless Timestamp field

13 months ago[GDI32] Reduce verbosity on debug builds
Pierre Schweitzer [Sat, 20 Apr 2019 09:24:54 +0000 (11:24 +0200)]
[GDI32] Reduce verbosity on debug builds

13 months ago[NTOSKRNL] Don't set VACB dirty on release if already dirty
Pierre Schweitzer [Sat, 20 Apr 2019 09:23:35 +0000 (11:23 +0200)]
[NTOSKRNL] Don't set VACB dirty on release if already dirty

CORE-15954

13 months ago[ATL][ATLTEST] Adapt to RATL and improvements (#1501)
Katayama Hirofumi MZ [Fri, 19 Apr 2019 23:35:39 +0000 (08:35 +0900)]
[ATL][ATLTEST] Adapt to RATL and improvements (#1501)

- Modify atldef.h for non-ReactOS environments.
- Update ATL testcase project files (from v120_xp to v140_xp).
- #define HAVE_APITEST and use it.
- s/NULL/0/

13 months ago[HIDCLASS] Implement IOCTL_HID_GET_FEATURE/IOCTL_HID_SET_FEATURE
Hervé Poussineau [Fri, 19 Apr 2019 20:40:32 +0000 (22:40 +0200)]
[HIDCLASS] Implement IOCTL_HID_GET_FEATURE/IOCTL_HID_SET_FEATURE

13 months ago[KERNEL32] GetSystemPowerStatus(): Set the BATTERY_FLAG_CRITICAL flag if the battery...
Eric Kohl [Fri, 19 Apr 2019 20:30:46 +0000 (22:30 +0200)]
[KERNEL32] GetSystemPowerStatus(): Set the BATTERY_FLAG_CRITICAL flag if the battery life gets lower than 5 percent.

13 months ago[KERNEL32] GetSystemPowerStatus(): Fix coding style. No code changes!
Eric Kohl [Fri, 19 Apr 2019 20:28:11 +0000 (22:28 +0200)]
[KERNEL32] GetSystemPowerStatus(): Fix coding style. No code changes!

13 months ago[STOBJECT] Improvements to the power notification icon
Eric Kohl [Fri, 19 Apr 2019 19:50:13 +0000 (21:50 +0200)]
[STOBJECT] Improvements to the power notification icon

- Use GetSystemPowerStatus() instead of querying each battery.
- Add an ugly AC power icon. Should be fixed or replaced.
- Display AC power, battery charging, battery depleting and error cases. The AC power case was missing.
- Update some strings because we are no longer using float for the charge percentage.

@Turkish translators: Please check and update the translation of IDS_PWR_CHARGING!

13 months ago[DBGHELP] SymFromAddr: Handle 2 or more symbols at the same address correct. 1055/head
Andreas Maier [Thu, 22 Nov 2018 21:15:55 +0000 (22:15 +0100)]
[DBGHELP] SymFromAddr: Handle 2 or more symbols at the same address correct.

There could be more then 2 symbols at the same addr.
Adjust function to handle that case correct.

13 months ago[DBGHELP] Set LastError for SymGetModuleBase-calls to ERROR_MOD_NOT_FOUND.
Andreas Maier [Thu, 22 Nov 2018 21:14:24 +0000 (22:14 +0100)]
[DBGHELP] Set LastError for SymGetModuleBase-calls to ERROR_MOD_NOT_FOUND.

Correct last error in module_find_by_addr.

13 months ago[DBGHELP] set correct values in symt_fill_sym_info (SYMBOL_INFO).
Andreas Maier [Thu, 22 Nov 2018 20:47:45 +0000 (21:47 +0100)]
[DBGHELP] set correct values in symt_fill_sym_info (SYMBOL_INFO).

* symtype: set to SymPdb not SymCv (may be for old pdb-files pre VS 6.0)
* flags: return SYMFLAG_PUBLIC_CODE for SymTagPublicSymbol if its a function.
* flags: do not return SYMFLAG_FUNCTION for SymTagFuncion.

13 months ago[DBGHELP] Add SYMFLAG_- and SYMTYPE_-defines.
Andreas Maier [Thu, 22 Nov 2018 20:34:14 +0000 (21:34 +0100)]
[DBGHELP] Add SYMFLAG_- and SYMTYPE_-defines.

13 months ago[DBGHELP] use correct record in codeview_snarf_public.
Andreas Maier [Thu, 22 Nov 2018 20:27:48 +0000 (21:27 +0100)]
[DBGHELP] use correct record in codeview_snarf_public.

Use public_vx iststead of data_vx for public symbols.

13 months ago[DBGHELP] search for debugfiles in modulepath too.
Andreas Maier [Sat, 3 Nov 2018 20:26:48 +0000 (21:26 +0100)]
[DBGHELP] search for debugfiles in modulepath too.

Debug symbols (like PDB, ...) could not be found if the direcory of
the module and application differs. Applying this patch they will
be found.
Dbghelp searches the module path too. (See MS docs).

13 months ago[CMAKE] msvc.cmake: Remove now redundant '/we4028' special case
Serge Gautherie [Fri, 19 Apr 2019 13:39:16 +0000 (15:39 +0200)]
[CMAKE] msvc.cmake: Remove now redundant '/we4028' special case

Addendum to 545a2c79367e1457e4bc7ac14d3c0f840c7e063c.

CORE-7538

13 months ago[APPVEYOR] Enable fast_finish (#1494)
Katayama Hirofumi MZ [Fri, 19 Apr 2019 14:39:18 +0000 (23:39 +0900)]
[APPVEYOR] Enable fast_finish (#1494)

It stops the remaining jobs if any error happened. It becomes less time for waiting for building.

13 months ago[BOOTDATA] AHKAppTests.cmd: Fix 'media' typo (#1502)
Serge Gautherie [Fri, 19 Apr 2019 13:12:16 +0000 (15:12 +0200)]
[BOOTDATA] AHKAppTests.cmd: Fix 'media' typo (#1502)

Addendum to df2a8c4. s/media/medium/

13 months ago[NTOBJSHEX] Reorder include files in the precompiled header 1474/head
Mark Jansen [Thu, 18 Apr 2019 19:17:00 +0000 (21:17 +0200)]
[NTOBJSHEX] Reorder include files in the precompiled header

13 months ago[APPHELP] Fix warnings
Mark Jansen [Thu, 18 Apr 2019 17:21:25 +0000 (19:21 +0200)]
[APPHELP] Fix warnings

13 months ago[RSHELL] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Thu, 18 Apr 2019 17:21:00 +0000 (19:21 +0200)]
[RSHELL] Disable exceptions in atl when compiling without exceptions

13 months ago[SHELL32_APITEST] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 21:04:07 +0000 (23:04 +0200)]
[SHELL32_APITEST] Disable exceptions in atl when compiling without exceptions

13 months ago[MSGINA_APITEST] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 21:03:42 +0000 (23:03 +0200)]
[MSGINA_APITEST] Disable exceptions in atl when compiling without exceptions

13 months ago[NETREG] Use exceptions with stl
Mark Jansen [Tue, 16 Apr 2019 21:03:22 +0000 (23:03 +0200)]
[NETREG] Use exceptions with stl

13 months ago[MSGINA] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 20:53:56 +0000 (22:53 +0200)]
[MSGINA] Disable exceptions in atl when compiling without exceptions

13 months ago[NTOBJSHEX] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 20:51:34 +0000 (22:51 +0200)]
[NTOBJSHEX] Disable exceptions in atl when compiling without exceptions

13 months ago[APPHELP_APITEST] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 20:49:55 +0000 (22:49 +0200)]
[APPHELP_APITEST] Disable exceptions in atl when compiling without exceptions

13 months ago[SHELL32] Use the same definitions for shell32 and it's static libs
Mark Jansen [Tue, 16 Apr 2019 20:39:36 +0000 (22:39 +0200)]
[SHELL32] Use the same definitions for shell32 and it's static libs

13 months ago[ATL] Retire atlnew
Mark Jansen [Sat, 6 Apr 2019 20:37:13 +0000 (22:37 +0200)]
[ATL] Retire atlnew

13 months ago[ATL][ATL_APITEST] Add test + implementation for CAtlFileMapping
Mark Jansen [Fri, 5 Apr 2019 21:22:55 +0000 (23:22 +0200)]
[ATL][ATL_APITEST] Add test + implementation for CAtlFileMapping

13 months ago[NTOSKRNL] Drop the no longer needed Dirty field
Pierre Schweitzer [Thu, 18 Apr 2019 06:14:41 +0000 (08:14 +0200)]
[NTOSKRNL] Drop the no longer needed Dirty field

CORE-15954

13 months ago[NTOSKRNL] Don't mark VACB dirty on unpin
Pierre Schweitzer [Wed, 17 Apr 2019 20:23:57 +0000 (22:23 +0200)]
[NTOSKRNL] Don't mark VACB dirty on unpin

This could happen if BCB was marked dirty previously.
Marking VACB dirty on unpin could lead to a double write of
the VACB, even if clean.
Indeed, now that setting BCB dirty leads to marking VACB
dirty, the VACB can be flushed in between by the lazy-writer.
The BCB state is not reset on VACB flush, contrary to the VACB state.
Thus, on unpin even if the VACB was already flushed, we were
setting back the dirty state, leading the VACB to be flushed again.

This could bring a small performance downgrade. Though it remains
limited since this is mostly used for FS metadata.
Possibly it could lead to metadata corruption, but this is likely
less possible.

CORE-15954

13 months ago[NtGDI] Update Region code
jimtabor [Wed, 17 Apr 2019 19:43:24 +0000 (14:43 -0500)]
[NtGDI] Update Region code

Wine Sync/Port and update for Regions. See CORE-15906.

13 months ago[GDI] Fixup attribute support for Regions
jimtabor [Wed, 17 Apr 2019 19:09:58 +0000 (14:09 -0500)]
[GDI] Fixup attribute support for Regions

Start to fix CORE-13817 when GDI batch is turn on for SelectClipRgn.

13 months ago[NTOSKRNL] NtPowerInformation: Report an AC powered machine by default.
Eric Kohl [Tue, 16 Apr 2019 18:14:36 +0000 (20:14 +0200)]
[NTOSKRNL] NtPowerInformation: Report an AC powered machine by default.

13 months ago[KMTESTS:CC] Add tests for CcCopyWrite
Pierre Schweitzer [Tue, 16 Apr 2019 06:25:09 +0000 (08:25 +0200)]
[KMTESTS:CC] Add tests for CcCopyWrite

CORE-15384

13 months ago[KERNEL32] Implement InvalidateNLSCache
Katayama Hirofumi MZ [Tue, 16 Apr 2019 12:41:58 +0000 (21:41 +0900)]
[KERNEL32] Implement InvalidateNLSCache

13 months ago[KERNEL32] Fix handle leak and caching (follow-up of 7e38267)
Katayama Hirofumi MZ [Tue, 16 Apr 2019 11:57:02 +0000 (20:57 +0900)]
[KERNEL32] Fix handle leak and caching (follow-up of 7e38267)