Stanislav Motylkov [Sat, 23 Feb 2019 20:34:22 +0000 (23:34 +0300)]
[MSGINA] Implement rotation bar animation
Based on initial work by Bisoc George. Rotation bar image by Zcooger. CORE-15215
Eric Kohl [Sun, 24 Feb 2019 14:35:36 +0000 (15:35 +0100)]
[MMSYS] Disable the 'Low' and 'High' text of the volume trackbar and the 'Place volume icon in the taskbar' checkbox when no sound device is available.
Raul Tambre [Sun, 24 Feb 2019 09:37:42 +0000 (11:37 +0200)]
[WINLOGON] Fix fallback keyboard layout flags
Eric Kohl [Sun, 24 Feb 2019 11:50:37 +0000 (12:50 +0100)]
[SNDVOL32] Advanced Controls dialog: Implemented the Bass and Treble trackbars.
Please check if they are working correctly. I have no way to check them myself.
Eric Kohl [Sat, 23 Feb 2019 16:26:48 +0000 (17:26 +0100)]
[SNDVOL32] Remove trailing whitespace
Eric Kohl [Sat, 23 Feb 2019 16:21:25 +0000 (17:21 +0100)]
[SNDVOL32] Resize the dialog and groupbox when there are two 'Other Controls'
Pierre Schweitzer [Sat, 23 Feb 2019 12:34:28 +0000 (13:34 +0100)]
[WS2_32] Use SEH in WSCGetProviderPath()
Eric Kohl [Sat, 23 Feb 2019 11:51:14 +0000 (12:51 +0100)]
[SNDVOL32] Advanced Controls dialog: Initialize the Other Controls
Pierre Schweitzer [Sat, 23 Feb 2019 09:57:06 +0000 (10:57 +0100)]
[WS2_32] Implement WSCGetProviderPath()
Eric Kohl [Fri, 22 Feb 2019 22:33:47 +0000 (23:33 +0100)]
[SNDVOL32] Advanced controls dialog: Remove the TBS_AUTOTICKS style from the trackbars and initialize them properly.
Eric Kohl [Thu, 21 Feb 2019 21:26:58 +0000 (22:26 +0100)]
[SNDVOL32] Move the advanced controls dialog to a separate file and update its title on creation.
Serge Gautherie [Wed, 20 Feb 2019 21:16:16 +0000 (22:16 +0100)]
[NDK] Fix 'DeletedChidren' typo (#1367)
On behalf of Vadim Galyant.
CORE-15769
Pierre Schweitzer [Wed, 20 Feb 2019 20:01:46 +0000 (21:01 +0100)]
[VIDEOPRT] Don't return uninitialized memory
Mark Jansen [Tue, 19 Feb 2019 20:32:51 +0000 (23:32 +0300)]
[SNDVOL32] Fix parsing dialog icons
Stanislav Motylkov [Tue, 19 Feb 2019 13:51:39 +0000 (16:51 +0300)]
[SNDVOL32] Add left and right balance icons
Thomas Faber [Wed, 20 Feb 2019 11:21:03 +0000 (12:21 +0100)]
[NTOS:PNP] Correctly respect data size in PnpRegSzToString. CORE-15766
Spotted by Vadim Galyant.
Thomas Faber [Wed, 20 Feb 2019 11:03:03 +0000 (12:03 +0100)]
[NTDLL_APITEST] Show that registry strings can be longer than MAXUSHORT.
Stanislav Motylkov [Tue, 19 Feb 2019 12:54:38 +0000 (15:54 +0300)]
[SNDVOL32] Add Russian translation
Addendum to
fe5c50e and
e6be187.
Michael Fritscher [Fri, 1 Feb 2019 19:14:00 +0000 (22:14 +0300)]
[FREELDR] PXE: Fix network packet size
1024 bytes should fit into a single network packet. CORE-15706
Eric Kohl [Mon, 18 Feb 2019 23:01:18 +0000 (00:01 +0100)]
[SNDVOL32] Add the 'Advanced Controls for Volume Control' dialog. It does nothing useful yet.
Mark Jansen [Sun, 17 Feb 2019 19:46:47 +0000 (20:46 +0100)]
[MSI] Prevent uninitialized variable usage
Mark Jansen [Sun, 17 Feb 2019 19:46:24 +0000 (20:46 +0100)]
[MSI] Do not leak rootkey
Mark Jansen [Sat, 16 Feb 2019 17:35:08 +0000 (18:35 +0100)]
[SHELL32] Abort change notifications on a nullptr
CORE-15703
Eric Kohl [Sun, 17 Feb 2019 23:58:28 +0000 (00:58 +0100)]
[SNDVOL32] Implement the dialog resize code for the 'Advanced Controls' menu item and prepare for clicks on the 'Advanced' button.
Eric Kohl [Sun, 17 Feb 2019 13:04:39 +0000 (14:04 +0100)]
[SNDVOL32] Fix the window height issue when the line selection changes and implement the 'Advanced Controls' menu item.
CORE-9108 CORE-15751
Thomas Faber [Sun, 17 Feb 2019 08:58:28 +0000 (09:58 +0100)]
[RTL] Fix GCC build.
Thomas Faber [Fri, 15 Feb 2019 18:43:25 +0000 (19:43 +0100)]
[ACPI] Update ACPICA library to version
20190215.
Thomas Faber [Sun, 3 Feb 2019 15:55:04 +0000 (16:55 +0100)]
[COMCTL32] Check for NULL pointer when handling BCM_GETIDEALSIZE.
Fixes crash in comctl32_winetest:button.
Thomas Faber [Sun, 3 Feb 2019 15:41:29 +0000 (16:41 +0100)]
[COMCTL32] Add NULL checks to SetWindowSubclass.
Imports Wine commit
04847e68f87 by Sven Baars.
Fixes crash in comctl32_winetest:subclass.
Thomas Faber [Sun, 3 Feb 2019 12:57:21 +0000 (13:57 +0100)]
[RTL] Protect pointer validity check in RtlFreeHeap with SEH.
Fixes crash in kernel32_winetest:heap.
Hermès Bélusca-Maïto [Sun, 17 Feb 2019 00:10:27 +0000 (01:10 +0100)]
[CMLIB] Assign a signature to the in-memory HHIVE registry hive structure. CORE-15753
Makes the `!reg hivelist` WinDbg command working in ReactOS.
Dedicated to Mark Jansen.
See for more details:
https://webcache.googleusercontent.com/search?q=cache:fmHJX9eFGkkJ:https://blogs.technet.microsoft.com/ganand/archive/2008/01/05/internal-structures-of-the-windows-registry.aspx
and
http://moyix.blogspot.com/2008/02/enumerating-registry-hives.html
Hermès Bélusca-Maïto [Sun, 17 Feb 2019 00:07:56 +0000 (01:07 +0100)]
[CMLIB] Minor code style changes only: Use slightly more explicit signature #define names so that we know to which hive structure they correspond.
Hermès Bélusca-Maïto [Sat, 16 Feb 2019 23:54:59 +0000 (00:54 +0100)]
[NTOS:CM] Set and reset the CMHIVE HiveIsLoading flag adequately. Fix an assertion in CmFlushKey() and reset the CMHIVE ViewLockOwner when releasing the view lock.
Eric Kohl [Sat, 16 Feb 2019 19:36:46 +0000 (20:36 +0100)]
[SNDVOL32] AUTORADIOBUTTONs are AUTORADIOBUTTONs, not PUSHBUTTONs
Eric Kohl [Sat, 16 Feb 2019 18:22:57 +0000 (19:22 +0100)]
[SNDVOL32] Change the menu item prefix from IDC to IDM
Mark Jansen [Sat, 16 Feb 2019 14:07:49 +0000 (15:07 +0100)]
[WIN32K:NTUSER] Do not try to reposition an off-screen menu as if it were a popup menu
CORE-15733
Pierre Schweitzer [Sat, 16 Feb 2019 13:12:01 +0000 (14:12 +0100)]
[KERNEL32] Stub SetThreadErrorMode()
Now, Steam crashes because of the stub of GetSystemTimePreciseAsFileTime
CORE-14966
Eric Kohl [Sat, 16 Feb 2019 12:54:46 +0000 (13:54 +0100)]
[SNDVOL32] Enable the balance and volume trackbars only if the line has a volume fader control.
Pierre Schweitzer [Sat, 16 Feb 2019 12:46:40 +0000 (13:46 +0100)]
[MSAFD] Add an initial implementation of SIO_GET_EXTENSION_FUNCTION_POINTER IOCTL
Also stub the related functions the IOCTL will return, namely: WSAID_ACCEPTEX,
WSAID_CONNECTEX, WSAID_DISCONNECTEX, WSAID_GETACCEPTEXSOCKADDRS
This will allow Steam client not to fail in an ASSERT
related to the Steam client PlatformSocketsInit function.
Even though, this doesn't fix Steam running on ReactOS since its UI requires
a Windows 7 API from Kernel32: SetThreadErrorMode().
Nota: its crash got fixed thanks to the Wine sync done recently.
CORE-14966
Eric Kohl [Sat, 16 Feb 2019 11:57:19 +0000 (12:57 +0100)]
[SNDVOL32] Disable the Mute checkbox for all lines that do not have a mute switch control
Pierre Schweitzer [Sat, 16 Feb 2019 09:01:50 +0000 (10:01 +0100)]
[E1000] Remove useless null check
CID 512827
Pierre Schweitzer [Sat, 16 Feb 2019 08:58:44 +0000 (09:58 +0100)]
[E1000] Don't attempt to free uninitialized pointer
CID
1442660
Katayama Hirofumi MZ [Sat, 16 Feb 2019 08:27:25 +0000 (17:27 +0900)]
msgdump.h undocumented drag & drop support (#1359)
In sdk/include/reactos/msgdump.h, support Drag & Drop undocumented messages.
Pierre Schweitzer [Sat, 16 Feb 2019 08:05:15 +0000 (09:05 +0100)]
[IPHLPAPI] Properly handle GetModuleBaseName failure
CID
1442662,
1442663
Pierre Schweitzer [Sat, 16 Feb 2019 08:00:06 +0000 (09:00 +0100)]
[IPHLPAPI] Check pointers when returning module info from specific connection
Pierre Schweitzer [Sat, 16 Feb 2019 07:48:08 +0000 (08:48 +0100)]
[IPHLPAPI] Remove dead code
CID 513306,
1442673,
1442697
Pierre Schweitzer [Thu, 14 Feb 2019 09:48:32 +0000 (10:48 +0100)]
[FASTFAT] On volume open, update share access if volume was already open
It was never updated afterwards, leading to a totally loss of share
access information amongst callers.
Pierre Schweitzer [Thu, 14 Feb 2019 09:12:31 +0000 (10:12 +0100)]
[VFATLIB] Don't forcibly delete LFN when not in RW mode
Bișoc George [Wed, 13 Feb 2019 14:22:28 +0000 (15:22 +0100)]
[USETUP] Check the status value of BuildInstallPaths() (#1349)
Julian Kirsch [Wed, 13 Feb 2019 12:12:52 +0000 (13:12 +0100)]
[NSLOOKUP] Fix crash in case of no network connectivity (#1354)
Prevent nslookup.exe from crashing when executed in a ROS VM with no network
interfaces. This is due to a NULL pointer dereference occurring if
`GetNetworkParams` in `main` fails with an error other than
`ERROR_BUFFER_OVERFLOW`. In this case, `pNetInfo` remains initialized to
NULL, causing `strncpy` to crash.
Bișoc George [Wed, 13 Feb 2019 12:11:17 +0000 (13:11 +0100)]
[CRYPTEXT] Add Romanian & Italian translations (#1352)
Bișoc George [Wed, 13 Feb 2019 12:10:54 +0000 (13:10 +0100)]
[OSK] Romanian & Italian translations update (#1353)
Andrew Cook [Wed, 13 Feb 2019 08:33:10 +0000 (19:33 +1100)]
[RAMDISK] Fix unterminated query table
Timo Kreuzer [Sun, 3 Feb 2019 23:06:35 +0000 (00:06 +0100)]
[CRT] Implement thread/fiber safe support for MSVC and Clang-CL
This is the most trivial (but also most efficient) implementation possible. Should be good enough for now.
Timo Kreuzer [Sun, 3 Feb 2019 22:36:49 +0000 (23:36 +0100)]
[CRT] Use alias names for rot functions when compiling with Clang-CL
Clang-CL does not support #pragma function like CL. The alternative to this approach is to disable all intrinsics for this single source file, but that is not trivial to do, as it can only be done by removing a compiler switch, which we have no CMake support for. Therefore this solution is simpler and as good.
Timo Kreuzer [Sun, 3 Feb 2019 18:57:30 +0000 (19:57 +0100)]
[MVDM] hack-fix Clang-CL build
Timo Kreuzer [Sun, 3 Feb 2019 17:25:04 +0000 (18:25 +0100)]
[CPPRT] Implement __std_terminate wrapper for Clang-CL
Timo Kreuzer [Sun, 3 Feb 2019 17:04:03 +0000 (18:04 +0100)]
[NDK] Fix INIT_SECTION for Clang (use the GCC definition)
Timo Kreuzer [Sun, 3 Feb 2019 16:49:29 +0000 (17:49 +0100)]
[CRT] Don't define _DECLSPEC_I on Clang builds
Eric Kohl [Mon, 11 Feb 2019 22:44:01 +0000 (23:44 +0100)]
[SNDVOL32] Read the Style value from the registry and use it as the default display mode. The /n option is no longer needed.
CORE-15743
Eric Kohl [Mon, 11 Feb 2019 20:16:32 +0000 (21:16 +0100)]
[SNDVOL32] Disable the balance trackbar for mono channels.
CORE-15743
Stanislav Motylkov [Mon, 11 Feb 2019 18:16:26 +0000 (21:16 +0300)]
[MEDIA][INF] Fix E1000 driver date
DriverVer date format is mm/dd/yyyy
Victor Perevertkin [Sun, 16 Sep 2018 12:07:46 +0000 (15:07 +0300)]
[CONFIGURE] Do not create another "reactos" directory in build directory. This makes configure.sh consistent with configure.cmd
Pierre Schweitzer [Mon, 11 Feb 2019 08:03:15 +0000 (09:03 +0100)]
[NTOSKRNL] Simplify object type name printing
Hermès Bélusca-Maïto [Sat, 5 Jan 2019 15:50:32 +0000 (16:50 +0100)]
[WIN32SS:NTUSER] Bugcheck in case two mandatory initialization steps are not fulfilled.
- Bugcheck VIDEO_DRIVER_INIT_FAILURE in case initializing video fails.
- Bugcheck WIN32K_INIT_OR_RIT_FAILURE (Windows-compatible) in case
the USER subsystem version does not match.
Hermès Bélusca-Maïto [Thu, 3 Jan 2019 14:50:06 +0000 (15:50 +0100)]
[BUGCODES] Add WIN32K_INIT_OR_RIT_FAILURE to the list.
Hermès Bélusca-Maïto [Sun, 10 Feb 2019 21:33:43 +0000 (22:33 +0100)]
[USBSTOR][USBSTOR_NEW] Fix a comparison made for assigning the ScsiInquiryData->RemovableMedia flag.
Now removable drives are really reported as such.
See https://github.com/reactos/reactos/pull/308/files#r163224294
for more details.
Hermès Bélusca-Maïto [Wed, 2 Jan 2019 19:28:21 +0000 (20:28 +0100)]
[DISK.SYS] Add a HACK so that we can use NT5+ NTOS functions with this NT4 driver for removable devices.
This is needed in order to avoid an infinite recursive loop between
disk!UpdateRemovableGeometry() and ntos!IoReadPartitionTable().
This does not happen with NT5+ disk_new.sys because it doesn't call
IoReadPartitionTable() in that situation.
Eric Kohl [Sun, 10 Feb 2019 21:17:15 +0000 (22:17 +0100)]
[SNDVOL32] Implement the volume and balance trackbar for mono and stereo lines.
Pierre Schweitzer [Sun, 10 Feb 2019 19:52:55 +0000 (20:52 +0100)]
[OOPS] That was not meant to be pushed/commited
Pierre Schweitzer [Sun, 10 Feb 2019 19:42:32 +0000 (20:42 +0100)]
[CRYPTEX] Add French translation
Stanislav Motylkov [Sun, 10 Feb 2019 19:26:09 +0000 (22:26 +0300)]
[CRYPTEXT] Add russian translation
Addendum to
d56d9c1.
Eric Kohl [Sun, 10 Feb 2019 18:34:22 +0000 (19:34 +0100)]
[SNDVOL32] Initialize and update the volume and balance trackbars. Moving the trackbars has no effect yet.
Eric Kohl [Sun, 10 Feb 2019 12:28:58 +0000 (13:28 +0100)]
[SNDVOL32] Fix coding style issues. No code changes!
Baruch Rutman [Sun, 10 Feb 2019 16:57:43 +0000 (18:57 +0200)]
[CRYPTEXT] Make extension localizable, and add an icon for certificate files (#1347)
- Localize error message and shell file extension description.
- Added Hebrew resources.
- Added Icon.
The icon is the Tango icon named "certificate". If anybody has a idea for more fitting icon please recommend it.
Follow up of #1343
CORE-15736
Hermès Bélusca-Maïto [Sun, 10 Feb 2019 16:30:56 +0000 (17:30 +0100)]
[NETCFGX] Fix an assignment typo.
Serge Gautherie [Sun, 10 Feb 2019 15:46:23 +0000 (16:46 +0100)]
[CMAKE] msvc.cmake: Remove 2 now redundant '/GF' (#1239)
Addendum to
5e673f3.
CORE-14373
Bișoc George [Sun, 10 Feb 2019 15:43:51 +0000 (16:43 +0100)]
[USETUP][REACTOS] Check the status return value of InitDestinationPaths() (#1264)
- Within the function's body code, check the status values returned by the called functions.
- Change the BuildInstallPaths's function type to NTSTATUS instead of VOID (and check the status of InitDestinationPaths() as well.
Bișoc George [Sun, 10 Feb 2019 15:04:16 +0000 (16:04 +0100)]
[OSK] Implement standard/enhanced keyboard handler (#1338)
- Add the respective standard keyboard resource.
- Implement the standard/enhanced keyboard dialog switcher.
- Implement save/load handler.
- Move the warning box conditinal check (bShowWarning) to wWinMain application entry point (this will prevent the modal welcome box from displaying each time the user switches into another dialog).
CORE-14428
Luo Yufan [Sun, 10 Feb 2019 14:46:19 +0000 (22:46 +0800)]
[SETUP][INF] Add font substitute for CJK. (#1346)
Fix CJK font problem in Royale theme in ReactOS.
The reason for this PR is similar to the previous one (#1127).
CORE-15738
Mark Jansen [Sat, 9 Feb 2019 12:23:47 +0000 (13:23 +0100)]
[IPHLPAPI] Preserve decoration in exported symbols
CORE-8462
CORE-15665
Eric Kohl [Sun, 10 Feb 2019 11:53:08 +0000 (12:53 +0100)]
[SNDVOL32] Disable the 'Advanced Controls' menu item by default.
Pierre Schweitzer [Sun, 10 Feb 2019 10:23:57 +0000 (11:23 +0100)]
[NTOSKRNL] Also display sections name
Serge Gautherie [Wed, 30 Jan 2019 00:54:42 +0000 (01:54 +0100)]
[UDFS] Correctly check SeSinglePrivilegeCheck() return value
SeSinglePrivilegeCheck() returns a BOOLEAN, not a NTSTATUS.
CORE-14271
Hermès Bélusca-Maïto [Sat, 9 Feb 2019 23:47:43 +0000 (00:47 +0100)]
[SDK:CMAKE] Fix LINK command-line from the VS IDE for CMake VSSolution configurations, when using MSVC "linker script" files.
MSBuild, via the VS IDE, uses response files when calling CL or LINK.
We cannot specify a custom response file on the linker command-line,
since specifying response files from within response files is forbidden.
We therefore have to pre-process, at configuration time, the linker
script so as to retrieve the custom linker options to be appended
to the linker command-line.
Hermès Bélusca-Maïto [Sat, 9 Feb 2019 23:43:31 +0000 (00:43 +0100)]
[FREELDR][SDK:CMAKE] Move the `MSVC "linker script" file' functionality out of FreeLdr's cmake file and place it in the dedicated files instead.
Oleksandr Shaposhnikov [Mon, 4 Feb 2019 02:53:09 +0000 (04:53 +0200)]
[FREELDR] Fix VSSolution configuring and build
"configure.cmd VSSolution" was failing due to add_asm_files macro
expansion. It was using the same 'freeldr_linker_file' variable name
as a temporary filename base twice. This patch uses '_target'
parameter to make those variable names differ.
Eric Kohl [Sat, 9 Feb 2019 23:14:05 +0000 (00:14 +0100)]
[SNDVOL32] Fix the positions and sizes of the separators of the normal line dialog and load the master dialogs for speakers or headphones.
Pierre Schweitzer [Sat, 9 Feb 2019 12:59:11 +0000 (13:59 +0100)]
[NTOSKRNL] Fix parsing loop
Pierre Schweitzer [Sat, 9 Feb 2019 12:45:19 +0000 (13:45 +0100)]
[NTOSKRNL] Add a first implementation of !handle command in KDBG
It allows dumping all the handles (filtered by PID/Process)
and it displays basic information about file and key handles
Andrew Cook [Sat, 9 Feb 2019 04:08:08 +0000 (15:08 +1100)]
[mvdm] Fix missing pointer dereference
Original code compared against the pointer value rather
than the first byte
Mark Jansen [Sat, 9 Feb 2019 00:44:39 +0000 (01:44 +0100)]
[CRYPTEXT] Add a minimal shell extension that will show the certificate dialog
Mark Jansen [Thu, 7 Feb 2019 19:57:04 +0000 (20:57 +0100)]
[LDR] Check forwarded imports against the manifest before trying to load them
CORE-15729
Victor Perevertkin [Mon, 21 Jan 2019 21:44:25 +0000 (00:44 +0300)]
[E1000] Finished an implementation of the driver.
Added PIDs for whole Intel 8254x family.
Note: this driver uses legacy interfaces for either receive and transmit descriptors.
CORE-14675
Mark Jansen [Mon, 2 Jul 2018 20:29:05 +0000 (22:29 +0200)]
[NDIS] Improve debug output
Mark Jansen [Sun, 3 Jun 2018 20:43:50 +0000 (22:43 +0200)]
[E1000] Initial send implementation.
CORE-14675
Mark Jansen [Tue, 29 May 2018 20:52:43 +0000 (22:52 +0200)]
[E1000] Implement basic sending.
Implement some interrupt recognition
CORE-14675
Mark Jansen [Sun, 27 May 2018 22:09:10 +0000 (00:09 +0200)]
[E1000] Basic initialization of the card
Initialize some registers, allocate basic resources
CORE-14675
Mark Jansen [Fri, 18 May 2018 22:23:45 +0000 (00:23 +0200)]
[E1000] Create an initial driver skeleton
Based on the rtl8139 driver written by Cameron Gutman
CORE-14675
Mark Jansen [Sun, 14 Oct 2018 13:45:02 +0000 (15:45 +0200)]
[LDR] Add support for .local files
CORE-187