Joachim Henze [Fri, 23 Sep 2022 21:28:39 +0000 (23:28 +0200)]
[EXPLORER] Cleanup after last commit CORE-15369
Improves code that was added by 0.4.15-dev-5078-g
46de3a22acc964f27a5260e144089125f83586ff
without any review yesterday.
Hervé Poussineau [Fri, 23 Sep 2022 21:06:34 +0000 (23:06 +0200)]
[ISAPNP] Generate hardware ids and compatible ids in upper case
Hervé Poussineau [Mon, 12 Sep 2022 20:59:49 +0000 (22:59 +0200)]
[SHELL32] Prevent use after free
'buffer' is local to the function, while m_sPath is an instance class member.
Fix that by calling the IShellLink::Resolve() function, which will allocate
and fill the m_sPath variable.
CORE-15229
Katayama Hirofumi MZ [Fri, 23 Sep 2022 04:50:24 +0000 (13:50 +0900)]
[USER32][IMM32] Use wcscspn instead of wcsspn
b4575ec and
db00a75 were my mistakes.
CORE-11700
Katayama Hirofumi MZ [Thu, 22 Sep 2022 23:25:27 +0000 (08:25 +0900)]
[EXPLORER] Follow-up of #4718 (
ba2cead)
Handle click OnNcLButtonUp instead of OnNcLButtonDown/OnNcLButtonDblClick.
CORE-15369
Katayama Hirofumi MZ [Thu, 22 Sep 2022 14:01:12 +0000 (23:01 +0900)]
[EXPLORER] 'Show Desktop' button should work on button up (#4718)
Follow-up of PR #4715. CORE-15369
- The 'Show Desktop' button of taskbar works on button up instead of button down.
- Add NULL checks for m_ShowDesktopButton.
- Fix hung-up in rebooting.
Katayama Hirofumi MZ [Thu, 22 Sep 2022 03:18:59 +0000 (12:18 +0900)]
[EXPLORER] Add 'Show Desktop' button at right edge of taskbar (#4715)
This PR adds a tiny button of window class "TrayShowDesktopButtonWClass" at right/bottom edge of taskbar.
This button allows the user to access "Show/Restore Desktop" feature by mouse.
You can toggle visibility of this button by registry value "TaskbarSd" in key "HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced".
The button is themed when theme is available.
CORE-15369
Katayama Hirofumi MZ [Mon, 19 Sep 2022 09:13:17 +0000 (18:13 +0900)]
[CPL][INTL] Realize automatic Japanese IME installation (#4705)
In intl.cpl, realize semi-automatic Japanese IME installation by checkbox "Install files for East Asian languages" by using rapps.exe. CORE-11700
Kyle Katarn [Mon, 19 Sep 2022 01:06:47 +0000 (03:06 +0200)]
[SHELL32] Fix property sheets that can't be closed due to failed init (#4709)
When a PropertySheet fails to init, that fact is being logged
and it shows an empty page, but it can't be closed.
Handle second failure properly by using FAILED_UNEXPECTEDLY macro.
CORE-18333
Kyle Katarn [Sun, 18 Sep 2022 23:14:23 +0000 (01:14 +0200)]
[HOTPLUG] Add French (fr-FR) translation (#4703)
Andrei Miloiu [Sun, 18 Sep 2022 23:10:49 +0000 (02:10 +0300)]
[APPWIZ] Update Romanian (ro-RO) translation (#4700)
Thamatip Chitpong [Sun, 18 Sep 2022 22:56:35 +0000 (05:56 +0700)]
[ZIPFLDR] Set large icon correctly (#4708)
Now it's correctly displayed in Alt+Tab window selection.
Joachim Henze [Sun, 18 Sep 2022 18:53:30 +0000 (20:53 +0200)]
[DDRAW] Handle DDLOCK_WRITEONLY in wined3dmapflags_from_ddrawmapflags() CORE-18378 (#4713)
Mutes the logging:
fixme:(dll/directx/wine/ddraw/utils.c:584) Unhandled flags 0x20.
gets logged many times per second.
It does affect several applications, e.g. the game 'Anno 1602' from 1998, and the 'Diablo 2 demo' from rapps,
For both games it can be observed with both: our VBEMP driver and the VBox4.3.12 3D-accelerated-driver.
Muting may improve performance a bit in such apps.
It gets logged although no missing features can be perceived visually in the rendering.
Fix it by importing Wine-commit
b943c7910b3261c9603343369cd632f7a3b56bba
ddraw: Handle DDLOCK_WRITEONLY in wined3dmapflags_from_ddrawmapflags().
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Mark Jansen [Wed, 14 Sep 2022 18:53:04 +0000 (20:53 +0200)]
[GDI32] Fix ExtTextOutA with ETO_GLYPH_INDEX
CORE-18365
Jérôme Gardou [Fri, 9 Sep 2022 17:17:14 +0000 (19:17 +0200)]
[NTOS] Add some sanity checks when synchronizing PDEs
Katayama Hirofumi MZ [Sat, 17 Sep 2022 04:59:51 +0000 (13:59 +0900)]
[CPL] Boundary check of Control Panel applets (#4706)
- Check the boundary (i < NUM_APPLETS) of the variable i in CPlApplet functions.
- Use UINT type for the variable i.
Katayama Hirofumi MZ [Fri, 16 Sep 2022 22:56:41 +0000 (07:56 +0900)]
[MEDIA][INF] The name of rapps in Japanese is too long (#4707)
Renaming: 「アプリケーション マネージャ」→「アプリ マネージャ」
Katayama Hirofumi MZ [Fri, 16 Sep 2022 22:12:05 +0000 (07:12 +0900)]
[INPUT] Fix IsRebootNeeded condition
If there is any IME HKL, reboot is needed.
Follow-up to #4666 (
596f04b). CORE-11700, CORE-18364
Katayama Hirofumi MZ [Fri, 16 Sep 2022 09:04:55 +0000 (18:04 +0900)]
[USER32] Avoid szImeFileName buffer overrun
CORE-11700
Katayama Hirofumi MZ [Fri, 16 Sep 2022 08:59:48 +0000 (17:59 +0900)]
[USER32] Don't allow invalid 'IME File' values
Improve security. CORE-11700
Katayama Hirofumi MZ [Fri, 16 Sep 2022 08:54:15 +0000 (17:54 +0900)]
[IMM32] Follow-up of
db00a75
Add more invalid characters. CORE-11700
Katayama Hirofumi MZ [Fri, 16 Sep 2022 08:41:12 +0000 (17:41 +0900)]
[NTUSER] Use IS_CICERO_MODE() macro in co_UserActivateKeyboardLayout
CORE-11700
Katayama Hirofumi MZ [Fri, 16 Sep 2022 08:35:05 +0000 (17:35 +0900)]
[IMM32] Don't allow invalid 'IME File' values
Improve security. CORE-11700
Katayama Hirofumi MZ [Thu, 15 Sep 2022 23:26:22 +0000 (08:26 +0900)]
[INPUT] Follow-up of #4666 (
596f04b)
Reboot is still needed for IME settings.
CORE-11700, CORE-18364
Katayama Hirofumi MZ [Thu, 15 Sep 2022 23:09:37 +0000 (08:09 +0900)]
[USER32][INPUT] Support various keyboard layouts (#4666)
- Fix IntLoadKeyboardLayout function to return the correct HKL value.
- Modify LAYOUT_LIST_NODE structure to add more information.
- Fix LayoutList_GetByHkl function to choose the IME HKLs correctly.
- Ignore DELETED entries correctly.
- Improve UI/UX.
CORE-11700, CORE-13244, CORE-18364
Artyom Ovsyannikov [Thu, 15 Sep 2022 10:56:29 +0000 (13:56 +0300)]
[REACTOS] Various Russian (ru-RU) translation fixes (#4696)
Reviewed-by: Stanislav Motylkov <binarymaster@mail.ru>
Thamatip Chitpong [Thu, 15 Sep 2022 14:54:10 +0000 (21:54 +0700)]
[HOTPLUG] Add title bar icon (#4695)
- Add small icon to the title bar
- Set large icon correctly
CORE-15445
Andrei Miloiu [Thu, 15 Sep 2022 14:42:03 +0000 (17:42 +0300)]
[HOTPLUG] Add Romanian (ro-RO) translation (#4693)
Signed-off-by: Andrei Miloiu <miloiuandrei@gmail.com>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Reviewed-by: Ștefan Fulea <reactos-contributor@programmer.net>
Kyle Katarn [Thu, 15 Sep 2022 13:56:31 +0000 (15:56 +0200)]
[MMC] Implement standard "About" menu action (#4639)
Reviewed-by: Serge Gautherie <reactos-git_serge_171003@gautherie.fr>
Reviewed-by: Mark Jansen <mark.jansen@reactos.org>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Kyle Katarn [Thu, 15 Sep 2022 10:14:50 +0000 (12:14 +0200)]
[SNDVOL32][MMSYS] Fix French (fr-FR) layout and translation (#4678)
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Serge Gautherie <32623169+SergeGautherie@users.noreply.github.com>
Kyle Katarn [Wed, 14 Sep 2022 19:33:13 +0000 (21:33 +0200)]
[SHELL32] Fix French message for "Overwrite Folder" confirmation message
[SHELL32] Fix French message for "Overwrite Folder" confirmation message
Stanislav Motylkov [Wed, 14 Sep 2022 20:48:21 +0000 (23:48 +0300)]
[INF] Update Russian (ru-RU) translation
Addendum to
a03ef85b.
Stanislav Motylkov [Wed, 14 Sep 2022 20:44:17 +0000 (23:44 +0300)]
[HOTPLUG] Update Russian (ru-RU) translation
Addendum to
21824a25.
Dmitry Borisov [Wed, 14 Sep 2022 20:40:47 +0000 (02:40 +0600)]
[INF] Add description for IDE-compatible controllers (#4690)
Add missing string. CORE-17256
Thamatip Chitpong [Wed, 14 Sep 2022 20:12:50 +0000 (03:12 +0700)]
[HOTPLUG] Add missing string resources for applet (#4689)
Use `IDS_CPLNAME` for the window title.
This also fixes the missing title text on the taskbar.
Thamatip Chitpong [Wed, 14 Sep 2022 17:06:22 +0000 (00:06 +0700)]
[MMSYS] Multimedia Control Panel diverse fixes (#4572)
- Use Unicode (WCHAR) instead of TCHAR
- Code formatting
- Use string safe functions
- Close handles after calling `CreateProcess`
- Save sound path as `REG_EXPAND_SZ` only if the path
contains '%' character, like Windows does
- Fix `wcsdup` leaks
Reviewed-by: Mark Jansen <mark.jansen@reactos.org>
Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Reviewed-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Thamatip Chitpong [Wed, 14 Sep 2022 14:29:29 +0000 (21:29 +0700)]
[INPUT] Fix taskbar icon and remove small icon hack (#4688)
- Use int for applet index (like other CPLs).
- Revert some changes from
976d48b.
Vitaly Orekhov [Wed, 14 Sep 2022 12:10:37 +0000 (15:10 +0300)]
[LOGONUI] Make Logon UI compilable again (#4684)
Logon UI was excluded from CMake build, probably for not being compliant
with 'warnings are errors' standard introduced at some point.
In the future, I would probably try to make Logon UI usable
alongside with the classic msgina interface.
- Add logonui back to CMakeLists
- Replace 'wcscpy_s' Vista+ function with StringCchCopyW
- Exclude some unused functions
Signed-off-by: Vitaly Orekhov <crce2000@mail.ru>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Mark Jansen [Sat, 27 Aug 2022 12:45:42 +0000 (14:45 +0200)]
[REGEDIT] Fix possible buffer overflow
Katayama Hirofumi MZ [Tue, 13 Sep 2022 18:39:18 +0000 (03:39 +0900)]
[CPL][INPUT] s/IDI_KEY_SHORT_ICO/IDI_CPLSYSTEM/ and small icon
The task icon of Taskbar was wrong...
Katayama Hirofumi MZ [Tue, 13 Sep 2022 17:58:28 +0000 (02:58 +0900)]
[USER32] Load keyboard layouts on logon correctly (#4686)
- Add IntLoadPreloadKeyboardLayouts helper function to load the layouts on log-on.
- In UpdatePerUserSystemParameters function, call CliImmInitializeHotKeys and IntLoadPreloadKeyboardLayouts functions.
CORE-16600
Jose Carlos Jesus [Tue, 13 Sep 2022 15:00:45 +0000 (16:00 +0100)]
[ATL] Fix window position to fit in screen area (#4512)
Clicking "Edit compatibility modes" button in the "Compatibility" tab
opens a window centered on the parent window. If we move the parent
window to one of the screen edges and then click this button again,
the new window will appear off screen.
Adjust position of created window, so now it would be completely visible.
CORE-17089
Reviewed-by: Mark Jansen <mark.jansen@reactos.org>
Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Joachim Henze [Tue, 13 Sep 2022 13:22:51 +0000 (15:22 +0200)]
[SYSSETUP] Update German (de-DE) translation (#4679)
- Fix typos in existing translation
- Update new strings that were added during 0.4.15-dev'ing
Addendum to
3f053db3 and
6d09885c. CORE-18357
Serge Gautherie [Tue, 13 Sep 2022 12:30:13 +0000 (14:30 +0200)]
[DOC] 3rd Party Files.txt: Fix Buslogic driver version (#4685)
Correct version is in the BusLogic958.rc file.
Addendum to
5ee633f7d7e (0.4.15-dev-4556).
CORE-18180
Serge Gautherie [Tue, 13 Sep 2022 12:08:45 +0000 (14:08 +0200)]
[DOC] 3rd Party Files.txt: Add 3rdparty/ to some sdk/lib/ paths (#4642)
Katayama Hirofumi MZ [Tue, 13 Sep 2022 06:48:04 +0000 (15:48 +0900)]
[BOOTDATA] Fix 'Layout Id' values of hivesys.inf
Fix them to Win2k3's settings.
CORE-11700
Katayama Hirofumi MZ [Tue, 13 Sep 2022 05:32:39 +0000 (14:32 +0900)]
[NTUSER] Fix UserSetDefaultInputLang by using reordering
- Move IntReorderKeyboardLayouts function.
- Fix UserSetDefaultInputLang function.
CORE-11700
Serge Gautherie [Mon, 12 Sep 2022 19:30:28 +0000 (21:30 +0200)]
[NTFS] PrintAllVCNs(): Fix a typo in an ASSERT() (#4682)
It was introduced in 0.4.7-dev-590-g
5579428b4f1.
Mark Jansen [Sun, 11 Sep 2022 20:14:46 +0000 (22:14 +0200)]
[SHELL32] Only hide a window when there is a window to hide
Mark Jansen [Sun, 11 Sep 2022 20:14:15 +0000 (22:14 +0200)]
[SHELL32] Properly destroy window
Mark Jansen [Sun, 11 Sep 2022 19:28:23 +0000 (21:28 +0200)]
[SHELL32] Don't try to remove buttons on a nonexisting window
Joachim Henze [Mon, 12 Sep 2022 12:26:19 +0000 (14:26 +0200)]
[TASKMGR] Pixel-perfection for left border (#4680)
CORE-18061
This makes the left border 2 pixels smaller in
IDD_APPLICATION_PAGE and IDD_PROCESS_PAGE.
The goal is:
- matching XPSP3 taskmgr to 100% on left border.
- leaving more room for the content of the 2 SysListView32.
- better aligning left border of IDD_APPLICATION_PAGE
and IDD_PROCESS_PAGE to IDD_PERFORMANCE_PAGE
upon tab-switching.
In addition: Update german (de-DE) translation:
Make wording of IDS_MSG_TRAYICONCPUUSAGE (used in tooltip)
match the wording used in IDS_STATUS_CPUUSAGE (used in status bar).
Kyle Katarn [Mon, 12 Sep 2022 12:22:52 +0000 (14:22 +0200)]
[NTOS:MM] Implement PeakCommitment (MmPeakCommitment, MmTotalCommittedPages) (#4650)
And return the corresponding values in SystemPerformanceInformation.
Lockless updating counters suggestion by Thomas Faber.
Hervé Poussineau [Mon, 12 Sep 2022 06:13:17 +0000 (08:13 +0200)]
[SHELL32] Fill link path before initializing the dialog
This fixes the Target type, Target location and Target fields
in shortcut properties window.
CORE-15229
Artyom Ovsyannikov [Sat, 10 Sep 2022 08:05:32 +0000 (11:05 +0300)]
[SYSSETUP] Add Tango Desktop Project to the list of used projects (#4676)
Stanislav Motylkov [Sat, 10 Sep 2022 23:16:34 +0000 (02:16 +0300)]
[MMSYS] Add proper description to Speaker Volume dialog
Spotted by Kyle Katarn.
Hervé Poussineau [Sat, 25 Jun 2022 17:01:08 +0000 (19:01 +0200)]
[CMAKE] Set KDBG define only where required (fastfat, win32k, ntoskrnl)
Hervé Poussineau [Sat, 25 Jun 2022 16:44:37 +0000 (18:44 +0200)]
[CMAKE] Set _WINKD_ define only where required (kernel and setuplib)
Hervé Poussineau [Sat, 10 Sep 2022 20:25:19 +0000 (22:25 +0200)]
[FLOPPY] Correctly return media changed information
If disk changed since last time, we must either return STATUS_IO_DEVICE_ERROR
or STATUS_VERIFY_REQUIRED, depending of VPB_MOUNTED flag.
This is already handled by the SignalMediaChanged() function.
CORE-18244
Mark Jansen [Sat, 10 Sep 2022 15:27:50 +0000 (17:27 +0200)]
[MSPAINT][EXPLORER][SHELL32] Enable ATL asserts in CMake
CORE-17505
In MSVC builds they would not work reliably when enabled in the precompiled header
Kyle Katarn [Sat, 10 Sep 2022 13:59:00 +0000 (15:59 +0200)]
[SHELL32] Fix Assertion when opening "File" menu in MyComputer twice (#4675)
ReactOS explorer shell asserts when opening the "File" menu in MyComputer for the second time.
This is due to the cached copy of IContextMenu not being released before attempting to cache it again.
Fix based on the patch proposed by JIRA user I_Kill_Bugs
CORE-18353
Signed-off by: I_Kill_Bugs (original patch author)
Kyle Katarn [Fri, 9 Sep 2022 21:51:51 +0000 (23:51 +0200)]
[NETSHELL] Fix Network Tray icon activity indication (#4669)
The network activity tray icon wasn't showing activity until the Properties
dialog was opened at least once.
This was due to the fact that the tray icon was initialized once with missing
initialization parameters for pContext (default state and Adapter index).
Fix this problem by adding the missing initialization.
CORE-4497, CORE-9017, CORE-15744
Thamatip Chitpong [Fri, 9 Sep 2022 18:26:39 +0000 (01:26 +0700)]
[ZIPFLDR] Show icon on the taskbar (#4670)
Kyle Katarn [Fri, 9 Sep 2022 18:23:11 +0000 (20:23 +0200)]
[EXPLORER] Fix Start Menu context menu actions (#4643)
CORE-18336
The current design was not processing actions verbs correctly for some
Start Menu context menu actions (Properties, Open all users, Explore all users),
despite associated code being implemented.
This was due by incorrectly filtering command IDs, not routing to the appropriate processing.
Katayama Hirofumi MZ [Thu, 8 Sep 2022 02:00:04 +0000 (11:00 +0900)]
[NTUSER] Implement IntReorderKeyboardLayouts
This function is provided for KLF_REORDER flag.
CORE-11700
Katayama Hirofumi MZ [Thu, 8 Sep 2022 01:50:49 +0000 (10:50 +0900)]
[IMM32] s/Ime32LoadImeDpi/Imm32LoadImeDpi/
Typo. CORE-11700
Katayama Hirofumi MZ [Thu, 8 Sep 2022 00:57:17 +0000 (09:57 +0900)]
[IMM32] Remove unnecessary NULL checks for function pointers
CORE-11700
Katayama Hirofumi MZ [Thu, 8 Sep 2022 00:43:43 +0000 (09:43 +0900)]
[IMM32] s/Imm32Is16BitMode/IS_16BIT_MODE/
CORE-11700
Katayama Hirofumi MZ [Thu, 8 Sep 2022 00:40:50 +0000 (09:40 +0900)]
[IMM32] s/Imm32IsCiceroMode/IS_CICERO_MODE/
CORE-11700
Kyle Katarn [Wed, 7 Sep 2022 23:28:13 +0000 (01:28 +0200)]
[DESKADP] Add some spacing between the "legend" and the data (#4668)
Follow up of PR #4665 (
cb6b07ee).
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Katayama Hirofumi MZ [Wed, 7 Sep 2022 08:40:51 +0000 (17:40 +0900)]
[BOOTDATA] Delete "Layout Id" from Japanese/Korean Keyboard Layout
CORE-11700
Mark Jansen [Sat, 18 Jun 2022 19:24:41 +0000 (21:24 +0200)]
[STOBJECT] Add support for the mouse key tray icon
Mark Jansen [Sat, 18 Jun 2022 19:24:04 +0000 (21:24 +0200)]
[PSDK] Add missing defines / argument names
Mark Jansen [Sat, 18 Jun 2022 19:23:43 +0000 (21:23 +0200)]
[PSDK] Add COWAIT_DEFAULT
Mark Jansen [Sat, 18 Jun 2022 19:19:42 +0000 (21:19 +0200)]
[STOBJECT] Keep the object alive while the thread is running,
Fix shutting down the thread.
Mark Jansen [Mon, 16 May 2022 10:34:40 +0000 (12:34 +0200)]
[KERNEL32] Fix BaseDefaultPath containing extra '.'
Katayama Hirofumi MZ [Tue, 6 Sep 2022 15:54:31 +0000 (00:54 +0900)]
[NOTEPAD] Follow-up of 'CJK font workaround'
- Revert some code.
- Add font name comments.
CORE-11700
Katayama Hirofumi MZ [Tue, 6 Sep 2022 06:35:14 +0000 (15:35 +0900)]
[NOTEPAD] CJK font workaround
Far East Asian users may not have suitable fixed-pitch fonts.
CORE-11700
Katayama Hirofumi MZ [Tue, 6 Sep 2022 05:21:46 +0000 (14:21 +0900)]
[NOTEPAD] Use DEFAULT_CHARSET instead of ANSI_CHARSET
Fix the font problem.
CORE-11700
Katayama Hirofumi MZ [Tue, 6 Sep 2022 05:05:59 +0000 (14:05 +0900)]
[NOTEPAD] Add STRING_DEFAULTFONT for default font
CORE-11700
Jérôme Gardou [Mon, 5 Sep 2022 16:25:14 +0000 (18:25 +0200)]
[AMSTREAM_WINETEST] Add missing dependency
Thamatip Chitpong [Mon, 5 Sep 2022 16:21:27 +0000 (23:21 +0700)]
[NOTEPAD] Improve UTF-8 encoding support and improve status bar (#4649)
- Add write support for UTF-8 without BOM.
- Add "UTF-8 with BOM" encoding to the "Save As" dialog.
- Show line endings and encoding on the status bar (like Notepad in Windows 10).
- Remove ignored WS_EX_STATICEDGE
- Add grip to the status window.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Stanislav Motylkov [Mon, 5 Sep 2022 13:24:16 +0000 (16:24 +0300)]
[DESKADP] Add Russian (ru-RU) translation. Addendum to
cb6b07ee.
Kyle Katarn [Mon, 5 Sep 2022 13:01:41 +0000 (15:01 +0200)]
[DESKADP] Improve default display of advanced adapter properties (#4665)
+ fix caption width in french resources.
Andrej Bartulin [Mon, 5 Sep 2022 12:58:00 +0000 (14:58 +0200)]
[TRANSLATION] Croatian translation of games (Solitare and Spider) (#4664)
Katayama Hirofumi MZ [Mon, 5 Sep 2022 02:41:25 +0000 (11:41 +0900)]
[NEWDEV] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Mon, 5 Sep 2022 02:28:04 +0000 (11:28 +0900)]
[SYSSETUP] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Sun, 4 Sep 2022 23:34:00 +0000 (08:34 +0900)]
[NTUSER][USER32][IMM32] Initialize pKL->piiex by using ImmLoadLayout (#4645)
To recognize IME, we have to initialize pKL->piiex.
- Add co_ClientImmLoadLayout and User32CallImmLoadLayoutFromKernel functions to call imm32!ImmLoadLayout on user mode from kernel.
- Use co_ClientImmLoadLayout in NtUserLoadKeyboardLayoutEx.
- Improve Imm32LoadIME to sanitize the IME table.
CORE-11700
Kyle Katarn [Sun, 4 Sep 2022 17:10:11 +0000 (19:10 +0200)]
[TASKMGR] Fix number formatting to respect NLS Number format settings (#4657)
TaskMgr currently does not respect local NLS settings and forces 3 digits + comma (US convention) formatting.
Fix this with a direct reuse of SH_FormatInteger() as already implemented in other places
(dll/win32/shell32/dialogs/filedefext.cpp ...)
- Removal of CommaSeparateNumberString() and replace with SH_FormatInteger().
- PerfDataGetText(): Use a switch structure. Return TRUE iftext could be retrieved; FALSE if not.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Mark Jansen [Sun, 4 Sep 2022 13:28:43 +0000 (15:28 +0200)]
[CODEOWNERS] Remove automatic assignment from cmake/apitests
Kyle Katarn [Sat, 3 Sep 2022 21:30:57 +0000 (23:30 +0200)]
[NETSHELL] Fix "ghost" network activity when opening Network Status page (#4662)
Opening Network Status page creates a systematic "ghost" network activity,
activating RX+TX activity icon both on property page and tray, while no Rx/Tx.
This is due to pContext->dw[In|Out]Octets being initialized to 0 and compared
to refreshed interface data.
To circumvent this, copy refreshed interface data to the context on first update.
Sam Watson [Sat, 3 Sep 2022 21:18:36 +0000 (09:18 +1200)]
[THEMES] Improve text colors of Modern Dark theme (#4655)
- Update colors for all different font sizes.
- Update caption color for other fonts too.
Kyle Katarn [Sat, 3 Sep 2022 21:12:29 +0000 (23:12 +0200)]
[TRANSLATION] French translation update (#4638)
Update of various French translation files for several modules:
CALC, LABEL, DXDIAG, MPLAY32, RAPPS, SHUTDOWN, SNDVOL32, EXPLORER, WINLOGON;
CONSOLE.CPL, MMSYS.CPL; NETCFGX.DLL, SHELL32.DLL, SHLWAPI.DLL, SYSSETUP.DLL
Kyle Katarn [Sat, 3 Sep 2022 20:56:33 +0000 (22:56 +0200)]
[NTOS:EX] Fix returned number of handles for Idle System Process (#4661)
PsIdleProcess and PsInitialSystemProcess share the same handle table. This
leads ObGetProcessHandleCount() to report the same number of handles
when called on those system processes, when being enumerated by
NtQuerySystemInformation(SystemProcessInformation).
Instead, just return 0 for the handle count of the Idle process in SystemProcessInformation.
This is not done in ObGetProcessHandleCount(), since a separate
NtQueryInformationProcess(ProcessHandleCount) for the idle process should return
a non-zero value.
CORE-16577
Kyle Katarn [Sat, 3 Sep 2022 15:29:26 +0000 (17:29 +0200)]
[TASKMGR] Fix overlapping controls (French only) (#4658)
Controls are sized with 0 pixel gap, which is OK in general but show an overlap upon selection.
Add the extra 1 pixel gap.
Kyle Katarn [Sat, 3 Sep 2022 15:27:50 +0000 (17:27 +0200)]
[TASKMGR] Fix UI on SwitchTo for multiple application (#4652)
Kyle Katarn [Sat, 3 Sep 2022 15:22:14 +0000 (17:22 +0200)]
[CONSOLE.CPL] Use translated resource rather than hardcoded text (#4647)
Kyle Katarn [Sat, 3 Sep 2022 15:19:41 +0000 (17:19 +0200)]
[USRMGR] Replace old (leftover) debug MessageBox with Wine trace macros (#4640)
Remove leftover of debug code. CORE-18276
Katayama Hirofumi MZ [Wed, 31 Aug 2022 03:04:21 +0000 (12:04 +0900)]
[KERNEL32] Fix kernel32.rc for UTF-8 codepage (#4648)
- Move #pragma code_page(65001) line.
CORE-18177
Katayama Hirofumi MZ [Tue, 30 Aug 2022 00:35:27 +0000 (09:35 +0900)]
[NTUSER] Move TL structure definition to ntuser.h (#4644)
- Move struct _TL and TL definitions from win32.h to ntuser.h.
- Modify the type of TL.pfnFree as newly-defined TL_FN_FREE function pointer.
CORE-11700