reactos.git
2 years ago[NTOS:KDBG] Silence clang -Wstring-plus-int warnings. 106/head
Thomas Faber [Fri, 3 Nov 2017 12:53:35 +0000 (13:53 +0100)]
[NTOS:KDBG] Silence clang -Wstring-plus-int warnings.

..\ntoskrnl\kdbg\i386\i386-dis.c(3131,23):  warning: adding 'char' to a string does not append to the string [-Wstring-plus-int]
      oappend ("%cs:" + intel_syntax);
               ~~~~~~~^~~~~~~~~~~~~~
..\ntoskrnl\kdbg\i386\i386-dis.c(3131,23):  note: use array indexing to silence this warning
      oappend ("%cs:" + intel_syntax);
                      ^
               &      [             ]

2 years ago[NTOS:KDBG] Portably read control registers.
Thomas Faber [Fri, 3 Nov 2017 12:52:34 +0000 (13:52 +0100)]
[NTOS:KDBG] Portably read control registers.

Fixes clang warning:
..\ntoskrnl\kdbg\kdb.c(175,25):  warning: variable 'TrapCr4' is uninitialized when used here [-Wuninitialized]
    KdbTrapFrame->Cr4 = TrapCr4;
                        ^~~~~~~
..\ntoskrnl\kdbg\kdb.c(140,45):  note: initialize the variable 'TrapCr4' to silence this warning
    ULONG TrapCr0, TrapCr2, TrapCr3, TrapCr4;
                                            ^
                                             = 0

2 years ago[RAPPS-DB] CORE-13027 add Npackd 1.23 - GPLv3 licensed packet manager
Joachim Henze [Wed, 8 Nov 2017 22:03:02 +0000 (23:03 +0100)]
[RAPPS-DB] CORE-13027 add Npackd 1.23 - GPLv3 licensed packet manager

2 years ago[RAPPS-DB] CORE-12284 LibreOffice HelpPack 5.4.3.2
Joachim Henze [Wed, 8 Nov 2017 20:01:38 +0000 (21:01 +0100)]
[RAPPS-DB] CORE-12284 LibreOffice HelpPack 5.4.3.2

2 years ago[RAPPS-DB] CORE-12284 LibreOffice 5.4.3.2 (as 2nd option)
Joachim Henze [Wed, 8 Nov 2017 19:41:13 +0000 (20:41 +0100)]
[RAPPS-DB] CORE-12284 LibreOffice 5.4.3.2 (as 2nd option)

2 years ago[RAPPS-DB] CORE-12284 LibreOffice 5.1.1.3 (LibreOfficeStill)
Joachim Henze [Wed, 8 Nov 2017 19:23:33 +0000 (20:23 +0100)]
[RAPPS-DB] CORE-12284 LibreOffice 5.1.1.3 (LibreOfficeStill)

2 years ago[mspaint] Replace the current 16 pixel program icon with one from the Tango icon...
Jared Smudde [Mon, 6 Nov 2017 21:17:56 +0000 (15:17 -0600)]
[mspaint] Replace the current 16 pixel program icon with one from the Tango icon theme.

2 years ago[RAPPS-DB] CORE-13199 pingus.txt fix typo in spanish description spotted by Javier...
Joachim Henze [Tue, 7 Nov 2017 18:25:46 +0000 (19:25 +0100)]
[RAPPS-DB] CORE-13199 pingus.txt fix typo in spanish description spotted by Javier Fernandez

2 years ago[RAPPS-DB] CORE-13947 update to IrfanView 4.50 & IrfanView Plugins to 4.50 (fixes...
Joachim Henze [Tue, 7 Nov 2017 17:27:49 +0000 (18:27 +0100)]
[RAPPS-DB] CORE-13947 update to IrfanView 4.50 & IrfanView Plugins to 4.50 (fixes broken link of plugins, workarounds MFC42.dll issue in old 4.44 setup and workarounds missing rapps-progress-dialog)

2 years ago[CDFS_NEW] Fix diff
Pierre Schweitzer [Tue, 7 Nov 2017 06:54:15 +0000 (07:54 +0100)]
[CDFS_NEW] Fix diff

2 years ago[RAPPS-DB] CORE-13947 IrfanView 4.44 fix download URL
Joachim Henze [Tue, 7 Nov 2017 01:50:24 +0000 (02:50 +0100)]
[RAPPS-DB] CORE-13947 IrfanView 4.44 fix download URL

2 years ago[NTOSKRNL] Make the CcWaitForCurrentLazyWriterActivity() stub return success instead...
Pierre Schweitzer [Mon, 6 Nov 2017 20:45:55 +0000 (21:45 +0100)]
[NTOSKRNL] Make the CcWaitForCurrentLazyWriterActivity() stub return success instead of hacking FSDs.
Suggested by Thomas

2 years ago[CDFS_NEW] Add a hack that allows locking a volume and thus, unmounting it. All that...
Pierre Schweitzer [Mon, 6 Nov 2017 19:09:23 +0000 (20:09 +0100)]
[CDFS_NEW] Add a hack that allows locking a volume and thus, unmounting it. All that work, just to be able to do this...

2 years ago[CDFS_NEW] You know... RBuild has been gone for ages!
Pierre Schweitzer [Mon, 6 Nov 2017 19:01:36 +0000 (20:01 +0100)]
[CDFS_NEW] You know... RBuild has been gone for ages!

2 years ago[CDFS_NEW] Add a CMakeFile and a registry file. When using both, you get a driver...
Pierre Schweitzer [Mon, 6 Nov 2017 18:58:49 +0000 (19:58 +0100)]
[CDFS_NEW] Add a CMakeFile and a registry file. When using both, you get a driver that builds and works in ROS. Could install ROS with it! :-)

2 years ago[CDFS_NEW] Remove a broken change (lol?!) that prevented the driver to properly work...
Pierre Schweitzer [Mon, 6 Nov 2017 18:55:34 +0000 (19:55 +0100)]
[CDFS_NEW] Remove a broken change (lol?!) that prevented the driver to properly work in ROS... Dropping SEH doesn't mean dropping code!

2 years ago[CDFS_NEW] Force calling convention to allow build
Pierre Schweitzer [Mon, 6 Nov 2017 18:52:43 +0000 (19:52 +0100)]
[CDFS_NEW] Force calling convention to allow build

2 years ago[CDFS_NEW] Force calling convention to allow build
Pierre Schweitzer [Mon, 6 Nov 2017 18:49:47 +0000 (19:49 +0100)]
[CDFS_NEW] Force calling convention to allow build

2 years ago[CDFS_NEW] Remove a no longer required build hack
Pierre Schweitzer [Mon, 6 Nov 2017 18:46:43 +0000 (19:46 +0100)]
[CDFS_NEW] Remove a no longer required build hack

2 years ago[CDFS_NEW] Remove a no longer required build hack
Pierre Schweitzer [Mon, 6 Nov 2017 18:44:13 +0000 (19:44 +0100)]
[CDFS_NEW] Remove a no longer required build hack

2 years ago[CDFS_NEW] Remove a no longer required build hack
Pierre Schweitzer [Mon, 6 Nov 2017 18:42:27 +0000 (19:42 +0100)]
[CDFS_NEW] Remove a no longer required build hack

2 years ago[CDFS_NEW] Fix headers inclusion so that it can work on a *nix platform
Pierre Schweitzer [Mon, 6 Nov 2017 18:38:01 +0000 (19:38 +0100)]
[CDFS_NEW] Fix headers inclusion so that it can work on a *nix platform

2 years agoUpdate pull request template with additional info
Alexander Shaposhnikov [Mon, 6 Nov 2017 17:28:12 +0000 (19:28 +0200)]
Update pull request template with additional info

2 years ago[RAPPS-DB] CORE-13965 downgrade to Miranda IM 0.10.21, because Miranda IM 0.10.48...
Joachim Henze [Mon, 6 Nov 2017 00:56:48 +0000 (01:56 +0100)]
[RAPPS-DB] CORE-13965 downgrade to Miranda IM 0.10.21, because Miranda IM 0.10.48 link is down and app was non-working before, dreimer gave ok to groom DB a bit

2 years ago[RAPPS] Reflect installation status it download dialog header.
Alexander Shaposhnikov [Sun, 5 Nov 2017 18:44:27 +0000 (20:44 +0200)]
[RAPPS] Reflect installation status it download dialog header.

Pointed out by Mark Jansen

2 years ago[SETUPAPI]: CM_Open_DevNode_Key_Ex: FIXME/ERR --> TRACE
Eric Kohl [Sun, 5 Nov 2017 16:55:25 +0000 (17:55 +0100)]
[SETUPAPI]: CM_Open_DevNode_Key_Ex: FIXME/ERR --> TRACE

2 years ago[SETUPAPI] GetDeviceInstanceKeyPath: Fix temporary buffer allocation, add missing...
Eric Kohl [Sun, 5 Nov 2017 16:31:34 +0000 (17:31 +0100)]
[SETUPAPI] GetDeviceInstanceKeyPath: Fix temporary buffer allocation, add missing code paths and fix registry paths.
This should fix parts of CORE-13944.

2 years ago[CDFS] Set the FO_CLEANUP_COMPLETE on cleanup
Pierre Schweitzer [Sun, 5 Nov 2017 12:47:58 +0000 (13:47 +0100)]
[CDFS] Set the FO_CLEANUP_COMPLETE on cleanup

2 years ago[CDFS] Don't allow FS opening when volume is locked
Pierre Schweitzer [Sun, 5 Nov 2017 09:59:49 +0000 (10:59 +0100)]
[CDFS] Don't allow FS opening when volume is locked

2 years ago[BROWSEUI] CBandSiteMenu
Stas'M [Wed, 1 Nov 2017 20:05:33 +0000 (23:05 +0300)]
[BROWSEUI] CBandSiteMenu

- Move SHGetFolder code to CreateBuiltInISFBand
- Get rid of CSIDL_FLAG_CREATE (Windows doesn't create Quick Launch
directory)
- Use ILFree since variables are reused now

2 years ago[CMAKE] Quick Launch shortcuts for Live/Hybrid CD
Stas'M [Wed, 1 Nov 2017 19:54:53 +0000 (22:54 +0300)]
[CMAKE] Quick Launch shortcuts for Live/Hybrid CD

2 years ago[SHORTCUTS.INF] Add shortcuts for Quick Launch
Stas'M [Wed, 1 Nov 2017 19:48:39 +0000 (22:48 +0300)]
[SHORTCUTS.INF] Add shortcuts for Quick Launch

2 years ago[SETUPAPI] Update some more functions to the current coding style, add annotations...
Eric Kohl [Sun, 5 Nov 2017 10:33:08 +0000 (11:33 +0100)]
[SETUPAPI] Update some more functions to the current coding style, add annotations and add function names to the TRACE calls.

2 years ago[SHELL32] SHBrowseForFolderW: Fix creating directories in the desktop and in drives...
Giannis Adamopoulos [Sun, 5 Nov 2017 10:09:42 +0000 (12:09 +0200)]
[SHELL32] SHBrowseForFolderW: Fix creating directories in the desktop and in drives like C: CORE-13925

2 years ago[SETUPAPI] GetDeviceInstanceKeyPath: Implement the CM_REGISTRY_SOFTWARE | CM_REGISTRY...
Eric Kohl [Sun, 5 Nov 2017 08:39:44 +0000 (09:39 +0100)]
[SETUPAPI] GetDeviceInstanceKeyPath: Implement the CM_REGISTRY_SOFTWARE | CM_REGISTRY_CONFIG part.

2 years ago[CDFS] Addendum to 03a9d8c: check for volume state (locked?) before opening a file
Pierre Schweitzer [Sat, 4 Nov 2017 20:31:35 +0000 (21:31 +0100)]
[CDFS] Addendum to 03a9d8c: check for volume state (locked?) before opening a file
CORE-13957

2 years ago[CDFS] Implement volume un/locking.
Pierre Schweitzer [Sat, 4 Nov 2017 20:29:51 +0000 (21:29 +0100)]
[CDFS] Implement volume un/locking.
CORE-13957

2 years ago[CDFS] Don't use uninit var. Fixes MSVC build (good boy :-))
Pierre Schweitzer [Sat, 4 Nov 2017 20:23:11 +0000 (21:23 +0100)]
[CDFS] Don't use uninit var. Fixes MSVC build (good boy :-))

2 years ago[SETUPAPI] CM_Open_DevNode_Key_Ex: Add support for remote registry access and the...
Eric Kohl [Sat, 4 Nov 2017 19:00:54 +0000 (20:00 +0100)]
[SETUPAPI] CM_Open_DevNode_Key_Ex: Add support for remote registry access and the Disposition parameter.

2 years ago[CDFS] Implement open handle count
Pierre Schweitzer [Sat, 4 Nov 2017 20:14:50 +0000 (21:14 +0100)]
[CDFS] Implement open handle count

2 years ago[CDFS] Remove the VPB field from the VCB. Not only it was never set, but the only...
Pierre Schweitzer [Sat, 4 Nov 2017 18:46:01 +0000 (19:46 +0100)]
[CDFS] Remove the VPB field from the VCB. Not only it was never set, but the only times it was used was broken!

2 years ago[SETUPAPI] Update some functions to the current coding style, add annotations and...
Eric Kohl [Sat, 4 Nov 2017 18:01:28 +0000 (19:01 +0100)]
[SETUPAPI] Update some functions to the current coding style, add annotations and add function names to the TRACE calls.

2 years ago[SETUPAPI] Start the implementation of CM_Open_DevNode_Key_Ex().
Eric Kohl [Sat, 4 Nov 2017 16:26:38 +0000 (17:26 +0100)]
[SETUPAPI] Start the implementation of CM_Open_DevNode_Key_Ex().

2 years ago[WIN32K] Check if the window being destroyed is currently tracked. (#103)
Mark Jansen [Sat, 4 Nov 2017 14:00:54 +0000 (15:00 +0100)]
[WIN32K] Check if the window being destroyed is currently tracked. (#103)

* [WIN32K] Check if the window being destroyed is currently tracked.
CORE-13619

2 years ago[DBGHELP] [XDK] [ARM64] Fix magic constant
Stas'M [Fri, 3 Nov 2017 16:48:19 +0000 (19:48 +0300)]
[DBGHELP] [XDK] [ARM64] Fix magic constant

2 years ago[USETUP][ROSAPPS][EXT2LIB] NtReadFile() calls: Remove unused 'ByteOffset = 0', Use... 100/head
Serge Gautherie [Wed, 1 Nov 2017 12:20:14 +0000 (13:20 +0100)]
[USETUP][ROSAPPS][EXT2LIB] NtReadFile() calls: Remove unused 'ByteOffset = 0', Use explicit NULL instead of ambiguous 0, Remove casts to same type. CORE-13910

2 years ago[FREELDR] Additional safety checks for PcMemGetBiosMemoryMap. CORE-13332 44/head
Serge Gautherie [Tue, 10 Oct 2017 01:39:44 +0000 (03:39 +0200)]
[FREELDR] Additional safety checks for PcMemGetBiosMemoryMap. CORE-13332

Cast MAX_BIOS_DESCRIPTORS to explicit ULONG from implicit int.
Comment/Add checks for PcMemoryMap/PcBiosMemoryMap arrays being full and bare handling of error cases.

2 years ago[REACTOS][FDEBUG] Remove unnecessary DLGPROC casts. 99/head
Thomas Faber [Tue, 31 Oct 2017 11:02:38 +0000 (12:02 +0100)]
[REACTOS][FDEBUG] Remove unnecessary DLGPROC casts.

2 years ago[CPL] Remove unnecessary DLGPROC casts.
Thomas Faber [Mon, 30 Oct 2017 23:37:37 +0000 (00:37 +0100)]
[CPL] Remove unnecessary DLGPROC casts.

2 years ago[SHELL32] SHBrowseForFolder: Fix creating a new folder (which was broken two years...
Giannis Adamopoulos [Fri, 3 Nov 2017 10:09:30 +0000 (12:09 +0200)]
[SHELL32] SHBrowseForFolder: Fix creating a new folder (which was broken two years ago and was properly reported 3 days ago). CORE-13925

2 years ago[COMCTL32] comctl32/propsheet: Fix redrawing of the static text elements.
Hermès Bélusca-Maïto [Thu, 2 Nov 2017 22:52:33 +0000 (23:52 +0100)]
[COMCTL32] comctl32/propsheet: Fix redrawing of the static text elements.

Partial revert of SVN r74136 (b1b4279): enforce the correct "color" for
the background of the static text elements: indeed, using a "transparent"
background kept instead the old window color, which was not correctly
repainted, unless you enforced a repaint by, e.g. moving away then back
the window, or moved something else on top of it.

Tested and approved by 'reactosfanboy'.
Was detected as a regression in the wizard of DVDWrite Now 1.5.12
Formatter GUI.

CORE-13929
CORE-12912

2 years ago[RDBSS] Fix a bug in RxQueryNameInfo(): don't only return name length, but also the...
Pierre Schweitzer [Thu, 2 Nov 2017 22:03:08 +0000 (23:03 +0100)]
[RDBSS] Fix a bug in RxQueryNameInfo(): don't only return name length, but also the whole structure. Avoids corruption

2 years ago[MSPAINT] Base dialog implementations on CDialogImpl
Benedikt Freisen [Wed, 1 Nov 2017 13:59:01 +0000 (14:59 +0100)]
[MSPAINT] Base dialog implementations on CDialogImpl

- Wrap implementation of Mirror/Rotate, Stretch/Skew and Attributes dialog in subclasses of CDialogImpl
- Turn global variables from code that was moved into member functions into member variables
- Add global instances of all three dialog classes
- Use <global instance>.DoModal(...) instead of one-line wrappers
- Replace some TCHAR arrays with CStrings

2 years ago[SHELL32] Fix multiple selection of desktop icons
Manuel Bachmann [Thu, 2 Nov 2017 18:55:03 +0000 (19:55 +0100)]
[SHELL32] Fix multiple selection of desktop icons

This fixes the following issue : when selecting multiple icons
on the desktop, and then right-clicking; the Properties sheet
would immediately be displayed, conflicting with the context
menu.

2 years ago[BROWSEUI] Add a todo comment block in CISFBand.cpp and CBandSite.cpp regarding some...
Giannis Adamopoulos [Thu, 2 Nov 2017 17:50:03 +0000 (19:50 +0200)]
[BROWSEUI] Add a todo comment block in CISFBand.cpp and CBandSite.cpp regarding some problems and missing features when using the quick launch toolbar. These two lists are not complete but cover most important problems of quick launch. There is no need to create bug reports for these.

2 years ago[ATL] Initial implementation of CAtlExeModuleT.
Mark Jansen [Sun, 22 Oct 2017 20:25:03 +0000 (22:25 +0200)]
[ATL] Initial implementation of CAtlExeModuleT.
CORE-13908

2 years ago[RDBSS] More capture
Pierre Schweitzer [Wed, 1 Nov 2017 14:12:08 +0000 (15:12 +0100)]
[RDBSS] More capture

2 years ago[RDBSS] Start defining the RxCapture* macros and start using them (to be continued)
Pierre Schweitzer [Wed, 1 Nov 2017 10:45:43 +0000 (11:45 +0100)]
[RDBSS] Start defining the RxCapture* macros and start using them (to be continued)

2 years ago[RXCE] Implement RxInitializeDebugSupport()
Pierre Schweitzer [Wed, 1 Nov 2017 10:20:28 +0000 (11:20 +0100)]
[RXCE] Implement RxInitializeDebugSupport()

2 years ago[RDBSS] Implement RxCheckFcbStructuresForAlignment()
Pierre Schweitzer [Wed, 1 Nov 2017 10:05:32 +0000 (11:05 +0100)]
[RDBSS] Implement RxCheckFcbStructuresForAlignment()

2 years ago[EXPLORER] -Rewrite taskbar settings routines and dialog
Giannis Adamopoulos [Mon, 30 Oct 2017 15:39:12 +0000 (17:39 +0200)]
[EXPLORER] -Rewrite taskbar settings routines and dialog
- Rewrite the taskbar settings and start menu settings property sheets.
- All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later.
- Implement toggling lock, autohide and always on top. The rest will be implemented later.

2 years ago[RDBSS] Implement RxQueryNameInfo() and RxConjureOriginalName()
Pierre Schweitzer [Tue, 31 Oct 2017 22:03:16 +0000 (23:03 +0100)]
[RDBSS] Implement RxQueryNameInfo() and RxConjureOriginalName()

2 years ago[RXCE] Implement RxAcquireExclusiveFcbResourceInMRx()
Pierre Schweitzer [Tue, 31 Oct 2017 20:34:36 +0000 (21:34 +0100)]
[RXCE] Implement RxAcquireExclusiveFcbResourceInMRx()

2 years ago[SERIAL] Fix Serial{Get,Clear}PerfStats() to become proper PKSYNCHRONIZE_ROUTINE...
Amine Khaldi [Tue, 31 Oct 2017 14:44:39 +0000 (15:44 +0100)]
[SERIAL] Fix Serial{Get,Clear}PerfStats() to become proper PKSYNCHRONIZE_ROUTINE routines and get rid of the related casts. Brought to you by Thomas Faber. CORE-11799 (#94)

2 years ago[XDK][DDK] Take the gcc path for __assert_annotation{A,W} and __CREATE_NTOS_DATA_IMPO...
Amine Khaldi [Tue, 31 Oct 2017 14:19:49 +0000 (15:19 +0100)]
[XDK][DDK] Take the gcc path for __assert_annotation{A,W} and __CREATE_NTOS_DATA_IMPORT_ALIAS when compiling with clang-cl. Include kdfuncs.h before rtlfuncs.h to have DbgPrint() defined before using it. CORE-11799 (#94)

2 years ago[LIB/ATL] Take the gcc code path for the unused macros when compiling with clang...
Amine Khaldi [Tue, 31 Oct 2017 13:44:07 +0000 (14:44 +0100)]
[LIB/ATL] Take the gcc code path for the unused macros when compiling with clang. CORE-11799 (#94)

2 years ago[STORPORT] Check status code of the call to PortFdoConnectInterrupt().
Eric Kohl [Tue, 31 Oct 2017 13:09:04 +0000 (14:09 +0100)]
[STORPORT] Check status code of the call to PortFdoConnectInterrupt().
CORE-13866

2 years ago[LIBXML2] Do not rely on nan() when compiling with clang. CORE-11799 (#94)
Amine Khaldi [Tue, 31 Oct 2017 13:10:03 +0000 (14:10 +0100)]
[LIBXML2] Do not rely on nan() when compiling with clang. CORE-11799 (#94)

2 years ago[XDK/NTBASEDEF] Use __builtin_offsetof to define FIELD_OFFSET when compiling with...
Amine Khaldi [Tue, 31 Oct 2017 12:54:41 +0000 (13:54 +0100)]
[XDK/NTBASEDEF] Use __builtin_offsetof to define FIELD_OFFSET when compiling with clang-cl. CORE-11799 (#94)

2 years ago[CRT/INTRIN] Use the gcc intrinsic equivalents when compiling with clang-cl and skip...
Amine Khaldi [Mon, 30 Oct 2017 21:51:00 +0000 (22:51 +0100)]
[CRT/INTRIN] Use the gcc intrinsic equivalents when compiling with clang-cl and skip the ones that are already supported/built-in. CORE-11799 (#94)

2 years ago[ACPICA] Take the gcc code path for host configuration when compiling with clang...
Amine Khaldi [Mon, 30 Oct 2017 21:45:42 +0000 (22:45 +0100)]
[ACPICA] Take the gcc code path for host configuration when compiling with clang. CORE-11799 (#94)

2 years ago[INCLUDE/REACTOS][LOCALMON][LOCALSPL][SPOOLSS] Add some missing VOIDs. CORE-11799...
Amine Khaldi [Mon, 30 Oct 2017 21:43:47 +0000 (22:43 +0100)]
[INCLUDE/REACTOS][LOCALMON][LOCALSPL][SPOOLSS] Add some missing VOIDs. CORE-11799 (#94)

2 years ago[LIBSAMPLERATE] Define exit() as __debugbreak(). CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 21:38:29 +0000 (22:38 +0100)]
[LIBSAMPLERATE] Define exit() as __debugbreak(). CORE-11799 (#94)

2 years ago[NMIDEBUG] Do not take the msvc codepath in NmiClearFlag(). CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 20:54:54 +0000 (21:54 +0100)]
[NMIDEBUG] Do not take the msvc codepath in NmiClearFlag(). CORE-11799 (#94)

2 years ago[SHELL32] Properly set case -714 as TBN_DRAGOUT. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 20:53:00 +0000 (21:53 +0100)]
[SHELL32] Properly set case -714 as TBN_DRAGOUT. CORE-11799 (#94)

2 years ago[BOOT/ENVIRON] Define the INT8 type as signed char. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 20:51:30 +0000 (21:51 +0100)]
[BOOT/ENVIRON] Define the INT8 type as signed char. CORE-11799 (#94)

2 years ago[SERIALUI] Set the stdcall calling convention for CommDlgProc() and make it return...
Amine Khaldi [Mon, 30 Oct 2017 20:48:49 +0000 (21:48 +0100)]
[SERIALUI] Set the stdcall calling convention for CommDlgProc() and make it return INT_PTR. CORE-11799 (#94)

2 years ago[SHELL32][REGEDIT][MSCONFIG_NEW] Correctly check for presence of list view sort header. 93/head
Thomas Faber [Fri, 27 Oct 2017 10:32:26 +0000 (12:32 +0200)]
[SHELL32][REGEDIT][MSCONFIG_NEW] Correctly check for presence of list view sort header.

2 years ago[NET] Add missing newlines to net utility output (#91)
Marian Schubert [Sun, 29 Oct 2017 20:38:05 +0000 (21:38 +0100)]
[NET] Add missing newlines to net utility output (#91)

Password last set and Password changeable lines were missing newlines.

2 years ago[KERNEL32] Fix a FIXME in WaitNamedPipeW(): allow waiting on a remote pipe
Pierre Schweitzer [Sun, 29 Oct 2017 19:34:49 +0000 (20:34 +0100)]
[KERNEL32] Fix a FIXME in WaitNamedPipeW(): allow waiting on a remote pipe

2 years ago[RTL] Revert b3b2a23 which introduced a regression.
Pierre Schweitzer [Sun, 29 Oct 2017 14:03:12 +0000 (15:03 +0100)]
[RTL] Revert b3b2a23 which introduced a regression.
Spotted by Jérome

2 years ago[KERNEL32] In GetLogicalDrives(), if NtQueryInformationProcess() call succeed, but...
Pierre Schweitzer [Sun, 29 Oct 2017 13:48:41 +0000 (14:48 +0100)]
[KERNEL32] In GetLogicalDrives(), if NtQueryInformationProcess() call succeed, but return drive map is empty, make sure returned error is success.
Patch by Alex Ionescu

2 years agoCID 1206831 Dereference after null check
Samuel Serapion [Fri, 20 Oct 2017 18:00:32 +0000 (14:00 -0400)]
CID 1206831 Dereference after null check

BytesRead is an optional out parameter and must be checked before being written to.

2 years ago[MOUNTMGR][NTOSKRNL] ZwWriteFile() calls: Use explicit NULL instead of ambiguous...
Serge Gautherie [Sat, 28 Oct 2017 15:02:24 +0000 (17:02 +0200)]
[MOUNTMGR][NTOSKRNL] ZwWriteFile() calls: Use explicit NULL instead of ambiguous 0. CORE-13910

2 years ago[RAPPS] Prevent download dialog placeholder from displaying
Alexander Shaposhnikov [Sat, 28 Oct 2017 20:44:17 +0000 (23:44 +0300)]
[RAPPS] Prevent download dialog placeholder from displaying

CORE-13915

2 years ago[EXPLORER] CSysPagerWnd: Notify the CTrayWindow to reposition its children only when...
Giannis Adamopoulos [Sat, 28 Oct 2017 19:09:44 +0000 (22:09 +0300)]
[EXPLORER] CSysPagerWnd: Notify the CTrayWindow to reposition its children only when the number of the icons shown in the notification area changes.

2 years ago[EXPLORER] Simplify how autohide is implemented
Giannis Adamopoulos [Sat, 28 Oct 2017 16:23:49 +0000 (19:23 +0300)]
[EXPLORER] Simplify how autohide is implemented
Do not change m_TrayRects when m_AutoHideOffset is changed. m_AutoHideOffset will be taken into account only while WM_WINDOWPOSCHANGING is processed

2 years ago[NTOS] Add missing brackets. Comment out some unused statements. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 14:19:17 +0000 (15:19 +0100)]
[NTOS] Add missing brackets. Comment out some unused statements. CORE-11799 (#94)

2 years ago[BROWSEUI][DEVMGR][EXPLORER][NTGDI][NTOBJSHEX][NTVDM][SETUPAPI] Remove/comment out...
Amine Khaldi [Sat, 28 Oct 2017 14:04:18 +0000 (15:04 +0100)]
[BROWSEUI][DEVMGR][EXPLORER][NTGDI][NTOBJSHEX][NTVDM][SETUPAPI] Remove/comment out some unused variables. CORE-11799 (#94)

2 years ago[SPOOLSV] Add some missing VOIDs. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 13:43:14 +0000 (14:43 +0100)]
[SPOOLSV] Add some missing VOIDs. CORE-11799 (#94)

2 years ago[GLU32] Add TrimRegion destructor when compiling with clang-cl. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 13:06:01 +0000 (14:06 +0100)]
[GLU32] Add TrimRegion destructor when compiling with clang-cl. CORE-11799 (#94)

2 years ago[OPENGL32] Set the stdcall calling convention for wglGetDHGLRC(). CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 12:56:32 +0000 (13:56 +0100)]
[OPENGL32] Set the stdcall calling convention for wglGetDHGLRC(). CORE-11799 (#94)

2 years ago[UDFS] Do not take some of the msvc codepaths when compiling with clang-cl due to...
Amine Khaldi [Sat, 28 Oct 2017 12:52:44 +0000 (13:52 +0100)]
[UDFS] Do not take some of the msvc codepaths when compiling with clang-cl due to issues such as inline assembly support. CORE-11799 (#94)

2 years ago[NTDLL][NTUSER][SPOOLSS][WINSPOOL] Add some missing VOIDs. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 12:46:11 +0000 (13:46 +0100)]
[NTDLL][NTUSER][SPOOLSS][WINSPOOL] Add some missing VOIDs. CORE-11799 (#94)

2 years ago[CRT/INTRIN] Use __forceinline for __INTRIN_INLINE in the clang case. CORE-11799...
Amine Khaldi [Sat, 28 Oct 2017 12:34:43 +0000 (13:34 +0100)]
[CRT/INTRIN] Use __forceinline for __INTRIN_INLINE in the clang case. CORE-11799 (#94)

2 years ago[CRT] fix bug in _rotr implementation
zefklop [Sat, 28 Oct 2017 08:28:27 +0000 (10:28 +0200)]
[CRT] fix bug in _rotr implementation

2 years ago[INCLUDE/WINE] Use __builtin_ffs in the clang-cl build. CORE-11799 (#94)
Amine Khaldi [Fri, 27 Oct 2017 22:55:59 +0000 (23:55 +0100)]
[INCLUDE/WINE] Use __builtin_ffs in the clang-cl build. CORE-11799 (#94)

2 years ago[SHELL32] Remove some unused members and comment out some unused Wine code. CORE...
Amine Khaldi [Fri, 27 Oct 2017 22:51:44 +0000 (23:51 +0100)]
[SHELL32] Remove some unused members and comment out some unused Wine code. CORE-11799 (#94)

2 years ago[MSAFD] Properly define SockAsyncThread() and avoid the cast. CORE-11799 (#94)
Amine Khaldi [Fri, 27 Oct 2017 22:47:30 +0000 (23:47 +0100)]
[MSAFD] Properly define SockAsyncThread() and avoid the cast. CORE-11799 (#94)

2 years ago[SHSVCS] Add missing VOID. CORE-11799 (#94)
Amine Khaldi [Fri, 27 Oct 2017 22:42:40 +0000 (23:42 +0100)]
[SHSVCS] Add missing VOID. CORE-11799 (#94)