reactos.git
5 weeks ago[NTOS:PNP] Reduce the default buffer size in EnumerateDevices. CORE-15882 1719/head
Thomas Faber [Sat, 20 Apr 2019 08:49:13 +0000 (10:49 +0200)]
[NTOS:PNP] Reduce the default buffer size in EnumerateDevices. CORE-15882

5 weeks ago[NTOS:PNP] Handle arbitrary subkey name lengths in EnumerateDevices. CORE-15882
Thomas Faber [Sat, 20 Apr 2019 08:48:43 +0000 (10:48 +0200)]
[NTOS:PNP] Handle arbitrary subkey name lengths in EnumerateDevices. CORE-15882

This also makes it necessary to fix a bug in the previous code:
ZwEnumerateKey will not account for space for a null terminator, so to
ensure we have space, we must allocate the additional WCHAR, but not
include it in the buffer size passed to the function.

6 weeks ago[SHELL32] Fix SHCreateDirectoryExW showing an error on success
Mark Jansen [Tue, 9 Jul 2019 20:52:17 +0000 (22:52 +0200)]
[SHELL32] Fix SHCreateDirectoryExW showing an error on success
CORE-15145

6 weeks ago[MEDIA][FONTS] Add Cyrillic MS Sans Serif (sserifer.fon)
Katayama Hirofumi MZ [Tue, 9 Jul 2019 03:56:09 +0000 (12:56 +0900)]
[MEDIA][FONTS] Add Cyrillic MS Sans Serif (sserifer.fon)

6 weeks ago[SETUPAPI] CM_Delete_DevNode_Key[_Ex]: Use DEVINST instead of DEVNODE because we...
Eric Kohl [Sun, 7 Jul 2019 22:08:22 +0000 (00:08 +0200)]
[SETUPAPI] CM_Delete_DevNode_Key[_Ex]: Use DEVINST instead of DEVNODE because we are using DEVINST anywhere else.

6 weeks ago[SETUPAPI] CMP_RegisterNotification: When a window is registered, pass the window...
Eric Kohl [Sun, 7 Jul 2019 21:46:25 +0000 (23:46 +0200)]
[SETUPAPI] CMP_RegisterNotification: When a window is registered, pass the window text to PNP_RegisterNotification().

6 weeks ago[WIN32SS][FREETYPE] Fix performance regression FreeBASIC console output CORE-16177
Joachim Henze [Sun, 7 Jul 2019 18:50:30 +0000 (20:50 +0200)]
[WIN32SS][FREETYPE] Fix performance regression FreeBASIC console output CORE-16177

By restoring historic state of GreExtTextOutW() / IntExtTextOutW()

This reverts guilty rev 0.4.12-dev-190-g
d6cfeaef5105dc6db2f12682bc48f17f9caacdcc
as well as some follow ups that dealt with new errors popping up afterwards.
The revert got ack of Katayama Hirofumi MZ.

Test VBox on master: https://reactos.org/testman/compare.php?ids=68471,68475
Test KVM on master: https://reactos.org/testman/compare.php?ids=68472,68476

Analog revert was applied before to 0.4.12-RC-42-g
021f498cb2bf50ea210696431786d24536da2691

6 weeks ago[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available... 1688/head
Bișoc George [Mon, 24 Jun 2019 16:45:52 +0000 (18:45 +0200)]
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. (#1688)

CORE-12313

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
6 weeks ago[SHELL32] Recycle-Bin: Minor code enhancements.
Hermès Bélusca-Maïto [Sun, 7 Jul 2019 13:57:01 +0000 (15:57 +0200)]
[SHELL32] Recycle-Bin: Minor code enhancements.

- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.

6 weeks ago[CMAKE] Disable INIT section ld scripts for now. CORE-16183 ROSBE-154
Thomas Faber [Sun, 7 Jul 2019 14:06:25 +0000 (16:06 +0200)]
[CMAKE] Disable INIT section ld scripts for now. CORE-16183 ROSBE-154

6 weeks ago[SHELL32] Enable the "Apply" button when user takes action on the edit box control...
Bișoc George [Sun, 7 Jul 2019 12:47:44 +0000 (14:47 +0200)]
[SHELL32] Enable the "Apply" button when user takes action on the edit box control (#1720)

CORE-12312

6 weeks ago[SETUPAPI][UMPNPMGR] The 3rd parameter of PNP_RegisterNotification() seems to be...
Eric Kohl [Sun, 7 Jul 2019 11:41:00 +0000 (13:41 +0200)]
[SETUPAPI][UMPNPMGR] The 3rd parameter of PNP_RegisterNotification() seems to be the service name

6 weeks ago[W32TIME] Implement w32time service. CORE-13001 1361/head
Doug Lyons [Sun, 7 Jul 2019 08:59:11 +0000 (10:59 +0200)]
[W32TIME] Implement w32time service. CORE-13001

6 weeks ago[TIMEDATE] Allow editing the time server combo box. CORE-13001
Doug Lyons [Sat, 10 Feb 2018 21:43:21 +0000 (15:43 -0600)]
[TIMEDATE] Allow editing the time server combo box. CORE-13001

6 weeks ago[TIMEDATE] Handle manual time server entry. CORE-13001
Doug Lyons [Sat, 10 Feb 2018 21:47:04 +0000 (15:47 -0600)]
[TIMEDATE] Handle manual time server entry. CORE-13001

6 weeks ago[TIMEDATE] Use w32time compatible registry settings. CORE-13001
Doug Lyons [Sat, 21 Apr 2018 06:13:27 +0000 (08:13 +0200)]
[TIMEDATE] Use w32time compatible registry settings. CORE-13001

6 weeks ago[W32TIME] Implement a rudimentary version of W32TimeSyncNow. CORE-13001
Thomas Faber [Sun, 3 Jun 2018 14:28:57 +0000 (16:28 +0200)]
[W32TIME] Implement a rudimentary version of W32TimeSyncNow. CORE-13001

6 weeks ago[TIMEDATE] Avoid the use of DisplayWin32Error in time sync utility functions. CORE...
Thomas Faber [Sun, 3 Jun 2018 13:35:42 +0000 (15:35 +0200)]
[TIMEDATE] Avoid the use of DisplayWin32Error in time sync utility functions. CORE-13001

6 weeks ago[TIMEDATE] Separate time sync functions out into their own file. CORE-13001
Thomas Faber [Sun, 3 Jun 2018 10:33:24 +0000 (12:33 +0200)]
[TIMEDATE] Separate time sync functions out into their own file. CORE-13001

This is in preparation for the w32time service, and based on
work by Doug Lyons.

6 weeks ago[NDIS] INIT/PAGE sections must be uppercase. 1712/head
Thomas Faber [Sun, 7 Jul 2019 06:22:16 +0000 (08:22 +0200)]
[NDIS] INIT/PAGE sections must be uppercase.

6 weeks ago[PCI] The INIT section must be uppercase.
Thomas Faber [Fri, 5 Jul 2019 15:38:04 +0000 (17:38 +0200)]
[PCI] The INIT section must be uppercase.

6 weeks ago[CMAKE] Ensure the INIT section is placed at the end of a module. CORE-14683
Thomas Faber [Sat, 29 Jun 2019 17:24:28 +0000 (19:24 +0200)]
[CMAKE] Ensure the INIT section is placed at the end of a module. CORE-14683

For MSVC, marking the section as discardable will do this automatically.
For GCC, we use a linker script that places it after the .reloc section
(which should be the last "real" section, check ld --verbose output for the
default linker script).

This fixes what seems to be a regression from r55835 (!).

6 weeks ago[USER32] Switch to only one window (Alt+Tab) (#1718)
Katayama Hirofumi MZ [Sun, 7 Jul 2019 00:05:10 +0000 (09:05 +0900)]
[USER32] Switch to only one window (Alt+Tab) (#1718)

Fix app switcher (Alt+Tab)'s behavior when there is only one app window. CORE-16176

6 weeks ago[CRT] Remove mingwm10.dll usage in tls support code 1715/head
Mark Jansen [Thu, 4 Jul 2019 21:06:51 +0000 (23:06 +0200)]
[CRT] Remove mingwm10.dll usage in tls support code
CORE-15491

6 weeks ago[NTOS:MM] Fix MmSizeOfSystemCacheInPages value on AMD64
Serge Gautherie [Fri, 21 Jun 2019 12:04:01 +0000 (14:04 +0200)]
[NTOS:MM] Fix MmSizeOfSystemCacheInPages value on AMD64

And add 'ASSERT(MmSystemCacheEnd == ...);'.

Addendum to d56a24908908b574852091af0b8bd9dca7bc1165.
CORE-14259

6 weeks ago[FLOPPY_NEW] Fix MSVC builds
Serge Gautherie [Sat, 6 Jul 2019 07:39:03 +0000 (09:39 +0200)]
[FLOPPY_NEW] Fix MSVC builds

6 weeks ago[IPHLPAPI] Use if_descrlen field for determining the length of
Victor Perevertkin [Sun, 30 Jun 2019 12:34:46 +0000 (15:34 +0300)]
[IPHLPAPI] Use if_descrlen field for determining the length of
if_descr in IFEntry structure. This fixes heap corruption on GCC8.
CORE-16088

6 weeks ago[PORTCLS] Zero memory in operator new. CORE-16157
Thomas Faber [Fri, 5 Jul 2019 15:26:16 +0000 (17:26 +0200)]
[PORTCLS] Zero memory in operator new. CORE-16157

Fixes a regression from 99fa38809fd8ed38d4d59fa1fcf3babb3216b895, which
replaced the kcom.h/stdunk.h versions (which zero memory) with local
implementations (which don't).

Standard C++ does not guarantee that memory is zeroed but several classes
rely on this, in particular for their m_Ref and m_bInitialized members.

Ideally the constructors should be fixed to initialize all required members,
but that task is error-prone so for now we simply restore the previous
behavior.

6 weeks ago[GDI32_APITEST] Improve SetWorldTransform testcase (#1717)
Katayama Hirofumi MZ [Fri, 5 Jul 2019 13:31:56 +0000 (22:31 +0900)]
[GDI32_APITEST] Improve SetWorldTransform testcase (#1717)

Improve the testcase for gdi32!SetWorldTransform function. CORE-15554

6 weeks ago[FASTFAT_NEW] Fix MSVC builds
Serge Gautherie [Thu, 4 Jul 2019 19:16:12 +0000 (21:16 +0200)]
[FASTFAT_NEW] Fix MSVC builds

CORE-14879

6 weeks agoFix FUNDING.yml syntax.
Colin Finck [Thu, 4 Jul 2019 07:12:50 +0000 (09:12 +0200)]
Fix FUNDING.yml syntax.

6 weeks agoUpdate FUNDING.yml now that the "Sponsor" button in GitHub has been activated.
Colin Finck [Thu, 4 Jul 2019 07:11:04 +0000 (09:11 +0200)]
Update FUNDING.yml now that the "Sponsor" button in GitHub has been activated.

6 weeks ago[KMTESTS:CC] Make buffer mapping tests more accurate
Pierre Schweitzer [Wed, 3 Jul 2019 19:38:37 +0000 (21:38 +0200)]
[KMTESTS:CC] Make buffer mapping tests more accurate

7 weeks ago[SHELL32][USERENV] Improve Russian translation (#1710)
Stanislav Motylkov [Mon, 1 Jul 2019 19:43:22 +0000 (22:43 +0300)]
[SHELL32][USERENV] Improve Russian translation (#1710)

CORE-16170

7 weeks ago[NTOS:CC] CcWriteVirtualAddress(): Do not round 'Size'
Serge Gautherie [Wed, 19 Jun 2019 04:54:02 +0000 (06:54 +0200)]
[NTOS:CC] CcWriteVirtualAddress(): Do not round 'Size'

Revert 'Properly align VACB writes' part of 2a80ae2bb6fdb4135d41244335caa2dadb6c8fa9.

CORE-15384 CORE-16018

7 weeks ago[WIN32SS][GDI] Improve stub for EngQueryDeviceAttribute
Bernhard Feichtinger [Mon, 22 Apr 2019 19:12:53 +0000 (21:12 +0200)]
[WIN32SS][GDI] Improve stub for EngQueryDeviceAttribute

7 weeks ago[REACTOS] Finally enable the LUID mapped devices
Pierre Schweitzer [Tue, 25 Jun 2019 20:14:23 +0000 (22:14 +0200)]
[REACTOS] Finally enable the LUID mapped devices

This allows users to have their own locally mapped DOS devices.
For instance, when a network drive is mapped, it is now mapped in the
user device maps and no longer in the global device map.
This avoids sharing mount points system wide whereas they shouldn't.

LUID mapped devices is the default W2K3 behavior.
Globally mapped devices can be restored by adding back this registry key.

https://twitter.com/HeisSpiter/status/1143615176450686976

CORE-16114

7 weeks ago[NTOSKRNL] When looping again in ObpLookupEntryDirectory, properly init root entry
Pierre Schweitzer [Tue, 25 Jun 2019 20:09:54 +0000 (22:09 +0200)]
[NTOSKRNL] When looping again in ObpLookupEntryDirectory, properly init root entry

This fixes looking in global directory for DOS drives that are globally mounted
(such as C: drive)

CORE-16114

7 weeks ago[BASESRV] Implement LUID mapped drive arrival/removal notification
Pierre Schweitzer [Thu, 20 Jun 2019 07:00:07 +0000 (09:00 +0200)]
[BASESRV] Implement LUID mapped drive arrival/removal notification

CORE-16114

7 weeks ago[SDK] Add RtlInitString to the NDK
Pierre Schweitzer [Thu, 20 Jun 2019 06:56:05 +0000 (08:56 +0200)]
[SDK] Add RtlInitString to the NDK

7 weeks ago[NTOSKRNL] Implement support for device maps in ObpLookupObjectName
Pierre Schweitzer [Thu, 20 Jun 2019 06:55:31 +0000 (08:55 +0200)]
[NTOSKRNL] Implement support for device maps in ObpLookupObjectName

This allows getting rid of the ?? hack in the kernel but this doesn't
allow enabling LUID device maps as ReactOS can no longer open a
session with them enabled. So, we must remain with device maps at
root

CORE-16114

7 weeks ago[KMTESTS:OB] Add support for LUID mappings being disabled in ObSecurity tests
Pierre Schweitzer [Thu, 20 Jun 2019 06:53:27 +0000 (08:53 +0200)]
[KMTESTS:OB] Add support for LUID mappings being disabled in ObSecurity tests

CORE-16114

7 weeks ago[SDK] Properly define ZwQueryInformationProcess
Thomas Faber [Thu, 20 Jun 2019 06:45:24 +0000 (08:45 +0200)]
[SDK] Properly define ZwQueryInformationProcess

7 weeks ago[MEDIA][FONTS] Disable sserife.fon font file
Katayama Hirofumi MZ [Sun, 30 Jun 2019 20:17:29 +0000 (05:17 +0900)]
[MEDIA][FONTS] Disable sserife.fon font file

7 weeks ago[DSOUND_NEW] Add CMakeLists.txt + mostly fix gcc compilation
Oleg Dubinskiy [Thu, 20 Jun 2019 09:37:00 +0000 (12:37 +0300)]
[DSOUND_NEW] Add CMakeLists.txt + mostly fix gcc compilation

7 weeks ago[FASTFAT] Fix use after free when volume is unmounted
Timo Kreuzer [Tue, 25 Jun 2019 19:03:14 +0000 (21:03 +0200)]
[FASTFAT] Fix use after free when volume is unmounted

7 weeks ago[NETSTAT] ShowUdpTable(): Fix "tcp" copypasta
Serge Gautherie [Sat, 29 Jun 2019 08:54:19 +0000 (10:54 +0200)]
[NETSTAT] ShowUdpTable(): Fix "tcp" copypasta

7 weeks ago[MEDIA][FONTS] Improve MS Sans Serif (sserife.fon) (#1703)
Katayama Hirofumi MZ [Sun, 30 Jun 2019 06:34:30 +0000 (15:34 +0900)]
[MEDIA][FONTS] Improve MS Sans Serif (sserife.fon) (#1703)

12pt Q.
14pt j and t.

7 weeks ago[MEDIA][FONTS] Rename khmzsser.fon as sserife.fon (#1703)
Katayama Hirofumi MZ [Sun, 30 Jun 2019 05:50:07 +0000 (14:50 +0900)]
[MEDIA][FONTS] Rename khmzsser.fon as sserife.fon (#1703)

7 weeks ago[MEDIA][FONTS] Add 'KHMZ Sans Serif' (khmzsser.fon) font (#1703)
Katayama Hirofumi MZ [Sun, 30 Jun 2019 04:26:05 +0000 (13:26 +0900)]
[MEDIA][FONTS] Add 'KHMZ Sans Serif' (khmzsser.fon) font (#1703)

Add a raster font file khmzsser.fon (KHMZ Sans Serif). CORE-15130

7 weeks ago[UMPNPMGR] PNP_RegisterNotification: Add notification filter parameter checks
Eric Kohl [Sat, 29 Jun 2019 15:52:56 +0000 (17:52 +0200)]
[UMPNPMGR] PNP_RegisterNotification: Add notification filter parameter checks

7 weeks ago[NETSTAT] Simplify some code; don't use exit(); call WSACleanup() on exit.
Hermès Bélusca-Maïto [Sat, 29 Jun 2019 16:10:43 +0000 (18:10 +0200)]
[NETSTAT] Simplify some code; don't use exit(); call WSACleanup() on exit.

7 weeks ago[NETSTAT] Formatting; use _wsystem() call; do not hardcode buffer lengths.
Hermès Bélusca-Maïto [Sat, 29 Jun 2019 15:05:43 +0000 (17:05 +0200)]
[NETSTAT] Formatting; use _wsystem() call; do not hardcode buffer lengths.

7 weeks ago[NETSTAT] Fix TCP/UDP output. (#1696) 1696/head
Alexey Gorgurov [Fri, 28 Jun 2019 20:15:00 +0000 (23:15 +0300)]
[NETSTAT] Fix TCP/UDP output. (#1696)
CORE-16151

The underlying StringCchPrintfW() function must use %S for CHAR strings
and %s for wide chars.
See
https://docs.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=vs-2019
for details.

7 weeks ago[TRANSLATIONS] Add/Update Portuguese (neutral) translations. (#1687) 1687/head
Jose Carlos Jesus [Sat, 22 Jun 2019 13:26:40 +0000 (14:26 +0100)]
[TRANSLATIONS] Add/Update Portuguese (neutral) translations. (#1687)

Translations for SYSDM.CPL, SETUPAPI, SHELL32, LSASRV, SAMSRV, SYSSETUP,
USRMGR, THEMEUI, USERENV, WININET, MSCONFIG.

7 weeks ago[UMPNPMGR][SETUPAPI] PNP_RegisterNotification() has got 9 parameters.
Eric Kohl [Sat, 29 Jun 2019 11:38:42 +0000 (13:38 +0200)]
[UMPNPMGR][SETUPAPI] PNP_RegisterNotification() has got 9 parameters.

7 weeks ago[SDK] Fix build with sal.h
Timo Kreuzer [Sun, 23 Jun 2019 13:41:26 +0000 (15:41 +0200)]
[SDK] Fix build with sal.h

* sal.h: add file header, uncomment _Interlocked_operand_ and PAL_STDCPP_COMPAT guard
* When including stl headers, define PAL_STDCPP_COMPAT

7 weeks ago[PSDK] Add sal.h from Microsoft GitHub (MIT license)
Timo Kreuzer [Sun, 23 Jun 2019 12:45:46 +0000 (14:45 +0200)]
[PSDK] Add sal.h from Microsoft GitHub (MIT license)

7 weeks ago[SDK] Move kcom.h from psdk to ddk where it belongs
Timo Kreuzer [Sat, 25 May 2019 12:24:07 +0000 (14:24 +0200)]
[SDK] Move kcom.h from psdk to ddk where it belongs

7 weeks ago[User32] Sync Port Wine.
jimtabor [Sat, 29 Jun 2019 03:22:49 +0000 (22:22 -0500)]
[User32] Sync Port Wine.

Patch :
Nikolay Sivov : Use correct brush color for centered image background.
Nikolay Sivov : Remove confusing comments.

7 weeks ago[User32] Sync Port Wine.
jimtabor [Sat, 29 Jun 2019 02:52:04 +0000 (21:52 -0500)]
[User32] Sync Port Wine.

Patch :
Vijay Kiran Kamuju : Add DlgDirList wildcard checks.
Nikolay Sivov : Fix setting negative dialog item ids.
Alistair Leslie-Hughes : Don't reset focus if current dialog is a child.
Dmitry Timoshkov : If there is no dialog controls to set focus to then
set focus to dialog itself.
Zhiyi Zhang : Send notification for the focused button in
IsDialogMessage().
Huw Davies : Avoid using the comma operator in a while condition.

Patch skipped : a525631920d74e9d797f38305b89e63aed1c5c41 : Scale dialog
base units based on DPI awareness.

7 weeks ago[SDK] Add missing definitions
Pierre Schweitzer [Fri, 28 Jun 2019 20:11:54 +0000 (22:11 +0200)]
[SDK] Add missing definitions

This fixes storport build

7 weeks ago[STORPORT] Improvements to the device enumerator code.
Eric Kohl [Thu, 27 Jun 2019 21:05:46 +0000 (23:05 +0200)]
[STORPORT] Improvements to the device enumerator code.

- Create PDO for the device
- Send a SCSIOP_INQUIRY command to the new PDO
- Delete the PDO if the inquiry command failed

7 weeks ago[LIBPNG] Update to version 1.6.37. CORE-16147
Thomas Faber [Thu, 27 Jun 2019 09:09:58 +0000 (11:09 +0200)]
[LIBPNG] Update to version 1.6.37. CORE-16147

7 weeks ago[MBEDTLS] Update to version 2.7.11. CORE-16147
Thomas Faber [Thu, 27 Jun 2019 09:04:40 +0000 (11:04 +0200)]
[MBEDTLS] Update to version 2.7.11. CORE-16147

7 weeks ago[DOC] Fix ACPICA version. CORE-16138
Thomas Faber [Thu, 27 Jun 2019 09:10:55 +0000 (11:10 +0200)]
[DOC] Fix ACPICA version. CORE-16138

7 weeks ago[ATL] Add CRect::PtInRect
Mark Jansen [Sat, 1 Jun 2019 11:53:04 +0000 (13:53 +0200)]
[ATL] Add CRect::PtInRect

8 weeks ago[NTOS:MM] Fix MiLocateKernelSections() and MmMakeKernelResourceSectionWritable().
Hermès Bélusca-Maïto [Tue, 25 Jun 2019 22:46:52 +0000 (00:46 +0200)]
[NTOS:MM] Fix MiLocateKernelSections() and MmMakeKernelResourceSectionWritable().

- MiLocateKernelSections(): Fix the calculation of MiKernelResourceEndPte,
  MmPoolCodeEnd and MmPteCodeEnd.

- MmMakeKernelResourceSectionWritable(): Fix PTE looping upper limit;
  use MI_MAKE_HARDWARE_PTE_KERNEL to build the updated read-write PTE.

8 weeks ago[FREELDR] Fix Release build
Victor Perevertkin [Tue, 25 Jun 2019 21:56:21 +0000 (00:56 +0300)]
[FREELDR] Fix Release build

8 weeks ago[NTOS:KE/MM] Some bug-fixes in the bugcheck code.
Hermès Bélusca-Maïto [Tue, 25 Jun 2019 18:45:23 +0000 (20:45 +0200)]
[NTOS:KE/MM] Some bug-fixes in the bugcheck code.

- Introduce the MmMakeKernelResourceSectionWritable() helper for
  making the kernel resource memory section writable, and use it
  in KeGetBugMessageText(). Indeed, this latter function patches
  in place the bugcheck resource message to trim any trailing
  newlines before displaying the message on screen.

  See also https://github.com/osresearch/uxen/blob/83bad53/dm/introspection-win7.c#L286
  that mentions it too.

  This fixes bugcheck text display (e.g. the MANUALLY_INITIATED_CRASH one)
  when using (at least) MSVC-built ReactOS, avoiding a Page-Fault
  exception during the bugcheck.

- Cover KeGetBugMessageText() in SEH since we are accessing kernel
  resources that could also be corrupted in bugcheck scenarii, and we
  don't want to further bugcheck.

- Fix newline trimming loop.

- KiDoBugCheckCallbacks():
  * Wrap the bugcheck CallbackRoutine call in SEH.
  * Add a FIXME concerning the need of further memory validation of CurrentRecord.

- Add a FIXME concerning the need to run the bugcheck-reason callbacks
  with the KbCallbackReserved1 reason, in KeBugCheckWithTf().
  Mentioned in http://blog.ptsecurity.com/2012/06/customizing-blue-screen-of-death.html

8 weeks ago[NTOS] Minor formatting enhancements only + typo fixes.
Hermès Bélusca-Maïto [Tue, 25 Jun 2019 18:43:24 +0000 (20:43 +0200)]
[NTOS] Minor formatting enhancements only + typo fixes.

8 weeks ago[USBSTOR] Do not print device descriptor by default.
Victor Perevertkin [Tue, 25 Jun 2019 16:04:20 +0000 (19:04 +0300)]
[USBSTOR] Do not print device descriptor by default.
Add SrbGetCdb macro

8 weeks ago[USBOHCI_NEW] Rename counter-intuitive field of Transfer Descriptor
Victor Perevertkin [Tue, 25 Jun 2019 12:14:21 +0000 (15:14 +0300)]
[USBOHCI_NEW] Rename counter-intuitive field of Transfer Descriptor

8 weeks ago[USBOHCI_NEW] Zero out the transfer descriptor right after allocation.
Victor Perevertkin [Tue, 25 Jun 2019 12:03:26 +0000 (15:03 +0300)]
[USBOHCI_NEW] Zero out the transfer descriptor right after allocation.
Cleaned up transfer routines and added some more docs.

8 weeks ago[USBOHCI_NEW] Simplify the MapTransferToTD routine and add some docs
Victor Perevertkin [Tue, 25 Jun 2019 10:02:35 +0000 (13:02 +0300)]
[USBOHCI_NEW] Simplify the MapTransferToTD routine and add some docs

8 weeks ago[UNIATA] Update to version 0.47a. CORE-15930
Thomas Faber [Tue, 25 Jun 2019 07:05:43 +0000 (09:05 +0200)]
[UNIATA] Update to version 0.47a. CORE-15930

8 weeks ago[ACPICA] Update to version 20190509. CORE-16138
Thomas Faber [Tue, 25 Jun 2019 06:58:25 +0000 (08:58 +0200)]
[ACPICA] Update to version 20190509. CORE-16138

8 weeks ago[RTL] Fix failure check in RtlpCreateCriticalSectionSem.
Thomas Faber [Tue, 25 Jun 2019 06:58:11 +0000 (08:58 +0200)]
[RTL] Fix failure check in RtlpCreateCriticalSectionSem.

8 weeks ago[CMIDRIVER] Try to fix build 3
Timo Kreuzer [Tue, 25 Jun 2019 07:04:59 +0000 (09:04 +0200)]
[CMIDRIVER] Try to fix build 3

8 weeks ago[FREELDR] Always change video mode back to text-mode before starting up ReactOS. 1653/head
Yaroslav Kibysh [Thu, 13 Jun 2019 19:26:42 +0000 (22:26 +0300)]
[FREELDR] Always change video mode back to text-mode before starting up ReactOS.
CORE-16116

- This allows getting the /NOGUIBOOT mode working correctly, as the latter
  expects text-mode. Then, usetup (via BLUE driver) will change to a
  different text-mode, or, GUI boot will change (via BOOTVID) to VGA
  640*480 16-color.

- Always hide the VGA cursor.

- Remove also the deprecated boolean "Setup" in the *PrepareForReactOS()
  functions.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
8 weeks ago[BLUE] Initialize the console with a default font for codepage 437.
Hermès Bélusca-Maïto [Tue, 25 Jun 2019 00:21:25 +0000 (02:21 +0200)]
[BLUE] Initialize the console with a default font for codepage 437.

8 weeks ago[CMIDRIVER] Try to fix build 2
Timo Kreuzer [Mon, 24 Jun 2019 22:54:00 +0000 (00:54 +0200)]
[CMIDRIVER] Try to fix build 2

8 weeks ago[CMIDRIVER] Try to fix build
Timo Kreuzer [Mon, 24 Jun 2019 22:26:08 +0000 (00:26 +0200)]
[CMIDRIVER] Try to fix build

8 weeks ago[STDUNK][PORTCLS][CMIDriver] Fix issue with operator new/delete
Timo Kreuzer [Sat, 25 May 2019 10:22:04 +0000 (12:22 +0200)]
[STDUNK][PORTCLS][CMIDriver] Fix issue with operator new/delete

Fix for MSVC warning "C2323: 'operator new': non-member operator new or delete functions may not be declared static or in a namespace other than the global namespace."

See https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-what-s-new-2003-through-2015?view=vs-2019 section "Overloaded operator new and operator delete"

8 weeks ago[GDI32_APITEST] Extend test for SetWorldTransform (#1686)
Timo Kreuzer [Mon, 24 Jun 2019 19:16:10 +0000 (21:16 +0200)]
[GDI32_APITEST] Extend test for SetWorldTransform (#1686)

8 weeks ago[WIN32SS][NTGDI] Strictly check in XFORMOBJ_iSetXform (#1676)
Katayama Hirofumi MZ [Mon, 24 Jun 2019 12:32:40 +0000 (21:32 +0900)]
[WIN32SS][NTGDI] Strictly check in XFORMOBJ_iSetXform (#1676)

Check if the determinant of the given transformation matrix is non-zero. If zero, the function returns DDI_ERROR without change. CORE-15554

8 weeks ago[BOOTVID] Diverse enhancements.
Hermès Bélusca-Maïto [Sun, 23 Jun 2019 19:05:28 +0000 (21:05 +0200)]
[BOOTVID] Diverse enhancements.

- Import cmdcnst.h and vga.h headers from the 'vga_new' VGA Miniport Driver,
  that contain definitions related to VGA registers as well as command-stream
  functionality.

- Replace a bunch of hardcoded values by their corresponding defintions.

- Replace "Captain-Obvious" comments in VgaIsPresent() with actual
  explanations from the corresponding function in 'vga_new'.

- Simplify the VgaInterpretCmdStream() function, based on the
  corresponding one from 'vga_new'.

- Use concise comments in the 'AT_Initialization' command stream definition.

- Import the 'VGA_640x480' initialization command stream from 'vga_new'
  and use it as the full VGA initialization stream whenever the HAL
  does not handle the VGA display (HalResetDisplay() returning FALSE).
  Otherwise we just use the 'AT_Initialization' command stream that
  performs minimal initialization.

- Remove unused AT_Initialization and other declarations from ARM build.

8 weeks ago[INFLIB] Fix INFCONTEXT structure to be compatible with the official definition ...
Timo Kreuzer [Sun, 23 Jun 2019 20:35:19 +0000 (22:35 +0200)]
[INFLIB] Fix INFCONTEXT structure to be compatible with the official definition (#1603)

* [INFLIB] Fix INFCONTEXT structure to be compatible with the official definition.

This makes inflib work on x64.

8 weeks ago[SETUPAPI][UMPNPMGR] PNP_UnregisterNotification: Add 2 unknown parameters
Eric Kohl [Sun, 23 Jun 2019 19:45:54 +0000 (21:45 +0200)]
[SETUPAPI][UMPNPMGR] PNP_UnregisterNotification: Add 2 unknown parameters

8 weeks ago[SETUPAPI][UMPNPMGR] Improve CMP_RegisterNotification/PNP_RegisterNotification
Eric Kohl [Sun, 23 Jun 2019 17:26:44 +0000 (19:26 +0200)]
[SETUPAPI][UMPNPMGR] Improve CMP_RegisterNotification/PNP_RegisterNotification

Pass the notification filter to PNP_RegisterNotification as a byte-pointer to the filter and the size of the filter.

8 weeks ago[BOOTVID] Fixes for VgaIsPresent() and VidInitialize().
Hermès Bélusca-Maïto [Sun, 23 Jun 2019 01:03:40 +0000 (03:03 +0200)]
[BOOTVID] Fixes for VgaIsPresent() and VidInitialize().

- VgaIsPresent(): Re-select the memory mode register before playing
  around with the sequencer flag. Otherwise the VGA may not be detected
  correctly from time to time.

- VidInitialize(): Simplify the initialization loop, reset AddressSpace
  to its "default" value of 1 when calling HalFindBusAddressTranslation()
  on 'NullAddress'.

8 weeks ago[BOOTVID] Simplify the code by introducing and using IO port helper macros.
Hermès Bélusca-Maïto [Sun, 23 Jun 2019 00:29:01 +0000 (02:29 +0200)]
[BOOTVID] Simplify the code by introducing and using IO port helper macros.

- Move around two header includes.
- Remove a redundant assignment in VgaInterpretCmdStream().

8 weeks ago[VGA_NEW] Fix confusion between CRTC Controller and Graphics Controller registers.
Hermès Bélusca-Maïto [Sat, 22 Jun 2019 21:27:26 +0000 (23:27 +0200)]
[VGA_NEW] Fix confusion between CRTC Controller and Graphics Controller registers.

8 weeks ago[NTVDM] Fix whitespace.
Hermès Bélusca-Maïto [Sat, 22 Jun 2019 21:24:13 +0000 (23:24 +0200)]
[NTVDM] Fix whitespace.

8 weeks ago[WIN32K] Fix spelling typo.
Hermès Bélusca-Maïto [Sat, 22 Jun 2019 21:03:10 +0000 (23:03 +0200)]
[WIN32K] Fix spelling typo.

8 weeks ago[WIN32SS] Fix multiple scrollbar redraw issues
Joachim Henze [Sat, 22 Jun 2019 20:27:23 +0000 (22:27 +0200)]
[WIN32SS] Fix multiple scrollbar redraw issues

This fixes:
- CORE-15911 "Scrollbars do not dissapear when Maximizing and not needed"
- CORE-10617 "ListView corrupt scrollbar upon resizing the column-header"

and will appease regression:
- CORE-15429 "Uninitialized scrollbars in 'My Computer'"

By applying clientFix.patch from CORE-15911 contributed by JIRA-user 'I_Kill_Bugs'.

https://reactos.org/testman/compare.php?ids=66723,66729

Earlier I already committed this fix into 0.4.12-RC-9-g
5ac548544ff6b3d52c6591385d9029164e766d71

8 weeks ago[NETCFGX] Start a network adapter device after the custom install steps have been...
Eric Kohl [Sat, 22 Jun 2019 18:59:16 +0000 (20:59 +0200)]
[NETCFGX] Start a network adapter device after the custom install  steps have been completed.

This could probably fix CORE-16103

8 weeks ago[SETUPAPI] Implement SetupDiRestartDevices()
Eric Kohl [Sat, 22 Jun 2019 18:50:51 +0000 (20:50 +0200)]
[SETUPAPI] Implement SetupDiRestartDevices()

8 weeks ago[Win32SS] Complete Print Driver Callbacks
jimtabor [Sat, 22 Jun 2019 17:02:51 +0000 (12:02 -0500)]
[Win32SS] Complete Print Driver Callbacks

This callback works. Haven't commit the rest yet. Still thinking about
the data packets types and shapes. Using wordpad to test this. It works,
loads and unloads due to incomplete driver support and no PDEV. It
crashes in ComCtl32 while loading a text file. When this gets committed
without a solution, the code will be commented out.

8 weeks ago[COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) (#1674)
Andreas Maier [Sat, 22 Jun 2019 14:36:14 +0000 (16:36 +0200)]
[COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) (#1674)

* [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression)

Fix cb_states / rb_states lookup table.

* [README.WINE] comctl32 is synced to WineStaging-3.3.

See commit b3fb8555 .