From 1969094028f166e7354ec639a5d38e4ef02716e5 Mon Sep 17 00:00:00 2001 From: Thomas Faber Date: Thu, 1 Feb 2018 11:07:39 +0100 Subject: [PATCH] [WIN32K:NTUSER] Avoid allocating an extra item in IntCloneMenuItems. CORE-14222 --- win32ss/user/ntuser/menu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/win32ss/user/ntuser/menu.c b/win32ss/user/ntuser/menu.c index 5ecffbb8e37..46382e48159 100644 --- a/win32ss/user/ntuser/menu.c +++ b/win32ss/user/ntuser/menu.c @@ -778,10 +778,10 @@ IntCloneMenuItems(PMENU Destination, PMENU Source) if(!Source->cItems) return FALSE; - NewMenuItem = DesktopHeapAlloc(Destination->head.rpdesk, (Source->cItems+1) * sizeof(ITEM)); + NewMenuItem = DesktopHeapAlloc(Destination->head.rpdesk, Source->cItems * sizeof(ITEM)); if(!NewMenuItem) return FALSE; - RtlZeroMemory(NewMenuItem, (Source->cItems+1) * sizeof(ITEM)); + RtlZeroMemory(NewMenuItem, Source->cItems * sizeof(ITEM)); Destination->rgItems = NewMenuItem; -- 2.17.1