From 29c9e92c9e6741e55a9c65ddf6777b8d9c671451 Mon Sep 17 00:00:00 2001 From: Serge Gautherie Date: Wed, 16 Jan 2019 17:46:27 +0100 Subject: [PATCH] [LOG2LINES] Add a TODO, Use a snprintf() Addendum to c5d8d8d. --- sdk/tools/log2lines/log2lines.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/tools/log2lines/log2lines.c b/sdk/tools/log2lines/log2lines.c index 4ee66bb5c93..b5ff009c387 100644 --- a/sdk/tools/log2lines/log2lines.c +++ b/sdk/tools/log2lines/log2lines.c @@ -637,6 +637,7 @@ main(int argc, const char **argv) char PathBuffer[LINESIZE + 1]; char LineOutBuffer[LINESIZE + 1]; + // TODO: Re-use one translate_files(), instead of repeated translate_line(). while (i < argc) { offset = argv[optCount + i++]; @@ -646,7 +647,7 @@ main(int argc, const char **argv) { l2l_dbg(2, "translating %s %s\n", exefile, offset); - sprintf(Line, "<%s:%s>\n", exefile, offset); + snprintf(Line, LINESIZE, "<%s:%s>\n", exefile, offset); translate_line(conOut, Line, PathBuffer, LineOutBuffer); report(conOut); } -- 2.17.1