From 2b8f4f6e244dcd83875564f72d8320c687a3a240 Mon Sep 17 00:00:00 2001 From: Thomas Faber Date: Wed, 7 Mar 2018 11:02:55 +0100 Subject: [PATCH] [NTOS:EX] Worker threads must not exit with a critical region held. CORE-13734 --- ntoskrnl/ex/work.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/ex/work.c b/ntoskrnl/ex/work.c index 731f442a853..24d328abc07 100644 --- a/ntoskrnl/ex/work.c +++ b/ntoskrnl/ex/work.c @@ -162,7 +162,7 @@ ProcessLoop: WorkItem->WorkerRoutine(WorkItem->Parameter); /* Make sure APCs are not disabled */ - if (Thread->Tcb.SpecialApcDisable) + if (Thread->Tcb.CombinedApcDisable != 0) { /* We're nice and do it behind your back */ DPRINT1("Warning: Broken Worker Thread: %p %p %p came back " @@ -170,7 +170,8 @@ ProcessLoop: WorkItem->WorkerRoutine, WorkItem->Parameter, WorkItem); - Thread->Tcb.SpecialApcDisable = 0; + ASSERT(Thread->Tcb.CombinedApcDisable == 0); + Thread->Tcb.CombinedApcDisable = 0; } /* Make sure it returned at right IRQL */ -- 2.17.1