From 2f541881a857b3d3c26da1f477891cba1a6182c5 Mon Sep 17 00:00:00 2001 From: Johannes Anderwald Date: Fri, 2 Oct 2009 10:53:36 +0000 Subject: [PATCH] - Check if NodeId is out of bounds - Return correct status code svn path=/trunk/; revision=43253 --- reactos/drivers/ksfilter/ks/topology.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/reactos/drivers/ksfilter/ks/topology.c b/reactos/drivers/ksfilter/ks/topology.c index 362465d2ed5..547a1ff92b2 100644 --- a/reactos/drivers/ksfilter/ks/topology.c +++ b/reactos/drivers/ksfilter/ks/topology.c @@ -241,6 +241,13 @@ KsTopologyPropertyHandler( case KSPROPERTY_TOPOLOGY_NAME: Node = (KSP_NODE*)Property; + if (Node->NodeId >= Topology->TopologyNodesCount) + { + Irp->IoStatus.Information = 0; + Status = STATUS_INVALID_PARAMETER; + break; + } + Status = RtlStringFromGUID(&Topology->TopologyNodesNames[Node->NodeId], &GuidString); if (!NT_SUCCESS(Status)) { @@ -254,6 +261,7 @@ KsTopologyPropertyHandler( if (!KeyName.Buffer) { Irp->IoStatus.Information = 0; + Status = STATUS_INSUFFICIENT_RESOURCES; break; } -- 2.17.1