From 454745e48ca3b583e9d6e1e70a9be418f490a88d Mon Sep 17 00:00:00 2001 From: Timo Kreuzer Date: Sun, 28 Apr 2019 17:20:02 +0200 Subject: [PATCH] [TELNET] Add missing curly braces to while-statement Fixes GCC 8 warning: base/applications/network/telnet/src/tmapldr.cpp:70:3: error: this 'while' clause does not guard... [-Werror=misleading-indentation] while (buf[len]) ^~~~~ base/applications/network/telnet/src/tmapldr.cpp:74:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'while' if (len && (buf[len-1] == ' ')) { ^~ --- .../network/telnet/src/tmapldr.cpp | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/base/applications/network/telnet/src/tmapldr.cpp b/base/applications/network/telnet/src/tmapldr.cpp index 99b3b62062f..ef1ada0dc67 100644 --- a/base/applications/network/telnet/src/tmapldr.cpp +++ b/base/applications/network/telnet/src/tmapldr.cpp @@ -67,18 +67,20 @@ static char * getline(istream& i, char* buf, int size){ if ((buf[0]==0)||(buf[0]==';')) continue; len = 0; // look for comment like this one - while (buf[len]) - if ((buf[len] == '/') && (buf[len+1] == '/')) buf[len] = 0; - else len++; + while (buf[len]) + { + if ((buf[len] == '/') && (buf[len + 1] == '/')) buf[len] = 0; + else len++; - if (len && (buf[len-1] == ' ')) { + if (len && (buf[len - 1] == ' ')) { len--; - buf[len]=0; - }; - // in case for comment like this one (in line just a comment) - if (buf[0]==0) continue; + buf[len] = 0; + }; + } + // in case for comment like this one (in line just a comment) + if (buf[0] == 0) continue; - break; + break; }; return (buf); }; -- 2.17.1