From 7479bc63fefa1fbab12dd7ae52690b549deeff54 Mon Sep 17 00:00:00 2001 From: Pierre Schweitzer Date: Sat, 24 Oct 2015 10:24:37 +0000 Subject: [PATCH] [SHELL32] Fix a memory leak CID 1322131 svn path=/trunk/; revision=69673 --- reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp b/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp index 5734673b6d5..2440d149553 100644 --- a/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp +++ b/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp @@ -1321,6 +1321,7 @@ HRESULT CMenuSFToolbar::FillToolbar(BOOL clearFirst) // If no items were added, show the "empty" placeholder if (DPA_GetPtrCount(dpaSort) == 0) { + DPA_Destroy(dpaSort); return AddPlaceholder(); } @@ -1341,7 +1342,10 @@ HRESULT CMenuSFToolbar::FillToolbar(BOOL clearFirst) hr = m_shellFolder->GetDisplayNameOf(item, SIGDN_NORMALDISPLAY, &sr); if (FAILED_UNEXPECTEDLY(hr)) + { + DPA_Destroy(dpaSort); return hr; + } StrRetToStr(&sr, NULL, &MenuString); -- 2.17.1