From 9bc2a273938f43a8deebdc91ecbe20d5968fceed Mon Sep 17 00:00:00 2001 From: Serge Gautherie Date: Tue, 13 Feb 2018 13:05:35 +0100 Subject: [PATCH] [KMTESTS:NPFS] Fix 2 Clang-Cl warnings about ShareAccess "warning: variable 'ShareAccess' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]" CORE-14306 --- modules/rostests/kmtests/npfs/NpfsHelpers.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/modules/rostests/kmtests/npfs/NpfsHelpers.c b/modules/rostests/kmtests/npfs/NpfsHelpers.c index 00864990b50..3dc9267bf8b 100644 --- a/modules/rostests/kmtests/npfs/NpfsHelpers.c +++ b/modules/rostests/kmtests/npfs/NpfsHelpers.c @@ -103,6 +103,11 @@ NpCreatePipe( ShareAccess = FILE_SHARE_READ; else if (NamedPipeConfiguration == FILE_PIPE_FULL_DUPLEX) ShareAccess = FILE_SHARE_READ | FILE_SHARE_WRITE; + else + { + ASSERTMSG("Invalid NamedPipeConfiguration parameter value!", FALSE); + return STATUS_INVALID_PARAMETER_6; + } DefaultTimeout.QuadPart = -50 * 1000 * 10; @@ -185,6 +190,11 @@ NpOpenPipe( ShareAccess = FILE_SHARE_READ; else if (NamedPipeConfiguration == FILE_PIPE_FULL_DUPLEX) ShareAccess = FILE_SHARE_READ | FILE_SHARE_WRITE; + else + { + ASSERTMSG("Invalid NamedPipeConfiguration parameter value!", FALSE); + return STATUS_INVALID_PARAMETER_3; + } return NpOpenPipeEx(ClientHandle, PipePath, -- 2.17.1