From b7e055c129fa0da563f7769c679d7b827bb87362 Mon Sep 17 00:00:00 2001 From: Amine Khaldi Date: Fri, 3 Jan 2014 17:23:55 +0000 Subject: [PATCH] [USBEHCI] * Remove inclusions that already exist in the main header. * Cleanup the main header. * Improve the GUIDs situation. CORE-7716 svn path=/trunk/; revision=61502 --- reactos/drivers/usb/usbehci/CMakeLists.txt | 3 +- reactos/drivers/usb/usbehci/guid.cpp | 6 ++++ reactos/drivers/usb/usbehci/hardware.h | 5 +--- reactos/drivers/usb/usbehci/interfaces.h | 6 +--- reactos/drivers/usb/usbehci/usbehci.h | 32 ++-------------------- 5 files changed, 12 insertions(+), 40 deletions(-) create mode 100644 reactos/drivers/usb/usbehci/guid.cpp diff --git a/reactos/drivers/usb/usbehci/CMakeLists.txt b/reactos/drivers/usb/usbehci/CMakeLists.txt index 8cf3944e827..2c6c425ae2a 100644 --- a/reactos/drivers/usb/usbehci/CMakeLists.txt +++ b/reactos/drivers/usb/usbehci/CMakeLists.txt @@ -10,7 +10,8 @@ list(APPEND SOURCE usbehci.cpp usb_request.cpp usb_queue.cpp - hardware.cpp) + hardware.cpp + guid.cpp) add_library(usbehci SHARED ${SOURCE} diff --git a/reactos/drivers/usb/usbehci/guid.cpp b/reactos/drivers/usb/usbehci/guid.cpp new file mode 100644 index 00000000000..8ea477c936f --- /dev/null +++ b/reactos/drivers/usb/usbehci/guid.cpp @@ -0,0 +1,6 @@ +/* DO NOT USE THE PRECOMPILED HEADER FOR THIS FILE! */ + +#include +#include + +/* NO CODE HERE, THIS IS JUST REQUIRED FOR THE GUID DEFINITIONS */ diff --git a/reactos/drivers/usb/usbehci/hardware.h b/reactos/drivers/usb/usbehci/hardware.h index 914bde40d26..2a84ee85479 100644 --- a/reactos/drivers/usb/usbehci/hardware.h +++ b/reactos/drivers/usb/usbehci/hardware.h @@ -1,8 +1,5 @@ #pragma once -#include - - // // Host Controller Capability Registers // @@ -325,4 +322,4 @@ typedef struct #define EHCI_QH_CAPS_SCM_SHIFT 8 // Split Completion Mask #define EHCI_QH_CAPS_SCM_MASK 0xff #define EHCI_QH_CAPS_ISM_SHIFT 0 // Interrupt Schedule Mask -#define EHCI_QH_CAPS_ISM_MASK 0xff \ No newline at end of file +#define EHCI_QH_CAPS_ISM_MASK 0xff diff --git a/reactos/drivers/usb/usbehci/interfaces.h b/reactos/drivers/usb/usbehci/interfaces.h index 3a69c3a9c23..447839038d1 100644 --- a/reactos/drivers/usb/usbehci/interfaces.h +++ b/reactos/drivers/usb/usbehci/interfaces.h @@ -1,10 +1,6 @@ - #ifndef INTERFACES_HPP #define INTERFACES_HPP -#include "libusb.h" - - //========================================================================================= // // class IUSBHardwareDevice @@ -152,4 +148,4 @@ DECLARE_INTERFACE_(IEHCIQueue, IUSBQueue) typedef IEHCIQueue *PEHCIQUEUE; -#endif +#endif /* INTERFACES_HPP */ diff --git a/reactos/drivers/usb/usbehci/usbehci.h b/reactos/drivers/usb/usbehci/usbehci.h index 2cc7bf747b2..171d39bb82e 100644 --- a/reactos/drivers/usb/usbehci/usbehci.h +++ b/reactos/drivers/usb/usbehci/usbehci.h @@ -1,35 +1,7 @@ #ifndef USBEHCI_H__ #define USBEHCI_H__ -#define INITGUID - -#include -#include -#include -#include - -extern "C" -{ -#include -} - - - -// -// FIXME: -// #include -// -#include -#include -#include - -// -// FIXME: -// the following includes are required to get kcom to compile -// -#include -#include -#include +#include #include "hardware.h" #include "interfaces.h" @@ -61,4 +33,4 @@ NTSTATUS NTAPI CreateUSBQueue(PUSBQUEUE *OutUsbQueue); // NTSTATUS NTAPI InternalCreateUSBRequest(PUSBREQUEST *OutRequest); -#endif +#endif /* USBEHCI_H__ */ -- 2.17.1