From bbaa62a6a8083a3bfc6a172bb2a59782cd47b28f Mon Sep 17 00:00:00 2001 From: Thomas Bluemel Date: Mon, 26 Sep 2005 11:14:34 +0000 Subject: [PATCH] - fixed uninitialized variable warning - fixed memory leak in SetupDiBuildDriverInfoList() svn path=/trunk/; revision=18086 --- reactos/lib/setupapi/devinst.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/reactos/lib/setupapi/devinst.c b/reactos/lib/setupapi/devinst.c index 2cb8a547edc..694b870ec62 100644 --- a/reactos/lib/setupapi/devinst.c +++ b/reactos/lib/setupapi/devinst.c @@ -3454,7 +3454,9 @@ GetVersionInformationFromInfFile( &RequiredSize); } //FIXME: DriverDate = Version.DriverVer => invalid date = 00/00/00 + RtlZeroMemory(DriverDate, sizeof(FILETIME)); //FIXME: DriverVersion = Version.DriverVer => invalid = 0 + *DriverVersion = 0; *pProviderName = ProviderName; return TRUE; @@ -3613,9 +3615,7 @@ SetupDiBuildDriverInfoList( /* Check if the ClassGuid in this .inf file is corresponding with our needs */ if (!IsEqualIID(&list->ClassGuid, &GUID_NULL) && !IsEqualIID(&list->ClassGuid, &ClassGuid)) { - SetupCloseInfFile(hInf); - hInf = INVALID_HANDLE_VALUE; - continue; + goto next; } } @@ -3766,9 +3766,11 @@ SetupDiBuildDriverInfoList( ManufacturerName = ManufacturerSection = NULL; Result = SetupFindNextLine(&ContextManufacturer, &ContextManufacturer); } + + ret = TRUE; +next: HeapFree(GetProcessHeap(), 0, ProviderName); ProviderName = NULL; - ret = TRUE; SetupCloseInfFile(hInf); hInf = INVALID_HANDLE_VALUE; -- 2.17.1