[AUDIT] security.c is mostly composed of trivial implementations of APIs that transfe...
authorAlex Ionescu <aionescu@gmail.com>
Tue, 18 Jul 2006 15:13:55 +0000 (15:13 +0000)
committerAlex Ionescu <aionescu@gmail.com>
Tue, 18 Jul 2006 15:13:55 +0000 (15:13 +0000)
commit3d6bddb98f584f0c3d3c2a7f50f8fdd5df193b33
treeded03d7128abe871ffebccec7761791d67efc02a
parentfff24ee1dd43f3dc8bbca0612d08b684428814cd
[AUDIT] security.c is mostly composed of trivial implementations of APIs that transfer one set of data from another, or simply wrap around complex Se* functions which do the actual work. There are one or two slightly more complex APIs (~15-20 lines), but they were written by Eric/Thomas, which are well-known for always writing clean code.
[FORMATTING] Re-formatted file properly, ordered functions and annotated them, added proper programmer credits, etc.
- Pushlocks need to be acquired in a -critical-, not -guarded- region.
- PsDisableImpersonation should return FALSE if it was already disbled.
- Don't forget to reference the token in PsReferenceEffectiveToken.
- PsImpersonateClient should still return success if it was given no token.
- PsImperstonateClient should de-reference the token if there is already active impersonation info.

svn path=/trunk/; revision=23152
reactos/ntoskrnl/KrnlFun.c
reactos/ntoskrnl/include/internal/tag.h
reactos/ntoskrnl/ps/security.c