[User32|Tests] Sync Port Wine Combo Controls.
authorJames Tabor <james.tabor@reactos.org>
Sat, 21 Sep 2019 13:47:56 +0000 (08:47 -0500)
committerJames Tabor <james.tabor@reactos.org>
Sat, 21 Sep 2019 13:47:56 +0000 (08:47 -0500)
commitc57d4d7b9e76959795b0abc66b2be5b7f46d3d3c
treeabe01f230925120058c3766b349e1ce22bc30bbc
parent432854ee18eb002049a058b5b233d8acc25ce76f
[User32|Tests] Sync Port Wine Combo Controls.

Need to cross check these changes with WINE ComCtl32 before you PANIC
HACK!!!!

Not in order:
Piotr Caban : Remove unneeded RECT parameter from CBPaintText helper.
              Don't invalidate ComboBox on CB_SETCURSEL message.
Don't invalidate ComboBox on LBN_SELCHANGE and
LBN_SELCANCEL.
              Add more CB_SETCURSEL tests on ComboBox.
              Redraw combo text field even if it's empty.
Let ComboBox edit control handle the redraw even if
CBF_NOREDRAW is set.
Don't do the painting if combobox is not visible in
CBPaintText.

Dmitry Timoshkov : Don't force a combobox repaint on WM_SIZE.

This breaks z-order based painting and causes side effects
for
applications that during the WM_PAINT processing reference
internal
             data associated with a not fully initialized window.
Ref :
https://source.winehq.org/git/wine.git/commit/2d9e3236ea8ae752184b8a285f9d616ec94afb8f

Fabian Maurer : Set listbox popup height correctly and add tests.

                Properly set dropdown height.

             Now that user32 and comctl32 combo are separated,
             this won't lead to a regression anymore
             Ref :
https://source.winehq.org/git/wine.git/commit/3d0be0bad8eca72e67199ebfb451150d58494ba3
             Info by Sebastian Lackner Ref:
https://source.winehq.org/git/wine.git/commit/f0fc0349976924379cc3ae2ff95fb342d7541294

Nikolay Sivov : Remove some misleading TODOs and confusing comments.
modules/rostests/winetests/user32/combo.c
win32ss/user/user32/controls/combo.c