Victor Perevertkin [Sun, 3 Jan 2021 00:46:12 +0000 (03:46 +0300)]
[CMAKE] Replace DIVISION_SLASH unicode character with SOLIDUS
This fixes the build on some machines. In addition, replace
the hardcoded "LINK /LIB" with ${CMAKE_AR}
Addendum to
b96e88894a4d55f5e8b94430deeb0f086151b24f
Hermès Bélusca-Maïto [Sat, 2 Jan 2021 23:10:03 +0000 (00:10 +0100)]
[USETUP] Minor improvements when initializing the console.
- Use NT values for uninitialized handle values.
- Cache the STD_INPUT_HANDLE.
- Free the console if GetConsoleScreenBufferInfo() fails in CONSOLE_Init().
Hermès Bélusca-Maïto [Sat, 2 Jan 2021 18:34:22 +0000 (19:34 +0100)]
[USETUP] Fix handling of the ESCAPE key.
Its AsciiChar is not zero in Console-compatible code.
Eric Kohl [Sat, 2 Jan 2021 20:18:18 +0000 (21:18 +0100)]
[SYSSETUP][INF] Add event log settings to the default security settings and apply them on setup
Thomas Faber [Sun, 27 Dec 2020 15:01:03 +0000 (16:01 +0100)]
[ACPICA] Update to version
20201217. CORE-17410
Eric Kohl [Fri, 1 Jan 2021 10:14:28 +0000 (11:14 +0100)]
[SYSSETUP] Rename defltws.inf to defltwk.inf
Eric Kohl [Fri, 1 Jan 2021 10:12:36 +0000 (11:12 +0100)]
[INF] Rename defltws.inf to defltwk.inf
Eric Kohl [Fri, 1 Jan 2021 09:24:36 +0000 (10:24 +0100)]
[SAMSRV][INF] Add missing aliases and privileges
- Add the 'Backup Operators', 'Replicator', 'RemoteDesktop Users' and 'Network Configuration Operators' aliases.
- Add missing privileges for the aliases.
Happy new year 2021! :-)
Hermès Bélusca-Maïto [Thu, 31 Dec 2020 23:00:00 +0000 (00:00 +0100)]
Happy New Year 2021 to the ReactOS Community!!
⚛️ 🍾 🥳 🎆 ☢️
Stanislav Motylkov [Thu, 31 Dec 2020 19:14:39 +0000 (22:14 +0300)]
[UNIATA] Properly mark ReactOS diff from upstream
Addendum to
4b9cf2e (r71252),
d14a872 (r73324),
7d65f2a (r71262), and
6c0ff7b.
CORE-11157 CORE-16078
Jérôme Gardou [Mon, 28 Dec 2020 16:52:22 +0000 (17:52 +0100)]
[FASTFAT_NEW] Fix callback calling convention
Serge Gautherie [Thu, 31 Dec 2020 14:42:42 +0000 (15:42 +0100)]
[ACPI] acpi_create_registry_table(): Close the key handle, on errors (#3372)
Addendum to
44f1cf1 (r74559). CORE-12942
Serge Gautherie [Thu, 31 Dec 2020 14:42:03 +0000 (15:42 +0100)]
[ACPI] AcpiRegOpenKey(): Add a missing OBJ_KERNEL_HANDLE (#3370)
CORE-10207
Stanislav Motylkov [Sun, 27 Dec 2020 22:38:06 +0000 (01:38 +0300)]
[UNIATA] Emulate SCSI INQUIRY to properly recognize Xbox DVD drives
CORE-16692
George Bișoc [Wed, 30 Dec 2020 22:48:34 +0000 (23:48 +0100)]
[OSK] Adjust the resource size, width and heigh properties of buttons (#3403)
For French (fr-FR) and French Canadian (fr-CA) translations.
CORE-17039
Tibor Lajos Füzi [Wed, 30 Dec 2020 22:42:34 +0000 (23:42 +0100)]
[TRANSLATION] Hungarian (hu-HU) translation update (#3388)
For mspaint, notepad, wordpad, cmd, cmdutils/help, appwiz, devmgr, newdev
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Erdem Ersoy [Wed, 11 Nov 2020 05:24:05 +0000 (08:24 +0300)]
[TRANSLATION] Update Turkish (tr-TR) translations of Control Panel applets (#3367)
Václav Zouzalík [Wed, 30 Dec 2020 20:44:41 +0000 (21:44 +0100)]
[SHIMGVW] Update Czech (cs-CZ) translation (#3409)
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Jérôme Gardou [Mon, 28 Dec 2020 11:06:34 +0000 (12:06 +0100)]
[CRT] Fix _onexit
Avoid calling malloc in CR initialisation code.
Have executables call msvcrt implementation, while the DLLs keep their own function tables
CORE-17362
Jérôme Gardou [Mon, 28 Dec 2020 09:47:38 +0000 (10:47 +0100)]
[CRT] Do not call atexit at process initialization
There is no guarantee that the underlying APIs are initialized at this point
CORE-17362
Jérôme Gardou [Mon, 28 Dec 2020 08:53:04 +0000 (09:53 +0100)]
[CRT] Format source a bit.
This is horrendous.
Stanislav Motylkov [Wed, 30 Dec 2020 00:24:06 +0000 (03:24 +0300)]
[NTOS:CM] Do not create ProcessorNameString value if there is no Brand String
If the CPU does support CPUID instruction but does not have the Brand String,
the legacy name detection should be performed either in CIM_Processor (WMI),
in the Processor device driver, or in the application itself.
The deleted Intel CPU name detection code can go to the WMI at some point.
In fact Windows XP and 2003 kernels do not have any strings of that kind.
This effectively reverts the hack committed 6 years ago in
7a985425 (r63798)
that was intended to workaround CORE-7952.
CORE-17413
Stanislav Motylkov [Tue, 29 Dec 2020 23:40:03 +0000 (02:40 +0300)]
[ACPI] Do not panic if ProcessorNameString does not exist
Windows does not create this value in the registry if the processor core
does not expose the Brand String. It's an optional value and existing code
accessing it already has proper NULL checks:
https://git.reactos.org/?p=reactos.git;a=blob;f=drivers/bus/acpi/buspdo.c;hb=
b96e88894a4d55f5e8b94430deeb0f086151b24f#l748
This is the proper fix for regression in CORE-7952.
Addendum to
48912992 (r61666) and
4d992804 (r62642).
CORE-17413
Stanislav Motylkov [Wed, 30 Dec 2020 00:18:17 +0000 (03:18 +0300)]
[DXDIAG] If ProcessorNameString not found, fall back to Identifier
It also should have its own routine for detecting CPU name, add a comment.
Windows XP and 2003 does have CPU name strings in dxdiagn.dll.
CORE-17413
Stanislav Motylkov [Wed, 30 Dec 2020 00:04:38 +0000 (03:04 +0300)]
[SYSDM] If ProcessorNameString not found, fall back to Identifier
Also add a comment about CIM_Processor. CORE-17413
Jérôme Gardou [Mon, 2 Nov 2020 09:51:08 +0000 (10:51 +0100)]
[CMAKE] Turn import libs into regular C static libs
Embed msvcrtex into libmsvcrt
Idea taken from Thomas Faber
Jérôme Gardou [Tue, 24 Nov 2020 17:30:40 +0000 (18:30 +0100)]
[GITHUB] Get LLVM latest version from chocolatey repository
Also, explicitly set target in toolchain file to help CMake getting things right.
Jérôme Gardou [Tue, 22 Dec 2020 11:32:45 +0000 (12:32 +0100)]
[CMAKE] Use -fcommon when using CLang
Jérôme Gardou [Wed, 25 Nov 2020 13:26:53 +0000 (14:26 +0100)]
[SPEC2DEF] Work-around a bug in MS linker handling of extern forwarders
Jérôme Gardou [Mon, 2 Nov 2020 09:49:24 +0000 (10:49 +0100)]
[MSVCRT_WINETEST] Unconditionally link against oldnames
Jérôme Gardou [Mon, 2 Nov 2020 09:47:44 +0000 (10:47 +0100)]
[FTP] Always link agains oldnames
Victor Perevertkin [Sun, 27 Dec 2020 15:40:33 +0000 (18:40 +0300)]
[NTOS:PNP] Send removal IRPs to a file system device object for mounted devices
If a DeviceObject has VPB attached, it should be treated in a special way
CORE-16106
Victor Perevertkin [Sun, 27 Dec 2020 15:35:52 +0000 (18:35 +0300)]
[MOUNTMGR] Do not handle device removal notification
Do not treat target device change notification as
DEVICE_INTERFACE_CHANGE_NOTIFICATION. The notification have to be
unregistered while handling GUID_DEVICE_INTERFACE_REMOVAL, so
GUID_TARGET_DEVICE_REMOVE_COMPLETE should never be sent to mountmgr in a
normal case.
CORE-16106
Hermès Bélusca-Maïto [Sat, 26 Dec 2020 23:38:36 +0000 (00:38 +0100)]
[CONSRV] Less hardcoded magic values.
Hermès Bélusca-Maïto [Sat, 26 Dec 2020 23:33:32 +0000 (00:33 +0100)]
[NTOS:IO] Fail if the driver name passed to NtLoadDriver() is an empty string.
Otherwise an assertion on the driver name is hit later on.
Can be reproduced by calling NtLoadDriver with a valid UNICODE_STRING
of Length == 0.
Hermès Bélusca-Maïto [Sat, 26 Dec 2020 23:31:54 +0000 (00:31 +0100)]
[NTOS:IO] Minor formatting only.
Making IopLoadUnloadDriver() looking similar to IopUnloadDriver().
Hermès Bélusca-Maïto [Thu, 17 Dec 2020 00:29:02 +0000 (01:29 +0100)]
[SAC] Fix the HeadlessInformation.PortType checks in DriverEntry().
Hermès Bélusca-Maïto [Thu, 17 Dec 2020 00:12:32 +0000 (01:12 +0100)]
[SAC] Use NULL for null pointer in last argument in HeadlessDispatch() calls.
Hermès Bélusca-Maïto [Sun, 13 Dec 2020 20:49:59 +0000 (21:49 +0100)]
[FREELDR] EMS boot options: Parse NT kernel load options in a consistent manner. Addendum to
d887308b.
In particular the parsing should not care about the letter case.
Hermès Bélusca-Maïto [Sun, 13 Dec 2020 17:07:45 +0000 (18:07 +0100)]
[PSDK][XDK] Add newer FILE_DEVICE_xxx DEVICE_TYPE defines.
Hermès Bélusca-Maïto [Sat, 12 Dec 2020 00:33:56 +0000 (01:33 +0100)]
[USETUP] Free allocated memory after loading the new text-mode font from the .CAB file.
Hermès Bélusca-Maïto [Wed, 8 Jan 2020 23:28:16 +0000 (00:28 +0100)]
[BLUE] IOCTL_CONSOLE_DRAW: Fix ConsoleDraw.SizeX/Y boundary checks. Always set the cursor position before possibly refreshing screen.
Baruch Rutman [Sat, 26 Dec 2020 16:48:21 +0000 (18:48 +0200)]
[GDI32_APITEST] Add tests for SetLayout and its effects (#3203)
As part of the efforts to fix mirroring (Right-to-left UI), this API test
should help determine what is wrong currently in how certain functions behave
when the DC is mirrored. It focuses mostly on BitBlt, StretchBlt and LPtoDP.
Inspired by PR #3109.
CORE-17298
Eric Kohl [Sat, 26 Dec 2020 13:22:43 +0000 (14:22 +0100)]
[WIDL] Fix a deprecation message and hints on how to build a new scanner and parser
Eric Kohl [Sat, 26 Dec 2020 13:00:26 +0000 (14:00 +0100)]
[WIDL] Port ALLOCATE attribute support to our WIDL
Eric Kohl [Fri, 25 Dec 2020 18:14:09 +0000 (19:14 +0100)]
[DEVMGR] Report property changes by the device manager to the installer
Serge Gautherie [Wed, 23 Dec 2020 12:20:37 +0000 (13:20 +0100)]
[SHELL32] spec: Fix SHGetAttributesFromDataObject() parameter types (#3317)
Addendum to
cdb48b8. CORE-17337
Jérôme Gardou [Wed, 25 Nov 2020 11:50:08 +0000 (12:50 +0100)]
[UMANDLG] Define Globals variable in only one translation unit
Jérôme Gardou [Thu, 26 Nov 2020 15:01:08 +0000 (16:01 +0100)]
[INCLUDE/IDL] Give implicit handles a more unique name
This avoids duplicated symbols when linking DLLs using more than one client or server stub
Jérôme Gardou [Mon, 14 Dec 2020 21:38:40 +0000 (22:38 +0100)]
[CMAKE] Add missing dependencies on PSDK
Jérôme Gardou [Wed, 25 Nov 2020 09:41:52 +0000 (10:41 +0100)]
[LIBXSLT] Fix public variable declarations when using clang-cl
Jérôme Gardou [Mon, 16 Nov 2020 08:24:58 +0000 (09:24 +0100)]
[NTOS/FSRTL] Implement FsRtlAcquireToCreateMappedSection using filter callbacks
Jérôme Gardou [Mon, 9 Nov 2020 09:37:10 +0000 (10:37 +0100)]
[KMTEST] Test what happens when CcSetFileSizes is called with data still mapped at the tail od the file
Jérôme Gardou [Tue, 1 Dec 2020 16:51:15 +0000 (17:51 +0100)]
[FASTFAT_NEW] Fix ReactOS compiler workaround
Jérôme Gardou [Mon, 30 Nov 2020 13:17:41 +0000 (14:17 +0100)]
[FASTFAT_NEW] Tune compile options and definitions for debugging
Jérôme Gardou [Mon, 30 Nov 2020 13:15:37 +0000 (14:15 +0100)]
[FASTFAT_NEW] Fix build
Jérôme Gardou [Thu, 10 Dec 2020 10:30:01 +0000 (11:30 +0100)]
[NTOS:IO] Validate input parameters in NtQueryDirectoryFile
It turns out this is not the job of the FS driver
Jérôme Gardou [Mon, 14 Dec 2020 14:51:15 +0000 (15:51 +0100)]
[NTOS:IO] Do not set Shared property of the file if we are failing in IoCheckShareAccess
Jérôme Gardou [Fri, 18 Dec 2020 14:23:22 +0000 (15:23 +0100)]
[KMTESTS] Add more tests for CcMapData & CcPinRead
Those show the shortcomings of the current implementation in ReactOS
Jérôme Gardou [Fri, 18 Dec 2020 16:21:01 +0000 (17:21 +0100)]
[NTOS:IO] Do not pass bogus file offset to the FS in NtReadFile & NtWriteFile
Eric Kohl [Mon, 21 Dec 2020 19:42:40 +0000 (20:42 +0100)]
[WINLOGON] Add hidden logon/logoff SFC notification
Oleg Dubinskiy [Sat, 14 Nov 2020 20:09:59 +0000 (22:09 +0200)]
[REGEDIT] Display search finished messagebox when using Find Next (F3) menu item (#3371)
This repeats behaviour of Windows Regedit. CORE-17368
Dmitry Borisov [Fri, 30 Oct 2020 19:06:30 +0000 (01:06 +0600)]
[WIN32K:NTUSER] Fix gradient caption bars with low color depth (#3338)
This fixes a problem when the window title bar is dithered down
to the 16- or 256-color palette. See also commit
0705f30.
Dmitry Borisov [Sat, 31 Oct 2020 16:10:42 +0000 (22:10 +0600)]
[USER32_APITEST] Add a test for SPI_GETGRADIENTCAPTIONS (#3338)
Oleg Dubinskiy [Tue, 27 Oct 2020 17:25:36 +0000 (19:25 +0200)]
[BROWSEUI][PSDK] Stubplement ShellTaskScheduler (#3326)
Required by MS Picture and Fax Viewer (shimgvw.dll).
Now it starts properly without replacing any other system files.
CORE-17337
Oleg Dubinskiy [Wed, 21 Oct 2020 14:46:09 +0000 (17:46 +0300)]
[BROWSEUI][PSDK] Stubplement UserAssist
Initial implementation of `CUserAssist` class, which contains `IUserAssist` interface.
See https://www.geoffchappell.com/studies/windows/ie/browseui/classes/userassist.htm.
Required by MS shell32.dll.
CORE-17345 CORE-17393
Eric Kohl [Sun, 20 Dec 2020 10:21:10 +0000 (11:21 +0100)]
[INTL] Broadcast a WM_SETTINGCHANGED message when settings have been changed.
Eric Kohl [Sun, 20 Dec 2020 09:47:08 +0000 (10:47 +0100)]
[INTL] Implement the selection of a property page by command line
Victor Perevertkin [Sat, 19 Dec 2020 18:41:52 +0000 (21:41 +0300)]
[CDROM_NEW] Add the registry file to CMakeLists.txt
Addendum to
2f6abcc4c339dfe260c125e05b227aac80415c9d
Victor Perevertkin [Sat, 19 Dec 2020 18:24:24 +0000 (21:24 +0300)]
[CDROM_NEW] Add a registry file for use on livecd and setup
Victor Perevertkin [Sat, 19 Dec 2020 18:00:06 +0000 (21:00 +0300)]
[VBE] Enable the driver start in the registry
Victor Perevertkin [Sat, 19 Dec 2020 17:52:54 +0000 (20:52 +0300)]
[BOOTDATA] Enable loading of the pci.sys driver
Victor Perevertkin [Sat, 19 Dec 2020 17:44:38 +0000 (20:44 +0300)]
[BOOTDATA] Do not explicitly load driver libraries in txtsetup.sif
If any driver depends on them, they will be loaded automatically
Joachim Henze [Sat, 19 Dec 2020 16:51:37 +0000 (17:51 +0100)]
[WIN32SS] Trim EOL white-space
Addendum to 0.4.15-dev-1457-g
870aa1254f07f6ec7d8c1ad93d53fa6c6b18264b
Joachim Henze [Sat, 19 Dec 2020 16:47:33 +0000 (17:47 +0100)]
[WIN32SS] Fix BSOD 0x1E nullptr deref via Git-bash CORE-16586
Thanks to the patches author Doug Lyons!
Joachim Henze [Fri, 18 Dec 2020 03:48:31 +0000 (04:48 +0100)]
[CDFS] Fix a macro-copy-paste and shrink the binary size CORE-17405
Joachim Henze [Thu, 17 Dec 2020 14:01:50 +0000 (15:01 +0100)]
[RTL] Fix build on MSVC bots part 2
Then stick with your stupid PCH on master already.
Addendum to 0.4.15-dev-1453-g
4ad7b6d
Joachim Henze [Thu, 17 Dec 2020 13:33:26 +0000 (14:33 +0100)]
[RDBSSLIB][RTL] Fix build on MSVC bots
Addendum to 0.4.15-dev-1453-g
4ad7b6d
Looks like CMake on master does not longer understand the syntax of
replace_compile_flags().
Will investigate that later again, when other issues have been
solved that do currently prevent me from testing that locally at all.
Most likely remove_target_compile_option() has to be used instead now.
Joachim Henze [Thu, 17 Dec 2020 12:31:43 +0000 (13:31 +0100)]
[APISETS][RDBSSLIB][RTL] Fix some build issues for MSVC Rls-config CORE-17402
A subset of the patch that is intended to fix all build issues in releases/0.4.14
for compiler MSVC 2010SP1 16.0.40219.1 with RosBE 2.1.6
I left out the changes for disk_new in master because the drivers sources
were replaced since the branching.
Thanks to Mark Jansen for providing the apisets part.
VBox https://reactos.org/testman/compare.php?ids=75522,75524
KVM https://reactos.org/testman/compare.php?ids=75521,75523
Victor Perevertkin [Tue, 15 Dec 2020 22:25:08 +0000 (01:25 +0300)]
[KMTESTS:IO] Remove ReactOS-specific workaround in IoVolume test
ReactOS is now more compatible, and names volume devices as
"\Device\HarddiskVolume%u"
Victor Perevertkin [Tue, 15 Dec 2020 22:15:00 +0000 (01:15 +0300)]
[CMD_WINETEST] Disable the test until fastfat_new is landed
Victor Perevertkin [Tue, 15 Dec 2020 22:12:26 +0000 (01:12 +0300)]
[MOUNTMGR] Fix bugs in MountMgrQueryDosVolumePath
- Do not access uninitialized SymlinkInformation on failure case
and just return
- Do not make an assumption that MOUNTMGR_TARGET_NAME has a zero-string
Jérôme Gardou [Tue, 15 Dec 2020 09:07:27 +0000 (10:07 +0100)]
[NTOS:MM] Fix more 64 bit arithmetics
Victor Perevertkin [Mon, 14 Dec 2020 18:09:14 +0000 (21:09 +0300)]
Jérôme Gardou [Mon, 14 Dec 2020 17:19:28 +0000 (18:19 +0100)]
[NTOS:MM] Fix passing section size to MiCreatePagingFileMap & fix maximum size check
Also return the right status instead of stupidly asserting when failing to allocate memory.
Jérôme Gardou [Mon, 14 Dec 2020 17:21:35 +0000 (18:21 +0100)]
[APITESTS] Do not compile SEH tests in when using dummy PSEH
Jérôme Gardou [Fri, 11 Dec 2020 12:11:03 +0000 (13:11 +0100)]
[PSDK] define __analysis_noreturn for clang static analyzer
Eric Kohl [Sun, 13 Dec 2020 15:24:58 +0000 (16:24 +0100)]
[SCSIPORT] Append the missing "SCSI <device type> Device" string to the device description
Eric Kohl [Sun, 13 Dec 2020 00:22:52 +0000 (01:22 +0100)]
[INF] Include volume.inf in the build
Eric Kohl [Sun, 13 Dec 2020 00:21:22 +0000 (01:21 +0100)]
[INF] Add an inf file for the volume device class
Eric Kohl [Sat, 12 Dec 2020 15:42:15 +0000 (16:42 +0100)]
[STORPROP] Add missing property provider stubs
Eric Kohl [Sat, 12 Dec 2020 11:46:11 +0000 (12:46 +0100)]
[SCSIPORT] Trim the Device ID and the Device Description
- Extend CopyField to support a default character and trimming.
- Use CopyField instead of CopyFieldTruncate.
CORE-17396
Eric Kohl [Thu, 10 Dec 2020 22:25:06 +0000 (23:25 +0100)]
[SCSIPORT] Fix the hardware IDs and remove the superfluous one
Eric Kohl [Wed, 9 Dec 2020 22:58:12 +0000 (23:58 +0100)]
[SCSIPORT] Add the enumerator (SCSI) to the Compatible IDs
Jérôme Gardou [Wed, 9 Dec 2020 17:05:07 +0000 (18:05 +0100)]
[NTOS:CC] Acquire the master lock after freeing the VACB in CcRosFlushDirtyPages
Fixes a random ASSERT
Jérôme Gardou [Wed, 9 Dec 2020 11:40:51 +0000 (12:40 +0100)]
Jérôme Gardou [Wed, 9 Dec 2020 11:24:23 +0000 (12:24 +0100)]
[SCSIPORT] Fix locking the device extension.
From MSDN:
It is an error to call KeReleaseSpinLockFromDpcLevel if the specified spin lock was acquired by calling KeAcquireSpinLock because the caller's original IRQL is not restored, which can cause deadlocks or fatal page faults.
Jérôme Gardou [Wed, 9 Dec 2020 09:00:35 +0000 (10:00 +0100)]
[USER32] Properly save EBX in the wndproc wrapper
Jérôme Gardou [Mon, 30 Nov 2020 11:42:33 +0000 (12:42 +0100)]
[NTOS/FSRTL] Fix MCB tests
- Fix behaviour when adding or removing entries in the middle of an existing run
- Do not touch output parameters when failing, caller might rely on this.
Jérôme Gardou [Fri, 27 Nov 2020 17:54:38 +0000 (18:54 +0100)]
[KMTEST:FSRTL] Add more tests for MCB API
These were obtained through debug prints of fastfat_new in ReactOS.