Timo Kreuzer [Tue, 12 Mar 2024 17:06:33 +0000 (19:06 +0200)]
[CRT] intrin_x86.h: Use movsl instead of movsd to fix a GCC 13 warning
Timo Kreuzer [Fri, 15 Mar 2024 18:46:45 +0000 (20:46 +0200)]
[DBGHELP] Remove useless broken CMake defines
Timo Kreuzer [Mon, 27 Nov 2023 20:19:55 +0000 (22:19 +0200)]
[HDAUDBUS] Silence debug spam
- Demote a DPRINT1 to a DPRINT
- Define NDEBUG
Timo Kreuzer [Fri, 8 Mar 2024 18:53:12 +0000 (20:53 +0200)]
[NTOS:EX] Fix a loop bug
Timo Kreuzer [Fri, 8 Mar 2024 17:35:03 +0000 (19:35 +0200)]
[RTL/x64] Fix a GCC compiler warning
Katayama Hirofumi MZ [Tue, 19 Mar 2024 00:44:10 +0000 (09:44 +0900)]
[SHLWAPI] SHLWAPI_DEF_ASSOCF: Add ASSOCF_INIT_NOREMAPCLSID (#6636)
Step up to correct shell32!FindExecutable.
JIRA issue: CORE-19493
Katayama Hirofumi MZ [Mon, 18 Mar 2024 23:58:07 +0000 (08:58 +0900)]
[SHELL32][SDK] Implement RealShellExecute(,Ex)(A,W) (#5849)
Implementing missing features...
JIRA issue: CORE-19278
- Modify shell32.spec.
- Implement RealShellExecuteA, RealShellExecuteW, RealShellExecuteExA,
and RealShellExecuteExW functions.
- Add the prototypes to <undocshell.h>.
- Modify SEE_MASK_... constants.
Katayama Hirofumi MZ [Sun, 17 Mar 2024 22:36:17 +0000 (07:36 +0900)]
[SHELL32_APITEST] Enhance FindExecutable testcase (#6634)
I want to know the details of FindExecutable
behavior.
JIRA issue: CORE-19493
Enhance the tests of return values.
Katayama Hirofumi MZ [Sun, 17 Mar 2024 22:32:47 +0000 (07:32 +0900)]
[MSPAINT] Support JPEG/PNG/GIF/TIFF wallpapers (#6632)
Improve usability.
JIRA issue: CORE-19485
- Enable the menu items to set the wallpapars.
- Save the current bitmap as file Wallpaper1.bmp
in CSIDL_LOCAL_APPDATA folder.
- Support JPEG/PNG/GIF/TIFF files in
RegistrySettings::SetWallpaper.
Katayama Hirofumi MZ [Sun, 17 Mar 2024 03:44:03 +0000 (12:44 +0900)]
[MSCTFIME] Use QISearch for QueryInterface (#6630)
Simplify code and reduce binary size.
JIRA issue: CORE-19360
- Use shlwapi!QISearch for QueryInterface
implementation.
- Add delay link to shlwapi.
Katayama Hirofumi MZ [Sun, 17 Mar 2024 02:55:19 +0000 (11:55 +0900)]
[MSUTB][SDK] Use QISearch for QueryInterface (#6631)
Simplify code and reduce binary size.
JIRA issue: CORE-19363
- Use shlwapi!QISearch for QueryInterface
implementation.
- Add delay link to shlwapi.
- Define QITABENT macro in <shlwapi.h>.
Katayama Hirofumi MZ [Sat, 16 Mar 2024 23:15:08 +0000 (08:15 +0900)]
[RAPPS][SHLWAPI][SDK] Un-escape URL filename (#6626)
Choosing the better filename.
JIRA issue: CORE-19490
- Add UrlUnescapeAndMakeFileNameValid helper function.
- Use UrlUnescapeW and PathIsValidCharW.
- Add PATH_CHAR_CLASS_... flags for PathIsValidCharA/W.
Katayama Hirofumi MZ [Sat, 16 Mar 2024 10:37:26 +0000 (19:37 +0900)]
[TOOLS] gen_baseaddress.py: Add '.ime' to ALL_EXTENSIONS (#6628)
We have dll/ime/msctfime for the DLL
file msctfime.ime.
JIRA issue: N/A
Add '.ime' to ALL_EXTENSIONS.
Katayama Hirofumi MZ [Sat, 16 Mar 2024 04:46:10 +0000 (13:46 +0900)]
[CMAKE] Update sdk/cmake/baseaddress(,_msvc).cmake (#6627)
Follow-up to #6624 (
fd96666). ReactOS got rekt in that PR
because kernel32.dll got so larger.
Fix base addresses of DLLs to boot successfully. Sorry.
(dll/ntdll/ldr/ldrutils.c:1423) Illegal DLL relocation!
C:\ReactOS\System32\ntdll.dll overlaps kernel32.dll
*** Fatal System Error: 0xc0000269
Proposed changes
After latest build:
python gen_baseaddress.py C:\Users\katahiromz\reactos-1\output-VS-i386
python gen_baseaddress.py C:\Users\katahiromz\reactos-1\output-MinGW-i386
Katayama Hirofumi MZ [Fri, 15 Mar 2024 15:11:53 +0000 (00:11 +0900)]
[SDK][MC] errcodes.mc: Add Japanese (ja-JP) translation (#6624)
Localize the error messages.
JIRA issue: CORE-18706
Modify errcodes.mc for Japanese localization.
Katayama Hirofumi MZ [Fri, 15 Mar 2024 14:46:14 +0000 (23:46 +0900)]
[SHELL32_APITEST] ShellExecuteEx: Fix command line checker (#6618)
Follow-up to #6617.
JIRA issue: CORE-19482
Add traces for error checking.
Katayama Hirofumi MZ [Fri, 15 Mar 2024 12:25:53 +0000 (21:25 +0900)]
[SHLWAPI] Implement SHSetDefaultDialogFont (#6620)
Implementing missing features...
JIRA issue: CORE-19278
- Implement SHSetDefaultDialogFont function.
- Add SHSetDefaultDialogFont prototype to
<shlwapi_undoc.h>.
Oleg Dubinskiy [Thu, 14 Mar 2024 19:58:12 +0000 (20:58 +0100)]
[SHELL32] Add transparent icon resource (#6621) CORE-19471
Add transparent 16x16 icon (just small picec of transparent background) as resource and use it for 50, 51, 52, 53 resource IDs.
Define it as IDI_SHELL_NONE_XX for all four IDs appropriately (since the icon displays nothing).
These resources are not used by anything yet, but they are confirmed to exist as resources with 50, 51, 52, 53 IDs in shell32.dll from Windows XP/Server 2003.
This allows to correct the ordering of all other resources those come starting from index 54, and hence it fixes the following icons displayed incorrectly after restoring to default system icon set via Stardock IconPackager 5.1:
- Control Panel folder icon;
- Folder Options item icon in Control Panel;
- My Music special folder in My Documents;
- several File extensions icons (.ini, .txt etc).
The icons are fixed as in the preview of IconPackager app, same in ReactOS itself.
Now only Web Browser item icon on the Desktop remains invalid. All other icons are restored correctly.
CORE-19471
Katayama Hirofumi MZ [Wed, 13 Mar 2024 11:04:39 +0000 (20:04 +0900)]
[BROWSEUI] Delete WS_BORDER and owner-drawing from IDC_SEARCH_COMBOBOX (#6610)
Related to #6609.
Delete WM_BORDER and CBS_OWNERDRAWFIXED
styles from IDC_SEARCH_COMBOBOX.
JIRA issue: N/A
Katayama Hirofumi MZ [Wed, 13 Mar 2024 08:09:20 +0000 (17:09 +0900)]
[SHELL32_APITEST] Make ShellExecuteEx testcase stable (#6617)
Making the tests trustworthy.
JIRA issue: ROSTESTS-389
- Enable command line checking.
- Rewrite the tests for better tests.
- Remove dependency with shell32_apitest_sub.
- Close the newly opened windows by Alt+F4 at ending.
Doug Lyons [Wed, 13 Mar 2024 06:16:02 +0000 (01:16 -0500)]
[NTUSER] Fix sticky mouse buttons (#6426)
Fix Mouse Buttons Sticking Down causing unexpected window dragging.
This is a patch supplied by @I_Kill_Bugs and seems to work well as tested by @julenuri.
JIRA issue: CORE-11775 'GIMP 2.6.12: Sticky issue when dragging with the mouse'
JIRA issue: CORE-14998 'Google Chrome 40.0.2214.115, when moving window position by dragging at the titlebar, the drag-end is not detected, the window may stick with the mouse pointer'
Improves JIRA issue: CORE-18511
Proposed changes
Add extra code into nonclient.c procedure DefWndDoSizeMove to drop tracking.
If we get a mouse move with the mouse left button down, then break out of testing.
Hermès Bélusca-Maïto [Mon, 18 Apr 2022 22:09:49 +0000 (00:09 +0200)]
[FREELDR] Factor duplicated code into a GetOSLoadingMethod() helper
This removes duplicated code present in both LoadOperatingSystem()
and EditOperatingSystemEntry().
+ Add SAL annotations to the related functions.
Katayama Hirofumi MZ [Tue, 12 Mar 2024 12:12:43 +0000 (21:12 +0900)]
[COMDLG32] Improve Japanese (ja-JP) translation, Part 2
Follow-up to
78f6179. CORE-18706
Piotr Hetnarowicz [Tue, 12 Mar 2024 12:02:29 +0000 (13:02 +0100)]
[SHELL32] Update Polish (pl-PL) translation (#6597)
Addendum to
71285dff489 and
0241b5c4e93. CORE-16956
Stanislav Motylkov [Tue, 12 Mar 2024 11:54:24 +0000 (14:54 +0300)]
[SHELL32] Update Russian (ru-RU) translation
Addendum to
71285dff489 and
0241b5c4e93. CORE-16956
Katayama Hirofumi MZ [Tue, 12 Mar 2024 11:55:47 +0000 (20:55 +0900)]
[COMDLG32] Improve Japanese (ja-JP) translation
CORE-18706
Katayama Hirofumi MZ [Tue, 12 Mar 2024 11:06:24 +0000 (20:06 +0900)]
[BROWSEUI] Search: Add WS_BORDER to IDC_SEARCH_COMBOBOX (#6609)
Fix a minor UI problem. IDC_SEARCH_COMBOBOX was border-less.
It was wrong.
JIRA issue: N/A
- Add WS_BORDER window style to IDC_SEARCH_COMBOBOX
combo box in IDD_SEARCH_DLG dialog resource.
Katayama Hirofumi MZ [Tue, 12 Mar 2024 09:49:52 +0000 (18:49 +0900)]
[COMCTL32] TreeView: Fix selection display on checking checkbox (#6608)
Fix checkboxed treeview selection display.
JIRA issue: CORE-19480
- Make the first argument of TREEVIEW_ToggleItemState non-const.
- Select the item by calling TREEVIEW_SelectItem in TREEVIEW_ToggleItemState.
Doug Lyons [Tue, 12 Mar 2024 07:45:22 +0000 (02:45 -0500)]
[USER32] Show Debug Log Message when unhandled PNG found in ICO file. (#5566)
Detect the PNG data in ICO files and print an appropriate message to the debug log.
JIRA issue: CORE-19107
Katayama Hirofumi MZ [Tue, 12 Mar 2024 07:10:59 +0000 (16:10 +0900)]
[SHELL32] CGuidItemContextMenu: Fix pwszCLSID leak (#6607)
Fix memory leak.
JIRA issue: CORE-19478
- Use CoTaskMemFree for pwszCLSID to avoid memory leak
in CGuidItemContextMenu_CreateInstance function.
Katayama Hirofumi MZ [Tue, 12 Mar 2024 06:58:22 +0000 (15:58 +0900)]
[SHELL32] Start Menu: Enhance context menu (#6606)
Improve Start Menu usability.
JIRA issue: CORE-19477
- Add CSIDLFromID helper function.
- Return a context menu interface at CShellMenuCallback::OnGetContextMenu.
FIXME: CSIDL_CONTROLS, CSIDL_NETWORK, and CSIDL_PRINTERS context menu
wrongly open My Computer.
Katayama Hirofumi MZ [Tue, 12 Mar 2024 02:40:02 +0000 (11:40 +0900)]
[MSUTB] Implement CLangBarItemList (#6605)
Supporting the Language bar...
JIRA issue: CORE-19363
- Define LANGBARITEMSTATE structure.
- Implement CLangBarItemList class.
Katayama Hirofumi MZ [Mon, 11 Mar 2024 23:26:07 +0000 (08:26 +0900)]
[SHELL32] Start Menu Customize: Fix bMustHideAdminTools (#6604)
Follow-up to #6603. Fix a bug in Admin Tools display.
JIRA issue: CORE-16956
Fix the value of bMustHideAdminTools in CMenuSFToolbar::FillToolbar.
Katayama Hirofumi MZ [Mon, 11 Mar 2024 23:17:05 +0000 (08:17 +0900)]
[EXPLORER] Start Menu Customize: Use TreeView_GetRoot (#6603)
Follow-up to #6596. Enable the Favorite menu setting.
JIRA issue: CORE-16956
- Use TreeView_GetRoot instead of TreeView_GetFirstVisible in
CustomizeClassic_OnOK function.
Hermès Bélusca-Maïto [Mon, 11 Mar 2024 20:44:45 +0000 (21:44 +0100)]
[FREELDR] Deduplicate common message-box creation code.
Also, make the (T)uiSave/RestoreScreen() helpers manage themselves the
temporary memory buffer used to store the temporary screen snapshot.
Hermès Bélusca-Maïto [Mon, 11 Mar 2024 16:22:37 +0000 (17:22 +0100)]
[FREELDR] Minor formatting for MsgBox functions + add SAL annotations
Hermès Bélusca-Maïto [Sun, 10 Mar 2024 15:39:40 +0000 (16:39 +0100)]
[FREELDR] Move the arch-specific intrin_i.h inclusions to where they are actually needed (NTLDR)
Hermès Bélusca-Maïto [Sun, 10 Mar 2024 15:35:25 +0000 (16:35 +0100)]
[FREELDR] FrLdrHeapCreate: Show the memory type in the ERR().
Hermès Bélusca-Maïto [Sun, 10 Mar 2024 15:20:16 +0000 (16:20 +0100)]
[FREELDR] Initialize CandidatePageCount to zero, needed if the while-loop is not run.
Granted, if the while-loop is not run, this means there is no memory
available at all on the computer where FreeLdr is running, which is
quite unexpected. But do the initialization anyways, in order to avoid
more obscure bugs down the line.
On the other hand, PageLookupTableMemAddress doesn't need to be
pre-initialized, since it gets initialized unconditionally afterwards.
Hermès Bélusca-Maïto [Sat, 9 Mar 2024 10:52:33 +0000 (11:52 +0100)]
[FREELDR] pcat.cmake: minor cleanup
Hermès Bélusca-Maïto [Sat, 9 Mar 2024 10:45:27 +0000 (11:45 +0100)]
[FREELDR] Pre-initialize the INI section list, improve loops over sections and items.
Avoids dereferencing list entries to sections/items when these lists are empty.
IniParseFile(): Emit an error to the debug log when a candidate setting
is outside a section and skip it, instead of popping up an error on the UI.
Hermès Bélusca-Maïto [Sat, 9 Mar 2024 10:27:37 +0000 (11:27 +0100)]
[FREELDR] ueficon.c: Add missing support for HOME and END keys.
And reserve INSERT, PAGE_UP and PAGE_DOWN for future handling.
Hermès Bélusca-Maïto [Sat, 9 Mar 2024 10:27:00 +0000 (11:27 +0100)]
[FREELDR] Minor code cleanup in arch/uefi files
Hermès Bélusca-Maïto [Sat, 9 Mar 2024 10:25:10 +0000 (11:25 +0100)]
[FREELDR] i386/hwdisk.c: Use FIRST_BIOS_DISK and FIRST_PARTITION macros like what's done in UEFI code.
Serge Gautherie [Mon, 11 Mar 2024 14:35:34 +0000 (15:35 +0100)]
[DESK] SetScreenSaver(): Remove remnant 'DeleteMode' variable (#6593)
Addendum to commit
d21e3a1d2 (r58360).
Doug Lyons [Mon, 11 Mar 2024 13:34:34 +0000 (08:34 -0500)]
[NTUSER] Fix PeekMessageA for MsgFilterLow/High mouse clicks (#6427)
Fix MSO and Word Viewer not closing when "X" on title bar is clicked.
This is another @I_Kill_Bugs patch.
CORE-14436 , CORE-16985
Katayama Hirofumi MZ [Mon, 11 Mar 2024 12:58:30 +0000 (21:58 +0900)]
[EXPLORER][SHELL32] Show/hide 'Admin tools' menu (#6598)
Improve Start Menu customization.
JIRA issue: CORE-16956
- Add IsPidlPrograms helper function.
- Specify a PIDL for Programs menu.
- Check the "StartMenuAdminTools" registry value.
- Don't add "Admin Tools" menu item into
CMenuSFToolbar::FillToolbar if necessary.
Katayama Hirofumi MZ [Mon, 11 Mar 2024 11:18:07 +0000 (20:18 +0900)]
[EXPLORER][SHELL32] Fix and improve Start Menu customization (#6596)
Correct the details of Start Menu customization.
JIRA issue: CORE-16956
- Hide the setting item if the item is restricted.
- Don't change restriction in Explorer.
- Fix Start Menu settings for restriction and registry.
- Fix and simplify code.
Katayama Hirofumi MZ [Mon, 11 Mar 2024 07:19:46 +0000 (16:19 +0900)]
[EXPLORER][SHELL32] Expand/unexpand Control Panel menu (#6595)
Follow-up to #6594. Improve Start Menu customization.
JIRA issue: CORE-16956
- Add IDS_ADVANCED_EXPAND_CONTROL_PANEL, IDS_ADVANCED_EXPAND_PRINTERS,
and IDS_ADVANCED_EXPAND_NET_CONNECTIONS resource strings.
- Check the "CascadeControlPanel", "CascadeNetworkConnections", and "CascadePrinters"
registry values.
- Modify Start Menu by using AddOrSetMenuItem and AddStartMenuItems helper
functions in CShellMenuCallback::OnGetSubMenu.
Katayama Hirofumi MZ [Mon, 11 Mar 2024 04:18:58 +0000 (13:18 +0900)]
[EXPLORER][SHELL32] Expand/unexpand My Documents menu (#6594)
Follow-up to #6592. Improve Start Menu
customization.
JIRA issue: CORE-16956
- Add IDS_ADVANCED_EXPAND_MY_DOCUMENTS
and IDS_ADVANCED_EXPAND_MY_PICTURES
resource strings.
- Check L"CascadeMyDocuments" and
L"CascadeMyPictures" registry values.
- Add GetAdvancedValue helper function.
- Implement CreateRecentMenu function.
Katayama Hirofumi MZ [Mon, 11 Mar 2024 02:24:26 +0000 (11:24 +0900)]
[BOOT] Don't create CSIDL_ADMINTOOLS folder in initial (#6551)
We shouldn't create an empty CSIDL_ADMINTOOLS folder at initial status.
JIRA issue: CORE-12328
- Modify boot/boot_images.cmake.
Katayama Hirofumi MZ [Mon, 11 Mar 2024 01:54:12 +0000 (10:54 +0900)]
[EXPLORER][SHELL32][SDK] Show/hide 'Run' menu item (#6592)
Improve Start Menu customization.
JIRA issue: CORE-16956
- Add SHSettingsChanged prototype to
<undocshell.h>.
- Add SetRestriction helper function.
- Implement showing/hiding Run menu
item of Start Menu.
Katayama Hirofumi MZ [Sun, 10 Mar 2024 23:29:04 +0000 (08:29 +0900)]
[SHELL32][SHLWAPI][SDK] Implement SHRestricted etc. (#6560)
shell32!SHRestricted is necessary to make shell working well.
JIRA issue: CORE-11515
- Add dll/win32/shell32/wine/PolicyData.h to define the shell policy data.
- Define POLICYDATA structure and SHELL_NO_POLICY constant
in <shlwapi_undoc.h>.
- Fix shell32!SHRestricted, shell32!SHSettingsChanged,
shlwapi!SHGetRestriction, and shlwapi!SHRestrictionLookup functions.
Serge Gautherie [Tue, 27 Feb 2024 21:42:54 +0000 (22:42 +0100)]
[KILL] ExecuteKill(): Return '1' on failures
and add a related 'CloseHandle()' call.
Also, enforce PID 'unsigned' type.
Serge Gautherie [Tue, 27 Feb 2024 21:42:54 +0000 (22:42 +0100)]
[KILL] main(): Return actual return value
and get rid of 'tail' variable, which had wrong type anyway.
Also, be strict about parameter number: only 1 PID is supported.
Serge Gautherie [Tue, 27 Feb 2024 21:42:54 +0000 (22:42 +0100)]
[FORMATTING][KILL] kill.c: reformat it
Hermès Bélusca-Maïto [Fri, 23 Feb 2024 21:58:06 +0000 (22:58 +0100)]
[SDK:NDK/XDK] Sync NtCurrentTeb() definitions between NDK and PSDK winnt.h (#6542)
The definitions in the NDK inline_ntcurrentteb.h and psfuncs.h files are
synced togther with those of winnt.h (in the winnt_old.h generator file).
See commits
c1929445d (r49627) and
925c587c8 (r56318).
IMPORTANT NOTE: The ARM64 definition does not exist yet in our headers!
Hermès Bélusca-Maïto [Fri, 23 Feb 2024 21:53:36 +0000 (22:53 +0100)]
[SDK:NDK/XDK] Adjust the KeGetPcr() ARM definition (#6542)
Re-enable the KIPCR() macro and use it for KeGetPcr()
and KeGetCurrentProcessorNumber() definitions.
Hermès Bélusca-Maïto [Fri, 23 Feb 2024 21:53:36 +0000 (22:53 +0100)]
[SDK:NDK/XDK] Remove x86 KeGetPcr() definition from the DDK (#6526)
The official MS DDK/WDK does not expose KeGetPcr() for x86, so do
not expose it there as well. Use instead the private NDK definition.
If it were exposed in the DDK/WDK, it would have to be a
multiprocessor-compatible definition.
Note that the broken definition was working only in single-processor
mode, using the PCR static memory pointer value.
The official MS DDK/WDK exposes KeGetPcr() as an alias to such a
PCR value only for IA64, MIPS and PPC, which is of course not great.
Katayama Hirofumi MZ [Sun, 10 Mar 2024 13:36:40 +0000 (22:36 +0900)]
[IMM32_APITEST] Add KLID testcase (#6590)
Confirming keyboard layout
implementation by checking
HKL, KLID, and registry.
JIRA issue: CORE-19268
- Add KLID testcase.
- Check HKLs, KLIDs (Keyboard
Layout IDs), and related
registry, with using
user32!GetKeyboardLayoutList
function.
Katayama Hirofumi MZ [Sun, 10 Mar 2024 06:37:42 +0000 (15:37 +0900)]
[MSCTF] Implement GetHKLSubstitute (#6589)
Implementing the back-end of
the Language bar...
JIRA issue: CORE-19361
- Rename GetLocaleInfoString
as GetHKLName.
- Implement GetHKLSubstitute
helper function.
- Fix GetHKLDesctription function.
Katayama Hirofumi MZ [Sun, 10 Mar 2024 03:15:56 +0000 (12:15 +0900)]
[KBSWITCH][INPUT][SDK] Use <imm32_undoc.h>'s IS_IME_HKL (#6588)
Unify the private IMM32 macro
definitions. Refactoring...
JIRA issue: CORE-19361
- Define IS_SPECIAL_HKL macro
in <imm32_undoc.h>.
- Use IS_IME_HKL and
IS_SPECIAL_HKL macros of
<imm32_undoc.h>,
in kbswitch and input modules.
Katayama Hirofumi MZ [Sun, 10 Mar 2024 02:35:05 +0000 (11:35 +0900)]
[MSCTF][SDK] Implement multi-language handling (#6587)
Implementing the back-end of
the Language bar...
JIRA issue: CORE-19361
- Add mlng.cpp and mlng.h.
- Modify msctf.spec.
- Implement MLNGINFO
structure and CStaticIconList
class.
- Implement TF_InitMlngInfo,
TF_MlngInfoCount,
TF_InatExtractIcon,
TF_GetMlngIconIndex, and
TF_GetMlngHKL functions.
Katayama Hirofumi MZ [Sat, 9 Mar 2024 03:57:50 +0000 (12:57 +0900)]
[MSCTFIME] Implement CicBridge::Notify (#6586)
Supporting TIPs...
JIRA issue: CORE-19360
- Implement CicBridge::Notify
method.
- Implement CicBridge::
SetCompositionString method.
- Add some CicInputContext
methods (stub).
Katayama Hirofumi MZ [Sat, 9 Mar 2024 02:59:37 +0000 (11:59 +0900)]
[MSCTFIME] Implement CicBridge::EscapeKorean (#6585)
Supporting TIPs...
JIRA issue: CORE-19360
- Add CicBridge::EscHanjaMode.
- Add code to CicBridge::EscapeKorean.
Katayama Hirofumi MZ [Fri, 8 Mar 2024 11:43:32 +0000 (20:43 +0900)]
[MSCTFIME][SDK] Add CInputContextOwner (stub) (#6584)
Supporting TIPs...
JIRA issue: CORE-19360
- Add ITfContextOwner
interface to "msctf.idl".
- Stub-implement
CInputContextOwner class.
Katayama Hirofumi MZ [Fri, 8 Mar 2024 09:17:09 +0000 (18:17 +0900)]
[SHELL32_APITEST] Improve ShellHook testcase (#6582)
Make shell32:ShellHook testcase stable and trustworthy.
JIRA issue: ROSTESTS-389
- Use real shell hook.
- Delete HSHELL_RUDEAPPACTIVATED tests.
- Add HSHELL_WINDOWDESTROYED tests.
Katayama Hirofumi MZ [Fri, 8 Mar 2024 08:21:57 +0000 (17:21 +0900)]
[SHELL32_APITEST] Improve FindExecutable testcase (#6583)
Make shell32:FindExecutable testcase stable and trustworthy.
JIRA issue: ROSTESTS-389
- Reduce dependency with sub-program (instead use copy of
notepad.exe).
- Simplify.
Hermès Bélusca-Maïto [Thu, 7 Mar 2024 12:07:23 +0000 (13:07 +0100)]
[FREELDR][ROSSYM(_NEW)] Remove last vestigial references to "NTOSAPI".
This was a MinGW-specific, non-MS-DDK/WDK-compatible define, that was
used to mark NTOS kernel/hal exports, instead of NTSYSAPI etc.
We have since fixed that, and changed the way Freeldr (and rossym)
manages these, see commits:
186c8b72d (r16028),
51f0dfd30 (r17651) and
526efd2ee (r24359)
Timo Kreuzer [Sun, 21 Jan 2024 10:14:51 +0000 (12:14 +0200)]
[HALAPIC] Rename a field for consistency
Timo Kreuzer [Sat, 2 Mar 2024 10:48:09 +0000 (12:48 +0200)]
[CMLIB] Quick-fix a pool buffer overrun
A more complete fix is in PR #6064, but this needs to be fixed now.
Stanislav Motylkov [Wed, 6 Mar 2024 13:00:36 +0000 (16:00 +0300)]
[MAIN] Fix icon identifiers and their order
Additionally:
- Reuse printers and fonts folder icons from shell32,
the same way as it was done in
c0dbde04365.
The printers folder icon was missing here though.
- Fix "look_key" => "lock_key" typos.
This fixes Administrative Tools and Fonts Folder icons in Control Panel
when being restored to defaults with Stardock IconPackager 5.1.
CORE-19471
Hermès Bélusca-Maïto [Wed, 6 Mar 2024 11:22:40 +0000 (12:22 +0100)]
[KERNEL32][PSDK][NTVDM][CONSRV] Use now-documented ReadConsoleInputEx() flag names.
Addendum to commit
b8b8819c7 (r60920)
ReadConsoleInputEx() and its flags used to be undocumented.
In the meantime they became documented on MSDN, see:
https://learn.microsoft.com/en-us/windows/console/readconsoleinputex
We can therefore adopt these now-documented flag names.
Oleg Dubinskiy [Wed, 6 Mar 2024 10:56:26 +0000 (11:56 +0100)]
[MYDOCS] Add missing icons expected by 3rd party applications (#6576)
Add "My Documents" and "My Pictures" icons, with 100 and 101 identifiers
accordingly. They are duplicating the icons from shell32.
This fixes My Documents desktop icon becoming blank when reverting back
to the system default icons after applying 3rd party icon set in Stardock
IconPackager 5.1, and also fixes icons of some items in the application
preview dialog.
It's confirmed that mydocs.dll on Windows XP SP3 and Server 2003 SP2
includes these two icon resources with the said identifiers.
The icons there are being an exact copy from shell32 as well.
CORE-19471 CORE-14758
Katayama Hirofumi MZ [Tue, 5 Mar 2024 23:11:32 +0000 (08:11 +0900)]
[BROWSEUI] Fix CExplorerBand Right-Dragging menu (#6579)
Display correct menu on right-dragging
an item in Folder explorer bar to Desktop.
JIRA issue: CORE-19474
In CExplorerBand::OnTreeItemDragging
method:
- Use GetAttributesOf to get the
attributes of a folder item.
- Use correct dwEffect value for
DoDragDrop call.
Katayama Hirofumi MZ [Tue, 5 Mar 2024 22:58:07 +0000 (07:58 +0900)]
[NTDLL][NTDLL_APITEST] Add LdrLoadDll testcase (#6563)
JIRA issue: CORE-6585
- Add one comment into LdrpLoadDll function.
- Add LdrLoadDll testcase.
Katayama Hirofumi MZ [Tue, 5 Mar 2024 22:52:30 +0000 (07:52 +0900)]
[USER32_APITEST][SDK] Add GW_ENABLEDPOPUP testcase (#6564)
JIRA issue: CORE-6920
- Add GW_ENABLEDPOPUP constant to
<winuser.h>.
- Add GW_ENABLEDPOPUP testcase.
Vitaly Orekhov [Tue, 5 Mar 2024 08:42:27 +0000 (11:42 +0300)]
[ATL] Implement CSimpleStringT::Preallocate (#6574)
Used in `ATL::CStringW` and `ATL::CStringA`, for example:
```
ATL::CStringW cswItemText = "";
cswItemText.Preallocate(64);
SendDlgItemMessageW(pdis->CtlID, LB_GETTEXT, pdis->itemID, reinterpret_cast<LPARAM>(cswItemText.GetBuffer()));
cswItemText.ReleaseBuffer();
```
This public function is used to allocate memory for the string via private PrepareWrite, but it's missing somehow. Now it shouldn't be.
Andrei Miloiu [Tue, 5 Mar 2024 03:46:29 +0000 (05:46 +0200)]
[MSHTML] Update Romanian (ro-RO) translation (#6519)
Katayama Hirofumi MZ [Mon, 4 Mar 2024 23:43:39 +0000 (08:43 +0900)]
[SHELL32] Use STDMETHOD macro and keyword override (#6570)
For simplicity and short typing.
JIRA issue: CORE-19469
- Replace "virtual HRESULT STDMETHODCALLTYPE
m" with "STDMETHOD(m)" (m is a method name).
- Replace "virtual t STDMETHODCALLTYPE m" with
"STDMETHOD_(t, m)" (t is a type. m is a method
name).
- Use "override" keyword as possible.
- CDefView should inherit IShellView3 due to
override CreateViewWindow3 method.
- Fix CDefView::CreateViewWindow3 (parameter
prcView is const RECT *, not LPRECT).
Katayama Hirofumi MZ [Mon, 4 Mar 2024 15:53:11 +0000 (00:53 +0900)]
[BROWSEUI] Use STDMETHOD macro and keyword override (#6569)
For simplicity and short typing.
JIRA issue: CORE-19469
- Replace "virtual HRESULT
STDMETHODCALLTYPE m"
with "STDMETHOD(m)"
(m is a method name).
- Replace "virtual t
STDMETHODCALLTYPE m"
with "STDMETHOD_(t, m)"
(t is a type. m is a method name).
- Use "override" keyword as possible.
Katayama Hirofumi MZ [Mon, 4 Mar 2024 15:34:21 +0000 (00:34 +0900)]
[NTOBJSHEX] Use STDMETHOD macro and keyword override (#6566)
For simplicity and short typing.
JIRA issue: CORE-19469
- Replace "virtual HRESULT
STDMETHODCALLTYPE m" with
"STDMETHOD(m)" (m is a
method name).
- Replace "virtual t
STDMETHODCALLTYPE m"
with "STDMETHOD_(t, m)"
(t is a type. m is a method name).
- Use "override" keyword as possible.
Oleg Dubinskiy [Mon, 4 Mar 2024 13:30:43 +0000 (14:30 +0100)]
[SHELL32] Allow custom shortcut overlay icon (#6419)
Use correct icon index in SIC_OverlayShortcutImage() to properly load
shortcut overlay icon from registry instead of always using default icon.
This allows to use custom shortcut icon set by user, in case it was
specified there.
As FIXME comment stated, the icon indexes were not implemented in the far
past, so this workaround was badly required. But now they are implemented,
so no need to always use default resource from shell32, enable the correct
code instead.
Also adapt this to CShellLink::CreateShortcutIcon() when the shortcut icon
is being changed in its properties dialog, as well as in CNewMenu class
when displaying menu items for creating a new folder or a shortcut.
Addendum to
f9a5344254. CORE-14758
Timo Kreuzer [Thu, 23 Nov 2023 20:21:12 +0000 (22:21 +0200)]
[NTOS:EX] Remove an ASSERT in ExpInsertPoolTracker
Katayama Hirofumi MZ [Sun, 3 Mar 2024 01:14:05 +0000 (10:14 +0900)]
[RSHELL] Use STDMETHOD macro and keyword override (#6575)
For simplicity and short typing.
JIRA issue: CORE-19469
- Replace "virtual HRESULT
STDMETHODCALLTYPE m" with
"STDMETHOD(m)" (m is a method name).
- Replace "virtual t STDMETHODCALLTYPE
m" with "STDMETHOD_(t, m)"
(t is a type. m is a method name).
- Use "override" keyword as possible.
Katayama Hirofumi MZ [Sat, 2 Mar 2024 12:38:52 +0000 (21:38 +0900)]
[NETSHELL] Use STDMETHOD macro and keyword override (#6568)
For simplicity and short typing.
JIRA issue: CORE-19469
- Replace "virtual HRESULT STDMETHODCALLTYPE m"
with "STDMETHOD(m)" (m is a method name).
- Replace "virtual t STDMETHODCALLTYPE m" with
"STDMETHOD_(t, m)" (t is a type. m is a method
name).
- Use override keyword as possible.
Katayama Hirofumi MZ [Sat, 2 Mar 2024 12:37:05 +0000 (21:37 +0900)]
[ACPPAGE] Use STDMETHOD macro and keyword override (#6567)
For simplicity and short typing.
JIRA issue: CORE-19469
- Replace "virtual HRESULT STDMETHODCALLTYPE
m" with "STDMETHOD(m)" (m is a method name).
- Replace "virtual t STDMETHODCALLTYPE m" with
"STDMETHOD_(t, m)" (t is a type. m is a method
name).
- Use "override" keyword as possible.
Timo Kreuzer [Sat, 24 Feb 2024 10:05:12 +0000 (12:05 +0200)]
[HALX86] Implement the clock IPI handler
Timo Kreuzer [Mon, 27 Nov 2023 05:51:51 +0000 (07:51 +0200)]
[HALX86] Move apicsmp.c to lib_hal_smp
Timo Kreuzer [Tue, 27 Feb 2024 17:58:11 +0000 (19:58 +0200)]
[NTOS/x64] Gracefully handle invalid Vector in KeConnectInterrupt
Fail instead of asserting. This is needed because a kmtest triggers it.
Katayama Hirofumi MZ [Fri, 1 Mar 2024 13:51:57 +0000 (22:51 +0900)]
[CMD] Enable Ctrl+H (^H) as backspace (#6562)
Ctrl+H should pretend like BackSpace key
on Command Prompt.
JIRA issue: CORE-5702
- Add Ctrl+H action in ReadCommand function.
Katayama Hirofumi MZ [Thu, 29 Feb 2024 23:42:59 +0000 (08:42 +0900)]
[APPWIZ] Shortcut: Rename if there is a conflict (#6556)
Follow-up to #6550. Avoid same name
overwriting.
JIRA issue: CORE-5866
- Rename the filename if there was duplicate.
- Simplify CreateShortcut function.
- Rename IDC_SHORTCUT_LOCATION as
IDC_LINK_LOCATION to resolve name conflict
with shell32/shresdef.h.
Joachim Henze [Thu, 29 Feb 2024 21:17:27 +0000 (22:17 +0100)]
[NETCFGX] Proper accelerators for en-US and de-DE (#6199)
proper accelerators for en-US (like english 2k3sp2)
proper accelerators for de-DE (like german XPSP3)
slightly improved accelerators for fr-FR
and mark existing accelerator collisions for all other languages with FIXME-comments.
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com> for ukrainian header
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org> for fr-FR
Piotr Hetnarowicz [Thu, 29 Feb 2024 18:20:48 +0000 (19:20 +0100)]
[APPWIZ] Update Polish (pl-PL) translation (#6559)
Hermès Bélusca-Maïto [Mon, 10 Jan 2022 19:17:08 +0000 (20:17 +0100)]
[SHELL32:WINE] Improve ROS-specific registry opening in SHRestricted() (#4275)
Hermès Bélusca-Maïto [Mon, 10 Jan 2022 19:05:38 +0000 (20:05 +0100)]
[SHELL32:WINE] Update the table of policy restrictions (#4275)
Our shell32's wine/shpolicy.c file, synced with Wine code (and which is
currently in master still up to date with Wine!), contains outdated or
incomplete definitions that date back from Windows 98/2000.
Update the restrictions with those from shell32 v6.0 of Windows Server 2003 SP2.
References:
https://www.geoffchappell.com/studies/windows/shell/shell32/api/util/restrictions.htm
https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/ne-shlobj_core-restrictions
"NoLogoff": http://systemmanager.ru/win2k_regestry.en/93519.htm
"StartMenuLogOff": http://systemmanager.ru/win2k_regestry.en/92884.htm
"GreyMSIAds": http://systemmanager.ru/win2k_regestry.en/93177.htm
Hermès Bélusca-Maïto [Mon, 10 Jan 2022 19:09:26 +0000 (20:09 +0100)]
[SHELL32:WINE] Add Wine-version info to the Wine's shell32_main header.
Hermès Bélusca-Maïto [Mon, 10 Jan 2022 19:02:18 +0000 (20:02 +0100)]
[SHELL32:WINE] Make the wine-imported files include shell32_main.h
Hermès Bélusca-Maïto [Mon, 10 Jan 2022 14:59:50 +0000 (15:59 +0100)]
[SHELL32] SHAddToRecentDocs(): Just use SHRestricted() to get the NoRecentDocsHistory policy...
... instead of redoing the manual work.
Hermès Bélusca-Maïto [Mon, 10 Jan 2022 14:53:46 +0000 (15:53 +0100)]
[SHELL32] Set a sane SHELL32 versioning, when compiled for NT 5.2 and NT 6+.
i.e. don't keep using version from Windows 2000...
Values taken from
https://www.geoffchappell.com/studies/windows/shell/shell32/history/index.htm