Johannes Anderwald [Thu, 28 Oct 2010 23:33:50 +0000 (23:33 +0000)]
- remove rtl dependency
- thanks to mephisto!
svn path=/trunk/; revision=49335
Aleksey Bragin [Thu, 28 Oct 2010 22:08:18 +0000 (22:08 +0000)]
Roel Messiant:
- Heap corruption fixes.
svn path=/trunk/; revision=49332
Giannis Adamopoulos [Thu, 28 Oct 2010 17:14:29 +0000 (17:14 +0000)]
[win32k]
message.c:
- Don't use RETURN macro
- Correctly use SEH. Use _SEH2_YIELD
svn path=/trunk/; revision=49331
Timo Kreuzer [Thu, 28 Oct 2010 08:15:41 +0000 (08:15 +0000)]
[FORMATTING]
- Replace big file header with small header
- apply consistent indentation of 4 spaces
svn path=/trunk/; revision=49324
Timo Kreuzer [Wed, 27 Oct 2010 22:58:23 +0000 (22:58 +0000)]
[NTOSKRNL]
- Add IoWMIDeviceObjectToProviderId and IoIs32bitProcess stubs for 64bit builds
- Comment out some deprecated amd64 code
- Add MmProtectToValue
- Fix a typo
svn path=/trunk/; revision=49322
Johannes Anderwald [Wed, 27 Oct 2010 21:12:44 +0000 (21:12 +0000)]
- remove debug prints
- dedicated to christoph
svn path=/trunk/; revision=49316
Timo Kreuzer [Wed, 27 Oct 2010 20:40:59 +0000 (20:40 +0000)]
[CLASSPNP]
Fix a typo in the spec file
svn path=/trunk/; revision=49314
Giannis Adamopoulos [Wed, 27 Oct 2010 20:31:17 +0000 (20:31 +0000)]
[FORMATTING]
- Fix formatting in message.c
svn path=/trunk/; revision=49313
Timo Kreuzer [Wed, 27 Oct 2010 20:14:15 +0000 (20:14 +0000)]
[basetsd.h]
add POINTER_SIGNED, POINTER_UNSIGNED, SPOINTER_32, UPOINTER_32
svn path=/trunk/; revision=49312
Timo Kreuzer [Wed, 27 Oct 2010 20:13:06 +0000 (20:13 +0000)]
[CLASSPNP]
Convert to spec
svn path=/trunk/; revision=49311
Timo Kreuzer [Wed, 27 Oct 2010 17:16:11 +0000 (17:16 +0000)]
[WIN32K]
Improve the code to enumerate monitors.
- Don't use custom MIN / MAX / ABS macros
- Calculate distance by r^2 = x^2 + y^2
- Use RECTL_bIntersectRect instead of code duplication
- Fix possible NULL pointer dereference
- pass bottom-right exclusive rect to IntGetMonitorsFromRect from NtUserMonitorFromPoint
- Don't handle MONITOR_DEFAULTTOPRIMARY and MONITOR_DEFAULTTONEAREST twice
- Use unsigned variables for unsigned values
- Don't check the result of a UINT returning function for < 0
- Improve readability
svn path=/trunk/; revision=49310
Timo Kreuzer [Wed, 27 Oct 2010 17:08:40 +0000 (17:08 +0000)]
[WIN32K]
Fix possible NULL pointer dereferences. Spotted by Amine Khaldi.
svn path=/trunk/; revision=49309
Timo Kreuzer [Wed, 27 Oct 2010 15:59:48 +0000 (15:59 +0000)]
[FORMATTING]
- Apply consistent indentation of 4 spaces and ansi style formatting.
- Remove the long GPL header
svn path=/trunk/; revision=49308
Timo Kreuzer [Wed, 27 Oct 2010 12:51:32 +0000 (12:51 +0000)]
[WIN32K]
Fix possible NULL pointer dereference. Spotted by Amine Khaldi.
svn path=/trunk/; revision=49303
Aleksey Bragin [Wed, 27 Oct 2010 09:58:18 +0000 (09:58 +0000)]
[NTOS/MM]
- Don't access pfn database directly, there is a function for this. Thanks sir_richard.
svn path=/trunk/; revision=49302
James Tabor [Wed, 27 Oct 2010 01:56:56 +0000 (01:56 +0000)]
[Win32k|User32]
- Fix for DosBOX. See bug 5670 for more details. Added more data copies in user32 hook.c.
svn path=/trunk/; revision=49301
James Tabor [Wed, 27 Oct 2010 00:03:41 +0000 (00:03 +0000)]
[User32] - Fix an over site and copy the return data back to the kernel.
svn path=/trunk/; revision=49300
Aleksey Bragin [Tue, 26 Oct 2010 21:34:52 +0000 (21:34 +0000)]
[NTOS/MM]
- Don't lie about page protection in MiQueryAddressState. Fixes PDFCreator-alike bugs.
See issue #5627 for more details.
svn path=/trunk/; revision=49296
Johannes Anderwald [Tue, 26 Oct 2010 15:19:14 +0000 (15:19 +0000)]
[PORTCLS]
- Disable driver specific filter / pin / node property handlers until bug leading to crashes has been found
svn path=/trunk/; revision=49280
James Tabor [Tue, 26 Oct 2010 06:24:50 +0000 (06:24 +0000)]
[Win32k|User32]
- Add fix for KsStudio for Olaf Siejka and debug prints for WH_KEYBOARD_LL. See bug 5670 for more details.
svn path=/trunk/; revision=49278
Aleksey Bragin [Mon, 25 Oct 2010 20:50:45 +0000 (20:50 +0000)]
[NTOS/MM]
- Handle various special cases in NtQueryVirtualMemory (e.g. querying illegal virtual addresses, shared memory area, etc). Example of an app doing this - OllyDbg.
svn path=/trunk/; revision=49277
Daniel Reimer [Mon, 25 Oct 2010 20:08:50 +0000 (20:08 +0000)]
Update rapps database.
svn path=/trunk/; revision=49276
Timo Kreuzer [Mon, 25 Oct 2010 17:36:27 +0000 (17:36 +0000)]
[YAROTOWS] Reintegrate the branch. For a brighter future.
Main features:
- Implement LDEVOBJ api. Responsible for loading dlls (display drivers, font drivers, keyboard layout, etc), replacing code in different locations.
- Implement PDEVOBJ api. A PDEVOBJ represents a physical device and is the core component for handling multiple display devices.
- Rewrite device locking. The new method was neccessary to allow dynamic mode switching.
- Implement support for enumerating display devices and settings.
- Implement dynamic mode switching.
- Implement a number of Eng mapping functions.
- Rewrite Eng level surface handling for cleaner code and better compatability.
- Rewrite parts of the DIB handling code.
- Rewrite DC creation and deletion. Deletion and cleanup is now completely callback based. Now we don't leak the DC objects when terminating a process, like we did before.
- Improve the XLATE and BRUSH code, removing several old hacks.
- Improve icon code.
Thanks to Jerome Gardou, Kamil Hornicek and everyone helping.
svn path=/trunk/; revision=49275
Timo Kreuzer [Mon, 25 Oct 2010 15:26:06 +0000 (15:26 +0000)]
Merge trunk head (r49270)
svn path=/branches/reactos-yarotows/; revision=49272
Timo Kreuzer [Mon, 25 Oct 2010 15:05:33 +0000 (15:05 +0000)]
[WIN32K]
Silence and improve a DPRINT
svn path=/branches/reactos-yarotows/; revision=49271
James Tabor [Mon, 25 Oct 2010 02:51:09 +0000 (02:51 +0000)]
[Win32k]
- Do not override WH_JOURNALPLAYBACK results if zero.
svn path=/trunk/; revision=49270
James Tabor [Mon, 25 Oct 2010 01:37:14 +0000 (01:37 +0000)]
[Win32k]
- Fix typos found by Mephisto on IRC, also add some debug prints in SetWindowsHookEx to see what hooks are installed.
svn path=/trunk/; revision=49269
James Tabor [Mon, 25 Oct 2010 00:15:35 +0000 (00:15 +0000)]
[User32]
- One more leftover to add. Now we test for both Local and Global hooks in user32. This will force any message sent to win32k if there are any Global hookers so we loose in performance. We need to rethink our usage of these Global hookers in our code.
svn path=/trunk/; revision=49268
Kamil Hornicek [Sun, 24 Oct 2010 23:40:23 +0000 (23:40 +0000)]
[WIN32K]
Simplify the RLE hack and avoid code duplication.
Bail out of UserEnumDisplaySettings early in case invalid ModeNum was requested.
Use default BPP value in UserChangeDisplaySettings if DM_BITSPERPEL is not set. Partially fixes "fullscreen issue" as described on the yarotows wiki page.
Remove some unused variables + misc cleanup.
svn path=/branches/reactos-yarotows/; revision=49267
Timo Kreuzer [Sun, 24 Oct 2010 23:32:18 +0000 (23:32 +0000)]
[WIN32K]
- Rewrite InitVideo
- Move registry functions to the appropriate file
- Silence some DPRINTs
svn path=/branches/reactos-yarotows/; revision=49266
Kamil Hornicek [Sun, 24 Oct 2010 22:52:50 +0000 (22:52 +0000)]
[WIN32K]
Set proper flags and masks in BuildDIBPalette. Set PAL_BGR for 24/32 BPP in AllocPalette. Rename Mode to Flags to better reflect its usage. Fixes "red icons" and dibtest.
svn path=/branches/reactos-yarotows/; revision=49265
Kamil Hornicek [Sun, 24 Oct 2010 22:51:51 +0000 (22:51 +0000)]
[WIN32K]
Follow-up to r48681. Fixes text on disabled controls.
svn path=/branches/reactos-yarotows/; revision=49264
Aleksey Bragin [Sun, 24 Oct 2010 20:02:04 +0000 (20:02 +0000)]
[N[NTOS/MM]
- Initialize Found to FALSE in NtQueryVirtualMemory. I wonder how GCC missed uninitialized var usage?
- Implement case when NtQueryVirtualMemory is called with non-existing virtual address.
See issue #3755 for more details.
svn path=/trunk/; revision=49261
Eric Kohl [Sun, 24 Oct 2010 13:48:11 +0000 (13:48 +0000)]
[SERVICES]
RControlService: Check the current state before sending a control request.
svn path=/trunk/; revision=49259
Timo Kreuzer [Sun, 24 Oct 2010 11:57:02 +0000 (11:57 +0000)]
[WIN32K]
Fix possible NULL pointer free. Fixes solitaire.
svn path=/branches/reactos-yarotows/; revision=49257
Cameron Gutman [Sun, 24 Oct 2010 10:48:10 +0000 (10:48 +0000)]
[HAL]
- Fix a broken loop that resulted in us registering the resources of multiple COM ports as our KD port
- Fixes bug #5530
svn path=/trunk/; revision=49256
Cameron Gutman [Sun, 24 Oct 2010 10:28:15 +0000 (10:28 +0000)]
[HAL]
- HalpEnableInterruptHandler: Set the IDT_LATCHED flag if the caller requested a latched interrupt
svn path=/trunk/; revision=49255
Eric Kohl [Sun, 24 Oct 2010 09:21:37 +0000 (09:21 +0000)]
[SERVICES]
- Use new handle check functions in RCloseServiceHandle().
- RControlService: Check if a control request is acceptable for a user mode service before sending it to the service.
svn path=/trunk/; revision=49253
Cameron Gutman [Sun, 24 Oct 2010 09:05:17 +0000 (09:05 +0000)]
[NTOSKRNL]
- Fix a critical bug in the conflict detection code
- Don't unconditionally skip conflict detection for shared resources, instead it should be done on a descriptor-by-descriptor basis (if both descriptors are shared)
- This check wasn't removed when I initially wrote this code and added the proper check below
svn path=/trunk/; revision=49252
Cameron Gutman [Sun, 24 Oct 2010 06:16:35 +0000 (06:16 +0000)]
[PNPMGR]
- Check that we got a valid vector back from HAL when translating an interrupt resource
- Add some debugging messages for failure paths in device resource handling code
svn path=/trunk/; revision=49251
James Tabor [Sun, 24 Oct 2010 04:36:45 +0000 (04:36 +0000)]
[Win32k]
- Fix an exception when set condition * first always is used then moving the mouse. There seems to be an initialization issue (The Init Bug) and not setting a desktop.
svn path=/trunk/; revision=49250
Cameron Gutman [Sun, 24 Oct 2010 02:51:48 +0000 (02:51 +0000)]
[NTOSKRNL]
- Partially implement IoAssignResources so that it creates a non-conflicting resource list from the requirements but it doesn't claim the resources for the device in the registry
- Partially implement IoReportResourceUsage so that it checks the resource list for conflicts but doesn't claim the resources in the registry
- Please test this revision with a variety of hardware and drivers because it activates several code paths in the PnP manager
- If this causes problems, look for "Denying an attempt to claim resources currently in use by another device!" in the debug log and report the bug to me
svn path=/trunk/; revision=49249
Cameron Gutman [Sun, 24 Oct 2010 02:38:14 +0000 (02:38 +0000)]
[NTOSKRNL]
- Rewrite the resource map code to fix a regression, several failures cases, and a few memory leaks
- Remove an incorrect definition of IopDetectResourceConflict in pnpreport.c (no idea how this didn't trigger an onslaught of warnings)
svn path=/trunk/; revision=49248
Timo Kreuzer [Sat, 23 Oct 2010 22:34:47 +0000 (22:34 +0000)]
Fix a comment
svn path=/trunk/; revision=49247
Timo Kreuzer [Sat, 23 Oct 2010 21:59:21 +0000 (21:59 +0000)]
[WIN32K]
- Remove a wrong ASSERT
- Improve EngLoadImageEx to correctly handle the path and optional dll extension.
- Get rid of EngLoadDriver
svn path=/branches/reactos-yarotows/; revision=49245
Johannes Anderwald [Sat, 23 Oct 2010 20:20:18 +0000 (20:20 +0000)]
[PORTCLS]
- Fix multiple bugs in round buffer implementation
- Should result in less audio glitches, especially when playing audio files with low sample rates. Please report any regressions!
svn path=/trunk/; revision=49244
Johannes Anderwald [Sat, 23 Oct 2010 18:51:17 +0000 (18:51 +0000)]
[PORTCLS]
- Rewrite the topology filter / pin / node property handling
- Store property sets of filter / pins / nodes in a common property set array
- Write a common dispatch function, which serves as a trampoline for filter / pin / node property requests
- Private property handlers of the drivers are now accessible
svn path=/trunk/; revision=49243
Johannes Anderwald [Sat, 23 Oct 2010 18:42:59 +0000 (18:42 +0000)]
[PORTCLS]
- Remove silence buffer hack
- Stub DRM Property Handler
- Before stopping the audio pin, fill the dma buffer with silence samples
- create a subdevice descriptor for instantiated pins too
svn path=/trunk/; revision=49242
Timo Kreuzer [Sat, 23 Oct 2010 17:05:34 +0000 (17:05 +0000)]
[FORMATTING]
Fix indentation, no code change.
svn path=/branches/reactos-yarotows/; revision=49241
Timo Kreuzer [Sat, 23 Oct 2010 16:42:45 +0000 (16:42 +0000)]
sync with trunk (r49238)
svn path=/branches/reactos-yarotows/; revision=49240
Johannes Anderwald [Sat, 23 Oct 2010 14:42:22 +0000 (14:42 +0000)]
- Fix definition of KSPROPSETID_DrmAudioStream, KSPROPERTY_DRMAUDIOSTREAM
svn path=/trunk/; revision=49239
Johannes Anderwald [Sat, 23 Oct 2010 12:10:56 +0000 (12:10 +0000)]
[PORTCLS]
- Fix check if the pin can be instantiated another time
- Remove hack to close old
- Add function FreePin to remove its old reference
- Fix memory leaks / reference leaks in WavePci pin implementation
- Fix memory / reference leaks in WavePci Close implementation
svn path=/trunk/; revision=49238
Johannes Anderwald [Sat, 23 Oct 2010 12:00:11 +0000 (12:00 +0000)]
[KS]
- Fix property set support handler for topology nodes
- Check if the driver supports a basic support handler. In that case return the basic support handler
svn path=/trunk/; revision=49237
James Tabor [Sat, 23 Oct 2010 05:36:12 +0000 (05:36 +0000)]
[Win32k|User32]
- Rewrite the Event and Hook procedures. See bug 5670 for more details.
svn path=/trunk/; revision=49231
Aleksey Bragin [Fri, 22 Oct 2010 16:22:21 +0000 (16:22 +0000)]
[MSI]
- Fix freed memory access and fix freeing of invalid pointer. (from http://www.winehq.org/pipermail/wine-patches/2010-October/094849.html )
See issue #3755 for more details.
svn path=/trunk/; revision=49229
Aleksey Bragin [Fri, 22 Oct 2010 13:18:11 +0000 (13:18 +0000)]
[MSI]
- Sync to Wine-1.3.5.
svn path=/trunk/; revision=49219
Aleksey Bragin [Thu, 21 Oct 2010 20:30:37 +0000 (20:30 +0000)]
[ADVAPI32]
- Roel Messiant: Fix short-circuit evaluation.
See issue #5677 for more details.
svn path=/trunk/; revision=49216
Eric Kohl [Wed, 20 Oct 2010 17:28:10 +0000 (17:28 +0000)]
[SERVICES]
- Remove the reference counter from the common handle type as a handle is never shared or duplicated.
- Remove the access right from the service handle as it is not used.
- Dereference service manager handles and service handles in two separate functions that SEH-protect the initial access to the handle and signature check. This will protect SCM from bogus handles.
svn path=/trunk/; revision=49214
Pierre Schweitzer [Tue, 19 Oct 2010 20:34:48 +0000 (20:34 +0000)]
[NTOSKRNL]
Implemented FstubAdjustPartitionCount(), FstubConvertExtendedToLayout(), FstubCopyEntryEFI(), FstubCreateDiskMBR(), FstubCreateDiskEFI(), FstubCreateDiskRaw(), FstubDbgPrintSetPartitionEx(), FstubReadHeaderEFI(), FstubReadPartitionTableEFI(), FstubSetPartitionInformationEFI(), FstubVerifyPartitionTableEFI(), FstubWriteBootSectorEFI(), FstubWriteEntryEFI(), FstubWriteHeaderEFI(), FstubWritePartitionTableEFI(), FstubWritePartitionTableMBR(), FstubWriteSector()
Implemented IoCreateDisk(), IoGetBootDiskInformation(), IoReadDiskSignature(), IoSetPartitionInformationEx(), IoVerifyPartitionTable(), IoWritePartitionTableEx()
To sum up, this commit finishes FSTUB API implementation in the ReactOS kernel. This means one important thing: now ReactOS kernel knows about a bit about EFI and about GPT. No need to say that it's the first step into EFI support. But a lot more work is needed. Especially since the kernel is the only real entity in ReactOS to handle GPT. All the rest of the OS doesn't know anything about GPT.
A small note about FstubVerifyPartitionTableEFI(). This function is supposed to check whether a disk formated with GPT is valid, and if it's not, to fix it. First step is implemented. Second step isn't yet supported.
A general note about all that stuff: on GPT, backup table isn't properly handled for the moment, as ReactOS is experiencing disk geometry issues. That means it's not having the proper disk sectors count and then, can't find the backup table (which is located on last disk sector).
References:
http://www.intel.com/technology/efi/
http://developer.apple.com/library/mac/#technotes/tn2006/tn2166.html
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.35.y.git;a=blob;f=fs/partitions/efi.h;hb=HEAD
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.35.y.git;a=blob;f=fs/partitions/efi.c;hb=HEAD
svn path=/trunk/; revision=49212
Sir Richard [Tue, 19 Oct 2010 20:23:37 +0000 (20:23 +0000)]
[NTOS]: Go back to using RosMm for the NLS section since supposedly this causes issues on some systems. This is the only actual change in r206/208/209, so if Caemyr's data is correct, this fill fix it.
svn path=/trunk/; revision=49211
Pierre Schweitzer [Tue, 19 Oct 2010 19:27:28 +0000 (19:27 +0000)]
[DISK]
Hackplemented support for IOCTL_DISK_GET_PARTITION_INFO_EX. It will work fine for MBR partitions but will fake returns for GPT partitions.
svn path=/trunk/; revision=49210
Sir Richard [Tue, 19 Oct 2010 18:57:30 +0000 (18:57 +0000)]
[NTOS]: Fix multiple math/logic bugs in the PrototypePTE paths. Caught while trying to switch the Win32k GDI Handle Table to ARM3 sections.
svn path=/trunk/; revision=49209
Sir Richard [Tue, 19 Oct 2010 17:39:22 +0000 (17:39 +0000)]
[NTOS]: C Pointer Math will bite even the most experienced programmer in the ass. Fix wrong calculation which led to ASSERTs and memory corruption (since the last revision).
svn path=/trunk/; revision=49208
Sir Richard [Tue, 19 Oct 2010 17:07:11 +0000 (17:07 +0000)]
[NTOS]: Add support for unmapping ARM3 sections, destroying segments and control areas, and clearing out subsection PTEs.
[NTOS]: Add support to MiDeletePte/MiDeleteVirtualAddresses to handle Section VADs.
[NTOS]: Add support to MiDeletePte to handle valid, prototype PTEs.
[NTOS]: Add MEM_TOP_DOWN support to ARM3 section code.
[NTOS]: Add support for unmapping currently mapped ARM3 section views at process termination.
[NTOS]: Use the new ARM3 section code for mapping the NLS section in the system (tests the system-view mapping code) and in each new process (tests the data-mapping code). Section is correctly unmapped at process termination time!
svn path=/trunk/; revision=49206
Sir Richard [Tue, 19 Oct 2010 17:01:28 +0000 (17:01 +0000)]
[NTOS]: Use allocation attribute 0x1 instead of 0xC0000000 to let RosMm know this is an ARM3 section. 0xC0000000 is actually a valid combination of SEC_ flags, 0x1 is illegal and thus recognized.
svn path=/trunk/; revision=49205
Sir Richard [Tue, 19 Oct 2010 17:00:12 +0000 (17:00 +0000)]
[NTOS]: Implement the MAREA<->VAD hack for section VADs as well.
svn path=/trunk/; revision=49204
Sir Richard [Tue, 19 Oct 2010 16:58:27 +0000 (16:58 +0000)]
[NTOS]: Get rid of MC_NPPOOL and MC_PPOOL memory consumers since those are not managed by RosMm anymore. Use MC_SYSTEM for the page table stuff that RosMm still handles, and keep MC_USER and MC_CACHE for the current Section/VirtualMemory/Cache RosMm code.
svn path=/trunk/; revision=49203
Sir Richard [Tue, 19 Oct 2010 16:57:20 +0000 (16:57 +0000)]
[NDK]: Add MMVAD_SHORT.
svn path=/trunk/; revision=49202
Sir Richard [Tue, 19 Oct 2010 04:30:48 +0000 (04:30 +0000)]
[NTOS]: Implement MiDecrementReferenceCount and rewrite large parts of the ProbeAndLock/Unlock MDL API to fully use ARM3 APIs, dropping MmReference/DereferencePage behind.
[NTOS]: Fix many MDL API bugs: correctly check for I/O pages, use LIST_HEAD instead of -1, track system-wide locked pages, use the process working set lock instead of the address space lock, add check for cross-ring MDL mappings, and make some small optimizations.
[NTOS]: Make some more fixes in MmAllocatePagesForMdl, MmFreeMdlPages to make the PFN entries more "correct".
[NTOS]: Had a little breakthrough: instead of complicating our lives and hiding certain ReactOS-Mm fields inside legitimate ARM3/MMPFN fields, differentiate between "legacy" (RosMm) and ARM3 pages. The legacy allocator (MmAllocPage/MmRequestPageMemoryConsumer) will use the non-paged pool to allocate a MMROSPFN add-on (8 bytes), in which the RMAP list head and SWAPENTRY are stored. When a legacy "free" is done, this data is deleted. Additionally, we can now tell apart between ARM3 and RosMm pages, so appropriate ASSERTs have been added to make sure the two never cross paths (which should safely let us use all the PFN fields now and implement working sets, etc...). I don't know why I didn't think of this sooner.
svn path=/trunk/; revision=49201
Sir Richard [Mon, 18 Oct 2010 23:07:09 +0000 (23:07 +0000)]
[NTOS]: Clean up Mm initialization, there is now no-more RosMM stuff done in Phase 0 of MmInit, only ARM3 runs. The kernel address space and memory areas are only initialized in Phase 1, because that's where sections are started up, and they're the only thing other than VM which still use memory-areas.
svn path=/trunk/; revision=49200
Johannes Anderwald [Mon, 18 Oct 2010 22:21:00 +0000 (22:21 +0000)]
[KS]
- Fix KSPROPERTY_PIN_CATEGORY handler when no category is provided
- Fix KSPROPERTY_PIN_NAME handler when there is no name provided. Use fallback pin category. If there is no category provided, fail with correct error code
- Fix KSPROPERTY_TOPOLOGY_NAME handler by checking if there is a node name provided. If not use node type as fallback.
- Return correct error code when property request id is out of bounds
svn path=/trunk/; revision=49199
Johannes Anderwald [Mon, 18 Oct 2010 18:59:17 +0000 (18:59 +0000)]
[PORTCLS]
- Store Miniport object in the device descriptor
- Fixes assert in NVidia NForce Audio Driver
svn path=/trunk/; revision=49198
Sir Richard [Mon, 18 Oct 2010 14:34:35 +0000 (14:34 +0000)]
[NTOS]: Remove the "35314 sginsberg /* REACTOS Mm Hack of Doom */". Apocalypse averted?
svn path=/trunk/; revision=49196
Sir Richard [Mon, 18 Oct 2010 14:29:05 +0000 (14:29 +0000)]
[NTOS]: Remove the Bavarian hack, I no longer think it is needed.
svn path=/trunk/; revision=49195
Sir Richard [Mon, 18 Oct 2010 14:25:33 +0000 (14:25 +0000)]
[NTOS]: Store the protection mask in the Fake VADs as well, we can read/convert this from the MAREA protection value.
[NTOS]: Reimplement NtQueryVirtualMemory to use VAD information instead. Even though Alloc/Free are still MAREA-based, the fake VADs we build ought to be enough to make the query API work for certain limited scenarios. Only some paths are implemented and it's lacking SEH, but it's good enough for the install/boot requirements. If there are any regressions, please file bugs.
svn path=/trunk/; revision=49194
Sir Richard [Mon, 18 Oct 2010 13:10:54 +0000 (13:10 +0000)]
[NTOS]: Complete the VAD-to-MAREA Synchronization hack by removing fake MAREAs that were added when inserting real VADs. To do this, we have to track the fake MAREA associated with a VAD, so we overload the FirstProtoTypePte field in the VAD, if this is NOT a section VAD (which we don't use yet). We'll figure something out for section VADs later.
[NTOS]: Now that VAD and MAREA views are synchronized, remove the VAD limit and let VADs be created at any address. Also do not create an arbitrary 16MB VAD memory area anymore. This basically now allows for as many PEB/TEBs as can fit in the address space, fixing the recent known regression that limited the number of threads a process could have.
svn path=/trunk/; revision=49193
Johannes Anderwald [Sun, 17 Oct 2010 22:38:34 +0000 (22:38 +0000)]
[WDMAUD.DRV]
- Kernel streaming pins need to transit states from Run -> Pause -> Acquire -> Stop.
- Fixes SB Live playback hang on last tone when stopping playback
svn path=/trunk/; revision=49191
Johannes Anderwald [Sun, 17 Oct 2010 21:15:21 +0000 (21:15 +0000)]
[MMIXER]
- Apply a hack to filter out pins, which are not part of filter node processing path
- The hack filters out all pins which have a physical connection. Ideally the code should check if the pin is part of a different rendering path and in that case remove the pin.
- Revert 49167
svn path=/trunk/; revision=49189
Sir Richard [Sun, 17 Oct 2010 20:11:04 +0000 (20:11 +0000)]
[NTOS]: Fix brainfart (an interesting bug we would've never hit, but a bug nevertheless).
svn path=/trunk/; revision=49188
Sir Richard [Sun, 17 Oct 2010 20:02:17 +0000 (20:02 +0000)]
[NTOS]: Use MI_SET_PFN_DELETED where we missed it.
[NTOS]: Implement support for deleting user-mode pageable VM addresses. Now when cleaning up the process address space, MiDeleteVirtualAddresses is called for the VADs, so this will now actually free the PEB/TEB pages that were previously getting leaked for each thread/process (a known regression I introduced when moving to VADs for PEB/TEB).
svn path=/trunk/; revision=49187
Sir Richard [Sun, 17 Oct 2010 19:56:04 +0000 (19:56 +0000)]
[NTOS]: Handle faults on non-demand-zero PTEs (and/or demand-zero PTEs that are not READWRITE (such as EXECUTE_READWRITE)).
svn path=/trunk/; revision=49186
Daniel Reimer [Sun, 17 Oct 2010 17:04:39 +0000 (17:04 +0000)]
Sync the out of sync winemine to Wine 1.3.5 and fork it, because of the modified look, improved resources and different code structure.
Additionally call it winmine, as it is in windows, too.
svn path=/trunk/; revision=49185
Eric Kohl [Sun, 17 Oct 2010 15:01:46 +0000 (15:01 +0000)]
[ADVAPI32]
Move the Encrypted File System (EFS) functions into their own file.
svn path=/trunk/; revision=49184
Eric Kohl [Sun, 17 Oct 2010 14:54:59 +0000 (14:54 +0000)]
[PSDK]
Add DecryptFileA/W prototype.
svn path=/trunk/; revision=49183
Sylvain Petreolle [Sun, 17 Oct 2010 14:50:02 +0000 (14:50 +0000)]
[APITESTS]
Fix (R)TEST macros in gdi32_apitest,
ensures correct display and no crash report in testman.
svn path=/trunk/; revision=49182
Sylvain Petreolle [Sun, 17 Oct 2010 12:47:02 +0000 (12:47 +0000)]
Katayama Hirofumi:
Add / update Japanese translations.
Fix typos in calc en-US resource.
Bug #5673,5674,5675,5676.
svn path=/trunk/; revision=49181
Sylvain Petreolle [Sun, 17 Oct 2010 11:12:54 +0000 (11:12 +0000)]
Patch by Roel Messiant :
Initialise PPB to zero.
The change from NtAllocateVirtualMemory to RtlAllocateHeap causes the memory to
be not automatically initialised to zero anymore.
Not every field of the PPB (for which the memory is allocated) gets explicitly
initialised, meaning this results in them having bogus values.
One of the now uninitialised fields is DebugFlags, which results in
DbgBreakPoint being called in NtProcessStartup. Simply ensuring the memory is
zeroed makes it all better again.
svn path=/trunk/; revision=49180
Daniel Reimer [Sun, 17 Oct 2010 00:26:32 +0000 (00:26 +0000)]
Sync reg xcopy winhlp32 wordpad and msiexec with Wine 1.3.5
svn path=/trunk/; revision=49179
Sir Richard [Sat, 16 Oct 2010 21:04:50 +0000 (21:04 +0000)]
[CSRSS]: Should use MEM_COMMIT | MEM_RESERVE, not just MEM_COMMIT when requesting a range of adress space that wasn't already reserved. This works in ReactOS because, well, no reason to explain why, but it wouldn't work on Windows or with a VAD-based kernel.
svn path=/trunk/; revision=49178
Sir Richard [Sat, 16 Oct 2010 21:02:48 +0000 (21:02 +0000)]
[NTOS]: Add MmProtectToValue array to convert MM/PTE protection values to Win32 protection flags.
svn path=/trunk/; revision=49177
Aleksey Bragin [Sat, 16 Oct 2010 19:46:03 +0000 (19:46 +0000)]
[PSDK]
- Add NOMIRRORBITMAP definition.
svn path=/trunk/; revision=49176
Aleksey Bragin [Sat, 16 Oct 2010 17:23:40 +0000 (17:23 +0000)]
[PSDK]
- Add ICONINFOEX* definitions and GetIconInfoEx* declarations from Wine.
svn path=/trunk/; revision=49175
Eric Kohl [Sat, 16 Oct 2010 16:26:52 +0000 (16:26 +0000)]
[ADVAPI32]
Implement LsaAddPrivilegesToAccount(), LsaCreateTrustedDomain(), LsaDeleteTrustedDomain() and LsaOpenTrustedDomainByName().
svn path=/trunk/; revision=49174
Sir Richard [Sat, 16 Oct 2010 15:48:42 +0000 (15:48 +0000)]
!!! The previous commit message had a typo, these are the Windows XP DDK Samples, not the Server 2003 DDK samples !!!
[CLASSPNP/CDROM_NEW]: Remove useless files.
svn path=/trunk/; revision=49172
Sir Richard [Sat, 16 Oct 2010 15:24:08 +0000 (15:24 +0000)]
[CLASSPNP]: Add Windows Server 2003 DDK ClassPNP sample, under the license and terms of the Windows Server 2003 DDK.
[CDROM]: Add Windows Server 2003 DDK Cdrom Sample, under the license and terms of the Windows Server 2003 DDK.
They both build and run fine, but PCIIDE(x) must be completed/enabled, and atapi must be rewritten to be WDM-compliant.
svn path=/trunk/; revision=49171
Cameron Gutman [Sat, 16 Oct 2010 15:15:51 +0000 (15:15 +0000)]
[SCSIPORT]
- Fix a couple of typos in the DMA code from my last commit
svn path=/trunk/; revision=49170
Sir Richard [Sat, 16 Oct 2010 14:20:30 +0000 (14:20 +0000)]
[RTL]: Fix a bug introduced Mon Dec 6 00:25:14 1999 UTC (10 years, 10 months ago) in revision 828. NtFreeVirtualMemory takes a pointer to the address to free, not the address instead. For the last 11 years, freeing the process parameter block resulted in freeing whatever the first value in the structure is, which is MaximumLength and initialized to 0x1000. ReactOS would then free whatever random address was in that area. In real Windows, it is illegal to free an allocation in the middle of the base address, and this call failed with the new VAD code. ReactOS either leaked the memory or freed random data, who knows.
[RTL]: Make the PPB live in the Heap instead of having its own virtual allocation, fixing the issue above. Stop rounding it to a PAGE_SIZE, and just use the space required.
svn path=/trunk/; revision=49169
Kamil Hornicek [Sat, 16 Oct 2010 13:55:09 +0000 (13:55 +0000)]
[MMIXER]
Amendment to rev. 49167 requested by Caemyr.
svn path=/trunk/; revision=49168
Johannes Anderwald [Sat, 16 Oct 2010 12:39:49 +0000 (12:39 +0000)]
[MMIXER]
- Disable assert for now
svn path=/trunk/; revision=49167
Johannes Anderwald [Sat, 16 Oct 2010 12:36:21 +0000 (12:36 +0000)]
[MMIXER]
- Add support for topologies where pins directly connect to other pins without nodes in between
- Check if the topology contains node. Fixes assert hit in VmWare Player(sound is not working)
- Thanks to Caemyr for testing
svn path=/trunk/; revision=49166