[0.4.7][APPWIZ] Don't hung up in Gecko download cancellation #3049 CORE-14538
authorJoachim Henze <Joachim.Henze@reactos.org>
Sun, 17 Jan 2021 21:53:15 +0000 (22:53 +0100)
committerJoachim Henze <Joachim.Henze@reactos.org>
Sun, 17 Jan 2021 21:53:15 +0000 (22:53 +0100)
commit52f6ad7d237dff68aeb1a305260011351985bd8c
tree466e9686798564934d5ae33126170402bf712761
parent77a1d1062b43bf9f5e9b2e80fa77033eb2d57075
[0.4.7][APPWIZ] Don't hung up in Gecko download cancellation #3049 CORE-14538

Do not call EndDialog outside the dialog procedure.

fix picked from commit 0.4.15-dev-511-g 90456e54a42604909bf2d93cb74abbbf6574268f

This hang/crash in 2nd stage setup did *not* affect our official carrier-releaser isos that
we host on sourceforge, because those come bundled with Gecko already and therefore always
skipped the download.
Most users were safe in the past therefore.
Still everyone that would like to build an iso by himself could potentially run
into those crashes, and it did not only happen upon user-driven cancellation,
but also often crashed upon network failure / timeout.
A very important fix therefore.
For some unknown reason the likelihood of this crash gradually increased from
0.4.7 where it happened almost never, until 0.4.14 where it crashed much more likely.
Not well understood, maybe depends on memory layout or something similar.
dll/cpl/appwiz/addons.c