[0.4.12][ROSHTTPD] Fix 3 MSVC2010SP1 x86 dbg warnings C4373 CORE-18104
authorJoachim Henze <Joachim.Henze@reactos.org>
Tue, 29 Mar 2022 17:35:44 +0000 (19:35 +0200)
committerJoachim Henze <Joachim.Henze@reactos.org>
Tue, 29 Mar 2022 17:35:44 +0000 (19:35 +0200)
can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuation:
[11438/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\config.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
        C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'
[11441/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\httpd.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
        C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'
[11442/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\roshttpd.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
        C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'

partial pick of 0.4.15-dev-2951-g 5d8e834897781944dcaf80de6c3df9c2c51212c7

modules/rosapps/applications/net/roshttpd/include/httpd.h

index ff85940..41a273f 100644 (file)
@@ -67,7 +67,7 @@ public:
        virtual BOOL Stop();
        virtual LPCServerClientSocket OnGetSocket(LPCServerSocket lpServerSocket);
        virtual LPCServerClientThread OnGetThread(LPCServerClientSocket Socket);
-       virtual void OnAccept(const LPCServerClientThread lpThread);
+       virtual void OnAccept(LPCServerClientThread lpThread);
 private:
        HTTPdState State;
 };