[CSRSRV]
authorHermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Sat, 4 May 2013 14:27:09 +0000 (14:27 +0000)
committerHermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Sat, 4 May 2013 14:27:09 +0000 (14:27 +0000)
- Code simplification.
- Remove unneeded casts.
- Fix comments.

svn path=/trunk/; revision=58922

reactos/subsystems/win32/csrsrv/api.c
reactos/subsystems/win32/csrsrv/thredsup.c

index 5bb6b76..9bea502 100644 (file)
@@ -63,7 +63,7 @@ CsrCallServerFromServer(IN PCSR_API_MESSAGE ReceiveMsg,
     {
         /* We are beyond the Maximum Server ID */
         DPRINT1("CSRSS: %lx is invalid ServerDllIndex (%08x)\n", ServerId, ServerDll);
-        ReplyMsg->Status = (ULONG)STATUS_ILLEGAL_FUNCTION;
+        ReplyMsg->Status = STATUS_ILLEGAL_FUNCTION;
         return STATUS_ILLEGAL_FUNCTION;
     }
     else
@@ -82,7 +82,7 @@ CsrCallServerFromServer(IN PCSR_API_MESSAGE ReceiveMsg,
                     ((ServerDll->NameTable) && (ServerDll->NameTable[ApiId])) ?
                     ServerDll->NameTable[ApiId] : "*** UNKNOWN ***", &ServerDll->Name);
             // DbgBreakPoint();
-            ReplyMsg->Status = (ULONG)STATUS_ILLEGAL_FUNCTION;
+            ReplyMsg->Status = STATUS_ILLEGAL_FUNCTION;
             return STATUS_ILLEGAL_FUNCTION;
         }
     }
@@ -155,7 +155,7 @@ CsrApiHandleConnectionRequest(IN PCSR_API_MESSAGE ApiMessage)
         if (CsrProcess)
         {
             /* Reference the Process */
-            CsrLockedReferenceProcess(CsrThread->Process);
+            CsrLockedReferenceProcess(CsrProcess);
 
             /* Release the lock */
             CsrReleaseProcessLock();
@@ -432,7 +432,7 @@ CsrApiRequestThread(IN PVOID Parameter)
             }
             else
             {
-                /* A bizare "success" code, just try again */
+                /* A strange "success" code, just try again */
                 DPRINT1("NtReplyWaitReceivePort returned \"success\" status 0x%x\n", Status);
                 continue;
             }
index 1682185..2ed743a 100644 (file)
@@ -958,10 +958,10 @@ CsrLockThreadByClientId(IN HANDLE Tid,
     /* Start Loop */
     while (NextEntry != &CsrThreadHashTable[i])
     {
-        /* Get the Process */
+        /* Get the Thread */
         CurrentThread = CONTAINING_RECORD(NextEntry, CSR_THREAD, HashLinks);
 
-        /* Check for PID Match */
+        /* Check for TID Match */
         if ((CurrentThread->ClientId.UniqueThread == Tid) &&
             (CurrentThread->Flags & CsrThreadTerminated) == 0)
         {