[SERVMAN]

- fix resource leaks CID 716292, 716293, 716294
- fix CID 716772 (double free), 513719 (wrong NULL check), 1206739 (cosmetic)
- make line endings CR LF when exporting the services list

svn path=/trunk/; revision=64882

diff --git a/reactos/base/applications/mscutils/servman/export.c b/reactos/base/applications/mscutils/servman/export.c
index f637a5d..3df3c44 100644 (file)
--- a/reactos/base/applications/mscutils/servman/export.c
+++ b/reactos/base/applications/mscutils/servman/export.c
@@ -52,7 +52,7 @@ SaveServicesToFile(PMAIN_WND_INFO Info,
     if(hFile != INVALID_HANDLE_VALUE)
     {
         TCHAR LVText[500];
     if(hFile != INVALID_HANDLE_VALUE)
     {
         TCHAR LVText[500];

-        TCHAR newl = _T('\n');
+        TCHAR newl[2] = {_T('\r'), _T('\n')};

         TCHAR tab = _T('\t');
         DWORD dwTextLength, dwWritten;
         INT NumListedServ = 0;
         TCHAR tab = _T('\t');
         DWORD dwTextLength, dwWritten;
         INT NumListedServ = 0;


@@ -68,7 +68,7 @@ SaveServicesToFile(PMAIN_WND_INFO Info,
                                                    LVText,
                                                    i,
                                                    k);
                                                    LVText,
                                                    i,
                                                    k);

-                if (LVText != NULL)
+                if (_tcslen(LVText))

                 {
                     WriteFile(hFile,
                               LVText,
                 {
                     WriteFile(hFile,
                               LVText,


@@ -84,8 +84,8 @@ SaveServicesToFile(PMAIN_WND_INFO Info,
                 }
             }
             WriteFile(hFile,
                 }
             }
             WriteFile(hFile,

-                      &newl,
-                      sizeof(TCHAR),
+                      newl,
+                      sizeof(newl),

                       &dwWritten,
                       NULL);
         }
                       &dwWritten,
                       NULL);
         }

diff --git a/reactos/base/applications/mscutils/servman/mainwnd.c b/reactos/base/applications/mscutils/servman/mainwnd.c
index 6823379..8291481 100644 (file)
--- a/reactos/base/applications/mscutils/servman/mainwnd.c
+++ b/reactos/base/applications/mscutils/servman/mainwnd.c
@@ -204,9 +204,10 @@ VOID SetMenuAndButtonStates(PMAIN_WND_INFO Info)
                 SendMessage(Info->hTool, TB_SETSTATE, ID_RESTART,
                        (LPARAM)MAKELONG(TBSTATE_ENABLED, 0));
             }
                 SendMessage(Info->hTool, TB_SETSTATE, ID_RESTART,
                        (LPARAM)MAKELONG(TBSTATE_ENABLED, 0));
             }

+        }

 
 

+        if(lpServiceConfig)

             HeapFree(GetProcessHeap(), 0, lpServiceConfig);
             HeapFree(GetProcessHeap(), 0, lpServiceConfig);

-        }

 
         if ( (Flags & SERVICE_ACCEPT_STOP) && (State == SERVICE_RUNNING) )
         {
 
         if ( (Flags & SERVICE_ACCEPT_STOP) && (State == SERVICE_RUNNING) )
         {

diff --git a/reactos/base/applications/mscutils/servman/progress.c b/reactos/base/applications/mscutils/servman/progress.c
index e3c2d6b..8c9c843 100644 (file)
--- a/reactos/base/applications/mscutils/servman/progress.c
+++ b/reactos/base/applications/mscutils/servman/progress.c
@@ -167,9 +167,7 @@ CreateProgressDialog(HWND hParent,
                                 0,
                                 (LPARAM)lpProgStr);
 
                                 0,
                                 (LPARAM)lpProgStr);
 

-            HeapFree(GetProcessHeap(),
-                     0,
-                     lpProgStr);
+            LocalFree(lpProgStr);

         }
 
         /* Finally, show and update the progress dialog */
         }
 
         /* Finally, show and update the progress dialog */

diff --git a/reactos/base/applications/mscutils/servman/propsheet_general.c b/reactos/base/applications/mscutils/servman/propsheet_general.c
index 9c33a97..6bac4cd 100644 (file)
--- a/reactos/base/applications/mscutils/servman/propsheet_general.c
+++ b/reactos/base/applications/mscutils/servman/propsheet_general.c
@@ -33,7 +33,6 @@ SetButtonStates(PSERVICEPROPSHEET dlgInfo,
     {
         hButton = GetDlgItem(hwndDlg, IDC_START);
         EnableWindow (hButton, TRUE);
     {
         hButton = GetDlgItem(hwndDlg, IDC_START);
         EnableWindow (hButton, TRUE);

-        HeapFree(GetProcessHeap(), 0, lpServiceConfig);

     }
     else if ( (Flags & SERVICE_ACCEPT_STOP) && (State == SERVICE_RUNNING) )
     {
     }
     else if ( (Flags & SERVICE_ACCEPT_STOP) && (State == SERVICE_RUNNING) )
     {


@@ -46,6 +45,9 @@ SetButtonStates(PSERVICEPROPSHEET dlgInfo,
         EnableWindow (hButton, TRUE);
     }
 
         EnableWindow (hButton, TRUE);
     }
 

+    if(lpServiceConfig)
+        HeapFree(GetProcessHeap(), 0, lpServiceConfig);
+

     hButton = GetDlgItem(hwndDlg, IDC_START_PARAM);
     EnableWindow(hButton, (State == SERVICE_STOPPED));
 
     hButton = GetDlgItem(hwndDlg, IDC_START_PARAM);
     EnableWindow(hButton, (State == SERVICE_STOPPED));
 

diff --git a/reactos/base/applications/mscutils/servman/query.c b/reactos/base/applications/mscutils/servman/query.c
index 14a68e5..3a5e82c 100644 (file)
--- a/reactos/base/applications/mscutils/servman/query.c
+++ b/reactos/base/applications/mscutils/servman/query.c
@@ -270,6 +270,7 @@ GetServiceList(PMAIN_WND_INFO Info,
         HeapFree(ProcessHeap,
                      0,
                      Info->pAllServices);
         HeapFree(ProcessHeap,
                      0,
                      Info->pAllServices);

+        Info->pAllServices = NULL;

     }
 
     ScHandle = OpenSCManager(NULL,
     }
 
     ScHandle = OpenSCManager(NULL,


@@ -319,7 +320,7 @@ GetServiceList(PMAIN_WND_INFO Info,
     if (ScHandle)
         CloseServiceHandle(ScHandle);
 
     if (ScHandle)
         CloseServiceHandle(ScHandle);
 

-    if (!bRet)
+    if (!bRet && Info->pAllServices)

     {
         HeapFree(ProcessHeap,
                  0,
     {
         HeapFree(ProcessHeap,
                  0,

diff --git a/reactos/base/applications/mscutils/servman/stop_dependencies.c b/reactos/base/applications/mscutils/servman/stop_dependencies.c
index 559002c..99b60bb 100644 (file)
--- a/reactos/base/applications/mscutils/servman/stop_dependencies.c
+++ b/reactos/base/applications/mscutils/servman/stop_dependencies.c
@@ -163,6 +163,8 @@ AddServiceNamesToStop(HWND hServiceListBox,
                          LB_ADDSTRING,
                          0,
                          (LPARAM)lpServiceConfig->lpDisplayName);
                          LB_ADDSTRING,
                          0,
                          (LPARAM)lpServiceConfig->lpDisplayName);

+
+            HeapFree(GetProcessHeap(), 0, lpServiceConfig);

         }
 
         /* Move onto the next string */
         }
 
         /* Move onto the next string */