* PROGRAMMERS: Johannes Anderwald (johannes.anderwald@reactos.org)
*/
-/*
-TODO:
- The code in NotifyShellViewWindow to deliver commands to the view is broken. It is an excellent
- example of the wrong way to do it.
-*/
-
#include "precomp.h"
extern "C"
class CDefaultContextMenu :
public CComObjectRootEx<CComMultiThreadModelNoCS>,
- public IContextMenu3
+ public IContextMenu3,
+ public IObjectWithSite
{
private:
+ CComPtr<IUnknown> m_site;
CComPtr<IShellFolder> m_psf;
UINT m_cidl;
PCUITEMID_CHILD_ARRAY m_apidl;
UINT BuildBackgroundContextMenu(HMENU hMenu, UINT iIdCmdFirst, UINT iIdCmdLast, UINT uFlags);
UINT AddStaticContextMenusToMenu(HMENU hMenu, UINT IndexMenu);
UINT BuildShellItemContextMenu(HMENU hMenu, UINT iIdCmdFirst, UINT iIdCmdLast, UINT uFlags);
+ HRESULT NotifyShellViewWindow(LPCMINVOKECOMMANDINFO lpcmi, BOOL bRefresh);
HRESULT DoPaste(LPCMINVOKECOMMANDINFO lpcmi, BOOL bLink);
HRESULT DoOpenOrExplore(LPCMINVOKECOMMANDINFO lpcmi);
HRESULT DoCreateLink(LPCMINVOKECOMMANDINFO lpcmi);
// IContextMenu3
virtual HRESULT WINAPI HandleMenuMsg2(UINT uMsg, WPARAM wParam, LPARAM lParam, LRESULT *plResult);
+ // IObjectWithSite
+ virtual HRESULT STDMETHODCALLTYPE SetSite(IUnknown *pUnkSite);
+ virtual HRESULT STDMETHODCALLTYPE GetSite(REFIID riid, void **ppvSite);
+
BEGIN_COM_MAP(CDefaultContextMenu)
COM_INTERFACE_ENTRY_IID(IID_IContextMenu, IContextMenu)
COM_INTERFACE_ENTRY_IID(IID_IContextMenu2, IContextMenu2)
COM_INTERFACE_ENTRY_IID(IID_IContextMenu3, IContextMenu3)
+ COM_INTERFACE_ENTRY_IID(IID_IObjectWithSite, IObjectWithSite)
END_COM_MAP()
};
return S_OK;
}
-static
HRESULT
-NotifyShellViewWindow(LPCMINVOKECOMMANDINFO lpcmi, BOOL bRefresh)
+CDefaultContextMenu::NotifyShellViewWindow(LPCMINVOKECOMMANDINFO lpcmi, BOOL bRefresh)
{
- /* Note: CWM_GETISHELLBROWSER returns not referenced object */
- LPSHELLBROWSER lpSB = (LPSHELLBROWSER)SendMessageA(lpcmi->hwnd, CWM_GETISHELLBROWSER, 0, 0);
- if (!lpSB)
- return E_FAIL;
+ CComPtr<IShellView> psv;
- CComPtr<IShellView> lpSV;
- if (FAILED(lpSB->QueryActiveShellView(&lpSV)))
- return E_FAIL;
+ HRESULT hr;
+
+ if (!m_site)
+ return E_FAIL;;
+
+ /* Get a pointer to the shell browser */
+ hr = IUnknown_QueryService(m_site, SID_IFolderView, IID_PPV_ARG(IShellView, &psv));
+ if (FAILED_UNEXPECTEDLY(hr))
+ return hr;
HWND hwndSV = NULL;
- if (SUCCEEDED(lpSV->GetWindow(&hwndSV)))
+ if (SUCCEEDED(psv->GetWindow(&hwndSV)))
SendMessageW(hwndSV, WM_COMMAND, MAKEWPARAM(LOWORD(lpcmi->lpVerb), 0), 0);
return S_OK;
}
CDefaultContextMenu::DoRefresh(
LPCMINVOKECOMMANDINFO lpcmi)
{
- CComPtr<IPersistFolder2> ppf2 = NULL;
- LPITEMIDLIST pidl;
- HRESULT hr = m_psf->QueryInterface(IID_PPV_ARG(IPersistFolder2, &ppf2));
- if (SUCCEEDED(hr))
- {
- hr = ppf2->GetCurFolder(&pidl);
- if (SUCCEEDED(hr))
- {
- SHChangeNotify(SHCNE_UPDATEDIR, SHCNF_IDLIST, pidl, NULL);
- ILFree(pidl);
- }
- }
- return hr;
+ if (!m_site)
+ return E_FAIL;;
+
+ /* Get a pointer to the shell view */
+ CComPtr<IShellView> psv;
+ HRESULT hr = IUnknown_QueryService(m_site, SID_IFolderView, IID_PPV_ARG(IShellView, &psv));
+ if (FAILED_UNEXPECTEDLY(hr))
+ return hr;
+
+ return psv->Refresh();
}
HRESULT
CComPtr<IDataObject> pDataObj;
HRESULT hr;
- if (SUCCEEDED(SHCreateDataObject(m_pidlFolder, m_cidl, m_apidl, NULL, IID_PPV_ARG(IDataObject, &pDataObj))))
- {
- if (!bCopy)
- {
- FORMATETC formatetc;
- STGMEDIUM medium;
- InitFormatEtc(formatetc, RegisterClipboardFormatW(CFSTR_PREFERREDDROPEFFECT), TYMED_HGLOBAL);
- pDataObj->GetData(&formatetc, &medium);
- DWORD * pdwFlag = (DWORD*)GlobalLock(medium.hGlobal);
- if (pdwFlag)
- *pdwFlag = DROPEFFECT_MOVE;
- GlobalUnlock(medium.hGlobal);
- pDataObj->SetData(&formatetc, &medium, TRUE);
- }
-
- hr = OleSetClipboard(pDataObj);
+ hr = SHCreateDataObject(m_pidlFolder, m_cidl, m_apidl, NULL, IID_PPV_ARG(IDataObject, &pDataObj));
+ if(FAILED_UNEXPECTEDLY(hr))
return hr;
- }
-
- /* Note: CWM_GETISHELLBROWSER returns not referenced object */
- LPSHELLBROWSER lpSB = (LPSHELLBROWSER)SendMessageA(lpcmi->hwnd, CWM_GETISHELLBROWSER, 0, 0);
- if (!lpSB)
- {
- ERR("failed to get shellbrowser\n");
- return E_FAIL;
- }
- CComPtr<IShellView> lpSV;
- hr = lpSB->QueryActiveShellView(&lpSV);
- if (FAILED(hr))
+ if (!bCopy)
{
- ERR("failed to query the active shellview\n");
- return hr;
+ FORMATETC formatetc;
+ STGMEDIUM medium;
+ InitFormatEtc(formatetc, RegisterClipboardFormatW(CFSTR_PREFERREDDROPEFFECT), TYMED_HGLOBAL);
+ pDataObj->GetData(&formatetc, &medium);
+ DWORD * pdwFlag = (DWORD*)GlobalLock(medium.hGlobal);
+ if (pdwFlag)
+ *pdwFlag = DROPEFFECT_MOVE;
+ GlobalUnlock(medium.hGlobal);
+ pDataObj->SetData(&formatetc, &medium, TRUE);
}
- hr = lpSV->GetItemObject(SVGIO_SELECTION, IID_PPV_ARG(IDataObject, &pDataObj));
- if (SUCCEEDED(hr))
- {
- hr = OleSetClipboard(pDataObj);
- if (FAILED(hr))
- ERR("OleSetClipboard failed");
- pDataObj->Release();
- } else
- ERR("failed to get item object\n");
-
- return hr;
+ return OleSetClipboard(pDataObj);
}
HRESULT
CDefaultContextMenu::DoRename(
LPCMINVOKECOMMANDINFO lpcmi)
{
- /* get the active IShellView. Note: CWM_GETISHELLBROWSER returns not referenced object */
- LPSHELLBROWSER lpSB = (LPSHELLBROWSER)SendMessageA(lpcmi->hwnd, CWM_GETISHELLBROWSER, 0, 0);
- if (!lpSB)
- {
- ERR("CWM_GETISHELLBROWSER failed\n");
+ CComPtr<IShellBrowser> psb;
+ HRESULT hr;
+
+ if (!m_site)
return E_FAIL;
- }
+
+ /* Get a pointer to the shell browser */
+ hr = IUnknown_QueryService(m_site, SID_IShellBrowser, IID_PPV_ARG(IShellBrowser, &psb));
+ if (FAILED_UNEXPECTEDLY(hr))
+ return hr;
/* is the treeview focused */
HWND hwnd;
- if (SUCCEEDED(lpSB->GetControlWindow(FCW_TREE, &hwnd)))
+ if (SUCCEEDED(psb->GetControlWindow(FCW_TREE, &hwnd)))
{
HTREEITEM hItem = TreeView_GetSelection(hwnd);
if (hItem)
}
CComPtr<IShellView> lpSV;
- HRESULT hr = lpSB->QueryActiveShellView(&lpSV);
- if (FAILED(hr))
- {
- ERR("CWM_GETISHELLBROWSER failed\n");
+ hr = psb->QueryActiveShellView(&lpSV);
+ if (FAILED_UNEXPECTEDLY(hr))
return hr;
- }
SVSIF selFlags = SVSI_DESELECTOTHERS | SVSI_EDIT | SVSI_ENSUREVISIBLE | SVSI_FOCUSED | SVSI_SELECT;
lpSV->SelectItem(m_apidl[0], selFlags);
return E_FAIL;
/* Show and select the new item in the def view */
- CComPtr<IShellBrowser> lpSB;
- CComPtr<IShellView> lpSV;
LPITEMIDLIST pidl;
PITEMID_CHILD pidlNewItem;
+ CComPtr<IShellView> psv;
/* Notify the view object about the new item */
SHChangeNotify(SHCNE_MKDIR, SHCNF_PATHW, (LPCVOID)wszName, NULL);
- /* FIXME: I think that this can be implemented using callbacks to the shell folder */
-
- /* Note: CWM_GETISHELLBROWSER returns shell browser without adding reference */
- lpSB = (LPSHELLBROWSER)SendMessageA(lpici->hwnd, CWM_GETISHELLBROWSER, 0, 0);
- if (!lpSB)
- return E_FAIL;
+ if (!m_site)
+ return S_OK;
- hr = lpSB->QueryActiveShellView(&lpSV);
- if (FAILED(hr))
- return hr;
+ /* Get a pointer to the shell view */
+ hr = IUnknown_QueryService(m_site, SID_IFolderView, IID_PPV_ARG(IShellView, &psv));
+ if (FAILED_UNEXPECTEDLY(hr))
+ return S_OK;
/* Attempt to get the pidl of the new item */
hr = SHILCreateFromPathW(wszName, &pidl, NULL);
pidlNewItem = ILFindLastID(pidl);
- hr = lpSV->SelectItem(pidlNewItem, SVSI_DESELECTOTHERS | SVSI_EDIT | SVSI_ENSUREVISIBLE |
+ hr = psv->SelectItem(pidlNewItem, SVSI_DESELECTOTHERS | SVSI_EDIT | SVSI_ENSUREVISIBLE |
SVSI_FOCUSED | SVSI_SELECT);
SHFree(pidl);
DWORD
CDefaultContextMenu::BrowserFlagsFromVerb(LPCMINVOKECOMMANDINFO lpcmi, PStaticShellEntry pEntry)
{
- LPSHELLBROWSER lpSB;
+ CComPtr<IShellBrowser> psb;
HWND hwndTree;
LPCWSTR FlagsName;
WCHAR wszKey[256];
DWORD wFlags;
DWORD cbVerb;
+ if (!m_site)
+ return 0;
+
/* Get a pointer to the shell browser */
- lpSB = (LPSHELLBROWSER)SendMessageA(lpcmi->hwnd, CWM_GETISHELLBROWSER, 0, 0);
- if (lpSB == NULL)
+ hr = IUnknown_QueryService(m_site, SID_IShellBrowser, IID_PPV_ARG(IShellBrowser, &psb));
+ if (FAILED_UNEXPECTEDLY(hr))
return 0;
/* See if we are in Explore or Browse mode. If the browser's tree is present, we are in Explore mode.*/
- if (SUCCEEDED(lpSB->GetControlWindow(FCW_TREE, &hwndTree)) && hwndTree)
+ if (SUCCEEDED(psb->GetControlWindow(FCW_TREE, &hwndTree)) && hwndTree)
FlagsName = L"ExplorerFlags";
else
FlagsName = L"BrowserFlags";
CDefaultContextMenu::TryToBrowse(
LPCMINVOKECOMMANDINFO lpcmi, LPCITEMIDLIST pidl, DWORD wFlags)
{
- LPSHELLBROWSER lpSB = (LPSHELLBROWSER)SendMessageW(lpcmi->hwnd, CWM_GETISHELLBROWSER, 0, 0);
+ CComPtr<IShellBrowser> psb;
HRESULT hr;
- if (lpSB == NULL)
+ if (!m_site)
return E_FAIL;
- hr = lpSB->BrowseObject(ILCombine(m_pidlFolder, pidl), wFlags);
+ /* Get a pointer to the shell browser */
+ hr = IUnknown_QueryService(m_site, SID_IShellBrowser, IID_PPV_ARG(IShellBrowser, &psb));
+ if (FAILED_UNEXPECTEDLY(hr))
+ return 0;
- return hr;
+ return psb->BrowseObject(ILCombine(m_pidlFolder, pidl), wFlags);
}
HRESULT
return S_OK;
}
-static
HRESULT
-IDefaultContextMenu_Constructor(
- const DEFCONTEXTMENU *pdcm,
- REFIID riid,
- void **ppv)
+WINAPI
+CDefaultContextMenu::SetSite(IUnknown *pUnkSite)
{
- if (ppv == NULL)
- return E_POINTER;
- *ppv = NULL;
-
- CComObject<CDefaultContextMenu> *pCM;
- HRESULT hr = CComObject<CDefaultContextMenu>::CreateInstance(&pCM);
- if (FAILED(hr))
- return hr;
- pCM->AddRef(); // CreateInstance returns object with 0 ref count */
+ m_site = pUnkSite;
+ return S_OK;
+}
- CComPtr<IUnknown> pResult;
- hr = pCM->QueryInterface(riid, (void **)&pResult);
- if (FAILED(hr))
- {
- pCM->Release();
- return hr;
- }
+HRESULT
+WINAPI
+CDefaultContextMenu::GetSite(REFIID riid, void **ppvSite)
+{
+ if (!m_site)
+ return E_FAIL;
- hr = pCM->Initialize(pdcm);
- if (FAILED(hr))
- {
- pCM->Release();
- return hr;
- }
+ return m_site->QueryInterface(riid, ppvSite);
+}
- *ppv = pResult.Detach();
- pCM->Release();
- TRACE("This(%p) cidl %u\n", *ppv, pdcm->cidl);
- return S_OK;
+static
+HRESULT
+CDefaultContextMenu_CreateInstance(const DEFCONTEXTMENU *pdcm, REFIID riid, void **ppv)
+{
+ return ShellObjectCreatorInit<CDefaultContextMenu>(pdcm, riid, ppv);
}
/*************************************************************************
HRESULT
WINAPI
-SHCreateDefaultContextMenu(
- const DEFCONTEXTMENU *pdcm,
- REFIID riid,
- void **ppv)
+SHCreateDefaultContextMenu(const DEFCONTEXTMENU *pdcm, REFIID riid, void **ppv)
{
- *ppv = NULL;
- HRESULT hr = IDefaultContextMenu_Constructor(pdcm, riid, ppv);
- if (FAILED(hr))
- ERR("IDefaultContextMenu_Constructor failed: %x\n", hr);
- TRACE("pcm %p hr %x\n", pdcm, hr);
- return hr;
+ return CDefaultContextMenu_CreateInstance(pdcm, riid, ppv);
}
/*************************************************************************
projects / reactos.git / commitdiff