/*
* Copyright 2012 Detlef Riekenberg
* Copyright 2013 Mislav Blažević
- * Copyright 2015,2016 Mark Jansen
+ * Copyright 2015-2017 Mark Jansen
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
/* FIXME: doesnt work on win10?! */
pdb = pSdbOpenDatabase(path1, DOS_PATH);
- ok(pdb != NULL, "unexpected NULL handle\n");
+ if (g_WinVersion < WINVER_WIN10)
+ {
+ /* ERROR,SdbOpenDatabaseEx,845,Failed to open SDB - File size too large or small. */
+ ok(pdb != NULL, "unexpected NULL handle\n");
+ }
if (pdb)
{
binary = (PBYTE)pSdbGetBinaryTagData(pdb, _TAGID_ROOT);
}
}
-static void match_str_attr_imp(PDB pdb, TAGID parent, TAG find, const char* compare)
+static void match_strw_attr_imp(PDB pdb, TAGID parent, TAG find, const WCHAR* compare)
{
TAGID attr = pSdbFindFirstTag(pdb, parent, find);
winetest_ok(attr != TAG_NULL, "Could not find: %x\n", find);
winetest_ok(name != NULL, "Could not convert attr to str.\n");
if (name)
{
- char name_a[100];
- WideCharToMultiByte(CP_ACP, 0, name, -1, name_a, sizeof(name_a), NULL, NULL);
- winetest_ok(strcmp(name_a, compare) == 0, "Expected tagid %x to be %s, was %s\n", attr, compare, name_a);
+ winetest_ok(wcscmp(name, compare) == 0, "Expected tagid %x to be %s, was %s\n", attr, wine_dbgstr_w(compare), wine_dbgstr_w(name));
}
}
}
}
}
-#define match_str_attr (winetest_set_location(__FILE__, __LINE__), 0) ? (void)0 : match_str_attr_imp
+#define match_strw_attr (winetest_set_location(__FILE__, __LINE__), 0) ? (void)0 : match_strw_attr_imp
#define match_dw_attr (winetest_set_location(__FILE__, __LINE__), 0) ? (void)0 : match_dw_attr_imp
#define match_qw_attr (winetest_set_location(__FILE__, __LINE__), 0) ? (void)0 : match_qw_attr_imp
#define match_guid_attr (winetest_set_location(__FILE__, __LINE__), 0) ? (void)0 : match_guid_attr_imp
}
}
match_qw_attr(pdb, root, TAG_TIME, 0x1d1b91a02c0d63e);
- match_str_attr(pdb, root, TAG_COMPILER_VERSION, "2.1.0.3");
- match_str_attr(pdb, root, TAG_NAME, "apphelp_test1");
+ match_strw_attr(pdb, root, TAG_COMPILER_VERSION, L"2.1.0.3");
+ match_strw_attr(pdb, root, TAG_NAME, L"apphelp_test1");
match_dw_attr(pdb, root, TAG_OS_PLATFORM, 1);
}
if (!layer)
return;
- match_str_attr(pdb, layer, TAG_NAME, "TestNewMode");
+ match_strw_attr(pdb, layer, TAG_NAME, L"TestNewMode");
shimref = pSdbFindFirstTag(pdb, layer, TAG_SHIM_REF);
ok(shimref != TAGID_NULL, "Expected a valid shim ref, got NULL\n");
if (!shimref)
return;
- match_str_attr(pdb, shimref, TAG_NAME, "VirtualRegistry");
- match_str_attr(pdb, shimref, TAG_COMMAND_LINE, "ThemeActive");
+ match_strw_attr(pdb, shimref, TAG_NAME, L"VirtualRegistry");
+ match_strw_attr(pdb, shimref, TAG_COMMAND_LINE, L"ThemeActive");
inexclude = pSdbFindFirstTag(pdb, shimref, TAG_INEXCLUD);
ok(inexclude != TAGID_NULL, "Expected a valid in/exclude ref, got NULL\n");
if (!inexclude)
is_include = pSdbFindFirstTag(pdb, inexclude, TAG_INCLUDE);
ok(is_include == TAGID_NULL, "Expected a NULL include ref, but got one anyway.\n");
- match_str_attr(pdb, inexclude, TAG_MODULE, "exclude.dll");
+ match_strw_attr(pdb, inexclude, TAG_MODULE, L"exclude.dll");
inexclude = pSdbFindNextTag(pdb, shimref, inexclude);
ok(inexclude != TAGID_NULL, "Expected a valid in/exclude ref, got NULL\n");
is_include = pSdbFindFirstTag(pdb, inexclude, TAG_INCLUDE);
ok(is_include != TAGID_NULL, "Expected a valid include ref, got NULL\n");
- match_str_attr(pdb, inexclude, TAG_MODULE, "include.dll");
+ match_strw_attr(pdb, inexclude, TAG_MODULE, L"include.dll");
}
static void check_matching_file(PDB pdb, TAGID exe, TAGID matching_file, int num)
return;
- match_str_attr(pdb, matching_file, TAG_NAME, "*");
- match_str_attr(pdb, matching_file, TAG_COMPANY_NAME, "CompanyName");
- match_str_attr(pdb, matching_file, TAG_PRODUCT_NAME, "ProductName");
- match_str_attr(pdb, matching_file, TAG_PRODUCT_VERSION, "1.0.0.1");
- match_str_attr(pdb, matching_file, TAG_FILE_VERSION, "1.0.0.0");
+ match_strw_attr(pdb, matching_file, TAG_NAME, L"*");
+ match_strw_attr(pdb, matching_file, TAG_COMPANY_NAME, L"CompanyName");
+ match_strw_attr(pdb, matching_file, TAG_PRODUCT_NAME, L"ProductName");
+ match_strw_attr(pdb, matching_file, TAG_PRODUCT_VERSION, L"1.0.0.1");
+ match_strw_attr(pdb, matching_file, TAG_FILE_VERSION, L"1.0.0.0");
if (num == 0 || num == 3)
{
{
match_dw_attr(pdb, matching_file, TAG_SIZE, 0x800);
match_dw_attr(pdb, matching_file, TAG_CHECKSUM, 0x178bd629);
- match_str_attr(pdb, matching_file, TAG_FILE_DESCRIPTION, "FileDescription");
+ match_strw_attr(pdb, matching_file, TAG_FILE_DESCRIPTION, L"FileDescription");
match_dw_attr(pdb, matching_file, TAG_MODULE_TYPE, 3);
match_dw_attr(pdb, matching_file, TAG_VERFILEOS, 4);
match_dw_attr(pdb, matching_file, TAG_VERFILETYPE, 1);
match_dw_attr(pdb, matching_file, TAG_LINKER_VERSION, 0x40002);
- match_str_attr(pdb, matching_file, TAG_ORIGINAL_FILENAME, "OriginalFilename");
- match_str_attr(pdb, matching_file, TAG_INTERNAL_NAME, "InternalName");
- match_str_attr(pdb, matching_file, TAG_LEGAL_COPYRIGHT, "LegalCopyright");
+ match_strw_attr(pdb, matching_file, TAG_ORIGINAL_FILENAME, L"OriginalFilename");
+ match_strw_attr(pdb, matching_file, TAG_INTERNAL_NAME, L"InternalName");
+ match_strw_attr(pdb, matching_file, TAG_LEGAL_COPYRIGHT, L"LegalCopyright");
match_dw_attr(pdb, matching_file, TAG_LINK_DATE, 0x12345);
match_dw_attr(pdb, matching_file, TAG_UPTO_LINK_DATE, 0x12345);
}
if (num == 2)
{
ok(matching_file != TAGID_NULL, "Did expect a secondary match on %d\n", num);
- match_str_attr(pdb, matching_file, TAG_NAME, "test_checkfile.txt");
+ match_strw_attr(pdb, matching_file, TAG_NAME, L"test_checkfile.txt");
match_dw_attr(pdb, matching_file, TAG_SIZE, 0x4);
match_dw_attr(pdb, matching_file, TAG_CHECKSUM, 0xb0b0b0b0);
}
if (num == 2)
{
match_dw_attr(pdb, layer, TAG_LAYER_TAGID, 0x18e);
- match_str_attr(pdb, layer, TAG_NAME, "TestNewMode");
+ match_strw_attr(pdb, layer, TAG_NAME, L"TestNewMode");
}
else
{
TAGID layer_tagid = pSdbFindFirstTag(pdb, layer, TAG_LAYER_TAGID);
ok(layer_tagid == TAGID_NULL, "expected not to find a layer tagid, got %x\n", layer_tagid);
- match_str_attr(pdb, layer, TAG_NAME, "WinSrv03");
+ match_strw_attr(pdb, layer, TAG_NAME, L"WinSrv03");
}
}
static struct
{
- const char* name;
- const char* app_name;
- const char* vendor;
+ const WCHAR* name;
+ const WCHAR* app_name;
+ const WCHAR* vendor;
GUID exe_id;
- const char* extra_file;
+ const WCHAR* extra_file;
DWORD dwLayerCount;
TAGREF atrExes_0;
DWORD adwExeFlags_0;
const char* env_var;
} test_exedata[5] = {
{
- "test_allow.exe",
- "apphelp_name_allow",
- "apphelp_vendor_allow",
+ L"test_allow.exe",
+ L"apphelp_name_allow",
+ L"apphelp_vendor_allow",
{ 0x4e50c93f, 0xb863, 0x4dfa, { 0xba, 0xe2, 0xd8, 0x0e, 0xf4, 0xce, 0x5c, 0x89 } },
NULL,
0,
NULL,
},
{
- "test_disallow.exe",
- "apphelp_name_disallow",
- "apphelp_vendor_disallow",
+ L"test_disallow.exe",
+ L"apphelp_name_disallow",
+ L"apphelp_vendor_disallow",
{ 0x156720e1, 0xef98, 0x4d04, { 0x96, 0x5a, 0xd8, 0x5d, 0xe0, 0x5e, 0x6d, 0x9f } },
NULL,
0,
NULL,
},
{
- "test_new.exe",
- "fixnew_name",
- "fixnew_vendor",
+ L"test_new.exe",
+ L"fixnew_name",
+ L"fixnew_vendor",
{ 0xce70ef69, 0xa21d, 0x408b, { 0x84, 0x5b, 0xf9, 0x9e, 0xac, 0x06, 0x09, 0xe7 } },
- "test_checkfile.txt",
+ L"test_checkfile.txt",
1,
0x2ec,
0,
NULL,
},
{
- "test_w2k3.exe",
- "fix_name",
- "fix_vendor",
+ L"test_w2k3.exe",
+ L"fix_name",
+ L"fix_vendor",
{ 0xb4ead144, 0xf640, 0x4e4b, { 0x94, 0xc4, 0x0c, 0x7f, 0xa8, 0x66, 0x23, 0xb0 } },
NULL,
0,
NULL,
},
{
- "test_unknown_file.exe",
- "apphelp_name_allow",
- "apphelp_vendor_allow",
+ L"test_unknown_file.exe",
+ L"apphelp_name_allow",
+ L"apphelp_vendor_allow",
{ 0x00000000, 0x0000, 0x0000, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 } },
NULL,
1,
ok(num < 4, "Too many matches, expected only 4!\n");
if (num >= 4)
break;
- match_str_attr(pdb, exe, TAG_NAME, test_exedata[num].name);
- match_str_attr(pdb, exe, TAG_APP_NAME, test_exedata[num].app_name);
- match_str_attr(pdb, exe, TAG_VENDOR, test_exedata[num].vendor);
+ match_strw_attr(pdb, exe, TAG_NAME, test_exedata[num].name);
+ match_strw_attr(pdb, exe, TAG_APP_NAME, test_exedata[num].app_name);
+ match_strw_attr(pdb, exe, TAG_VENDOR, test_exedata[num].vendor);
match_guid_attr(pdb, exe, TAG_EXE_ID, &test_exedata[num].exe_id);
check_matching_file(pdb, exe, pSdbFindFirstTag(pdb, exe, TAG_MATCHING_FILE), num);
apphelp = pSdbFindFirstTag(pdb, exe, TAG_APPHELP);
static struct
{
DWORD htmlhelpid;
- const char* link;
- const char* apphelp_title;
- const char* apphelp_details;
+ const WCHAR* link;
+ const WCHAR* apphelp_title;
+ const WCHAR* apphelp_details;
} test_layerdata[2] = {
{
2,
- "http://reactos.org/disallow",
- "apphelp_name_disallow",
- "Not allowed!",
+ L"http://reactos.org/disallow",
+ L"apphelp_name_disallow",
+ L"Not allowed!",
},
{
1,
- "http://reactos.org/allow",
- "apphelp_name_allow",
- "Allow it!",
+ L"http://reactos.org/allow",
+ L"apphelp_name_allow",
+ L"Allow it!",
},
};
ok(link != TAGID_NULL, "expected to find a link tag\n");
if (link != TAGID_NULL)
{
- match_str_attr(pdb, link, TAG_LINK_URL, test_layerdata[num].link);
+ match_strw_attr(pdb, link, TAG_LINK_URL, test_layerdata[num].link);
}
- match_str_attr(pdb, apphelp, TAG_APPHELP_TITLE, test_layerdata[num].apphelp_title);
- match_str_attr(pdb, apphelp, TAG_APPHELP_DETAILS, test_layerdata[num].apphelp_details);
+ match_strw_attr(pdb, apphelp, TAG_APPHELP_TITLE, test_layerdata[num].apphelp_title);
+ match_strw_attr(pdb, apphelp, TAG_APPHELP_DETAILS, test_layerdata[num].apphelp_details);
apphelp = pSdbFindNextTag(pdb, root, apphelp);
num++;
}
BOOL ret;
DWORD ver_hi, ver_lo;
- test_create_db("test_db.sdb", g_WinVersion >= WINVER_WIN10);
+ test_create_db(L"test_db.sdb", g_WinVersion >= WINVER_WIN10);
/* both ver_hi and ver_lo cannot be null, it'll crash. */
ver_hi = ver_lo = 0x12345678;
}
}
+static BOOL IsUserAdmin()
+{
+ BOOL Result;
+ SID_IDENTIFIER_AUTHORITY NtAuthority = { SECURITY_NT_AUTHORITY };
+ PSID AdministratorsGroup;
+
+ Result = AllocateAndInitializeSid(&NtAuthority, 2,
+ SECURITY_BUILTIN_DOMAIN_RID,
+ DOMAIN_ALIAS_RID_ADMINS,
+ 0, 0, 0, 0, 0, 0,
+ &AdministratorsGroup);
+ if (Result)
+ {
+ if (!CheckTokenMembership( NULL, AdministratorsGroup, &Result))
+ Result = FALSE;
+ FreeSid(AdministratorsGroup);
+ }
+
+ return Result;
+}
+
+
+
template<typename SDBQUERYRESULT_T>
static void check_adwExeFlags(DWORD adwExeFlags_0, SDBQUERYRESULT_T& query, const char* file, int line, int cur)
{
template<typename SDBQUERYRESULT_T>
-static void test_mode_generic(const char* workdir, HSDB hsdb, int cur)
+static void test_mode_generic(const WCHAR* workdir, HSDB hsdb, int cur)
{
- char exename[MAX_PATH], testfile[MAX_PATH];
- WCHAR exenameW[MAX_PATH];
+ WCHAR exename[MAX_PATH], testfile[MAX_PATH];
BOOL ret;
SDBQUERYRESULT_T query;
PDB pdb;
memset(&query, 0xab, sizeof(query));
- sprintf(exename, "%s\\%s", workdir, test_exedata[cur].name);
+ swprintf(exename, L"%s\\%s", workdir, test_exedata[cur].name);
if (test_exedata[cur].extra_file)
- sprintf(testfile, "%s\\%s", workdir, test_exedata[cur].extra_file);
+ swprintf(testfile, L"%s\\%s", workdir, test_exedata[cur].extra_file);
test_create_exe(exename, 0);
- MultiByteToWideChar(CP_ACP, 0, exename, -1, exenameW, MAX_PATH);
if (test_exedata[cur].extra_file)
{
/* First we try without the file at all. */
- DeleteFileA(testfile);
- ret = pSdbGetMatchingExe(hsdb, exenameW, NULL, NULL, 0, (SDBQUERYRESULT_VISTA*)&query);
+ DeleteFileW(testfile);
+ ret = pSdbGetMatchingExe(hsdb, exename, NULL, NULL, 0, (SDBQUERYRESULT_VISTA*)&query);
ok(ret == 0, "SdbGetMatchingExe should have failed for %d.\n", cur);
/* Now re-try with the correct file */
test_create_file(testfile, "aaaa", 4);
#if 0
// Results seem to be cached based on filename, until we can invalidate this, do not test the same filename twice!
- DeleteFileA(exename);
+ DeleteFileW(exename);
// skip exports
test_create_exe(exename, 1);
ret = pSdbGetMatchingExe(hsdb, exenameW, NULL, NULL, 0, &query);
ok(ret == 0, "SdbGetMatchingExe should have failed for %d.\n", cur);
- DeleteFileA(exename);
+ DeleteFileW(exename);
test_create_exe(exename, 0);
#endif
SetEnvironmentVariableA("__COMPAT_LAYER", test_exedata[cur].env_var);
}
- ret = pSdbGetMatchingExe(hsdb, exenameW, NULL, NULL, 0, (SDBQUERYRESULT_VISTA*)&query);
+ ret = pSdbGetMatchingExe(hsdb, exename, NULL, NULL, 0, (SDBQUERYRESULT_VISTA*)&query);
ok(ret, "SdbGetMatchingExe should not fail for %d.\n", cur);
exe_count = (test_exedata[cur].env_var == NULL) ? 1 : 0;
else if (g_WinVersion < WINVER_WIN10)
expect_flags = 0x101;
else
+ {
expect_flags = 0x121; /* for 2 and 3, this becomes 101 when not elevated. */
+ if ((cur == 2 || cur == 3) && !IsUserAdmin())
+ expect_flags &= ~0x20;
+ }
if (test_exedata[cur].env_var)
expect_flags &= ~0x100;
TAG tag = pSdbGetTagFromTagID(pdb, tagid);
test_is_testdb(pdb);
ok(tag == TAG_EXE, "Expected tag to be TAG_EXE, was 0x%x for %d.\n", tag, cur);
- match_str_attr(pdb, tagid, TAG_NAME, test_exedata[cur].name);
+ match_strw_attr(pdb, tagid, TAG_NAME, test_exedata[cur].name);
/* And back again */
ret = pSdbTagIDToTagRef(hsdb, pdb, tagid, &tr);
TAG tag = pSdbGetTagFromTagID(pdb, tagid);
test_is_testdb(pdb);
ok(tag == TAG_LAYER, "Expected tag to be TAG_LAYER, was 0x%x for %d.\n", tag, cur);
- match_str_attr(pdb, tagid, TAG_NAME, "TestNewMode");
+ match_strw_attr(pdb, tagid, TAG_NAME, L"TestNewMode");
/* And back again */
ret = pSdbTagIDToTagRef(hsdb, pdb, tagid, &tr);
- if (RtlDosPathNameToNtPathName_U(exenameW, &exenameNT, NULL, NULL))
+ if (RtlDosPathNameToNtPathName_U(exename, &exenameNT, NULL, NULL))
{
ret = pSdbGetMatchingExe(hsdb, exenameNT.Buffer, NULL, NULL, 0, (SDBQUERYRESULT_VISTA*)&query);
+ if (!ret && g_WinVersion >= WINVER_WIN10)
+ {
+ /*
+ ERROR,AslPathGetLongFileNameLongpath,110,Long path conversion failed 123 [c0000001]
+ ERROR,AslPathBuildSignatureLongpath,1086,AslPathGetLongFileNameLongpath failed for \??\C:\Users\MARK~1.DEV\AppData\Local\Temp\apphelp_test\test_allow.exe [c0000001]
+ */
+ trace("Using DOS path for Win10\n");
+ ret = pSdbGetMatchingExe(hsdb, exename, NULL, NULL, 0, (SDBQUERYRESULT_VISTA*)&query);
+ }
ok(ret, "SdbGetMatchingExe should not fail for %d.\n", cur);
RtlFreeUnicodeString(&exenameNT);
}
if (test_exedata[cur].extra_file)
- DeleteFileA(testfile);
- DeleteFileA(exename);
+ DeleteFileW(testfile);
+ DeleteFileW(exename);
if (test_exedata[cur].env_var)
{
template<typename SDBQUERYRESULT_T>
static void test_MatchApplications(void)
{
- char workdir[MAX_PATH], dbpath[MAX_PATH];
- WCHAR dbpathW[MAX_PATH];
+ WCHAR workdir[MAX_PATH], dbpath[MAX_PATH];
BOOL ret;
HSDB hsdb;
- ret = GetTempPathA(MAX_PATH, workdir);
- ok(ret, "GetTempPathA error: %d\n", GetLastError());
- lstrcatA(workdir, "apphelp_test");
+ ret = GetTempPathW(_countof(workdir), workdir);
+ ok(ret, "GetTempPathW error: %d\n", GetLastError());
+ wcscat(workdir, L"apphelp_test");
- ret = CreateDirectoryA(workdir, NULL);
- ok(ret, "CreateDirectoryA error: %d\n", GetLastError());
+ ret = CreateDirectoryW(workdir, NULL);
+ ok(ret, "CreateDirectoryW error: %d\n", GetLastError());
/* SdbInitDatabase needs an nt-path */
- sprintf(dbpath, "\\??\\%s\\test.sdb", workdir);
+ swprintf(dbpath, L"\\??\\%s\\test.sdb", workdir);
test_create_db(dbpath + 4, g_WinVersion >= WINVER_WIN10);
- MultiByteToWideChar(CP_ACP, 0, dbpath, -1, dbpathW, MAX_PATH);
- hsdb = pSdbInitDatabase(HID_DATABASE_FULLPATH, dbpathW);
+ hsdb = pSdbInitDatabase(HID_DATABASE_FULLPATH, dbpath);
ok(hsdb != NULL, "Expected a valid database handle\n");
pSdbReleaseDatabase(hsdb);
}
- DeleteFileA(dbpath + 4);
+ DeleteFileW(dbpath + 4);
- ret = RemoveDirectoryA(workdir);
- ok(ret, "RemoveDirectoryA error: %d\n", GetLastError());
+ ret = RemoveDirectoryW(workdir);
+ ok(ret, "RemoveDirectoryW error: %d\n", GetLastError());
}
static void test_TagRef(void)
{
- char tmpdir[MAX_PATH], dbpath[MAX_PATH];
- WCHAR dbpathW[MAX_PATH];
+ WCHAR tmpdir[MAX_PATH], dbpath[MAX_PATH];
BOOL ret;
HSDB hsdb;
PDB pdb;
DWORD size;
TAGREF tr;
- ret = GetTempPathA(MAX_PATH, tmpdir);
+ ret = GetTempPathW(_countof(tmpdir), tmpdir);
ok(ret, "GetTempPathA error: %d\n", GetLastError());
/* SdbInitDatabase needs an nt-path */
- sprintf(dbpath, "\\??\\%stest.sdb", tmpdir);
+ swprintf(dbpath, L"\\??\\%stest.sdb", tmpdir);
test_create_db(dbpath + 4, g_WinVersion >= WINVER_WIN10);
- MultiByteToWideChar(CP_ACP, 0, dbpath, -1, dbpathW, MAX_PATH);
- hsdb = pSdbInitDatabase(HID_DATABASE_FULLPATH, dbpathW);
+ hsdb = pSdbInitDatabase(HID_DATABASE_FULLPATH, dbpath);
/* HSDB is the only arg that can't be null */
ret = pSdbTagRefToTagID(hsdb, 0, NULL, NULL);
pSdbReleaseDatabase(hsdb);
- DeleteFileA(dbpath + 4);
+ DeleteFileW(dbpath + 4);
}