- Fix typos, found by PVS-Studio

svn path=/trunk/; revision=53516

diff --git a/reactos/dll/win32/netshell/lanstatusui.c b/reactos/dll/win32/netshell/lanstatusui.c
index 2a5dd9b..75123d7 100644 (file)
--- a/reactos/dll/win32/netshell/lanstatusui.c
+++ b/reactos/dll/win32/netshell/lanstatusui.c
@@ -179,7 +179,7 @@ UpdateLanStatus(HWND hwndDlg,  LANSTATUSUI_CONTEXT * pContext)
             pContext->Status = 3;
         }
     }
-    else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE || MIB_IF_OPER_STATUS_DISCONNECTED)
+    else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED)
     {
         if (pContext->Status != 4)
         {

diff --git a/reactos/dll/win32/opengl32/font.c b/reactos/dll/win32/opengl32/font.c
index ea58b75..4f67b57 100644 (file)
--- a/reactos/dll/win32/opengl32/font.c
+++ b/reactos/dll/win32/opengl32/font.c
@@ -1081,7 +1081,7 @@ BOOL APIENTRY IntUseFontOutlinesW(HDC hDC, DWORD first, DWORD count, DWORD listB
 
         glyphSize = GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, 0, NULL, &matrix);
 
-        if (glyphSize < 0)
+        if (glyphSize == GDI_ERROR)
             return FALSE; /*WGL_STATUS_FAILURE*/
 
         if (glyphSize > glyphBufSize)
@@ -1096,7 +1096,7 @@ BOOL APIENTRY IntUseFontOutlinesW(HDC hDC, DWORD first, DWORD count, DWORD listB
         /*
         * Get the glyph's outlines.
         */
-        if (GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, glyphBufSize, glyphBuf, &matrix) < 0)
+        if (GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, glyphBufSize, glyphBuf, &matrix) == GDI_ERROR)
         {
             HeapFree(GetProcessHeap(), 0, glyphBuf);
             return FALSE; /*WGL_STATUS_FAILURE*/

diff --git a/reactos/dll/win32/shell32/autocomplete.c b/reactos/dll/win32/shell32/autocomplete.c
index a0ace20..b05fd67 100644 (file)
--- a/reactos/dll/win32/shell32/autocomplete.c
+++ b/reactos/dll/win32/shell32/autocomplete.c
@@ -448,7 +448,7 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam,
            ShowWindow(This->hwndListBox, SW_HIDE);
            break;
        case WM_KILLFOCUS:
-           if ((This->options && ACO_AUTOSUGGEST) &&
+           if ((This->options & ACO_AUTOSUGGEST) &&
                ((HWND)wParam != This->hwndListBox))
            {
                ShowWindow(This->hwndListBox, SW_HIDE);

diff --git a/reactos/dll/win32/syssetup/wizard.c b/reactos/dll/win32/syssetup/wizard.c
index 809da5f..cae440d 100644 (file)
--- a/reactos/dll/win32/syssetup/wizard.c
+++ b/reactos/dll/win32/syssetup/wizard.c
@@ -1693,8 +1693,8 @@ RegistrationProc(LPVOID Parameter)
         {
           if (0 == LoadStringW(hDllInstance, IDS_UNKNOWN_ERROR,
                                UnknownError,
-                               sizeof(UnknownError) / sizeof(UnknownError[0] -
-                               20)))
+                               sizeof(UnknownError) / sizeof(UnknownError[0]) -
+                               20))
             {
               wcscpy(UnknownError, L"Unknown error");
             }

diff --git a/reactos/drivers/network/tdi/cte/events.c b/reactos/drivers/network/tdi/cte/events.c
index 26bf227..a3a3053 100644 (file)
--- a/reactos/drivers/network/tdi/cte/events.c
+++ b/reactos/drivers/network/tdi/cte/events.c
@@ -123,7 +123,7 @@ CTEScheduleEvent(PCTE_DELAYED_EVENT Event,
     KeAcquireSpinLock(&Event->Lock, &OldIrql);
 
     /* Make sure it is queued */
-    if (!Event->Queued);
+    if (!Event->Queued)
     {
         /* Mark it as queued and set optional context pointer */
         Event->Queued = TRUE;

diff --git a/reactos/lib/3rdparty/adns/src/transmit.c b/reactos/lib/3rdparty/adns/src/transmit.c
index 421a85d..352b7f6 100644 (file)
--- a/reactos/lib/3rdparty/adns/src/transmit.c
+++ b/reactos/lib/3rdparty/adns/src/transmit.c
@@ -200,7 +200,7 @@ void adns__querysend_tcp(adns_query qu, struct timeval now) {
     ADNS_CAPTURE_ERRNO;
     adns__sigpipe_unprotect(qu->ads);
     if (wr < 0) {
-      if (!(errno == EAGAIN || EWOULDBLOCK || errno == EINTR || errno == ENOSPC ||
+      if (!(errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR || errno == ENOSPC ||
            errno == ENOBUFS || errno == ENOMEM)) {
        adns__tcp_broken(ads,"write",strerror(errno));
        return;

diff --git a/reactos/lib/3rdparty/stlport/src/locale.cpp b/reactos/lib/3rdparty/stlport/src/locale.cpp
index 8df976b..774f843 100644 (file)
--- a/reactos/lib/3rdparty/stlport/src/locale.cpp
+++ b/reactos/lib/3rdparty/stlport/src/locale.cpp
@@ -208,7 +208,7 @@ static void _Stl_loc_combine_names_aux(_Locale_impl* L,
 static void _Stl_loc_combine_names(_Locale_impl* L,
                                    const char* name1, const char* name2,
                                    locale::category c) {
-  if ((c & locale::all) == 0 || strcmp(name1, name1) == 0)
+  if ((c & locale::all) == 0 || strcmp(name1, name2) == 0)
     L->name = name1;
   else if ((c & locale::all) == locale::all)
     L->name = name2;

diff --git a/reactos/ntoskrnl/mm/ARM3/mdlsup.c b/reactos/ntoskrnl/mm/ARM3/mdlsup.c
index a5fdd59..e7e613d 100644 (file)
--- a/reactos/ntoskrnl/mm/ARM3/mdlsup.c
+++ b/reactos/ntoskrnl/mm/ARM3/mdlsup.c
@@ -1174,7 +1174,7 @@ MmUnlockPages(IN PMDL Mdl)
             // Check if this page is in the PFN database
             //
             Pfn1 = MiGetPfnEntry(*MdlPages);
-            if (Pfn1);
+            if (Pfn1)
             {
                 /* Get the current entry and reference count */
                 OldRefCount = Pfn1->u3.e2.ReferenceCount;