[MSI] Enumerate only type DRIVE_FIXED CORE-17623 (& CORE-14432)

MSI on 2k3sp2 hides empty CD-ROM, and hides CD-ROM with iso mounted.
MSI on 2k3sp2 hides VBox shares, both: writable and read-only-ones.
MSI on 2k3sp2 hides floppy drives with a floppy img mounted.
MSI on XPSP3 hides a mounted writable USB stick.

Thanks to the patches author Doug Lyons.

This patch supersedes
0.4.15-dev-2651-g 864e20b881130cbc9668b8e253a31b8c325e9b99 (CORE-14432)
and we are also better than Wines
https://source.winehq.org/git/wine.git/commit/0dd0d879a1c487dcefedd44762d4ea0fcebd98fe

diff --git a/dll/win32/msi/dialog.c b/dll/win32/msi/dialog.c
index 2ed6815..7a8417f 100644 (file)
--- a/dll/win32/msi/dialog.c
+++ b/dll/win32/msi/dialog.c
@@ -3238,7 +3238,7 @@ static void msi_dialog_vcl_add_drives( msi_dialog *dialog, msi_control *control
     while (*ptr)
     {
 #ifdef __REACTOS__
-        if (GetDriveTypeW(ptr) == DRIVE_CDROM)
+        if (GetDriveTypeW(ptr) != DRIVE_FIXED)
         {
             ptr += lstrlenW(ptr) + 1;
             continue;