projects
/
reactos.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
62822df
)
[0.4.12][MMSYS] OnHScroll(): Fix wrong '&&' operator (#2855)
author
Joachim Henze
<Joachim.Henze@reactos.org>
Sun, 17 Jan 2021 12:20:54 +0000
(13:20 +0100)
committer
Joachim Henze
<Joachim.Henze@reactos.org>
Sun, 17 Jan 2021 12:20:54 +0000
(13:20 +0100)
CORE-17079 Found by static code analysis
The wrong code once was introduced by 0.4.12-dev-408-g
431f9bf3110b6868ab2d08fab0812841bc0a7f6e
We were not aware of any user observable malfunction caused
by it.
fix picked from commit 0.4.15-dev-311-g
03d5ff7f68b2eea68c2a4f3c2ddc9e31ef5b602a
dll/cpl/mmsys/speakervolume.c
patch
|
blob
|
history
diff --git
a/dll/cpl/mmsys/speakervolume.c
b/dll/cpl/mmsys/speakervolume.c
index
a21c940
..
3b8b2cf
100644
(file)
--- a/
dll/cpl/mmsys/speakervolume.c
+++ b/
dll/cpl/mmsys/speakervolume.c
@@
-155,7
+155,7
@@
OnHScroll(
INT id, idx, i, j;
id = (INT)GetWindowLongPtr((HWND)lParam, GWLP_ID);
- if (id < 9475
&&
id > 9503)
+ if (id < 9475
||
id > 9503)
return;
if ((id - 9475) % 4 != 0)