[EXPLORER_NEW]
authorThomas Faber <thomas.faber@reactos.org>
Fri, 18 Jan 2013 23:34:51 +0000 (23:34 +0000)
committerThomas Faber <thomas.faber@reactos.org>
Fri, 18 Jan 2013 23:34:51 +0000 (23:34 +0000)
- Restructure TaskSwitchWnd_CheckActivateTaskItem. No logic change intended.

svn path=/trunk/; revision=58192

reactos/base/shell/explorer-new/taskswnd.c

index aed9793..7d3db25 100644 (file)
@@ -945,58 +945,49 @@ TaskSwitchWnd_CheckActivateTaskItem(IN OUT PTASK_SWITCH_WND This,
     if (TaskItem != NULL)
         TaskGroup = TaskItem->Group;
 
-    if (This->IsGroupingEnabled && TaskGroup != NULL)
+    if (This->IsGroupingEnabled &&
+        TaskGroup != NULL &&
+        TaskGroup->IsCollapsed)
     {
-        if (TaskGroup->IsCollapsed)
-        {
-            /* FIXME */
-        }
-        else
-            goto ChangeTaskItemButton;
+        /* FIXME */
+        return;
     }
-    else
+
+    if (ActiveTaskItem != NULL)
     {
-ChangeTaskItemButton:
-        if (ActiveTaskItem != NULL)
-        {
-            PTASK_GROUP ActiveTaskGroup;
+        PTASK_GROUP ActiveTaskGroup;
 
-            if (ActiveTaskItem == TaskItem)
-                return;
+        if (ActiveTaskItem == TaskItem)
+            return;
 
-            ActiveTaskGroup = ActiveTaskItem->Group;
+        ActiveTaskGroup = ActiveTaskItem->Group;
 
-            if (This->IsGroupingEnabled && ActiveTaskGroup != NULL)
-            {
-                if (ActiveTaskGroup->IsCollapsed)
-                {
-                    if (ActiveTaskGroup == TaskGroup)
-                        return;
+        if (This->IsGroupingEnabled &&
+            ActiveTaskGroup != NULL &&
+            ActiveTaskGroup->IsCollapsed)
+        {
+            if (ActiveTaskGroup == TaskGroup)
+                return;
 
-                    /* FIXME */
-                }
-                else
-                    goto ChangeActiveTaskItemButton;
-            }
-            else
+            /* FIXME */
+        }
+        else
+        {
+            This->ActiveTaskItem = NULL;
+            if (ActiveTaskItem->Index >= 0)
             {
-ChangeActiveTaskItemButton:
-                This->ActiveTaskItem = NULL;
-                if (ActiveTaskItem->Index >= 0)
-                {
-                    TaskSwitchWnd_UpdateTaskItemButton(This,
-                                                       ActiveTaskItem);
-                }
+                TaskSwitchWnd_UpdateTaskItemButton(This,
+                                                   ActiveTaskItem);
             }
         }
+    }
 
-        This->ActiveTaskItem = TaskItem;
+    This->ActiveTaskItem = TaskItem;
 
-        if (TaskItem != NULL && TaskItem->Index >= 0)
-        {
-            TaskSwitchWnd_UpdateTaskItemButton(This,
-                                               TaskItem);
-        }
+    if (TaskItem != NULL && TaskItem->Index >= 0)
+    {
+        TaskSwitchWnd_UpdateTaskItemButton(This,
+                                           TaskItem);
     }
 }