Ratin Gao [Thu, 9 Mar 2023 16:08:08 +0000 (00:08 +0800)]
[KERNEL32] Remove a pointless SEH in VirtualAllocEx (#5117)
Win2K3 just wraps in SEH only this syscall, which appears pointless
and was removed since NT6.0. We remove it too as an experiment.
Revert the change that added SEH here from commit
6d97180 (r52899).
Katayama Hirofumi MZ [Wed, 8 Mar 2023 23:24:19 +0000 (08:24 +0900)]
[NOTEPAD] Use DestroyIcon instead of DeleteObject to destroy icon (#5130)
CORE-18837
Katayama Hirofumi MZ [Wed, 8 Mar 2023 23:23:08 +0000 (08:23 +0900)]
[NOTEPAD] Remove some needless type casts (#5134)
CORE-18837
Hermès Bélusca-Maïto [Wed, 8 Mar 2023 23:13:48 +0000 (00:13 +0100)]
[WORDPAD][WRITE] Remove redundant pragma code_page(65001)...
... since this is done in the main RC file, from which the per-language
resource files are included.
Doug Lyons [Wed, 8 Mar 2023 20:47:45 +0000 (14:47 -0600)]
[MSAFD] Work around regression of CORE-18848 from
0.4.12-dev-693-g2b1f6c8 (#5102)
Fix winetest for ws2_32:sock that crashes on 'test_AcceptEX' by modifying return values of WSPIoctl for 'case SIO_GET_EXTENSION_FUNCTION_POINTER'
Mark Jansen [Wed, 1 Mar 2023 20:35:17 +0000 (21:35 +0100)]
[SDK:SCRNSAVE] Implement mouse move threshold.
This makes it easier to start the screensavers by double-clicking.
Katayama Hirofumi MZ [Wed, 8 Mar 2023 18:41:11 +0000 (03:41 +0900)]
[NOTEPAD] Delete main.h (#5133)
Reduce files to improve readability. Move the codes in main.h into notepad.h. Make the size of Globals.szFilter 512.
CORE-18837
Katayama Hirofumi MZ [Wed, 8 Mar 2023 18:11:57 +0000 (03:11 +0900)]
[NOTEPAD] Reduce lines in and around comments (#5131)
Reduce lines. CORE-18837
Thomas Faber [Sun, 5 Mar 2023 19:42:22 +0000 (14:42 -0500)]
[WINESYNC] user32/edit: Allow buffer access after EM_GETHANDLE.
wine commit id
f62d8dc58fb3fb5f11a8ab55620ab9b2fbdaf967 by Nikolay Sivov <nsivov@codeweavers.com>
Thomas Faber [Fri, 20 Jan 2023 01:34:46 +0000 (20:34 -0500)]
[REGEDIT] Avoid buffer overflow in SelectNode. CORE-18602
Thomas Faber [Sat, 4 Mar 2023 21:51:57 +0000 (16:51 -0500)]
[REGEDIT] Add back import prompt message lost during Wine sync. CORE-18770
George Bișoc [Tue, 7 Mar 2023 17:39:46 +0000 (18:39 +0100)]
[NTOS:SE][FORMATTING] Fix the file header
This fixes the copyright file header at the top of the file, reflecting
the Coding Style rules. No code changes!
George Bișoc [Tue, 7 Mar 2023 10:42:22 +0000 (11:42 +0100)]
[NTOS:SE] Do not allocate memory pool just for the access rights
Access check is an expensive operation, that is, whenever an access to an
object is performed an access check has to be done to ensure the access
can be allowed to the calling thread who attempts to access such object.
Currently SepAnalyzeAcesFromDacl allocates a block of pool memory for
access check rights, nagging the Memory Manager like a desperate naughty
creep. So instead initialize the access rights as a simple variable in
SepAccessCheck and pass it out as an address to SepAnalyzeAcesFromDacl so
that the function will fill it up with access rights. This helps with
performance, avoiding wasting a few bits of memory just to hold these
access rights.
In addition to that, add a few asserts and fix the copyright header on
both se.h and accesschk.c, to reflect the Coding Style rules.
Katayama Hirofumi MZ [Tue, 7 Mar 2023 05:42:27 +0000 (14:42 +0900)]
[NOTEPAD] Improve printing (header/footer/tabs/performance) (#5111)
- Fix GetPrintingRect function.
- Add DrawHeaderOrFooter, DoPrintBody, DoPrintPage, DoCreatePrintFonts, and DoPrintDocument helper functions.
- Implement page header/footer and tabs printing in DIALOG_FilePrint function.
- Improve printing performance.
- Modify the header/footer resource strings.
- Delete the needless resource strings.
CORE-18837
George Bișoc [Mon, 6 Mar 2023 19:03:44 +0000 (20:03 +0100)]
[NTOS:SE] Print debug output only if NDEBUG is not defined
This mutes a lot of debug spam that fills up the debugger when an access
check fails because a requestor doesn't have enough privileges to access
an object.
Doug Lyons [Mon, 6 Mar 2023 11:22:28 +0000 (05:22 -0600)]
[WS2_32] Fix Two DPRINT typo errors (#5113)
Katayama Hirofumi MZ [Sun, 5 Mar 2023 14:28:00 +0000 (23:28 +0900)]
[MSVCRT] Follow-up of Follow-up of #5032 (
f172503)
Fix for system/_wsystem.
Use _set_errno(ENOMEM) for malloc failure.
Rename status variable as exit_code.
Katayama Hirofumi MZ [Sun, 5 Mar 2023 14:20:12 +0000 (23:20 +0900)]
[MSVCRT] Follow-up of #5032 (
f172503)
Use _cwait() instead of WaitForSingleObject and GetExitCodeProcess.
Use malloc/free instead of LocalAlloc/LocalFree.
Katayama Hirofumi MZ [Sun, 5 Mar 2023 12:01:14 +0000 (21:01 +0900)]
[MSVCRT][CRT_APITEST] Implement _wsystem (#5032)
Implement _wsystem(), by referring system().
Improve system().
Use WaitForSingleObject in system() and _wsystem().
Check existence of COMSPEC.
Thanks ChatGPT.
Atharva Kulkarni [Sun, 5 Mar 2023 11:53:38 +0000 (17:23 +0530)]
[MSPAINT] Treat as a file even if the bitmap file is empty
CORE-18508
Katayama Hirofumi MZ [Sun, 5 Mar 2023 02:41:32 +0000 (11:41 +0900)]
[NTUSER][USER32] Refactor NtUserLoadKeyboardLayoutEx (#5107)
- Split some code of NtUserLoadKeyboardLayoutEx to newly-added co_IntLoadKeyboardLayoutEx helper function.
- Modify NtUserLoadKeyboardLayoutEx prototype.
- Move co_UserImmLoadLayout code.
- Implement KLF_REORDER.
- Rename UserLoadKbdLayout as co_UserLoadKbdLayout.
- Improve LoadKeyboardLayoutEx.
CORE-11700
Joachim Henze [Sat, 4 Mar 2023 10:45:06 +0000 (11:45 +0100)]
[SDK] Improve gen_baseaddress.py and its output files (#4964)
* [SDK:TOOLS] Improve gen_baseaddress.py
Adds some kbd layout modules into the excludes-section:
that we do lack for todays master: e.g._ kbdeo, kbdsf, kbdrost
and also some that we lacked in the past
(for improving backwards compatibility of the script to older rls-branches):
kbdgm, kbdes, kbdgrist, kbdja, kbdko, kbdsk, kbdsk1
* [SDK:CMAKE] Highlight in the output files where the script does misbehave
Carlo Bramini [Thu, 23 Feb 2023 09:57:28 +0000 (10:57 +0100)]
[CMDUTILS] Add Italian (it-IT) translation for WHERE command
Katayama Hirofumi MZ [Wed, 1 Mar 2023 11:17:27 +0000 (20:17 +0900)]
[NOTEPAD] Don't reset Find/Replace if lpstrFindWhat is set (#5104)
We don't want to reset the status of the checkboxes even if the Find/Replace dialog was closed. If lpstrFindWhat is set, do not reset the Find/Replace settings at DIALOG_SearchDialog. CORE-18837
Katayama Hirofumi MZ [Wed, 1 Mar 2023 10:57:10 +0000 (19:57 +0900)]
[NOTEPAD] Fix NOTEPAD_FindTextAt (#5103)
The whole-word search of Notepad had a bug around punctuation. For example, the text "Windows" didn't match in the text "MS-DOS,Windows,ReactOS". Use _istalnum instead of _istspace. Fix the position to check. _istalnum matches an alphabet letter or numeric digit. CORE-18837
Katayama Hirofumi MZ [Tue, 28 Feb 2023 22:16:28 +0000 (07:16 +0900)]
[NOTEPAD] Shift+F3 for backward search (#5101)
- Add Shift+F3 accelerator as command CMD_SEARCH_PREV.
- Extend DIALOG_SearchNext function with bDown argument for the action of CMD_SEARCH_PREV.
- Modify the message loop for effective F3 key on Find/Replace dialog.
CORE-17064
Joachim Henze [Tue, 28 Feb 2023 00:00:29 +0000 (01:00 +0100)]
[RAPPS] Style-addendum, no functional change (#5091)
* Just rename the 4 new files. Absolutely no other change.
* CMakeLists.txt, adapt the filenames
* Adapt all includes to make it compile
* CApplicationDB->CAppDB
* CApplicationInfo->CAppInfo
* Follow Mark Jansens good example and antipad the headers
Doug Lyons [Sun, 26 Feb 2023 19:03:53 +0000 (13:03 -0600)]
Fix ICO_ExtractIconExW causing explorer to crash when trying
to display icon for bad EXE PE header.
See CORE-15879
Co-authored-by: Thomas Faber <thomas.faber@reactos.org>
Katayama Hirofumi MZ [Mon, 27 Feb 2023 03:33:45 +0000 (12:33 +0900)]
[IMM32] Fix ImmGetCompositionStringA/W (#5105)
Fix some typos in Imm32GetCompStrA/W. CORE-11700
Katayama Hirofumi MZ [Sun, 26 Feb 2023 02:57:44 +0000 (11:57 +0900)]
[IMM32] Silence 'Out of boundary' log-spam
CORE-18852
Rexx J. Larsson [Sat, 25 Feb 2023 22:44:06 +0000 (23:44 +0100)]
[SYSSETUP] Removed qemu credit entirely (#4971)
Mark Jansen [Tue, 31 Jan 2023 17:12:52 +0000 (18:12 +0100)]
[USER32] Fix edit UAF by importing wine commit
b40ddf42370e8344a862fbbc40384678db3871a9
Mark Jansen [Thu, 27 Oct 2022 21:52:36 +0000 (23:52 +0200)]
[COMCTL32] Fix edit UAF by importing wine commit
fed0c33fe02a3fcb477086a32dc8d52c1e347889
Jose Carlos Jesus [Sat, 25 Feb 2023 22:38:42 +0000 (18:38 -0400)]
[SHELL32] Give a chance to rename new file or folder when created (#4950)
Katayama Hirofumi MZ [Sat, 25 Feb 2023 01:31:43 +0000 (10:31 +0900)]
[COMDLG32] Follow-up of #5097 (
f4bb0ae)
Do not change flags unless necessary.
https://bugs.winehq.org/show_bug.cgi?id=54567
CORE-17064
Katayama Hirofumi MZ [Sat, 25 Feb 2023 00:16:36 +0000 (09:16 +0900)]
[COMDLG32] Find/Replace: Correctly set flags (#5097)
The flags were not updated correctly. CORE-17064
Katayama Hirofumi MZ [Fri, 24 Feb 2023 01:19:53 +0000 (10:19 +0900)]
[USETUP] Speed up DoFileCopy +24% (#5089)
Make STRING_COPYING cached. CORE-18838
Jose Carlos Jesus [Thu, 23 Feb 2023 00:51:33 +0000 (20:51 -0400)]
[BOOTDATA][INF] Add pt-PT translation (#4926)
Jose Carlos Jesus [Thu, 23 Feb 2023 00:43:53 +0000 (20:43 -0400)]
[SHELL32] Move error message to rc files so can be translated (CORE-18786) (#4997)
CORE-18786
Katayama Hirofumi MZ [Wed, 22 Feb 2023 12:18:05 +0000 (21:18 +0900)]
[NOTEPAD] Improve DIALOG_GoTo (#5082)
- Don't use text directly in DIALOG_GoTo function. Rely the EM_* message handlers.
- Fix and improve DIALOG_GOTO resource dialog (that was wrong in some points).
- Add STRING_LINE_NUMBER_OUT_OF_RANGE.
CORE-18837
Katayama Hirofumi MZ [Tue, 21 Feb 2023 23:35:55 +0000 (08:35 +0900)]
[NTUSER] Send WM_IME_SYSTEM:IMS_UPDATEIMEUI (#5075)
Send WM_IME_SYSTEM:IMS_UPDATEIMEUI message after window position change to improve IME UI sync. CORE-11700, CORE-15289
Katayama Hirofumi MZ [Tue, 21 Feb 2023 00:22:41 +0000 (09:22 +0900)]
[NOTEPAD] Avoid half-initialized status of settings (#5078)
- Avoid buffer overrun in QueryString helper function.
- Improve NOTEPAD_LoadSettingsFromRegistry function.
CORE-18837
Katayama Hirofumi MZ [Tue, 21 Feb 2023 00:17:47 +0000 (09:17 +0900)]
[SHLWAPI][SHLWAPI_APITEST] Expand string in SHLoadIndirectString (#5084)
- shlwapi!SHLoadIndirectString expands the environmental strings if the first character was '@'.
- Implement SHLoadRegUIStringA function.
CORE-10667
Katayama Hirofumi MZ [Tue, 21 Feb 2023 00:14:26 +0000 (09:14 +0900)]
[USETUP] Speed up CONSOLE_SetStatusTextXV +17% (#5086)
Get more speed by omitting erasing and overwriting whole line. CORE-18838
Atharva Kulkarni [Mon, 20 Feb 2023 19:23:37 +0000 (00:53 +0530)]
[MCIAVI32] Add ifdef guards to prevent regression (#5090)
as an addendum to (#5063) and CORE-18669
Mark Jansen [Sat, 11 Feb 2023 22:57:46 +0000 (23:57 +0100)]
[ATL] Remove some code that doesn't exist in the native ATL
Mark Jansen [Mon, 20 Feb 2023 18:30:02 +0000 (19:30 +0100)]
[RAPPS] Rework application handling
Previously, there would be function duplication between installed and available applications.
Now this is handled with polymorphism, which allows to re-use a lot of code.
Additionally, toolbar buttons are properly disabled now.
The mutex used to guard rapps' single instance is renamed,
so that the 'new' and old rapps can be run at the same time for testing.
CORE-18459
Katayama Hirofumi MZ [Mon, 20 Feb 2023 13:00:49 +0000 (22:00 +0900)]
[NOTEPAD] Simplify GetSelectionText (#5083)
Use EM_GETHANDLE message to get text. CORE-18837
Katayama Hirofumi MZ [Mon, 20 Feb 2023 12:59:16 +0000 (21:59 +0900)]
[NOTEPAD] Make "UTF-8 without BOM" default (#5081)
- Define a constant ENCODING_DEFAULT that is equal to ENCODING_UTF8.
- Initialize Globals.encFile as ENCODING_DEFAULT.
- Reset encoding and line ending in DIALOG_FileNew.
- AnalyzeEncoding returns ENCODING_DEFAULT for non-zero ASCII text.
- Remove unnecessary DIALOG_StatusBarAlignParts calls.
CORE-18837
Katayama Hirofumi MZ [Mon, 20 Feb 2023 09:31:34 +0000 (18:31 +0900)]
[USETUP] Slightly optimize CONSOLE_SetStyledText (#5087)
Do not calculate Length unless necessary. CORE-18838
Joachim Henze [Sun, 19 Feb 2023 17:44:21 +0000 (18:44 +0100)]
[NETSHELL] Repair "Network Connection 'State' does nothing" CORE-18844
It regressed in master by 0.4.15-dev-5613-g
7a17c7d9adadf88eafc382d792771bea5fc412f8
It was the only place within the ros sources where message WM_SHOWSTATUSDLG
was sent also from code. And therefore the only one that needed to be updated as well.
Gabriel Grondin [Sun, 19 Feb 2023 17:29:08 +0000 (18:29 +0100)]
[SYSDM] Fix french translation and layout (#4992)
Based on earlier PR #4704
- Fixed alignment for too long text.
- Improved translation.
- Minor adjustments.
CORE-18381
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Kyle Katarn <contact@kcsoftwares.com>
Joachim Henze [Sat, 18 Feb 2023 17:28:30 +0000 (18:28 +0100)]
[AUDIOSRV] Overhaul logging interfaces CORE-16912 (#5067)
Katayama Hirofumi MZ [Sat, 18 Feb 2023 12:40:11 +0000 (21:40 +0900)]
[NOTEPAD] Simplify FileExists function (#5079)
Simplify FileExists helper function by using GetFileAttributes function. CORE-18837
Atharva Kulkarni [Sat, 18 Feb 2023 10:33:58 +0000 (16:03 +0530)]
[MCIAVI32] Media Player: Don't open empty files (#5063)
Opening an empty file in media player could cause a crash. CORE-18669
Doug Lyons [Fri, 17 Feb 2023 22:11:00 +0000 (16:11 -0600)]
[IP] Allow 0xFFFF as Valid Network Port Number (#5074)
* Allow 0xFFFF as valid port number
* Note possible reason for failure in TCPAllocatePort
* Return NtStatus error on TCP/IP out-of-ports failure
* Replace unavailable "ERR" with "DbgPrint"
Katayama Hirofumi MZ [Fri, 17 Feb 2023 06:17:34 +0000 (15:17 +0900)]
[NOTEPAD] Follow-up of #5076 (
621439d)
- Add DIALOG_StatusBarUpdateAll() and use it.
- Fix the status bar initial contents.
Katayama Hirofumi MZ [Fri, 17 Feb 2023 03:29:30 +0000 (12:29 +0900)]
[BROWSEUI] Add CAddressEditBox::RefreshAddress and use it (#5062)
Follow-up of #5026 [BROWSEUI] Execute command line from address bar. Elegantly reset the address bar after command line execution. CORE-15453
Katayama Hirofumi MZ [Fri, 17 Feb 2023 00:23:25 +0000 (09:23 +0900)]
[NOTEPAD] Fix and simplify Status Bar handling (#5076)
- Rename DoCreateStatusBar as DoShowHideStatusBar.
- Simplify WM_SIZE handler.
- Enable/disable CMD_STATUSBAR menu item correctly.
- Make DoShowHideStatusBar independent from DoCreateEditWindow.
Joachim Henze [Thu, 16 Feb 2023 18:33:37 +0000 (19:33 +0100)]
[NTUSER] Optimize Window Snap Disabling (#5061)
Suleyman Poyraz [Wed, 15 Feb 2023 16:29:52 +0000 (19:29 +0300)]
[TRANSLATION] Add/Update Turkish (tr-TR) translations (#4959)
Programs: at, charmap, diskpart, drwtsn32, explorer, fc, fontview, format, reg, timeout, where, wmic,
mspaint, regedit, runas, rundll32, subst, utilman, umandlg, w32time, winlogon
Tools: arping, vgafontedit, explorer-old, fraginator, fontsub, systeminfo, vcdcontroltool
CPLs: desk, hotplug, input, sysdm
DLLs: newdev, syssetup, user32
Themes: lunar
Screensavers: blankscr, butterflies, circles, cylfrac, matrix, mazescr, ssstars, starfield
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Katayama Hirofumi MZ [Wed, 15 Feb 2023 01:15:51 +0000 (10:15 +0900)]
[NOTEPAD] Simplify NOTEPAD_EnableSearchMenu (#5077)
Robert Naumann [Tue, 14 Feb 2023 21:19:38 +0000 (22:19 +0100)]
[REGEDIT] Work around a Wine bug. Fixes CORE-18603
See https://bugs.winehq.org/show_bug.cgi?id=54491
Thamatip Chitpong [Tue, 14 Feb 2023 20:57:41 +0000 (03:57 +0700)]
[NTUSER] IntWinListOwnedPopups: Exclude default IME window from the list (#5069)
And in IntShowOwnedPopups: Remove the window owner check hack as it's no longer needed.
Based on my observation, the owner of the default IME window can change and it depends on
the window that is being focused.
CORE-18659
CORE-18768
Katayama Hirofumi MZ [Tue, 14 Feb 2023 11:54:53 +0000 (20:54 +0900)]
[CRT] printf/wprintf: Support %zu (#5056)
"%zu" is a printf format specifier for type size_t. Some apps assume the implementation of this specifier. CORE-17787
Katayama Hirofumi MZ [Tue, 14 Feb 2023 11:53:48 +0000 (20:53 +0900)]
[SHELL32][SHELL32_APITEST] Improve CommandLineToArgvW (#5055)
This PR will reduce the failures of CommandLineToArgvW testcase of shell32_apitest.
- Use isspace and isblank in shell32!CommandLineToArgvW.
- Strengthen shell32_apitest:CommandLineToArgvW testcase.
CORE-17787
Katayama Hirofumi MZ [Tue, 14 Feb 2023 04:34:20 +0000 (13:34 +0900)]
[NOTEPAD] Optimize AnalyzeEncoding
CORE-14641
Katayama Hirofumi MZ [Tue, 14 Feb 2023 04:25:44 +0000 (13:25 +0900)]
[NOTEPAD] Follow-up of
d3da0cb; *pBytes should be unsigned
CORE-14641
Katayama Hirofumi MZ [Tue, 14 Feb 2023 04:12:47 +0000 (13:12 +0900)]
[NOTEPAD] Follow-up of #5012 (
0a851ea); Fix encoding
There was a bug in encoding analyzer.
CORE-14641
Katayama Hirofumi MZ [Tue, 14 Feb 2023 01:57:25 +0000 (10:57 +0900)]
[NTUSER] Add 'Win:' comments to co_UserHideCaret and co_UserShowCaret
CORE-11700
Katayama Hirofumi MZ [Tue, 14 Feb 2023 01:45:19 +0000 (10:45 +0900)]
[NTUSER] Add 'Win:' comment to IntRealChildWindowFromPoint
CORE-11700
Katayama Hirofumi MZ [Tue, 14 Feb 2023 01:43:37 +0000 (10:43 +0900)]
[NTUSER] Add 'Win:' comment to IntChildWindowFromPointEx
CORE-11700
Katayama Hirofumi MZ [Tue, 14 Feb 2023 01:39:26 +0000 (10:39 +0900)]
[NTUSER] Add 'Win:' comment to IntDeferWindowPos
CORE-11700
Katayama Hirofumi MZ [Tue, 14 Feb 2023 01:30:16 +0000 (10:30 +0900)]
[NTUSER] Add 'Win:' comment to IntEndDeferWindowPosEx
CORE-11700
Mark Jansen [Mon, 13 Feb 2023 22:19:55 +0000 (23:19 +0100)]
[BROWSEUI] Fix crash while editing a label in the folder tree
+ Add a missing break
CORE-18646
Atharva Kulkarni [Mon, 13 Feb 2023 19:49:45 +0000 (01:19 +0530)]
[BROWSEUI] Don't show file names in Relevance column in search results (#5072)
* Dont show file names in Relevance column
* Define new column names
* Update CompareIDs to use newer defines
Atharva Kulkarni [Mon, 13 Feb 2023 19:45:39 +0000 (01:15 +0530)]
[EXPLORER] Fix crash on backspace while editing a label in the folder panel (#5059)
While editing a label, accelerator events should not be propagated.
Tibor Lajos Füzi [Mon, 13 Feb 2023 14:29:45 +0000 (15:29 +0100)]
[DESK] Update Hungarian (hu-HU) translation (#5060)
Doug Lyons [Mon, 13 Feb 2023 14:27:40 +0000 (08:27 -0600)]
[NTUSER] Missing "X" on "Folder" pane when Right Click > Explore from Desktop icons & Rapps toolbar errors (#5068)
Fix for right-clicking on 'My Computer' and selecting 'explore' and there is no 'X' for the title bar in the Folders pane
Also fixes Rapps missing toolbar combo box and edit box controls that were not displayed.
This is a complete revert of #4995 (commit
7866eb2) while still retaining its fixes.
CORE-18830, CORE-18817
Co-authored-by: I_Kill_Bugs
Katayama Hirofumi MZ [Sun, 12 Feb 2023 23:32:09 +0000 (08:32 +0900)]
[NOTEPAD] Fix and improve DoSaveFile (#5066)
- Use EM_GETHANDLE to get the text.
- Check zero size and handle it elegantly.
CORE-18832
Doug Lyons [Sun, 12 Feb 2023 18:17:55 +0000 (12:17 -0600)]
Fix Wine Internet Explorer Print hang (#5064)
When using wine internet explorer it crashes if you click print even if you click cancel, this fixes that issue.
nsIWebBrowserPrint_Print apparently causes issues for unknown reasons.
JIRA issue: CORE-16884
By returning S_OK print doesn't cause a crash.
Use ERR and S_OK return before hitting nsIWebBrowserPrint_Print
Rexx J. Larsson [Sun, 12 Feb 2023 15:15:51 +0000 (16:15 +0100)]
[RAPPS] Fix Installed Apps information display (#4973)
This fixes hyperlinks highlighting the text before it.
CORE-18397
Joachim Henze [Sat, 11 Feb 2023 23:35:27 +0000 (00:35 +0100)]
[NTUSER] Delete temporary workarounds in co_IntSetScrollInfo() (#4985)
fixes JIRA issue: CORE-18050
improves the code by removing ancient hacks (the static variables)
reduces testbot failures
VBox: https://reactos.org/testman/compare.php?ids=85831,85832 LGTM (-2 failures in user32:scroll for both bots)
KVM: https://reactos.org/testman/compare.php?ids=85829,85833 LGTM (-2 failures in user32:scroll for both bots)
co-authored by Doug-Lyons
Joachim Henze [Sat, 11 Feb 2023 20:35:57 +0000 (21:35 +0100)]
[BROWSEUI] Update de-DE.rc German translation
German accelerator for "&Datei" collided with "A&dresse".
Fix by switching to what MS uses in german XPSP3.
see the before-state with the [BROWSEUI] collision here:
https://jira.reactos.org/secure/attachment/65116/ros.png
Please note that in current master head the accelerators in
[BROWSEUI] filebrowser are generally broken for other reasons.
So this commit will not entirely fix CORE-18824
Also update to new-style header (inspired by es-ES.rc) and
https://reactos.org/wiki/Coding_Style
and add a missing translation.
Joachim Henze [Sat, 11 Feb 2023 20:09:47 +0000 (21:09 +0100)]
[SYSSETUP] Fix a space-typo in IDS_WZD_PASSWORDEMPTY for *.rc (#5049)
Also update any existing old-school-headers to more compact newstyle.
Jose Carlos Jesus [Fri, 10 Feb 2023 15:05:11 +0000 (11:05 -0400)]
[SHLWAPI] No need extension to execute '.bat' files CORE-17612 (#4932)
When no extension is provided, add default extension with correct precedence using PathFileExistsDefExtW.
- Use PathFindOnPathExW when searching in current directory and PATH environment variable.
- Fix Width String terminator to UNICODE_NULL.
- Fix all failed tests on PathFindPathExW KVM test.
CORE-17612
Ratin Gao [Fri, 10 Feb 2023 14:56:13 +0000 (22:56 +0800)]
[SHELL32] Remove unused flag SEE_MASK_UNICODE (#5033)
SEE_MASK_UNICODE does nothing, so we needn't mark it as "unsupported flag" and output FIXME
Ratin Gao [Fri, 10 Feb 2023 14:15:25 +0000 (22:15 +0800)]
[TRANSLATION] Improve Simplified Chinese (zh-CN) translation (#4979)
- Add and improve translation
- Fix mistakes
Katayama Hirofumi MZ [Thu, 9 Feb 2023 12:54:20 +0000 (21:54 +0900)]
[NOTEPAD] Treat empty file correctly (#5057)
#5012 had a regression on opening an empty file.
CORE-14641, CORE-18826
Joachim Henze [Wed, 8 Feb 2023 09:05:04 +0000 (10:05 +0100)]
[EXPLORER][BROWSEUI] de-DE.rc fix 3 german keyboard accelerators
[BROWSEUI] German accelerator for "F&avoriten" collided with "&Ansicht".
[EXPLORER] German accelerator for "F&avoriten" must be "&Favoriten" also in the startmenu.
[BROWSEUI] German accelerator for "S&chnellstartleiste" was missing.
Fix all 3 by switching to what MS uses in german XPSP3.
see the before-state with the [BROWSEUI] collision here:
https://jira.reactos.org/secure/attachment/65116/ros.png
Please note that in current master head the accelerators in
[BROWSEUI] filebrowser are generally broken for other reasons.
So this commit will not entirely fix CORE-18824 yet, but just
rules out the small related glitches in the german rc-files.
Thamatip Chitpong [Mon, 6 Feb 2023 17:52:53 +0000 (00:52 +0700)]
[WINMM] Constify some variables
Wine commit:
4aca7601265ca76339662aa4e1a9c6669cebc9a0
author: Andrew Talbot <andrew.talbot@talbotville.com>
Mon, 22 Aug 2011 19:31:51 +0000 (20:31 +0100)
committer: Alexandre Julliard <julliard@winehq.org>
Tue, 23 Aug 2011 14:53:53 +0000 (16:53 +0200)
Thamatip Chitpong [Mon, 6 Feb 2023 16:43:45 +0000 (23:43 +0700)]
[WINMM] Fixed boundary condition in mmioOpen file name parsing
Wine commit:
4431c32c91206040d59d3eb82a971245594d1243
author: Alexander Puzankov <alxpnv@gmail.com>
Sun, 5 Dec 2010 14:24:59 +0000 (17:24 +0300)
committer: Alexandre Julliard <julliard@winehq.org>
Sun, 5 Dec 2010 15:44:28 +0000 (16:44 +0100)
Thamatip Chitpong [Mon, 6 Feb 2023 15:47:21 +0000 (22:47 +0700)]
[WINMM] Revert "Handle playing of files containing a '+' as part of the filename."
Wine commit:
cc5f2b2c766bbe4975d7ee4a7c3b269650cbf874
author: Alexander Puzankov <alxpnv@gmail.com>
Mon, 29 Nov 2010 18:15:16 +0000 (21:15 +0300)
committer: Alexandre Julliard <julliard@winehq.org>
Wed, 1 Dec 2010 16:16:20 +0000 (17:16 +0100)
Joachim Henze [Mon, 6 Feb 2023 14:01:52 +0000 (15:01 +0100)]
[REACTOS] "reactos" -> "https://reactos" (#5043)
To harmonize, to save some bytes, and last but not least for security reasons.
This can be understood as an addendum to (#2619).
Katayama Hirofumi MZ [Mon, 6 Feb 2023 13:46:26 +0000 (22:46 +0900)]
[BROWSEUI] Execute command line from address bar (#5026)
CORE-15453
Mark Jansen [Thu, 2 Feb 2023 00:54:51 +0000 (01:54 +0100)]
[ROSAPPS] Remove pice
Mark Jansen [Wed, 1 Feb 2023 19:15:54 +0000 (20:15 +0100)]
[USERENV_WINETEST] Compare variable case insensitive
This fixes a test for TestWHS
Mark Jansen [Tue, 31 Jan 2023 15:26:21 +0000 (16:26 +0100)]
[DBGHELP_APITEST] Skip more tests on 2k3's dbghelp.dll
Mark Jansen [Thu, 2 Feb 2023 14:38:48 +0000 (15:38 +0100)]
[KMTESTS:CC] Disable Cc tests that seem to hang TestWHS
Mark Jansen [Wed, 1 Feb 2023 18:23:36 +0000 (19:23 +0100)]
[UXTHEME_APITEST] Skip some tests that fail without a theme