Support -Werror
authorCasper Hornstrup <chorns@users.sourceforge.net>
Sun, 10 Apr 2005 19:44:11 +0000 (19:44 +0000)
committerCasper Hornstrup <chorns@users.sourceforge.net>
Sun, 10 Apr 2005 19:44:11 +0000 (19:44 +0000)
svn path=/branches/xmlbuildsystem/; revision=14582

80 files changed:
reactos/apps/utils/net/arp/arp.c
reactos/apps/utils/net/finger/finger.c
reactos/apps/utils/net/finger/net.c
reactos/apps/utils/net/ftp/ftp.xml
reactos/apps/utils/net/ipconfig/ipconfig.xml
reactos/apps/utils/net/netstat/netstat.xml
reactos/apps/utils/net/ping/ping.c
reactos/apps/utils/net/route/route.c
reactos/apps/utils/net/whois/whois.c
reactos/baseaddress.xml
reactos/boot/freeldr/freeldr/freeldr_base.xml
reactos/drivers/bus/acpi/acpi.xml
reactos/drivers/bus/directory.xml
reactos/drivers/bus/serenum/serenum.xml [new file with mode: 0644]
reactos/drivers/dd/sndblst/card.c
reactos/drivers/dd/sndblst/dma.c
reactos/drivers/dd/sndblst/irq.c
reactos/drivers/dd/sndblst/portio.c
reactos/drivers/dd/sndblst/settings.c
reactos/drivers/dd/sndblst/sndblst.c
reactos/drivers/dd/sound/dsp.c
reactos/drivers/dd/sound/dsp.h
reactos/drivers/dd/sound/mixer.c
reactos/drivers/dd/sound/sound.c
reactos/drivers/dd/sound/wave.c
reactos/drivers/lib/oskittcp/oskittcp.xml
reactos/lib/cabinet/cabinet.xml
reactos/lib/comctl32/comctl32.xml
reactos/lib/comdlg32/comdlg32.xml
reactos/lib/dbghelp/dbghelp.xml
reactos/lib/devenum/devenum.xml
reactos/lib/dinput/dinput.xml
reactos/lib/directory.xml
reactos/lib/iphlpapi/iphlpapi.xml
reactos/lib/kbdda/kbdda.xml
reactos/lib/kbddv/kbddv.xml
reactos/lib/kbdes/kbdes.xml
reactos/lib/kbdfr/kbdfr.xml
reactos/lib/kbdgr/kbdgr.xml
reactos/lib/kbdse/kbdse.xml
reactos/lib/kbduk/kbduk.xml
reactos/lib/kbdus/kbdus.xml
reactos/lib/msi/msi.xml [new file with mode: 0644]
reactos/lib/ntdll/rtl/intrlck.c
reactos/lib/ole32/ole32.xml
reactos/lib/oleaut32/oleaut32.xml
reactos/lib/riched20/riched20.xml
reactos/lib/rpcrt4/rpcrt4.xml
reactos/lib/serialui/serialui.xml [new file with mode: 0644]
reactos/lib/setupapi/setupapi.xml
reactos/lib/shdocvw/shdocvw.xml
reactos/lib/shell32/shell32.xml
reactos/lib/shlwapi/shlwapi.xml
reactos/lib/urlmon/urlmon.xml
reactos/lib/userenv/desktop.c
reactos/lib/userenv/registry.c
reactos/lib/userenv/setup.c
reactos/lib/winmm/winmm.xml
reactos/subsys/system/calc/calc.xml
reactos/subsys/system/directory.xml
reactos/subsys/system/msiexec/msiexec.xml [new file with mode: 0644]
reactos/subsys/system/regedit/childwnd.c
reactos/subsys/system/regedit/edit.c
reactos/subsys/system/regedit/framewnd.c
reactos/subsys/system/regedit/hexedit.c
reactos/subsys/system/regedit/listview.c
reactos/subsys/system/regedit/main.c
reactos/subsys/system/regedit/main.h
reactos/subsys/system/regedit/regproc.c
reactos/subsys/system/regedit/security.c
reactos/subsys/system/regedit/security.h
reactos/subsys/system/reporterror/reporterror.c
reactos/subsys/system/usetup/usetup.xml
reactos/subsys/system/winefile/winefile.xml
reactos/subsys/win32k/objects/font.c
reactos/tools/rbuild/backend/mingw/mingw.cpp
reactos/tools/rbuild/backend/mingw/modulehandler.cpp
reactos/tools/rbuild/module.cpp
reactos/tools/rbuild/rbuild.h
reactos/tools/rbuild/rbuild.txt

index 4468cac..19bbf0f 100644 (file)
@@ -87,7 +87,7 @@ int main(int argc, char *argv[])
 
         DWORD dwUptime = SnmpSvcGetUptime();
 
-        _tprintf(_T("SNMP uptime: %d\n"), dwUptime);
+        _tprintf(_T("SNMP uptime: %ld\n"), dwUptime);
 
         SnmpUtilMemFree(pCache);
     } else {
index 125f878..7d3c999 100644 (file)
  *          Had to remove local handling.       Otherwise, same as whois.
  */
 
-#ifndef lint
-static char copyright[] =
-"@(#) Copyright (c) 1989, 1993\n\
-       The Regents of the University of California.  All rights reserved.\n";
-#endif /* not lint */
-
-#ifndef lint
-static char sccsid[] = "@(#)finger.c   8.5 (Berkeley) 5/4/95";
-#endif /* not lint */
-
 /*
  * Finger prints out information about users.  It is not portable since
  * certain fields (e.g. the full user name, office, and phone numbers) are
index 3cf4bdb..f007a79 100644 (file)
  * SUCH DAMAGE.
  */
 
-#ifndef lint
-static char sccsid[] = "@(#)net.c      8.4 (Berkeley) 4/28/95";
-#endif /* not lint */
-
 #include <sys/types.h>
 #include <winsock2.h>
 #include "unistd.h"
@@ -63,7 +59,7 @@ netfinger(char *name)
        if (!(host = rindex(name, '@')))
                return;
 
-       *host++ = NULL;
+       *host++ = 0;
        if (isdigit(*host) && (defaddr.s_addr = inet_addr(host)) != -1) {
                def.h_name = host;
                def.h_addr_list = alist;
index 0871c49..abc7f2d 100644 (file)
@@ -1,4 +1,4 @@
-<module name="ftp" type="win32cui" installbase="system32" installname="ftp.exe">\r
+<module name="ftp" type="win32cui" installbase="system32" installname="ftp.exe" warnings="true">\r
        <include base="ftp">.</include>\r
        <define name="__USE_W32API" />\r
        <library>kernel32</library>\r
index 7a980e6..f875803 100644 (file)
@@ -1,4 +1,4 @@
-<module name="ipconfig" type="win32cui" installbase="system32" installname="ipconfig.exe">\r
+<module name="ipconfig" type="win32cui" installbase="system32" installname="ipconfig.exe" warnings="true">\r
        <include base="ipconfig">.</include>\r
        <define name="__USE_W32API" />\r
        <library>kernel32</library>\r
index 580e3d8..68a2e26 100644 (file)
@@ -1,4 +1,4 @@
-<module name="netstat" type="win32cui" installbase="system32" installname="netstat.exe">\r
+<module name="netstat" type="win32cui" installbase="system32" installname="netstat.exe" warnings="true">\r
        <include base="netstat">.</include>\r
        <define name="__USE_W32API" />\r
        <define name="_WIN32_IE">0x600</define>\r
index 5cab246..f91a898 100644 (file)
@@ -113,7 +113,7 @@ VOID DisplayBuffer(
     UINT i;
     PCHAR p;
 
-    printf("Buffer (0x%X)  Size (0x%X).\n", Buffer, Size);
+    printf("Buffer (0x%p)  Size (0x%lX).\n", Buffer, Size);
 
     p = (PCHAR)Buffer;
     for (i = 0; i < Size; i++) {
@@ -386,7 +386,6 @@ VOID QueryTime(PLARGE_INTEGER Time)
 
 VOID TimeToMsString(LPSTR String, LARGE_INTEGER Time)
 {
-    UINT          i, Length;
     CHAR          Convstr[40];
     LARGE_INTEGER LargeTime;
 
index ded8801..60f2b22 100644 (file)
@@ -35,8 +35,7 @@ int print_routes() {
     PMIB_IPFORWARDTABLE IpForwardTable;
     DWORD Error;
     ULONG Size = 0;
-    char Destination[IPBUF], Gateway[IPBUF], Netmask[IPBUF], 
-       Index[IPBUF], Metric[IPBUF];
+    char Destination[IPBUF], Gateway[IPBUF], Netmask[IPBUF];
     int i;
 
     if( (Error = GetIpForwardTable( NULL, &Size, TRUE )) ==
@@ -63,7 +62,7 @@ int print_routes() {
                    inet_ntoa( IN_ADDR_OF(IpForwardTable->table[i].
                                dwForwardNextHop) ) );
 
-           printf( "%-16s%-16s%-16s%-10d%-10d\n", 
+           printf( "%-16s%-16s%-16s%-10ld%-10ld\n", 
                    Destination,
                    Netmask,
                    Gateway,
index 989d0a2..1715476 100644 (file)
  *          more convenient fdopen()/fprintf() to send()/recv().
  */
 
-#ifndef lint
-static char copyright[] =
-"@(#) Copyright (c) 1980, 1993\n\
-       The Regents of the University of California.  All rights reserved.\n";
-#endif /* not lint */
-
-#ifndef lint
-static char sccsid[] = "@(#)whois.c    8.1 (Berkeley) 6/6/93";
-#endif /* not lint */
-
 #include <sys/types.h>
 #include <winsock2.h>
 /* #include <sys/socket.h> */
 /* #include <netinet/in.h> */
 /* #include <netdb.h> */
 #include <stdio.h>
+#include <stdlib.h>
 
 /* #include <various.h> */
 #include <getopt.h>
@@ -160,6 +151,7 @@ int main(int argc, char **argv)
                putchar(ch);
 
        leave(0);
+       return 0;
 }
 
 void usage()
index 2af4618..69f52b9 100644 (file)
@@ -25,6 +25,7 @@
 <property name="BASEADDRESS_SECUR32" value="0x6b3A0000" />\r
 <property name="BASEADDRESS_SMDLL" value="0x6b3B0000" />\r
 <property name="BASEADDRESS_URLMON" value="0x6b3C0000" />\r
+<property name="BASEADDRESS_SERIALUI" value="0x6b3D0000" />\r
 <property name="BASEADDRESS_CARDS" value="0x701a0000" />\r
 <property name="BASEADDRESS_WININET" value="0x70200000" />\r
 <property name="BASEADDRESS_ACLUI" value="0x71550000" />\r
@@ -58,6 +59,7 @@
 <property name="BASEADDRESS_MMDRV" value="0x77500000" />\r
 <property name="BASEADDRESS_CRTDLL" value="0x77630000" />\r
 <property name="BASEADDRESS_MSAFD" value="0x777a0000" />\r
+<property name="BASEADDRESS_MSI" value="0x777b0000" />\r
 <property name="BASEADDRESS_SNMPAPI" value="0x777c0000" />\r
 <property name="BASEADDRESS_WINMM" value="0x777d0000" />\r
 <property name="BASEADDRESS_WS2HELP" value="0x777e0000" />\r
index f08569e..6bf12a6 100644 (file)
@@ -1,4 +1,4 @@
-<module name="freeldr_base" type="objectlibrary">\r
+<module name="freeldr_base" type="objectlibrary" warnings="true">\r
        <include base="freeldr_base">include</include>\r
        <include base="freeldr_base">cache</include>\r
        <include base="ntoskrnl">include</include>\r
index 43c25f2..009ffc2 100644 (file)
@@ -1,4 +1,4 @@
-<module name="acpi" type="kernelmodedriver" installbase="system32/drivers" installname="acpi.sys">\r
+<module name="acpi" type="kernelmodedriver" installbase="system32/drivers" installname="acpi.sys" warnings="true">\r
        <include base="acpi">include</include>\r
        <include base="acpi">ospm/include</include>\r
        <library>ntoskrnl</library>\r
index fe5626f..c0b239b 100644 (file)
@@ -7,3 +7,6 @@
 <directory name="pci">\r
        <xi:include href="pci/pci.xml" />\r
 </directory>\r
+<directory name="serenum">\r
+       <xi:include href="serenum/serenum.xml" />\r
+</directory>\r
diff --git a/reactos/drivers/bus/serenum/serenum.xml b/reactos/drivers/bus/serenum/serenum.xml
new file mode 100644 (file)
index 0000000..9db96ab
--- /dev/null
@@ -0,0 +1,12 @@
+<module name="serenum" type="kernelmodedriver" installbase="system32/drivers" installname="serenum.sys">
+       <include base="serenum">.</include>
+       <define name="__USE_W32API" />
+       <library>ntoskrnl</library>
+       <library>hal</library>
+       <file>detect.c</file>
+       <file>fdo.c</file>
+       <file>misc.c</file>
+       <file>pdo.c</file>
+       <file>serenum.c</file>
+       <file>serenum.rc</file>
+</module>
index 434406b..e1b38b0 100644 (file)
@@ -50,8 +50,6 @@ BOOLEAN IsSpeakerEnabled(UINT BasePort)
 
 VOID BeginPlayback(UINT BasePort, UINT BitDepth, UINT Channels, UINT BlockSize)
 {
-    CHAR Command;
-
     DPRINT("BeginPlayback(%d, %d, %d, %d)\n", BasePort, BitDepth, Channels, BlockSize);
 
 //    switch(BitDepth)
index bbeddbb..876b170 100644 (file)
@@ -70,7 +70,6 @@ BOOLEAN CreateDMA(PDEVICE_OBJECT DeviceObject)
 {
     DEVICE_DESCRIPTION Desc;
     ULONG MappedRegs = 0;
-    NTSTATUS Status;
     PDEVICE_EXTENSION Device = DeviceObject->DeviceExtension;
     KEVENT DMAEvent;
     KIRQL OldIrql;
index 1448f77..b9ffbff 100644 (file)
@@ -14,14 +14,6 @@ BOOLEAN CheckIRQ(PDEVICE_EXTENSION Parameters)
 
     for (i = 0; ValidIRQs[i] != 0xffff; i ++)
     {
-        UCHAR ThisIRQ = ValidIRQs[i];
-        UCHAR bConfig = (UCHAR)(0x40 |
-                            (ThisIRQ == 7 ? 0x08 :
-                             ThisIRQ == 9 ? 0x10 :
-                             ThisIRQ == 10 ? 0x18 :
-                             ThisIRQ == 11 ? 0x20 :
-                             0));
-
         // Consult the card
 
 //        OUTPORT(pHw, BOARD_CONFIG, bConfig);
@@ -37,7 +29,6 @@ BOOLEAN CheckIRQ(PDEVICE_EXTENSION Parameters)
     // else
     // Compaq stuff?
     {
-        UCHAR CompaqPIDR;
         UCHAR Expected;
 
         switch (Parameters->IRQ)
@@ -59,9 +50,6 @@ BOOLEAN ISR(
     IN PKINTERRUPT pInterrupt,
     IN PVOID Context)
 {
-    PDEVICE_OBJECT DeviceObject = (PDEVICE_OBJECT)Context;
-    PDEVICE_EXTENSION Parameters = DeviceObject->DeviceExtension;
-
     DPRINT("*** Processing ISR ***\n");
 
     // What do we do here then?
index 6c91808..0cd268c 100644 (file)
@@ -83,7 +83,7 @@ WORD InitSoundCard(UINT BasePort)
     {
         // Check to make sure the reset was acknowledged:
         for (TimeOut = SB_TIMEOUT;
-             Status = (SB_READ_DATA(BasePort) != SB_DSP_READY) && TimeOut > 0;
+             (Status = (SB_READ_DATA(BasePort) != SB_DSP_READY) && (TimeOut > 0));
              TimeOut --);
     }
 
index 983918d..71d6ec4 100644 (file)
@@ -292,8 +292,6 @@ NTSTATUS SaveSettings(
         NT status STATUS_SUCCESS if successful
 */
 {
-    NTSTATUS s;
-
     DPRINT("SaveSettings() unimplemented\n");
 
 //    UNIMPLEMENTED;
index 7cb3990..d745702 100644 (file)
@@ -294,8 +294,6 @@ BlasterDeviceControl(PDEVICE_OBJECT DeviceObject,
 {
     PIO_STACK_LOCATION Stack;
     PDEVICE_EXTENSION DeviceExtension;
-    UINT ByteCount;
-    PBYTE Data;
 
     DPRINT("BlasterDeviceControl() called!\n");
 
index 3e0cbbf..fd36af3 100644 (file)
@@ -25,6 +25,7 @@ unsigned char read_dsp(unsigned short base)
 {
 //     while((inb(base+0x0e)&0x80)==0);        //Wait until there is something to read
 //     return  inb(base+0x0a);
+       return 0;
 }
 
 /************************************'
index 8f79320..543cf44 100644 (file)
@@ -13,5 +13,5 @@ unsigned short base;
 unsigned char irq,dma8,dma16;
 unsigned char read_dsp(unsigned short base);
 void write_dsp(unsigned short base,unsigned char data);
-//sb_status detect_dsp(SB16* sb16);
+sb_status detect_dsp(SB16* sb16);
 sb_status reset_dsp(unsigned short base_address);
index 8a579eb..6aa9ab2 100644 (file)
@@ -20,6 +20,7 @@ unsigned char read_mixer(unsigned short base,unsigned char reg)
 
 //     outb(base+0x04,reg);
 //     return inb(base+0x05);
+       return 0;
 }
 
 unsigned char get_irq(SB16* sb16)
index 051e14a..d084a55 100644 (file)
@@ -77,6 +77,7 @@ NTSTATUS ModuleEntry(PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath)
  * RETURNS: Success or failure
  */
 {
+#if 0
        PDEVICE_OBJECT DeviceObject;
        NTSTATUS ret;
    
@@ -96,7 +97,7 @@ NTSTATUS ModuleEntry(PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath)
        DriverObject->MajorFunction[IRP_MJ_WRITE] = Dispatch;
        DriverObject->MajorFunction[IRP_MJ_WRITE] = Dispatch;
        DriverObject->DriverUnload = NULL;
-   
+#endif
        return(STATUS_SUCCESS);
 }
 
index 79927c0..2f86adb 100644 (file)
@@ -29,7 +29,7 @@ SB16 sb16;
 
 ULONG OldIRQ;
 PKINTERRUPT IrqObject;
-BOOLEAN DMAOutputISR(PKINTERRUPT Interrupt, PVOID ServiceContext)
+BOOLEAN STDCALL DMAOutputISR(PKINTERRUPT Interrupt, PVOID ServiceContext)
 {
        DPRINT1("interrupt\n");
        return FALSE;
@@ -42,7 +42,7 @@ void sb16_play(WAVE_HDR* wave)
        KIRQL Dirql;
        KAFFINITY Affinity;
        PKINTERRUPT IrqObject;
-       unsigned int mask,newmask;
+       unsigned int newmask;
        
        unsigned int i;
        unsigned int tmp[255];
index d5e6ff0..48069b0 100644 (file)
@@ -1,5 +1,5 @@
-<module name="oskittcp" type="staticlibrary">\r
-        <define name="__REACTOS__">1</define>\r
+<module name="oskittcp" type="staticlibrary" warnings="true">\r
+       <define name="__REACTOS__">1</define>\r
        <define name="__NTDRIVER__"/>\r
        <define name="KERNEL"/>\r
        <define name="_DISABLE_TIDENTS"/>\r
index d44098f..d117463 100644 (file)
@@ -1,4 +1,4 @@
-<module name="cabinet" type="win32dll" baseaddress="${BASEADDRESS_CABINET}" installbase="system32" installname="cabinet.dll">\r
+<module name="cabinet" type="win32dll" baseaddress="${BASEADDRESS_CABINET}" installbase="system32" installname="cabinet.dll" warnings="true">\r
        <importlibrary definition="cabinet.spec.def" />\r
        <include base="cabinet">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 58d1d23..8fc1741 100644 (file)
@@ -1,4 +1,4 @@
-<module name="comctl32" type="win32dll" baseaddress="${BASEADDRESS_COMCTL32}" installbase="system32" installname="comctl32.dll">\r
+<module name="comctl32" type="win32dll" baseaddress="${BASEADDRESS_COMCTL32}" installbase="system32" installname="comctl32.dll" warnings="true">\r
        <importlibrary definition="comctl32.spec.def" />\r
        <include base="comctl32">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 745bec7..f361b88 100644 (file)
@@ -1,4 +1,4 @@
-<module name="comdlg32" type="win32dll" baseaddress="${BASEADDRESS_COMDLG32}" installbase="system32" installname="comdlg32.dll">\r
+<module name="comdlg32" type="win32dll" baseaddress="${BASEADDRESS_COMDLG32}" installbase="system32" installname="comdlg32.dll" warnings="true">\r
        <importlibrary definition="comdlg32.spec.def" />\r
        <include base="comdlg32">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 082efac..ccc8bc9 100644 (file)
@@ -1,4 +1,4 @@
-<module name="dbghelp" type="win32dll" baseaddress="${BASEADDRESS_DBGHELP}" installbase="system32" installname="dbghelp.dll">\r
+<module name="dbghelp" type="win32dll" baseaddress="${BASEADDRESS_DBGHELP}" installbase="system32" installname="dbghelp.dll" warnings="true">\r
        <importlibrary definition="dbghelp.spec.def" />\r
        <include base="dbghelp">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index dc3ae29..9f10fed 100644 (file)
@@ -1,4 +1,4 @@
-<module name="devenum" type="win32dll" baseaddress="${BASEADDRESS_DEVENUM}" installbase="system32" installname="devenum.dll">\r
+<module name="devenum" type="win32dll" baseaddress="${BASEADDRESS_DEVENUM}" installbase="system32" installname="devenum.dll" warnings="true">\r
        <importlibrary definition="devenum.spec.def" />\r
        <include base="devenum">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 5ee3f65..9759739 100644 (file)
@@ -1,4 +1,4 @@
-<module name="dinput" type="win32dll" baseaddress="${BASEADDRESS_DINPUT}" installbase="system32" installname="dinput.dll">\r
+<module name="dinput" type="win32dll" baseaddress="${BASEADDRESS_DINPUT}" installbase="system32" installname="dinput.dll" warnings="true">\r
        <importlibrary definition="dinput.spec.def" />\r
        <include base="dinput">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 7fe706b..05fd22a 100644 (file)
 <directory name="msgina">\r
        <xi:include href="msgina/msgina.xml" />\r
 </directory>\r
+<directory name="msi">\r
+       <xi:include href="msi/msi.xml" />\r
+</directory>\r
 <directory name="msimg32">\r
        <xi:include href="msimg32/msimg32.xml" />\r
 </directory>\r
 <directory name="secur32">\r
        <xi:include href="secur32/secur32.xml" />\r
 </directory>\r
+<directory name="serialui">\r
+       <xi:include href="serialui/serialui.xml" />\r
+</directory>\r
 <directory name="setupapi">\r
        <xi:include href="setupapi/setupapi.xml" />\r
 </directory>\r
index 45d0e11..7b1d3d6 100644 (file)
@@ -1,4 +1,4 @@
-<module name="iphlpapi" type="win32dll" baseaddress="${BASEADDRESS_IPHLPAPI}" installbase="system32" installname="iphlpapi.dll">\r
+<module name="iphlpapi" type="win32dll" baseaddress="${BASEADDRESS_IPHLPAPI}" installbase="system32" installname="iphlpapi.dll" warnings="true">\r
        <importlibrary definition="iphlpapi.spec.def" />\r
        <include base="iphlpapi">include</include>\r
        <include base="ReactOS">include/wine</include>\r
index c6a687c..399e875 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbdda" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdda.dll">\r
+<module name="kbdda" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdda.dll" warnings="true">\r
        <importlibrary definition="kbdda.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
index ddf8d9a..7d03f1b 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbddv" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbddv.dll">\r
+<module name="kbddv" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbddv.dll" warnings="true">\r
        <importlibrary definition="kbddv.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
index 2ec4a6c..92e1219 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbdes" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdes.dll">\r
+<module name="kbdes" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdes.dll" warnings="true">\r
        <importlibrary definition="kbdes.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
index 00749bb..cf1e6f3 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbdfr" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdfr.dll">\r
+<module name="kbdfr" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdfr.dll" warnings="true">\r
        <importlibrary definition="kbdfr.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
index fd896c4..e24f249 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbdgr" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdgr.dll">\r
+<module name="kbdgr" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdgr.dll" warnings="true">\r
        <importlibrary definition="kbdgr.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
index 5388a84..39cd023 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbdse" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdse.dll">\r
+<module name="kbdse" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdse.dll" warnings="true">\r
        <importlibrary definition="kbdse.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
index e45d648..46d4029 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbduk" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbduk.dll">\r
+<module name="kbduk" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbduk.dll" warnings="true">\r
        <importlibrary definition="kbduk.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
index 3976179..89f2c6f 100644 (file)
@@ -1,4 +1,4 @@
-<module name="kbdus" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdus.dll">\r
+<module name="kbdus" type="kernelmodedll" entrypoint="0" installbase="system32" installname="kbdus.dll" warnings="true">\r
        <importlibrary definition="kbdus.def" />\r
        <include base="ntoskrnl">include</include>\r
        <define name="_DISABLE_TIDENTS" />\r
diff --git a/reactos/lib/msi/msi.xml b/reactos/lib/msi/msi.xml
new file mode 100644 (file)
index 0000000..1514fca
--- /dev/null
@@ -0,0 +1,52 @@
+<module name="msi" type="win32dll" baseaddress="${BASEADDRESS_MSI}" installbase="system32" installname="msi.dll" warnings="true">
+       <importlibrary definition="msi.spec.def" />
+       <include base="msi">.</include>
+       <include base="ReactOS">include/wine</include>
+       <define name="__REACTOS__" />
+       <define name="__USE_W32API" />
+       <define name="_WIN32_IE">0x600</define>
+       <define name="_WIN32_WINNT">0x501</define>
+       <define name="WINVER">0x501</define>
+       <library>wine</library>
+       <library>uuid</library>
+       <library>ntdll</library>
+       <library>kernel32</library>
+       <library>user32</library>
+       <library>gdi32</library>
+       <library>advapi32</library>
+       <library>shell32</library>
+       <library>winmm</library>
+       <library>cabinet</library>
+       <library>ole32</library>
+       <library>oleaut32</library>
+       <library>version</library>
+       <file>action.c</file>
+       <file>appsearch.c</file>
+       <file>cond.tab.c</file>
+       <file>create.c</file>
+       <file>custom.c</file>
+       <file>delete.c</file>
+       <file>dialog.c</file>
+       <file>distinct.c</file>
+       <file>format.c</file>
+       <file>handle.c</file>
+       <file>insert.c</file>
+       <file>msi.c</file>
+       <file>msiquery.c</file>
+       <file>order.c</file>
+       <file>package.c</file>
+       <file>preview.c</file>
+       <file>record.c</file>
+       <file>registry.c</file>
+       <file>regsvr.c</file>
+       <file>select.c</file>
+       <file>sql.tab.c</file>
+       <file>string.c</file>
+       <file>suminfo.c</file>
+       <file>table.c</file>
+       <file>tokenize.c</file>
+       <file>update.c</file>
+       <file>where.c</file>
+       <file>msi.spec</file>
+       <file>msi.rc</file>
+</module>
index 49f8b76..597e8a0 100644 (file)
@@ -122,7 +122,7 @@ InterlockedCompareExchange(PLONG Destination,
        LONG Exchange,
        LONG Comperand)
 {      
-       PVOID ret;
+       LONG ret;
        __asm__ ( /* lock for SMP systems */
                   "lock\n\t"
                   "cmpxchgl %2,(%1)"
index 9cc776b..6cddd5c 100644 (file)
@@ -1,4 +1,4 @@
-<module name="ole32" type="win32dll" baseaddress="${BASEADDRESS_OLE32}" installbase="system32" installname="ole32.dll">\r
+<module name="ole32" type="win32dll" baseaddress="${BASEADDRESS_OLE32}" installbase="system32" installname="ole32.dll" warnings="true">\r
        <importlibrary definition="ole32.spec.def" />\r
        <include base="ole32">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index e885c4e..c9b3c04 100644 (file)
@@ -1,4 +1,4 @@
-<module name="oleaut32" type="win32dll" baseaddress="${BASEADDRESS_OLEAUT32}" installbase="system32" installname="oleaut32.dll">\r
+<module name="oleaut32" type="win32dll" baseaddress="${BASEADDRESS_OLEAUT32}" installbase="system32" installname="oleaut32.dll" warnings="true">\r
        <importlibrary definition="oleaut32.spec.def" />\r
        <include base="oleaut32">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index cfc5135..e3e97fc 100644 (file)
@@ -1,4 +1,4 @@
-<module name="riched20" type="win32dll" baseaddress="${BASEADDRESS_RICHED20}">
+<module name="riched20" type="win32dll" baseaddress="${BASEADDRESS_RICHED20}" warnings="true">
        <importlibrary definition="riched20.spec.def" />
        <include base="riched20">.</include>
        <include base="ReactOS">include/wine</include>
index f0be6dd..7577e74 100644 (file)
@@ -1,4 +1,4 @@
-<module name="rpcrt4" type="win32dll" baseaddress="${BASEADDRESS_RPCRT4}">\r
+<module name="rpcrt4" type="win32dll" baseaddress="${BASEADDRESS_RPCRT4}" warnings="true">\r
        <importlibrary definition="rpcrt4.spec.def" />\r
        <include base="rpcrt4">.</include>\r
        <include base="ReactOS">include/wine</include>\r
diff --git a/reactos/lib/serialui/serialui.xml b/reactos/lib/serialui/serialui.xml
new file mode 100644 (file)
index 0000000..56637e5
--- /dev/null
@@ -0,0 +1,12 @@
+<module name="serialui" type="win32dll" baseaddress="${BASEADDRESS_SERIALUI}">
+       <importlibrary definition="serialui.def" />
+       <include base="serialui">.</include>
+       <define name="__USE_W32API" />
+       <define name="UNICODE" />
+       <define name="_UNICODE" />
+       <library>kernel32</library>
+       <library>user32</library>
+       <library>shlwapi</library>
+       <file>serialui.c</file>
+       <file>serialui.rc</file>
+</module>
index 739d6c5..2524200 100644 (file)
@@ -1,4 +1,4 @@
-<module name="setupapi" type="win32dll" baseaddress="${BASEADDRESS_SETUPAPI}" installbase="system32" installname="setupapi.dll">\r
+<module name="setupapi" type="win32dll" baseaddress="${BASEADDRESS_SETUPAPI}" installbase="system32" installname="setupapi.dll" warnings="true">\r
        <importlibrary definition="setupapi.spec.def" />\r
        <include base="setupapi">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 85064cc..fa7ac28 100644 (file)
@@ -1,4 +1,4 @@
-<module name="shdocvw" type="win32dll" baseaddress="${BASEADDRESS_SHDOCVW}" installbase="system32" installname="shdocvw.dll">\r
+<module name="shdocvw" type="win32dll" baseaddress="${BASEADDRESS_SHDOCVW}" installbase="system32" installname="shdocvw.dll" warnings="true">\r
        <importlibrary definition="shdocvw.spec.def" />\r
        <include base="shdocvw">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 8eb3b62..796703e 100644 (file)
@@ -1,4 +1,4 @@
-<module name="shell32" type="win32dll" baseaddress="${BASEADDRESS_SHELL32}" installbase="system32" installname="shell32.dll">\r
+<module name="shell32" type="win32dll" baseaddress="${BASEADDRESS_SHELL32}" installbase="system32" installname="shell32.dll" warnings="true">\r
        <importlibrary definition="shell32.spec.def" />\r
        <include base="shell32">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index a018851..b6db72e 100644 (file)
@@ -1,4 +1,4 @@
-<module name="shlwapi" type="win32dll" baseaddress="${BASEADDRESS_SHLWAPI}" installbase="system32" installname="shlwapi.dll">\r
+<module name="shlwapi" type="win32dll" baseaddress="${BASEADDRESS_SHLWAPI}" installbase="system32" installname="shlwapi.dll" warnings="true">\r
        <importlibrary definition="shlwapi.spec.def" />\r
        <include base="shlwapi">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 6e9156f..5253d0c 100644 (file)
@@ -1,4 +1,4 @@
-<module name="urlmon" type="win32dll" baseaddress="${BASEADDRESS_URLMON}" installbase="system32" installname="urlmon.dll">\r
+<module name="urlmon" type="win32dll" baseaddress="${BASEADDRESS_URLMON}" installbase="system32" installname="urlmon.dll" warnings="true">\r
        <importlibrary definition="urlmon.spec.def" />\r
        <include base="urlmon">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index 1d9260a..bf73535 100644 (file)
@@ -232,7 +232,7 @@ AddDesktopItemW (BOOL bCommonDesktop,
   WCHAR szLinkPath[MAX_PATH];
   WCHAR szArguments[MAX_PATH];
   WCHAR szCommand[MAX_PATH];
-  WIN32_FIND_DATA FindData;
+  WIN32_FIND_DATAW FindData;
   HANDLE hFind;
   LPWSTR Ptr;
   DWORD dwLength;
@@ -416,7 +416,7 @@ DeleteDesktopItemW (BOOL bCommonItem,
   wcscat (szLinkPath, L".lnk");
   DPRINT ("Link path: '%S'\n", szLinkPath);
 
-  return DeleteFile (szLinkPath);
+  return DeleteFileW (szLinkPath);
 }
 
 
@@ -657,7 +657,7 @@ AddItemW (LPCWSTR lpGroupName,  /* Optional */
   WCHAR szLinkPath[MAX_PATH];
   WCHAR szArguments[MAX_PATH];
   WCHAR szCommand[MAX_PATH];
-  WIN32_FIND_DATA FindData;
+  WIN32_FIND_DATAW FindData;
   HANDLE hFind;
   LPWSTR Ptr;
   DWORD dwLength;
index 07a873d..482827d 100644 (file)
@@ -206,7 +206,7 @@ CopyKey (HKEY hDstKey,
              return FALSE;
            }
 
-         if (RegSetValueEx (hDstKey,
+         if (RegSetValueExW (hDstKey,
                             lpNameBuffer,
                             0,
                             dwType,
index f5b5335..e809ff9 100644 (file)
@@ -110,7 +110,7 @@ InitializeProfiles (VOID)
   HKEY hKey;
 
   /* Load profiles directory path */
-  if (!LoadString(hInstance,
+  if (!LoadStringW(hInstance,
                  IDS_PROFILEPATH,
                  szBuffer,
                  MAX_PATH))
@@ -289,7 +289,7 @@ InitializeProfiles (VOID)
     }
 
   /* Set 'Fonts' folder path */
-  GetWindowsDirectory(szBuffer, MAX_PATH);
+  GetWindowsDirectoryW(szBuffer, MAX_PATH);
   wcscat(szBuffer, L"\\media\\fonts");
 
   dwLength = (wcslen(szBuffer) + 1) * sizeof(WCHAR);
@@ -541,7 +541,7 @@ InitializeProfiles (VOID)
   RegCloseKey(hKey);
 
   /* Load 'Program Files' location */
-  if (!LoadString(hInstance,
+  if (!LoadStringW(hInstance,
                  IDS_PROGRAMFILES,
                  szBuffer,
                  MAX_PATH))
index 616014e..cbff235 100644 (file)
@@ -1,4 +1,4 @@
-<module name="winmm" type="win32dll" baseaddress="${BASEADDRESS_WINMM}" installbase="system32" installname="winmm.dll">\r
+<module name="winmm" type="win32dll" baseaddress="${BASEADDRESS_WINMM}" installbase="system32" installname="winmm.dll" warnings="true">\r
        <importlibrary definition="winmm.spec.def" />\r
        <include base="winmm">.</include>\r
        <include base="ReactOS">include/wine</include>\r
index bdbc8de..bc2bad7 100644 (file)
@@ -1,4 +1,4 @@
-<module name="calc" type="win32gui" installbase="system32" installname="calc.exe">\r
+<module name="calc" type="win32gui" installbase="system32" installname="calc.exe" warnings="true">\r
        <include base="calc">.</include>\r
        <define name="__USE_W32API" />\r
        <define name="_WIN32_IE">0x0501</define>\r
index 3c5ff42..c85058c 100644 (file)
@@ -16,6 +16,9 @@
 <directory name="format">\r
        <xi:include href="format/format.xml" />\r
 </directory>\r
+<directory name="msiexec">\r
+       <xi:include href="msiexec/msiexec.xml" />\r
+</directory>\r
 <directory name="notepad">\r
        <xi:include href="notepad/notepad.xml" />\r
 </directory>\r
diff --git a/reactos/subsys/system/msiexec/msiexec.xml b/reactos/subsys/system/msiexec/msiexec.xml
new file mode 100644 (file)
index 0000000..ad522e9
--- /dev/null
@@ -0,0 +1,19 @@
+<module name="msiexec" type="win32gui" installbase="system32" installname="msiexec.exe" warnings="true">
+       <include base="msiexec">.</include>
+       <include base="ReactOS">include/wine</include>
+       <define name="__REACTOS__" />
+       <define name="__USE_W32API" />
+       <define name="_WIN32_IE">0x501</define>
+       <define name="_WIN32_WINNT">0x501</define>
+       <define name="WINVER">0x501</define>
+       <library>uuid</library>
+       <library>wine</library>
+       <library>ntdll</library>
+       <library>kernel32</library>
+       <library>user32</library>
+       <library>advapi32</library>
+       <library>ole32</library>
+       <library>msi</library>
+       <file>msiexec.c</file>
+       <file>version.rc</file>
+</module>
index 04040f3..a4528e0 100644 (file)
@@ -131,7 +131,7 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
  *  WM_DESTROY  - post a quit message and return
  *
  */
-INT_PTR CALLBACK
+LRESULT CALLBACK
 ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
 {
     static short last_split;
index 3d0ee68..84f186f 100644 (file)
@@ -271,7 +271,6 @@ LRESULT CALLBACK DwordEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPAR
 INT_PTR CALLBACK modify_dword_dlgproc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam)
 {
     WNDPROC oldproc;
-    TCHAR* valueData;
     HWND hwndValue;
     int len;
     TCHAR ValueString[32];
@@ -398,7 +397,6 @@ INT_PTR CALLBACK modify_dword_dlgproc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LP
 
 INT_PTR CALLBACK modify_binary_dlgproc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam)
 {
-    PVOID valueData;
     HWND hwndValue;
     int len;
 
index 71a7b5d..8cb0a28 100644 (file)
@@ -642,7 +642,7 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
  *
  */
 
-INT_PTR CALLBACK
+LRESULT CALLBACK
 FrameWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
 {
     switch (message) {
index a363752..c305922 100644 (file)
@@ -21,6 +21,8 @@
 #define WIN32_LEAN_AND_MEAN     /* Exclude rarely-used stuff from Windows headers */
 #include <windows.h>
 #include <commctrl.h>
+#include <stdio.h>
+#include <stdlib.h>
 #include <tchar.h>
 
 #include "hexedit.h"
@@ -226,7 +228,7 @@ HEXEDIT_PaintLines(PHEXEDIT_DATA hed, HDC hDC, DWORD ScrollPos, DWORD First, DWO
       dx = hed->LeftMargin;
       
       /* draw address */
-      _stprintf(addr, _T("%04X"), linestart);
+      _stprintf(addr, _T("%04lX"), linestart);
       TextOut(hDC, dx, dy, addr, 4);
       
       dx += ((4 + hed->AddressSpacing) * hed->CharWidth);
@@ -273,7 +275,6 @@ HEXEDIT_PaintLines(PHEXEDIT_DATA hed, HDC hDC, DWORD ScrollPos, DWORD First, DWO
 static DWORD
 HEXEDIT_HitRegionTest(PHEXEDIT_DATA hed, POINTS pt)
 {
-  WINDOWINFO wi;
   int d;
   
   if(pt.x <= hed->LeftMargin)
@@ -478,6 +479,7 @@ HEXEDIT_HEM_SETMAXBUFFERSIZE(PHEXEDIT_DATA hed, DWORD nMaxSize)
     hed->hBuffer = LocalReAlloc(hed->hBuffer, hed->MaxBuffer, LMEM_MOVEABLE);
     HEXEDIT_Update(hed);
   }
+  return 0;
 }
 
 /*** Message Proc *************************************************************/
index 2aea225..4383117 100644 (file)
@@ -176,7 +176,7 @@ static void AddEntryToList(HWND hwndLV, LPTSTR Name, DWORD dwValType, void* ValB
             break;
         case REG_MULTI_SZ:
             {
-              LPTSTR src, str, cursrc;
+              LPTSTR src, str;
               if(dwCount >= 2)
               {
                  src = (LPTSTR)ValBuf;
@@ -374,17 +374,6 @@ static int CALLBACK CompareFunc(LPARAM lParam1, LPARAM lParam2, LPARAM lParamSor
     return g_invertSort ? _tcscmp(r->name, l->name) : _tcscmp(l->name, r->name);
 }
 
-static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
-{
-    switch (LOWORD(wParam)) {
-        /*    case ID_FILE_OPEN: */
-        /*        break; */
-    default:
-        return FALSE;
-    }
-    return TRUE;
-}
-
 BOOL ListWndNotifyProc(HWND hWnd, WPARAM wParam, LPARAM lParam, BOOL *Result)
 {
     NMLVDISPINFO* Info;
@@ -445,7 +434,6 @@ BOOL ListWndNotifyProc(HWND hWnd, WPARAM wParam, LPARAM lParam, BOOL *Result)
                 }
                 else
                 {
-                  LONG ret;
                  //if((ret = RenameValue(lineinfo->name, Info->item.pszText)) != ERROR_SUCCESS)
                   {
                    TCHAR msg[128], caption[128];
index 40c9f20..30bc08f 100644 (file)
@@ -21,6 +21,8 @@
 #define WIN32_LEAN_AND_MEAN     /* Exclude rarely-used stuff from Windows headers */
 #include <windows.h>
 #include <commctrl.h>
+#include <accctrl.h>
+#include <unknwn.h>
 #include <stdlib.h>
 #include <tchar.h>
 #include <process.h>
@@ -29,7 +31,7 @@
 
 #include "main.h"
 #include "hexedit.h"
-
+#include "security.h"
 
 BOOL ProcessCmdLine(LPSTR lpCmdLine);
 
@@ -118,7 +120,6 @@ BOOL InitInstance(HINSTANCE hInstance, int nCmdShow)
     if(!AclUiAvailable)
     {
       HMENU hEditMenu;
-      int mePos;
       /* hide the Edit/Permissions... menu entry */
       hEditMenu = GetSubMenu(hMenuFrame, 1);
       if(hEditMenu != NULL)
index 5bce146..96c6d42 100644 (file)
@@ -80,10 +80,10 @@ extern TCHAR szChildClass[];
 extern void ShowAboutBox(HWND hWnd);
 
 /* childwnd.c */
-extern INT_PTR CALLBACK ChildWndProc(HWND, UINT, WPARAM, LPARAM);
+extern LRESULT CALLBACK ChildWndProc(HWND, UINT, WPARAM, LPARAM);
 
 /* framewnd.c */
-extern INT_PTR CALLBACK FrameWndProc(HWND, UINT, WPARAM, LPARAM);
+extern LRESULT CALLBACK FrameWndProc(HWND, UINT, WPARAM, LPARAM);
 extern void SetupStatusBar(HWND hWnd, BOOL bResize);
 extern void UpdateStatusBar(void);
 
index 974e3c0..acf2045 100644 (file)
@@ -22,6 +22,7 @@
 
 #include <limits.h>
 #include <stdio.h>
+#include <ctype.h>
 #include <windows.h>
 #include <winnt.h>
 #include <winreg.h>
index 216f389..74669b9 100644 (file)
    Implementation of the CRegKeySecurity interface
  ******************************************************************************/
  
+ static ifaceCRegKeySecurityVbtl efvt =
+{
+  /* IUnknown methods */
+  CRegKeySecurity_fnQueryInterface,
+  CRegKeySecurity_fnAddRef,
+  CRegKeySecurity_fnRelease,
+  
+  /* CRegKeySecurity methods */
+  CRegKeySecurity_fnGetObjectInformation,
+  CRegKeySecurity_fnGetSecurity,
+  CRegKeySecurity_fnSetSecurity,
+  CRegKeySecurity_fnGetAccessRights,
+  CRegKeySecurity_fnMapGeneric,
+  CRegKeySecurity_fnGetInheritTypes,
+  CRegKeySecurity_fnPropertySheetPageCallback
+};
+
 SI_ACCESS RegAccess[] = {
   {&GUID_NULL, KEY_ALL_ACCESS,         (LPWSTR)MAKEINTRESOURCE(IDS_ACCESS_FULLCONTROL),      SI_ACCESS_GENERAL | SI_ACCESS_SPECIFIC},
   {&GUID_NULL, KEY_READ,               (LPWSTR)MAKEINTRESOURCE(IDS_ACCESS_READ),             SI_ACCESS_GENERAL},
@@ -257,7 +274,6 @@ RegKeyEditPermissions(HWND hWndOwner,
                       LPCTSTR lpKeyName)
 {
   BOOL Result;
-  HMODULE hAclEditDll;
   LPWSTR Machine, KeyName;
   HKEY hInfoKey;
   LPREGKEYSECURITY RegKeySecurity;
index a0e9f83..ada97c7 100644 (file)
@@ -12,6 +12,12 @@ GetSecurityInfo(HANDLE handle,
                 PACL* ppSacl,
                 PSECURITY_DESCRIPTOR* ppSecurityDescriptor);
 
+extern BOOL
+InitializeAclUiDll(VOID);
+
+extern VOID
+UnloadAclUiDll(VOID);
+
 DEFINE_GUID(IID_CRegKeySecurity, 0x965fc360, 0x16ff, 0x11d0, 0x0091, 0xcb,0x00,0xaa,0x00,0xbb,0xb7,0x23);
 
 /******************************************************************************
@@ -103,23 +109,6 @@ HRESULT STDMETHODCALLTYPE CRegKeySecurity_fnPropertySheetPageCallback(LPREGKEYSE
                                                                       UINT uMsg,
                                                                       SI_PAGE_TYPE uPage);
 
-static ifaceCRegKeySecurityVbtl efvt =
-{
-  /* IUnknown methods */
-  CRegKeySecurity_fnQueryInterface,
-  CRegKeySecurity_fnAddRef,
-  CRegKeySecurity_fnRelease,
-  
-  /* CRegKeySecurity methods */
-  CRegKeySecurity_fnGetObjectInformation,
-  CRegKeySecurity_fnGetSecurity,
-  CRegKeySecurity_fnSetSecurity,
-  CRegKeySecurity_fnGetAccessRights,
-  CRegKeySecurity_fnMapGeneric,
-  CRegKeySecurity_fnGetInheritTypes,
-  CRegKeySecurity_fnPropertySheetPageCallback
-};
-
 #endif /* _REGEXP_SECURITY_H */
 
 /* EOF */
index 3d1240c..11ff644 100644 (file)
@@ -86,6 +86,7 @@ FillErrorReport(HWND hwndDlg)
   return errorReport;\r
 }\r
 \r
+VOID\r
 ReleaseErrorReport(LPERROR_REPORT errorReport)\r
 {\r
   if (errorReport->YourEmail)\r
@@ -320,10 +321,8 @@ ReceiveResponse(SOCKET socket, LPSTR responseBuffer, PULONG responseBufferSize)
 {\r
   PCHAR pch = (PCHAR)responseBuffer;\r
   ULONG length = 0;\r
-  INT contentLength = 0;\r
   fd_set fdset[1];\r
   struct timeval timeout;\r
-  CHAR buf[4000];\r
 \r
   FD_ZERO(&fdset);\r
   FD_SET(socket, &fdset);\r
@@ -380,7 +379,6 @@ SubmissionThread(LPVOID lpParameter)
   SOCKET socket;\r
   HANDLE hThread;\r
   INT error;\r
-  INT i;\r
 \r
   if (AbortSubmission != 0)\r
     goto done;\r
@@ -585,11 +583,9 @@ WinMain(HINSTANCE hInstance,
        LPSTR lpszCmdLine,\r
        int nCmdShow)\r
 {\r
-       WORD wVersionRequested;\r
-       WSADATA wsaData;\r
-       INT error;\r
-  INT version;\r
-  WCHAR *lc;\r
+  WORD wVersionRequested;\r
+  WSADATA wsaData;\r
+  INT error;\r
 \r
   hAppInstance = hInstance;\r
 \r
@@ -602,12 +598,12 @@ WinMain(HINSTANCE hInstance,
     LoadString(hAppInstance, IDS_FAILED_TO_INITIALIZE_WINSOCK, format, sizeof(format) / sizeof(WCHAR));\r
     wsprintf(message, format, error);\r
     MessageBox(NULL, message, NULL, MB_ICONWARNING);\r
-    return;\r
+    return 0;\r
   }\r
   \r
   CreateWizard();\r
 \r
-       WSACleanup();\r
+  WSACleanup();\r
   \r
   return 0;\r
 }\r
index 5521379..68b920b 100644 (file)
@@ -1,4 +1,4 @@
-<module name="usetup" type="nativecui" installbase="system32" installname="usetup.exe">\r
+<module name="usetup" type="nativecui" installbase="system32" installname="usetup.exe" warnings="true">\r
        <bootstrap base="reactos/system32" nameoncd="smss.exe" />\r
        <include base="usetup">.</include>\r
        <include base="zlib">.</include>\r
index 8dac35e..e2809e6 100644 (file)
@@ -1,4 +1,4 @@
-<module name="winefile" type="win32gui"  installbase="system32" installname="winefile.exe">\r
+<module name="winefile" type="win32gui"  installbase="system32" installname="winefile.exe" warnings="true">\r
        <include base="winefile">.</include>\r
        <define name="UNICODE" />\r
        <define name="__USE_W32API" />\r
index ee68335..dd31a49 100644 (file)
@@ -1,2 +1,2 @@
 /* EMPTY FOR NOW */
-/* Hope I didn't delete existing defs!! Check CVS version of this file.. */
\ No newline at end of file
+/* Hope I didn't delete existing defs!! Check CVS version of this file.. */
index 4e34985..935d696 100644 (file)
@@ -417,10 +417,11 @@ MingwBackend::GenerateGlobalVariables () const
        GenerateGlobalCFlagsAndProperties (\r
                "=",\r
                ProjectNode.non_if_data );\r
-       fprintf ( fMakefile, "PROJECT_RCFLAGS = $(PROJECT_CFLAGS)\n" );\r
-       fprintf ( fMakefile, "PROJECT_WIDLFLAGS = $(PROJECT_CFLAGS)\n" );\r
-       fprintf ( fMakefile, "PROJECT_LFLAGS = %s\n",\r
+       fprintf ( fMakefile, "PROJECT_RCFLAGS := $(PROJECT_CFLAGS)\n" );\r
+       fprintf ( fMakefile, "PROJECT_WIDLFLAGS := $(PROJECT_CFLAGS)\n" );\r
+       fprintf ( fMakefile, "PROJECT_LFLAGS := %s\n",\r
                  GenerateProjectLFLAGS ().c_str () );\r
+       fprintf ( fMakefile, "PROJECT_CFLAGS += -Wall\n" );\r
        fprintf ( fMakefile, "\n" );\r
 }\r
 \r
index 03e2514..9290027 100644 (file)
@@ -1445,6 +1445,8 @@ MingwModuleHandler::GenerateOtherMacros ()
        string globalCflags = "-g";\r
        if ( backend->usePipe )\r
                globalCflags += " -pipe";\r
+       if ( !module.enableWarnings )\r
+               globalCflags += " -Werror";\r
        \r
        fprintf (\r
                fMakefile,\r
index 8bfd035..d51ebda 100644 (file)
@@ -222,6 +222,12 @@ Module::Module ( const Project& project,
                useWRC = att->value == "true";\r
        else\r
                useWRC = true;\r
+\r
+       att = moduleNode.GetAttribute ( "warnings", false );\r
+       if ( att != NULL )\r
+               enableWarnings = att->value == "true";\r
+       else\r
+               enableWarnings = false;\r
 }\r
 \r
 Module::~Module ()\r
index b52ff47..b50b587 100644 (file)
@@ -176,6 +176,7 @@ public:
        std::string installBase;\r
        std::string installName;\r
        bool useWRC;\r
+       bool enableWarnings;\r
 \r
        Module ( const Project& project,\r
                 const XMLElement& moduleNode,\r
index e707ac0..af5b9fb 100644 (file)
@@ -107,7 +107,7 @@ Module element
 There can be zero or more modules per xml build file.\r
 \r
 Syntax:\r
-       <module name="msvcrt" type="win32dll" extension=".dll" entrypoint="_DllMain@12" baseaddress="0x70000000" mangledsymbols="true" installbase="system32" installname="msvcrt.dll" usewrc="false">\r
+       <module name="msvcrt" type="win32dll" extension=".dll" entrypoint="_DllMain@12" baseaddress="0x70000000" mangledsymbols="true" installbase="system32" installname="msvcrt.dll" usewrc="false" warnings="true">\r
                ...\r
        </module>\r
 \r
@@ -121,6 +121,7 @@ Attributes:
        installbase - Base directory of the generated file in the installation directory. This attribute is optional.\r
        installname - Name of generated file in the installation directory. This attribute is optional, but if not specified, the generated file is not copied to the installation directory.\r
        usewrc - Use WRC to compile resources if true. If false, windres is used. This attribute is optional. If not specified, WRC will be used.\r
+       warnings - Error out if false and at least one warning is emitted during building of this module. This attribute is optional. If not specified, it is assumed to be false.\r
 \r
 Value:\r
        None.\r