102 min agoFix build. master trunk
gadamopoulos [Tue, 21 Feb 2017 21:53:34 +0000 (21:53 +0000)]
Fix build.

git-svn-id: file:///srv/svn/reactos/trunk@73874 97493ccd-5924-5043-b1f5-66cb403b36ce

108 min ago[COMCTL32] -Rename BUTTON_Paint to BUTTON_PaintWithTheme and use it in the newly...
gadamopoulos [Tue, 21 Feb 2017 21:47:41 +0000 (21:47 +0000)]
[COMCTL32] -Rename BUTTON_Paint to BUTTON_PaintWithTheme and use it in the newly added code for the v6 button.

git-svn-id: file:///srv/svn/reactos/trunk@73873 97493ccd-5924-5043-b1f5-66cb403b36ce

2 hours ago[COMCTL32] -Add a comment to clarify that there is no need to backport the #ifdef...
gadamopoulos [Tue, 21 Feb 2017 21:07:06 +0000 (21:07 +0000)]
[COMCTL32] -Add a comment to clarify that there is no need to backport the #ifdef _USER32_ defines back to user32 (although they will work fine in user32).

git-svn-id: file:///srv/svn/reactos/trunk@73872 97493ccd-5924-5043-b1f5-66cb403b36ce

2 hours ago[COMCTL32]: Copy button.c from user32, make the needed changes to make it compile...
gadamopoulos [Tue, 21 Feb 2017 21:03:04 +0000 (21:03 +0000)]
[COMCTL32]: Copy button.c from user32, make the needed changes to make it compile and register it. This is the beginning of the v6 button. Remove the subclassing of the builtin button.

git-svn-id: file:///srv/svn/reactos/trunk@73871 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago* Revert r73869 because wmi was mentioned nowhere in CORE-9111, nor in our tree restr...
akhaldi [Tue, 21 Feb 2017 09:04:05 +0000 (09:04 +0000)]
* Revert r73869 because wmi was mentioned nowhere in CORE-9111, nor in our tree restructure wiki, nor any developers discussions. This is the ReactOS trunk, not a branch.

git-svn-id: file:///srv/svn/reactos/trunk@73870 97493ccd-5924-5043-b1f5-66cb403b36ce

24 hours ago[WMI]: Gather all the user-mode components of WMI inside base/wmi/, as part of the...
hbelusca [Mon, 20 Feb 2017 23:28:09 +0000 (23:28 +0000)]
[WMI]: Gather all the user-mode components of WMI inside base/wmi/, as part of the ReactOS source code tree restructure. This gives an idea how this can be done for other ReactOS components.

git-svn-id: file:///srv/svn/reactos/trunk@73869 97493ccd-5924-5043-b1f5-66cb403b36ce

25 hours ago[SECUR32]: As an interim step towards a proper NTLM implementation that is done by...
hbelusca [Mon, 20 Feb 2017 22:28:07 +0000 (22:28 +0000)]
[SECUR32]: As an interim step towards a proper NTLM implementation that is done by Samuel Serapion, I temporarily commit Wine's NTLM code layer around Samba's "ntlm_auth" utility. In addition I add the kerberos & negotiate stubs too.
This is not a problem on Wine, because they run on Linux distributions, most of which have Samba available. But this is not the case on Windows / ReactOS, so few adaptations were needed: in the dispatcher.c code, the fork_helper function was partially rewritten around CreateProcess to start the ntlm_auth utility (I try to use maximally the CRT to not have to rewrite other functions). This works great.
But then, to make this NTLM layer working on ReactOS, one has to find a Windows build of Samba. Here is one: . This is a Samba 3.0.23c build. You need to follow *exactly* the manual installation steps to make it work (actually, everything up to "Step 6" included, i.e. running smbsetup.cmd). This means in particular to copy Samba into C:\Program Files\samba, as this path is also hardcoded into the executables.
As the Wine's NTLM layer expects Samba 3.0.25+, I manually downgraded the expected version, which appears to still work nice for the needs of Office 2010 installation.

You can now play with it and try to install Office 2010.

CORE-12601 #comment Wine's NTLM layer committed in r73868 as an interim step towards a proper implementation.

git-svn-id: file:///srv/svn/reactos/trunk@73868 97493ccd-5924-5043-b1f5-66cb403b36ce

26 hours ago[MOFCOMP]: Add the MOF compiler stub from Wine, which allows fixing the very last...
hbelusca [Mon, 20 Feb 2017 20:47:42 +0000 (20:47 +0000)]
[MOFCOMP]: Add the MOF compiler stub from Wine, which allows fixing the very last step in the installation of Office 2010.
CORE-12811 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73867 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[SHLWAPI]: Stub SHPropertyBag_WriteLONG and SHPropertyBag_WriteStr. Patch by Jared...
gadamopoulos [Mon, 20 Feb 2017 20:18:10 +0000 (20:18 +0000)]
[SHLWAPI]: Stub SHPropertyBag_WriteLONG and SHPropertyBag_WriteStr. Patch by Jared Smudde. CORE-12805

git-svn-id: file:///srv/svn/reactos/trunk@73866 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[SHELL32] -Cleanup CFSFolder::_LoadDynamicDropTargetHandlerForKey. Inspired by patch...
gadamopoulos [Mon, 20 Feb 2017 20:13:22 +0000 (20:13 +0000)]
[SHELL32] -Cleanup CFSFolder::_LoadDynamicDropTargetHandlerForKey. Inspired by patch by Victor Martinez Calvo. CORE-12799. CID 1401249

git-svn-id: file:///srv/svn/reactos/trunk@73865 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[MSGINA] -Make ShellIsFriendlyUIActive export a non fatal stub. CORE-12805
gadamopoulos [Mon, 20 Feb 2017 19:51:12 +0000 (19:51 +0000)]
[MSGINA] -Make ShellIsFriendlyUIActive export a non fatal stub. CORE-12805

git-svn-id: file:///srv/svn/reactos/trunk@73864 97493ccd-5924-5043-b1f5-66cb403b36ce

28 hours ago[MSWSOCK]
tfaber [Mon, 20 Feb 2017 19:32:12 +0000 (19:32 +0000)]
- Eliminate dead code in NSP_LookupServiceNextW. Patch by Víctor Martínez Calvo. CID 1400942
CORE-12806 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73863 97493ccd-5924-5043-b1f5-66cb403b36ce

30 hours ago[USER32][UXTHEME]
tfaber [Mon, 20 Feb 2017 17:31:50 +0000 (17:31 +0000)]
- Make API hooks type-safe. Fixes stack pointer corruption when calling ThemeGetScrollInfo. Powered by /RTC1

git-svn-id: file:///srv/svn/reactos/trunk@73862 97493ccd-5924-5043-b1f5-66cb403b36ce

31 hours ago[WS2_32]
tfaber [Mon, 20 Feb 2017 16:33:44 +0000 (16:33 +0000)]
- Re-apply null termination fix in GetProtoGetNextEnt, which was lost in ws2_32_new work. CID 716700

git-svn-id: file:///srv/svn/reactos/trunk@73861 97493ccd-5924-5043-b1f5-66cb403b36ce

31 hours ago[BROWSEUI]
tfaber [Mon, 20 Feb 2017 16:07:05 +0000 (16:07 +0000)]
- Correctly pass the buffer size to RegQueryValueW in CAutoComplete::Init. Patch by Víctor Martínez Calvo. CID 1401255
CORE-12795 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73860 97493ccd-5924-5043-b1f5-66cb403b36ce

31 hours ago[FREELDR]: Update the FreeLdr's startup notes.
hbelusca [Mon, 20 Feb 2017 15:45:01 +0000 (15:45 +0000)]
[FREELDR]: Update the FreeLdr's startup notes.

git-svn-id: file:///srv/svn/reactos/trunk@73859 97493ccd-5924-5043-b1f5-66cb403b36ce

32 hours ago[EVENTLOG]
khornicek [Mon, 20 Feb 2017 14:45:03 +0000 (14:45 +0000)]
- Silence some debug prints. This commit bears the "Hermès' seal of approval".

git-svn-id: file:///srv/svn/reactos/trunk@73858 97493ccd-5924-5043-b1f5-66cb403b36ce

35 hours ago[WINPRINT]
tfaber [Mon, 20 Feb 2017 12:00:13 +0000 (12:00 +0000)]
- Avoid uninitialized hPrintMonitor in PrintRawJob failure case. Patch by Víctor Martínez Calvo
CORE-12792 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73857 97493ccd-5924-5043-b1f5-66cb403b36ce

36 hours ago[KS]
tfaber [Mon, 20 Feb 2017 11:35:24 +0000 (11:35 +0000)]
- Avoid leaking AllocatorFraming in KsCreateDefaultAllocatorEx. Patch by Sebastian Gasiorek
CORE-12797 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73856 97493ccd-5924-5043-b1f5-66cb403b36ce

37 hours ago[WIN32K]
khornicek [Mon, 20 Feb 2017 10:10:37 +0000 (10:10 +0000)]
- Don't try to delete the pattern bitmap in UserInitialize.
- Set the correct owner before deleting the update region in co_UserFreeWindow.
- Fixes some "Trying to delete global object" debug prints.

git-svn-id: file:///srv/svn/reactos/trunk@73855 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[blackshade.msstyles] -Add a skeleton for a theme based on a mockup by David Quintana
gadamopoulos [Sun, 19 Feb 2017 20:40:45 +0000 (20:40 +0000)]
[blackshade.msstyles] -Add a skeleton for a theme based on a mockup by David Quintana

git-svn-id: file:///srv/svn/reactos/trunk@73854 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[COMCTL32]
ekohl [Sun, 19 Feb 2017 20:39:11 +0000 (20:39 +0000)]
Update a tool buttons tooltip rectangle when the button gets hidden.
Patch will be sent upstream!
CORE-12667 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73853 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DEVMGR]
ekohl [Sun, 19 Feb 2017 19:40:04 +0000 (19:40 +0000)]
- NEVER EVER use single line if statements!!!!
- Fix indentation and coding style.

git-svn-id: file:///srv/svn/reactos/trunk@73852 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DEVMGR]
ekohl [Sun, 19 Feb 2017 19:13:41 +0000 (19:13 +0000)]
Hide "HTREE\ROOT\0" from the device tree.
CORE-12670 #resolve #comment Thanks a lot!

git-svn-id: file:///srv/svn/reactos/trunk@73851 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DEVMGR]
ekohl [Sun, 19 Feb 2017 18:31:52 +0000 (18:31 +0000)]
Select a treeview item on a right click.

git-svn-id: file:///srv/svn/reactos/trunk@73850 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[MSAFD][WS2_32]
tfaber [Sun, 19 Feb 2017 17:50:34 +0000 (17:50 +0000)]
- Properly return error codes from WSPConnect
CORE-12787 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73849 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[EVENTVWR]
pschweitzer [Sun, 19 Feb 2017 17:24:13 +0000 (17:24 +0000)]
Don't attempt to free random address

CID 1401231

git-svn-id: file:///srv/svn/reactos/trunk@73848 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[UXTHEME] Fix the conversion from color id to theme metric and don't pass the metric...
gadamopoulos [Sun, 19 Feb 2017 16:32:44 +0000 (16:32 +0000)]
[UXTHEME] Fix the conversion from color id to theme metric and don't pass the metric id to GetSysColor. CORE-11086

git-svn-id: file:///srv/svn/reactos/trunk@73847 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[ACPI]
ekohl [Sun, 19 Feb 2017 15:13:49 +0000 (15:13 +0000)]
Generate a proper device id string for processor devices.

git-svn-id: file:///srv/svn/reactos/trunk@73846 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SHELL32]
pschweitzer [Sun, 19 Feb 2017 13:22:02 +0000 (13:22 +0000)]
For the input string, WideCharToMultiByte takes a char count and not a buffer size.

CID 14010961401088

git-svn-id: file:///srv/svn/reactos/trunk@73845 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SHELL32]
pschweitzer [Sun, 19 Feb 2017 13:00:12 +0000 (13:00 +0000)]
Don't attempt to dereference a pointer after having freed it

CID 1401297

git-svn-id: file:///srv/svn/reactos/trunk@73844 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[WS2_32]
pschweitzer [Sun, 19 Feb 2017 12:52:14 +0000 (12:52 +0000)]
Remove duplicated if

CID 1400935

git-svn-id: file:///srv/svn/reactos/trunk@73843 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DNSAPI]
pschweitzer [Sun, 19 Feb 2017 12:42:08 +0000 (12:42 +0000)]
Properly check for domain name being set

CID 1401070

git-svn-id: file:///srv/svn/reactos/trunk@73842 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[WSHTCPIP]
tfaber [Sun, 19 Feb 2017 12:21:06 +0000 (12:21 +0000)]
- Fix incorrect sizeof in SHIoctl_GetInterfaceList. CID 1401188

git-svn-id: file:///srv/svn/reactos/trunk@73841 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[WS2_32]
tfaber [Sun, 19 Feb 2017 12:05:48 +0000 (12:05 +0000)]
- Fix ridiculous over-casting

git-svn-id: file:///srv/svn/reactos/trunk@73840 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[WS2_32]
tfaber [Sun, 19 Feb 2017 11:44:18 +0000 (11:44 +0000)]
- Fix wrong ServLength in getnameinfo, again, since it got lost in the ws2_32_new work. CID 716150

git-svn-id: file:///srv/svn/reactos/trunk@73839 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[UXTHEME] -Set cbSize field of WINDOWINFO before calling GetWindowInfo. CORE-12776
gadamopoulos [Sun, 19 Feb 2017 11:41:23 +0000 (11:41 +0000)]
[UXTHEME] -Set cbSize field of WINDOWINFO before calling GetWindowInfo. CORE-12776

git-svn-id: file:///srv/svn/reactos/trunk@73838 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DNSAPI]
pschweitzer [Sun, 19 Feb 2017 11:34:00 +0000 (11:34 +0000)]
Properly check for domain name being set

CID 1401080

git-svn-id: file:///srv/svn/reactos/trunk@73837 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[FASTFAT]
pschweitzer [Sun, 19 Feb 2017 11:22:21 +0000 (11:22 +0000)]
Avoid uninit variable usage.

CID 14012571401259

git-svn-id: file:///srv/svn/reactos/trunk@73836 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[LOCALMON]
tfaber [Sun, 19 Feb 2017 10:31:37 +0000 (10:31 +0000)]
- Avoid a potential double free in InitializePrintMonitor2. CID 1401299
- Avoid a use after free in LocalmonClosePort. CID 1401298

git-svn-id: file:///srv/svn/reactos/trunk@73835 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[UXTHEME] -The code to draw the classic style borders was copied from win32k, so...
gadamopoulos [Sun, 19 Feb 2017 10:23:26 +0000 (10:23 +0000)]
[UXTHEME] -The code to draw the classic style borders was copied from win32k, so imitate what it does and restore two bits that got removed in the copy. CORE-9667

git-svn-id: file:///srv/svn/reactos/trunk@73834 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SHELL32] -Try to fix themes when opening the control panel applet from the control...
gadamopoulos [Sun, 19 Feb 2017 09:10:03 +0000 (09:10 +0000)]
[SHELL32] -Try to fix themes when opening the control panel applet from the control panel.

git-svn-id: file:///srv/svn/reactos/trunk@73833 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek...
mjansen [Sat, 18 Feb 2017 22:54:31 +0000 (22:54 +0000)]
[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek. CID 1322124 CORE-12784 #resolve #comment Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@73832 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sat, 18 Feb 2017 21:37:56 +0000 (21:37 +0000)]
Get rid of the ENTRY_DELETED2, ENTRY_VOLUME2 and ENTRY_END2 macros.

git-svn-id: file:///srv/svn/reactos/trunk@73831 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sat, 18 Feb 2017 21:24:31 +0000 (21:24 +0000)]
Modify ReadVolumeLabel() so that it is able to read the volume label, even without using the VCB, the root FCB, Cc, the universe.
This is important, because in case of device verifying, you cannot rely on these elements anylonger, but you need to read the label.
A readme has been attached to the function, to indicate how to call it (I wish I could have put more asserts!). It's ugly, I know.

This allows fixing a FIXME in VfatVerify(): we can also check the volume label for FATX volumes.
The FIXME comment was misleading: MS FastFAT doesn't make any checksum or whatever of FAT root. Let's not do it.

git-svn-id: file:///srv/svn/reactos/trunk@73830 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sat, 18 Feb 2017 18:35:48 +0000 (18:35 +0000)]
Move ReadVolumeLabel() to fsctl.c close to functions that need it

git-svn-id: file:///srv/svn/reactos/trunk@73829 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case...
gadamopoulos [Sat, 18 Feb 2017 18:14:32 +0000 (18:14 +0000)]
[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case is that it is not a pointer and another case that it is a pointer to a struct. What I'm sure of is that as it is now the position of the string in the binary affects the behavior of ApplyTheme. Thankfully 0 works great on windows.

git-svn-id: file:///srv/svn/reactos/trunk@73828 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[KMTESTS:MM]
tfaber [Sat, 18 Feb 2017 14:22:44 +0000 (14:22 +0000)]
- Add some stricter checks and improved error handling in NtCreateSection_user

git-svn-id: file:///srv/svn/reactos/trunk@73827 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[USBSTOR]
tfaber [Sat, 18 Feb 2017 11:47:40 +0000 (11:47 +0000)]
- Fix a broken assert (yes, calling NTOHL is wrong, ContiguousLogicBlocksByte0 is the MSB). CID 701077

git-svn-id: file:///srv/svn/reactos/trunk@73826 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ...
mjansen [Sat, 18 Feb 2017 11:25:31 +0000 (11:25 +0000)]
[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ. CORE-6621

git-svn-id: file:///srv/svn/reactos/trunk@73825 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[PSDK]
tfaber [Sat, 18 Feb 2017 09:30:59 +0000 (09:30 +0000)]
- Fix KsFilterFactoryGetDevice

git-svn-id: file:///srv/svn/reactos/trunk@73824 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[SHELL32]
khornicek [Fri, 17 Feb 2017 23:39:39 +0000 (23:39 +0000)]
- Make the "Open with" dialog start in Program Files as is done in Windows (doesn't really changes anything because comdlg32 doesn't expand environment variables).

git-svn-id: file:///srv/svn/reactos/trunk@73823 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FASTFAT]
pschweitzer [Fri, 17 Feb 2017 22:25:03 +0000 (22:25 +0000)]
Generalize the usage of functions pointers for FatX vs Fat specific code (direntry).
This should also help speeding up FastFAT.

git-svn-id: file:///srv/svn/reactos/trunk@73822 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FASTFAT]
pschweitzer [Fri, 17 Feb 2017 21:24:12 +0000 (21:24 +0000)]
In the FCB, get rid of the FCB_IS_FATX_ENTRY flag. It makes no sense to have it on each and every file as the VCB already has such flag

git-svn-id: file:///srv/svn/reactos/trunk@73821 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FASTFAT]
pschweitzer [Fri, 17 Feb 2017 18:06:38 +0000 (18:06 +0000)]
Fix a typo brought in r73819

git-svn-id: file:///srv/svn/reactos/trunk@73820 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FASTFAT]
pschweitzer [Fri, 17 Feb 2017 17:58:18 +0000 (17:58 +0000)]
More FastFAT cleanup.
Except a light performances boost due to useless checks removal in read/write and to some functions inlining

More to follow...

git-svn-id: file:///srv/svn/reactos/trunk@73819 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[SHELL32] -Expand the name of the cpl file because CreateActCtx needs a full path.
gadamopoulos [Fri, 17 Feb 2017 17:23:17 +0000 (17:23 +0000)]
[SHELL32] -Expand the name of the cpl file because CreateActCtx needs a full path.

git-svn-id: file:///srv/svn/reactos/trunk@73818 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[DBGHELP] Add experimental rsym support. CORE-12773
mjansen [Fri, 17 Feb 2017 16:18:15 +0000 (16:18 +0000)]
[DBGHELP] Add experimental rsym support. CORE-12773

git-svn-id: file:///srv/svn/reactos/trunk@73817 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[DBGHELP_APITEST] Add tests for pdb and rsym parsing. CORE-12773
mjansen [Fri, 17 Feb 2017 16:15:49 +0000 (16:15 +0000)]
[DBGHELP_APITEST] Add tests for pdb and rsym parsing. CORE-12773

git-svn-id: file:///srv/svn/reactos/trunk@73816 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[SDK][KERNEL32] Add defines for PEB.AppCompatFlags CORE-12768 #resolve
mjansen [Fri, 17 Feb 2017 16:12:19 +0000 (16:12 +0000)]
[SDK][KERNEL32] Add defines for PEB.AppCompatFlags CORE-12768 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73815 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[LIBTIFF]
tfaber [Fri, 17 Feb 2017 13:58:26 +0000 (13:58 +0000)]
- Fix GCC non-PCH build

git-svn-id: file:///srv/svn/reactos/trunk@73814 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[LIBTIFF]
tfaber [Fri, 17 Feb 2017 13:43:05 +0000 (13:43 +0000)]
- Update to version 4.0.7
CORE-12775 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@73813 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[WIN32K]
khornicek [Fri, 17 Feb 2017 13:13:36 +0000 (13:13 +0000)]
- The pattern bitmap can get deleted during the GDI cleanup for process before the brush itself.
- Gets rid of some of those pesky "GreDeleteObject: Trying to delete invalid object" debug prints.

git-svn-id: file:///srv/svn/reactos/trunk@73812 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[LIBTIFF]
tfaber [Fri, 17 Feb 2017 13:05:50 +0000 (13:05 +0000)]
- Use the official libtiff 4.0.3 def file to determine exported functions (instead of exporting everything in GCC builds, nothing in MSVC builds)
- Remove unused ROS-diffs
CORE-6898 CORE-12275

git-svn-id: file:///srv/svn/reactos/trunk@73811 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[PING]
khornicek [Fri, 17 Feb 2017 12:30:14 +0000 (12:30 +0000)]
- Addendum to r73626. Convert the print specifiers too so that ping doesn't only output the old specifiers themselves.

git-svn-id: file:///srv/svn/reactos/trunk@73810 97493ccd-5924-5043-b1f5-66cb403b36ce

tfaber [Fri, 17 Feb 2017 12:17:20 +0000 (12:17 +0000)]
- Fix some MSVC-specific definitions

git-svn-id: file:///srv/svn/reactos/trunk@73809 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FASTFAT]
pschweitzer [Fri, 17 Feb 2017 11:38:05 +0000 (11:38 +0000)]

git-svn-id: file:///srv/svn/reactos/trunk@73808 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FASTFAT]
pschweitzer [Fri, 17 Feb 2017 11:08:38 +0000 (11:08 +0000)]
Fix a few ugly things.
Both Thomas & cppcheck should be happier now!

git-svn-id: file:///srv/svn/reactos/trunk@73807 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[WIN32k]
gadamopoulos [Fri, 17 Feb 2017 11:07:14 +0000 (11:07 +0000)]
 -Fix a couple of cases where we use the versioned class atom instead of the non versioned one.

- Add support for versioned classes in RegisterClassExWOWW, GetClassInfoExW, GetClassInfoExA, UnregisterClassA, UnregisterClassW, and User32CreateWindowEx
- Make ClassNameToVersion return the name of the versioned class and the library name that implements it while preserving a hack that lets user32 know which classes are registered by comctl32 (this is needed because the default activation context doesn't contain the non versioned classes yet).
- Make VersionRegisterClass to load the specified library and make it register its classes which is used when the class is not registered yet but its manifest is active.

git-svn-id: file:///srv/svn/reactos/trunk@73806 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[LIBJPEG]
tfaber [Fri, 17 Feb 2017 11:05:50 +0000 (11:05 +0000)]
- Update to version 9b

git-svn-id: file:///srv/svn/reactos/trunk@73805 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[LIBPNG]
tfaber [Fri, 17 Feb 2017 10:42:03 +0000 (10:42 +0000)]
- Update to version 1.6.28

git-svn-id: file:///srv/svn/reactos/trunk@73804 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[COMCTL32]
gadamopoulos [Fri, 17 Feb 2017 10:04:24 +0000 (10:04 +0000)]
- Add and install a manifest for comctl32 version 5.82.
- Since our comctl32 tries to imitate both version 5 and version 6, register its classes twice, once while having the version 6 manifest active and once when having the version 5 active.
- Register the themed versions of the built in controls while having the version 6 manifest active (and register them as global classes). This breaks theming of built in controls until versioned classes get implemented.
- Do not try to subclass the dialog class. This is incorrect and can lead to problems like in CORE-8534, CORE-12727, CORE-8387. This removes the background texture of the themed tabs which will be implemented in the future in uxtheme using api hooks.
This breaks a great deal of theming but keep in mind that it is in the middle of a transition to have them implemented correctly without the terrible side effects (broken ansi conversion, not always  using themes for built in controls. However comctl32 is now ready for versioned classes to be enabled.

git-svn-id: file:///srv/svn/reactos/trunk@73803 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[SPIDER]
khornicek [Wed, 15 Feb 2017 10:53:41 +0000 (10:53 +0000)]
- Make the formatting a bit more consistent.

- Remove an useless cast.

git-svn-id: file:///srv/svn/reactos/trunk@73802 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[BOOTLIB]: Fix assembly file containing Archx86TransferTo32BitApplicationAsm to use...
ion [Wed, 15 Feb 2017 00:53:15 +0000 (00:53 +0000)]
[BOOTLIB]: Fix assembly file containing Archx86TransferTo32BitApplicationAsm to use assume:nothing, otherwise we end up with SS segment overrides everywhere.
[BOOTLIB]: Correctly bias access to GDT/IDT registers by 2 bytes since this is a 48-bit instruction. The loaded GDT/IDT was previously invalid and causing random GPFs.
[BOOTLIB]: Fix EfiStall in protected mode. It was previously not stalling.
[BOOTLIB]: Fix calculation in MmMapPhysicalAddress
[BOOTLIB]: Fix missing goto in MmSelectMappingAddress which broke the function in real mode.
[BOOTLIB]: Fix incorrect ranges in MmSelectMappingAddress.
[BOOTLIB]: Fix incorrect offset calculation in MmSelectMappingAddress.
Now hitting (as expected), unimplemented virtual code path in BlMmMapPhysicalAddressEx.

git-svn-id: file:///srv/svn/reactos/trunk@73801 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[RUNDLL32] -Load and activate the manifest of the hosted dll before loading the library.
gadamopoulos [Tue, 14 Feb 2017 09:47:13 +0000 (09:47 +0000)]
[RUNDLL32] -Load and activate the manifest of the hosted dll before loading the library.

git-svn-id: file:///srv/svn/reactos/trunk@73799 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NEWDEV] -Use manifest_hosted.rc.
gadamopoulos [Tue, 14 Feb 2017 09:41:38 +0000 (09:41 +0000)]
[NEWDEV] -Use manifest_hosted.rc.

git-svn-id: file:///srv/svn/reactos/trunk@73798 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[BOOTLIB]: Clarify some attributes now that their meaning is clearer.
ion [Mon, 13 Feb 2017 23:47:06 +0000 (23:47 +0000)]
[BOOTLIB]: Clarify some attributes now that their meaning is clearer.
[BOOTLIB]: Implement MmSelectMappingAddress and fix its prototype.
[BOOTLIB]: Implement MmPapPageAllocatorExtend and fix MmPapAllocatePagesInRange to use it.
We are trying to choose VA 0 for PA 0x8000 and currently fail due to conflicts. TBD.

git-svn-id: file:///srv/svn/reactos/trunk@73797 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[UMPNPMGR]
ekohl [Mon, 13 Feb 2017 22:59:40 +0000 (22:59 +0000)]
PNP_GetDeviceList and PNP_GetDeviceListSize:
- Do not return CR_CALL_NOT_IMPLEMENTED by default.
- pulLength is counted in characters, not in bytes!
- Use the correct Relations value for PowerRelations.

Add the PowerRelations value to a comment.

CM_Get_Device_ID_List_Size_ExW and CM_Get_Device_ID_List_ExW count the buffer length in characters, not in bytes!

git-svn-id: file:///srv/svn/reactos/trunk@73796 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NTOSKRNL]
ekohl [Mon, 13 Feb 2017 22:38:11 +0000 (22:38 +0000)]
Implement IopGetDeviceRelations().

git-svn-id: file:///srv/svn/reactos/trunk@73795 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[SHELL32] -Call CPlApplet export of control panel applets with the correct activation...
gadamopoulos [Mon, 13 Feb 2017 22:09:14 +0000 (22:09 +0000)]
[SHELL32] -Call CPlApplet export of control panel applets with the correct activation context.

git-svn-id: file:///srv/svn/reactos/trunk@73794 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[FASTFAT]
pschweitzer [Mon, 13 Feb 2017 21:17:26 +0000 (21:17 +0000)]
In order to make VfatVerify() work on something else than floppies, ask for change count when issuing IOCTL_DISK_CHECK_VERIFY

git-svn-id: file:///srv/svn/reactos/trunk@73793 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[UXTHEME] -Move the global variables for the scrollbars into the WND_CONTEXT. Hook...
gadamopoulos [Mon, 13 Feb 2017 18:45:18 +0000 (18:45 +0000)]
[UXTHEME] -Move the global variables for the scrollbars into the WND_CONTEXT. Hook ThemeGetScrollInfo to set the correct tracking position as tracking is handled completely in uxtheme. Fixes scrolling while dragging the scrollbar thumb in the listview control.

git-svn-id: file:///srv/svn/reactos/trunk@73792 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[UXTHEME] -Remove an overzealous check that prevented the scrollbar from being repain...
gadamopoulos [Mon, 13 Feb 2017 17:31:14 +0000 (17:31 +0000)]
[UXTHEME] -Remove an overzealous check that prevented the scrollbar from being repainted when the cursor was moving in it.

git-svn-id: file:///srv/svn/reactos/trunk@73791 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[UXTHEME] -Fix the size of the thump in the themed scrollbar. CORE-7988
gadamopoulos [Mon, 13 Feb 2017 17:27:13 +0000 (17:27 +0000)]
[UXTHEME] -Fix the size of the thump in the themed scrollbar. CORE-7988

git-svn-id: file:///srv/svn/reactos/trunk@73790 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[COMCTL32] -Fix drawing the borders of themed controls. Patch by Sylvain Deverre...
gadamopoulos [Mon, 13 Feb 2017 15:08:47 +0000 (15:08 +0000)]
[COMCTL32] -Fix drawing the borders of themed controls. Patch by Sylvain Deverre. CORE-10761

git-svn-id: file:///srv/svn/reactos/trunk@73789 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[BROWSEUI] -Fix a couple of cases where the tree view can cause a crash.
gadamopoulos [Mon, 13 Feb 2017 15:04:03 +0000 (15:04 +0000)]
[BROWSEUI] -Fix a couple of cases where the tree view can cause a crash.

git-svn-id: file:///srv/svn/reactos/trunk@73788 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[USER32_APITEST]: Add a couple more tests for GetClassInfoExW.
gadamopoulos [Mon, 13 Feb 2017 09:58:06 +0000 (09:58 +0000)]
[USER32_APITEST]: Add a couple more tests for GetClassInfoExW.

git-svn-id: file:///srv/svn/reactos/trunk@73787 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[WIN32KNT_APITEST]: Make a test for NtUserGetClassInfo more strict to test its exact...
gadamopoulos [Mon, 13 Feb 2017 09:56:35 +0000 (09:56 +0000)]
[WIN32KNT_APITEST]: Make a test for NtUserGetClassInfo more strict to test its exact return value.

git-svn-id: file:///srv/svn/reactos/trunk@73786 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[WIN32K:NTUSER]
tfaber [Sun, 12 Feb 2017 23:09:35 +0000 (23:09 +0000)]
- Kill a noisy debug print

git-svn-id: file:///srv/svn/reactos/trunk@73785 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[FASTFAT]
pschweitzer [Sun, 12 Feb 2017 19:31:31 +0000 (19:31 +0000)]
Don't attempt to verify volume if it was already verified in between

git-svn-id: file:///srv/svn/reactos/trunk@73784 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[WIN32KNT_APITEST]: -Make sure that NtUserUnregisterClass works when it gets the...
gadamopoulos [Sun, 12 Feb 2017 12:11:18 +0000 (12:11 +0000)]
[WIN32KNT_APITEST]: -Make sure that NtUserUnregisterClass works when it gets the versioned class name. Show that NtUserFindWindowEx needs the non versioned class name.

git-svn-id: file:///srv/svn/reactos/trunk@73783 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[SMSS]
pschweitzer [Sun, 12 Feb 2017 08:49:53 +0000 (08:49 +0000)]
Remove useless nullptr check

git-svn-id: file:///srv/svn/reactos/trunk@73782 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[SERVMAN]
pschweitzer [Sun, 12 Feb 2017 08:42:03 +0000 (08:42 +0000)]
Remove duplicated condition

git-svn-id: file:///srv/svn/reactos/trunk@73781 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[FASTFAT]
pschweitzer [Sun, 12 Feb 2017 08:25:42 +0000 (08:25 +0000)]
Remove useless assignement

git-svn-id: file:///srv/svn/reactos/trunk@73780 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[IP]
tfaber [Sat, 11 Feb 2017 23:13:45 +0000 (23:13 +0000)]
- Handle chained pbuf structures in TCPSendDataCallback

git-svn-id: file:///srv/svn/reactos/trunk@73779 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[FASTFAT]
pschweitzer [Sat, 11 Feb 2017 20:26:33 +0000 (20:26 +0000)]
In case of an error while trying to verify the volume, only return STATUS_WRONG_VOLUME is raw mounts are allowed

git-svn-id: file:///srv/svn/reactos/trunk@73778 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[FASTFAT]
pschweitzer [Sat, 11 Feb 2017 18:33:47 +0000 (18:33 +0000)]
Remove useless assignement

git-svn-id: file:///srv/svn/reactos/trunk@73777 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[REGEDIT]
khornicek [Sat, 11 Feb 2017 16:02:49 +0000 (16:02 +0000)]
- Fix a possible null pointer dereference. CID 731448
- Check string length before copying into a fixed size buffer. CID 515207
- Bail out of _CmdWndProc if keyPath is null. CID 1102164
- Use strsafe functions. CID 1102477

git-svn-id: file:///srv/svn/reactos/trunk@73776 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[CRT]
tfaber [Sat, 11 Feb 2017 15:55:56 +0000 (15:55 +0000)]
- Add missing _sgdt declaration in intrin.h

git-svn-id: file:///srv/svn/reactos/trunk@73775 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[IP]
tfaber [Sat, 11 Feb 2017 13:36:05 +0000 (13:36 +0000)]
- Apparently MIN_TRACE isn't enough to get printed...

git-svn-id: file:///srv/svn/reactos/trunk@73774 97493ccd-5924-5043-b1f5-66cb403b36ce