40 min ago[NTOS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114 master trunk
akhaldi [Sun, 4 Oct 2015 11:54:25 +0000 (11:54 +0000)]
[NTOS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

git-svn-id: file:///srv/svn/reactos/trunk@69439 97493ccd-5924-5043-b1f5-66cb403b36ce

45 min ago[NTVDM] Revert r69435.
akhaldi [Sun, 4 Oct 2015 11:49:28 +0000 (11:49 +0000)]
[NTVDM] Revert r69435.

git-svn-id: file:///srv/svn/reactos/trunk@69438 97493ccd-5924-5043-b1f5-66cb403b36ce

13 hours agoFix 0x%lu specifier in our skeleton service and its only user tcpsvcs.
spetreolle [Sat, 3 Oct 2015 22:38:05 +0000 (22:38 +0000)]
Fix 0x%lu specifier in our skeleton service and its only user tcpsvcs.

git-svn-id: file:///srv/svn/reactos/trunk@69437 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[ROSTESTS]
spetreolle [Sat, 3 Oct 2015 22:21:19 +0000 (22:21 +0000)]
Fix 0x%lu specifier.
Add cmake file for notificationtest.

git-svn-id: file:///srv/svn/reactos/trunk@69436 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[NTVDM] Improve the PCH situation.
akhaldi [Sat, 3 Oct 2015 21:47:46 +0000 (21:47 +0000)]
[NTVDM] Improve the PCH situation.

git-svn-id: file:///srv/svn/reactos/trunk@69435 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[user32_apitest]
spetreolle [Sat, 3 Oct 2015 21:41:10 +0000 (21:41 +0000)]
0x%lu does not mean anything correct.

git-svn-id: file:///srv/svn/reactos/trunk@69434 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[NTVDM] Fix PCH w.r.t. using the debug routines. The PCH use here in itself could...
akhaldi [Sat, 3 Oct 2015 19:17:55 +0000 (19:17 +0000)]
[NTVDM] Fix PCH w.r.t. using the debug routines. The PCH use here in itself could use *a lot* of improvements but that's another story.

git-svn-id: file:///srv/svn/reactos/trunk@69433 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[NTVDM]
hbelusca [Sat, 3 Oct 2015 18:57:06 +0000 (18:57 +0000)]
- French translation fix.
- Add PCH support.
- Properly track RC files dependencies. CORE-9806

git-svn-id: file:///srv/svn/reactos/trunk@69432 97493ccd-5924-5043-b1f5-66cb403b36ce

21 hours ago[NTVDM]
hbelusca [Sat, 3 Oct 2015 15:06:24 +0000 (15:06 +0000)]
Usability fixes (part 2):
- Properly keep the mouse show state across screenbuffer switches.
- Use unicode strings for the disk menu items.
See r69428.

git-svn-id: file:///srv/svn/reactos/trunk@69431 97493ccd-5924-5043-b1f5-66cb403b36ce

23 hours ago[WIN32SS:GDI]
hbelusca [Sat, 3 Oct 2015 13:30:15 +0000 (13:30 +0000)]
Convert COLOR16 values to byte range before calling XLATEOBJ_iXlate.
This fixes gradient colors in some applications, as for example in Code::Blocks.
Patch by Vort. This is a fix for code written in revision r8117, so old !!
CORE-8652 #comment Committed in r69430, thanks guys!

git-svn-id: file:///srv/svn/reactos/trunk@69430 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[RAPPS] Fix SSL certificate pinning, allow HTTPS links, add URL args support, some...
akhaldi [Sat, 3 Oct 2015 08:39:05 +0000 (08:39 +0000)]
[RAPPS] Fix SSL certificate pinning, allow HTTPS links, add URL args support, some UX fixes, comment improvements and fix stopping the download process when pressing cancel. By Ismael Ferreras Morezuelas. CORE-9060 CORE-10289

git-svn-id: file:///srv/svn/reactos/trunk@69429 97493ccd-5924-5043-b1f5-66cb403b36ce

33 hours ago[NTVDM]
hbelusca [Sat, 3 Oct 2015 02:36:35 +0000 (02:36 +0000)]
Usability fixes:
- Update the menu each time the user chooses to show or hide the mouse pointer.
- Keep the mouse show state across screenbuffer switches (text/graphics) (half-hackish at the moment; will be elegantly fixed later on).
- Update the floppy disk menu items each time the user mounts / ejects a disk; display the disk image file name currently mounted (CHAR strings used at the moment, WCHAR conversion will follow soon).

git-svn-id: file:///srv/svn/reactos/trunk@69428 97493ccd-5924-5043-b1f5-66cb403b36ce

45 hours ago[FAST486]
aandrejevic [Fri, 2 Oct 2015 15:11:24 +0000 (15:11 +0000)]
Reading/writing to memory should #SS(0) when the segment is the stack segment,
and #GP(0) otherwise. It should never generate #NP.

git-svn-id: file:///srv/svn/reactos/trunk@69427 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[INCLUDES] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE...
akhaldi [Thu, 1 Oct 2015 18:12:45 +0000 (18:12 +0000)]
[INCLUDES] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

git-svn-id: file:///srv/svn/reactos/trunk@69426 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[RAPPS] Get rid of the flickering of the URL in the download dialog and decode it...
akhaldi [Thu, 1 Oct 2015 09:37:55 +0000 (09:37 +0000)]
[RAPPS] Get rid of the flickering of the URL in the download dialog and decode it. By Ismael Ferreras Morezuelas. CORE-9060

git-svn-id: file:///srv/svn/reactos/trunk@69425 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FAST486]
aandrejevic [Thu, 1 Oct 2015 02:24:17 +0000 (02:24 +0000)]
Fix the TSS limit validity check.
Implement I/O privilege checking.

git-svn-id: file:///srv/svn/reactos/trunk@69424 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]: Fix the open-file dialog filter.
hbelusca [Thu, 1 Oct 2015 02:03:31 +0000 (02:03 +0000)]
[NTVDM]: Fix the open-file dialog filter.

git-svn-id: file:///srv/svn/reactos/trunk@69423 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]
hbelusca [Thu, 1 Oct 2015 00:37:38 +0000 (00:37 +0000)]
- Temporarily hack the boot sequence to floppy, then hard disk. See r69421; will be improved in the future.
- Complete the BIOS 16-bit bootstrap code.

git-svn-id: file:///srv/svn/reactos/trunk@69422 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]
hbelusca [Thu, 1 Oct 2015 00:09:24 +0000 (00:09 +0000)]
- Add a basic boot sequence functionality (read from CMOS); will be improved in the future.
- Print a "FATAL BOOT FAILURE" error message when INT 18h is called.
- Fail startup if we cannot mount the available hard disk images.
- Improve some diagnostic error messages.

git-svn-id: file:///srv/svn/reactos/trunk@69421 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FAST486]
aandrejevic [Wed, 30 Sep 2015 21:08:31 +0000 (21:08 +0000)]
- Don't forget to push the error code when the exception handler is a task gate.
- Use SS0/ESP0, SS1/ESP1, or SS2/ESP2 for ring 0/1/2 code task CALLs.

git-svn-id: file:///srv/svn/reactos/trunk@69420 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[DEVMGR]
gedmurphy [Wed, 30 Sep 2015 19:55:52 +0000 (19:55 +0000)]
Add typedef for CStringAtlW. Fixes msvc build

git-svn-id: file:///srv/svn/reactos/trunk@69419 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[CDROM]
pschweitzer [Wed, 30 Sep 2015 16:29:07 +0000 (16:29 +0000)]

CORE-10287 #resolve #comment Fixed with r69418

git-svn-id: file:///srv/svn/reactos/trunk@69418 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[KMTESTS:IO]
pschweitzer [Tue, 29 Sep 2015 18:43:35 +0000 (18:43 +0000)]
Simplify kernel mode thread creation

git-svn-id: file:///srv/svn/reactos/trunk@69417 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days agoRemove legacy _KeNumberProcessors hack. While we are at it fix its type (CCHAR not...
sginsberg [Tue, 29 Sep 2015 18:34:33 +0000 (18:34 +0000)]
Remove legacy _KeNumberProcessors hack. While we are at it fix its type (CCHAR not UCHAR) and remove it from the NDK as it is a public global provided by the DDK (where we properly define it with the "__CREATE_NTOS_DATA_IMPORT_ALIAS" fix when needed. Also, the variable KeActiveProcessors is not even exported from NTOS so move it to an internal header. Fix missed fix in UDFS as well in uncompiled file.

git-svn-id: file:///srv/svn/reactos/trunk@69416 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[MOUNTMGR]
pschweitzer [Tue, 29 Sep 2015 18:22:38 +0000 (18:22 +0000)]
Remove last hack

git-svn-id: file:///srv/svn/reactos/trunk@69415 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[MOUNTMGR]
pschweitzer [Tue, 29 Sep 2015 17:30:54 +0000 (17:30 +0000)]
Get rid of a hack, thanks to r69413

git-svn-id: file:///srv/svn/reactos/trunk@69414 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CRT]
tfaber [Tue, 29 Sep 2015 17:24:48 +0000 (17:24 +0000)]
- Add "memcmp" library that is used by kernel drivers to get memcmp/RtlEqualMemory
CORE-10285 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@69413 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTOSKRNL]
pschweitzer [Tue, 29 Sep 2015 16:28:59 +0000 (16:28 +0000)]
Don't bugcheck on unimplemented FsRtlOplockFsctrl(), FsRtlCurrentBatchOplock(), FsRtlCheckOplock()
Properly implement FsRtlInitializeOplock() (which is no-op on Windows 2k3)

CORE-10284 #resolve #comment Resolved with r69412

git-svn-id: file:///srv/svn/reactos/trunk@69412 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTVDM]
hbelusca [Mon, 28 Sep 2015 22:15:06 +0000 (22:15 +0000)]
- Add floppy image automount support from the registry, as it was done for HDDs in r69390 (it's really copy-paste & adaptation of the existing code).
- Increase HDD number support from 1 to 4 (maximum) for INT 13h.

git-svn-id: file:///srv/svn/reactos/trunk@69411 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[CDROM]
pschweitzer [Mon, 28 Sep 2015 21:06:02 +0000 (21:06 +0000)]

git-svn-id: file:///srv/svn/reactos/trunk@69410 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[CDROM]
pschweitzer [Mon, 28 Sep 2015 20:20:46 +0000 (20:20 +0000)]

git-svn-id: file:///srv/svn/reactos/trunk@69409 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTVDM]
aandrejevic [Mon, 28 Sep 2015 18:55:26 +0000 (18:55 +0000)]
Fix a division-by-zero problem by storing the mouse driver's Width and Height
in DWORDs, thus avoiding the integer overflow which could make them zero.

git-svn-id: file:///srv/svn/reactos/trunk@69408 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[FAST486]
aandrejevic [Mon, 28 Sep 2015 18:51:48 +0000 (18:51 +0000)]
- Always use the descriptor type, and never the limit, to identify
legacy vs. modern TSSes.
- Don't forget to write back the modified TSS link.

git-svn-id: file:///srv/svn/reactos/trunk@69407 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[CDROM]
pschweitzer [Mon, 28 Sep 2015 17:55:48 +0000 (17:55 +0000)]

Dedicated to Peter Hater

git-svn-id: file:///srv/svn/reactos/trunk@69406 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[TOOLS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE...
akhaldi [Mon, 28 Sep 2015 17:31:37 +0000 (17:31 +0000)]
[TOOLS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

git-svn-id: file:///srv/svn/reactos/trunk@69405 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[RAPPS]
dreimer [Mon, 28 Sep 2015 16:16:37 +0000 (16:16 +0000)]
Update German translation.

git-svn-id: file:///srv/svn/reactos/trunk@69404 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[SHELL32]
gadamopoulos [Mon, 28 Sep 2015 16:04:34 +0000 (16:04 +0000)]
- Actually use the localized name for Control Panel.

git-svn-id: file:///srv/svn/reactos/trunk@69403 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[RAPPS]
pschweitzer [Mon, 28 Sep 2015 15:29:41 +0000 (15:29 +0000)]
Update French translation

git-svn-id: file:///srv/svn/reactos/trunk@69402 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[RAPPS]
cwittich [Mon, 28 Sep 2015 14:09:09 +0000 (14:09 +0000)]
add support for SSL certificate pinning

git-svn-id: file:///srv/svn/reactos/trunk@69401 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTOS] Implement the KD Get/SetContextEx functionality (copying part of a CONTEXT...
sginsberg [Mon, 28 Sep 2015 14:08:54 +0000 (14:08 +0000)]
[NTOS] Implement the KD Get/SetContextEx functionality (copying part of a CONTEXT via Offset + Byte Count instead of copying a whole context), and stub out KdpWriteCustomBreakpoint. Newer WinDbg uses the GetContextEx functionality regardless of whether we report it as supported or not, and didn't seem to fall back on the regular GetContext functionality when it was missing, so whatever it was using it for should work awesome now. This had no impact on the broken Registers window though. Also small fix to use the _M_XXX checks consistently.

git-svn-id: file:///srv/svn/reactos/trunk@69400 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTOS] Fix kmtest
sginsberg [Mon, 28 Sep 2015 12:48:14 +0000 (12:48 +0000)]
[NTOS] Fix kmtest

git-svn-id: file:///srv/svn/reactos/trunk@69399 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[KMTESTS:OB]
pschweitzer [Mon, 28 Sep 2015 12:25:38 +0000 (12:25 +0000)]
Add a test dedicated to Stefan.

git-svn-id: file:///srv/svn/reactos/trunk@69398 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[MBEDTLS] Add a resource file for the dll. By Ismael Ferreras Morezuelas with minor...
akhaldi [Mon, 28 Sep 2015 12:09:26 +0000 (12:09 +0000)]
[MBEDTLS] Add a resource file for the dll. By Ismael Ferreras Morezuelas with minor changes by me. CORE-9065

git-svn-id: file:///srv/svn/reactos/trunk@69397 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[RAPPS]
pschweitzer [Mon, 28 Sep 2015 11:50:58 +0000 (11:50 +0000)]
Thanks to r69394, switch rapps database download to https

git-svn-id: file:///srv/svn/reactos/trunk@69396 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[GNUTLS] Get rid of what's left of the GnuTLS back-end. CORE-9065
akhaldi [Mon, 28 Sep 2015 11:23:36 +0000 (11:23 +0000)]
[GNUTLS] Get rid of what's left of the GnuTLS back-end. CORE-9065

git-svn-id: file:///srv/svn/reactos/trunk@69395 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[MBEDTLS] Use mbedtls as a lightweight schannel TLS/SSL back-end. This is an initial...
akhaldi [Mon, 28 Sep 2015 09:43:08 +0000 (09:43 +0000)]
[MBEDTLS] Use mbedtls as a lightweight schannel TLS/SSL back-end. This is an initial checkpoint and more will follow in due time. Brought to you by Peter Hater, Ismael Ferreras Morezuelas, Sebastian Lackner and Michael Müller. CORE-9065

git-svn-id: file:///srv/svn/reactos/trunk@69394 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTOS] Fix the Ob wait system calls to only catch the exceptions that are expected...
sginsberg [Mon, 28 Sep 2015 09:01:11 +0000 (09:01 +0000)]
[NTOS] Fix the Ob wait system calls to only catch the exceptions that are expected to be raised by the Ke wait functions (and not potentially silently catching *any* exception and corrupting everything in the process). Also fixup some code logic. SEH Mega Fixup 1/???

git-svn-id: file:///srv/svn/reactos/trunk@69393 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTDLL_APITEST]
pschweitzer [Mon, 28 Sep 2015 08:53:31 +0000 (08:53 +0000)]
*.S expects length in chars

git-svn-id: file:///srv/svn/reactos/trunk@69392 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTOS] Make SE routines use ExAllocateLocallyUniqueId instead of the system call...
sginsberg [Mon, 28 Sep 2015 07:44:49 +0000 (07:44 +0000)]
[NTOS] Make SE routines use ExAllocateLocallyUniqueId instead of the system call variant (SeCreateAccessStateEx already did this, but with Exp*). Also, Ex(p)AllocateLocallyUniqueId can't fail so there is no need to return success all the time (and check for it...). This also just happens to move the first system call to phase 1 instead of 0.

git-svn-id: file:///srv/svn/reactos/trunk@69391 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTVDM]
hbelusca [Mon, 28 Sep 2015 01:36:31 +0000 (01:36 +0000)]
Read global settings from the register (in HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\NTVDM ; note that this is a ReactOS-only configuration key, because no equivalent functionality exists on windows), and currently initialize:
- the BIOS and ROM files to be used;
- the hard disks to be mounted at startup (they cannot be unmounted at runtime, contrary to the floppies) (maximum 4 hard disks).

git-svn-id: file:///srv/svn/reactos/trunk@69390 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[RTL]
pschweitzer [Sun, 27 Sep 2015 20:54:20 +0000 (20:54 +0000)]
Major bugfixing session for RtlGenerate8dot3Name()... Up to know, AllowExtendedCharacters was totally ignored and any upcased char, as long as it was not in the forbidden list was accepted. This was bringing numerous problems (cf: apitest :-)).

So, now, the following fixes were brought:
- AllowExtendedCharacters isn't ignored any longer. If it's given, the unicode char is upcased, if it's not, as previously, the ansi char is upcased
- Be more strict in the allowed chars in name: only allow "graph" chars. This avoids generating broken names that aren't allowed in FAT
- In case no char could be added in the name, then, for the generation of the name checksum and use it as shortname
- When writing the checksum, don't use reversed order, but direct order, to match Windows behavior (as exposed with tests)
- When writing the checksum, use when possible bit operations instead of numerical operations for performances reasons (NFC)
- Rewrite RtlpGetCheckSum() with an algorithm that produces the exact same checksums than Windows 2003.

This whole commit fixes all apitests related (direct visible effect). As a bonus, it also fixes short names generation in FAT: we no longer produce broken volumes with international file names.
This also fixes less visible issues: we were producing unicode strings with null char in their middle (as exposed in tests), not sure about how all functions could handle this: likely not that good, this could have lead to various memory issues & corruptions.

CORE-10223 #resolve #comment Fixed with r69389

git-svn-id: file:///srv/svn/reactos/trunk@69389 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTDLL_APITEST]
pschweitzer [Sun, 27 Sep 2015 20:41:14 +0000 (20:41 +0000)]
Add more tests for RtlGenerate8dot3Name().
Not sure how many more are failing in ReactOS: they all pass in my WC (teasing :-))


git-svn-id: file:///srv/svn/reactos/trunk@69388 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[SHELLEXTS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE...
akhaldi [Sun, 27 Sep 2015 18:40:24 +0000 (18:40 +0000)]
[SHELLEXTS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

git-svn-id: file:///srv/svn/reactos/trunk@69387 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[SHELLEXTS] Properly track resource file dependencies. CORE-9806
akhaldi [Sun, 27 Sep 2015 18:37:23 +0000 (18:37 +0000)]
[SHELLEXTS] Properly track resource file dependencies. CORE-9806

git-svn-id: file:///srv/svn/reactos/trunk@69386 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[CPLS] Properly track resource file dependencies. CORE-9806
akhaldi [Sun, 27 Sep 2015 18:30:39 +0000 (18:30 +0000)]
[CPLS] Properly track resource file dependencies. CORE-9806

git-svn-id: file:///srv/svn/reactos/trunk@69385 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[MMDEVAPI_WINETEST] Add missing dxsdk dependency.
akhaldi [Sun, 27 Sep 2015 18:25:34 +0000 (18:25 +0000)]
[MMDEVAPI_WINETEST] Add missing dxsdk dependency.

git-svn-id: file:///srv/svn/reactos/trunk@69384 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTOS:EX]
tfaber [Sun, 27 Sep 2015 17:40:23 +0000 (17:40 +0000)]
- Remove push lock asserts that are prone to race conditions
CORE-10267 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@69383 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTVDM]: Update the read/write flag of the mounted image: fixes errors when trying...
hbelusca [Sun, 27 Sep 2015 17:39:29 +0000 (17:39 +0000)]
[NTVDM]: Update the read/write flag of the mounted image: fixes errors when trying to write to the read-only image. Now we correctly return a "write-protected" disk error.

git-svn-id: file:///srv/svn/reactos/trunk@69382 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[WINMINE] Improve the mine bitmap. By Jared Smudde. CORE-10251
rnaumann [Sun, 27 Sep 2015 17:35:54 +0000 (17:35 +0000)]
[WINMINE] Improve the mine bitmap. By Jared Smudde. CORE-10251

git-svn-id: file:///srv/svn/reactos/trunk@69381 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[SHELL32]Update some toolbar button bitmaps. By Jared Smudde. CORE-10232
rnaumann [Sun, 27 Sep 2015 17:15:09 +0000 (17:15 +0000)]
[SHELL32]Update some toolbar button bitmaps. By Jared Smudde. CORE-10232

git-svn-id: file:///srv/svn/reactos/trunk@69380 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[ICONS]Massive icon improvements by Jared Smudde. CORE-10023
rnaumann [Sun, 27 Sep 2015 16:59:28 +0000 (16:59 +0000)]
[ICONS]Massive icon improvements by Jared Smudde. CORE-10023

git-svn-id: file:///srv/svn/reactos/trunk@69379 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTVDM] Update German translation
rnaumann [Sun, 27 Sep 2015 16:28:27 +0000 (16:28 +0000)]
[NTVDM] Update German translation

git-svn-id: file:///srv/svn/reactos/trunk@69378 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[KERNEL32]: Use the _ARRAYSIZE macro in the ENV_NAME_ENTRY macro, for the same reason...
hbelusca [Sun, 27 Sep 2015 16:16:26 +0000 (16:16 +0000)]
[KERNEL32]: Use the _ARRAYSIZE macro in the ENV_NAME_ENTRY macro, for the same reasons mentioned in r69376.

git-svn-id: file:///srv/svn/reactos/trunk@69377 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTVDM]: Fix GCC build by using _ARRAYSIZE (which is the old-school sizeof(foo)/sizeo...
hbelusca [Sun, 27 Sep 2015 16:12:45 +0000 (16:12 +0000)]
[NTVDM]: Fix GCC build by using _ARRAYSIZE (which is the old-school sizeof(foo)/sizeof(foo[0]) macro) instead of ARRAYSIZE (which does the same but in a more complicated way, which involves a construct that cannot be embedded inside definitions of variables).

git-svn-id: file:///srv/svn/reactos/trunk@69376 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTVDM]
hbelusca [Sun, 27 Sep 2015 15:24:26 +0000 (15:24 +0000)]
- Start implementing a user menu for mounting/unmounting floppy disks at runtime. Menu state refresh & proper localization remain to be done.
- Add a temporary "Sleep(INFINITE)" where the VdmShutdown function is susceptible to trigger again a VDM cleanup in case it was called again in parallel. For diagnosing CORE-10182, see also r69366.

git-svn-id: file:///srv/svn/reactos/trunk@69375 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[SHELL32]
gadamopoulos [Sun, 27 Sep 2015 15:09:28 +0000 (15:09 +0000)]
- Fix for drive free/total space in My Computer. Patch by Barrett Karish.

git-svn-id: file:///srv/svn/reactos/trunk@69374 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[SHELL32]
gadamopoulos [Sun, 27 Sep 2015 14:27:09 +0000 (14:27 +0000)]
- Don't duplicate the code for getting the name of a drive. CDrivesFolder already does  it (and it does it better). Make the drive properties call it to get the name it needs.

git-svn-id: file:///srv/svn/reactos/trunk@69373 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[DIRECTX] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE...
akhaldi [Sun, 27 Sep 2015 14:00:29 +0000 (14:00 +0000)]
[DIRECTX] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

git-svn-id: file:///srv/svn/reactos/trunk@69372 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days agoFix gcc build
gadamopoulos [Sun, 27 Sep 2015 11:47:08 +0000 (11:47 +0000)]
Fix gcc build

git-svn-id: file:///srv/svn/reactos/trunk@69371 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[SHELL32]
gadamopoulos [Sun, 27 Sep 2015 11:31:52 +0000 (11:31 +0000)]
- Improve a change from r27016. Running the control panel applets in the context of explorer is not correct. We should really use ShellExecute here.

git-svn-id: file:///srv/svn/reactos/trunk@69370 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[SHELL32]
gadamopoulos [Sun, 27 Sep 2015 10:52:10 +0000 (10:52 +0000)]
- Fix SH_ParseGuidDisplayName which was completely broken when I committed it.
- Use GUIDFromStringW instead of SHCLSIDFromStringW in _ILCreateGuidFromStrW. The latter needs the string to terminate right after the guid.

git-svn-id: file:///srv/svn/reactos/trunk@69369 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days agoForgot to commit this file.
aandrejevic [Sat, 26 Sep 2015 19:23:59 +0000 (19:23 +0000)]
Forgot to commit this file.

git-svn-id: file:///srv/svn/reactos/trunk@69368 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[FAST486]
aandrejevic [Sat, 26 Sep 2015 19:22:50 +0000 (19:22 +0000)]
Whether a TSS is 16-bit or 32-bit depends solely on its signature.
Its size is irrelevant.

git-svn-id: file:///srv/svn/reactos/trunk@69367 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTVDM]
hbelusca [Sat, 26 Sep 2015 17:46:07 +0000 (17:46 +0000)]
Add a DPRINT to diagnose CORE-10182

git-svn-id: file:///srv/svn/reactos/trunk@69366 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTVDM]
hbelusca [Sat, 26 Sep 2015 17:35:31 +0000 (17:35 +0000)]
Add basic disk support with mounting/unmounting images in NTVDM:
- basic disk controller (at the moment this is just a collection of helper functions. A real HW emulation will come later on).
- INT 13h services for the BIOS.
At the moment, the images to be mounted are hardcoded in disk.c. Please see disk.c for examples of how to use the function. This will be reworked to allow user choice without having to recompile NTVDM.
CORE-10262 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@69365 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[BOOT] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114
akhaldi [Sat, 26 Sep 2015 16:31:49 +0000 (16:31 +0000)]
[BOOT] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

git-svn-id: file:///srv/svn/reactos/trunk@69364 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[COMCTL32] Mark a ros-diff with its tracking ticket: CORE-4912
akhaldi [Sat, 26 Sep 2015 16:30:49 +0000 (16:30 +0000)]
[COMCTL32] Mark a ros-diff with its tracking ticket: CORE-4912

git-svn-id: file:///srv/svn/reactos/trunk@69363 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[KE]
sginsberg [Sat, 26 Sep 2015 10:12:53 +0000 (10:12 +0000)]
Misc trap/interrupt fixes:
- Stub legacy KiGetTickCountHandler (INT 2A) to fail instead of breakpointing. We have made it so far without it, and if someone finds something that actually uses this instead of Win32's GetTickCount we can add it then. Raises the bar of making ReactOS breakpoint from 2 bytes to 4.
- Bugcheck with the right status code in case Kei386EoiHelper is called (which means you are trying to load a Windows HAL which we totally do not support right now).
- Use Ke* instead of Kf* in C code for IRQL routines.

git-svn-id: file:///srv/svn/reactos/trunk@69362 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NTVDM]
hbelusca [Sat, 26 Sep 2015 03:24:55 +0000 (03:24 +0000)]
- Don't hardcode magic values of characters if they have C escape codes.
- Print an extra newline on call to the Ctrl-C handler, as it is done on real DOS.
- Use a do{}while loop which loops while we don't have read a CR character.

git-svn-id: file:///srv/svn/reactos/trunk@69361 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NTVDM]
aandrejevic [Sat, 26 Sep 2015 02:51:37 +0000 (02:51 +0000)]
DosReadFile echoes the line feed when it encounters it.
A backspace should delete the '^' sign for special characters.

git-svn-id: file:///srv/svn/reactos/trunk@69360 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NTVDM]
aandrejevic [Sat, 26 Sep 2015 00:05:10 +0000 (00:05 +0000)]
Fix INT 21h/0Ah.
DosReadCharacter shouldn't echo all the time.

git-svn-id: file:///srv/svn/reactos/trunk@69359 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NTVDM]
hbelusca [Fri, 25 Sep 2015 22:42:08 +0000 (22:42 +0000)]
- Fix a comment.
- Do not hardcode buffer size.

git-svn-id: file:///srv/svn/reactos/trunk@69358 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NTVDM]
aandrejevic [Fri, 25 Sep 2015 22:09:37 +0000 (22:09 +0000)]
Don't echo when STDIN isn't the CON device.

git-svn-id: file:///srv/svn/reactos/trunk@69357 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NTVDM]
aandrejevic [Fri, 25 Sep 2015 22:00:57 +0000 (22:00 +0000)]
Fix DOS character device I/O. Implement CON line buffering.
Make sure INT 21h functions 01h, 06h, 07h, 08h, 0Ah and 3Fh work as expected
for CON input.

git-svn-id: file:///srv/svn/reactos/trunk@69356 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[KDBG] Let's try to have one single version of DPFLTR_DEFAULT_ID shall we -- 101...
sginsberg [Fri, 25 Sep 2015 19:28:05 +0000 (19:28 +0000)]
[KDBG] Let's try to have one single version of DPFLTR_DEFAULT_ID shall we -- 101 as part of DPFLTR_TYPE enum is correct, 0xFFFFFFFF as an incorrect define for the "internal" default ID is wrong.

git-svn-id: file:///srv/svn/reactos/trunk@69355 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NDK] Put ZwCreateKeyedEvent in NDK where it belongs.
sginsberg [Fri, 25 Sep 2015 18:40:56 +0000 (18:40 +0000)]
[NDK] Put ZwCreateKeyedEvent in NDK where it belongs.
[EX] Remove "KeGetCurrentProcess" and just use the EPROCESS Pcb member for type correctness instead of inventing a new macro to hide the casting.
[PS] Remove stray INIT_FUNCTION (doesn't do much on a prototype).
[IO] Define _IO_DEBUG_ to 0 again after someone forgot to leave it on 4 years ago (only bloated the code since IopTraceLevel was 0 anyway).

git-svn-id: file:///srv/svn/reactos/trunk@69354 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[KMTESTS:IO]
pschweitzer [Fri, 25 Sep 2015 15:57:28 +0000 (15:57 +0000)]
Add more tests for IoCreateFile(), this time purely dealing with symlinks reparse points.
They won't run on ReactOS (obviously) as we don't have RW NTFS support.

On Windows, they show interesting results....
With Windows 2003, creating the symlink is allowed and works, but then Windows is totally unable to deal with it and keeps complaining about an unhandled reparse tag.
The only way to open it is to open the reparse point itself. Not that working symlinks... Not sure which part is not able to handle the said reparse tag. NTFS? Io?
With Windows Vista+, it just works fine. Symlink is created & functionnal.

Broken logic!

git-svn-id: file:///srv/svn/reactos/trunk@69353 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[KERNEL32_APITEST]
pschweitzer [Fri, 25 Sep 2015 14:53:08 +0000 (14:53 +0000)]
Rename apitest Mailslot test to MailslotRead to avoid testman issue with mailslot winetest

git-svn-id: file:///srv/svn/reactos/trunk@69352 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[KERNEL32_APITEST]
pschweitzer [Fri, 25 Sep 2015 14:44:38 +0000 (14:44 +0000)]
Add a test for CORE-10188 (which was fixed by Thomas in r69236).
It is based on Nikita Pechenkin's patch with a few modifications by me to avoid race condition on start (and avoid flappy test) and to match more closely our coding style

ROSTESTS-190 #resolve #comment Committed in r69351. Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@69351 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[ATL]
gedmurphy [Thu, 24 Sep 2015 20:59:09 +0000 (20:59 +0000)]
A few more gcc based fixes. Just needs the template parameter issues fixing

git-svn-id: file:///srv/svn/reactos/trunk@69350 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[DEVMGR_NEW]
hbelusca [Thu, 24 Sep 2015 19:11:24 +0000 (19:11 +0000)]
(Resources) Add a missing comma. Fixes part of GCC build.

git-svn-id: file:///srv/svn/reactos/trunk@69349 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[DEVMGR_NEW]
hbelusca [Thu, 24 Sep 2015 18:06:02 +0000 (18:06 +0000)]
- Use ROS-style paths for include files.
- Fixup its CMakeFiles for C++11 compilation under GCC (done the way we did for other C++ projects).
- Add a VS project for DEVMGR to make Ged happy.

Start C++ fixups:
- Add 'placement new' operator.
- Add some missing functions (that were not caught by MSVC compilation because we atm. accept function usage without the existence of its actual code...).
More to follow...

git-svn-id: file:///srv/svn/reactos/trunk@69348 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[SHELL32]
gadamopoulos [Thu, 24 Sep 2015 15:49:18 +0000 (15:49 +0000)]
- Fix displaying the name of guid items.

git-svn-id: file:///srv/svn/reactos/trunk@69347 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days agoRevert back to the old devmgr I'll install gcc and reapply the changes tonight.
gedmurphy [Thu, 24 Sep 2015 07:30:08 +0000 (07:30 +0000)]
Revert back to the old devmgr I'll install gcc and reapply the changes tonight.
Apologies for the spam

git-svn-id: file:///srv/svn/reactos/trunk@69346 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days agoTurn off building devmgr for now due to multiple gcc errors. I'll install gcc :o...
gedmurphy [Thu, 24 Sep 2015 07:18:29 +0000 (07:18 +0000)]
Turn off building devmgr for now due to multiple gcc errors. I'll install gcc :o and fix things locally instead of relying on the buildbots

git-svn-id: file:///srv/svn/reactos/trunk@69345 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days agounixification
gedmurphy [Thu, 24 Sep 2015 07:13:21 +0000 (07:13 +0000)]

git-svn-id: file:///srv/svn/reactos/trunk@69344 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days agoFix build (part 1 of ?)
gedmurphy [Thu, 24 Sep 2015 07:09:29 +0000 (07:09 +0000)]
Fix build (part 1 of ?)

git-svn-id: file:///srv/svn/reactos/trunk@69343 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[DEVMGR]
gedmurphy [Thu, 24 Sep 2015 07:06:29 +0000 (07:06 +0000)]
Delete the old devmgr and replace it with devmgr_new

git-svn-id: file:///srv/svn/reactos/trunk@69342 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[NTOSKRNL]: Now that OBJ_VALID_ATTRIBUTES doesn't include all attributes, fix the...
ion [Thu, 24 Sep 2015 03:32:08 +0000 (03:32 +0000)]
[NTOSKRNL]: Now that OBJ_VALID_ATTRIBUTES doesn't include all attributes, fix the kernel parameter checks.

git-svn-id: file:///srv/svn/reactos/trunk@69341 97493ccd-5924-5043-b1f5-66cb403b36ce

ion [Thu, 24 Sep 2015 02:40:30 +0000 (02:40 +0000)]
[NTOSKRNL]: Add a helper function such that user-mode cannot pass certain kernel-only object attributes to ObOpenObjectByPointer.
[NTOSKRNL]: Make \Device\PhysicalMemory OBJ_KERNEL_EXCLUSIVE
[NTOSKRNL]: Deny access to user-mode when opening a handle to an object with OBJ_KERNEL_EXCLUSIVE
[NTOSKRNL]: Fix NtOpenProcess, NtOpenThread, NtOpenThreadTokenEx, NtOpenProcessTokenEx to use the helper function. Should fix Rtl using OBJ_KERNEL_HANDLE in user-mode.
Thanks to ThFabba for finding out these bugs, and the hbelusca for adding a missing check to NtOpenProcessTokenEx.

git-svn-id: file:///srv/svn/reactos/trunk@69340 97493ccd-5924-5043-b1f5-66cb403b36ce