reactos.git
9 hours ago[NTOSKRNL_VISTA] master trunk
pschweitzer [Mon, 25 Jul 2016 20:45:48 +0000 (20:45 +0000)]
[NTOSKRNL_VISTA]
Implement KeQueryActiveProcessorCount().

CORE-11674

git-svn-id: file:///srv/svn/reactos/trunk@72001 97493ccd-5924-5043-b1f5-66cb403b36ce

9 hours ago[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification...
hbelusca [Mon, 25 Jul 2016 20:24:30 +0000 (20:24 +0000)]
[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification by myself):
◾ Don't return TRUE when CB_SETITEMDATA fails.
◾ Avoid pScheme NULL dereference if allocation fails. CID 1223154
◾ Avoid overflowing the destiny buffer by using StringCchCopy() CID 510953
and:
1) Make it more readable by returning as soon as possible when an error happens.
2) Make it more readable by reducing the nested ifs-checks.
3) Remove the added string in the combobox if the sound scheme buffer mem allocation fails (pt.3 modified).
CORE-11603 #resolve #comment Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@72000 97493ccd-5924-5043-b1f5-66cb403b36ce

10 hours ago[TOOLS]
tfaber [Mon, 25 Jul 2016 19:28:40 +0000 (19:28 +0000)]
[TOOLS]
- Fix MSVC 2013+ build. Patch by Victor Matovykh.
CORE-11575 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71998 97493ccd-5924-5043-b1f5-66cb403b36ce

10 hours ago[SHELL32]
tfaber [Mon, 25 Jul 2016 19:25:46 +0000 (19:25 +0000)]
[SHELL32]
- Add missing dependency

git-svn-id: file:///srv/svn/reactos/trunk@71997 97493ccd-5924-5043-b1f5-66cb403b36ce

19 hours ago[ADVAPI32] silence debug spam
cwittich [Mon, 25 Jul 2016 11:07:44 +0000 (11:07 +0000)]
[ADVAPI32] silence debug spam

git-svn-id: file:///srv/svn/reactos/trunk@71995 97493ccd-5924-5043-b1f5-66cb403b36ce

19 hours ago[WIN32K:NTUSER]
tfaber [Mon, 25 Jul 2016 10:45:30 +0000 (10:45 +0000)]
[WIN32K:NTUSER]
- Fix UserDrawCaptionBar debug spam

git-svn-id: file:///srv/svn/reactos/trunk@71994 97493ccd-5924-5043-b1f5-66cb403b36ce

21 hours ago[NTOS:CC]
tfaber [Mon, 25 Jul 2016 08:48:50 +0000 (08:48 +0000)]
[NTOS:CC]
- Unconditionally acquire the VACB lock during map/pin/unpin operations and release it appropriately
CORE-11555 #resolve
CORE-11654 CORE-11504 CORE-11328 #comment This might be fixed with r71993. Could you retry please?

git-svn-id: file:///srv/svn/reactos/trunk@71993 97493ccd-5924-5043-b1f5-66cb403b36ce

35 hours ago[NTVDM]
aandrejevic [Sun, 24 Jul 2016 18:25:50 +0000 (18:25 +0000)]
[NTVDM]
Implement the VGA AC Color Select register.
Implement INT 0x10, AH = 0x10, subfunction AL = 0x13.

git-svn-id: file:///srv/svn/reactos/trunk@71992 97493ccd-5924-5043-b1f5-66cb403b36ce

37 hours ago[NTOS:CC]
tfaber [Sun, 24 Jul 2016 17:10:30 +0000 (17:10 +0000)]
[NTOS:CC]
- Centralize VACB locking/unlocking into inline functions for easier instrumentation

git-svn-id: file:///srv/svn/reactos/trunk@71991 97493ccd-5924-5043-b1f5-66cb403b36ce

38 hours ago[NTVDM]
aandrejevic [Sun, 24 Jul 2016 15:45:50 +0000 (15:45 +0000)]
[NTVDM]
Always reset the AC latch before writing to the AC index register.
CORE-11669 #resolve #comment Should be fixed in revision r71990.

git-svn-id: file:///srv/svn/reactos/trunk@71990 97493ccd-5924-5043-b1f5-66cb403b36ce

38 hours ago[EVENTVWR]
hbelusca [Sun, 24 Jul 2016 15:24:50 +0000 (15:24 +0000)]
[EVENTVWR]
- Use helper functions for doing the filtering on the events (idea by Mark Jansen).
- Fix the states of menu items, depending on which event log/item (log file/filter; event item...) is currently selected.
- Correctly empty the event items list & cache whenever an event log/filter is closed (and avoid a crash when all logs/filters are closed and someone attempts to open an event item), during concurrent accesses. I use a reference count and AddRef/Release helpers.
- Get rid of the annoying log loading popup, and use instead the loading message displayed in the events listview as well as a progress-bar in the status bar.
CORE-11637

git-svn-id: file:///srv/svn/reactos/trunk@71989 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521
akhaldi [Sat, 23 Jul 2016 21:33:40 +0000 (21:33 +0000)]
[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521

git-svn-id: file:///srv/svn/reactos/trunk@71986 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
mjansen [Sat, 23 Jul 2016 20:35:11 +0000 (20:35 +0000)]
[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
As suggested by Thomas :)

git-svn-id: file:///srv/svn/reactos/trunk@71985 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[MPR]
pschweitzer [Sat, 23 Jul 2016 19:52:23 +0000 (19:52 +0000)]
[MPR]
Provide ReactOS specific implementation for WNetGetConnection(), we cannot use Wine's due to Wine specific MountMgr calls.

git-svn-id: file:///srv/svn/reactos/trunk@71984 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SHELL32] close hKey in error case
cwittich [Sat, 23 Jul 2016 19:39:16 +0000 (19:39 +0000)]
[SHELL32] close hKey in error case

git-svn-id: file:///srv/svn/reactos/trunk@71983 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[NTOS:IO]
tfaber [Sat, 23 Jul 2016 18:18:11 +0000 (18:18 +0000)]
[NTOS:IO]
- Avoid infinite loop in IopMountVolume. Brought to you by Vadim Galyant.
CORE-11663 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71982 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE...
mjansen [Sat, 23 Jul 2016 13:15:19 +0000 (13:15 +0000)]
[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE-10439

git-svn-id: file:///srv/svn/reactos/trunk@71981 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SHELL32] cache entries of "New" menu
cwittich [Sat, 23 Jul 2016 12:31:30 +0000 (12:31 +0000)]
[SHELL32] cache entries of "New" menu
CORE-10439

git-svn-id: file:///srv/svn/reactos/trunk@71980 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SHELL32]
gadamopoulos [Sat, 23 Jul 2016 08:42:38 +0000 (08:42 +0000)]
[SHELL32]
- CDefView: Add the skeleton check that should be used to implement moving items in the CDefView. Nothing more is implemented because GetKeyState is completely unreliable.

git-svn-id: file:///srv/svn/reactos/trunk@71979 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
hbelusca [Fri, 22 Jul 2016 14:15:09 +0000 (14:15 +0000)]
[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
CORE-7645

git-svn-id: file:///srv/svn/reactos/trunk@71978 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[ADVPACK]: Add file version information resource.
hbelusca [Fri, 22 Jul 2016 13:19:25 +0000 (13:19 +0000)]
[ADVPACK]: Add file version information resource.
CORE-7645 #comment Please retest the installation of Visual Basic 6 runtime with revision >= 71977.

git-svn-id: file:///srv/svn/reactos/trunk@71977 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[USETUP]
ekohl [Thu, 21 Jul 2016 20:53:43 +0000 (20:53 +0000)]
[USETUP]
Keyboard Modifier LEDs not working in usetup.
Patch by Carlo Bramini.
CORE-3368 #resolve #comment Thanks a lot!

git-svn-id: file:///srv/svn/reactos/trunk@71976 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE...
mjansen [Thu, 21 Jul 2016 17:29:41 +0000 (17:29 +0000)]
[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE-11606 #resolve #comment Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@71975 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[SERIAL]
tfaber [Wed, 20 Jul 2016 12:50:58 +0000 (12:50 +0000)]
[SERIAL]
- Properly stub SerialPower
CORE-11648

git-svn-id: file:///srv/svn/reactos/trunk@71974 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[PARPORT]
tfaber [Wed, 20 Jul 2016 12:21:11 +0000 (12:21 +0000)]
[PARPORT]
- Properly stub FdoPower and PdoPower
CORE-11648

git-svn-id: file:///srv/svn/reactos/trunk@71973 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[PCIIDEX]
tfaber [Wed, 20 Jul 2016 11:49:22 +0000 (11:49 +0000)]
[PCIIDEX]
- Add a stub for PciIdeXPowerDispatch
CORE-11648

git-svn-id: file:///srv/svn/reactos/trunk@71972 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[SERVICES]
ekohl [Tue, 19 Jul 2016 21:30:45 +0000 (21:30 +0000)]
[SERVICES]
Service logon page:
- Handle the interactive service type flag.
- Change the service configuration in the apply function.

git-svn-id: file:///srv/svn/reactos/trunk@71971 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed...
akhaldi [Tue, 19 Jul 2016 18:12:15 +0000 (18:12 +0000)]
[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed CORE-11511.

git-svn-id: file:///srv/svn/reactos/trunk@71970 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTOS:KE]
tfaber [Tue, 19 Jul 2016 12:51:49 +0000 (12:51 +0000)]
[NTOS:KE]
- Load LDT on context switch if required.
CORE-11511 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71967 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[REGEDIT]
hbelusca [Mon, 18 Jul 2016 22:27:17 +0000 (22:27 +0000)]
[REGEDIT]
- Minor whitespace fixes in main.c
- Use a correct info msgbox title when showing regedit command-line usage. Something to think about: translate the cmdline usage! :)

git-svn-id: file:///srv/svn/reactos/trunk@71966 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[SERVMAN]
ekohl [Mon, 18 Jul 2016 21:49:19 +0000 (21:49 +0000)]
[SERVMAN]
Service logon property page:
- Fix initialization and display bugs.
- Start work on the 'Apply' function. It doe not apply changes yet.
- Add password check messages.

git-svn-id: file:///srv/svn/reactos/trunk@71965 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[BOOTDATA]: Disable automatic debugger startup on application crash. This allows...
hbelusca [Mon, 18 Jul 2016 19:25:53 +0000 (19:25 +0000)]
[BOOTDATA]: Disable automatic debugger startup on application crash. This allows getting back the error popup as we used to have, and also warn the user there was indeed a problem, instead of silently start the default debugger (that I've set to an unexistant "drwtsn.exe") and fail silently, since that default debugger doesn't exist.
CORE-11508

git-svn-id: file:///srv/svn/reactos/trunk@71964 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[USER32_WINETEST] Sync with Wine Staging 1.9.14.
akhaldi [Mon, 18 Jul 2016 15:48:27 +0000 (15:48 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.14.

git-svn-id: file:///srv/svn/reactos/trunk@71963 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[USER32] Add missing lprc check in SetRect().
akhaldi [Mon, 18 Jul 2016 15:46:38 +0000 (15:46 +0000)]
[USER32] Add missing lprc check in SetRect().

git-svn-id: file:///srv/svn/reactos/trunk@71962 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[WS2_32_WINETEST] Sync with Wine Staging 1.9.14. Made possible thanks to Peter Hater...
akhaldi [Mon, 18 Jul 2016 10:44:58 +0000 (10:44 +0000)]
[WS2_32_WINETEST] Sync with Wine Staging 1.9.14. Made possible thanks to Peter Hater's changes. CORE-11368 ROSTESTS-233

git-svn-id: file:///srv/svn/reactos/trunk@71961 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[SHELL32] Add AVI file 151. By Jared Smudde. CORE-11638
akhaldi [Mon, 18 Jul 2016 10:27:56 +0000 (10:27 +0000)]
[SHELL32] Add AVI file 151. By Jared Smudde. CORE-11638

git-svn-id: file:///srv/svn/reactos/trunk@71960 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[User32]
jimtabor [Mon, 18 Jul 2016 02:35:46 +0000 (02:35 +0000)]
[User32]
- Fix log out shutdown dialog window input. See CORE-11633 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71959 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[EVENTVWR]
hbelusca [Sun, 17 Jul 2016 23:06:03 +0000 (23:06 +0000)]
[EVENTVWR]
Commit "Part 1" of my Improvements for the Event Log Viewer. See CORE-11637 description for more details (too long to stay there).

git-svn-id: file:///srv/svn/reactos/trunk@71958 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[EXPLORER] Fix the Explore all users/open all users menu items. Patch by Jared Smudde...
mjansen [Sat, 16 Jul 2016 17:49:27 +0000 (17:49 +0000)]
[EXPLORER] Fix the Explore all users/open all users menu items. Patch by Jared Smudde. CORE-11146 #resolve #comment Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@71956 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days agoOoops! These were not meant to be committed!
ekohl [Sat, 16 Jul 2016 17:41:44 +0000 (17:41 +0000)]
Ooops! These were not meant to be committed!

git-svn-id: file:///srv/svn/reactos/trunk@71955 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[SERVICES]
ekohl [Sat, 16 Jul 2016 17:39:37 +0000 (17:39 +0000)]
[SERVICES]
Check for NULL pointers before derreferecing them in ScmIsSameServiceAccount().
Patch by Victor Martinez Calvo.
CORE-11599 #resolve #comment Thanks a lot!

git-svn-id: file:///srv/svn/reactos/trunk@71954 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[ADVAPI32]
ekohl [Sat, 16 Jul 2016 16:18:17 +0000 (16:18 +0000)]
[ADVAPI32]
Remove unneeded NULL checks at CreateServiceA/W and ChangeServiceConfigW/A().
Patch by Victor Martinez Calvo.
CORE-11610 #resolve #comment Thanks a lot!

git-svn-id: file:///srv/svn/reactos/trunk@71953 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[LSASRV]
ekohl [Sat, 16 Jul 2016 14:57:33 +0000 (14:57 +0000)]
[LSASRV]
Fix cleanup in LsarRetrievePrivateData().
Modified patch by Victor Martinez Calvo.
CORE-11611 #resolve #comment Thanks a lot!

git-svn-id: file:///srv/svn/reactos/trunk@71952 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[WS2_32]
tfaber [Sat, 16 Jul 2016 07:49:30 +0000 (07:49 +0000)]
[WS2_32]
- Fix a few ws2_32:getaddrinfo test failures. Based on a patch by Peter Hater.
CORE-11368

git-svn-id: file:///srv/svn/reactos/trunk@71951 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[KERNEL32]
tfaber [Sat, 16 Jul 2016 07:08:21 +0000 (07:08 +0000)]
[KERNEL32]
- Fix GetComputerNameEx behavior with regard to NULL/non-NULL buffers and size calculation
CORE-11368

git-svn-id: file:///srv/svn/reactos/trunk@71950 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[EXPLORER] HACK: ignore unimplemented SetBandSiteInfo. Patch by Wim Hueskes. CORE...
mjansen [Fri, 15 Jul 2016 23:33:53 +0000 (23:33 +0000)]
[EXPLORER] HACK: ignore unimplemented SetBandSiteInfo. Patch by Wim Hueskes. CORE-9809 #resolve #comment Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@71949 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[PSDK]: Add two missing flags concerning custom-drawn controls.
hbelusca [Fri, 15 Jul 2016 21:12:52 +0000 (21:12 +0000)]
[PSDK]: Add two missing flags concerning custom-drawn controls.

git-svn-id: file:///srv/svn/reactos/trunk@71948 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[KERNEL32] Check the return buffer for NULL before initializing the unicode string...
akhaldi [Fri, 15 Jul 2016 20:18:20 +0000 (20:18 +0000)]
[KERNEL32] Check the return buffer for NULL before initializing the unicode string buffer with it. By Peter Hater. CORE-11368

git-svn-id: file:///srv/svn/reactos/trunk@71947 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[NtGdi]
jimtabor [Fri, 15 Jul 2016 20:13:33 +0000 (20:13 +0000)]
[NtGdi]
- Make SetBkColor work the same as client side.

git-svn-id: file:///srv/svn/reactos/trunk@71946 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[EVENTVWR]: Fix transparency problems for some icons.
hbelusca [Thu, 14 Jul 2016 18:58:05 +0000 (18:58 +0000)]
[EVENTVWR]: Fix transparency problems for some icons.

git-svn-id: file:///srv/svn/reactos/trunk@71944 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[BOOTLIB]
pschweitzer [Thu, 14 Jul 2016 13:04:08 +0000 (13:04 +0000)]
[BOOTLIB]
Fix checksum computation

CID #1363451

git-svn-id: file:///srv/svn/reactos/trunk@71941 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[BOOTLIB]
pschweitzer [Thu, 14 Jul 2016 12:58:29 +0000 (12:58 +0000)]
[BOOTLIB]
Fix out of bounds read.

CID #1363549

git-svn-id: file:///srv/svn/reactos/trunk@71940 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[BOOTMGR]
pschweitzer [Thu, 14 Jul 2016 12:46:31 +0000 (12:46 +0000)]
[BOOTMGR]
Don't use uninit var.

CID #1363650

git-svn-id: file:///srv/svn/reactos/trunk@71939 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[BOOTLIB]
pschweitzer [Thu, 14 Jul 2016 12:40:17 +0000 (12:40 +0000)]
[BOOTLIB]
Don't deal with uninit ptr.

CID #1363698

git-svn-id: file:///srv/svn/reactos/trunk@71938 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[NTOSKRNL]
pschweitzer [Thu, 14 Jul 2016 12:21:57 +0000 (12:21 +0000)]
[NTOSKRNL]
Assert that the allocated buffers are not leaked.

CID #1248416

git-svn-id: file:///srv/svn/reactos/trunk@71937 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[MUP]
pschweitzer [Thu, 14 Jul 2016 12:07:05 +0000 (12:07 +0000)]
[MUP]
Don't deal with uninit ptr.

CID #1322222

git-svn-id: file:///srv/svn/reactos/trunk@71936 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[ACPPAGE] Remove unused var. CID 1363705
mjansen [Wed, 13 Jul 2016 18:44:51 +0000 (18:44 +0000)]
[ACPPAGE] Remove unused var. CID 1363705

git-svn-id: file:///srv/svn/reactos/trunk@71934 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[RAPPS_NEW] Use the actual buffer size instead of hardcoding a random number. CID...
mjansen [Wed, 13 Jul 2016 18:33:42 +0000 (18:33 +0000)]
[RAPPS_NEW] Use the actual buffer size instead of hardcoding a random number. CID 1363551

git-svn-id: file:///srv/svn/reactos/trunk@71933 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[ACLAYER] Use the return of StringCbPrintfW instead of ignoring it. CID 1363460-63...
mjansen [Wed, 13 Jul 2016 18:10:37 +0000 (18:10 +0000)]
[ACLAYER] Use the return of StringCbPrintfW instead of ignoring it. CID 1363460-63, 65-70, 76, 78, 85, 88, 90

git-svn-id: file:///srv/svn/reactos/trunk@71932 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[APPHELP] Dereference after null check (default_dir). CID 1363509
mjansen [Wed, 13 Jul 2016 18:02:16 +0000 (18:02 +0000)]
[APPHELP] Dereference after null check (default_dir). CID 1363509

git-svn-id: file:///srv/svn/reactos/trunk@71931 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[NTOSKRNL_VISTA]
tfaber [Wed, 13 Jul 2016 17:48:21 +0000 (17:48 +0000)]
[NTOSKRNL_VISTA]
- Avoid ugly hacks
CORE-11596 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71930 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[NET]
hbelusca [Wed, 13 Jul 2016 17:35:16 +0000 (17:35 +0000)]
[NET]
No need to check for whether 'pBuffer' is NULL to call NetApiBufferFree, because:
- 'pBuffer' was used above this call without any particular checks;
- 'pBuffer' can be only null when NetUserEnum fails with an error different from NERR_Success or ERROR_MORE_DATA. But this case was actually checked for before using 'pBuffer'.
By Victor Martinez aka. Mr.Coverity ^^ :)
CID 1363629
CORE-11598 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71929 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[NTOSKRNL_VISTA lib]
hbelusca [Wed, 13 Jul 2016 16:43:16 +0000 (16:43 +0000)]
[NTOSKRNL_VISTA lib]
Initialize utf8_ch_len to zero before using it (at each turn of the for-loop). As I couldn't find this code in Wine, I couldn't see whether they already fixed it or not. Caught by Victor.
CORE-11596

git-svn-id: file:///srv/svn/reactos/trunk@71928 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[SETUP]
hbelusca [Wed, 13 Jul 2016 16:33:37 +0000 (16:33 +0000)]
[SETUP]
- Fix leaking 'pSetupData' in case of failure. CID 1363604
- Since we know that in the remaining of the code, 'pSetupData' is a valid pointer, we can free it at the very end without rechecking whether it was NULL or not.
CORE-11591 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71927 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[MAGNIFY]
hbelusca [Wed, 13 Jul 2016 16:27:39 +0000 (16:27 +0000)]
[MAGNIFY]
Missing break. CID 1363532
CORE-11593 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71926 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[MKHIVE]
hbelusca [Wed, 13 Jul 2016 16:23:12 +0000 (16:23 +0000)]
[MKHIVE]
- Fix usage of the 'Status' variable. CID 1363689
- Fix some DPRINTs.
CORE-11595 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71925 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[CHARMAP]
hbelusca [Wed, 13 Jul 2016 15:50:44 +0000 (15:50 +0000)]
[CHARMAP]
Don't overrun FillGrid() when accessing the last elements. Rewrite the code using 'for' loops, in the same style as what is done elsewhere in the code. CID 1363552
CORE-11597 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71924 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[BOOTLIB]
hbelusca [Wed, 13 Jul 2016 15:43:08 +0000 (15:43 +0000)]
[BOOTLIB]
- BiOpenKey is being feed with the wrong ElementHandle, it should be feed with ElementsHandle one. CID 1363670 . By Victor Martinez Calvo. CORE-11600 #resolve
[BOOTMGR]
- Fix an Assign vs Compare issue. CID 1363558 .  By Victor Martinez Calvo. CORE-11592 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71923 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[BOOTLIB] Remove stray semicolon from a condition in ConsoleCreateLocalInputConsole...
akhaldi [Wed, 13 Jul 2016 09:08:34 +0000 (09:08 +0000)]
[BOOTLIB] Remove stray semicolon from a condition in ConsoleCreateLocalInputConsole(). Patch by Victor for CID 1363701. CORE-11588

git-svn-id: file:///srv/svn/reactos/trunk@71919 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 4. CORE-11368
jimtabor [Wed, 13 Jul 2016 03:16:00 +0000 (03:16 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 4. CORE-11368

git-svn-id: file:///srv/svn/reactos/trunk@71918 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[User32]
jimtabor [Wed, 13 Jul 2016 03:09:01 +0000 (03:09 +0000)]
[User32]
- Sync/port up to Wine Staging 1.9.11 or current. See CORE-11368.

git-svn-id: file:///srv/svn/reactos/trunk@71917 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[NtUser]
jimtabor [Wed, 13 Jul 2016 03:04:20 +0000 (03:04 +0000)]
[NtUser]
- Fix crash in User32:win:test_winproc_handles. See CORE-11368.

git-svn-id: file:///srv/svn/reactos/trunk@71916 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[User32]
jimtabor [Wed, 13 Jul 2016 00:40:07 +0000 (00:40 +0000)]
[User32]
- Fix regression in API:RealGetWindowClass test due to wine sync/port.
- ReactOS use of DIALOG_get_info is an enhanced fork of the same wine function.

git-svn-id: file:///srv/svn/reactos/trunk@71915 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[CONCFG]: Add needed inclusion for StrSafe functions.
hbelusca [Wed, 13 Jul 2016 00:09:36 +0000 (00:09 +0000)]
[CONCFG]: Add needed inclusion for StrSafe functions.

git-svn-id: file:///srv/svn/reactos/trunk@71914 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[CONSRV]
hbelusca [Wed, 13 Jul 2016 00:06:09 +0000 (00:06 +0000)]
[CONSRV]
- Fix potential Out-of-bounds access during string copy/concatenation. CID 1322098.
- Fix check for NULL after potential dereference. CID 1322175.

git-svn-id: file:///srv/svn/reactos/trunk@71913 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[SHELL32]
hbelusca [Tue, 12 Jul 2016 23:00:50 +0000 (23:00 +0000)]
[SHELL32]
- Use StringCbCopyW

[PROGMAN]
- Use StringCbCopyW: CID #1363712.
- Don't read registry values in a registry key if we failed to open it. CID #514350.

git-svn-id: file:///srv/svn/reactos/trunk@71912 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[USETUP]
hbelusca [Tue, 12 Jul 2016 22:30:55 +0000 (22:30 +0000)]
[USETUP]
- Don't hardcode buffer string size in GetPartTypeStringFromPartitionType calls.
- Possibly check whether the first character of the PartTypeString string is NULL before printing a generic partition information in case the partition type is unknown. We might check instead for the STRING_FORMATUNKNOWN string...
- Don't check for PartTypeString being NULL since it's not a pointer. CID #1363481 and CID #1363494.

git-svn-id: file:///srv/svn/reactos/trunk@71911 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[KERNEL32_WINETEST] Sync with Wine Staging 1.9.14 except thread tests. CORE-11511
akhaldi [Tue, 12 Jul 2016 21:10:24 +0000 (21:10 +0000)]
[KERNEL32_WINETEST] Sync with Wine Staging 1.9.14 except thread tests. CORE-11511

git-svn-id: file:///srv/svn/reactos/trunk@71910 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[NTDLL_WINETEST] Partial sync with Wine Staging 1.9.14. CORE-11368 holds some remaini...
akhaldi [Tue, 12 Jul 2016 20:40:20 +0000 (20:40 +0000)]
[NTDLL_WINETEST] Partial sync with Wine Staging 1.9.14. CORE-11368 holds some remaining tests.

git-svn-id: file:///srv/svn/reactos/trunk@71909 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 3. CORE-11368
jimtabor [Tue, 12 Jul 2016 20:08:44 +0000 (20:08 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.11 Part 3. CORE-11368

git-svn-id: file:///srv/svn/reactos/trunk@71907 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[Win32SS]
jimtabor [Tue, 12 Jul 2016 20:06:30 +0000 (20:06 +0000)]
[Win32SS]
- Update (Sync/Port) User32:Text to Wine Staging 1.9.11, see CORE-11368.

git-svn-id: file:///srv/svn/reactos/trunk@71906 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[Win32SS]
jimtabor [Tue, 12 Jul 2016 18:23:04 +0000 (18:23 +0000)]
[Win32SS]
- Cleanup error codes for Classes and Menus.
- Update (Sync/Port) User32:Dialog to Wine Staging 1.9.11, see CORE-11368.
- Now pass exactly the same tests as windows, except for the two ToDos lines 1596 & 1617. The other test failures are on wine for not being compatible!

git-svn-id: file:///srv/svn/reactos/trunk@71904 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[SCHTASKS] Import from Wine Staging 1.9.14. CORE-11576
akhaldi [Tue, 12 Jul 2016 15:35:42 +0000 (15:35 +0000)]
[SCHTASKS] Import from Wine Staging 1.9.14. CORE-11576

git-svn-id: file:///srv/svn/reactos/trunk@71903 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[UXTHEME_WINETEST] Sync with Wine Staging 1.9.14.
akhaldi [Tue, 12 Jul 2016 11:13:34 +0000 (11:13 +0000)]
[UXTHEME_WINETEST] Sync with Wine Staging 1.9.14.

git-svn-id: file:///srv/svn/reactos/trunk@71902 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[UXTHEME] Apply Wine commit 997e204 by Louis Lenders: Fix CloseThemeData with invalid...
akhaldi [Tue, 12 Jul 2016 11:12:58 +0000 (11:12 +0000)]
[UXTHEME] Apply Wine commit 997e204 by Louis Lenders: Fix CloseThemeData with invalid handle value. CORE-11368

git-svn-id: file:///srv/svn/reactos/trunk@71901 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[SHELL32_WINETEST] Sync with Wine Staging 1.9.14.
akhaldi [Tue, 12 Jul 2016 10:49:51 +0000 (10:49 +0000)]
[SHELL32_WINETEST] Sync with Wine Staging 1.9.14.

git-svn-id: file:///srv/svn/reactos/trunk@71900 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[PSDK] Add some missing ASSOCF_* enum elements.
akhaldi [Tue, 12 Jul 2016 10:46:22 +0000 (10:46 +0000)]
[PSDK] Add some missing ASSOCF_* enum elements.

git-svn-id: file:///srv/svn/reactos/trunk@71899 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[ADVAPI32_WINETEST] Sync with Wine Staging 1.9.14.
akhaldi [Tue, 12 Jul 2016 10:38:36 +0000 (10:38 +0000)]
[ADVAPI32_WINETEST] Sync with Wine Staging 1.9.14.

git-svn-id: file:///srv/svn/reactos/trunk@71898 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[TRANSLATION] Russian translations by Nikolay Burshtyn (amber). CORE-11567 #resolve...
mjansen [Mon, 11 Jul 2016 19:02:48 +0000 (19:02 +0000)]
[TRANSLATION] Russian translations by Nikolay Burshtyn (amber). CORE-11567 #resolve #comment Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@71896 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[INCLUDES/WINE] Update test.h.
akhaldi [Mon, 11 Jul 2016 10:47:42 +0000 (10:47 +0000)]
[INCLUDES/WINE] Update test.h.

git-svn-id: file:///srv/svn/reactos/trunk@71895 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[GDI32_WINETEST] Sync with Wine Staging 1.9.14.
akhaldi [Mon, 11 Jul 2016 10:46:47 +0000 (10:46 +0000)]
[GDI32_WINETEST] Sync with Wine Staging 1.9.14.

git-svn-id: file:///srv/svn/reactos/trunk@71894 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks agoFix usage of the first parameter for TranslateAccelerator: this should be the handle...
hbelusca [Mon, 11 Jul 2016 01:57:47 +0000 (01:57 +0000)]
Fix usage of the first parameter for TranslateAccelerator: this should be the handle of the window that will receive the accelerator commands (not the window from which the message originates).

git-svn-id: file:///srv/svn/reactos/trunk@71893 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[SERVMGR]
ekohl [Sun, 10 Jul 2016 21:54:17 +0000 (21:54 +0000)]
[SERVMGR]
Service recovery page:
- Dissect the 'run process' command line and display it.
- Implement the 'Browse' button.

git-svn-id: file:///srv/svn/reactos/trunk@71892 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[NEWDEV]
ekohl [Sun, 10 Jul 2016 20:26:05 +0000 (20:26 +0000)]
[NEWDEV]
Fix words in newdev. (Italian translation)
Patch by decodp.
CORE-11437 #resolve #comment Thanks a lot!

git-svn-id: file:///srv/svn/reactos/trunk@71891 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[FASTFAT]
pschweitzer [Sun, 10 Jul 2016 18:16:03 +0000 (18:16 +0000)]
[FASTFAT]
CcMapData 4th arg isn't a boolean but a flag. Fix it accordingly
CcPinRead 4th arg isn't a boolean but a flag. Fix it accordingly

git-svn-id: file:///srv/svn/reactos/trunk@71890 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[CDFS]
pschweitzer [Sun, 10 Jul 2016 18:06:47 +0000 (18:06 +0000)]
[CDFS]
CcMapData 4th arg isn't a boolean but a flag. Fix it accordingly

git-svn-id: file:///srv/svn/reactos/trunk@71889 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[FASTFAT][CDFS]
pschweitzer [Sun, 10 Jul 2016 17:14:33 +0000 (17:14 +0000)]
[FASTFAT][CDFS]
Call CcMapData(), CcPinRead() inside a SEH block
This allows returning more significant error codes on failure

[NTOSKRNL]
Enable Thomas code for raising exceptions

CORE-9848

git-svn-id: file:///srv/svn/reactos/trunk@71888 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[SDK] Add the first appcompat database, containing references to version lie shims...
mjansen [Sun, 10 Jul 2016 16:21:53 +0000 (16:21 +0000)]
[SDK] Add the first appcompat database, containing references to version lie shims. CORE-11302 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@71887 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[SDK][XML2SDB] Introducing the xml2sdb host tool, used to convert xml files to appcom...
mjansen [Sun, 10 Jul 2016 16:14:39 +0000 (16:14 +0000)]
[SDK][XML2SDB] Introducing the xml2sdb host tool, used to convert xml files to appcompat Sdb files. CORE-11302
Uses tinyxml2 to parse the xml.
Thanks to Thomas for reviewing / suggesting fixes!

git-svn-id: file:///srv/svn/reactos/trunk@71886 97493ccd-5924-5043-b1f5-66cb403b36ce

2 weeks ago[APPHELP] Prepare sdbwrite related api for a new hosttool. CORE-11302
mjansen [Sun, 10 Jul 2016 16:06:39 +0000 (16:06 +0000)]
[APPHELP] Prepare sdbwrite related api for a new hosttool. CORE-11302
- Adding an extra argument to SdbReAlloc
- Do not rely on platform wcs* functions.

git-svn-id: file:///srv/svn/reactos/trunk@71885 97493ccd-5924-5043-b1f5-66cb403b36ce