reactos.git
3 days ago[MBEDTLS] Update to version 2.7.16. CORE-17155 master
Thomas Faber [Sat, 4 Jul 2020 12:43:45 +0000 (14:43 +0200)]
[MBEDTLS] Update to version 2.7.16. CORE-17155

3 days ago[MBEDTLS] Switch license headers to the dual-licensed version. CORE-17155
Thomas Faber [Sat, 4 Jul 2020 12:47:41 +0000 (14:47 +0200)]
[MBEDTLS] Switch license headers to the dual-licensed version. CORE-17155

This is the default going forward, and separating it out into its own
commit removes the noise from the following sync commit.

3 days ago[ROSAPPS] Remove applications from test directory 2947/head
Mark Jansen [Tue, 23 Jun 2020 21:46:35 +0000 (23:46 +0200)]
[ROSAPPS] Remove applications from test directory
CORE-17097

3 days ago[ROSAUTOTEST] Add option to list all testable modules
Mark Jansen [Tue, 23 Jun 2020 21:45:42 +0000 (23:45 +0200)]
[ROSAUTOTEST] Add option to list all testable modules

3 days ago[SVCHOST] Fix PSID initialization 2965/head
Mark Jansen [Thu, 2 Jul 2020 20:25:46 +0000 (22:25 +0200)]
[SVCHOST] Fix PSID initialization
CORE-17151

3 days ago[NTOS:IO] Fix pool memory disclosure in IopQueueTargetDeviceEvent (#2966)
Nguyen Trung Khanh [Sat, 4 Jul 2020 13:41:18 +0000 (20:41 +0700)]
[NTOS:IO] Fix pool memory disclosure in IopQueueTargetDeviceEvent (#2966)

3 days ago[WIN32SS][GDI] Fix pool memory disclosure in NtGdiGetOutlineTextMetricsInternalW...
Nguyen Trung Khanh [Sat, 4 Jul 2020 13:39:16 +0000 (20:39 +0700)]
[WIN32SS][GDI] Fix pool memory disclosure in NtGdiGetOutlineTextMetricsInternalW (#2964)

3 days ago[CMAKE] Remove obsolete 'GCC_VERSION' checks (#2962)
Serge Gautherie [Sat, 4 Jul 2020 13:33:50 +0000 (15:33 +0200)]
[CMAKE] Remove obsolete 'GCC_VERSION' checks (#2962)

following upgrade to RosBE 2.2.0 support and GCC 8.4.

3 days ago[ADVAPI32_WINETEST] test_create_delete_svc(): Fix 'account' size (#2960)
Serge Gautherie [Sat, 4 Jul 2020 13:24:46 +0000 (15:24 +0200)]
[ADVAPI32_WINETEST] test_create_delete_svc(): Fix 'account' size (#2960)

Cherry-pick
https://source.winehq.org/git/wine.git/commit/56a83c585aeb071af29824399e22db5cdce0318a

3 days ago[UTILDLL_APITEST] Create 'CachedGetUserFromSid()' test (#2954)
Serge Gautherie [Sat, 4 Jul 2020 13:24:13 +0000 (15:24 +0200)]
[UTILDLL_APITEST] Create 'CachedGetUserFromSid()' test (#2954)

3 days ago[ROSTESTS] sertest.c: Replace a busy loop with 'Sleep()' (#2886)
Serge Gautherie [Sat, 4 Jul 2020 13:18:22 +0000 (15:18 +0200)]
[ROSTESTS] sertest.c: Replace a busy loop with 'Sleep()' (#2886)

Detected by Cppcheck: uninitvar.
ROSTESTS-204

Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
3 days ago[OSK] Updated German On-Screen Keyboard translation (#2882)
FritzsHero [Sat, 4 Jul 2020 13:17:26 +0000 (15:17 +0200)]
[OSK] Updated German On-Screen Keyboard translation (#2882)

3 days ago[NET] cmdAccounts(): Set ProductType default value (#2365)
Serge Gautherie [Sat, 4 Jul 2020 13:16:22 +0000 (15:16 +0200)]
[NET] cmdAccounts(): Set ProductType default value (#2365)

3 days ago[USER32][NTUSER] Fix wrong return from LB_GETLISTBOXINFO (#2168)
Jose Carlos Jesus [Sat, 4 Jul 2020 13:11:10 +0000 (14:11 +0100)]
[USER32][NTUSER] Fix wrong return from LB_GETLISTBOXINFO (#2168)

And is now consistent with comctl32 and Wine too...

8 days ago[UDFS] Zero-initialize IO_STATUS_BLOCK data in UDFCommonCreate
Victor Perevertkin [Sun, 28 Jun 2020 23:37:12 +0000 (02:37 +0300)]
[UDFS] Zero-initialize IO_STATUS_BLOCK data in UDFCommonCreate
Some places have been changed to return FILE_DOES_NOT_EXIST, everything
else just returns 0. FastFAT driver from MS does the same (tm),
so I'm not going to have a big research here.
CORE-16623

Co-authored-by: Suraj K Suresh <kssuraj15@gmail.com>
10 days ago[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub 2932/head
Oleg Dubinskiy [Thu, 18 Jun 2020 18:06:34 +0000 (21:06 +0300)]
[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub
See https://www.geoffchappell.com/studies/windows/win32/services/svchost/dll/svchostpushserviceglobals.htm.

10 days ago[SDK][SVCHOST] Move all global svchost declarations to public header. 2931/head
Oleg Dubinskiy [Thu, 18 Jun 2020 12:03:01 +0000 (15:03 +0300)]
[SDK][SVCHOST] Move all global svchost declarations to public header.

Also update the includes.
It will allow to use those declarations globally where they are required (e. g. for SvchostPushServiceGlobals functions in some services).
No functional changes.

10 days ago[MSI] Remove obsolete '__ASM_DEFINE_FUNC()' 2918/head
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[MSI] Remove obsolete '__ASM_DEFINE_FUNC()'

MSVC build reports:
{{
dll\win32\msi\msvchelper.h(3): warning C4005: '__ASM_DEFINE_FUNC': macro redefinition
sdk\include\reactos\wine/asm.h(60): note: see previous definition of '__ASM_DEFINE_FUNC'
dll\win32\msi\custom.c(547): warning C4003: not enough actual parameters for macro '__ASM_DEFINE_FUNC'
}}

Addendum to 476c99b and 9efafd6.

10 days ago[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()'
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()'

Addendum to 0f5d91b.
CORE-16441

10 days ago[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type 2917/head
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type

MSVC 'Release' build reports:
'dll\apisets\api-ms-win-crt-utility-l1-1-0_stubs.c(41): warning C4391: 'int llabs()': incorrect return type for intrinsic function, expected '__int64''

Addendum to 3f15a0d.

10 days ago[POWRPROF_APITEST] Fix cppcheck warnings. 2891/head
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[POWRPROF_APITEST] Fix cppcheck warnings.

* test_CallNtPowerInformation(): Fix 2 'sizeof(sizeof())' copypastas
* test_ValidatePowerPolicies_Next(): Delete a duplicate line

10 days ago[CRT] _onexit(): Fix 'memcpy()' size 2892/head
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[CRT] _onexit(): Fix 'memcpy()' size

Cherry-pick
https://source.winehq.org/git/wine.git/commit/70bff7377dbe9bdaaac5e86c49ee45130e65e5d9

10 days ago[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive.
Serge Gautherie [Mon, 1 Jun 2020 19:29:02 +0000 (21:29 +0200)]
[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive.

* _atexit_cleanup is no longer used
* Fix cppcheck 'pointerSize' warning

10 days ago[SYSDM] Set the proper icon in title bar
Jared Smudde [Sat, 27 Jun 2020 00:51:22 +0000 (19:51 -0500)]
[SYSDM] Set the proper icon in title bar

10 days ago[KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate.
Thomas Faber [Sat, 27 Jun 2020 07:27:33 +0000 (09:27 +0200)]
[KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate.

* Check the entire version field
* Check the variant field
* Accept RPC_NT_UUID_LOCAL_ONLY, which is sometimes returned by Windows
* Repeat the test to show that these things happen every time

Based on a patch by Serge Gautherie.

11 days ago[FASTFAT_NEW] Sync to upstream 16022c5 (#2938)
Serge Gautherie [Fri, 26 Jun 2020 17:03:01 +0000 (19:03 +0200)]
[FASTFAT_NEW] Sync to upstream 16022c5 (#2938)

12 days ago[TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific

12 days ago[NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code
Serge Gautherie [Fri, 22 May 2020 18:24:31 +0000 (20:24 +0200)]
[NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code

No impact.

Detected by Cppcheck: unreachableCode.
Addendum to ddaf47dec3f096666757ff2cc9892adc01da887c (r34976).

13 days ago[USBSTOR] Correctly terminate a REG_MULTI_SZ string
Victor Perevertkin [Wed, 24 Jun 2020 18:14:36 +0000 (21:14 +0300)]
[USBSTOR] Correctly terminate a REG_MULTI_SZ string
returned by the IRP_MN_QUERY_ID handler

13 days ago[WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory. 2937/head
Nguyen Trung Khanh [Sat, 20 Jun 2020 03:16:56 +0000 (10:16 +0700)]
[WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory.

This avoids disclosing pool contents to user mode when not all members
of the respective structure are initialized or when there is padding.

In co_IntCallWindowProc, also zero the stack buffer since this can
be passed to user mode as well, and contains padding.

13 days ago[NPFS] Fix querying FileAllInformation.
Thomas Faber [Tue, 23 Jun 2020 08:15:24 +0000 (10:15 +0200)]
[NPFS] Fix querying FileAllInformation.

13 days ago[NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c 2940/head
Victor Perevertkin [Sun, 21 Jun 2020 14:54:44 +0000 (17:54 +0300)]
[NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c
And rearrange them in more logical order.

This effectively splits the file, leaving public "Io" functions in
pnpmgr.c along with some things not related do device object management.
Functions which manipulate the device tree are left in devaction.c.
In future all these functions will only be accessed from
DeviceActionWorker.
While being public API, IoRequestDeviceEject and IoInvalidateDeviceState
have been moved to devaction.c as well. In next commits they will be
converted to DeviceActionWorker routines and their callers will be put
in pnpmgr.c

13 days ago[ROSAUTOTEST] Add /t parameter for repeating tests
Victor Perevertkin [Mon, 18 May 2020 02:42:53 +0000 (05:42 +0300)]
[ROSAUTOTEST] Add /t parameter for repeating tests

2 weeks ago[KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136
Thomas Faber [Sun, 21 Jun 2020 08:18:19 +0000 (10:18 +0200)]
[KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136

2 weeks ago[I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136
Thomas Faber [Sun, 21 Jun 2020 07:57:17 +0000 (09:57 +0200)]
[I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136

We neither want to handle IRPs we don't understand, nor do we want to
assert in case of unexpected IOCTLs.

2 weeks ago[NTOS:IO] Move device node functions from pnpmgr/pnpmgr.c to pnpmgr/devnode.c 2934/head
Victor Perevertkin [Fri, 19 Jun 2020 20:55:40 +0000 (23:55 +0300)]
[NTOS:IO] Move device node functions from pnpmgr/pnpmgr.c to pnpmgr/devnode.c
Add SAL2 annotations to functions while moving
Convert IopCreateDeviceNode description to a Doxygen format

2 weeks ago[FASTFAT_NEW] Simplify unsupported NT6.2+ workarounds
Serge Gautherie [Mon, 15 Jun 2020 04:57:04 +0000 (06:57 +0200)]
[FASTFAT_NEW] Simplify unsupported NT6.2+ workarounds

2 weeks ago[FASTFAT_NEW] Remove obsolete compiler workarounds
Serge Gautherie [Mon, 15 Jun 2020 04:57:04 +0000 (06:57 +0200)]
[FASTFAT_NEW] Remove obsolete compiler workarounds

following upgrade to GCC 8.4 and MSVC 2015.

2 weeks ago[FASTFAT_NEW] Fix GCC 8.4 build
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[FASTFAT_NEW] Fix GCC 8.4 build

'.../strucsup.c:...:...: error: 'Ex*NPagedLookasideList' is static but used in inline function 'Fat*' which is not static [-Werror]'

2 weeks ago[FASTFAT_NEW] fatdata.h: Properly mark ReactOS own code
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[FASTFAT_NEW] fatdata.h: Properly mark ReactOS own code

Addendum to 3013e15.

2 weeks ago[CMAKE] Remove work-arounds for old CMake versions. CORE-17109 2901/head
Thomas Faber [Sun, 7 Jun 2020 07:26:23 +0000 (09:26 +0200)]
[CMAKE] Remove work-arounds for old CMake versions. CORE-17109

2 weeks ago[CMAKE] Use CMake 3.17 default policies. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 21:00:02 +0000 (23:00 +0200)]
[CMAKE] Use CMake 3.17 default policies. CORE-17109

2 weeks ago[CMAKE] Bump minimum to 3.17, no longer require -ReactOS build. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:59:26 +0000 (22:59 +0200)]
[CMAKE] Bump minimum to 3.17, no longer require -ReactOS build. CORE-17109

2 weeks ago[CMAKE] Set CMAKE_MSVC_RUNTIME_LIBRARY to satisfy CMP0091. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 22:20:09 +0000 (00:20 +0200)]
[CMAKE] Set CMAKE_MSVC_RUNTIME_LIBRARY to satisfy CMP0091. CORE-17109

We use /NODEFAULTLIB, and consequently also don't want CMake to add
a default library for us.

2 weeks ago[CMAKE] Use NEW policy for CMP0058. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:57:30 +0000 (22:57 +0200)]
[CMAKE] Use NEW policy for CMP0058. CORE-17109

2 weeks ago[CMAKE] Mark host tools as byproducts. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:57:11 +0000 (22:57 +0200)]
[CMAKE] Mark host tools as byproducts. CORE-17109

2 weeks ago[BOOTDATA] Mark reactos.inf as a byproduct. CORE-17109
Thomas Faber [Sat, 6 Jun 2020 20:56:49 +0000 (22:56 +0200)]
[BOOTDATA] Mark reactos.inf as a byproduct. CORE-17109

2 weeks ago[WINMM] Improve implementation of timeGetTime, timeBeginPeriod, timeEndPeriod (#2933)
Thomas Brogan [Sat, 20 Jun 2020 10:28:25 +0000 (13:28 +0300)]
[WINMM] Improve implementation of timeGetTime, timeBeginPeriod, timeEndPeriod (#2933)

Use QueryPerformanceCounter if a high-resolution timer is requested (<= 5ms) instead of the more inaccurate GetTickCount.

2 weeks ago[PCI] Fix PDO removal
Hervé Poussineau [Thu, 18 Jun 2020 16:18:13 +0000 (18:18 +0200)]
[PCI] Fix PDO removal

We must not do anything on PDO removal, especially not deleting it.
We are allowed to delete it, only once we successfully completed a IRP_MN_QUERY_DEVICE_RELATIONS without with PDO.

2 weeks ago[SETUPAPI] Add function names in traces
Hervé Poussineau [Thu, 18 Jun 2020 17:20:14 +0000 (19:20 +0200)]
[SETUPAPI] Add function names in traces

2 weeks ago[NtUser] Fix MSVC_x64 Build
James Tabor [Thu, 18 Jun 2020 16:55:13 +0000 (11:55 -0500)]
[NtUser] Fix MSVC_x64 Build

Attempt to fix.

2 weeks ago[NtUser] Fix Crash in Win32k
James Tabor [Thu, 18 Jun 2020 16:06:31 +0000 (11:06 -0500)]
[NtUser] Fix Crash in Win32k

Use strict thread and desktop verifying. See CORE-15092 and CORE-17133.

2 weeks ago[GDI32] MirrorRgnByWidth(): Fix 'phrgn' parameter handling 2910/head
Serge Gautherie [Tue, 9 Jun 2020 00:52:17 +0000 (02:52 +0200)]
[GDI32] MirrorRgnByWidth(): Fix 'phrgn' parameter handling

Detected by Cppcheck: uselessAssignmentPtrArg.
Addendum to 794e7aa (r31523) and e647530 (r65893).

2 weeks ago[VIDEOPRT] IntVideoPortCreateAdapterDeviceObject(): 1+1 trivial fixes 2909/head
Serge Gautherie [Mon, 8 Jun 2020 20:45:45 +0000 (22:45 +0200)]
[VIDEOPRT] IntVideoPortCreateAdapterDeviceObject(): 1+1 trivial fixes

Detected by Cppcheck: funcArgOrderDifferent, redundantAssignment.

2 weeks ago[KMTESTS:OB] ObTypes: Support latest NT5.2 results 2153/head
Serge Gautherie [Mon, 16 Dec 2019 03:28:29 +0000 (04:28 +0100)]
[KMTESTS:OB] ObTypes: Support latest NT5.2 results

Update Port and WaitablePort values.

3 weeks ago[RAPPS] delete obsolete field GSoC_2020/Syzkaller
He Yang [Sun, 14 Jun 2020 18:34:43 +0000 (02:34 +0800)]
[RAPPS] delete obsolete field

3 weeks ago[DNSRSLVR] Define NDEBUG in cache.c
Joachim Henze [Sun, 14 Jun 2020 18:03:33 +0000 (20:03 +0200)]
[DNSRSLVR] Define NDEBUG in cache.c

To avoid leaking private data into logs by default.
Some testers may consider their DNS-suffix private data.
And DnsIntCacheAddEntry() logs that via Record->pName.

3 weeks agoRevert "[FONTS] Add Selawik as a substitution for Segoe UI" CORE-17122 (#2921)
Oleg Dubinskiy [Sun, 14 Jun 2020 10:09:41 +0000 (13:09 +0300)]
Revert "[FONTS] Add Selawik as a substitution for Segoe UI" CORE-17122 (#2921)

This reverts commit 97fb49a3d2bfdbbf5f03e193f922a80dd39ca9ba.

3 weeks ago[MPG123] Update to version 1.26.1. CORE-17098
Thomas Faber [Sat, 30 May 2020 19:43:44 +0000 (21:43 +0200)]
[MPG123] Update to version 1.26.1. CORE-17098

3 weeks ago[ACPICA] Update to version 20200528. CORE-17094
Thomas Faber [Sat, 30 May 2020 13:30:56 +0000 (15:30 +0200)]
[ACPICA] Update to version 20200528. CORE-17094

3 weeks ago[RTL] Use LastEntryInSegment to speed up RtlpFindAndCommitPages. CORE-14588 2319/head
Thomas Faber [Sun, 2 Feb 2020 11:54:19 +0000 (12:54 +0100)]
[RTL] Use LastEntryInSegment to speed up RtlpFindAndCommitPages. CORE-14588

3 weeks ago[RTL] Add and populate LastEntryInSegment. CORE-14588
Thomas Faber [Sun, 2 Feb 2020 11:53:57 +0000 (12:53 +0100)]
[RTL] Add and populate LastEntryInSegment. CORE-14588

3 weeks ago[RTL] Create a define for the common members of HEAP and HEAP_SEGMENT. CORE-14588
Thomas Faber [Sat, 1 Feb 2020 20:34:03 +0000 (21:34 +0100)]
[RTL] Create a define for the common members of HEAP and HEAP_SEGMENT. CORE-14588

The code relies on these members matching up, so it's confusing for them
to be duplicated.

3 weeks ago[USBSTOR] Fix unused variable introduced in 94e61c3
Victor Perevertkin [Sat, 13 Jun 2020 00:20:08 +0000 (03:20 +0300)]
[USBSTOR] Fix unused variable introduced in 94e61c3

3 weeks ago[USBSTOR] Fix wrong function name in a9b97ae
Victor Perevertkin [Sat, 13 Jun 2020 00:07:00 +0000 (03:07 +0300)]
[USBSTOR] Fix wrong function name in a9b97ae

3 weeks ago[USBSTOR] Move PDO's Inquiry data and FDO's SCSI context
Victor Perevertkin [Fri, 12 Jun 2020 13:51:42 +0000 (16:51 +0300)]
[USBSTOR] Move PDO's Inquiry data and FDO's SCSI context
to their Device Extensions.
This way the driver can better handle low memory situations

3 weeks ago[USBSTOR] General refactoring.
Victor Perevertkin [Sat, 9 Nov 2019 22:05:47 +0000 (01:05 +0300)]
[USBSTOR] General refactoring.
Remove unused structures and unused fields in device extensions.
Replaced magic numbers with constants

3 weeks ago[README.FSD] Add 'disk_new' entry
Serge Gautherie [Wed, 10 Jun 2020 08:09:14 +0000 (10:09 +0200)]
[README.FSD] Add 'disk_new' entry

Follow-up to 022f4b2 (r55555).

3 weeks ago[README.FSD] Add 'nfs41 project' entries
Serge Gautherie [Sat, 6 Jun 2020 18:09:03 +0000 (20:09 +0200)]
[README.FSD] Add 'nfs41 project' entries

CORE-8204

3 weeks ago[README.FSD] Remove obsolete 'reactos/' directory
Serge Gautherie [Sat, 6 Jun 2020 18:04:15 +0000 (20:04 +0200)]
[README.FSD] Remove obsolete 'reactos/' directory

4 weeks ago[FREELDR] Add display controller detection for Xbox
Stanislav Motylkov [Tue, 9 Jun 2020 19:02:09 +0000 (22:02 +0300)]
[FREELDR] Add display controller detection for Xbox

Also add system identifier here.

[BOOTDATA] Fix some typos

CORE-16216

4 weeks ago[SECUR32_WINETEST] Update for new WineHQ certificate
Serge Gautherie [Mon, 8 Jun 2020 17:41:32 +0000 (19:41 +0200)]
[SECUR32_WINETEST] Update for new WineHQ certificate

Cherry-pick
https://source.winehq.org/git/wine.git/commit/16254af818095216e10aee4d9032a8def3ac3344

CORE-17088

4 weeks ago[WININET_WINETEST][URLMON_WINETEST][SHELL32_APITEST] Skip some tests
Victor Perevertkin [Mon, 8 Jun 2020 00:43:43 +0000 (03:43 +0300)]
[WININET_WINETEST][URLMON_WINETEST][SHELL32_APITEST] Skip some tests
Due to hangs on test machines
ROSTESTS-357 ROSTESTS-358 CORE-17057

4 weeks ago[VSSAPI] Add missing wrapper for ?CreateVssBackupComponents@@YGJPAPAVIVssBackupCompon...
Oleg Dubinskiy [Thu, 26 Mar 2020 14:47:16 +0000 (16:47 +0200)]
[VSSAPI] Add missing wrapper for ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z and _VSSAPI_CreateVssBackupComponents@4 in msvc.s, to fix MSVC compilation

4 weeks ago[VSSAPI] Import Wine commits "Stub CreateVssBackupComponentsInternal + ?CreateVssBack...
Oleg Dubinskiy [Wed, 25 Mar 2020 19:23:37 +0000 (21:23 +0200)]
[VSSAPI] Import Wine commits "Stub CreateVssBackupComponentsInternal + ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z"
https://source.winehq.org/git/wine.git/commit/ce9b5a7e1782828f0a84d31eff73cf643ea4fe85
https://source.winehq.org/git/wine.git/commit/767c94bc5c0b9cdef0465b0fec555d846331fb03
CORE-9511.

4 weeks ago[PSDK] Import vsbackup.idl from Wine and enable it in CMakeLists.txt
Oleg Dubinskiy [Wed, 25 Mar 2020 19:09:17 +0000 (21:09 +0200)]
[PSDK] Import vsbackup.idl from Wine and enable it in CMakeLists.txt
Required by vssapi stubs CORE-9511.

4 weeks ago[PSDK] Add some missing definitions from Wine in vss.idl
Oleg Dubinskiy [Wed, 25 Mar 2020 18:59:25 +0000 (20:59 +0200)]
[PSDK] Add some missing definitions from Wine in vss.idl
Required by vssapi stubs and Wine's vsbackup.idl CORE-9511.

4 weeks ago[PSDK] Replace our vswriter.h by Wine's vswriter.idl and enable it in CMakeLists.txt
Oleg Dubinskiy [Wed, 25 Mar 2020 18:33:28 +0000 (20:33 +0200)]
[PSDK] Replace our vswriter.h by Wine's vswriter.idl and enable it in CMakeLists.txt
Required by vssapi stubs CORE-9511.
Our current vswriter.h has no some needed definitions, but simple adding them in the current header is not an option, since Wine's vsbackup.idl (which is required too) depends on it.
Then it will not need to add ROS-specific diff(s) in Wine's vsbackup.idl.

4 weeks ago[CHARMAP] Functionality Improvements and Bug Fixes (#2560)
Charles Ambrye [Sun, 7 Jun 2020 17:34:45 +0000 (10:34 -0700)]
[CHARMAP] Functionality Improvements and Bug Fixes (#2560)

- Resize the window slightly when compiled with REMOVE_ADVANCED to avoid deadspace at the bottom of the window.

- Skip over the non-printable characters by starting with character ' ' + 1.

- Instead of iterating over every cell, simply compute the cell x and y using the CellSize.

- Modify behaviour of charmap to allow large character render on mouse move, only hiding the larger character on double click.

- Simplify math for moving window to be on desktop.
Added FIXME to highlight this doesn't work well on multi-monitor setups.
Changed xPos and yPos to LONG since negative numbers are valid on multi-monitor setups.

- Do not draw invalid glyphs on the map (can happen when switching fonts or filtering existing font).
- Do not allow mouse-over of invalid glyphs.

- Fix bug that caused the Help button to remain enabled as it was being modified before it was even created.
- Do a better job at finding the correct glyph under the mouse.

- Ensure the active cell is cleared correctly.

- Invalidate the rect around the previously active cell to ensure it gets redrawn as inactive.

- Fix bug from CORE-10518 (initial active cell was not being invalidated on scroll).

- Do not try to copy a character to the output if there is no active cell selected.

- Populate the advanced portion of the screen with several built-in code pages (the list is hardcoded so that we don't enumerate everything).

- Add functionality to filter the character map by a code page (called a character set in this program).

- Some fonts list 0x0000 as drawable, even when it isn't, so ignore any valid glyphs that contain it.

4 weeks ago[RPCRT4] Export NdrCreateServerInterfaceFromStub as `stub` 2715/head
Oleg Dubinskiy [Sat, 2 May 2020 08:32:14 +0000 (11:32 +0300)]
[RPCRT4] Export NdrCreateServerInterfaceFromStub as `stub`
Required by MS ole32.dll CORE-15395, CORE-17004.

4 weeks ago[SHELLBARS] Add missing psdk dependency.
Thomas Faber [Sat, 6 Jun 2020 20:55:49 +0000 (22:55 +0200)]
[SHELLBARS] Add missing psdk dependency.

4 weeks ago[MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available.
Thomas Faber [Sat, 6 Jun 2020 20:55:23 +0000 (22:55 +0200)]
[MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available.

4 weeks ago[NTDLL_APITEST] Add ProcessWx86Information testcase for NtXxxInformationProcess ...
George Bișoc [Sat, 6 Jun 2020 19:38:37 +0000 (21:38 +0200)]
[NTDLL_APITEST] Add ProcessWx86Information testcase for NtXxxInformationProcess (#2852)

4 weeks ago[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2764/head
Amine Khaldi [Sat, 9 May 2020 21:37:40 +0000 (22:37 +0100)]
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905

4 weeks ago[HHPCOMP] Fix 2 MSVC C4101 warnings (#2392)
Serge Gautherie [Sat, 6 Jun 2020 16:42:47 +0000 (18:42 +0200)]
[HHPCOMP] Fix 2 MSVC C4101 warnings (#2392)

"...\chmc\chmc.c(671): warning C4101: 'code': unreferenced local variable"
"...\chmc\chmc.c(671): warning C4101: 'len': unreferenced local variable"

4 weeks ago[SHLWAPI] lang/*.rc : Enforce aa-BB filenames (#2816)
Serge Gautherie [Sat, 6 Jun 2020 16:25:43 +0000 (18:25 +0200)]
[SHLWAPI] lang/*.rc : Enforce aa-BB filenames (#2816)

4 weeks ago[NFSD] readdir_copy_shortname(): Add needed brackets to '*name_size_out' (#2856)
Serge Gautherie [Sat, 6 Jun 2020 16:21:05 +0000 (18:21 +0200)]
[NFSD] readdir_copy_shortname(): Add needed brackets to '*name_size_out' (#2856)

CORE-17078

4 weeks ago[APPHELP_APITEST] Properly handle a couple 'malloc()/free()' (#2898)
Serge Gautherie [Sat, 6 Jun 2020 15:58:34 +0000 (17:58 +0200)]
[APPHELP_APITEST] Properly handle a couple 'malloc()/free()' (#2898)

Detected by Cppcheck: memleak, redundantAssignment.
Addendum to 78280ad2 (r71226).

4 weeks ago[NTOSKRNL] Add 'DECLSPEC_NORETURN' to a few 'KeBugCheck*()' (#2896)
Serge Gautherie [Sat, 6 Jun 2020 15:50:14 +0000 (17:50 +0200)]
[NTOSKRNL] Add 'DECLSPEC_NORETURN' to a few 'KeBugCheck*()' (#2896)

4 weeks ago[NTDLL_APITEST] Add NtSetInformationThread testcase (#2793)
George Bișoc [Sat, 6 Jun 2020 15:48:39 +0000 (17:48 +0200)]
[NTDLL_APITEST] Add NtSetInformationThread testcase (#2793)

4 weeks ago[NTDLL_APITEST] Add ProcessBasePriority and ProcessRaisePriority classes unit tests...
George Bișoc [Sat, 6 Jun 2020 15:47:38 +0000 (17:47 +0200)]
[NTDLL_APITEST] Add ProcessBasePriority and ProcessRaisePriority classes unit tests (#2740)

ProcessRaisePriority expects a buffer input information argument of KPRIORITY type definition as shown in this documentation (see the PROCESS_INFORMATION_CLASS structure members list of classes).
https://undocumented.ntinternals.net/index.html?page=UserMode%2FUndocumented%20Functions%2FNT%20Objects%2FProcess%2FNtSetInformationProcess.html

4 weeks ago[NTOS:KE] Save ExceptionList in the assembly version of KiEnterTrap. CORE-15723 2836/head
Thomas Faber [Fri, 22 May 2020 20:34:56 +0000 (22:34 +0200)]
[NTOS:KE] Save ExceptionList in the assembly version of KiEnterTrap. CORE-15723

If SEH is used in a C trap handler, the exception frame will be
registered before the call to KiEnterTrap, which means we save
the wrong trap handler. We'll therefore also restore this wrong
frame for the excepting code, resulting in a stale SEH chain.

We avoid this problem by saving the handler in the assembly
trap entry code instead of from C. While SEH in a C trap handler
should now theoretically be safe, we still forbid it through
asserts in the C KiEnterTrap variants to make any potential
future problems more obvious. Should this functionality be
needed at some point and deemed safe, these asserts can then be
removed.

4 weeks ago[NTOS:KE] Split KiCheckForSListFault into its own function. CORE-15723
Thomas Faber [Fri, 22 May 2020 09:18:39 +0000 (11:18 +0200)]
[NTOS:KE] Split KiCheckForSListFault into its own function. CORE-15723

This avoids SEH in a trap handler.
See the following commit for more details.

4 weeks ago[RTL] Add FPO information to RtlpExecuteHandler. CORE-15723
Thomas Faber [Fri, 22 May 2020 07:22:39 +0000 (09:22 +0200)]
[RTL] Add FPO information to RtlpExecuteHandler. CORE-15723

4 weeks ago[CDMAKE] Add 'DECLSPEC_NORETURN' to 'error_exit()' (#2893)
Serge Gautherie [Fri, 5 Jun 2020 11:57:49 +0000 (13:57 +0200)]
[CDMAKE] Add 'DECLSPEC_NORETURN' to 'error_exit()' (#2893)

Detected by Cppcheck: doubleFree.

4 weeks ago[SDK:RTL] RtlValidAcl(): Improve ACL error messages (#2833)
Serge Gautherie [Thu, 4 Jun 2020 21:20:20 +0000 (23:20 +0200)]
[SDK:RTL] RtlValidAcl(): Improve ACL error messages (#2833)

CORE-11506

4 weeks ago[KERNEL32] FatalAppExitW: Add an 'UNREFERENCED_LOCAL_VARIABLE(Status)' (#2883)
Serge Gautherie [Thu, 4 Jun 2020 20:35:54 +0000 (22:35 +0200)]
[KERNEL32] FatalAppExitW: Add an 'UNREFERENCED_LOCAL_VARIABLE(Status)' (#2883)

Addendum to 21d2accad37825f47e3caa78ff36153751652238 (r71793).

4 weeks ago[IPHLPAPI] getNumInterfacesInt(): Remove 'if()' redundant condition (#2884)
Serge Gautherie [Thu, 4 Jun 2020 20:26:28 +0000 (22:26 +0200)]
[IPHLPAPI] getNumInterfacesInt(): Remove 'if()' redundant condition (#2884)

No impact.

Detected by Cppcheck: redundantCondition.
Addendum to 1fe3a2d6c307a1ec11d7728a9493360a5808e1ac (r9788).

4 weeks ago[HALXBOX] Fix clock drift (#2889)
Dmitry Borisov [Tue, 2 Jun 2020 23:14:16 +0000 (05:14 +0600)]
[HALXBOX] Fix clock drift (#2889)

Add a new rollover table for Original Xbox (base frequency is 1.125000 MHz).
This fixes potential time issues in kernel and drivers.

CORE-16216

4 weeks ago[FREELDR] Fix register offset
Stanislav Motylkov [Tue, 2 Jun 2020 23:04:07 +0000 (02:04 +0300)]
[FREELDR] Fix register offset

Addendum to 10e52f6.