Bișoc George [Tue, 21 Apr 2020 09:28:07 +0000 (11:28 +0200)]
[CRT][STDLIB] Wine-sync _mbtowc_l function code
The current _mbtowc_l code directly passes the string count size argument to cbMultiByte argument parameter to MultiByteToWideChar(). As the size of lpMultiByteStr expressed in bytes by cbMultiByte is dependent of the actual given string, the size of lpWideCharStr expressed in characters by cchWideChar is always 1.
The resulting parameters to MultiByteToWideChar() will lead to a failure as lpWideCharStr cannot accommodate the converted string if the size pointed by lpMultiByteStr is larger than the buffer wide string to receive the converted output, a Win32 error code of ERROR_INSUFFICIENT_BUFFER in other words. The fact that _mbtowc_l never fails without WINE Gecko package installed is because the codepage pointed by lc_codepage is CP_ACP and the converted output is directly given to the destination wide string parameter thus never calling MultiByteToWideChar(). Installing WINE Gecko merely unhides this problem.
As _mbtowc_l is imported from WINE and that they have updated their code (which at the same time this fixes the aforementioned problem), the following commit syncs the updated code from WINE.
CORE-16885
Joachim Henze [Tue, 28 Apr 2020 19:33:26 +0000 (21:33 +0200)]
[BOOTDATA] CORE-16976 Strip netkvm from optional files
Because we added it into our sources recently,
there is no need anymore for opt-adding binaries.
VBox OK https://reactos.org/testman/compare.php?ids=72868,72873
KVM OK https://reactos.org/testman/compare.php?ids=72869,72872
Katayama Hirofumi MZ [Tue, 28 Apr 2020 11:56:18 +0000 (20:56 +0900)]
[SHIMGVW] Correctly draw display border (#2687)
Use WS_EX_CLIENTEDGE extended style for display window.
Fix message WM_SIZE handling. CORE-16983
Serge Gautherie [Mon, 27 Apr 2020 20:10:22 +0000 (22:10 +0200)]
[WINSPOOL] EnumPrintersA: Refactor failure handling (#2304)
Serge Gautherie [Tue, 31 Mar 2020 07:39:16 +0000 (09:39 +0200)]
[RPCRT4] Add I_RpcSNCHOption() as 'stub'
CORE-12534
Piotr Hetnarowicz [Mon, 27 Apr 2020 19:49:33 +0000 (21:49 +0200)]
[LABEL] Update Polish translation (#2678)
Co-Authored-By: Adam Słaboń <asaillen456esx@gmail.com>
Kyle Katarn [Mon, 27 Apr 2020 16:25:19 +0000 (18:25 +0200)]
[SYSDM] User Profiles fix of OnDestroy (CORE-16921) (#2614)
Stanislav Motylkov [Mon, 27 Apr 2020 12:22:58 +0000 (15:22 +0300)]
[SHELL32] Fix dialog labels in Recycle Bin properties page (#2676)
Also fix remaining "Max size" edit box positions.
Addendum to
e6e45b3. CORE-16972
Mark Jansen [Wed, 6 Mar 2019 23:15:00 +0000 (00:15 +0100)]
[WIN32K] Mute a DPRINT
Mark Jansen [Wed, 6 Mar 2019 23:13:19 +0000 (00:13 +0100)]
[WIN32K] Allocate a buffer for a classname that is too long
Kyle Katarn [Mon, 27 Apr 2020 10:48:26 +0000 (12:48 +0200)]
[SHELL32] Fix "Max size" Edit box position in Recycle Bin properties page (#2676)
CORE-16972
Kyle Katarn [Mon, 27 Apr 2020 10:44:27 +0000 (12:44 +0200)]
[NETID] Fix incorrect component position and size, complete French translation (#2672)
- Missing fr-fr translation for some items
- Wrong components size and/or position to fully display text
CORE-16597
- Complete fr-fr translation of associated .rc file
- Fix of component design (size, location, BS_MULTILINE).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Piotr Hetnarowicz [Mon, 27 Apr 2020 10:38:27 +0000 (12:38 +0200)]
[RASDLG] pl-PL update (#2675)
Kyle Katarn [Mon, 27 Apr 2020 10:32:42 +0000 (12:32 +0200)]
[EXPLORER] Fix incorrect component position and size for French language (#2671)
CORE-16930, CORE-12386
Victor Perevertkin [Mon, 27 Apr 2020 00:40:48 +0000 (03:40 +0300)]
[CMAKE] Fix build with CMake 3.17.1-ReactOS (RosBE 2.2)
Oleg Dubinskiy [Sun, 26 Apr 2020 19:15:21 +0000 (22:15 +0300)]
[PROFMAP] Initial implementation (#2119)
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
Serge Gautherie [Fri, 24 Jan 2020 13:47:58 +0000 (14:47 +0100)]
[EXPLORER] trayclock: Update timer delay when showing seconds is modified
Serge Gautherie [Fri, 24 Jan 2020 13:47:58 +0000 (14:47 +0100)]
[EXPLORER] trayclock: Better handle timers, especially when it is hidden
Serge Gautherie [Fri, 24 Jan 2020 03:41:00 +0000 (04:41 +0100)]
[EXPLORER] CTrayClockWnd::CalculateDueTime(): Fix uiDueTime value
when showing seconds.
Adam Stachowicz [Sun, 26 Apr 2020 18:39:09 +0000 (20:39 +0200)]
[CODEOWNERS ] Clarify the use of teams
Oleg Dubinskiy [Sun, 26 Apr 2020 17:43:53 +0000 (20:43 +0300)]
[SHLWAPI] Add version limit for export from NT 5.1 to NT5.2, because it was dropped since NT6
Co-Authored-By: Serge Gautherie <32623169+SergeGautherie@users.noreply.github.com>
Oleg Dubinskiy [Sun, 26 Apr 2020 13:21:46 +0000 (16:21 +0300)]
[SHLWAPI] Improve SHEvaluateSystemCommandTemplate export CORE-14742
Hermès Bélusca-Maïto [Sun, 26 Apr 2020 17:10:48 +0000 (19:10 +0200)]
[WIN32SS] Fix formatting only.
Victor Perevertkin [Sun, 26 Apr 2020 16:50:44 +0000 (19:50 +0300)]
[MEDIA][CMAKE] Create add_driver_inf cmake function
*.inf files for drivers can now be placed along with the driver code
Serge Gautherie [Fri, 24 Apr 2020 02:18:48 +0000 (04:18 +0200)]
[THEMES] Update now-redirected 'http' and 'reactos.org' URLs
Mohamed Mediouni [Fri, 31 May 2019 21:42:53 +0000 (23:42 +0200)]
[CRT] Implement __chkstk function for ARM (#1595)
Incoming r4 contains the number of dwords to allocate, converting to bytes then return.
This makes ReactOS applications compiled for ARM running on true ARM Windows.
Reference: https://github.com/wine-mirror/wine/commit/
2b095beace7b457586bd33b3b1c81df116215193
Mohamed Mediouni [Sat, 1 Jun 2019 10:51:37 +0000 (12:51 +0200)]
[CRT] ARM & ARM64 Windows do not have initenv in their CRTs (#1597)
Native CRT on ARM & ARM64 Windows doesn't have these functions.
For compatibility, it's mandatory to not have it at all. Otherwise,
ARM executables built for ReactOS do not run on true ARM Windows.
Consider doing full sync with mingw-w64 CRT in future.
Sylvain Deverre [Sun, 26 Apr 2020 16:40:47 +0000 (18:40 +0200)]
[LWIP] Use tcp_close when both shut_rx and shut_tx are set. Fixes CORE-16868 (#2582)
Serge Gautherie [Thu, 27 Dec 2018 16:37:54 +0000 (17:37 +0100)]
[USER32] EDIT_WM_KillFocus(): Restore Wine code, #ifdef'ed out
Use '#ifdef __REACTOS__' for WINESYNC'ed code.
Partially reverts
71ab0b5d4cb7fe00e0047308a18ae48c734266b9.
CORE-10266
Serge Gautherie [Thu, 24 Oct 2019 21:40:25 +0000 (23:40 +0200)]
[NTOS:KE] KiTrap0DHandler(): Fix a copypasta
Addendum to r45038.
Andreas Maier [Sat, 11 Apr 2020 21:32:04 +0000 (23:32 +0200)]
[MSV1_0] Create stubs for SECPKG_FUNCTION_TABLE (SpLsaModeInitialize)
This commit fixes a bug too.
Old code of SpLsaModeInitialze returns a pointer to a local variable (SECPKG_FUNCTION_TABLE).
Serge Gautherie [Sun, 26 Apr 2020 15:23:13 +0000 (17:23 +0200)]
[RPCRT4] Fully WineSync spec file. CORE-16441 (#2494)
* [RPCRT4] Export NdrServerCallAll stub
Addendum to
6feb8748d300347f848eee8436845a1f0c67d3aa.
Import rest of
https://source.winehq.org/git/wine.git/commit/
e54224e88c9514b7a1293d2f5b9471effbb3358f
With thanks to Hermès B., who noticed it is 64bit only.
CORE-16441
* [RPCRT4] Fix NdrServerContextMarshall spec file entry
Addendum to
6feb8748d300347f848eee8436845a1f0c67d3aa.
Import
https://source.winehq.org/git/wine.git/commit/
660ee356e9cc0478b806949e4fdbc9f0588468db
CORE-16441
* [RPCRT4] Fix RpcNetworkIsProtseqValid[AW] spec file entries
Cherry-pick
https://source.winehq.org/git/wine.git/commit/
6127c688eaa68b6adcc06f44bf41cb6f0c608d77
Hermès Bélusca-Maïto [Thu, 16 Apr 2020 17:09:35 +0000 (19:09 +0200)]
[SDK] Update sdkddkver.h with newer NTDDI_WIN10_* versioning defines.
Mark Jansen [Sun, 26 Apr 2020 15:01:08 +0000 (17:01 +0200)]
[USETUP] Fix the build for msvc
Victor Perevertkin [Sun, 26 Apr 2020 14:58:52 +0000 (17:58 +0300)]
[CODEOWNERS] Add more language groups to translations auto-assignment
Adam Stachowicz [Sun, 26 Apr 2020 14:48:46 +0000 (16:48 +0200)]
[INTL.CPL] Polish translation update (#2665)
After PR #2654
Katayama Hirofumi MZ [Sun, 26 Apr 2020 13:06:19 +0000 (22:06 +0900)]
[SHELL32] Implement VK_DELETE on SHBrowseForFolder (#2661)
Enable Del/Delete key to delete the selected folder in "Browse for Folder" dialog.
You can use https://jira.reactos.org/secure/attachment/40118/getfolder.zip as a test program.
CORE-7592
Hervé Poussineau [Sat, 25 Apr 2020 22:23:13 +0000 (00:23 +0200)]
[USETUP] Move loading of requested font from blue.sys to usetup
Hervé Poussineau [Mon, 13 May 2019 21:28:19 +0000 (23:28 +0200)]
[USETUP] Support a custom way to extract files for cabinet files
This will be used to extract files from cabinet to memory, instead of
writing them to disk.
Hervé Poussineau [Mon, 13 May 2019 21:22:20 +0000 (23:22 +0200)]
[USETUP] Optimize font loading
Reload a new font only if codepage changed.
Hervé Poussineau [Sat, 25 Apr 2020 19:34:16 +0000 (21:34 +0200)]
[BLUE] Add an IOCTL to directly choose which font to use (instead of codepage)
Mark Jansen [Sat, 18 Apr 2020 11:53:02 +0000 (13:53 +0200)]
[RTL] Implement LdrpRecordUnloadEvent
Mark Jansen [Sat, 18 Apr 2020 11:51:37 +0000 (13:51 +0200)]
[NTDLL_APITEST] Add a test for RtlGetUnloadEventTrace
Mark Jansen [Sat, 18 Apr 2020 11:50:50 +0000 (13:50 +0200)]
[NDK] Fix RTL_UNLOAD_EVENT_TRACE_NUMBER
William Kent [Sun, 26 Apr 2020 12:31:16 +0000 (08:31 -0400)]
[FONTS] Add Selawik as a substitution for Segoe UI
Serge Gautherie [Thu, 13 Feb 2020 02:25:42 +0000 (03:25 +0100)]
[SHELL32] DoGetProductType(): Use RegGetValueW()
instead of RegQueryValueExW(), to enforce a null terminator.
Addendum to
9f4e8ef25b53d27494efab569288452fbaa1cdfa.
Serge Gautherie [Thu, 13 Feb 2020 02:25:42 +0000 (03:25 +0100)]
[ROSPERF] PrintOSVersion(): Fix RegQueryValueExW() use
Bișoc George [Sun, 26 Apr 2020 12:14:17 +0000 (14:14 +0200)]
[UTILMAN] Properly annotate some variables (#2561)
Previously the code had a mixture of 'sz', 'wsz', 'lp' and 'lpwsz' Hungarian annotation prefixes which could bring confusions about the nature of the annotated variables. From now on all of these variables have a well defined annotation. Furthermore, add a missing argument annotation to LaunchProcess().
Serge Gautherie [Fri, 28 Feb 2020 12:14:36 +0000 (13:14 +0100)]
[NDK][NTDLL] RtlGetNtProductType(): Update it with SAL2 annotations
郑 [Sun, 26 Apr 2020 12:00:02 +0000 (20:00 +0800)]
Update zh-CN.rc (#2522)
Saibamen [Sun, 26 Apr 2020 11:56:46 +0000 (13:56 +0200)]
[SHIMGVW] Update Polish translation (#2666)
After PR #2606
Saibamen [Sun, 26 Apr 2020 11:56:17 +0000 (13:56 +0200)]
[DESK.CPL] Update Polish translation (#2664)
After PR #2591
Mark Jansen [Tue, 21 Apr 2020 20:10:49 +0000 (22:10 +0200)]
[NTDLL_APITEST] Add test for RTL_DEBUG_QUERY_MODULES
Mark Jansen [Thu, 16 Apr 2020 17:59:53 +0000 (19:59 +0200)]
[RTL] Partially implement RtlCreateQueryDebugBuffer and RtlDestroyQueryDebugBuffer
Mark Jansen [Thu, 16 Apr 2020 17:58:07 +0000 (19:58 +0200)]
[NTDLL_APITEST] Add minimal test for RTL_DEBUG_INFORMATION allocation
Mark Jansen [Thu, 16 Apr 2020 17:58:48 +0000 (19:58 +0200)]
[NDK] Fix RTL_DEBUG_INFORMATION definition
Mark Jansen [Wed, 15 Apr 2020 21:34:14 +0000 (23:34 +0200)]
[NDK] Fix BackTrace size in RTL_PROCESS_BACKTRACE_INFORMATION
Mark Jansen [Mon, 13 Apr 2020 21:37:25 +0000 (23:37 +0200)]
[NDK] Add STACK_TRACE_DATABASE definition
Mark Jansen [Wed, 15 Apr 2020 19:25:01 +0000 (21:25 +0200)]
[PSDK] Add argument names + sal annotations
Bișoc George [Sun, 26 Apr 2020 11:14:44 +0000 (13:14 +0200)]
[UTILMAN] Add Romanian and Italian translations (#2562)
Jose Carlos Jesus [Sun, 26 Apr 2020 11:12:28 +0000 (12:12 +0100)]
[BOOTDATA] Portuguese translation for EVENT_LABEL and DESKTOP_SCHEME (#2631)
Saibamen [Sun, 26 Apr 2020 11:07:25 +0000 (13:07 +0200)]
[POWERCFG] Update polish translation (#2663)
Update after PR #2593
Jose Carlos Jesus [Sun, 26 Apr 2020 11:06:34 +0000 (12:06 +0100)]
[CPL] Portuguese translation update (#2629)
Portuguese translation for:
cpl/input, cpl/hotplug, cpl/liccpa, cpl/telephon, cpl/timedate
Victor Perevertkin [Sun, 26 Apr 2020 10:36:33 +0000 (13:36 +0300)]
[IEXPLORE] Make duckduckgo our default search engine
Katayama Hirofumi MZ [Sun, 26 Apr 2020 03:30:58 +0000 (12:30 +0900)]
[SHELL32] Update name in CDefView::LV_RenameItems
Bișoc George [Sun, 26 Apr 2020 10:18:41 +0000 (12:18 +0200)]
[CRT_APITEST] Add testcase for mbtowc() (#2652)
Kyle Katarn [Sun, 26 Apr 2020 09:54:42 +0000 (11:54 +0200)]
[NETID] fr-fr translation fix and component size (#2586)
Kyle Katarn [Sun, 26 Apr 2020 08:20:22 +0000 (10:20 +0200)]
[POWERCFG] Power Scheme fix as per CORE-16893 (#2593)
Related to CORE-16900
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Katayama Hirofumi MZ [Sun, 26 Apr 2020 00:07:14 +0000 (09:07 +0900)]
[MSPAINT] Add to recent documents (#2651)
Add to recent documents upon file save. CORE-3588
Katayama Hirofumi MZ [Sun, 26 Apr 2020 00:06:39 +0000 (09:06 +0900)]
[NOTEPAD] Add to recent documents (#2649)
Add to recent documents upon file save. CORE-3588
Robert Naumann [Thu, 23 Apr 2020 17:28:14 +0000 (19:28 +0200)]
[CONTROL] Fix hang while calling RunControlPanel() CORE-11373
- based on a patch by Jira user "wimh"
- also addressed Hermes' suggestion to use ARRAYSIZE instead of MAX_PATH
Kyle Katarn [Sat, 25 Apr 2020 16:34:41 +0000 (18:34 +0200)]
[DESK][THEMEUI] Update French translation (#2591)
Co-authored-by: Sylvain Deverre <deverre.sylv@gmail.com>
Kyle Katarn [Sat, 25 Apr 2020 08:41:01 +0000 (10:41 +0200)]
[COMDLG32][REGEDIT] Fix display problems (CORE-16890) (#2638)
Kyle Katarn [Sat, 25 Apr 2020 08:38:35 +0000 (10:38 +0200)]
[SHELL32] Improve french translations
Katayama Hirofumi MZ [Sat, 25 Apr 2020 02:01:20 +0000 (11:01 +0900)]
[SHELL32] Command 'start C:' should open 'C:\' (#2642)
Based on JIRA user amaneureka's idea.
In SHELL_execute function, add a backslash for Drive "C:", "D:" or "E:" etc.
CORE-16384
Joachim Henze [Fri, 24 Apr 2020 20:22:22 +0000 (22:22 +0200)]
[SDK] Raise KERNEL_VERSION_PATCH_LEVEL to 15 in the version.cmake
Kyle Katarn [Fri, 24 Apr 2020 16:28:38 +0000 (18:28 +0200)]
[SYSDM] Virtual Memory panel : improve settings for pagefile + fr-fr translation
* Fix for CORE-12486
Co-Authored-By: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Co-authored-by: Sylvain Deverre <deverre.sylv@gmail.com>
Kyle Katarn [Fri, 24 Apr 2020 14:27:07 +0000 (16:27 +0200)]
[INTL] Translate hardcoded string (#2654)
CORE-16951
Thomas Faber [Fri, 24 Apr 2020 12:56:26 +0000 (14:56 +0200)]
[WINDOWSCODECS] Use upstream Wine fix for 4bps BGRA TIFF. CORE-16796
Import Wine commits by Dmitry Timoshkov:
*
0cd8502b49 windowscodecs: Add support for 4bps RGBA format to TIFF decoder.
*
962bb99352 windowscodecs/tests: Add a separate test for 4bps BGRA TIFF format.
Thomas Faber [Fri, 24 Apr 2020 07:25:23 +0000 (09:25 +0200)]
[LIBXSLT] Update to version 1.1.34. CORE-16952
Thomas Faber [Wed, 22 Apr 2020 21:32:51 +0000 (23:32 +0200)]
[LIBXML2] Update to version 2.9.10. CORE-16952
Timo Kreuzer [Sun, 28 Jan 2018 22:44:28 +0000 (23:44 +0100)]
[NTOS:IO] Fix parsing of resource lists
Also add a hack to avoid failing on now occurring resource conflict detection and try to fix at least one resource in ACPI hal.
CORE-10146
CORE-12892
Victor Perevertkin [Fri, 24 Apr 2020 09:44:05 +0000 (12:44 +0300)]
[GITIGNORE] Remove "build" folder, which discards some commited files
Katayama Hirofumi MZ [Fri, 24 Apr 2020 08:45:43 +0000 (17:45 +0900)]
[SDK][RTL][NTDLL_APITEST] Add RtlMultipleAllocateHeap and RtlMultipleFreeHeap (#2641)
- Add RtlMultipleAllocateHeap and RtlMultipleFreeHeap functions (2k3+).
- Add a testcase for two functions.
CORE-12026
Kyle Katarn [Fri, 24 Apr 2020 06:38:41 +0000 (08:38 +0200)]
[SHELL32] Fix for incorrect init of hide/show hidden files & folders
Stanislav Motylkov [Thu, 23 Apr 2020 23:48:22 +0000 (02:48 +0300)]
[INTL] Fix build (#2612)
Addendum to
76dd2fc.
Serge Gautherie [Sat, 18 Apr 2020 14:40:42 +0000 (16:40 +0200)]
[REACTOS] Remove some ending spaces
Serge Gautherie [Sat, 18 Apr 2020 14:40:42 +0000 (16:40 +0200)]
[REACTOS] Update some external URLs
Serge Gautherie [Thu, 23 Apr 2020 23:30:40 +0000 (01:30 +0200)]
[README] Update now-redirected 'reactos.org' URLs (#2633)
Mas Ahmad Muhammad [Thu, 23 Apr 2020 23:24:32 +0000 (06:24 +0700)]
[TRANSLATION] Update Indonesian translation for CPL applets (#2612)
Signed-off-by: Mas Ahmad Muhammad <m.charly81@gmail.com>
Sylvain Deverre [Thu, 23 Apr 2020 18:11:10 +0000 (20:11 +0200)]
[NETKVM] Fix GCC build
Kyle Katarn [Thu, 23 Apr 2020 17:58:32 +0000 (19:58 +0200)]
[SENDMAIL] Add french translation for "Send To" shell extension
James Tabor [Thu, 23 Apr 2020 14:33:32 +0000 (09:33 -0500)]
[NETKVM] Fix Build
Nguyen Trung Khanh [Thu, 5 Mar 2020 03:58:56 +0000 (10:58 +0700)]
[NETKVM] Import NetKVM network adapter driver by Red Hat
CORE-15841
Katayama Hirofumi MZ [Thu, 23 Apr 2020 13:02:41 +0000 (22:02 +0900)]
[NTGDI][FREETYPE] Return non-zero gm.gmBlackBoxX/Y (#2643)
In return of GetGlyphOutline function call, gm.gmBlackBoxX and gm.gmBlackBoxY must be non-zero to avoid Division by Zero. At epilogue of ftGdiGetGlyphOutline, we adjust the values. CORE-15949
Serge Gautherie [Wed, 22 Apr 2020 19:39:25 +0000 (21:39 +0200)]
[EXPLORER] Update now-redirected 'http' and 'reactos.org' URLs
Serge Gautherie [Wed, 22 Apr 2020 20:03:42 +0000 (22:03 +0200)]
[ACPPAGE] Update now-redirected 'reactos.org' URLs
Serge Gautherie [Wed, 22 Apr 2020 20:03:42 +0000 (22:03 +0200)]
[SYSDM] Update now-redirected 'http' and 'reactos.org' URLs
Katayama Hirofumi MZ [Thu, 23 Apr 2020 07:03:55 +0000 (16:03 +0900)]
[ZIPFLDR] Improve Japanese translation
Katayama Hirofumi MZ [Thu, 23 Apr 2020 06:59:32 +0000 (15:59 +0900)]
[SENDMAIL] Improve Japanese IDS_SHORTCUT translation