Katayama Hirofumi MZ [Sat, 15 Oct 2022 12:00:13 +0000 (21:00 +0900)]
[USER32][NTUSER] Fill by white in DrawFrameControl:DFC_MENU (#4779)
DrawFrameControl:DFC_MENU draws the monochrome image of menu arrow or checkmark. However, the function didn't draw the entire rectangle correctly when the rectangle was not a square. CORE-18417
Mark Jansen [Sat, 15 Oct 2022 09:09:25 +0000 (11:09 +0200)]
[SHELL32] Fix using the wrong context menu
Katayama Hirofumi MZ [Sat, 15 Oct 2022 03:27:32 +0000 (12:27 +0900)]
[RAPPS] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Fri, 14 Oct 2022 23:13:22 +0000 (08:13 +0900)]
[INCLUDE] immdev.h: Adapt INPUTCONTEXTDX to C++
CORE-11700
Mark Jansen [Fri, 14 Oct 2022 22:01:45 +0000 (00:01 +0200)]
[SHELL32] Remove unused function
Mark Jansen [Thu, 1 Sep 2022 19:55:04 +0000 (21:55 +0200)]
[SHELL32] CFolderItemVerb: Zero-initialize output parameters
Mark Jansen [Thu, 1 Sep 2022 19:54:31 +0000 (21:54 +0200)]
[SHELL32] Fix CDefaultContextMenu DFM_MERGECONTEXTMENU handling
Mark Jansen [Thu, 22 Sep 2022 17:27:33 +0000 (19:27 +0200)]
[SHELL32] Show file / drive properties at the position where the mouse was.
CORE-18386
Katayama Hirofumi MZ [Thu, 13 Oct 2022 22:17:24 +0000 (07:17 +0900)]
[INF][INTL.INF][SETUPLIB] We don't have preinstalled IMEs (#4774)
Don't write the preinstalled IME keyboard layouts in Chinese, Japanese and Korean (CJK). CORE-18506
Robert Naumann [Thu, 13 Oct 2022 19:30:22 +0000 (21:30 +0200)]
[WMIC] Update German translation
Thamatip Chitpong [Thu, 13 Oct 2022 14:52:14 +0000 (21:52 +0700)]
[SYSDM] Improve license dialog icon (#4773)
- Use `mimetypes/application-certificate` icon
from Tango Icon Theme 0.8.90 instead of `IDI_CPLSYSTEM`
- Set large icon correctly
- Add NULL check for DestroyIcon
- Minor code formatting
Katayama Hirofumi MZ [Thu, 13 Oct 2022 07:01:02 +0000 (16:01 +0900)]
[KBSWITCH][IMM32][USER32] Consider keyboard layout corner cases
Considering invalid Keyboard Layout registry entries.
CORE-11700
Katayama Hirofumi MZ [Thu, 13 Oct 2022 03:08:02 +0000 (12:08 +0900)]
[IMM32] Silence CtfImmDispatchDefImeMessage's fixme
Too noisy. CORE-11700
Katayama Hirofumi MZ [Thu, 13 Oct 2022 02:07:03 +0000 (11:07 +0900)]
[BROWSEUI] Follow-up of
2e67c18 (#4767); Also check 'MenuText'
CORE-18394
Katayama Hirofumi MZ [Wed, 12 Oct 2022 22:14:24 +0000 (07:14 +0900)]
[IMM32] Implement Imm32ImeNonImeToggle (#4769)
- Rename Imm32ImeNonImeToggle as Imm32CImeNonImeToggle (Win: CIMENonIMEToggle).
- Add Imm32ImeNonImeToggle (Win: IMENonIMEToggle) function.
- Improve IME hot-key functions.
CORE-11700
Jose Carlos Jesus [Fri, 16 Sep 2022 15:50:27 +0000 (16:50 +0100)]
[COMCTL32] Don't hardcode dwCaretWidth parameter while calling CreateCaret
Also replace 0 with NULL for the second argument of the function call.
CORE-18151
Jose Carlos Jesus [Fri, 16 Sep 2022 15:40:01 +0000 (16:40 +0100)]
[COMCTL32] Read caret width from registry
Add caret width value to EDITSTATE structure.
To keep the same behavior as Windows Server 2003,
we need to update dwCaretWidth when EDIT_WM_SetFocus is called.
CORE-18151
Jose Carlos Jesus [Fri, 2 Sep 2022 18:50:11 +0000 (19:50 +0100)]
[NTUSER] Call SpiSetDWord when processing SPI_SETCARETWIDTH message
This corresponds to REG_DWORD type of CaretWidth value.
CORE-18151
Hermès Bélusca-Maïto [Mon, 10 Oct 2022 21:12:05 +0000 (23:12 +0200)]
[WINDOWSX.H] Make header compatible with MS PSDK + Add missing original license. (#4768)
To hypothetical future sync'ers: If you ever try to sync this file with
MinGW-w64, please be extremely careful to port all the fixes (including
x64-compatible casting fixes, missing definitions, etc.) that have been
brought to this file along the years by your dear ReactOS colleagues.
Hermès Bélusca-Maïto [Mon, 10 Oct 2022 20:59:46 +0000 (22:59 +0200)]
[WINDOWSX.H] Fix some x64 incompatibilities. (#4768)
Hervé Poussineau [Tue, 11 Oct 2022 16:56:04 +0000 (18:56 +0200)]
[WIN32SS:ENG] Call display mouse functions only when using hardware pointer
Otherwise, use software pointer functions.
This fixes graphical glitches on cursor change, when the display driver
provides accelerated pointer functions (DrvSetPointerShape/DrvMovePointer),
but refuses to handle a certain cursor.
These graphical glitches may be reproduced:
- by using Voodoo driver SFFT 1.9
- by using framebuf_new.dll instead of framebuf.dll
- by using the panning driver (setting DefaultSettings.XPanning and
DefaultSettings.YPanning in registry)
Stanislav Motylkov [Tue, 11 Oct 2022 16:32:12 +0000 (19:32 +0300)]
[RAPPS] Fix inconsistencies in the translations
- Fix truncated dialogs
- Fix element positions
- Fix element misc flags
- Also uniform resource file headers per Coding Style
Addendum to
e3fdbe5806c,
1866b89100c, and
9186a358da0.
CORE-18497
Katayama Hirofumi MZ [Tue, 11 Oct 2022 03:06:51 +0000 (12:06 +0900)]
[IMM32] Follow-up of
deb4f4e; Add comments
CORE-11700
Katayama Hirofumi MZ [Mon, 10 Oct 2022 22:39:40 +0000 (07:39 +0900)]
[NTOSKRNL] Revert
53ac8da and use UNIMPLEMENTED_DBGBREAK()
Stanislav Motylkov [Mon, 10 Oct 2022 21:46:14 +0000 (00:46 +0300)]
[BROWSEUI] Update Russian (ru-RU) translation
Addendum to
2e67c18d. CORE-18394
Katayama Hirofumi MZ [Mon, 10 Oct 2022 21:15:28 +0000 (06:15 +0900)]
[BROWSEUI][INCLUDE] Localize 'Address' on CBandSiteMenu (#4767)
- Add IDS_ADDRESSMENUTEXT resource string (whose ID matchs the string of addressband.rgs).
- Add SHLoadRegUIStringA/W function prototype to <shlwapi_undoc.h>.
- Use SHLoadRegUIStringW to load MenuTextPUI.
CORE-18394
Stanislav Motylkov [Sat, 14 Apr 2018 23:04:48 +0000 (02:04 +0300)]
[DESK] Implement dialog to manipulate desktop icons (#4766)
For now only add ability to show or hide desktop icons.
CORE-8427
Stanislav Motylkov [Fri, 7 Oct 2022 01:18:28 +0000 (04:18 +0300)]
[PSDK] Add some missing Shell State Flags to shlobj.h
See https://docs.microsoft.com/en-us/windows/win32/shell/ssf-constants
CORE-8427
Peter Meerwald-Stadler [Wed, 5 Oct 2022 11:38:54 +0000 (13:38 +0200)]
[ZLIB] Restore 'uncrypt' functionality in minizip (using #ifdef REACTOS)
CORE-18339
Peter Meerwald-Stadler [Wed, 5 Oct 2022 11:35:59 +0000 (13:35 +0200)]
[ZLIB] Update to v1.2.12. CORE-18339
Upstream commit
21767c654d31d2dccdde4330529
Katayama Hirofumi MZ [Mon, 10 Oct 2022 06:50:13 +0000 (15:50 +0900)]
[IMM32] Add ImmGetAppCompatFlags and epilogue of ImmProcessKey
CORE-11700
Katayama Hirofumi MZ [Mon, 10 Oct 2022 05:58:22 +0000 (14:58 +0900)]
[USERINIT] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Mon, 10 Oct 2022 00:33:08 +0000 (09:33 +0900)]
[NTOSKRNL] Write 'if (var) ASSERT(FALSE);' as 'ASSERT(!var);'
Based on Serge Gautherie's patch.
CORE-13216
Katayama Hirofumi MZ [Sun, 9 Oct 2022 23:47:24 +0000 (08:47 +0900)]
[SHELL32] DestroyMenu on m_pShellMenu->SetMenu failure
CORE-13194
Katayama Hirofumi MZ [Sun, 9 Oct 2022 23:45:04 +0000 (08:45 +0900)]
[SHELL32] De-select m_marlett on CMenuToolbarBase::OnCustomDraw
CORE-13194
Stanislav Motylkov [Sun, 9 Oct 2022 15:12:02 +0000 (18:12 +0300)]
[SYSDM] Fix element positions and general consistency
Stanislav Motylkov [Sun, 9 Oct 2022 13:40:28 +0000 (16:40 +0300)]
[NETPLWIZ] Add Russian (ru-RU) translation
Andrei Miloiu [Sun, 9 Oct 2022 11:00:20 +0000 (14:00 +0300)]
[TRANSLATION] Big Romanian (ro-RO) translation update - part 1 (#4701)
- [CALC] Improve Romanian (ro-RO) translation
- [SOLITAIRE] Improve Romanian (ro-RO) translation
- [MSPAINT] Improve Romanian (ro-RO) translation
- [MSTSC] Improve Romanian (ro-RO) translation
- [SNDVOL32] Improve Romanian (ro-RO) translation
- [REACTOS] Improve Romanian (ro-RO) translation
- [USETUP] Improve Romanian (ro-RO) translation
- [DESK] Improve Romanian (ro-RO) translation
- [INPUT] Improve Romanian (ro-RO) translation
- [INTL] Improve Romanian (ro-RO) translation
- [JOY] Improve Romanian (ro-RO) translation
- [MMSYS] Improve Romanian (ro-RO) translation
- [POWERCFG] Improve Romanian (ro-RO) translation
- [SYSDM] Improve Romanian (ro-RO) translation
- [ACPPAGE] Improve Romanian (ro-RO) translation
- [DESKADP] Improve Romanian (ro-RO) translation
- [MYDOCS] Add Romanian (ro-RO) translation
- [NETPLWIZ] Add Romanian (ro-RO) translation
- [NTOBJSHEX] Improve Romanian (ro-RO) translation
- [SENDMAIL] Add Romanian (ro-RO) translation
- [ZIPFLDR] Improve Romanian (ro-RO) translation
- [JSCRIPT] Improve Romanian (ro-RO) translation
- [MSGINA] Improve Romanian (ro-RO) translation
- [SYSSETUP] Improve Romanian (ro-RO) translation
- [MC] Add Romanian (ro-RO) translation
Reviewed-by: Ștefan Fulea <stefan.fulea@mail.com>
Reviewed-by: Joachim Henze <joachim.henze@reactos.org>
Reviewed-by: George Bișoc <george.bisoc@reactos.org>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Robert Naumann [Sat, 8 Oct 2022 11:19:28 +0000 (13:19 +0200)]
[MORE] Update German translation (#4761)
Robert Naumann [Sat, 8 Oct 2022 11:19:06 +0000 (13:19 +0200)]
[FC] Add German translation (#4760)
Robert Naumann [Sat, 8 Oct 2022 11:18:18 +0000 (13:18 +0200)]
[GIT] Add .DS_Store files to .gitignore (#4762)
When working on macOS, the system creates a .DS_Store file in every accessed directory. They are marked as new files
in git, which is very annoying. This change will exclude these files.
Katayama Hirofumi MZ [Fri, 7 Oct 2022 23:47:22 +0000 (08:47 +0900)]
[USETUP] Clear underlined text correctly
CORE-18446, CORE-5052
Katayama Hirofumi MZ [Fri, 7 Oct 2022 23:22:24 +0000 (08:22 +0900)]
[USETUP][VGAFONTS] Improve Japanese character display
- Modify media/vgafonts/932-8x8.bin Japanese VGA font.
- Use special codepoints of new font 932-8x8.bin.
Appendum of #4750. Line connection bug still remains.
CORE-5052
Katayama Hirofumi MZ [Fri, 7 Oct 2022 22:46:00 +0000 (07:46 +0900)]
[USETUP][VGAFONTS] Improve Romanian character display (#4750)
- Modify media/vgafonts/28606-8x8.bin Romanian VGA font to display special characters.
- Add global variables for special characters "Char..." for Romanian VGA font.
- Toggle the global variables "Char..." in SetConsoleCodePage function.
CORE-18446
Jose Carlos Jesus [Thu, 6 Oct 2022 19:48:38 +0000 (20:48 +0100)]
[TRANSLATION] Improve Portuguese (pt-PT) translation (#4758)
- [WINNLS] Update pt-PT translation
- [NETCFGX] Update pt-PT translation
- [SHELL32] Update pt-PT translation
Mas Ahmad Muhammad [Thu, 6 Oct 2022 19:44:46 +0000 (02:44 +0700)]
[TRANSLATION] Update Indonesian (id-ID) translation (#4585)
- [WRITE] Add Indonesian (id-ID) translation
- [WINLOGON] Update Indonesian (id-ID) translation
Hermès Bélusca-Maïto [Thu, 6 Oct 2022 17:55:17 +0000 (19:55 +0200)]
[FC] Add missing period at the end of the usage sentence.
Except for German as it's going to be handled by PR #4760.
Hermès Bélusca-Maïto [Thu, 6 Oct 2022 13:21:57 +0000 (15:21 +0200)]
[KERNEL32] Fix DisableThreadLibraryCalls function argument type in spec file.
+ Remove space between function name and parentheses there too.
Hermès Bélusca-Maïto [Thu, 6 Oct 2022 13:17:24 +0000 (15:17 +0200)]
[ACLEDIT][MSIMG32][HIDCLASS] Fix DLL-main function argument type in spec file.
Hermès Bélusca-Maïto [Wed, 5 Oct 2022 21:19:48 +0000 (23:19 +0200)]
[IMM32][LPK] Remove msvcrt dependency; fix entrypoint. (#4759)
Hermès Bélusca-Maïto [Wed, 5 Oct 2022 21:15:29 +0000 (23:15 +0200)]
[GDI32][USER32] Order the set_module_type arguments the usual way ("UNICODE" before the entrypoint).
+ Harmonize the entrypoints as well.
Hermès Bélusca-Maïto [Tue, 4 Oct 2022 00:15:22 +0000 (02:15 +0200)]
[EVENTVWR] Fix settings loading. Remove usage of Rtl functions. Use Win32 CRT assert. (#4752)
- Don't create the settings registry key when trying to load them.
Defer its creation when saving the settings.
- Use more restricted access rights when opening/creating the key.
- Ensure read and written string settings are NULL-terminated.
- Use the Win32 CRT assert so that if an assertion fails we get a
message on the screen, not via the kernel debugger.
Stanislav Motylkov [Wed, 5 Oct 2022 17:08:07 +0000 (20:08 +0300)]
[KEYBOARD] Fix problems in our keyboard layouts
- Fix failing API tests added in
6aacfa93 and
c1c12793:
'KbdLayout' test: All failures fixed now
'VirtualKey' test: One of two failures fixed
- This also should fix related problems with "F17" shortcut key
in the menu items of some programs.
CORE-17906 CORE-3903
Stanislav Motylkov [Wed, 5 Oct 2022 00:36:11 +0000 (03:36 +0300)]
[USER32_APITEST] Add tests for Keyboard Layouts
CORE-17906
Ratin Gao [Wed, 5 Oct 2022 12:31:39 +0000 (20:31 +0800)]
[RTL][NTDLL_APITEST] Implement RtlRemovePrivileges (#4614)
Vista+ API, compile-time guarded.
Add tests for it.
Hermès Bélusca-Maïto [Fri, 30 Sep 2022 18:40:43 +0000 (20:40 +0200)]
[WINLOGON] Protect function calls to '3rd-party' DLLs by SEH. (#4743)
This includes:
- Notification dll calling in CallNotificationDll().
- winmm.dll API calling (e.g. PlaySound) in PlaySoundRoutine().
Also:
- Fix dwKeyName usage in RegEnumKeyExW() specifying a number of *characters*.
Stanislav Motylkov [Mon, 3 Oct 2022 14:34:10 +0000 (17:34 +0300)]
[DESK] Fix screensaver preview drawing
Use window subclassing to override WM_PAINT message handling
and use RedrawWindow function along with WS_CLIPCHILDREN style
for the parent window in order to preserve screensaver drawing.
CORE-15929
Stanislav Motylkov [Mon, 3 Oct 2022 14:32:42 +0000 (17:32 +0300)]
[DESK] Show screensaver preview in a monitor
Reuse the same monitor bitmap for the top preview control.
Also use Windows-compatible class name for it.
CORE-10606
Stanislav Motylkov [Tue, 4 Oct 2022 18:14:31 +0000 (21:14 +0300)]
[REACTOS][CPL] Coding style fixes only
Hermès Bélusca-Maïto [Mon, 3 Oct 2022 00:29:49 +0000 (02:29 +0200)]
[EVENTVWR] Improve behaviour on event item selection. (#4746)
CORE-18438
- Each event detail control stores its own "current" item index, so
that there can be different event detail dialogs showing different
events concurrently (half-plemented; this is a Win7-like feature).
As such, give the index of the selected event item when sending
the EVT_DISPLAY message, instead of having the details dialog
retrieve everytime by itself the current selected item (that may
change in-between calls, and can trigger the "No Items in ListView"
error).
- When pressing "Prev"/"Next" buttons, detect whether we already are
at the top/bottom of the event log, and if so, prompt the user to
continue around.
Clear up any selected event in the list, before selecting the new
one. (Note: the event list supports multiple selection, for future
functionality.)
Katayama Hirofumi MZ [Tue, 4 Oct 2022 00:40:43 +0000 (09:40 +0900)]
[NTUSER][USER32] Initial support of WS_EX_NOACTIVATE flag (#4731)
WS_EX_NOACTIVATE flag forbids the window to be activated. CORE-18417
Doug Lyons [Mon, 3 Oct 2022 22:26:02 +0000 (17:26 -0500)]
[NTUSER] Fix 'Trying to link windows to itself' (#4478) CORE-18132
Fix 'Trying to link windows to itself' on DestroyWindow. Patch by I_Kill_Bugs.
This fixes a potential BSOD 0x50 observable in the app Localizer Editor"
Hermès Bélusca-Maïto [Mon, 3 Oct 2022 00:26:20 +0000 (02:26 +0200)]
[EVENTVWR] Simplify some duplicated code. (#4745)
Hermès Bélusca-Maïto [Sun, 2 Oct 2022 16:22:43 +0000 (18:22 +0200)]
[EVENTVWR] Update file headers.
Stanislav Motylkov [Mon, 3 Oct 2022 18:00:58 +0000 (21:00 +0300)]
[DESK] Fix screensaver layouts for all translations
Also remove trailing "0" for the preview static control styles.
Stanislav Motylkov [Sat, 1 Oct 2022 12:42:49 +0000 (15:42 +0300)]
[DESK] Show monitor on "Settings" page when only one monitor detected
Hide multiple monitor selection controls in this case.
Otherwise, show them when multiple monitors are detected
and hide the monitor preview bitmap.
This fixes the focus on the resolution slider when tested in Windows XP.
Also use the monitor bitmap globally, because it's used on multiple pages.
CORE-17939 CORE-10606
Stanislav Motylkov [Sat, 1 Oct 2022 11:56:01 +0000 (14:56 +0300)]
[WLANCONF] Fix getting the interface GUID value
GetInterfaceInfo returns interface name in Windows XP and 2003
in this format: `\DEVICE\TCPIP_{GUID}`.
MSDN says that the `Name` member of the `IP_ADAPTER_INDEX_MAP`
may start with '{' character on Windows Vista and later.
https://docs.microsoft.com/en-us/windows/win32/api/ipexport/ns-ipexport-ip_adapter_index_map
Change the code to support both cases. CORE-18032
Stanislav Motylkov [Sat, 1 Oct 2022 11:28:42 +0000 (14:28 +0300)]
[USER32_APITEST] Add tests for MapVirtualKeyW
For @julcar. See PR #4730 for details. CORE-17906
Mark Jansen [Sun, 18 Sep 2022 18:59:00 +0000 (20:59 +0200)]
[EXPLORER][BROWSEUI][SHELL32][NETSHELL] Fix wrong usage of CComPtr
Mark Jansen [Sun, 18 Sep 2022 18:57:38 +0000 (20:57 +0200)]
[ATL] Prohibit the use of AddRef/Release on objects inside CComPtr
This mimics what MS's CComPtr is doing:
https://learn.microsoft.com/en-us/cpp/atl/reference/ccomptrbase-class?view=msvc-170#operator_ptr
The reasoning behind this is that AddRef/Release is handled by the CComPtr,
so anyone calling that is most likely not using the CComPtr correct.
Mark Jansen [Thu, 22 Sep 2022 21:03:21 +0000 (23:03 +0200)]
[SHELL32] CDefView: Rework context menu handling
Previously, we would share one object between a multitude of options.
Now, the only two options that need to store something for later use each have their own space for it.
The context menu always cleans up after itself, the File menu does not.
CORE-18345
CORE-18361
CORE-18366
Hermès Bélusca-Maïto [Tue, 26 Apr 2022 00:40:54 +0000 (02:40 +0200)]
[ROSAPPS] Rename template filesystem to a better name.
Hermès Bélusca-Maïto [Mon, 25 Apr 2022 22:25:33 +0000 (00:25 +0200)]
[FASTFAT] And now use the MS-open-sourced fastfat_new as our official FAT12/16/32 FS driver.
Hermès Bélusca-Maïto [Fri, 30 Sep 2022 15:49:36 +0000 (17:49 +0200)]
[EXPLORER] Addendum in translation (missing indentation).
Nikolay Dimitrov [Tue, 5 Apr 2022 20:04:08 +0000 (23:04 +0300)]
[TRANSLATION] Update Bulgarian translation (#4429)
Update translations for:
Explorer, Calculator, MSPaint, MSGina, USetup.
Add translations for:
INetCPL, Crypt32, CryptUI.
Signed-off-by: Nikolay Dimitrov <delphipro@gmail.com>
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Reviewed-by: Rosen Iliev <winterhell2002@gmail.com>
Stanislav Motylkov [Thu, 29 Sep 2022 09:00:04 +0000 (12:00 +0300)]
[TRANSLATION] More Russian (ru-RU) translation fixes
Addendum to
3f411c5d.
Stanislav Motylkov [Thu, 29 Sep 2022 08:08:17 +0000 (11:08 +0300)]
[INPUT] Update Russian (ru-RU) translation
Addendum to
5f4bb73e.
Hermès Bélusca-Maïto [Thu, 29 Sep 2022 02:27:15 +0000 (04:27 +0200)]
[TRANSLATION][INPUT.CPL] Update french translation.
Hermès Bélusca-Maïto [Thu, 29 Sep 2022 02:06:17 +0000 (04:06 +0200)]
[KBSWITCH][INPUT.CPL] Correctly do the input language indicator.
Addendum to commits
5f4bb73e and
c6ccb92b.
- GetLocaleInfo() returns an int, not a bool: makes it clear in the test.
- No need to use StringCchCopy() to just initialize two chars to the
same value.
- The question about the test in https://github.com/reactos/reactos/pull/4723#discussion_r981331634
was meant to discover that CreateDIBSection() was unnecessary, since
the very original code (before commit
0991cedc) did not use it and was
working fine in that regard. The simple fix was to use GetDC(NULL).
- Use SM_CXSMICON/SM_CYSMICON metrics for the KBSWITCH indicator as well.
- Override the font size obtained from SPI_GETICONTITLELOGFONT with a
known one (allows to get a correct indicator even if the user font
is very large).
- Do the initialization in such a way that in case SPI_GETICONTITLELOGFONT
or CreateFontIndirect fails, we always fall back to the default stock
font that is ensured to always exist.
- Initialize *all* the fields of the IconInfo structure.
Katayama Hirofumi MZ [Wed, 28 Sep 2022 22:32:39 +0000 (07:32 +0900)]
[KBSWITCH] Fix keyboard indicator text and font (#4723)
- Do the same behaviour as input.dll in getting indicator text.
- Use full color DIB (device-independent bitmap) to improve icon.
- Use SPI_GETICONTITLELOGFONT for font.
CORE-10667
Katayama Hirofumi MZ [Wed, 28 Sep 2022 22:31:43 +0000 (07:31 +0900)]
[CPL][INPUT] Make the ListView a TreeView (#4726)
- Make the list a TreeView.
- Modify IDD_PROPPAGESETTINGS resource dialog for UI compatibility.
Serge Gautherie [Wed, 28 Sep 2022 19:38:35 +0000 (21:38 +0200)]
[DNSAPI] DNSRSLVR_HANDLE_bind(): Demote 1 DPRINT1() (#4733)
Addendum to
b79246c534d (0.4.14-dev-174).
CORE-18384
Serge Gautherie [Wed, 28 Sep 2022 18:38:42 +0000 (20:38 +0200)]
[DOC] 3rd Party Files.txt: Update WinBtrfs to v1.8.1 (#4732)
Addendum to
29d1938258c (0.4.15-dev-5113).
CORE-18322
Hervé Poussineau [Wed, 28 Sep 2022 16:26:44 +0000 (18:26 +0200)]
[WIN32SS] Change LDEVOBJ_bProbeAndCaptureDevmode to account for not provided fields when searching an exact mode
This fixes mode change if an application requests (for example) 640x480x32, without providing display frequency.
Johannes Obermayr [Wed, 28 Sep 2022 16:08:10 +0000 (18:08 +0200)]
[BTRFS][UBTRFS][SHELLBTRFS] Upgrade to 1.8.1 (#4729)
CORE-18322
v1.8.1 (2022-08-23):
- Fixed use-after-free when flushing
- Fixed crash when opening volume when AppLocker installed
- Compression now disabled for no-COW files, as on Linux
- Flushing now scales better on very fast drives
- Fixed small files getting padded to 4,096 bytes by lazy writer
- Added NoDataCOW registry option
Hervé Poussineau [Mon, 26 Sep 2022 21:41:47 +0000 (23:41 +0200)]
[FRAMEBUF] Implement required DirectDraw functions
However, do not support any optional callback.
dxdiag now accepts to run DirectDraw tests.
Hervé Poussineau [Mon, 26 Sep 2022 21:35:09 +0000 (23:35 +0200)]
[NTOS:PNP] Partially implement NtPlugPlayControl(PlugPlayControlQueryAndRemoveDevice)
CORE-12307
Hervé Poussineau [Mon, 26 Sep 2022 21:33:16 +0000 (23:33 +0200)]
[NETSHELL] Return error if disconnection failed
CORE-12307
Katayama Hirofumi MZ [Sun, 25 Sep 2022 23:07:50 +0000 (08:07 +0900)]
[NTUSER][KBSWITCH] Realize Alt+Shift keyboard switch (retry) (#4721)
Alt+Shift is a useful key combination to switch the current keyboard layout. CORE-11737
- Add ID_NEXTLAYOUT command to kbswitch.
- Send command ID_NEXTLAYOUT to kbswitch on Alt+Shift key combination in WM_SYSKEYDOWN handling of IntDefWindowProc function.
- Make IntFindWindow a non-static function.
Hermès Bélusca-Maïto [Sun, 25 Sep 2022 21:59:07 +0000 (23:59 +0200)]
[CMD] Fix build. Addendum to
67ac583b5.
Hermès Bélusca-Maïto [Sun, 25 Sep 2022 21:50:25 +0000 (23:50 +0200)]
[CMD] COPY: Always remove the read-only attribute, for MS-DOS backwards-compatibility.
Tested and compared with MS CMD.EXE when copying files within the
same directory, across directories and across drives.
This is not done for the MOVE, REN and REPLACE commands however.
CORE-18090
Serge Gautherie [Sun, 25 Sep 2022 18:35:23 +0000 (20:35 +0200)]
[BCRYPT_WINETEST] Wine Sync to
8d8936cbb6fea3cac862e059e814527f5361f48b (#208)
Import, as is, the next 2 commits from Wine:
8d8936cbb6fea3cac862e059e814527f5361f48b 2016-12-06 Bruno Jesus bcrypt/tests: Normalize all tests to use function pointers.
b5e5be13d20adff5d7b784e71c7a48fb95fde2c8 2016-12-06 Bruno Jesus bcrypt/tests: Workaround RegGetValueW not being present in XP.
These let this test load on WS03 and even WXP, too.
Notice though, that even after the change, the test does not manage to load bcrypt.dll yet on Windows XPSP3 yet, even when copying it next the test.
No functional changes.
ROSTESTS-296
Mark Jansen [Tue, 13 Sep 2022 19:35:23 +0000 (21:35 +0200)]
[ACLAYERS] Fix RtlGetVersion
Mark Jansen [Tue, 13 Sep 2022 18:46:51 +0000 (20:46 +0200)]
[MSI] Abuse SE_DynamicShim until we have proper shims integration
CORE-18362
Mark Jansen [Sun, 18 Nov 2018 22:18:13 +0000 (23:18 +0100)]
[APPHELP] Implement SE_DynamicShim
Hermès Bélusca-Maïto [Sun, 25 Sep 2022 15:52:16 +0000 (17:52 +0200)]
[BOOTDATA] hivesys.inf: Remove redundant fastfat "Start" entry.
The one in the [AddReg] section has the very same value.
Hermès Bélusca-Maïto [Sun, 25 Sep 2022 15:40:22 +0000 (17:40 +0200)]
[OPENGLCFG] Fix encoding of Japanese translation (was using Shift-JIS, now using UTF8).
Addendum to commit
555bec6a4.
Joachim Henze [Sun, 25 Sep 2022 13:48:54 +0000 (15:48 +0200)]
[EXPLORER] Cleanup after last commit (#4722)
Improves code that was added by 0.4.15-dev-5078-g
46de3a22acc
without any review yesterday.
CORE-15369
Thamatip Chitpong [Sun, 25 Sep 2022 13:46:30 +0000 (20:46 +0700)]
[MMSYS] Fix "Speaker settings" image transparency (#4716)
- Use 72x72 icon instead of a bitmap
- Use correct control position and size for IDC_SPEAKIMG
- VolumeDlgProc: Add NULL check for DestroyIcon and fix cleanup order
Addendum to
781c247b.
Andrei Miloiu [Sun, 25 Sep 2022 08:44:41 +0000 (11:44 +0300)]
[DEVMGR] Update Romanian (ro-RO) translation (#4699)
Reviewed-by: Ștefan Fulea <stefan.fulea@mail.com>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>