reactos.git
2 years ago[CRT] Fix some _CRTIMP
Timo Kreuzer [Sat, 31 Jul 2021 15:15:30 +0000 (17:15 +0200)]
[CRT] Fix some _CRTIMP

Get rid of the ugly __MINGW_IMP_SYMBOL hacks.

2 years ago[CRT] Fix CRT headers a bit
Timo Kreuzer [Wed, 28 Jul 2021 08:25:22 +0000 (10:25 +0200)]
[CRT] Fix CRT headers a bit

* Remove unused internal version of float.h
* Define _STATIC_ASSERT in crtdefs.h
* Add some missing declarations

2 years ago[CRT] Remove _fmode and _commode initialization
Timo Kreuzer [Sat, 24 Jul 2021 14:27:20 +0000 (16:27 +0200)]
[CRT] Remove _fmode and _commode initialization

This "initialization" copies the value of the local variable to the one exported from msvcrt, which is the same. Also there shouldn't be a local version of the variable in the first place.

2 years ago[IMM32] Rewrite ImmInstallIMEA (#3873)
Katayama Hirofumi MZ [Tue, 3 Aug 2021 22:32:13 +0000 (07:32 +0900)]
[IMM32] Rewrite ImmInstallIMEA (#3873)

Implementing Japanese input... CORE-11700

2 years ago[WIN32K:NTUSER] In debug builds, enable free & tail checking when creating heaps
Jérôme Gardou [Fri, 30 Jul 2021 13:59:40 +0000 (15:59 +0200)]
[WIN32K:NTUSER] In debug builds, enable free & tail checking when creating heaps

Actually catches bugs

2 years ago[WIN32K:USER] Fix potential use after free when painting child windows
Jérôme Gardou [Fri, 30 Jul 2021 13:44:57 +0000 (15:44 +0200)]
[WIN32K:USER] Fix potential use after free when painting child windows

2 years ago[WIN32K:NTUSER] Assert global user lock is held exclusively when using global & deskt...
Jérôme Gardou [Fri, 30 Jul 2021 13:42:09 +0000 (15:42 +0200)]
[WIN32K:NTUSER] Assert global user lock is held exclusively when using global & desktop heaps

They're explicitly not serialized because we count on this.

2 years ago[WIN32K:NTUSER] Make sure to hold User Global Lock before unmapping desktop heap
Jérôme Gardou [Fri, 30 Jul 2021 13:58:22 +0000 (15:58 +0200)]
[WIN32K:NTUSER] Make sure to hold User Global Lock before unmapping desktop heap

2 years ago[WIN32K:NTUSER] Allocate & free timers under global user lock
Jérôme Gardou [Fri, 30 Jul 2021 13:40:33 +0000 (15:40 +0200)]
[WIN32K:NTUSER] Allocate & free timers under global user lock

2 years ago[WIN32K] On init, start by initializing NtUser stuff
Jérôme Gardou [Fri, 30 Jul 2021 13:38:10 +0000 (15:38 +0200)]
[WIN32K] On init, start by initializing NtUser stuff

Allocate gpsi (Global Server Info) after initializing & grabbing Userlock

2 years ago[NTOS:MM] Remove dead code
Jérôme Gardou [Tue, 3 Aug 2021 08:57:12 +0000 (10:57 +0200)]
[NTOS:MM] Remove dead code

2 years ago[CMAKE] Update DLL base addresses
Jérôme Gardou [Tue, 3 Aug 2021 08:36:32 +0000 (10:36 +0200)]
[CMAKE] Update DLL base addresses

2 years ago[GITHUB] Build Release configuration for all compilers 3838/head
Victor Perevertkin [Sun, 1 Aug 2021 21:26:51 +0000 (00:26 +0300)]
[GITHUB] Build Release configuration for all compilers

2 years ago[CMAKE] Add memcmp to libntoskrnl for both clang and clang-cl
Victor Perevertkin [Sun, 1 Aug 2021 21:23:10 +0000 (00:23 +0300)]
[CMAKE] Add memcmp to libntoskrnl for both clang and clang-cl

2 years ago[MSVCRTEX] Add some routines required for clang optimizations
Victor Perevertkin [Sun, 1 Aug 2021 21:19:31 +0000 (00:19 +0300)]
[MSVCRTEX] Add some routines required for clang optimizations

- Include exp2* in all clang builds
- Include __aulldiv for i386 ones

Those are required, at least for clang-cl Release configuration

2 years ago[CONFIGURE] Make configure.sh print out an error when CMake fails
Nexware [Sun, 1 Aug 2021 22:40:43 +0000 (18:40 -0400)]
[CONFIGURE] Make configure.sh print out an error when CMake fails

2 years ago[UXTHEME] Fix incorrect part IDs in button class map.
Robert Naumann [Sat, 31 Jul 2021 20:14:38 +0000 (22:14 +0200)]
[UXTHEME] Fix incorrect part IDs in button class map.

Wine Patch by Zhiyi Zhang. (Commit ec82a0ebe65a0bd9f41c743d301c853e77dd8b8b)

2 years ago[NTOS:SE] Handle the reference logon session of the token 3847/head
George Bișoc [Sun, 25 Jul 2021 09:37:02 +0000 (11:37 +0200)]
[NTOS:SE] Handle the reference logon session of the token

When creating or duplicating an access token object, make sure that the logon session is getting referenced by the token must be inserted onto the logon reference member (a.k.a LogonSession) for proper logon session referencing tracking.

Also when a token object is about to be destroyed or that we are taking away a reference session from it, we must ensure that the referenced logon session data gets removed from the token in question.
CORE-17700

2 years ago[NTOS:SE] Implement logon reference insertion/removal to tokens
George Bișoc [Sun, 25 Jul 2021 09:34:45 +0000 (11:34 +0200)]
[NTOS:SE] Implement logon reference insertion/removal to tokens

2 years ago[NTOS:SE] Unify all the SRM tags in one place
George Bișoc [Sat, 24 Jul 2021 10:21:28 +0000 (12:21 +0200)]
[NTOS:SE] Unify all the SRM tags in one place

And rename SEP_LOGON_SESSION_TAG and SEP_LOGON_NOTIFICATION_TAG to TAG_LOGON_SESSION and TAG_LOGON_NOTIFICATION respectively.

2 years ago[ARM/CRT] Refactor several functions (#3865) 3865/head
Roman Masanin [Sat, 31 Jul 2021 01:04:25 +0000 (04:04 +0300)]
[ARM/CRT] Refactor several functions (#3865)

- Make __fto64 function more readable
- Call worker function directly for __rt_sdiv/udiv
- Adapt __rt_sdiv64/udiv64 asm shims accordingly
- Add header files to CMake source list

CORE-17607 CORE-17614 CORE-17703 CORE-17604

Addendum to f2bc1f0ee448094e and 54406bf4.

2 years ago[IMM32] Improve ImmSimulateHotKey (#3858)
Katayama Hirofumi MZ [Sat, 31 Jul 2021 06:56:11 +0000 (15:56 +0900)]
[IMM32] Improve ImmSimulateHotKey (#3858)

- Improve ImmSimulateHotKey function.
- Modify IMEDPI structure.
CORE-11700

2 years ago[IMM32] Rewrite ImmEnumInputContext (#3859)
Katayama Hirofumi MZ [Sat, 31 Jul 2021 06:45:07 +0000 (15:45 +0900)]
[IMM32] Rewrite ImmEnumInputContext (#3859)

- Rewrite ImmEnumInputContext function.
- Modify NtUserBuildHimcList.
CORE-11700

2 years ago[CRT/ARM] __fto64: Assembly wrappers are actually not needed anymore
Stanislav Motylkov [Fri, 30 Jul 2021 19:48:03 +0000 (22:48 +0300)]
[CRT/ARM] __fto64: Assembly wrappers are actually not needed anymore

Addendum to e448094e. CORE-17703 CORE-17604

2 years ago[NTOS:MM] Fix MiIsUserPte inline
Jérôme Gardou [Fri, 30 Jul 2021 16:54:30 +0000 (18:54 +0200)]
[NTOS:MM] Fix MiIsUserPte inline

2 years ago[FFS] Remove the FFS/UFS driver 3837/head
Victor Perevertkin [Fri, 23 Jul 2021 16:20:10 +0000 (19:20 +0300)]
[FFS] Remove the FFS/UFS driver

The upstream driver is not maintained and the file system itself
is in a semi-abandoned state.
Originally imported at 3a3ef631d12d8ac7ee2a95abf8c1c6e4815ac1a5

The driver is written by Lee Jae-Hong, updated by Bo Brantén.
ReactOS porting made by Peter Hater and Pierre Schweitzer.
Follow updates at http://www.acc.umu.se/~bosse/

FS Recognizer code is left to keep the FS support as an
installable driver.

CORE-11040

2 years ago[REISERFS] Remove the ReiserFS driver
Victor Perevertkin [Fri, 23 Jul 2021 18:12:31 +0000 (21:12 +0300)]
[REISERFS] Remove the ReiserFS driver

The upstream driver is not maintained and the file system itself
is in a semi-abandoned state.
Originally imported at e308102f4ab47c3c6a9107c743cbf3ec2c38f690

The driver is written by Mark W Piper, updated by Bo Brantén.
ReactOS porting made by Peter Hater and Pierre Schweitzer.
Follow updates at http://www.acc.umu.se/~bosse/

FS Recognizer code is left to keep the FS support as an
installable driver.

CORE-11005

2 years ago[CRT_APITEST] Add tests for __dtoi64/dtou64/stoi64/stou64 on ARM (#3848) 3848/head
Roman Masanin [Mon, 26 Jul 2021 21:31:29 +0000 (00:31 +0300)]
[CRT_APITEST] Add tests for __dtoi64/dtou64/stoi64/stou64 on ARM (#3848)

CORE-17703 CORE-17604

2 years ago[CRT/ARM] Implement __dtoi64/dtou64/stoi64/stou64 functions (#3848)
Roman Masanin [Sun, 25 Jul 2021 14:50:48 +0000 (17:50 +0300)]
[CRT/ARM] Implement __dtoi64/dtou64/stoi64/stou64 functions (#3848)

CORE-17703 CORE-17604

2 years ago[CRT/ARM] Fix modulus on division (#3856) 3856/head
Roman Masanin [Wed, 28 Jul 2021 11:34:59 +0000 (14:34 +0300)]
[CRT/ARM] Fix modulus on division (#3856)

This fixes all tests added in 759bdedc. Addendum to f2bc1f0e.

CORE-17607 CORE-17614 CORE-17604

2 years ago[CRT_APITEST] Add tests for __rt_sdiv/udiv/sdiv64/udiv64 on ARM
Stanislav Motylkov [Wed, 28 Jul 2021 19:38:21 +0000 (22:38 +0300)]
[CRT_APITEST] Add tests for __rt_sdiv/udiv/sdiv64/udiv64 on ARM

Addendum to f2bc1f0e and f1e2c6cb.

CORE-17607 CORE-17614 CORE-17604

2 years ago[IMM32] s/idThread/dwThreadId/
Katayama Hirofumi MZ [Wed, 28 Jul 2021 23:21:33 +0000 (08:21 +0900)]
[IMM32] s/idThread/dwThreadId/

- Rename idThread variable as dwThreadId.
- Rename idImeThread variable as dwImeThreadId.
CORE-11700

2 years ago[IMM32] Rewrite ImmSetCompositionWindow (#3855)
Katayama Hirofumi MZ [Wed, 28 Jul 2021 14:26:02 +0000 (23:26 +0900)]
[IMM32] Rewrite ImmSetCompositionWindow (#3855)

Implementing Japanese input... CORE-11700

2 years ago[IMM32] Implement ImmLoadLayout (#3854)
Katayama Hirofumi MZ [Wed, 28 Jul 2021 14:25:10 +0000 (23:25 +0900)]
[IMM32] Implement ImmLoadLayout (#3854)

Implementing Japanese input... CORE-11700

2 years ago[IMM32] Rewrite ImmNotifyIME (#3853)
Katayama Hirofumi MZ [Wed, 28 Jul 2021 14:24:09 +0000 (23:24 +0900)]
[IMM32] Rewrite ImmNotifyIME (#3853)

Implementing Japanese input... CORE-11700

2 years ago[IMM32] Rewrite ImmSetStatusWindowPos (#3852)
Katayama Hirofumi MZ [Wed, 28 Jul 2021 14:23:09 +0000 (23:23 +0900)]
[IMM32] Rewrite ImmSetStatusWindowPos (#3852)

Implementing Japanese input... CORE-11700

2 years ago[CRT] Fix _matherror and _setusermatherror
Timo Kreuzer [Sat, 24 Jul 2021 16:13:06 +0000 (18:13 +0200)]
[CRT] Fix _matherror and _setusermatherror

We previously used 2 different versions: one from wine and one from mingw-w64.
The former was used in msvcrt, the latter was statically compiled into the executable. When using MS libs, there is only one _matherr, which is statically linked into the executable and does nothing (it's not really a function for users to be called).
_setusermatherror should only exist in msvcrt and not statically, which wouldn't work at all.

2 years ago[CRT] Define NULL in crtdefs.h
Timo Kreuzer [Tue, 27 Jul 2021 13:08:26 +0000 (15:08 +0200)]
[CRT] Define NULL in crtdefs.h

2 years ago[NTOS:MM] Annotate some functions with regards to MmPfnLock
Jérôme Gardou [Fri, 23 Jul 2021 15:14:47 +0000 (17:14 +0200)]
[NTOS:MM] Annotate some functions with regards to MmPfnLock

Also fix MI_ASSERT_PFN_LOCK_HELD macro.
Now in debug builds, SpinLocks are always non-zero when held.

2 years ago[NTOS:MM] Always release PFN lock in MmDereferenceSegmentWithLock
Jérôme Gardou [Fri, 23 Jul 2021 14:38:56 +0000 (16:38 +0200)]
[NTOS:MM] Always release PFN lock in MmDereferenceSegmentWithLock

All callers release it after calling it.
CORE-17698

2 years ago[VIDEOPRT] Fix updating of new registry path values
Timo Kreuzer [Thu, 22 Jul 2021 14:13:38 +0000 (16:13 +0200)]
[VIDEOPRT] Fix updating of new registry path values

CORE-17688
When a new driver is installed for the same device (like VBoxVideo), it uses the same hardware enum registry key and thus reuses the same DisplayId and the same display registry key. Therefore we need to update the setting in that key, even when the key already exists.

This seems to work good and not cause any issues, but testing indicated that on Windows some values are only updated, when the driver has changed. If neccessary, this can be achieved by updating and querying the ActiveService value in the device enum key (e.g. HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\PCI\VEN_80EE&DEV_BEEF&SUSYS_00000000&REV_00\3&267a616a&0&10\Control: ActiveService). If that doesn't match the current device name (from DriverExtension->RegistryPath) the values should be copied over.

2 years ago[WIN32K] Fix uninitialized variable
Timo Kreuzer [Mon, 19 Jul 2021 06:55:09 +0000 (08:55 +0200)]
[WIN32K] Fix uninitialized variable

2 years ago[CRT/arm] Update file headers to new format and change license to MIT
Timo Kreuzer [Sat, 24 Jul 2021 09:41:06 +0000 (11:41 +0200)]
[CRT/arm] Update file headers to new format and change license to MIT

* Add Raman Masanin to copyrights
* Add some comments
* Return long long from __rt_sdiv (no functional difference, just for clarity)

2 years ago[CPPRT] arm: Add 2 'MSVCRTEX_eh_vector_*structor_iterator' aliases
Serge Gautherie [Mon, 24 May 2021 06:56:17 +0000 (08:56 +0200)]
[CPPRT] arm: Add 2 'MSVCRTEX_eh_vector_*structor_iterator' aliases

CORE-17606

2 years ago[NTOS:SE] Remove redundant commented call on token duplication
George Bișoc [Sun, 25 Jul 2021 16:02:32 +0000 (18:02 +0200)]
[NTOS:SE] Remove redundant commented call on token duplication

When duplicating an access token, the authentication ID is already copied from the existing token to the new one anyway so there's no point on having the commented call still left in the code.

2 years ago[DRWTSN32] Fix Clang build. Addendum to bdab437f.
Stanislav Motylkov [Sun, 25 Jul 2021 14:52:33 +0000 (17:52 +0300)]
[DRWTSN32] Fix Clang build. Addendum to bdab437f.

Also use a macro for better code readability.

Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
2 years ago[DRWTSN32] Recognize STATUS_ASSERTION_FAILURE as exception number
Stanislav Motylkov [Sun, 25 Jul 2021 12:32:08 +0000 (15:32 +0300)]
[DRWTSN32] Recognize STATUS_ASSERTION_FAILURE as exception number

2 years ago[IMM32] Imm(Lock|Unlock)ImeDpi and ImmSetOpenStatus (#3830)
Katayama Hirofumi MZ [Sun, 25 Jul 2021 02:57:57 +0000 (11:57 +0900)]
[IMM32] Imm(Lock|Unlock)ImeDpi and ImmSetOpenStatus (#3830)

- Add IMEDPI structure to ntuser.h.
- Implement ImmLockImeDpi/ImmUnlockImeDpi functions.
- Rewrite ImmSetOpenStatus function.
- Modify some NTUSER function prototypes.
- Modify imm32.spec.
CORE-11700

2 years ago[IMM32] Improve ImmGetImeInfoEx (#3833)
Katayama Hirofumi MZ [Sun, 25 Jul 2021 02:56:17 +0000 (11:56 +0900)]
[IMM32] Improve ImmGetImeInfoEx (#3833)

- Rewrite ImmGetImeInfoEx function.
- Implement CtfImmIsTextFrameServiceDisabled function.
- Modify imm32.spec.
CORE-11700

2 years ago[IMM32] Improve ImmUnlockClientImc and Imm32HeapAlloc (#3834)
Katayama Hirofumi MZ [Sun, 25 Jul 2021 02:55:03 +0000 (11:55 +0900)]
[IMM32] Improve ImmUnlockClientImc and Imm32HeapAlloc (#3834)

- Fix Imm32HeapAlloc function.
- Fix ImmUnlockClientImc function.
CORE-11700

2 years ago__rt_div fixes for arm (#3843)
Roman Masanin [Sat, 24 Jul 2021 18:23:58 +0000 (21:23 +0300)]
__rt_div fixes for arm (#3843)

[CRT/arm] Fix __rt_udiv and __rt_sdiv

2 years ago[SHELL32] Update de-DE.rc in IDD_BROWSE_FOR_FOLDER_NEW
Joachim Henze [Sat, 24 Jul 2021 13:11:54 +0000 (15:11 +0200)]
[SHELL32] Update de-DE.rc in IDD_BROWSE_FOR_FOLDER_NEW

More space for the german text in that button.
Correct the keyboard accelerator.

2 years ago[SHELLUTILS] Fix FAILED_UNEXPECTEDLY macro evaluating twice 3829/head
Mark Jansen [Fri, 23 Jul 2021 18:24:13 +0000 (20:24 +0200)]
[SHELLUTILS] Fix FAILED_UNEXPECTEDLY macro evaluating twice

2 years ago[SHELL32] CDefView: Respect item attributes
Mark Jansen [Thu, 15 Jul 2021 20:46:20 +0000 (22:46 +0200)]
[SHELL32] CDefView: Respect item attributes

2 years ago[FONTEXT] Cache attributes, handle sorting
Mark Jansen [Thu, 15 Jul 2021 20:45:19 +0000 (22:45 +0200)]
[FONTEXT] Cache attributes, handle sorting

2 years ago[CMAKE] Turn all warnings into errors on MSVC x86
Timo Kreuzer [Fri, 21 Feb 2020 19:07:27 +0000 (20:07 +0100)]
[CMAKE] Turn all warnings into errors on MSVC x86

2 years ago[REACTOS] Silence warnings in 3r-party code
Timo Kreuzer [Tue, 29 Jun 2021 08:03:28 +0000 (10:03 +0200)]
[REACTOS] Silence warnings in 3r-party code

2 years ago[REACTOS] Fix a number of MSVC warnings
Timo Kreuzer [Tue, 29 Jun 2021 16:50:15 +0000 (18:50 +0200)]
[REACTOS] Fix a number of MSVC warnings

2 years ago[USETUP] Fix invalid use of character count instead of byte count
Timo Kreuzer [Wed, 21 Jul 2021 08:26:42 +0000 (10:26 +0200)]
[USETUP] Fix invalid use of character count instead of byte count

2 years ago[PSDK][NDK] Use hex to define MIN/MAX constants like in native SDK
Timo Kreuzer [Tue, 29 Jun 2021 08:57:43 +0000 (10:57 +0200)]
[PSDK][NDK] Use hex to define MIN/MAX constants like in native SDK

This fixes use of unary minus operator on unsigned type warning.

2 years ago[KMTESTS:NTOS_IO] Fix check of spinlocks in case of checked builds
Jérôme Gardou [Fri, 23 Jul 2021 15:38:22 +0000 (17:38 +0200)]
[KMTESTS:NTOS_IO] Fix check of spinlocks in case of checked builds

Down back to zero failures

2 years ago[EVENTVWR] Update other languages RCs also CORE-17699
Joachim Henze [Thu, 22 Jul 2021 23:37:17 +0000 (01:37 +0200)]
[EVENTVWR] Update other languages RCs also CORE-17699

Use a capital letter for the /L parameter
because the Shells default font in the
help dialog makes a small L look like a small I.
MS also often does use that trick
to differentiate.

2 years ago[EVENTVWR] Update de-DE.rc CORE-17699
Joachim Henze [Thu, 22 Jul 2021 23:23:36 +0000 (01:23 +0200)]
[EVENTVWR] Update de-DE.rc CORE-17699

2 years ago[CRT] Remove checkstk_ms from build (it was unused)
Timo Kreuzer [Sat, 17 Jul 2021 13:47:24 +0000 (15:47 +0200)]
[CRT] Remove checkstk_ms from build (it was unused)

2 years ago[CRT] Refactor CMake files
Timo Kreuzer [Sat, 17 Jul 2021 12:53:17 +0000 (14:53 +0200)]
[CRT] Refactor CMake files

2 years ago[HAL/APIC] Make the real time clock more precise
Timo Kreuzer [Fri, 16 Jul 2021 09:42:45 +0000 (11:42 +0200)]
[HAL/APIC] Make the real time clock more precise

The interval time is now calculated in 0.1ns precision and a running fraction on the 100ns interval is updated on each clock interrupt.
Also adjust minimum, maximum and default clock rate to what Windows uses.

2 years ago[HAL/APIC] Fix clock initialization
Timo Kreuzer [Fri, 16 Jul 2021 09:45:39 +0000 (11:45 +0200)]
[HAL/APIC] Fix clock initialization

Previously we enabled the timer interrupt, before the kernel was notified of our time increment, so when a clock interrupt happened, it would increment the tick count, but add 0 to the system time, resulting in an invalid state, in which timers would be inserted into the wrong timer table slot. Fixes CORE-16253

2 years ago[HAL/APIC] Use APIC_CLOCK_VECTOR everywhere, instead of keeping separate definitions
Timo Kreuzer [Wed, 7 Jul 2021 19:58:23 +0000 (21:58 +0200)]
[HAL/APIC] Use APIC_CLOCK_VECTOR everywhere, instead of keeping separate definitions

2 years ago[BOOTDATA] Update readme.txt
Joachim Henze [Sun, 18 Jul 2021 23:05:00 +0000 (01:05 +0200)]
[BOOTDATA] Update readme.txt

Consistency regarding URLs:
- some URLs had the trailing slash, some had not
- moving all URLs to EOL makes it more convenient to copy-paste them

2 years ago[FONTEXT] Add de-DE translation CORE-17692
Joachim Henze [Sun, 18 Jul 2021 22:33:39 +0000 (00:33 +0200)]
[FONTEXT] Add de-DE translation CORE-17692

2 years ago[FONTEXT] Improve it-IT.rc comments
Joachim Henze [Sun, 18 Jul 2021 21:56:31 +0000 (23:56 +0200)]
[FONTEXT] Improve it-IT.rc comments

addendum to (#831)

2 years ago[SYSSETUP] Update de-DE.rc
Joachim Henze [Sun, 18 Jul 2021 15:51:44 +0000 (17:51 +0200)]
[SYSSETUP] Update de-DE.rc

The buttons name on the last dialog of 2nd stage
is "Fertig" and not "Beenden".
So make the help-texts consistent with that.

2 years ago[EVENTVWR] Add a context menu to TreeView items. (#3828)
Jose Carlos Jesus [Sat, 17 Jul 2021 17:26:48 +0000 (18:26 +0100)]
[EVENTVWR] Add a context menu to TreeView items. (#3828)

Same as in Windows XP/2003.
+ Specify a default extension when opening or saving an event-log file.

2 years ago[ADVAPI32][SERVICES] Use the context handle to encrypt and decrypt service passwords
Eric Kohl [Sat, 17 Jul 2021 14:26:16 +0000 (16:26 +0200)]
[ADVAPI32][SERVICES] Use the context handle to encrypt and decrypt service passwords

2 years ago[IMM32] Rewrite ImmGetStatusWindowPos (#3824)
Katayama Hirofumi MZ [Thu, 15 Jul 2021 22:30:55 +0000 (07:30 +0900)]
[IMM32] Rewrite ImmGetStatusWindowPos (#3824)

Rewrite ImmGetStatusWindowPos function. CORE-11700

2 years ago[IMM32] Rewrite ImmGetCandidateWindow (#3823)
Katayama Hirofumi MZ [Thu, 15 Jul 2021 18:04:00 +0000 (03:04 +0900)]
[IMM32] Rewrite ImmGetCandidateWindow (#3823)

Rewrite ImmGetCandidateWindow function. CORE-11700

2 years ago[NTOS:PS] Support using QUOTA_LIMITS_EX in NtSetInformationProcess(ProcessQuotaLimits)
Hervé Poussineau [Thu, 15 Jul 2021 06:55:06 +0000 (08:55 +0200)]
[NTOS:PS] Support using QUOTA_LIMITS_EX in NtSetInformationProcess(ProcessQuotaLimits)

Both QUOTA_LIMITS and QUOTA_LIMITS_EX are already supported in PspSetQuotaLimits,
but this was broken by a330b56787951d897eec0706b4649a452f8ba623

2 years ago[KMTESTS:SE] Implement initial logon session tests
George Bișoc [Thu, 17 Jun 2021 16:12:12 +0000 (18:12 +0200)]
[KMTESTS:SE] Implement initial logon session tests

This implements tests for SeMarkLogonSessionForTerminationNotification exported routine so far.

2 years ago[NTOS:SE] Implement logon session termination notification
George Bișoc [Thu, 17 Jun 2021 16:11:14 +0000 (18:11 +0200)]
[NTOS:SE] Implement logon session termination notification

Note to SELF and EVERYONE: the commit implements the initial logon session termination notification implementation, the SeMarkLogonSessionForTerminationNotification function, but as it currently stands there are several other tasks to be addressed in the future in order for the logon termination notification to be fully completed. The tasks as of which are.

1. Our SepRmDereferenceLogonSession is not fully implemented, as it doesn't inform the LSA and filesystems of logon deletion notification
2. Implement two worker routines that are actually in charge of such tasks of informing LSA and FSDs
3. Perform logon deletion
4. Do further investigations and check whatever that is left to address, if any

2 years ago[DDRAW] ddraw.c ddraw7_FlipToGDISurface() to Wine-6.8 (#3827) CORE-15128
Doug Lyons [Thu, 15 Jul 2021 17:04:46 +0000 (12:04 -0500)]
[DDRAW] ddraw.c ddraw7_FlipToGDISurface() to Wine-6.8 (#3827) CORE-15128

fixes CORE-15128 "Fall 0.1.3, black controls all over the desktop after exiting the game"
which regressed by 0.4.9-dev-155-g 9987f02917539e05268ba2ad11e62d24a3636972
(the sync to Wine Staging 3.3)

the patch on top of 0.4.15-dev-2923-g2210d23:
KVM: https://reactos.org/testman/compare.php?ids=78290,78295 LGTM
VBox: https://reactos.org/testman/compare.php?ids=78291,78294 LGTM

2 years ago[SAMSRV] SamrQueryInformationDomain: Older functions should call new functions
Eric Kohl [Thu, 15 Jul 2021 15:25:06 +0000 (17:25 +0200)]
[SAMSRV] SamrQueryInformationDomain: Older functions should call new functions

2 years ago[IMM32] Rewrite ImmGetIMEFileNameA/W (#3822)
Katayama Hirofumi MZ [Thu, 15 Jul 2021 14:01:50 +0000 (23:01 +0900)]
[IMM32] Rewrite ImmGetIMEFileNameA/W (#3822)

- Rewrite ImmGetIMEFileNameA and ImmGetIMEFileNameW functions. CORE-11700

2 years ago[IMM32] Rewrite ImmGetDefaultIMEWnd (#3821)
Katayama Hirofumi MZ [Thu, 15 Jul 2021 12:59:53 +0000 (21:59 +0900)]
[IMM32] Rewrite ImmGetDefaultIMEWnd (#3821)

- Rewrite ImmGetDefaultIMEWnd function.
- Add g_dwImm32Flags global variable.
- Add Imm32QueryWindow helper function.
- Implement CtfImmIsCiceroEnabled function.
- Modify imm32.spec.
CORE-11700

2 years ago[WIN32K] Check if a graphics device already exists before trying to add it
Timo Kreuzer [Tue, 13 Jul 2021 20:24:41 +0000 (22:24 +0200)]
[WIN32K] Check if a graphics device already exists before trying to add it

This avoids DPRINTs alleging a failure to open a device.
Also improve another DPRINT.

2 years ago[WIN32K] Fix detection of multiple display devices on VBox
Timo Kreuzer [Tue, 13 Jul 2021 06:29:11 +0000 (08:29 +0200)]
[WIN32K] Fix detection of multiple display devices on VBox

2 years ago[NETAPI32] Return the old values for NetGetJoinInformation() to fix Chrome Installer...
Eric Kohl [Wed, 14 Jul 2021 13:22:17 +0000 (15:22 +0200)]
[NETAPI32] Return the old values for NetGetJoinInformation() to fix Chrome Installer regression

Should fix CORE-17679

2 years ago[IMM32_APITEST] Add clientimc testcase (#3815)
Katayama Hirofumi MZ [Tue, 13 Jul 2021 16:19:35 +0000 (01:19 +0900)]
[IMM32_APITEST] Add clientimc testcase (#3815)

- Add clientimc testcase to imm32_apitest.
- Add "precomp.h".
CORE-11700

2 years ago[IMM32] Rewrite ImmGetCompositionWindow (#3820)
Katayama Hirofumi MZ [Tue, 13 Jul 2021 12:13:39 +0000 (21:13 +0900)]
[IMM32] Rewrite ImmGetCompositionWindow (#3820)

Rewrite ImmGetCompositionWindow function. CORE-11700

2 years ago[IMM32] Rewrite ImmGetCompositionFontA/W (#3813)
Katayama Hirofumi MZ [Tue, 13 Jul 2021 11:51:28 +0000 (20:51 +0900)]
[IMM32] Rewrite ImmGetCompositionFontA/W (#3813)

- Rewrite ImmGetCompositionFontA and ImmGetCompositionFontW functions.
- Add INIT_* macro definitions in <ddk/imm.h>.
CORE-11700

2 years ago[IMM32] Rewrite ImmGetCandidateListCountA/W (#3812)
Katayama Hirofumi MZ [Tue, 13 Jul 2021 11:17:17 +0000 (20:17 +0900)]
[IMM32] Rewrite ImmGetCandidateListCountA/W (#3812)

Implement ImmGetCandidateListCountA and ImmGetCandidateListCountW functions by using newly defined ImmGetCandidateListCountAW function. CORE-11700

2 years ago[COMCTL32] Listview: Only apply horizontal offset when setting header position CORE...
Joachim Henze [Tue, 13 Jul 2021 05:38:45 +0000 (07:38 +0200)]
[COMCTL32] Listview: Only apply horizontal offset when setting header position CORE-17674

This imports
Wine commit https://github.com/wine-mirror/wine/commit/d92906249fd4abd75d5d2ee2fba966855fac2e4c#diff-7f0ae6301b1f6ea1128640b76cd831308e24466f15399de6d5040557b79f0f16
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Thanks to Doug Lyons who picked the fix for us from Wine 6.0

It fixes for us CORE-17674 "Corruption of the listview header"
which regressed by 0.4.14-dev-150-g 00f14ee1f22a1c285462459f859fa17c90ccc19f
when we synced to Wine Staging 4.18

Testbot results of the patch:
KVM https://reactos.org/testman/compare.php?ids=78225,78270 LGTM
VBox https://reactos.org/testman/compare.php?ids=78226,78271 LGTM

I intend to port this back into 0.4.14RC94 also, so no official reactos release
will ever be affected by it.

2 years ago[DESK] Only try to restart graphic device after installation
Hervé Poussineau [Mon, 12 Jul 2021 21:50:42 +0000 (23:50 +0200)]
[DESK] Only try to restart graphic device after installation

If it fails, require a reboot.

CORE-17675

2 years ago[GITHUB] Add MSVC Release builder
Timo Kreuzer [Sat, 10 Jul 2021 11:27:55 +0000 (13:27 +0200)]
[GITHUB] Add MSVC Release builder

2 years ago[CRT] Add some missing #pragma function
Timo Kreuzer [Sat, 10 Jul 2021 11:24:42 +0000 (13:24 +0200)]
[CRT] Add some missing #pragma function

2 years ago[CRT] Fix handling of intrinsics and inline functions
Timo Kreuzer [Sat, 10 Jul 2021 11:07:18 +0000 (13:07 +0200)]
[CRT] Fix handling of intrinsics and inline functions

2 years ago[CMAKE] Don't turn C4101 (unreferenced local variable) into an error on release builds
Timo Kreuzer [Sat, 10 Jul 2021 10:45:04 +0000 (12:45 +0200)]
[CMAKE] Don't turn C4101 (unreferenced local variable) into an error on release builds

2 years ago[NTOS:MM] Fix MiSetSystemCodeProtection
Timo Kreuzer [Tue, 6 Jul 2021 11:48:52 +0000 (13:48 +0200)]
[NTOS:MM] Fix MiSetSystemCodeProtection

CORE-16387 CORE-17638
Windows only makes the header RO for session space mapped drivers (win32k, dx and display drivers)

2 years ago[SAMSRV] Older functions should call newer functions
Eric Kohl [Sun, 11 Jul 2021 10:54:28 +0000 (12:54 +0200)]
[SAMSRV] Older functions should call newer functions

2 years ago[BROWSEUI] Multithreaded auto-completion (#3794)
Katayama Hirofumi MZ [Sun, 11 Jul 2021 04:00:00 +0000 (13:00 +0900)]
[BROWSEUI] Multithreaded auto-completion (#3794)

- Make auto-completion multi-threaded.
CORE-9281

2 years ago[IMM32] Add some candidate handlings (#3799)
Katayama Hirofumi MZ [Sun, 11 Jul 2021 00:48:15 +0000 (09:48 +0900)]
[IMM32] Add some candidate handlings (#3799)

- Implement ImmGetCandidateListA and ImmGetCandidateListW, by using newly added ImmGetCandidateListAW function.
- Implement ImmLockClientImc and ImmUnlockClientImc functions.
- Modify imm32.spec.
- Remove #ifdef's.
CORE-11700