reactos.git
4 years ago[SHELL32] Improve comments of shell folder paths
Katayama Hirofumi MZ [Fri, 24 Jan 2020 12:32:25 +0000 (21:32 +0900)]
[SHELL32] Improve comments of shell folder paths

4 years ago[SHELL32][USERENV] Update Japanese special folder names
Katayama Hirofumi MZ [Fri, 24 Jan 2020 12:27:50 +0000 (21:27 +0900)]
[SHELL32][USERENV] Update Japanese special folder names

4 years ago[WIN32SS] Replace inline by FORCEINLINE, as in other files of the module
Hervé Poussineau [Mon, 20 Jan 2020 16:56:44 +0000 (17:56 +0100)]
[WIN32SS] Replace inline by FORCEINLINE, as in other files of the module

4 years ago[SETUPLIB] Fix possible out-of-bound buffer if BootStore->Type is unknown/invalid
Hervé Poussineau [Mon, 20 Jan 2020 16:49:00 +0000 (17:49 +0100)]
[SETUPLIB] Fix possible out-of-bound buffer if BootStore->Type is unknown/invalid

4 years ago[SDK] Use HEX macro, like elsewhere in the file
Hervé Poussineau [Tue, 14 Jan 2020 22:20:10 +0000 (23:20 +0100)]
[SDK] Use HEX macro, like elsewhere in the file

4 years ago[NTOS] Move FORCEINLINE specifier where appropriate
Hervé Poussineau [Tue, 14 Jan 2020 22:18:48 +0000 (23:18 +0100)]
[NTOS] Move FORCEINLINE specifier where appropriate

4 years ago[FREELDR] Comment out useless variable
Hervé Poussineau [Tue, 14 Jan 2020 22:16:25 +0000 (23:16 +0100)]
[FREELDR] Comment out useless variable

4 years ago[EXPLORER][INCLUDE] Fix wrong title on taskbar about ampersand (&) (#2266)
Katayama Hirofumi MZ [Wed, 22 Jan 2020 00:58:43 +0000 (09:58 +0900)]
[EXPLORER][INCLUDE] Fix wrong title on taskbar about ampersand (&) (#2266)

Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
Based on @learn-more's CORE-11619.patch. CORE-11619

4 years ago[BOOTDATA][USERENV] Improve and fix user profile info (#2265)
Katayama Hirofumi MZ [Tue, 21 Jan 2020 23:19:39 +0000 (08:19 +0900)]
[BOOTDATA][USERENV] Improve and fix user profile info (#2265)

The international user profile info was inconsistent; thus TEMP and TMP environment variables were wrong. CORE-16635

4 years ago[Win32nt|ApiTests] Add Exclude, Intersect and Offset Clip Region tests.
jimtabor [Mon, 20 Jan 2020 19:11:09 +0000 (13:11 -0600)]
[Win32nt|ApiTests] Add Exclude, Intersect and Offset Clip Region tests.

4 years ago[NtGdi] Fix clip region merging.
James Tabor [Mon, 20 Jan 2020 18:49:11 +0000 (12:49 -0600)]
[NtGdi] Fix clip region merging.

Use a new region while merging from the original. See CORE-16626.

4 years ago[ATL] Re-enable MSVC warning C4477 (#2010)
Serge Gautherie [Mon, 20 Jan 2020 13:24:06 +0000 (14:24 +0100)]
[ATL] Re-enable MSVC warning C4477 (#2010)

Follow-up to e410a122.

4 years ago[WIN32SS][USERSRV] Add CSR API_NUMBER comments
Katayama Hirofumi MZ [Sun, 19 Jan 2020 23:06:40 +0000 (08:06 +0900)]
[WIN32SS][USERSRV] Add CSR API_NUMBER comments

4 years ago[USETUP] Implement resource ID text based strings for MUI (#2193)
Bișoc George [Sun, 19 Jan 2020 16:58:13 +0000 (17:58 +0100)]
[USETUP] Implement resource ID text based strings for MUI (#2193)

CORE-12683

Supersedes PR #612.

* [USETUP] Implement the internal MUI routines for text manipulation based on its ID and implement text resource based IDs

USETUP (the 1st stage text mode setup module) bases upon MUI (Multilingual User Interface) sub-component of USETUP which is responsible for the ability into translating the MUI pages (each page having corresponding properties like X, Y coordinates, text flags and text string buffer) in various languages.
The only problem, as of now, is that whenever you want to modify a certain property of a page, such as removing a text from the said page in the screen, you've got to rely on using CONSOLE_* specific functions and calling with hardcoded parameters, namely the coordinates.

This can become a problem as not every localized (translated) MUI page has the same properties for each language and this could lead to various issues. Therefore, assigning each entry with an ID you can remove a text by only giving its ID (and the entry page number) without having the need to specify the coordinates
as the internal MUI routine, MUIGetEntry(), automatically retrieves the entry with respective data fields.

The following commit implements:

- MUIGetEntry()
- MUIClearText()
- MUIClearStyledText()
- MUISetText()
- MUISetStyledText()
- Now the X and Y coordinate members of MUI_ENTRY are of SHORT integer type, for the sake of the general code as most of the coordination values, even the COORD structure itself, has the coordination points as SHORTs and not BYTEs.

The following MUI functions will be used to manipulate text based resources depending on their ID from the corresponding MUI entry.

* [USETUP] Make CONSOLE_ClearTextXY function public so that we can use across other files.

* [USETUP] Implement the IDs for each text MUI entry in locale files.

This mechanism follows the same principle of resource IDs in Win32 applications. Static text is merely a resource that doesn't get changed programmatically for whole of its lifetime whereas dynamic resources can change during the lifetime of the program depending on the algorithm (for example, hide that piece of text and set another one, etc.).

* [USETUP] Remove the "Press ENTER to continue" message prompt when the partition formatting begins.

4 years ago[TRANSLATION] Update Portuguese translation (#2257)
Jose Carlos Jesus [Sun, 19 Jan 2020 14:45:07 +0000 (14:45 +0000)]
[TRANSLATION] Update Portuguese translation (#2257)

Improvements/updates for sysdm.cpl, devmgr.dll, hhctrl.ocx, netid.dll,
and add new Portuguese translation for shimgvw.dll .

4 years ago[SYSSETUP] When the physical host name is set, also set an empty physical domain...
Eric Kohl [Sun, 19 Jan 2020 12:33:15 +0000 (13:33 +0100)]
[SYSSETUP] When the physical host name is set, also set an empty physical domain name

4 years ago[KERNEL32] Improvements to Get/SetComputerNameExW
Eric Kohl [Sun, 19 Jan 2020 12:28:02 +0000 (13:28 +0100)]
[KERNEL32] Improvements to Get/SetComputerNameExW

- The ComputerNamePhysicalDnsDomain name type gets or sets the 'NV Domain' registry value.
- The ComputerNamePhysicalDnsHostname name type gets or sets the 'NV Hostname' registry value.
- IsValidComputerName: Enforce name length restrictions according to the name type.

4 years ago[NETEVENT] Netevent.dll does not have an entry point because it is a resource-only...
Eric Kohl [Sat, 18 Jan 2020 18:22:53 +0000 (19:22 +0100)]
[NETEVENT] Netevent.dll does not have an entry point because it is a resource-only dll.

4 years ago[FREELDR] Add FAT12 file system boot sector for NEC PC-98 series (#2025)
Dmitry Borisov [Sat, 18 Jan 2020 18:16:23 +0000 (00:16 +0600)]
[FREELDR] Add FAT12 file system boot sector for NEC PC-98 series (#2025)

The first part of PC-98 Port - https://reactos.org/wiki/PC-98

- Add FAT12 file system boot sector for NEC PC-98 series.
- Add a new build target for a PC-98 bootable floppy disk.
- Add a new sub-architecture into config.cmake.

4 years ago[WBEMPROX] Always free 'new_path' (#2056)
Serge Gautherie [Sat, 18 Jan 2020 17:53:11 +0000 (18:53 +0100)]
[WBEMPROX] Always free 'new_path' (#2056)

Cherry-pick
https://source.winehq.org/git/wine.git/commit/a45dfea99a2eeaf3ede829b04e58c13d14b33970

CORE-13391

4 years ago[HALXBOX] Don't use Xbox partitions if MBR signature found (#2253)
Stanislav Motylkov [Sat, 18 Jan 2020 17:41:32 +0000 (20:41 +0300)]
[HALXBOX] Don't use Xbox partitions if MBR signature found (#2253)

* [HALXBOX] Formatting only.

* [HALXBOX] Don't use Xbox partitions if MBR signature found.

- Fixes BSOD 0x7B when booting from a HDD that have both MBR and BRFR signatures.
- It happens when you format Xbox (BRFR) disk as MBR.
  After that "BRFR" signature is still located at sector 3.
- Also fix pre-existing leaks.

CORE-16216 CORE-16329

4 years ago[DNSAPI] DnsQuery_W: Check names for invalid characters before querying the dns resolver.
Eric Kohl [Sat, 18 Jan 2020 14:02:18 +0000 (15:02 +0100)]
[DNSAPI] DnsQuery_W: Check names for invalid characters before querying the dns resolver.

4 years ago[XDK] Fix x64 version of KeGetCurrentProcessorNumber() and add KeGetCurrentProcessorI...
Timo Kreuzer [Sun, 21 Apr 2019 09:28:58 +0000 (11:28 +0200)]
[XDK] Fix x64 version of KeGetCurrentProcessorNumber() and add KeGetCurrentProcessorIndex()

4 years ago[FLTMGR] Safely query object name in FltpGetObjectName. CID 1420811
Thomas Faber [Sat, 30 Nov 2019 11:04:14 +0000 (12:04 +0100)]
[FLTMGR] Safely query object name in FltpGetObjectName. CID 1420811

4 years ago[SHELL] Add SHOpenFolderAndSelectItems to shlobj.h.
Thomas Faber [Sat, 30 Nov 2019 10:02:06 +0000 (11:02 +0100)]
[SHELL] Add SHOpenFolderAndSelectItems to shlobj.h.

4 years ago[ATL30] Fix m_szAutoName definition and construction in Wine's ATL30 dll.
Hermès Bélusca-Maïto [Wed, 15 Jan 2020 00:14:30 +0000 (01:14 +0100)]
[ATL30] Fix m_szAutoName definition and construction in Wine's ATL30 dll.

- Make the format actually MS-compatible: "ATL" followed by colon,
  followed by hexadecimal digits of pointer.

- The MS counterpart of this DLL was delivered with Visual C++ 6.0 and
  Windows 98+, so obviously it always was 32-bit and they never had a
  64-bit version for it. But we do. So make the size of the m_szAutoName
  buffer cross-compatible.

- See previous commit dbddd878 and the discussion in PR #2010.

4 years ago[SDK:ATL] Fix the size of the ATL_WNDCLASSINFOW::m_szAutoName member according to...
Hermès Bélusca-Maïto [Wed, 15 Jan 2020 00:10:28 +0000 (01:10 +0100)]
[SDK:ATL] Fix the size of the ATL_WNDCLASSINFOW::m_szAutoName member according to the actual MS-compatible auto-generated window class name.

The autogenerated name has the format:
    "ATL:<hexadecimal_digits_of_pointer><NULL-terminator>"

and the number of hex digits in 0xABCD1234 (for 32-bit == 4-byte)
pointers (without the '0x') is 8 == 4*2, and for 64-bit == 8-byte
pointers (e.g. 0xABCDEF0123456789) is 16 == 8*2.

4 years ago[CMAKE] Add proper global definition for Xbox port (#2250)
Stanislav Motylkov [Tue, 14 Jan 2020 21:15:18 +0000 (00:15 +0300)]
[CMAKE] Add proper global definition for Xbox port (#2250)

CORE-16216

4 years ago[FREELDR][XBOXVMP] Check only low 28 bits for framebuffer address (#2249)
Stanislav Motylkov [Tue, 14 Jan 2020 19:20:22 +0000 (22:20 +0300)]
[FREELDR][XBOXVMP] Check only low 28 bits for framebuffer address (#2249)

Fixes framebuffer detection on real hardware Xbox.

4 years ago[SYSDM] general.c: Make 2 global variables 'static' (#2060)
Serge Gautherie [Tue, 14 Jan 2020 17:54:17 +0000 (18:54 +0100)]
[SYSDM] general.c: Make 2 global variables 'static' (#2060)

And 1 'const' too.

This allows reducing confusion about scope/use.

4 years ago[TRANSLATION] Add/update Hungarian translation for shell32, ieframe, browseui (#2127)
7OMI [Tue, 14 Jan 2020 17:52:38 +0000 (18:52 +0100)]
[TRANSLATION] Add/update Hungarian translation for shell32, ieframe, browseui (#2127)

4 years ago[FLOPPY_NEW] WindowsSync to 8fb512a (#2238)
Serge Gautherie [Tue, 14 Jan 2020 17:50:19 +0000 (18:50 +0100)]
[FLOPPY_NEW] WindowsSync to 8fb512a (#2238)

* [FLOPPY_NEW] Make 6 '#ifdef' explicit about '__REACTOS__'

* [FLOPPY_NEW] RtlStringCbPrintf?() need bytes, not chars

Import
https://github.com/microsoft/Windows-driver-samples/commit/8fb512ac674df5ba129a69906d450f2a1361136d

4 years ago[HAL][FREELDR] Fix system timer oscillator frequency on a Xbox (#2245)
disean [Tue, 14 Jan 2020 17:47:36 +0000 (23:47 +0600)]
[HAL][FREELDR] Fix system timer oscillator frequency on a Xbox (#2245)

See https://xboxdevwiki.net/Porting_an_Operating_System_to_the_Xbox_HOWTO#Timer_Frequency

4 years ago[FREELDR] Cache INT13h drive data in pcdisk.c (#2097)
disean [Tue, 14 Jan 2020 03:08:53 +0000 (09:08 +0600)]
[FREELDR] Cache INT13h drive data in pcdisk.c (#2097)

* [FREELDR] Cache the drive geometry in the PcDiskReadLogicalSectorsCHS()

Speed up the loading time a bit.

* [FREELDR] Generalize the cache to all the geometry data + INT 13h extensions-supported status.

The data structure used is "PC_DISK_DRIVE".

- Adapt the associated functions;
- Make DiskGetExtendedDriveParameters() private to pcdisk.c

- Introduce PcDiskDriveNumberToDrive(), that is similar to the XBOX
  function XboxDiskDriveNumberToDeviceUnit(), that retrieves a valid
  pointer to the cached disk corresponding to the given BIOS DriveNumber.
  If needed the cached data gets initialized.

- Make XboxDiskDriveNumberToDeviceUnit() simpler by just returning the
  pointer to the corresponding drive, of NULL if there is none.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
4 years ago[MSGINA] Improve Japanese status dialog (#2248)
Katayama Hirofumi MZ [Mon, 13 Jan 2020 14:01:39 +0000 (23:01 +0900)]
[MSGINA] Improve Japanese status dialog (#2248)

Improve Japanese translation (IDD_STATUS).

4 years ago[SHELL32] Improve Japanese folder property sheet (#2247)
Katayama Hirofumi MZ [Mon, 13 Jan 2020 13:47:26 +0000 (22:47 +0900)]
[SHELL32] Improve Japanese folder property sheet (#2247)

Improve Japanese translation.

4 years ago[SHELL32][SHLWAPI] Improve Japanese file property sheet (#2246)
Katayama Hirofumi MZ [Mon, 13 Jan 2020 13:33:50 +0000 (22:33 +0900)]
[SHELL32][SHLWAPI] Improve Japanese file property sheet (#2246)

- Improve file property dialog (IDD_FILE_PROPERTIES).
- Translate shlwapi resource into Japanese.

4 years ago[FREELDR] Add ATA/ATAPI driver. (#2167) 2167/head
Dmitry Borisov [Sun, 22 Dec 2019 21:52:40 +0000 (03:52 +0600)]
[FREELDR] Add ATA/ATAPI driver. (#2167)
CORE-16220 CORE-16216

* Create a new driver.
* Use the functions from the library in xboxdisk.c

Driver now supports PC, Xbox and NEC PC-98.

Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
4 years ago[DNSAPI] Answer queries for ip addresses before they are passed to the resolver cache.
Eric Kohl [Sun, 12 Jan 2020 14:15:06 +0000 (15:15 +0100)]
[DNSAPI] Answer queries for ip addresses before they are passed to the resolver cache.

4 years ago[NETCFGX] Notify the installer of changes to the properties
Eric Kohl [Sat, 11 Jan 2020 15:25:37 +0000 (16:25 +0100)]
[NETCFGX] Notify the installer of changes to the properties

4 years ago[WIN32SS][WINSRV] Fullwidth character handling Part 2 (#2240)
Katayama Hirofumi MZ [Sun, 12 Jan 2020 13:04:57 +0000 (22:04 +0900)]
[WIN32SS][WINSRV] Fullwidth character handling Part 2 (#2240)

Follow-up of #2231. Also fix FillConsoleOutputAttribute, WriteConsoleOutputCharacterW and WriteConsoleOutputAttribute functions.
CORE-12451

4 years ago[CMD_APITEST] Add more regression tests for attrib 2141/head
Doug Lyons [Sun, 8 Dec 2019 14:23:22 +0000 (08:23 -0600)]
[CMD_APITEST] Add more regression tests for attrib

4 years ago[NTFS] Fix use after free in failure case of NtfsMountVolume.
Thomas Faber [Sat, 11 Jan 2020 13:08:20 +0000 (14:08 +0100)]
[NTFS] Fix use after free in failure case of NtfsMountVolume.

NtfsGetVolumeData frees FileRecLookasideList in case of failure, so don't
free it again.
Dereferencing NewDeviceObject invalidates Vcb.

4 years ago[UDFS] Fix uninitialized var use in UDFCommonCreate, return the right error code
Suraj K Suresh [Fri, 10 Jan 2020 10:09:14 +0000 (15:39 +0530)]
[UDFS] Fix uninitialized var use in UDFCommonCreate, return the right error code
CORE-16174

4 years ago[APISETS] Forwarders don't need parameter specifications (#2225)
Serge Gautherie [Fri, 10 Jan 2020 13:20:53 +0000 (14:20 +0100)]
[APISETS] Forwarders don't need parameter specifications (#2225)

Addendum to 192926ee.

4 years ago[TRANSLATION] [SHELL32] Improvements to Portuguese translation (#2228)
Jose Carlos Jesus [Fri, 10 Jan 2020 12:44:55 +0000 (12:44 +0000)]
[TRANSLATION] [SHELL32] Improvements to Portuguese translation (#2228)

And minor adjustments because of text lenght.

4 years ago[KERNEL32_APITEST] Strengthen ConsoleCP for Writing functions (#2235)
Katayama Hirofumi MZ [Wed, 8 Jan 2020 12:20:24 +0000 (21:20 +0900)]
[KERNEL32_APITEST] Strengthen ConsoleCP for Writing functions (#2235)

Add some tests for WriteConsoleOutputCharacterW and WriteConsoleOutputAttribute etc. into ConsoleCP testcase. CORE-12451

4 years ago[SERVICES] Use the local system account to run all services on a LiveCD
Eric Kohl [Tue, 7 Jan 2020 23:14:50 +0000 (00:14 +0100)]
[SERVICES] Use the local system account to run all services on a LiveCD

This fixes CORE-16589.

4 years ago[KS] KsQueryInformationFile(): Fix 'FastIoQueryBasicInfo' copypasta (#2236)
Serge Gautherie [Tue, 7 Jan 2020 14:13:40 +0000 (15:13 +0100)]
[KS] KsQueryInformationFile(): Fix 'FastIoQueryBasicInfo' copypasta (#2236)

Addendum to commit 4725a4fd (r42117).

4 years ago[WIN32SS][WINSRV] Fullwidth character handling for Asian console (#2231)
Katayama Hirofumi MZ [Tue, 7 Jan 2020 06:26:58 +0000 (15:26 +0900)]
[WIN32SS][WINSRV] Fullwidth character handling for Asian console (#2231)

Far-East Asian language (Chinese, Japanese and Korean; CJK) needs special handling in console.
Especially a fullwidth character (mk_wcwidth_cjk(ch) == 2) needs a double width space. A fullwidth character on the console window is treated as a pair of a leading byte and a trailing byte (COMMON_LVB_LEADING_BYTE and COMMON_LVB_TRAILING_BYTE). CORE-12451

4 years ago[DESK] The DisplayClassInstaller must create a new DeviceX subkey for each new displa...
Eric Kohl [Mon, 6 Jan 2020 21:38:53 +0000 (22:38 +0100)]
[DESK] The DisplayClassInstaller must create a new DeviceX subkey for each new display devices

This should fix CORE-16615

4 years ago[USB] Update the names of new USB drivers
Oleg Dubinskiy [Thu, 2 Jan 2020 13:05:51 +0000 (15:05 +0200)]
[USB] Update the names of new USB drivers

4 years ago[SDK][USB] Delete old USB drivers and libusb
Oleg Dubinskiy [Thu, 2 Jan 2020 13:01:32 +0000 (15:01 +0200)]
[SDK][USB] Delete old USB drivers and libusb

4 years ago[WINHTTP_WINETEST] Skip several tests from execution in order to prevent
Victor Perevertkin [Mon, 6 Jan 2020 02:36:39 +0000 (05:36 +0300)]
[WINHTTP_WINETEST] Skip several tests from execution in order to prevent
testbot hangs.
ROSTESTS-350

4 years ago[DNSRSLVR] R_ResolverFlushCache should only flush cached records which were not read...
Eric Kohl [Sun, 5 Jan 2020 23:45:41 +0000 (00:45 +0100)]
[DNSRSLVR] R_ResolverFlushCache should only flush cached records which were not read from the hosts file

4 years ago[WININET_WINETEST] http: Remove ROSTESTS_73_FIXED workaround
Serge Gautherie [Thu, 2 Jan 2020 02:42:07 +0000 (03:42 +0100)]
[WININET_WINETEST] http: Remove ROSTESTS_73_FIXED workaround

ROSTESTS-73

4 years ago[TIMEDATE] Update the clock on WM_TIMECHANGE
Eric Kohl [Sun, 5 Jan 2020 11:21:53 +0000 (12:21 +0100)]
[TIMEDATE] Update the clock on WM_TIMECHANGE

4 years ago[SYSDM] Improve the user profile dialog
Eric Kohl [Sat, 4 Jan 2020 13:54:30 +0000 (14:54 +0100)]
[SYSDM] Improve the user profile dialog

- Currently used profiles cannot be copied or deleted.
- Unknown profiles cannot be copied.
- A double click on a profile opens the change profile type dialog.

4 years ago[PSDK] Support STRICT_TYPED_ITEMIDS in shdeprecated.idl. CORE-16385 2161/head
Suraj K Suresh [Tue, 24 Dec 2019 18:54:51 +0000 (00:24 +0530)]
[PSDK] Support STRICT_TYPED_ITEMIDS in shdeprecated.idl. CORE-16385

4 years ago[PSDK] Support STRICT_TYPED_ITEMIDS in shlwapi.h. CORE-16385
Suraj K Suresh [Tue, 24 Dec 2019 15:48:43 +0000 (21:18 +0530)]
[PSDK] Support STRICT_TYPED_ITEMIDS in shlwapi.h. CORE-16385

4 years ago[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385
Suraj K Suresh [Mon, 23 Dec 2019 08:51:51 +0000 (14:21 +0530)]
[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385

4 years ago[CRT] Define _INTEGRAL_MAX_BITS only if it isn't already defined by the compiler...
Hermès Bélusca-Maïto [Fri, 3 Jan 2020 18:33:21 +0000 (19:33 +0100)]
[CRT] Define _INTEGRAL_MAX_BITS only if it isn't already defined by the compiler. CORE-16555

4 years ago[NTDLL_APITEST] Addendum to ae8c9a1f: really test the "zero Length, non-zero MaximumL...
Hermès Bélusca-Maïto [Fri, 3 Jan 2020 16:41:14 +0000 (17:41 +0100)]
[NTDLL_APITEST] Addendum to ae8c9a1f: really test the "zero Length, non-zero MaximumLength" case. + add few simplifications.

4 years ago[BLUE] Add IOCTL buffers validation. Addendum to commit bfd8a848. 2172/head
Hermès Bélusca-Maïto [Tue, 24 Dec 2019 12:27:15 +0000 (13:27 +0100)]
[BLUE] Add IOCTL buffers validation. Addendum to commit bfd8a848.

Also convert all sizes and positions of CONSOLE_DRAW to USHORT since
this is the standard type for all console buffer positions & sizes
(minimum value 0, maximum value 0xFFFF == 65535).

4 years ago[NTDLL] Architecture specific spec file improvements
Timo Kreuzer [Sat, 21 Sep 2019 17:37:03 +0000 (19:37 +0200)]
[NTDLL] Architecture specific spec file improvements

4 years ago[NTDLL] Remove redundant Zw* -> Nt* forwarders
Timo Kreuzer [Sat, 21 Sep 2019 15:45:01 +0000 (17:45 +0200)]
[NTDLL] Remove redundant Zw* -> Nt* forwarders

4 years ago[NTDLL] Add some more stub exports
Timo Kreuzer [Sat, 21 Sep 2019 13:48:59 +0000 (15:48 +0200)]
[NTDLL] Add some more stub exports

4 years ago[RTL][NTDLL] Add some function stubs
Timo Kreuzer [Sat, 21 Sep 2019 10:46:01 +0000 (12:46 +0200)]
[RTL][NTDLL] Add some function stubs

- LdrSetAppCompatDllRedirectionCallback
- RtlCancelTimer
- RtlCreateServiceSid
- RtlQueryProcessHeapInformation
- RtlQueueApcWow64Thread
- RtlSetTimer
- RtlUnhandledExceptionFilter2
- RtlpNotOwnerCriticalSection

4 years ago[NTDLL] Export some more existing functions
Timo Kreuzer [Sat, 21 Sep 2019 11:26:54 +0000 (13:26 +0200)]
[NTDLL] Export some more existing functions

4 years ago[NTDLL] Ordinals -> @
Timo Kreuzer [Thu, 19 Sep 2019 13:56:29 +0000 (15:56 +0200)]
[NTDLL] Ordinals -> @

4 years ago[SPEC2DEF] Set ordinals explicitly in export def file
Timo Kreuzer [Sun, 22 Sep 2019 12:59:09 +0000 (14:59 +0200)]
[SPEC2DEF] Set ordinals explicitly in export def file

The reason is that dlltool orders the exports differently than MSVC builds (MSVC orders the exports by symbol name, rather than by export name), so we rely on sorting in the spec file, which was only respected, when ordinals were put into the def file.
On MSVC builds it is left to the linker to determine the correct order, which helps to get the differences between architectures right (different symbol decoration, difference between order for functions like NtLoadKey vs NtLoadKey2, which results from the stdcall decoration on x86, which is missing on other architectures.

TODO: To correctly handle non-x86 architectures with GCC builds, spec2def would need to reorder the export list based on symbol names, which would work for C functions, by taking the calling convention into account, but would require an extra c++-stdcall calling convention to be added to know the corresponding symbol starts with "?".

4 years ago[NDK][XDK][RTL] Fix definition of RtlFillMemoryUlong on x64
Timo Kreuzer [Mon, 23 Sep 2019 11:57:32 +0000 (13:57 +0200)]
[NDK][XDK][RTL] Fix definition of RtlFillMemoryUlong on x64

4 years ago[SETUP] Don't free a DLL that is still in use by a different thread
Timo Kreuzer [Tue, 13 Mar 2018 19:04:34 +0000 (20:04 +0100)]
[SETUP] Don't free a DLL that is still in use by a different thread

4 years ago[NTOS:KE] In KiExitV86Mode, restore KTSS::Esp0 to its standard value. CORE-16531 2123/head
Thomas Faber [Sun, 1 Dec 2019 19:36:13 +0000 (20:36 +0100)]
[NTOS:KE] In KiExitV86Mode, restore KTSS::Esp0 to its standard value. CORE-16531

The trap frame is in a random location on the stack, and setting Esp0 there
wastes significant amounts of space and may lead to unexpected stack overflows.

Also use a more descriptive expression for the V86 members of the KTRAP_FRAME.

4 years ago[WIN32K:NTGDI] Add missing probe to NtGdiGetPath.
Thomas Faber [Tue, 31 Dec 2019 20:07:39 +0000 (21:07 +0100)]
[WIN32K:NTGDI] Add missing probe to NtGdiGetPath.

4 years ago[WIN32K:NTGDI] Avoid breakpoints in syscalls.
Thomas Faber [Tue, 31 Dec 2019 20:06:43 +0000 (21:06 +0100)]
[WIN32K:NTGDI] Avoid breakpoints in syscalls.

4 years ago[NTOS:IO] Fix indentation. No code changes!
Eric Kohl [Thu, 2 Jan 2020 22:13:18 +0000 (23:13 +0100)]
[NTOS:IO] Fix indentation. No code changes!

4 years ago[LSASRV] Add parameter validation in LsapSetLogonSessionData().
Hermès Bélusca-Maïto [Tue, 18 Jun 2019 00:27:47 +0000 (02:27 +0200)]
[LSASRV] Add parameter validation in LsapSetLogonSessionData().

4 years ago[MSV1_0] Extend parameter validation in LsaApLogonUserEx2() and MsvpChangePassword...
Hermès Bélusca-Maïto [Tue, 18 Jun 2019 00:27:08 +0000 (02:27 +0200)]
[MSV1_0] Extend parameter validation in LsaApLogonUserEx2() and MsvpChangePassword(); fix crash in LsaApLogonUserEx2() when LogonDomainName points to a NULL string.

4 years ago[RTL] Fix RtlValidateUnicodeString() regarding the tests and add some SAL annotations.
Hermès Bélusca-Maïto [Thu, 2 Jan 2020 20:10:42 +0000 (21:10 +0100)]
[RTL] Fix RtlValidateUnicodeString() regarding the tests and add some SAL annotations.

4 years ago[NTDLL_APITEST] Add a test for RtlValidateUnicodeString().
Hermès Bélusca-Maïto [Thu, 2 Jan 2020 20:09:32 +0000 (21:09 +0100)]
[NTDLL_APITEST] Add a test for RtlValidateUnicodeString().

4 years ago[DISK_NEW] Return correct info size in failure case of DiskIoctlGetPartitionInfoEx.
Thomas Faber [Thu, 2 Jan 2020 15:26:50 +0000 (16:26 +0100)]
[DISK_NEW] Return correct info size in failure case of DiskIoctlGetPartitionInfoEx.

4 years ago[CDROM] Return the correct data length for IOCTL_DISK_GET_LENGTH_INFO. CORE-16607
Thomas Faber [Thu, 2 Jan 2020 12:27:19 +0000 (13:27 +0100)]
[CDROM] Return the correct data length for IOCTL_DISK_GET_LENGTH_INFO. CORE-16607

4 years ago[SHELL32] Fix extra fixme (#1975)
Maxim Smirnov [Thu, 2 Jan 2020 12:35:32 +0000 (15:35 +0300)]
[SHELL32] Fix extra fixme (#1975)

This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`

4 years ago[BOOTDATA] Add AppliedDPI registry value (#1966)
Oleg Dubinskiy [Thu, 2 Jan 2020 09:06:18 +0000 (11:06 +0200)]
[BOOTDATA] Add AppliedDPI registry value (#1966)

Add AppliedDPI DWORD registry value 0x00000060 (96 DPI) into HKCU\Control Panel\Desktop\WindowMetrics registry key. For now it does nothing, since saving DPI registry settings is not implemented yet. It's required only for ViStart 8 to be started successfully (with MS VB6 Runtime installed and wshom.ocx replaced). CORE-13877

4 years ago[FREELDR] Update ACPI Extended Attributes support to 6.3 (#1782) 1782/head
Serge Gautherie [Fri, 2 Aug 2019 15:39:50 +0000 (17:39 +0200)]
[FREELDR] Update ACPI Extended Attributes support to 6.3 (#1782)

Update BIOS_MEMORY_MAP and PcMemGetBiosMemoryMap() from ACPI 6.2-A to ACPI 6.3.

Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
4 years ago[FREELDR] Simplify the PrintText() and FrLdrBugCheckWithMessage() routines by using... 1777/head
Hermès Bélusca-Maïto [Wed, 1 Jan 2020 20:08:37 +0000 (21:08 +0100)]
[FREELDR] Simplify the PrintText() and FrLdrBugCheckWithMessage() routines by using a new PrintTextV() helper.

4 years ago[FREELDR] Reimplement i386PrintText(), adding line wrap handling. CORE-16268
Serge Gautherie [Wed, 31 Jul 2019 13:48:46 +0000 (15:48 +0200)]
[FREELDR] Reimplement i386PrintText(), adding line wrap handling. CORE-16268

Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
4 years ago[FREELDR] xboxcons.c, i386bug.c: Formatting and whitespace fixes.
Serge Gautherie [Wed, 31 Jul 2019 13:39:59 +0000 (15:39 +0200)]
[FREELDR] xboxcons.c, i386bug.c: Formatting and whitespace fixes.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
4 years ago[WS2_32_APITEST] Add some tests for GetAddrInfoW
Stanislav Motylkov [Sat, 28 Dec 2019 20:52:18 +0000 (23:52 +0300)]
[WS2_32_APITEST] Add some tests for GetAddrInfoW

Test results proves WSAStartup call should precede GetAddrInfoW calls.

4 years ago[SDK][INCLUDE] Total refinement of Gdiplus headers (#2223)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 11:28:42 +0000 (20:28 +0900)]
[SDK][INCLUDE] Total refinement of Gdiplus headers (#2223)

Missing functions added. CORE-16585

4 years ago[SDK][INCLUDE] Improve gdiplusgraphics.h (#2222)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 10:10:47 +0000 (19:10 +0900)]
[SDK][INCLUDE] Improve gdiplusgraphics.h (#2222)

CORE-16585

4 years ago[SDK][INCLUDE] Improve gdiplusmetafile.h (#2221)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 08:06:34 +0000 (17:06 +0900)]
[SDK][INCLUDE] Improve gdiplusmetafile.h (#2221)

CORE-16585

4 years ago[SDK][INCLUDE] Improve gdiplusmatrix.h (#2220)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 07:48:52 +0000 (16:48 +0900)]
[SDK][INCLUDE] Improve gdiplusmatrix.h (#2220)

CORE-16585

4 years ago[SDK][INCLUDE] Improve gdiplusstringformat.h (#2219)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 06:40:46 +0000 (15:40 +0900)]
[SDK][INCLUDE] Improve gdiplusstringformat.h (#2219)

CORE-16585

4 years ago[SDK][INCLUDE] Improve gdipluspath.h (#2218)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 06:40:05 +0000 (15:40 +0900)]
[SDK][INCLUDE] Improve gdipluspath.h (#2218)

CORE-16585

4 years ago[SDK][INCLUDE] Refinement of Gdiplus headers (#2217)
Katayama Hirofumi MZ [Wed, 1 Jan 2020 04:53:30 +0000 (13:53 +0900)]
[SDK][INCLUDE] Refinement of Gdiplus headers (#2217)

Define getNat helper functions in gdiplusbase.h and use them. CORE-16585

4 years agoHappy New Year 2020 to everyone!!
Hermès Bélusca-Maïto [Tue, 31 Dec 2019 23:00:00 +0000 (00:00 +0100)]
Happy New Year 2020 to everyone!!

🎊 🎆 🍾 🥳

.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
   __,  ,__)            __,  ,__)       __, ,__)        ░░▄████▄░▄███▄░▄████▄░▄███▄░░
  (--|__| _ ,_ ,_      (--|\ | _       (--\ | _  _ ,_   ░░▀▀░▄██░██░██░▀▀░▄██░██░██░░
    _|  |(_||_)|_)(_|    _| \|(/_(_|_)     \|(/_(_||    ░░░▄██▀░░██░██░░▄██▀░░██░██░░
   (        |  |  ,_|   (                (__|           ░░██████░▀███▀░██████░▀███▀░░
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.

   ███████████████████████████████████████████████████████████████████████████████
   ██████████████████▓▒▒▒▒▒▒▓▓█████████████████████████▓▓▒▒▒▒▒▒▓██████████████████
   ███████████████▒▒▒▒▓▓███▓▓▓▒▒░▒▓▓█████████████▓▒▒░▒▒▓▓████▓▓▒▒▒▓███████████████
   █████████████▓░░░░░░░░░▒▒▓██████▓▒▒▒▓█████▓▒▒▒▓██████▓▒▒░░░░░░░░░▓█████████████
   ███████████▒▓░▒█████████▓▓▒░▒▓███▓▓▓▓▓▓▓▓▓▓▓▓████▒▒▒▒▓▓████████▓▒░▓▓███████████
   ██████████▒▒▓░▓██████████████▓▓▓▓▓█████▓▓▓▓▓▓▓▓▒▒███████████████▓░▓░▒██████████
   █████████▓░▓█░▓██████████▓▒▒▒▒▓▓▓▓███████▓▓▓▓▓▓▓▓▓▒▒▓███████████▓░█▒░▓█████████
   █████████▓▒██▒▒████████▒▒░░░░▒▒▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▒▒░█████████▒▒█▓▒▒█████████
   █████████▓░██▓░▓█████▓▓▒▒░░░░▒▒▓▓▓▓████▓▓▓▓▓▓▓▓▒▒▓▓▓▓▓▒░░▓█████▓░▓█▓░▓█████████
   ██████████░▓██▒▒▓██▓▓▓▓▓▒▒▒▒▒▒▓▓▓▓██████▓▓▓▓▓▓▒▒▒▒▒▓▓▓▓▒▒░░███▓░▒██▒░██████████
   ██████████▒▒▓██▒▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████▓▓▓▒▒▒▒▒▒▒▒▒▓▒▒▒▒░░▓█▒▒██▓░▓██████████
   ███████████▒▒███▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓████▓▓▓▓▓▓▒▒░▒▒▒▒▒▒▒▒▒░░░▒███▒▓███████████
   ████████████▒▒█▓▓▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒▒░░░░▒▒░░░▒▒▒░░░▓██▒▒████████████
   █████████████▒▒▒▒▒▒░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓▒▒░░░░░░░░░░░░░▒▒▒▓▒▒█████████████
   ██████████████░░▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒░░░░░░░░░▒░░▒░▒██████████████
   ██████████████▓▒░▒▒▒▒▒░░▒▒░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░▓███████████████
   ██████████████▓▒▓░░▒▒▒▒░░░░░░░░░░░░░░░░░▒▒▒▒▒▒░░░░░░░░░░▒░░░░░▓▒▓▓█████████████
   ███████████▓▒▓▓▓▒▒░░░░░▒▒░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░░▒▒▒█▒▒▓███████████
   ██████████▓▒▒█▓▓▒▒░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▓▒▒▒▒██▒▒▓██████████
   █████████▓▒▓██▓▒▒▒▒░░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▒▒▒▒▒▒▓███▓▒▓█████████
   ████████▓▒▓███▓▒▒▒▒░░░▒░░░░░░▒░░░░░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▓▓▒▒▓▒▓██▓▒▓████████
   ███████▓▒▓███▒▓▓▒▒▒░░░░░▒░░░░░░▒░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▓▓▓▓▒▒██▓▒▓██▓▒████████
   ███████▒▒██▓▒▓█▓▓▒▒░░░░░░░▒░░░░░░▒░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▒▓▓▓▒▒▓███▓▒███▒▓███████
   ██████▓▒▓██▒▒███▓▒▒▒░░░░░░░░▒▒░░░░░▒▒░░░░░░░░▒▒░░▒▓▓▓▓▒▒▒▒▒▒▓█████▒▒██▓░▓██████
   ██████▒▒██▒▒█████▓▒▒▒░░░░░░░░░▒░░░░░░░▒░░░░▒▒░░▒▓▒▒▒▒▒▒▒▒▒▒████████▒▒██▒▒██████
   ██████▒▓██░▓██████▓▓▒▒▒░░░░░░░░░░▒░░░░░░░▒░░░░▒▒▒▒▒▒▒▓▓▒▒██████████▒░██▒▒██████
   ██████▒▒▓▓▒█████████▓▓▒▒▒░░░░░░░░░░▒▒░░░░▒▒▒▓░░░▒▒▒▒▒▓▓████████████▓▒▓▓░▒██████
   ██████▓░▒▒▒███████████▓▓▒▒░░░░▒▒▒░▒░▒▒▒▒░░▒▒▒▒▒▓▒░░▒▒██████████████▓░▒▒▒███████
   ███████▓▒░░▒█████████▓▒▒░░▒▓▓▒▒▒░░░░▒▒▒▓▒▓▒░░▒▒▓▓██▓▓▒░▒▒▓█████████▒░░▒████████
   ██████████▒░░░░░░░▒▒▓▓█████▓▓▒░░▒▓██▓▓████████▒░▒▒▓██████▓▓▒▒░░░░░░░▒██████████
   ███████████▓▒▒▒▓▓████▓▓▒▒▒░▒▒█████████████████████▒▒░▒▒▓▓▓███▓▓▒▒▒▒████████████
   ████████████████▓▓▓▓▓▓███████████████████████████████████▓▓▓▓▓▓████████████████
   ███████████████████████████████████████████████████████████████████████████████
   ███████████████████████████████████████████████████████████████████████████████
   ██████████████████████████████████████████████████████████▓░░▓████████░░░▓█████
   ███▒░░░░▒▓███████████████████████████████████████▒█████▓▒▒▓██▓▒▒▓████▓░█▓░▓████
   ███▒█████░▒███▓▒▒▒▒▒▓████▓▒▒▒▒▒▓█▓███▓▒▒▒▒▒▒▓██▓▒░▒▒▓▒▓█████████▓▒██▓▒█████████
   ███▒█████░▒█▓▒▒█████▒▒██▒▒▓████▓░▒██▒▒▓████▓▒▓██▓░▓██▓███████████▓▓██▓░░░▒█████
   ███▒█▓░░▒▓█▓▒▒▓▒░░▒▓▒░▒▓▒███████▒▒██▒████████████░███▓███████████▓▓██████░▒████
   ███▒██░▓███▓▒▓█████████▓▒███████▒▒██▒████████████░███▒▓██████████▓████████░▓███
   ███▒███░▒▓██▓▒▒████▓▒▓██▓▒▒▓██▓▒░▒██▓▒▒▓███▓▒▓███░████▓▒▒█████▒▒▓███▓▒▓██░▓████
   ███▒████▓░▓████▒▒▒▒▒██████▓▒▒▒▒▓█▓████▓▒▒▒▒▓█████▒███████▓▒▒▒▒▓███████▒▒▒▓█████
   ███████████████████████████████████████████████████████████████████████████████

4 years ago[ADVAPI32] OpenSCManagerA/W: Set the last error even in case of success
Eric Kohl [Tue, 31 Dec 2019 22:23:23 +0000 (23:23 +0100)]
[ADVAPI32] OpenSCManagerA/W: Set the last error even in case of success

This fixes a failure in the QueryServiceConfig2 api test.

4 years ago[LSASRV] LsarLookupSids: Return proper domain information for nameless domains
Eric Kohl [Tue, 31 Dec 2019 16:59:10 +0000 (17:59 +0100)]
[LSASRV] LsarLookupSids: Return proper domain information for nameless domains