Joachim Henze [Mon, 15 Jul 2019 01:35:42 +0000 (03:35 +0200)]
[0.4.12][BOOTDATA][SETUP] Fix regression CORE-16200 font rendering
By removing font substitution for 'Microsoft Sans Serif'.
Thanks to the patches author Katayama Hirofumi MZ.
This is a partial revert of the guilty rev
master guilty 0.4.13-dev-9-g
811faed421a798659af3cb3f09369af84fc4edf0
RC guilty 0.4.12-RC-13-g
8d3def0529e7e1bb9095713d46f5fbb64df0d299
VBox test result:
https://reactos.org/testman/compare.php?ids=68497,68499
Joachim Henze [Sun, 7 Jul 2019 22:05:00 +0000 (00:05 +0200)]
[0.4.12][WIN32SS] Workaround Marlett drawing for Window close buttons CORE-16125
It regressed for RC by 0.4.12-RC-16-g
e1ac9dcd66f2438818e194efa0905d05243c4107
and for master by 0.4.13-dev-110-g
19fc9415bfc811c6c0eef197f72d8bdffcfedba2
Thanks to Katayama Hirofumi MZ, the workarounds author.
We think it is a workaround, so we will not commit to master.
Testbot runs (executed on master) seem to be non-alarming
VBox https://reactos.org/testman/compare.php?ids=68471,68479
KVM https://reactos.org/testman/compare.php?ids=68472,68480
Joachim Henze [Sun, 7 Jul 2019 16:21:19 +0000 (18:21 +0200)]
[0.4.12][WIN32SS][FREETYPE] Fix performance regression FreeBASIC console output CORE-16177
By restoring historic state of GreExtTextOutW() / IntExtTextOutW()
This reverts guilty rev 0.4.12-dev-190-g
d6cfeaef5105dc6db2f12682bc48f17f9caacdcc
as well as some follow ups that dealt with new errors popping up afterwards.
The revert got ack of Katayama Hirofumi MZ.
Test VBox on master: https://reactos.org/testman/compare.php?ids=68471,68475
Test KVM on master: https://reactos.org/testman/compare.php?ids=68472,68476
I intend to restore the function to that same state in master today.
Joachim Henze [Sat, 6 Jul 2019 10:38:43 +0000 (12:38 +0200)]
[0.4.12][NTOSKRNL] Restore section layout to fix BSOD regression CORE-14683
This fixes high chance for BSOD 0x50 PAGE_FAULT_IN_NONPAGED_AREA
when booting after DVDwriteNow has been installed.
Many thanks to the fixes author Thomas Faber.
We believe this was a regression of SVN r55835
6ebf8c253770af0c029f1d7937a33235108d59e3
The fix has not been applied to master yet.
Hermès Bélusca-Maïto [Sat, 13 Apr 2019 23:17:15 +0000 (01:17 +0200)]
[0.4.12][GDI32] Do not 'hard-assert' during the font-unit-test
The goal of this is to revive the VBox-testbot that failed miserably
like the VBox-one in
https://build.reactos.org/#/builders/9/builds/24947
all the way through the 0.4.12RCs, because 0.4.12-dev was in a poor state
upon branching.
cherry picked from commit 0.4.13-dev-23-g
7334567211b921220ef82f168ef8e4bc7d5b2724
Joachim Henze [Fri, 21 Jun 2019 22:09:47 +0000 (00:09 +0200)]
[0.4.12][COMCTL32] Fix regression CORE-14619 "Checkbox buttons theming"
It regressed by Wine sync in 0.4.9-dev-719-g
b3fb8555bf9abcc04eeac31c7153d33e2f027fc0
The fix has not been committed to master yet,
it is a partial sync to Wine Staging 3.3
Thanks to the patches author Andreas Maier <staubim@quantentunnel.de>
JIRA username 'andy-123'
two testbot runs:
https://reactos.org/testman/compare.php?ids=68367,68369
https://reactos.org/testman/compare.php?ids=68367,68371
Katayama Hirofumi MZ [Thu, 20 Jun 2019 09:58:45 +0000 (18:58 +0900)]
[0.4.12][WIN32SS][NTGDI] usWinAscent and usWinDescent must be treated as signed (#1670)
TT_OS2.usWinAscent and TT_OS2.usWinDescent must be treated as FT_Short.
These values affect font metrics.
This PR will fix CORE-14994 that regressed by 0.4.10-dev-466-g
35f62fc5ba0b69e7335ff41400cb3b45660f4557
cherry picked from commit 0.4.13-dev-483-g
641a0ea99be50975e79498e48ae73b2edfc5c616
Andreas Maier [Tue, 18 Jun 2019 20:40:27 +0000 (22:40 +0200)]
[0.4.12][EXPLORER] Properly initialize tbBtn.iBitmap. CORE-14262 PR#1667
In CNotifyToolbar::AddButton tbBtn.iBitmap (imagelist-index)
was initialized with 0. TightVNC adds the icon without NIF_ICON flag.
So the wrong icon index was kept and later replaced.
This fixes an old regression visible since SVN r68893
cherry picked from commit 0.4.13-dev-481-g
8d6c9e844c9b5e8a33344c9768e0d2fa305445c5
Andreas Maier [Tue, 18 Jun 2019 19:00:43 +0000 (21:00 +0200)]
[0.4.12][EXPLORER] fix traces PR#1667
cherry picked from commit 0.4.13-dev-480-g
7796df375a29c2881803de4d4ce6e4b0d43245ae
Mark Jansen [Sun, 16 Jun 2019 19:54:44 +0000 (21:54 +0200)]
[0.4.12][INPUT] Don't race the system to free an imagelist
Fixes CORE-16121
"reproducible heap assertion at 2nd setup stage when
adding additional keyboard layouts"
https://reactos.org/testman/compare.php?ids=68231,68234
cherry-picked from 0.4.13-dev-459-g
f3d1d380412dada010053165ec5070907b41d10c
Joachim Henze [Sun, 16 Jun 2019 11:07:55 +0000 (13:07 +0200)]
[0.4.12][WIN32K:ENG] Fix fullscreen switch regressions CORE-15325 & CORE-14684 PR#1659
In PDEVOBJ_vRefreshModeList, find a proper match for the current
display mode instead of assuming a constant index.
Both tickets regressed by SVN r74404
384affe098a91ce38623e4703f25ab139eff68de
Many thanks to the patches author Thomas Faber.
cherry picked from commit 0.4.13-dev-456-g
00e882c2b1ba302d01c2c63a803d78e4fbac7168
Joachim Henze [Sat, 15 Jun 2019 15:50:36 +0000 (17:50 +0200)]
[0.4.12][LPK] Fix for regression CORE-16115. (#1654)
Fixes "STDU Viewer 1.6.375 crashing"
A regression of 0.4.12-dev-933-g
7143e411c46380b4ec73f51b481c382504602901
Proposed changes of author Baruch Rutman aka "peterooch" peterooch@gmail.com:
- Use the total extent (width) and font metrics (height) as values
to put in the lpSize variable instead of calling ScriptString_pSize()
in the LpkGetTextExtentExPoint() function.
- Use GetTextExtentExPointWPri in more cases as another effort to get the data.
Many thanks for that prompt fix!
Master got fixed similar in 0.4.13-dev-445-g
22064d7787514c72ab5d3db5da4d0929cab73b15
Joachim Henze [Fri, 14 Jun 2019 21:02:55 +0000 (23:02 +0200)]
[0.4.12][MSI] Fix regression CORE-14646
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.
The regession was introduced to ros by 0.4.8-dev-739-g
f8b992f2d31aaea06dd6a360ad19165d56c331dc
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445
Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.
I also committed the same fix to master during 0.4.13-dev.
Joachim Henze [Wed, 12 Jun 2019 23:25:28 +0000 (01:25 +0200)]
[0.4.12][NTOS:PNP] Workaround a BSOD with HDAUDIO during boot PR#1560 CORE-15874
Thanks to Thomas Faber, author of the patch.
I depend on external testers here for confirmation of effectiveness.
We think the problem was unhidden by 0.4.12-dev-757-g
789cfd3ddc6cd15d80db120d0ddcc1e7616ce85d
and surrounding works.
When traversing the device tree, keep a reference to the current device.
Devices can be deleted during the traversal, so in order to keep
the tree walk intact without use-after-free situations,
this just keeps the PDO around until we no longer need the device node.
It could be argued that this is a hack, however implementing it the "correct way"
(I haven't actually researched how Windows does this) is unlikely to be possible
with our current PNP manager -- so this should keep us going for a while.
Joachim Henze [Wed, 12 Jun 2019 18:12:21 +0000 (20:12 +0200)]
[0.4.12][COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147
But greatly improves perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We still fear that this workaround could break buttons that
intend to change their appearance when being hovered.
We workaround only the RC, but will leave master affected for now.
Joachim Henze [Mon, 10 Jun 2019 13:38:23 +0000 (15:38 +0200)]
[WIN32SS][NTUSER] Addendum to
0.4.12-dev-956-g0197c4f CORE-15893
Aims PixelPerfection for a regression that was introduced by
0.4.12-dev-954-g
1f619b27814f3bbf9673754a69bcae50c89fed19
and then improved already by
0.4.12-dev-956-g
0197c4f875d3332dbc4656a6360e3c7e9def2ed5
The tweaking got ack of Jim Tabor. Test results:
https://reactos.org/testman/compare.php?ids=68026,68029
cherry-picked from 0.4.13-dev-397-g
3cc50cedaf5e74041608d403054d1fe6394596e6
Joachim Henze [Sun, 9 Jun 2019 20:41:25 +0000 (22:41 +0200)]
[0.4.12][COMCTL32] Addendum to last commit
CORE-14433, CORE-15892, CORE-15118, CORE-15529
Similar to commit5 from PR#1211
Joachim Henze [Sun, 9 Jun 2019 09:54:37 +0000 (11:54 +0200)]
[0.4.12][COMCTL32] Fix multiple regressions v5/v6 imagelist when SxS
The problems began when we committed the two SxS commits
0.4.8-dev-502-g
7000fe2340aedfd1c1fc643f50d1aa1036c7530e
and
0.4.8-dev-503-g
f318a25e1059d0a80999ebf649ea215b584c3a0e
Since then incompatible comctl32 v5/v6 imagelist were in mixed usage.
The new comctl32 patch fixes the following regressions:
- CORE-14433 MSVCPP 6 installer browseForFolder-dlg lacked icons
- CORE-14433 MS Word Viewer 2003 open-dlg lacked icons
- CORE-15118 OCR CuneiForm 12 lacked icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacked checkboxes
- CORE-15529 Bulk Rename utility lacked icons
Fixing comctl32 directly was applied to 0.4.12RC for the first time.
Older releases always used a partial SxS revert instead.
Master is still unpatched to date.
The fix is a combination of the first 4 commits of PR#1211 and
the attached is_valid.diff. Thanks to everyone involved:
Giannis Adamopoulos, Mark Jansen and Andreas Maier!
Joachim Henze [Thu, 6 Jun 2019 00:21:36 +0000 (02:21 +0200)]
[0.4.12][WIN32SS][FREETYPE] Avoid performance regression CORE-16020
by reverting essential parts of "Font rotation at arbitrary angles"
which was once committed in several steps:
Initial commit (PR#1207)
0.4.12-dev-243-g
f757a135192c02a3c41d8da47eb9dba21d34ebd1
broke font rendering for GTK apps CORE-15623
Second commit (PR#1238)
0.4.12-dev-558-g
64987cf2731f9762d0316274bf7877a9bd3d88ba
restored font rendering in GTK apps but introduced slowdown CORE-16020
Katayama agreed to the temporal revert and will try to come up later
with a performance optimized version.
We revert in 0.4.12-RC and 0.4.13-dev.
The revert will cause failure-increases in gdi32:TextTransform.
Joachim Henze [Sun, 2 Jun 2019 21:50:06 +0000 (23:50 +0200)]
[0.4.12][WIN32SS] Revert "Make App Switcher use the owner window's icon (#1299)"
to protect our latest improvement of showing correct cpl icons in taskswitch
CORE-16086
This reverts commit
0.4.12-dev-437-g
484943d04f0dc3f84b7c8e754d1d2505f0a41df3
which was done in context of CORE-15672
(without being able to resolve that ticket)
0.4.12-dev-437 contrasts our latest information c.f. Raymond Chen's article:
http://blogs.msdn.com/b/oldnewthing/archive/2007/10/08/
5351207.aspx
Eventually we should select the icon instead using that same algorithm.
Joachim Henze [Sun, 2 Jun 2019 12:23:18 +0000 (14:23 +0200)]
[0.4.12][UNIATA] Apply workaround for regression CORE-16078, booting broke on specific Intel Z170
JIRA-user "Illen" reported booting from his Z170 controller worked up to
0.4.12-dev-936-g89aaf0e
and would refuse booting - beginning with uniata commit
0.4.12-dev-937-g
b54613073127f5204660d9e9ab86159fea06b23e
For sure this workaround is just a temporary and no proper solution,
but was confirmed to be working by "Illen". We have no clear understanding of the real bug yet.
Can be replaced by something better at any time.
It was just committed into the RC, master remains affected.
Joachim Henze [Sun, 2 Jun 2019 11:15:37 +0000 (13:15 +0200)]
[0.4.12][COMCTL32] Fix regression with disabled menubar buttons in IDA5free CORE-14209
The patch was not committed to master yet. Currently is still under review in PR-1599.
The patch also improves the rendering of disabled menubar buttons for SumatraPDF CORE-10601.
Even after the patch we are not perfect at deciding when to draw masked
and when to draw desaturated in 32bpp, but it definitely improves end users experience.
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
Joachim Henze [Sat, 1 Jun 2019 20:53:16 +0000 (22:53 +0200)]
[0.4.12][MSHTML] Fake Success in HTMLDocument_put_bgColor()
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error
8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
cherry picked from commit 0.4.13-dev-327-g
bc3eed68ca1f4c5aa66ceaca4fc8ae405714699e
Joachim Henze [Mon, 27 May 2019 18:22:53 +0000 (20:22 +0200)]
[0.4.12] [WIN32SS][NTGDI] Fix regression BSOD in QIP CORE-16059 and similar BSODs by avoiding FLOAT in kernel
This is a squashed backmerge of
PR1572 FLOAT in IntEscapeMatrix
0.4.13-dev-255-g
01370964495a0769edafb76a06e7b5a81374c1fc
PR1574 FLOAT for orientation
0.4.13-dev-257-g
fabbd7c1c162dc4dec8a23f8470cafb8871d4675
PR1576 FLOAT in ftGdiGetGlyphOutline
0.4.13-dev-270-g
86046a9bf4af57551308331631447c7ccfa87fe9
Those 3 commits were part of CORE-15838.
All those regressions have been introduced during 0.4.12-dev'ing.
Joachim Henze [Tue, 21 May 2019 22:30:10 +0000 (00:30 +0200)]
[0.4.12] [NtUser] Apply review of jimtabor
to the workaround in last commit 0.4.12-RC-19-g
700779e643d4154d4a8bb569810171aaa4f3c72a
Many thanks to reviewer jimtabor for this very prompt review!
I tested, the new state still succeeds in CORE-15477, CORE-14979, CORE-15599, CORE-15600, CORE-15654
Fixes 'multiple apps leaving the taskbar visible erroneously when switching into fullscreen.'
Please note that the problem with taskbar staying visible is only fixed for some, but not all apps
(see CORE-11242 for some still failing examples, e.g: Bound Around).
We now have the same state in 0.4.12RCs, that we just have committed to master in 0.4.13-dev-247-g
0f29b3faa7770c441d084e4b41ceba555d4181ab
Joachim Henze [Tue, 21 May 2019 20:51:45 +0000 (22:51 +0200)]
[0.4.12] [NtUser] Workaround regressions CORE-15477, CORE-14979, CORE-15599, CORE-15600, CORE-15654
Fixes 'multiple apps leaving the taskbar visible erroneously when switching into fullscreen.'
Please note that the problem with taskbar staying visible is only fixed for some, but not all apps (see CORE-11242 for examples).
This partially reverts commit
09ab5ea7ed2ab0e709ed2e8f8f9f6c3711b2ac7f (SVN r75407)
I applied this interim solution into 0.4.12RCs for the very first time and rls-tests still
have to prove it being free of obvious side-effects.
Theoretically we could still switch to a better solution at any time.
The workaround never was applied to master to date.
https://reactos.org/testman/compare.php?ids=67536,67539
Joachim Henze [Thu, 16 May 2019 22:47:16 +0000 (00:47 +0200)]
[0.4.12] [JSCRIPT] Fix regression CORE-13810 "Vypress Chat 2.1.9 MSI setup fatal error"
The regression was unhidden by MSI-winesync 1.5.10 almost 7years ago:
8939969e21ddd1472e64596e11dee2ab58c9025e
Finally we can fix it by adding MS enumerator extension to Jscript.
Many thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
The patch is WIP and was not committed to master yet.
https://reactos.org/testman/compare.php?ids=67482,67485
jimtabor [Thu, 11 Apr 2019 01:52:01 +0000 (20:52 -0500)]
[0.4.12] [NtUser] Fix Theme Non Client Painting, fixes the visible parts of regression CORE-15934
Resizing a themed window does not longer show a flashing rectangle in the title-bar after the fix.
Still this seems to be work-in-progress even after this first commit, but makes me happy for 0.4.12RCs
for now.
See CORE-7166 & CORE-15934.
cherry picked from commit 0.4.13-dev-8-g
cfdf36e44250048b3377f333c93bc311e424ac3d
Katayama Hirofumi MZ [Sat, 27 Apr 2019 00:38:01 +0000 (09:38 +0900)]
[0.4.12] [WIN32SS][NTGDI] FireFox checkmark, fixes regression CORE-15303 (#1535)
The font size was a bit larger than expected.
FireFox will show checkmarks correctly in View menu.
This is a partial revert of 0.4.10-dev-466-g
35f62fc5ba0b69e7335ff41400cb3b45660f4557
cherry picked from commit 0.4.13-dev-110-g
19fc9415bfc811c6c0eef197f72d8bdffcfedba2
Katayama Hirofumi MZ [Thu, 11 Apr 2019 09:23:32 +0000 (18:23 +0900)]
[0.4.12] [WIN32SS][NTGDI] CORE-15755 commit 3 of 3
Delete unnecessary (ULONG) cast
cherry picked from commit 0.4.13-dev-11-g
983cd57c1eaae41383f850d2372170bb0b4a5efb
Katayama Hirofumi MZ [Thu, 11 Apr 2019 08:57:57 +0000 (17:57 +0900)]
[0.4.12] [GDI32][NTGDI] Avoid integer overflow CORE-15755 commit 2 of 3
Follow up of #1492. CORE-15755
- Use RtlULongMult function to check integer overflows.
cherry picked from commit 0.4.13-dev-10-g
bc9f3ed887861dfcc935ab077eaeea38b4cf1b1d
Katayama Hirofumi MZ [Thu, 11 Apr 2019 02:46:52 +0000 (11:46 +0900)]
[0.4.12] [GDI32][NTGDI][SETUP] CORE-15755 commit 1 of 3
Fix font enumeration part 2 (#1492)
Eliminate some bugs about font enumeration.
- Add "Microsoft Sans Serif" font substitution.
- Fix and improve the treatment of the nominal font names.
- Split IntGetFontFamilyInfo function from NtGdiGetFontFamilyInfo.
- Add DoFontSystemUnittest function for font system unittest to GDI32.
- Call DoFontSystemUnittest function at CreateFontIndirectW first call.
cherry picked from commit 0.4.13-dev-9-g
811faed421a798659af3cb3f09369af84fc4edf0
Katayama Hirofumi MZ [Fri, 26 Apr 2019 12:56:36 +0000 (21:56 +0900)]
[0.4.12] [WIN32SS][NTGDI] Keep FontSubstitutes enumeration CORE-15785 (#1532)
Fixes regression CORE-15785.
When LOGFONT.lfFaceName[0] == 0, then enumeration of font substitutes had failed.
CORE-15785 commit 2 of 2
cherry picked from commit 0.4.13-dev-107-g
ae8417fd9068dd32ec180636117bba1dc0603325
Katayama Hirofumi MZ [Tue, 9 Apr 2019 08:39:42 +0000 (17:39 +0900)]
[0.4.12] [GDI32] Improve IntFontFamilyListUnique function (#1491)
Make gdi32!IntFontFamilyListUnique function std::unique compatible.
Previous code didn't set the first entry correctly.
CORE-15785 commit 1 of 2
cherry picked from commit 0.4.13-dev-5-g
ae80eb824e882f7ed2f6f163922bee30c63284ad
Joachim Henze [Thu, 9 May 2019 18:14:20 +0000 (20:14 +0200)]
[0.4.12] [NTDLL/LDR] Revert the 0.4.12-workaround for comctl32 imagelist
This reverts 0.4.12-RC-2-g
f57e9ed9260956ebd7e0293d4a72cffd994fd064
and therefore brings the SxS state back to master. It allows many SxS-dependent apps to run again that broke by the new 0.4.12-workaround.
e.g: Miranda 0.10.48
Unfortunately this will expose many issues for the first time in the 0.4.12release (same way like in master),
that I could properly hide in all past releases by a different workaround (that we can not longer use due to heavy 0.4.12-dev SxS works)
This commit reintroduces:
- CORE-14433 MSVCPP 6 installer open-dlg, MS Word Viewer 2003 open-dlg lacks icons
- CORE-15118 OCR CuneiForm 12 lacks icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacks checkboxes
We think that all those issues are caused by incompatible comctl32 v5/v6 imagelists actually.
If time will allow it, I might experiment with some macros later to hide the comctl32-issue leaving SxS intact.
Joachim Henze [Mon, 15 Apr 2019 17:46:36 +0000 (19:46 +0200)]
[0.4.12] [WIN32SS] Appease regression CORE-15429 & fix CORE-15911
By applying for the first time clientFix.patch from CORE-15911 contributed by JIRA-user 'I_Kill_Bugs'.
The patch acts as a better replacement for a workaround of DougLyons from CORE-15429
that aimed to hide the issue for our file-browser only.
The new approach gave good results for the testbots
https://reactos.org/testman/compare.php?ids=66723,66729
but wasn't tested much yet. In case it causes any problems during testing-cycle,
I might eventually switch back to our old workaround instead from the last releases.
jimtabor [Thu, 11 Apr 2019 00:24:50 +0000 (19:24 -0500)]
[0.4.12] [DDraw] Fix DxDiag tests. Fixes regression CORE-15905
After the DC work is done while before releasing the DC flush the GDI batch.
See CORE-15905. Someone may need to notify wine about this change.
cherry picked from commit 0.4.13-dev-7-g
84d518b19089c04f0423a7e99dda2728fc7670a7
Joachim Henze [Wed, 10 Apr 2019 23:19:29 +0000 (01:19 +0200)]
[0.4.12] Revert "[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF"
To avoid CORE-15804 MSTSC fails to connect with error "ERROR: Bad packet header"
This reverts commit 0.4.12-dev-752-g
6bc61f63f1e0ad20ab09f881d6968558eba9a8e6.
Joachim Henze [Sun, 16 Dec 2018 23:14:06 +0000 (00:14 +0100)]
[0.4.12] Revert "[NTOSKRNL] Properly align VACB writes"
to avoid CORE-15384 "ros corrupts FAT16 partition"
This reverts commit 0.4.11-dev-210-g
2a80ae2bb6fdb4135d41244335caa2dadb6c8fa9
Like we did in 0.4.11rls.
I would happily switch over to a proper working fix from master later.
I would also do that if it appeared only after this interim solution got committed.
(cherry picked from commit
78cd6265d97f635d6e19a109e58250d038b0ce10)
Joachim Henze [Tue, 19 Jun 2018 18:56:21 +0000 (20:56 +0200)]
[0.4.12] [COMCTL32] Appease regression CORE-14671 & CORE-14701
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.
Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).
Thanks to patches author Doug Lyons.
The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.
like in last release
(cherry picked from commit
b906163dc1a657e759985636fd68ff87fb68c251)
Joachim Henze [Wed, 10 Apr 2019 11:25:10 +0000 (13:25 +0200)]
[0.4.12] Avoid regression CORE-14955 "Ddraw fullscreen crashes"
This brings us back to before commit 0.4.10-dev-55-g
7af3969e9fe68b5f55a088f93a6b69570822c733
and therefore downgrades D3D8,D3D9,DDRAW,WINED3D to 3.3 for this rls.
This is same versions as we had in 0.4.10rls (I used same revert then)
Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
DxDiag crashed when switching to fullscreen,
Diablo II crashed immediately,
Monster-Truck-Madness 2 demo crashed after main menu
Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.
This will be the interim fix, which I will keep for rls at least
until someone manages to fix CORE-14955 properly in master with current Wine.
analog to 0.4.10-RC-17-g
bb4c55d650a465d9b3f0ff46a7bf10b1ee2fcb0a
Joachim Henze [Sat, 17 Feb 2018 19:28:15 +0000 (20:28 +0100)]
[0.4.12] [RDBSS] Avoid CORE-13938
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"
I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?
Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.
like in last release
(cherry picked from commit
26080d0c644e3f503948ca2a722813c47acc71bc)
Joachim Henze [Tue, 9 Apr 2019 20:09:45 +0000 (22:09 +0200)]
[0.4.12] [NTDLL/LDR] Avoid multiple regressions
By reverting just commit 0.4.8-dev-502-g
7000fe2340aedfd1c1fc643f50d1aa1036c7530e.
It fixes:
- CORE-14433 MSVCPP 6 installer open-dlg, MS Word Viewer 2003 open-dlg lacks icons
- CORE-15118 OCR CuneiForm 12 lacks icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacks checkboxes
We think that all those issues are caused by incompatible comctl32 v5/v6
imagelists actually.
Please notice, that in the past ros-releases, I used to revert additionally
0.4.8-dev-503-g
f318a25e1059d0a80999ebf649ea215b584c3a0e
but since a lot of LDR work was done during 0.4.12-dev I was forced to
minimize the needed revert this time in order to not threaten
recent LDR-work done by Mark & Thomas
Thomas Faber [Sun, 30 Jul 2017 10:58:32 +0000 (10:58 +0000)]
[0.4.12] [WIN32SS] Mask WndProc exceptions to hide all tickets linked to CORE-11915
e.g. this allows using MsDepends
Unfortunately still necessary, luckily still effective
like in last release
cherry picked from commit
bca25b10b4cd5603daa3863a0d9fd1762e82bfb1
Joachim Henze [Mon, 8 Apr 2019 16:29:18 +0000 (18:29 +0200)]
[0.4.12] Branch releases/0.4.12 & change KERNEL_VERSION_BUILD_TYPE "RC"
Stanislav Motylkov [Mon, 8 Apr 2019 14:19:16 +0000 (17:19 +0300)]
[THEMES][CMAKE] Cmake file fixup for Modern theme
Addendum to
00ff951. CORE-13020
Jake Collins [Sun, 17 Mar 2019 22:27:56 +0000 (22:27 +0000)]
[THEMES] Overhaul ReactOS modern theme. CORE-13020 (#1424)
Katayama Hirofumi MZ [Mon, 8 Apr 2019 12:59:33 +0000 (21:59 +0900)]
[SHELL32] Fix SHFileOperation Move operation (#1487)
Reduce failures of Move operation of shell32!SHFileOperation function. CORE-13450
Victor Perevertkin [Mon, 1 Apr 2019 01:00:52 +0000 (04:00 +0300)]
[USBHID] Do not assert if the device was unplugged during an operation.
Stanislav Motylkov [Sun, 7 Apr 2019 20:12:15 +0000 (23:12 +0300)]
[RAPPS] Update Russian translation
Addendum to
07f3691 and
d5b4570.
Stanislav Motylkov [Sun, 7 Apr 2019 20:10:23 +0000 (23:10 +0300)]
[SYSSETUP] Update Russian translation
Addendum to
5d4d48a,
21b7648, and
ea799b7.
Foxlet [Sat, 6 Apr 2019 02:10:59 +0000 (22:10 -0400)]
[SYSSETUP] Add Mizu to syssetup.
Foxlet [Thu, 4 Apr 2019 07:40:12 +0000 (03:40 -0400)]
[THEMES] Mizu Theme RC.
Foxlet [Thu, 4 Apr 2019 07:35:42 +0000 (03:35 -0400)]
[FONTS] Add Source Sans font family.
Source Sans Pro sourced from https://github.com/adobe-fonts/source-sans-pro ,
Source Code Pro sourced from https://github.com/adobe-fonts/source-code-pro
Hervé Poussineau [Sun, 7 Apr 2019 19:00:33 +0000 (21:00 +0200)]
[CMAKE] Temporarly disable pch in some modules to fix travis-ci
Problem appeared after
09c4d0a74b2362e2c9d29ec87c54ecc3bddd5b79
Hervé Poussineau [Sun, 7 Apr 2019 17:08:53 +0000 (19:08 +0200)]
[UDFS] Fix macros to support 'bit' being a complex expression
This is for example used in udf_info/mount.cpp:
UDFSetUsedBits(new_bm, i & ~(d-1), d);
Hervé Poussineau [Sun, 7 Apr 2019 17:08:04 +0000 (19:08 +0200)]
[UDFS] Keep same includes/defines on x64 as on other architectures
Hervé Poussineau [Sun, 7 Apr 2019 16:59:36 +0000 (18:59 +0200)]
[NTOS:FSRTL] Use _SEH2_AbnormalTermination() instead of _abnormal_termination()
We're already using SEH2 macros, so also use SEH2 functions
Hervé Poussineau [Sun, 7 Apr 2019 16:59:13 +0000 (18:59 +0200)]
[MUP] Use _SEH2_AbnormalTermination() instead of _abnormal_termination()
We're already using SEH2 macros, so also use SEH2 functions
Hervé Poussineau [Sun, 7 Apr 2019 17:16:04 +0000 (19:16 +0200)]
[SDK] Fix _SEH2_AbnormalTermination() macro in dummy SEH
Hervé Poussineau [Sun, 7 Apr 2019 16:26:26 +0000 (18:26 +0200)]
[ADVAPI32] Send correct type to ElfrChangeNotify()
This fixes the following compiler error:
../dll/win32/advapi32/service/eventlog.c:658:59: error: passing argument 3 of 'ElfrChangeNotify' makes integer from pointer without a cast [-Werror=int-conversion]
dll/win32/advapi32/eventlogrpc_c.h:391:20: note: expected 'ULONG {aka long unsigned int}' but argument is of type 'HANDLE {aka void *}'
Hervé Poussineau [Sun, 7 Apr 2019 15:43:58 +0000 (17:43 +0200)]
[ACLAYERS] Use correct prototypes
FARPROC is defined in windef.h as "typedef INT_PTR (WINAPI *FARPROC)();"
Hervé Poussineau [Sun, 7 Apr 2019 06:58:46 +0000 (08:58 +0200)]
[EXT2] Add __REACTOS__ check around changes done in
76910c358f7197a6b8e283ea267faf7b5c1812ff
Hervé Poussineau [Sat, 6 Apr 2019 21:35:37 +0000 (23:35 +0200)]
[CMAKE] Prevent out-of-bound accesses in parser/lexer files
which try to remove path prefix from them.
Hervé Poussineau [Sat, 6 Apr 2019 21:11:53 +0000 (23:11 +0200)]
[DHCPCSVC] Eliminate unused code and associated parameters
This is mostly the same as OpenBSD commit
b4e4f16f2ae0ddf1e786bb12c99b8c51170a1a33
Hervé Poussineau [Thu, 4 Apr 2019 12:19:27 +0000 (14:19 +0200)]
[SDK] Remove double declaration of _alloca
_alloca() is already defined in sdk/include/crt/malloc.h
Eric Kohl [Sun, 7 Apr 2019 14:41:56 +0000 (16:41 +0200)]
[NTOSKRNL] Use global power capabilities and report button presence
- Add and initialize a global power capabilities variable.
- Return the global power capabilities via NtPowerInformation.SystemPowerCapabilities.
- Report the presence of power button, sleep button and lid.
Joachim Henze [Sun, 7 Apr 2019 13:15:25 +0000 (15:15 +0200)]
[COMCTL32] Improve status bar margin for unthemed and themed CORE-15834
Improve further what was recently committed in
0.4.12-dev-361-g
da9accfba6e8eb769dcd317185a9b57d161275b7
Katayama Hirofumi MZ [Sun, 7 Apr 2019 12:38:00 +0000 (21:38 +0900)]
[SHELL32] Fix explorer file item label background CORE-15937
Katayama Hirofumi MZ [Sun, 7 Apr 2019 11:20:23 +0000 (20:20 +0900)]
[KERNEL32] Support Japanese calendar (#1482)
Implement the Japanese calendar in kernel32. Locale info and date formatting. CORE-15920
Katayama Hirofumi MZ [Sun, 7 Apr 2019 09:35:52 +0000 (18:35 +0900)]
[KERNEL32_APITEST] Improve one-character Heisei tests (#1483)
One-character Heisei for CAL_SABBREVERASTRING locale info can be U+337B or U+5E73. And one-character Reiwa U+32FF, U+4EE4, and U+F9A8 are also added. Improve kernel32_apitest testcase. Thanks @ThFabba CORE-15920
Thomas Faber [Sat, 6 Apr 2019 13:21:35 +0000 (15:21 +0200)]
[ACPICA] Update to version
20190405. CORE-15926
Eric Kohl [Sun, 7 Apr 2019 07:21:34 +0000 (09:21 +0200)]
[NET][MC] Move the remaining STATISTICS and USER strings from net.exe to netmsg.dll.
Translators, please check the translations!
Katayama Hirofumi MZ [Sun, 7 Apr 2019 03:18:54 +0000 (12:18 +0900)]
[KERNEL32_APITEST] JapaneseCalendar must work even if not codepage 932"
Delete (GetACP() != 932) check.
Maxim Smirnov [Fri, 5 Apr 2019 10:16:07 +0000 (13:16 +0300)]
[FONT] Fix FontSmoothing
Katayama Hirofumi MZ [Sat, 6 Apr 2019 23:05:35 +0000 (08:05 +0900)]
[BOOTDATA] Improve error message of AHKAppTests.cmd (#1476)
+ dbgprint "Insert ReactOS CD and try again."
Eric Kohl [Sat, 6 Apr 2019 17:42:51 +0000 (19:42 +0200)]
[NET][MC] Move STATISTICS SERVER strings from net.exe to netmsg.dll.
Translators, please check the translations!
Jérôme Gardou [Sat, 6 Apr 2019 14:55:10 +0000 (16:55 +0200)]
[CMAKE] Clear CMAKE_<LANGUAGE>_IMPLICIT_LINK_LIBRARIES and
_IMPLICIT_LINK_DIRECTORIES
Othrewise, if you link a RC module with a static C library (as done for
fusion DLLs), you get the standard C libraries from GCC. This is not
what we want.
This might have to be done for MSVC builds. Check build.ninja to verify
this.
Jérôme Gardou [Sat, 6 Apr 2019 14:50:56 +0000 (16:50 +0200)]
[CMAKE] Also set blank DEFINE_SYMBOL property for freeldr helpers
Jérôme Gardou [Sat, 6 Apr 2019 12:00:23 +0000 (14:00 +0200)]
[GDI32] Use correct dependenxy for the winegdi library
Jérôme Gardou [Sat, 6 Apr 2019 11:56:48 +0000 (13:56 +0200)]
[ZLIB] use correct dependency for minizip library
Jérôme Gardou [Sat, 6 Apr 2019 11:22:50 +0000 (13:22 +0200)]
[CMAKE] unset EXPORT_SYMBOL for modules and shared libraries
We don't use that
Jérôme Gardou [Wed, 20 Mar 2019 13:19:48 +0000 (14:19 +0100)]
[CMAKE] Use modules instead of shared libraries
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.
On my system, this reduces the configure-time by a factor of two.
Eric Kohl [Sat, 6 Apr 2019 13:32:00 +0000 (15:32 +0200)]
[NET][MC] Move NET USER strings from net.exe to netmsg.dll.
Translators, please check the translations!
Katayama Hirofumi MZ [Sat, 6 Apr 2019 12:59:35 +0000 (21:59 +0900)]
[KERNEL32_APITEST] s/48815/0xBEAF/
Eric Kohl [Sat, 6 Apr 2019 11:33:26 +0000 (13:33 +0200)]
[NET][MC] Move NET CONFIG strings from net.exe to netmsg.dll.
Translators, please check the translations!
Katayama Hirofumi MZ [Sat, 6 Apr 2019 11:11:07 +0000 (20:11 +0900)]
[KERNEL32] Improve MultiByteToWideChar (#1477)
Reduce MultiByteToWideChar failures. CORE-13349
Katayama Hirofumi MZ [Sat, 6 Apr 2019 09:20:04 +0000 (18:20 +0900)]
[KERNEL32_APITEST] Follow up of
89af984
Katayama Hirofumi MZ [Sat, 6 Apr 2019 08:48:15 +0000 (17:48 +0900)]
[KERNEL32_APITEST] 5-byte, 6-byte, ... UTF-8 sequences
Timo Kreuzer [Fri, 5 Apr 2019 14:53:57 +0000 (16:53 +0200)]
[MC] Add missing message translations by copying the english version
Note: always translate the whole file! It's easier (use a script or simply a regex replace) and required by Visual Studio 2019.
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:55:03 +0000 (13:55 +0900)]
[KERNEL32_APITEST] Careless
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:51:20 +0000 (13:51 +0900)]
[KERNEL32_APITEST] Trivial
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:48:05 +0000 (13:48 +0900)]
[KERNEL32_APITEST] Forgot FreeLibrary
Katayama Hirofumi MZ [Sat, 6 Apr 2019 04:34:21 +0000 (13:34 +0900)]
[KERNEL32_APITEST] Follow up of #1472
Katayama Hirofumi MZ [Sat, 6 Apr 2019 03:05:15 +0000 (12:05 +0900)]
also add modules/AHK_Tests to .gitignore
Katayama Hirofumi MZ [Sat, 6 Apr 2019 02:47:25 +0000 (11:47 +0900)]
add modules/ahk_tests to .gitignore
Katayama Hirofumi MZ [Sat, 6 Apr 2019 02:41:08 +0000 (11:41 +0900)]
[SHELL32] pl-PL.rc escape sequence fix
Adam Słaboń [Fri, 5 Apr 2019 23:00:46 +0000 (01:00 +0200)]
[SYSSETUP] Add Lunar theme option to 2nd setup stage
This adds Lunar theme option to the 2nd setup stage theme chooser page.
Eric Kohl [Fri, 5 Apr 2019 21:14:07 +0000 (23:14 +0200)]
[NET][MC] Replace strings for the ACCOUNTS, GROUP and LOCALGROUP commands by netmsg.dll messages.
Mark Jansen [Tue, 2 Apr 2019 22:44:02 +0000 (00:44 +0200)]
[SYSSETUP] Add a theme chooser that can handle multiple styles