20 months ago[NTOS/MM] Recognize AMD64 image in PeFmtCreateSection failure case 1544/head
Mark Jansen [Tue, 30 Apr 2019 17:03:17 +0000 (19:03 +0200)]
[NTOS/MM] Recognize AMD64 image in PeFmtCreateSection failure case

20 months ago[BASESRV] Strengthen default permissions for DOS devices
Pierre Schweitzer [Wed, 15 May 2019 06:32:55 +0000 (08:32 +0200)]
[BASESRV] Strengthen default permissions for DOS devices

This is linked to previous work done on DOS devices creation
in basesrv. If this DWORD is not set (or 0), DOS devices will
be created with an ACL that make the symlink readable by any
and modifiable by any.
With protection mode set, the symlink will be still readable by
any but not modifiable by anyone but the owner.

This should also affect some objects managed by session manager.

By default, on W2K3, that protection mode is set.

20 months ago[MAGNIFY] Initialize the common controls as the program has a manifest 1562/head
Bișoc George [Sun, 12 May 2019 14:18:28 +0000 (16:18 +0200)]
[MAGNIFY] Initialize the common controls as the program has a manifest

20 months ago[FIND] Improvements / bug-fixes. (#1553) 1553/head
Hermès Bélusca-Maïto [Sat, 11 May 2019 23:05:53 +0000 (01:05 +0200)]
[FIND] Improvements / bug-fixes. (#1553)

- Only include the strictly necessary headers.
- Get rid of the dependency on shell and user DLLs.
- fgetws() gets the string buffer size in number of characters.
- We can use the CRT functions for lengths of the arguments etc.

- The cFileName member of the WIN32_FIND_DATAW structure does not
  contain the full PATH to the enumerated file, but only its name.
  In order to use _wfopen(), build a full file path out of the
  directory part of the file specification and the full file name.

- Simplify a ConPrintf() call to make it "atomic".
- Fix the "confusion" lLineCount vs. lLineNumber vocable in the code.
- Do not emit an extra newline after having displayed the results for
  a given file.
- Uppercase the switches for performing the comparisons.
- Send the errors to the StdErr stream.
- Remove trailing whitespace.

20 months ago[FIND] Rewrite of the find utility. (#1553)
Paweł Cholewa [Sat, 4 May 2019 22:39:14 +0000 (00:39 +0200)]
[FIND] Rewrite of the find utility. (#1553)

This commit contains a complete rewrite of find console utility.
The goal of it was to make the source code easier to maintain
and to add a missing feature (/offline switch).

Additional changes:
 * now the program operates on Unicode strings;
 * added conutils and shlwapi as program's libraries;
 * added IDS_INVALID_SWITCH string into resources;
 * modified IDS_USAGE string to include /offline switch
   description. was used for reference.

20 months ago[HIDCLASS] Implement IRP_MJ_WRITE
Hervé Poussineau [Tue, 14 May 2019 12:18:21 +0000 (14:18 +0200)]

20 months ago[NtUser] Fix Paint Messages
jimtabor [Mon, 13 May 2019 16:31:58 +0000 (11:31 -0500)]
[NtUser] Fix Paint Messages

This is a HACK for forcing painting of non client areas. Paint code
seems very restricted.

See CORE-7166 & CORE-15934.

20 months ago[APPVEYOR] Disable the clang-cl
Pierre Schweitzer [Mon, 13 May 2019 06:33:00 +0000 (08:33 +0200)]
[APPVEYOR] Disable the clang-cl

The compiler hits an assert while building a file
The two "officially" supported compilers are working though

This will bring back green status for our CI on GitHub

20 months ago[POWERCFG] Show the hibernate page only if the S4 power state is available
Eric Kohl [Sun, 12 May 2019 21:52:08 +0000 (23:52 +0200)]
[POWERCFG] Show the hibernate page only if the S4 power state is available

20 months ago[POWERCFG] Add a separate power schemes dialog for ac-only systems
Eric Kohl [Sun, 12 May 2019 21:48:36 +0000 (23:48 +0200)]
[POWERCFG] Add a separate power schemes dialog for ac-only systems

The layout issues will be fixed by a future patch.

20 months ago[EXPLORER] Add Portuguese (Portugal) pt-PT.rc translation. CORE-15967 (#1558)
Jose Carlos Jesus [Thu, 25 Apr 2019 18:31:58 +0000 (19:31 +0100)]
[EXPLORER] Add Portuguese (Portugal) pt-PT.rc translation. CORE-15967 (#1558)

20 months ago[Gdi32] Batch Type Select Mode for Testing 1558/head
jimtabor [Sat, 11 May 2019 16:22:06 +0000 (11:22 -0500)]
[Gdi32] Batch Type Select Mode for Testing

Do not allow setting hdc if no batch type is found.
See CORE-15988.

20 months ago[BTRFS] Upgrade to 1.2.1
Pierre Schweitzer [Sat, 11 May 2019 09:53:13 +0000 (11:53 +0200)]
[BTRFS] Upgrade to 1.2.1


20 months ago[UBTRFS] Upgrade to 1.2.1
Pierre Schweitzer [Sat, 11 May 2019 09:24:42 +0000 (11:24 +0200)]
[UBTRFS] Upgrade to 1.2.1


20 months ago[BTRFS] Upgrade to 1.2.1
Pierre Schweitzer [Sat, 11 May 2019 09:20:02 +0000 (11:20 +0200)]
[BTRFS] Upgrade to 1.2.1


20 months ago[HIDPARSER] Implement HidP_GetValueCaps
Hervé Poussineau [Fri, 10 May 2019 09:28:28 +0000 (11:28 +0200)]
[HIDPARSER] Implement HidP_GetValueCaps

20 months ago[MOUHID] Correctly detect tablet devices
Hervé Poussineau [Fri, 10 May 2019 06:39:10 +0000 (08:39 +0200)]
[MOUHID] Correctly detect tablet devices

Some mice give a logical min/logical max which is the maximum move
that they can provide. Those were wrongly detected as absolute mice,
and mouse pointer was mostly stuck at the upper left corner of the

20 months ago[POWERCFG] Fix-up the lid, power button and sleep button settings according to the...
Eric Kohl [Thu, 9 May 2019 21:56:37 +0000 (23:56 +0200)]
[POWERCFG] Fix-up the lid, power button and sleep button settings according to the power capabilities.

20 months ago[Win32SS] Plug in Last Batch
jimtabor [Thu, 9 May 2019 17:35:21 +0000 (12:35 -0500)]
[Win32SS] Plug in Last Batch

Plugging in last batch after 12 years.

20 months ago[NtGDI] Fix ExtSelectClipRgn Tests
jimtabor [Thu, 9 May 2019 17:33:21 +0000 (12:33 -0500)]
[NtGDI] Fix ExtSelectClipRgn Tests

Fix results from tests, add (last one) gdi batch support for
ExtSelectClipRgn. Left commented out test code in tree this time.
Pass Katayama Hirofumi MZ SelectClipRgn tests. After commit will plug in
the last batch. After 12 years.

See CORE-13817 and CORE-15906.

20 months ago[BASESRV] Misc fixes: use BaseSrvHeap and silent a DPRINT
Pierre Schweitzer [Thu, 9 May 2019 06:56:29 +0000 (08:56 +0200)]
[BASESRV] Misc fixes: use BaseSrvHeap and silent a DPRINT

20 months ago[POWERCFG] Do not re-initialize all paged directly when the hibernate file setting...
Eric Kohl [Wed, 8 May 2019 20:56:55 +0000 (22:56 +0200)]
[POWERCFG] Do not re-initialize all paged directly when the hibernate file setting changes. Re-initialize the pages on PSN_SETACTIVE instead.

20 months ago[BASESRV] Make Buffer MAX_PATH big again
Pierre Schweitzer [Wed, 8 May 2019 18:39:57 +0000 (20:39 +0200)]
[BASESRV] Make Buffer MAX_PATH big again

20 months ago[BASESVR] Take SessionId into account while creating BNO directory
Pierre Schweitzer [Wed, 8 May 2019 18:35:31 +0000 (20:35 +0200)]
[BASESVR] Take SessionId into account while creating BNO directory

20 months ago[BASESRV] Fix the BNO string buffer usage
Pierre Schweitzer [Wed, 8 May 2019 18:06:49 +0000 (20:06 +0200)]
[BASESRV] Fix the BNO string buffer usage

This avoids reinitializing it before use.

20 months ago[Win32nt|ApiTests] Add ExtSelectClipRgn test
jimtabor [Wed, 8 May 2019 17:31:17 +0000 (12:31 -0500)]
[Win32nt|ApiTests] Add ExtSelectClipRgn test

For CORE-13817 and CORE-15906

20 months ago[BASESRV] Rewrite DOS devices management
Pierre Schweitzer [Wed, 8 May 2019 16:29:52 +0000 (18:29 +0200)]
[BASESRV] Rewrite DOS devices management

This will notably bring support for DOS mapping with LUID devices
(not yet supported in the kernel, though).
This also reduces complexity (and thus memory usage) with the "history"
thing. Multiple targets are stored in the link target as MULTI_SZ string.

This fixes regressions introduced with kernel32 fixes/rewrites.

20 months ago[KERNEL32] Drop unused line breaks
Pierre Schweitzer [Wed, 8 May 2019 16:13:30 +0000 (18:13 +0200)]
[KERNEL32] Drop unused line breaks

20 months ago[BASESRV] Enable the ProtectionMode query code
Pierre Schweitzer [Tue, 7 May 2019 20:48:41 +0000 (22:48 +0200)]
[BASESRV] Enable the ProtectionMode query code
And make it global

20 months ago[BASESRV] Make SessionId global
Pierre Schweitzer [Tue, 7 May 2019 20:41:30 +0000 (22:41 +0200)]
[BASESRV] Make SessionId global

20 months ago[NTOS:CM] Do not call ZwQueryObject with a zero-size buffer. CORE-15882
Thomas Faber [Tue, 7 May 2019 11:51:06 +0000 (13:51 +0200)]
[NTOS:CM] Do not call ZwQueryObject with a zero-size buffer. CORE-15882

Actually fixes ntdll_apitest:NtLoadUnloadKey.

20 months ago[ROSAUTOTEST] Fix and improve some log handling (#1531)
Serge Gautherie [Tue, 7 May 2019 06:39:52 +0000 (08:39 +0200)]
[ROSAUTOTEST] Fix and improve some log handling (#1531)

* wmain(): Use endl instead of '\n', for 'System uptime'
* wmain(): Output "[ROSAUTOTEST] " in two cases: 'System uptime' and all CSimpleException.

20 months ago[POWERCFG] Implement the power scheme 'Save As' feature
Eric Kohl [Mon, 6 May 2019 21:55:42 +0000 (23:55 +0200)]
[POWERCFG] Implement the power scheme 'Save As' feature


20 months ago[POWERCFG] Do not call other pages init routines when the hibernate setting changes...
Eric Kohl [Mon, 6 May 2019 21:38:17 +0000 (23:38 +0200)]
[POWERCFG] Do not call other pages init routines when the hibernate setting changes. This will be fixed later.

20 months ago[DDK][PSDK] Added the rest of the defines for netkvm
Benjamin Aerni [Mon, 6 May 2019 05:34:58 +0000 (22:34 -0700)]
[DDK][PSDK] Added the rest of the defines for netkvm

20 months ago[DDK][PSDK] Add some missing NDIS definitions/types. Caught by Benjamin Aerni.
Hermès Bélusca-Maïto [Sun, 5 May 2019 21:18:45 +0000 (23:18 +0200)]
[DDK][PSDK] Add some missing NDIS definitions/types. Caught by Benjamin Aerni.

20 months ago[POWERCFG] Fix power scheme deletion
Eric Kohl [Sun, 5 May 2019 20:48:53 +0000 (22:48 +0200)]
[POWERCFG] Fix power scheme deletion

CORE-12566, CORE-12567

20 months ago[POWERCFG] Improve the error handling in AddPowerScheme() and keep track of the curre...
Eric Kohl [Sun, 5 May 2019 20:01:54 +0000 (22:01 +0200)]
[POWERCFG] Improve the error handling in AddPowerScheme() and keep track of the current power scheme.

20 months ago[NOTEPAD] Duplicate notepad.exe in SystemRoot. CORE-16003 (#1555)
Oleg Dubinskiy [Sun, 5 May 2019 17:48:37 +0000 (20:48 +0300)]
[NOTEPAD] Duplicate notepad.exe in SystemRoot. CORE-16003 (#1555)

This is also done on Windows for backwards compatibility with Windows 3.x/9x.
But, it's also used (i.e. "required") by some installers, like Doom 3 Demo installer and Battlefield 1942 Single Player Demo installer, for successful opening of their Readme file at the end of their installation!

20 months ago[KERNEL32] Misc. fixes to DefineDosDeviceW
Pierre Schweitzer [Sun, 5 May 2019 16:31:43 +0000 (18:31 +0200)]
[KERNEL32] Misc. fixes to DefineDosDeviceW

- Add support for LUIDDeviceMapsEnabled;
- Broadcast proper message in case of device removal;
- Use less memory for strings management;
- Make code a bit cleaner.

20 months ago[NTOS:CM] Check for correct status from ZwQueryObject. CORE-15882
Thomas Faber [Sun, 5 May 2019 15:56:10 +0000 (17:56 +0200)]
[NTOS:CM] Check for correct status from ZwQueryObject. CORE-15882

Fixes regression in ntdll_apitest:NtLoadUnloadKey from d570482bc72.

20 months ago[POWERCFG] Really fix the power schemes exceptions!
Eric Kohl [Sun, 5 May 2019 15:00:57 +0000 (17:00 +0200)]
[POWERCFG] Really fix the power schemes exceptions!

20 months ago[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces
Pierre Schweitzer [Sun, 5 May 2019 12:18:09 +0000 (14:18 +0200)]
[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces

It also comes with a small performance boost: instead of performing object
queries one after another, we query them all at once.

20 months ago[NTOS:PNP] Reduce the size of the pool buffer in IopGetParentIdPrefix. CORE-15882 1507/head
Thomas Faber [Thu, 18 Apr 2019 05:41:50 +0000 (07:41 +0200)]
[NTOS:PNP] Reduce the size of the pool buffer in IopGetParentIdPrefix. CORE-15882

20 months ago[NTOS:CM] Reduce the size of some unnecessarily large stack buffers. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 08:31:34 +0000 (10:31 +0200)]
[NTOS:CM] Reduce the size of some unnecessarily large stack buffers. CORE-15882

20 months ago[NTOS:CM] Simplify CmpGetRegistryPath to avoid unnecessary stack buffers. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 08:25:52 +0000 (10:25 +0200)]
[NTOS:CM] Simplify CmpGetRegistryPath to avoid unnecessary stack buffers. CORE-15882

20 months ago[NTOS:CM] Avoid a fixed-length stack buffer in CmpCmdHiveOpen. CORE-15882
Thomas Faber [Wed, 17 Apr 2019 07:37:37 +0000 (09:37 +0200)]
[NTOS:CM] Avoid a fixed-length stack buffer in CmpCmdHiveOpen. CORE-15882

20 months ago[NTOS:CM] Avoid a fixed-length stack buffer in CmpAddToHiveFileList. CORE-15882
Thomas Faber [Mon, 15 Apr 2019 10:10:23 +0000 (12:10 +0200)]
[NTOS:CM] Avoid a fixed-length stack buffer in CmpAddToHiveFileList. CORE-15882

20 months ago[NTOS] Use correct buffer size when calling MiResolveImageReferences. CORE-15882
Thomas Faber [Mon, 15 Apr 2019 06:25:23 +0000 (08:25 +0200)]
[NTOS] Use correct buffer size when calling MiResolveImageReferences. CORE-15882

20 months ago[NTOS:PNP] Avoid a fixed-length stack buffer in IopActionConfigureChildServices....
Thomas Faber [Sun, 24 Mar 2019 14:04:37 +0000 (15:04 +0100)]
[NTOS:PNP] Avoid a fixed-length stack buffer in IopActionConfigureChildServices. CORE-15882

20 months ago[NTOS:IO] Avoid a fixed-length buffer in IopGetDriverObject. CORE-15882
Thomas Faber [Sun, 24 Mar 2019 13:47:59 +0000 (14:47 +0100)]
[NTOS:IO] Avoid a fixed-length buffer in IopGetDriverObject. CORE-15882

20 months ago[NTOS:KDBG] Avoid use of MAX_PATH. CORE-15882
Thomas Faber [Sun, 24 Mar 2019 09:44:46 +0000 (10:44 +0100)]
[NTOS:KDBG] Avoid use of MAX_PATH. CORE-15882

20 months ago[KERNEL32] Reduce QueryDosDeviceA memory footprint
Pierre Schweitzer [Sun, 5 May 2019 08:12:59 +0000 (10:12 +0200)]
[KERNEL32] Reduce QueryDosDeviceA memory footprint

by using TEB static unicode string (which is already
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.

20 months ago[KERNEL32] Reduce DefineDosDeviceA memory footprint
Pierre Schweitzer [Sun, 5 May 2019 07:25:34 +0000 (09:25 +0200)]
[KERNEL32] Reduce DefineDosDeviceA memory footprint

by using TEB static unicode string (which is already

20 months ago[CONSOLE.CPL] Fix the console screen preview when selecting TrueType fonts.
Hermès Bélusca-Maïto [Sat, 4 May 2019 23:10:39 +0000 (01:10 +0200)]
[CONSOLE.CPL] Fix the console screen preview when selecting TrueType fonts.
CORE-13182 CORE-13196

- Use the correct character height & width.
- Additions: use StringCch*() when initializing the dialog title.

[CONSRV:CONCFG] Minor fixes.

- When retrieving font characteristics in ConCfgReadUserSettings(),
  check for NULL/zero values that indicate that we should use default
  ones instead.
- Rename 'dwNumSubKeys' into 'dwNumValues'.

20 months ago[MC] Add message tranlations. Supplement to 3acec58f.
Eric Kohl [Sat, 4 May 2019 21:13:28 +0000 (23:13 +0200)]
[MC] Add message tranlations. Supplement to 3acec58f.

20 months ago[NET] Replace remaining strings of the NET ACCOUNTS command by messages
Eric Kohl [Sat, 4 May 2019 19:08:27 +0000 (21:08 +0200)]
[NET] Replace remaining strings of the NET ACCOUNTS command by messages

20 months ago[ROSAUTOTEST] Don't disallow buffering for journal file
Pierre Schweitzer [Fri, 3 May 2019 10:13:51 +0000 (12:13 +0200)]
[ROSAUTOTEST] Don't disallow buffering for journal file

This fixes back journal in ReactOS "at low costs". Indeed,
because write are improperly aligned right now, journaling
just fails.
With that patch, Cc will take care of aligning writes and
journal will be written again. Because flush operations
happen at each and every write to the journal, we expect
changes to land on disk quickly (not as quickly as if
they were directly written). But that's a good trade off
between over engineering and fixing a broken feature.


20 months ago[AUTOCHK] Don't check any volume on boot
Pierre Schweitzer [Sat, 4 May 2019 08:57:33 +0000 (10:57 +0200)]
[AUTOCHK] Don't check any volume on boot

This will avoid triggering a FAT repair on
unclean FAT volumes.

If dosfstools.fsck works fine in Linux, its
usage on ReactOS triggers worse corruption
than unclean shutdown.

Given I've no time for debugging this, I
kill it off.


20 months ago[WIN32SS][NTGDI] Correctly get/update ptlCurrent about TA_UPDATECP
Katayama Hirofumi MZ [Sat, 4 May 2019 01:07:24 +0000 (10:07 +0900)]
[WIN32SS][NTGDI] Correctly get/update ptlCurrent about TA_UPDATECP

20 months ago[WIN32SS][NTGDI] Wrap IntLPtoDP and IntDPtoLP macros by do { .... } while (0)
Katayama Hirofumi MZ [Sat, 4 May 2019 00:56:09 +0000 (09:56 +0900)]
[WIN32SS][NTGDI] Wrap IntLPtoDP and IntDPtoLP macros by do { .... } while (0)

20 months ago[APPSHIM_APITEST] Fix 2k3 test failures 1550/head
Mark Jansen [Wed, 1 May 2019 20:48:08 +0000 (22:48 +0200)]
[APPSHIM_APITEST] Fix 2k3 test failures

20 months ago[HIDParser] Fix MSVC build
jimtabor [Thu, 2 May 2019 19:33:07 +0000 (14:33 -0500)]
[HIDParser] Fix MSVC build

Attempt to fix build for MSVC.
This effected local build GCC system with newer Ninja version. Not sure
if this has an effect.

20 months ago[POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which...
Eric Kohl [Thu, 2 May 2019 18:21:32 +0000 (20:21 +0200)]
[POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState.

20 months ago[HID] Use hidparser static library for HidP_* functions
Hervé Poussineau [Sat, 27 Apr 2019 12:17:10 +0000 (14:17 +0200)]
[HID] Use hidparser static library for HidP_* functions

hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys

At the same time, this permis implementation of some HidP_* functions.

20 months ago[HIDPARSE/HIDPARSER] Move HidP_* functions from hidparse.sys to hidparser library
Hervé Poussineau [Sat, 27 Apr 2019 09:19:46 +0000 (11:19 +0200)]
[HIDPARSE/HIDPARSER] Move HidP_* functions from hidparse.sys to hidparser library

Interface between both is not anymore the HidParser_* functions, but
the HidP_* functions and the AllocFunction/FreeFunction/DebugFunctions/

20 months ago[SERIAL] Immediately complete read IRP if all requested bytes have been found in...
Hervé Poussineau [Thu, 2 May 2019 11:26:46 +0000 (13:26 +0200)]
[SERIAL] Immediately complete read IRP if all requested bytes have been found in circular buffer

Previously, we had to wait to receive another byte to finish the first IRP.

20 months ago[I8042PRT] Do not assert on unknown IOCTL
Hervé Poussineau [Sat, 27 Apr 2019 21:07:39 +0000 (23:07 +0200)]
[I8042PRT] Do not assert on unknown IOCTL

20 months ago[NtGDI] Set Xform flags if a changed
jimtabor [Thu, 2 May 2019 16:56:55 +0000 (11:56 -0500)]
[NtGDI] Set Xform flags if a changed

Missed more flags changes.

20 months ago[NtGDI] Set Xform flags if a changed
jimtabor [Thu, 2 May 2019 15:16:50 +0000 (10:16 -0500)]
[NtGDI] Set Xform flags if a changed

Missed flags changes.

20 months ago[NtGDI] Adding Support for Viewport TextOut
jimtabor [Thu, 2 May 2019 15:11:11 +0000 (10:11 -0500)]
[NtGDI] Adding Support for Viewport TextOut

Add Viewport changes to Text Out Batch.

20 months ago[COMDLG32] Fix treatment of wrong filename extension (#1545)
Katayama Hirofumi MZ [Thu, 2 May 2019 13:48:01 +0000 (22:48 +0900)]
[COMDLG32] Fix treatment of wrong filename extension (#1545)

Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270

20 months ago[NTDLL_APITEST] Query sector size for NtWriteFile tests
Pierre Schweitzer [Thu, 2 May 2019 11:59:47 +0000 (13:59 +0200)]
[NTDLL_APITEST] Query sector size for NtWriteFile tests

20 months ago[NTDLL_APITEST] Add tests for alignment for NtWriteFile
Pierre Schweitzer [Thu, 2 May 2019 10:07:46 +0000 (12:07 +0200)]
[NTDLL_APITEST] Add tests for alignment for NtWriteFile
This mimics the usage of WriteFile which is done in rosautotest.


20 months ago[GDI32] Add batch flag for Text Out
James Tabor [Thu, 2 May 2019 04:24:53 +0000 (23:24 -0500)]
[GDI32] Add batch flag for Text Out

Set batch flag for Text Out with font and attributes change sets.

20 months ago[GDI32] Fix MS build
James Tabor [Thu, 2 May 2019 01:53:06 +0000 (20:53 -0500)]
[GDI32] Fix MS build

Fix old uncovered code.

20 months ago[GDI32] Update signal flags for batch.
James Tabor [Thu, 2 May 2019 01:33:09 +0000 (20:33 -0500)]
[GDI32] Update signal flags for batch.

Add removed flags for batch signaling. This will allow syncing of
changed Xfroms after batched drawing. Disable calls to kernel mode since
the code is closely identical. Kernel calls are for init time when
PDCATTR is normally zero. ReactOS seems to work better keeping this from
While making code changes add Xform state flags from:

Test BOT results:,67254,67255

20 months ago[OSK] Hotfix for PR #1536 (#1549) 1549/head
Bișoc George [Wed, 1 May 2019 08:33:13 +0000 (10:33 +0200)]
[OSK] Hotfix for PR #1536 (#1549)


20 months ago[ACGENRAL] Add a test shim 1534/head
Mark Jansen [Tue, 30 Apr 2019 20:51:28 +0000 (22:51 +0200)]
[ACGENRAL] Add a test shim

20 months ago[ROSAPPS] Add a test application for shims
Mark Jansen [Tue, 30 Apr 2019 20:50:21 +0000 (22:50 +0200)]
[ROSAPPS] Add a test application for shims

20 months ago[APPHELP] Add ordinal import support
Mark Jansen [Sun, 11 Feb 2018 21:40:51 +0000 (22:40 +0100)]
[APPHELP] Add ordinal import support

20 months ago[POWERCFG] Fix indentation. No code changes!
Eric Kohl [Wed, 1 May 2019 11:16:00 +0000 (13:16 +0200)]
[POWERCFG] Fix indentation. No code changes!

20 months ago[GDI32_APITEST] Improve SetMapMode testcase (#1547)
Katayama Hirofumi MZ [Wed, 1 May 2019 09:28:18 +0000 (18:28 +0900)]
[GDI32_APITEST] Improve SetMapMode testcase (#1547)

Check the relation of mode change and viewport change. CORE-14994

20 months ago[WIN32SS][NTGDI] Fix ExtTextOut about TA_UPDATECP (#1546)
Katayama Hirofumi MZ [Wed, 1 May 2019 07:51:00 +0000 (16:51 +0900)]
[WIN32SS][NTGDI] Fix ExtTextOut about TA_UPDATECP (#1546)

Add WORLD_XFORM_CHANGED flag to some positioning functions.
Fix IntExtTextOutW function for TA_UPDATECP alignment, so that it can correctly update the current position. CORE-14994

20 months ago[KERNEL32_APITEST] JapaneseCalendar: Reiwa era has come!
Katayama Hirofumi MZ [Wed, 1 May 2019 07:15:23 +0000 (16:15 +0900)]
[KERNEL32_APITEST] JapaneseCalendar: Reiwa era has come!

20 months ago[NTOS/MM] Ensure ImageBase is not used uninitialized 1537/head
Mark Jansen [Sat, 27 Apr 2019 21:58:01 +0000 (23:58 +0200)]
[NTOS/MM] Ensure ImageBase is not used uninitialized

20 months ago[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented...
Hermès Bélusca-Maïto [Mon, 29 Apr 2019 20:51:35 +0000 (22:51 +0200)]
[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989

20 months ago[OSK] Make the buttons themed
Bișoc George [Mon, 22 Apr 2019 13:01:18 +0000 (15:01 +0200)]
[OSK] Make the buttons themed

Our On-Screen Keyboard has a manifest and the buttons (the ones with BS_ICON styles) aren't rendered with the specific theme as it should be but instead it takes the classic theme.

The code relies on NM_CUSTOMDRAW notification, which is more intuitive and efficient than doing owner-drawn operations as NM_CUSTOMDRAW allows the controls to use styles whereas you cannot do it on owner-drawn controls.


20 months ago[WIN32KNT_APITEST] Forgot a extension in CMakeLists.txt
Katayama Hirofumi MZ [Mon, 29 Apr 2019 10:42:04 +0000 (19:42 +0900)]
[WIN32KNT_APITEST] Forgot a extension in CMakeLists.txt

20 months ago[WIN32SS][NTGDI][GDI32] Fix DPtoLP and NtGdiTransformPoints etc. (#1540)
Katayama Hirofumi MZ [Mon, 29 Apr 2019 05:45:44 +0000 (14:45 +0900)]
[WIN32SS][NTGDI][GDI32] Fix DPtoLP and NtGdiTransformPoints etc. (#1540)

Fix NtGdiTransformPoints, gdi32!DPtoLP, gdi32!LPtoDP and gdi32!SetMapMode functions. Fix CORE-15983. CORE-15983

20 months ago[APITESTS] set_module_type(win32u module)
Katayama Hirofumi MZ [Mon, 29 Apr 2019 03:49:54 +0000 (12:49 +0900)]
[APITESTS] set_module_type(win32u module)

20 months ago[APITESTS] Add NtGdiTransformPoints testcase (#1542)
Katayama Hirofumi MZ [Mon, 29 Apr 2019 00:13:22 +0000 (09:13 +0900)]
[APITESTS] Add NtGdiTransformPoints testcase (#1542)

Add a testcase for NtGdiTransformPoints function. set_module_type(win32u... win32dll) CORE-15983

20 months ago[KERNEL32_APITEST] Rename the 'Console.c' file into 'ConsoleCP.c' and its test-functi...
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 20:47:14 +0000 (22:47 +0200)]
[KERNEL32_APITEST] Rename the 'Console.c' file into 'ConsoleCP.c' and its test-function as well, in order to reflect the actual name of the corresponding test.

20 months agoAdd a shared "port" directory for POSIX functions needed by multiple host tools ...
Colin Finck [Sat, 27 Apr 2019 14:19:26 +0000 (16:19 +0200)]
Add a shared "port" directory for POSIX functions needed by multiple host tools (getopt/mkstemps) and import the one and only getopt from glibc.

This finally fixes our duplicated getopt functions from different sources and gives us an up to date and the most compatible implementation.
isohybrid actually relies on a glibc-specific getopt behavior that we previously hacked into the reactos_support_code.c implementation derived from BSD/mingw-w64.
widl also needs getopt and previously used an even older BSD-derived code.

20 months ago[ISOHYBRID] Fix the remaining warnings properly.
Colin Finck [Sat, 27 Apr 2019 09:35:04 +0000 (11:35 +0200)]
[ISOHYBRID] Fix the remaining warnings properly.

I will send these changes upstream (minus the REACTOS_ISOHYBRID_EFI_MAC_SUPPORT ifdefs).

20 months ago[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525)
Timo Kreuzer [Mon, 15 Apr 2019 11:29:33 +0000 (13:29 +0200)]
[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525)

20 months ago[CONSRV] Cache the console window system menu handle; simplify its initialization...
Hermès Bélusca-Maïto [Sun, 28 Apr 2019 19:47:55 +0000 (21:47 +0200)]
[CONSRV] Cache the console window system menu handle; simplify its initialization code.

20 months ago[REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)
Serge Gautherie [Sun, 28 Apr 2019 19:19:42 +0000 (21:19 +0200)]

No functional change otherwise.

20 months ago[ACCESS] Reposition the "ToggleKeys" group box control (#1541)
Bișoc George [Sun, 28 Apr 2019 18:21:38 +0000 (20:21 +0200)]
[ACCESS] Reposition the "ToggleKeys" group box control (#1541)


20 months ago[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. ... 1065/head
Andrew Boyarshin [Mon, 26 Nov 2018 12:49:15 +0000 (19:49 +0700)]
[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. (#1065)

- The 2nd parameter is already passed in user-mode by GetThreadDesktop().
  It is then used by NtUserGetThreadDesktop() as a fallback for console

- Lookup and validate the thread by using the IntTID2PTI() helper.
- Don't reference the desktop with too many access rights.
- Get rid of the old-school DECLARE_RETURN() & co. macros.

Co-authored-by: Hermès Bélusca-Maïto <>