Pierre Schweitzer [Fri, 10 Aug 2018 06:40:02 +0000 (08:40 +0200)]
[NTOSKRNL] Restrict rights on the page file
Pierre Schweitzer [Fri, 10 Aug 2018 06:01:31 +0000 (08:01 +0200)]
[NTOSKRNL] Deny page file creation on floppy disk
Pierre Schweitzer [Fri, 10 Aug 2018 05:50:16 +0000 (07:50 +0200)]
[NTOSKRNL] Properly open a page file and set appropriate attributes
Pierre Schweitzer [Thu, 9 Aug 2018 19:13:08 +0000 (21:13 +0200)]
[NTOSKRNL] Check that caller has appropriate right before creating page file
Eric Kohl [Sat, 11 Aug 2018 20:25:30 +0000 (22:25 +0200)]
[DLLHOST] Add dllhost to make the device driver extractor for my Lenovo T400 happy
Katayama Hirofumi MZ [Fri, 10 Aug 2018 13:37:37 +0000 (22:37 +0900)]
[WIN32SS][FONT] Fix the system logical stock font data (#709)
This fixes the stock font data to improve font selection.
CORE-14885
Katayama Hirofumi MZ [Fri, 10 Aug 2018 11:25:50 +0000 (20:25 +0900)]
[SHELL32] Fix a careless mistake of ShellExecCmdLine (#737)
CORE-14886
Katayama Hirofumi MZ [Wed, 18 Jul 2018 20:02:49 +0000 (05:02 +0900)]
[CONSRV] Implement support for file/directory drag-and-drop (#692).
CORE-14833
Serge Gautherie [Wed, 4 Jul 2018 01:42:04 +0000 (03:42 +0200)]
[REACTOS] Improve how some ASSERTMSG() message values are printed: enforce ending "\n".
NB: Not touching calls in "third-party" code: class and classpnp.
Serge Gautherie [Mon, 2 Jul 2018 09:45:01 +0000 (11:45 +0200)]
[CMLIB] Simplify an ASSERTMSG() as an ASSERT().
Hermès Bélusca-Maïto [Wed, 8 Aug 2018 19:37:22 +0000 (21:37 +0200)]
[BOOTLIB] Fix the implementation of RtlAssert() ('Message' can be NULL, and fix the printing of ANSI string). Fix also the implementation of DbgPrint().
Serge Gautherie [Thu, 21 Jun 2018 03:05:50 +0000 (05:05 +0200)]
[REACTOS] RtlAssert(): use "%lu" as LineNumber format.
Hermès Bélusca-Maïto [Wed, 8 Aug 2018 18:45:39 +0000 (20:45 +0200)]
[CONSRV] Minor code re-organization.
Hermès Bélusca-Maïto [Wed, 8 Aug 2018 18:38:41 +0000 (20:38 +0200)]
[CONSRV] Add a PasteText() helper function and use it.
Thomas Faber [Wed, 8 Aug 2018 17:58:56 +0000 (19:58 +0200)]
[HAL] Remove misleading debug prints about USB controllers.
Hermès Bélusca-Maïto [Tue, 7 Aug 2018 17:40:06 +0000 (19:40 +0200)]
[CMD] Small translation update.
Bișoc George [Tue, 7 Aug 2018 18:31:56 +0000 (20:31 +0200)]
[TRANSLATION][WMIC] Add Italian translation
Eric Kohl [Tue, 7 Aug 2018 20:56:33 +0000 (22:56 +0200)]
[WLNOTIFY] Add sens service stubs
Serge Gautherie [Fri, 2 Feb 2018 23:19:18 +0000 (00:19 +0100)]
[NTOSKRNL] Round memory size up, "debug log" part
Assumed to better match actual physical RAM size.
CORE-12321
Jared Smudde [Tue, 7 Aug 2018 11:22:03 +0000 (06:22 -0500)]
[BOOTDATA] Change the default open command for HTA files to open in Wine Internet Explorer. (#719)
It's a shortcut from implementing the function in mshtml but it works.
Also add an edit option to the right click menu.
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 20:36:14 +0000 (22:36 +0200)]
[CMD] Add speed-optimized checks for dot-directories "." and ".." .
Adapted from PR #592 by Katayama Hirofumi MZ.
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 19:46:38 +0000 (21:46 +0200)]
[CMD] Fix the way the DIR-command pattern is interpreted when it contains paths or filenames with trailing dots.
Particular DIR commands like: "DIR .", "DIR .." now work as expected,
and we also correctly fix the behavior for files without extension,
that r38746 (
2b06cfc0) originally tried to fix but broke the previous
examples.
Therefore "DIR *." and "DIR noextfile." work too.
Pathological cases like "DIR \...", "DIR \...\.", "DIR ..\...\.." and
the like (and with more than 3 dots) now work as expected.
Adapted from PR #592 by Katayama Hirofumi MZ, but with extended bugfixing.
CORE-13961
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 19:22:27 +0000 (21:22 +0200)]
[CMD] Code formatting; use LPCTSTR where possible; use a MAX_PATH sized dircmd buffer.
Katayama Hirofumi MZ [Mon, 25 Jun 2018 00:53:45 +0000 (09:53 +0900)]
[CMD] Create a DirNodeCleanup() helper for cleanup and simplify code (adapted from PR #592).
Hermès Bélusca-Maïto [Sun, 29 Jul 2018 23:36:43 +0000 (01:36 +0200)]
[CMD] Fix French translation.
Mark Jansen [Sun, 5 Aug 2018 20:14:44 +0000 (22:14 +0200)]
[NTOSKRNL] Fix a nullptr dereference in IopStartDevice
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 15:30:21 +0000 (17:30 +0200)]
[WINLOGON] Hack-fix for CORE-14877 ; see commit
bcec1fd6.
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 15:29:34 +0000 (17:29 +0200)]
[WINLOGON][MSGINA] Fix typo.
Eric Kohl [Sun, 5 Aug 2018 18:02:22 +0000 (20:02 +0200)]
[SYSSETUP] SetupStartService: Wait until the service is running
Eric Kohl [Sun, 5 Aug 2018 14:16:53 +0000 (16:16 +0200)]
[ADVAPI32] Add parameter checks to LogonUserExW and initialize the token handle.
Eric Kohl [Sun, 5 Aug 2018 13:57:03 +0000 (15:57 +0200)]
[NETAPI32] Implement I_NetServerSetServiceBits()
Eric Kohl [Sun, 5 Aug 2018 13:36:48 +0000 (15:36 +0200)]
[NETAPI32] Add annotations and move NetUseGetInfo to a better location.
Eric Kohl [Sun, 5 Aug 2018 13:04:01 +0000 (15:04 +0200)]
[SRVSVC] Set and retrieve service bits and rename unknown functions
- Service bits are set by NetrServerSetServiceBits and can be retrieved by NetrServerGetInfo.
- The real name of function 42 is NetrServerSetServiceBitsEx and the real name of function 47 is NetrDfsSetServerInfo.
Katayama Hirofumi MZ [Sun, 5 Aug 2018 11:39:17 +0000 (20:39 +0900)]
[SHELL32] Fix handling of multiple parameters in the 'Run' dialog (#665)
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.
- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.
CORE-14790
Thomas Faber [Sun, 5 Aug 2018 10:57:25 +0000 (12:57 +0200)]
[MSCONFIG] Fix buffer overflow when handling long service command lines.
Mark Jansen [Thu, 2 Aug 2018 20:36:17 +0000 (22:36 +0200)]
[ZIPFLDR] Add 'Extract All' to individual item context menu.
Mark Jansen [Thu, 2 Aug 2018 19:36:54 +0000 (21:36 +0200)]
[ZIPFLDR] Add 'Extract All' menu item to the folder context menu.
Mark Jansen [Fri, 3 Aug 2018 18:45:20 +0000 (20:45 +0200)]
[ATL] Fix the CComQIIDPtr template.
Mark Jansen [Sat, 21 Apr 2018 22:00:34 +0000 (00:00 +0200)]
[ZIPFLDR] Implement RouteTheCall, so that applications can 'launch' zip files
Denis Malikov [Sun, 4 Feb 2018 15:59:21 +0000 (22:59 +0700)]
[HAL] Add NT6-compatible version of HalpMapPhysicalMemory64 and HalpUnmapVirtualAddress
Eric Kohl [Sat, 4 Aug 2018 23:05:52 +0000 (01:05 +0200)]
[LSASRV] Implement and call the policy change notification routine
Eric Kohl [Sat, 4 Aug 2018 20:17:52 +0000 (22:17 +0200)]
[LSASRV][SECUR32] Implement LsaRegisterPolicyChangeNotification and LsaUnregisterPolicyChangeNotification
Timo Kreuzer [Sat, 7 Jul 2018 14:09:03 +0000 (16:09 +0200)]
[REACTOS] Fix 64 bit issues
Timo Kreuzer [Mon, 23 Apr 2018 09:42:32 +0000 (11:42 +0200)]
[DLLS] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 15:12:18 +0000 (16:12 +0100)]
[APPLICATIONS] Fix 64 bit issues
Timo Kreuzer [Sun, 11 Feb 2018 23:38:10 +0000 (00:38 +0100)]
[MVDM] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 15:07:41 +0000 (16:07 +0100)]
[WINSRV] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 20:58:15 +0000 (21:58 +0100)]
[REACTX] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 15:04:17 +0000 (16:04 +0100)]
[APPHELP] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 15:05:00 +0000 (16:05 +0100)]
[SHELL32] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 16:44:13 +0000 (17:44 +0100)]
[USER32] Fix 64 bit issues
Timo Kreuzer [Sun, 4 Mar 2018 15:06:54 +0000 (16:06 +0100)]
[GDI32] Fix 64 bit issues
Timo Kreuzer [Thu, 15 Feb 2018 21:34:48 +0000 (22:34 +0100)]
[KERNEL32] Fix 64 bit issues
Timo Kreuzer [Mon, 23 Apr 2018 09:27:49 +0000 (11:27 +0200)]
[DRIVERS] Fix 64 bit issues
Timo Kreuzer [Tue, 27 Feb 2018 21:15:44 +0000 (22:15 +0100)]
[UNIATA] Fix 64 bit issues
Timo Kreuzer [Tue, 27 Feb 2018 20:56:06 +0000 (21:56 +0100)]
[USBPORT] Fix 64 bit issues
Timo Kreuzer [Mon, 29 Jan 2018 19:31:07 +0000 (20:31 +0100)]
[NTOS] Fix 64 bit issues
Timo Kreuzer [Tue, 6 Feb 2018 00:17:11 +0000 (01:17 +0100)]
[FREELDR] Fix 64 bit issues
Timo Kreuzer [Sat, 14 Jul 2018 10:32:57 +0000 (12:32 +0200)]
[ROSTESTS] Fix 64 bit issues
Timo Kreuzer [Mon, 5 Mar 2018 11:07:15 +0000 (12:07 +0100)]
[KMTESTS] Fix 64 bit issues
Julio Carchi [Fri, 3 Aug 2018 13:08:13 +0000 (08:08 -0500)]
[TRANSLATIONS] Fix spanish translations for some resources (#725)
Setup wizard
Network settings wizard
Input CPL
Open file dialogs
Devmgr
Explorer
Bișoc George [Fri, 3 Aug 2018 10:12:29 +0000 (12:12 +0200)]
[TRANSLATION][TASKKILL] Add Italian translation (#717)
Nguyễn Thanh Sơn [Fri, 3 Aug 2018 10:10:16 +0000 (17:10 +0700)]
[MSPAINT] Added Vietnamese translation. (#722)
Bișoc George [Thu, 2 Aug 2018 13:32:30 +0000 (15:32 +0200)]
[INPUT] Fix a truncated text
Stanislav Motylkov [Mon, 30 Jul 2018 21:22:35 +0000 (00:22 +0300)]
[I8042PRT] Move DMI/SMBIOS parsing functions into library
Stanislav Motylkov [Sun, 29 Jul 2018 20:50:15 +0000 (23:50 +0300)]
[KERNEL32] Implement System Firmware functions
- Implement EnumSystemFirmwareTables
- Implement GetSystemFirmwareTable
These functions currently using registry workaround and can be improved later.
CORE-12105
Stanislav Motylkov [Sun, 29 Jul 2018 14:43:10 +0000 (17:43 +0300)]
[KERNEL32_APITEST] Add SystemFirmware tests
CORE-12105
Stanislav Motylkov [Sat, 14 Apr 2018 22:56:32 +0000 (01:56 +0300)]
[I8042PRT] Dump SMBIOS tables into registry for usermode access
Reference:
https://social.msdn.microsoft.com/Forums/en-US/
0bb0840e-85f4-4cdb-9710-
7581f7348f2f/how-to-get-motherboard-serial-number-without-using-wmi-in-c
CORE-12105 CORE-14867
Jared Smudde [Wed, 1 Aug 2018 20:15:27 +0000 (15:15 -0500)]
[USRMGR] Disable the Extra tab. It serves no purpose. (#700)
Julio Carchi [Tue, 31 Jul 2018 08:58:21 +0000 (03:58 -0500)]
[TRANSLATIONS] Fix some Spanish translations (#715)
Also added some new ones.
Phil Eaton [Sat, 7 Jul 2018 02:35:39 +0000 (22:35 -0400)]
[RAPPS] Deselect apps after installing
I found it unintuitive that each time I selected some software for installation, it wasn't automatically deselected after installation. I kept re-triggering the same installation a few times before I realized I had to manually uncheck the checked packages.
Eric Kohl [Sun, 29 Jul 2018 21:19:14 +0000 (23:19 +0200)]
[ADVAPI32] Stop the service dispatcher thread only if a SERVICE_CONTROL_STOP command was sent
Hermès Bélusca-Maïto [Sun, 29 Jul 2018 15:39:09 +0000 (17:39 +0200)]
[SHELL32] Silence a noisy DPRINT.
Hermès Bélusca-Maïto [Sun, 29 Jul 2018 14:00:49 +0000 (16:00 +0200)]
[AUTOCHK] Improvements: code + command-line handling.
- Add support for the following command-line arguments: /k, /p (and a little bit
of /r), and add support for checking a particular volume.
A description of these arguments can be found at:
"Description of Enhanced Chkdsk, Autochk, and Chkntfs Tools in Windows 2000",
https://web.archive.org/web/
20150215210228/http://support.microsoft.com:80/kb/218461
- Slightly improve some messages.
- Get rid of legacy OpenDirectory() and simplify GetFileSystem().
Hermès Bélusca-Maïto [Sun, 29 Jul 2018 13:19:30 +0000 (15:19 +0200)]
[AUTOCHK] Improve the timeout countdown prompt by displaying the actual remaining seconds before the disk check.
Make also keyboard availability optional.
Hermès Bélusca-Maïto [Sun, 29 Jul 2018 13:05:22 +0000 (15:05 +0200)]
[AUTOCHK] Minor code formatting; reduce indentation level of some blocks; use RTL_NUMBER_OF() macro; normalize file header.
Hermès Bélusca-Maïto [Sat, 28 Jul 2018 15:27:52 +0000 (17:27 +0200)]
[EXPLORER] Improve debug output.
Katayama Hirofumi MZ [Sat, 28 Jul 2018 14:30:48 +0000 (23:30 +0900)]
[WIN32SS][FREETYPE] Update copyright text
Pierre Schweitzer [Sun, 29 Jul 2018 11:58:30 +0000 (13:58 +0200)]
[NTOSKNRL] Only allocate a MDL if we have an output length
For user mode, when probing output buffer, if it's null, length
will also be set to 0.
This avoids user mode applications being able to trigger various
asserts in ReactOS (and thus BSOD when no debugger is plugged ;-)).
Katayama Hirofumi MZ [Sat, 28 Jul 2018 14:24:26 +0000 (23:24 +0900)]
[WIN32SS] Add 5 members to FONTGDI structure
Katayama Hirofumi MZ [Sat, 28 Jul 2018 14:37:03 +0000 (23:37 +0900)]
[WIN32SS][FONT] Change the type of 2nd argument of IntRequestFontSize
Eric Kohl [Sun, 29 Jul 2018 05:30:43 +0000 (07:30 +0200)]
[RPCRT4] Update the support for remote pipes which was dropped by the sync to Wine Staging 2.9 and update rpcrt4_ros.diff accordingly
Serge Gautherie [Fri, 27 Jul 2018 19:54:12 +0000 (21:54 +0200)]
[ROSDDT] do_update_base(): Fix assignment to f (#702)
Thanks to "devpao" for reporting this.
ROSAPPS-343
Serge Gautherie [Fri, 27 Jul 2018 19:53:50 +0000 (21:53 +0200)]
[MAN] AnalyzeArgv(): Fix 2 overruns related to element (#703)
- Also use _countof().
- Also add braces.
- Also enforce consistent "no spaces" style.
Thanks to "devpao" for pointing to this function.
ROSAPPS-344
Baruch Rutman [Thu, 26 Jul 2018 19:08:29 +0000 (22:08 +0300)]
[LPK] Changes (#622).
- Changed how the ScriptIsComplex check is made to account direction, most noticeble on dxdiag,
https://docs.microsoft.com/en-us/windows/desktop/api/usp10/nf-usp10-scriptiscomplex
However commented out the ScriptIsComplex flag change because of a bug.
- Added a check and debug print if BIDI_Reorder fails.
Baruch Rutman [Mon, 18 Jun 2018 14:54:15 +0000 (17:54 +0300)]
[LPK] Added more error handling code (#622).
- Added a codepath if both glyphs and reordered_str arrays are NULL.
- Move variables back to the beginning of function.
CORE-14732
Baruch Rutman [Mon, 18 Jun 2018 11:52:57 +0000 (14:52 +0300)]
[LPK] Diverse fixes (#622).
- Changed wcspy to strsafe function.
- Use GetCharWidthI instead of GetCharWidth32W if dealing with glyph indices.
Baruch Rutman [Mon, 18 Jun 2018 09:07:16 +0000 (12:07 +0300)]
[LPK] Refactoring (#622).
- Moved lpDx and lpGlyphs operations to seperate brackets.
- lpGlyphs == NULL checks + memory managment additions.
CORE-14732
Katayama Hirofumi MZ [Thu, 26 Jul 2018 12:34:00 +0000 (21:34 +0900)]
[USER32][WIN32SS] Implement TileWindows function (#678)
CORE-14815
David Knapp [Thu, 26 Jul 2018 05:28:42 +0000 (01:28 -0400)]
[AUTOCHK] Improve readability of messages
Mark Jansen [Sun, 22 Jul 2018 11:03:51 +0000 (13:03 +0200)]
[KMTESTS] Add compile time asserts for IO_STACK_LOCATION offsets
CORE-14782
Mark Jansen [Sun, 22 Jul 2018 11:02:20 +0000 (13:02 +0200)]
[XDK][NDK] Restore struct alignment for IO_STACK_LOCATION
CORE-14782
Jared Smudde [Sun, 22 Jul 2018 16:05:50 +0000 (11:05 -0500)]
[EXPLORER] Fix creation of shortcuts in the start menu.
Alisson Lauffer [Mon, 23 Jul 2018 23:10:49 +0000 (20:10 -0300)]
Update README.md with the latest release
Eric Kohl [Sun, 22 Jul 2018 13:17:02 +0000 (15:17 +0200)]
[SERVICES] Keep a global service bits variable that combines the service bits of all running services
Hermès Bélusca-Maïto [Sun, 22 Jul 2018 19:32:38 +0000 (21:32 +0200)]
[KERNEL32] Use RtlStringCbCopyNW() to correctly fill the WIN32_FIND_DATA.cFileName and cAlternateFileName members without any overflow and with a terminating NULL character.
Hermès Bélusca-Maïto [Sun, 8 Jul 2018 18:39:19 +0000 (20:39 +0200)]
[WIN32SS:NTUSER] Update SetWindowStationUser() and NtUserSetWindowStationUser() prototypes.
Also, improve NtUserSetWindowStationUser() capture order, make psid optional as it should (and avoid a user-mode triggered BSOD), and initialize luidUser only when everything succeeded.
Hermès Bélusca-Maïto [Sat, 16 Jun 2018 17:43:40 +0000 (19:43 +0200)]
[WIN32SS:USER] Code formatting only.
Hermès Bélusca-Maïto [Sun, 17 Jun 2018 21:17:52 +0000 (23:17 +0200)]
[USER32_APITEST] Add few other tests (validation of the desktop path string); improve the output of some messages, displaying the expected values in case of test failure.
See also PR #621.
Hermès Bélusca-Maïto [Sun, 17 Jun 2018 19:39:44 +0000 (21:39 +0200)]
[ROSTESTS] Add an interactive test for window stations. See also PR #621.