3 years ago[RAPPS] Set header style when sorting by column
Alexander Shaposhnikov [Thu, 8 Feb 2018 22:41:55 +0000 (00:41 +0200)]
[RAPPS] Set header style when sorting by column

3 years ago[NTOSKRNL] Fix a ****ing bug where private cache map was deleted in CcUninitializeCac...
Pierre Schweitzer [Thu, 8 Feb 2018 13:15:02 +0000 (14:15 +0100)]
[NTOSKRNL] Fix a ****ing bug where private cache map was deleted in CcUninitializeCacheMap()
before the call to CcRosReleaseFileCache() which expects to have it to properly clean the file.
So, move deletion code to CcRosReleaseFileCache() so that he's the only one to handle private map.
Should hopefully fix all the recent buildbots issues (and the universe perhaps, who knows?)

3 years ago[NDK] Update the PRIVATE_CACHE_MAP structure to match W2K3 one.
Pierre Schweitzer [Thu, 8 Feb 2018 13:02:42 +0000 (14:02 +0100)]
[NDK] Update the PRIVATE_CACHE_MAP structure to match W2K3 one.
Also update the spin lock on allocation.

3 years ago[NTOSKRNL] Revert 2362e0f and 07e6e9c (partly) they seem to have caused high instabil...
Pierre Schweitzer [Thu, 8 Feb 2018 12:40:54 +0000 (13:40 +0100)]
[NTOSKRNL] Revert 2362e0f and 07e6e9c (partly) they seem to have caused high instability in Cc.
This reverts BCB being lazy written when marked dirty.

We'll go back to this behavior when this part will have been reworked and stabilized.


3 years ago[NTOSKRNL] Revert 6ece4e9fc22d664ea2485d04303e8ae10047f21f for third tools compatibility
Pierre Schweitzer [Thu, 8 Feb 2018 10:50:45 +0000 (11:50 +0100)]
[NTOSKRNL] Revert 6ece4e9fc22d664ea2485d04303e8ae10047f21f for third tools compatibility

3 years ago[NTOSKRNL] Implement CcSetAdditionalCacheAttributes()
Pierre Schweitzer [Thu, 8 Feb 2018 10:49:22 +0000 (11:49 +0100)]
[NTOSKRNL] Implement CcSetAdditionalCacheAttributes()

3 years ago[NTOSKRNL] Misc cosmetic changes
Pierre Schweitzer [Thu, 8 Feb 2018 10:02:07 +0000 (11:02 +0100)]
[NTOSKRNL] Misc cosmetic changes

3 years ago[NTOSKRNL] Implement CcSetReadAheadGranularity()
Pierre Schweitzer [Thu, 8 Feb 2018 08:46:57 +0000 (09:46 +0100)]
[NTOSKRNL] Implement CcSetReadAheadGranularity()

3 years ago[NTOSKRNL] Magic value--
Pierre Schweitzer [Thu, 8 Feb 2018 08:46:08 +0000 (09:46 +0100)]
[NTOSKRNL] Magic value--

3 years ago[SYSDM] Make the GPL text ASCII. CORE-14278
Thomas Faber [Wed, 7 Feb 2018 09:53:51 +0000 (10:53 +0100)]
[SYSDM] Make the GPL text ASCII. CORE-14278

This is better than wasting space on null chars (and having Git mangle it).
Also ensure that it gets CRLF newlines since its contents go in the binary.

3 years ago[LIBXML2] Restore lost ROS-diff introduced in 7571d351ce. CORE-14291 CORE-11799
Thomas Faber [Wed, 7 Feb 2018 23:41:13 +0000 (00:41 +0100)]
[LIBXML2] Restore lost ROS-diff introduced in 7571d351ce. CORE-14291 CORE-11799

3 years ago[NTOSKRNL] When initializing file cache, also allocate a private cache map if needed.
Pierre Schweitzer [Wed, 7 Feb 2018 22:18:54 +0000 (23:18 +0100)]
[NTOSKRNL] When initializing file cache, also allocate a private cache map if needed.
Not used yet.

3 years ago[NTOSKRNL] Drop the CcTryToInitializeFileCache() which is actually doing nothing...
Pierre Schweitzer [Wed, 7 Feb 2018 21:23:25 +0000 (22:23 +0100)]
[NTOSKRNL] Drop the CcTryToInitializeFileCache() which is actually doing nothing relevant

3 years ago[NTOS:KE] Replace "Fatal System Error" with "BugCheck"
Serge Gautherie [Wed, 7 Feb 2018 05:29:02 +0000 (06:29 +0100)]
[NTOS:KE] Replace "Fatal System Error" with "BugCheck"

3 years ago[NTOSKRNL] Use the LockQueueMasterLock where appropriate
Pierre Schweitzer [Wed, 7 Feb 2018 20:35:22 +0000 (21:35 +0100)]
[NTOSKRNL] Use the LockQueueMasterLock where appropriate

3 years ago[NTOSKRNL] Handle FSRTL_FLAG_LIMIT_MODIFIED_PAGES flag in CcDeferWrite().
Pierre Schweitzer [Wed, 7 Feb 2018 20:11:39 +0000 (21:11 +0100)]
Util now, CcDeferWrite() was ignoring limits per file object.

3 years ago[NTOSKRNL] Add wait support in CcCanIWrite()
Pierre Schweitzer [Wed, 7 Feb 2018 20:09:36 +0000 (21:09 +0100)]
[NTOSKRNL] Add wait support in CcCanIWrite()

3 years ago[NTOSKRNL] Implement CcPostDeferredWrites() that executes deferred writes.
Pierre Schweitzer [Wed, 7 Feb 2018 19:27:55 +0000 (20:27 +0100)]
[NTOSKRNL] Implement CcPostDeferredWrites() that executes deferred writes.
Make use of it in the lazy writer

3 years ago[NTOSKRNL] Properly implement lazy writer activity watching.
Pierre Schweitzer [Wed, 7 Feb 2018 17:56:13 +0000 (18:56 +0100)]
[NTOSKRNL] Properly implement lazy writer activity watching.
We get rid of the old iLazyWriterNotify event in favor of work items
that contain an event that lazy writer will set once its done.
To implement this, we rely on the newly introduced CcPostTickWorkQueue work queue
that will contain work items that are to be queued once lazy writer is done.

Move the CcWaitForCurrentLazyWriterActivity() implementation to the
lazy writer file, and reimplemented it using the new support mechanisms

3 years ago[NTOSKRNL] Drop the always running thread for lazy writer.
Pierre Schweitzer [Wed, 7 Feb 2018 17:10:59 +0000 (18:10 +0100)]
[NTOSKRNL] Drop the always running thread for lazy writer.
Instead move to a threading model like the Windows one.
We'll queue several work items to be executed in a system thread (Cc worker)
when there are VACB that have been marked as dirty. Furthermore, some delay
will be observed before action to avoid killing the system with IOs.
This new threading model opens way for read ahead and write behind implementation.

Also, moved the initialization of the lazy writer to CcInitializeCacheManager()
it has nothing to do with views and shouldn't be initialized there.

Also, moved the lazy writer implementation to its own file.

Modified CcDeferWrite() and CcRosMarkDirtyVacb() to take into account the new threading model.

Introduced new functions:
- CcPostWorkQueue(): post an item to be handled by Cc worker and spawn a worker if required
- CcScanDpc(): called after some time (not to have lazy writer always running) to queue a lazy scan
- CcLazyWriteScan(): the lazy writer we used to have
- CcScheduleLazyWriteScan(): function to call when you want to start a lazy writer run. It will make a DPC after some time and queue execution
- CcWorkerThread(): the worker thread that will handle lazy write, read ahead, and so on

3 years ago[NTOSKRNL] On Cc init, also define CcNumberWorkerThreads which will be used later on
Pierre Schweitzer [Wed, 7 Feb 2018 16:52:51 +0000 (17:52 +0100)]
[NTOSKRNL] On Cc init, also define CcNumberWorkerThreads which will be used later on
Also make a "default" case (really limited) in case SystemSize doesn't match.

3 years ago[NTOSKRNL] Rename ExpCriticalWorkerThreads and ExpDelayedWorkerThreads (no p)
Pierre Schweitzer [Wed, 7 Feb 2018 16:51:35 +0000 (17:51 +0100)]
[NTOSKRNL] Rename ExpCriticalWorkerThreads and ExpDelayedWorkerThreads (no p)
to match Windows names and make them available for the whole kernel.

3 years ago[NTOSKRNL] Save system size on init in CcCapturedSystemSize
Pierre Schweitzer [Wed, 7 Feb 2018 16:49:23 +0000 (17:49 +0100)]
[NTOSKRNL] Save system size on init in CcCapturedSystemSize

3 years ago[TRANSLATION] Simplified Chinese translation update for NETID and PING. (#369)
Luo Yufan [Wed, 7 Feb 2018 13:03:42 +0000 (21:03 +0800)]
[TRANSLATION] Simplified Chinese translation update for NETID and PING. (#369)

3 years ago[SYSSETUP] Hackfix CORE-14228
Giannis Adamopoulos [Wed, 7 Feb 2018 00:26:28 +0000 (02:26 +0200)]
[SYSSETUP] Hackfix CORE-14228
Wine's comctl32 somehow fails to load an 24bpp image with ImageList_LoadImageW
when crMask is CLR_NONE so use a color that doesn't exist in the bitmaps until
comctl32 gets fixed.

I prefer to add this silly hack in a non critical dll than make a hasty change in the
critical comctl32 until some proper tests are written for this absurd failure.

Giannis Adamopoulos [Tue, 6 Feb 2018 23:15:49 +0000 (01:15 +0200)]
Such a manifest is meant to be activated by the caller of the exports of the dll.
This means that the user of syssetup which is setup.exe is the one that should do the proper handling of the manifests.
Since setup.exe is the one that needs to do the right thing, add a CREATEPROCESS_MANIFEST_RESOURCE_ID to it and avoid
dealing with ISOLATIONAWARE_MANIFEST_RESOURCE_ID altogether (which is supposed to be used by activating the activation context
before calling the exports of the dll that has it). We don't really use ISOLATIONAWARE_MANIFEST_RESOURCE_ID correctly in any
place in the tree so let's rely on CREATEPROCESS_MANIFEST_RESOURCE_ID for now.

This fixes one part of CORE-14228 where no image was shown in the theme selector buttons. This happened because comctl32 was
statically linked and calling ImageList_LoadImage ended up creating an image list with comctl32 v5. Then we passed this image
list to a button created with comctl32 v6 and as a result the image list was unusable. This is yet another issue that needs
to be addressed in the future. Namely, it seems that in windows comctl32 v6 can use image lists created by comctl32 v5 whereas
we cannot.

This fix is not a hack but cleverly works around these two bugs that need to be addressed some time in the future.

3 years ago[EXPLORER] Update all preview bitmaps showing notification area
Joachim Henze [Tue, 6 Feb 2018 16:35:08 +0000 (17:35 +0100)]
[EXPLORER] Update all preview bitmaps showing notification area

To reflect recent changes in taskbar height, icon spacing,
clock x and y margins.
Also make sure all shots show the exact same time
and choose a more localization agnostic time.

3 years ago[EXPLORER] Update classic/modern startmenu preview bitmaps
Joachim Henze [Tue, 6 Feb 2018 13:48:43 +0000 (14:48 +0100)]
[EXPLORER] Update classic/modern startmenu preview bitmaps

To reflect our recent updates in banners and notification area.
Also reduces explorer binary size by 214.016bytes.

3 years ago[NTOSKRNL] Define the Mm global variables related to Cc on Mm init.
Pierre Schweitzer [Tue, 6 Feb 2018 12:38:55 +0000 (13:38 +0100)]
[NTOSKRNL] Define the Mm global variables related to Cc on Mm init.
This means that MmSystemCacheStart, MmSystemCacheEnd, MmSizeOfSystemCacheInPages
have now a valid value.
System cache is not used atm the moment though. MmMapViewInSystemCache() is to
be implemented, and Cc is to be made aware of this.


3 years ago[RAPPS] Do not resize (hide) the treeview when minimizing.
Mark Jansen [Mon, 5 Feb 2018 23:02:17 +0000 (00:02 +0100)]
[RAPPS] Do not resize (hide) the treeview when minimizing.

3 years ago[TRANSLATION] Romanian translation for FONTEXT and TIMEOUT (#363)
Bișoc George [Mon, 5 Feb 2018 17:57:39 +0000 (18:57 +0100)]
[TRANSLATION] Romanian translation for FONTEXT and TIMEOUT (#363)

[FONTEXT]: At the moment there is a comment in the en-US.rc resource file that advises to not translate it. I only created this file as a basis for the future. The file will be updated later when there is the possibility for FONTEXT to be translated further.

3 years ago[LIBXML2] Update to version 2.9.7. CORE-14291
Thomas Faber [Sun, 4 Feb 2018 16:15:47 +0000 (17:15 +0100)]
[LIBXML2] Update to version 2.9.7. CORE-14291

3 years ago[TRANSLATION][BROWSEUI][MEDIA] Simplified Chinese translations update (#360)
Luo Yufan [Mon, 5 Feb 2018 17:47:53 +0000 (01:47 +0800)]
[TRANSLATION][BROWSEUI][MEDIA] Simplified Chinese translations update (#360)

3 years ago[LIBTIFF] Restore ROS-diff that I thought was no longer needed because of PCH. CORE...
Thomas Faber [Mon, 5 Feb 2018 17:21:23 +0000 (18:21 +0100)]
[LIBTIFF] Restore ROS-diff that I thought was no longer needed because of PCH. CORE-14291

3 years ago[SHELL32] CDefViewBckgrndMenu: Fix a crash when pasting on a new explorer window.
Mark Jansen [Mon, 5 Feb 2018 16:12:00 +0000 (17:12 +0100)]
[SHELL32] CDefViewBckgrndMenu: Fix a crash when pasting on a new explorer window.

3 years ago[LIBMPG123] Update to version 1.25.8. CORE-14291
Thomas Faber [Sun, 4 Feb 2018 15:37:07 +0000 (16:37 +0100)]
[LIBMPG123] Update to version 1.25.8. CORE-14291

3 years ago[LIBTIFF] Update to version 4.0.9. CORE-14291
Thomas Faber [Sun, 4 Feb 2018 15:21:58 +0000 (16:21 +0100)]
[LIBTIFF] Update to version 4.0.9. CORE-14291

3 years ago[LIBXSLT] Update to version 1.1.32. CORE-14291
Thomas Faber [Sun, 4 Feb 2018 14:52:31 +0000 (15:52 +0100)]
[LIBXSLT] Update to version 1.1.32. CORE-14291

3 years ago[LIBXSLT] Better highlight some ROS diffs. CORE-14291
Thomas Faber [Sun, 4 Feb 2018 14:51:19 +0000 (15:51 +0100)]
[LIBXSLT] Better highlight some ROS diffs. CORE-14291

3 years ago[LIBJPEG] Update to version 9c. CORE-14291
Thomas Faber [Sun, 4 Feb 2018 12:22:20 +0000 (13:22 +0100)]
[LIBJPEG] Update to version 9c. CORE-14291

3 years ago[LIBPNG] Update to version 1.6.34. CORE-14291
Thomas Faber [Sun, 4 Feb 2018 12:08:19 +0000 (13:08 +0100)]
[LIBPNG] Update to version 1.6.34. CORE-14291

3 years ago[FREELDR] Reduce the timeout during serial mouse detection. CORE-14280 351/head
Thomas Faber [Tue, 30 Jan 2018 19:50:05 +0000 (20:50 +0100)]
[FREELDR] Reduce the timeout during serial mouse detection. CORE-14280

3 years ago[FREELDR] Remove unnecessary checks. CORE-14280
Thomas Faber [Tue, 30 Jan 2018 19:48:25 +0000 (20:48 +0100)]
[FREELDR] Remove unnecessary checks. CORE-14280

3 years ago[FREELDR] Display an additional status message for hardware detection. CORE-14280
Thomas Faber [Tue, 30 Jan 2018 19:47:12 +0000 (20:47 +0100)]
[FREELDR] Display an additional status message for hardware detection. CORE-14280

3 years ago[NTOS:MM] Make x64 address space layout more like Vista+
Timo Kreuzer [Sun, 28 Jan 2018 16:45:41 +0000 (17:45 +0100)]
[NTOS:MM] Make x64 address space layout more like Vista+
- Change MM_SYSTEM_SPACE_START to 0xFFFFF88000000000
- Move MI_DEBUG_MAPPING to the end of the system PTE range
- Add MI_SYSTEM_CACHE_START and MI_SYSTEM_CACHE_END, which is in the range that Vista uses as dynamic VA space for cache and other allocations
- Wrap x86 specific code that makes now invalid assumptions about the address space layout in #ifdef _M_IX86

3 years ago[ROSLOAD]: Continue work on target preparation OslPrepareTarget 2/104.
Alex Ionescu [Mon, 5 Feb 2018 00:01:38 +0000 (16:01 -0800)]
[ROSLOAD]: Continue work on target preparation OslPrepareTarget 2/104.
[ROSLOAD]: Stubplement OslpCheckForcedFailure, OslpGetSetBootStatusData, OslSetBootStatusData, OslGetBootStatusData.
[ROSLOAD]: Stub OslpInitializeBootStatusDataLog, OslpReadWriteBootStatusData.
[BOOTLIB]: Fix BlAppendBootOptionString to accept an actual BCD ID instead of hardcoding LibraryPath.
[BOOTLIB]: Fix BlAppendBootOptionBoolean to accept an actual BOOLEAN value instead of hardcoding TRUE.
[BOOTLIB]: Implement BlDeviceIsVirtualPartitionDevice.
[BOOTLIB]: Add missing BcdOSLoaderInteger_ForceFailure BCD value. Add BCDE_OSLOADER_TYPE_BOOT_STATUS_POLICY based on BcdEdit.exe and Geoff Chappel site.

3 years ago[SERVICES] Remove the synchronous service control pipe code
Eric Kohl [Sun, 4 Feb 2018 21:30:33 +0000 (22:30 +0100)]
[SERVICES] Remove the synchronous service control pipe code

Remove the synchronous service control pipe code because we are using the asynchronous service control pipe code for years.

3 years ago[SETUPAPI] Machine handles are pointers.
Eric Kohl [Sun, 4 Feb 2018 20:02:20 +0000 (21:02 +0100)]
[SETUPAPI] Machine handles are pointers.

3 years ago[NTOSKRNL] Yet another ASSERT...
Pierre Schweitzer [Sun, 4 Feb 2018 21:02:27 +0000 (22:02 +0100)]
[NTOSKRNL] Yet another ASSERT...


3 years ago[NTOSKRNL] Add an assert against VACB reference count overflow.
Pierre Schweitzer [Sun, 4 Feb 2018 20:46:08 +0000 (21:46 +0100)]
[NTOSKRNL] Add an assert against VACB reference count overflow.
Very likely to be hit...


3 years ago[SETUPAPI] Add a proper (SEH protected) check for LOG_CONF handles
Eric Kohl [Sun, 4 Feb 2018 19:23:51 +0000 (20:23 +0100)]
[SETUPAPI] Add a proper (SEH protected) check for LOG_CONF handles

3 years ago[SETUPAPI] Fix the coding style, annotations and debug messages
Eric Kohl [Sun, 4 Feb 2018 16:47:37 +0000 (17:47 +0100)]
[SETUPAPI] Fix the coding style, annotations and debug messages

* Fix the coding style.
* Add missing annotations.
* Add the function name to the debug messages.
* Treat all machine handles like pointers.

3 years ago[PSDK][XDK] Remove DECLSPEC_* from windef.h, protect against redefinition in winnt.h
Thomas Faber [Sun, 4 Feb 2018 18:24:00 +0000 (19:24 +0100)]
[PSDK][XDK] Remove DECLSPEC_* from windef.h, protect against redefinition in winnt.h

3 years ago[TRANSLATION] Polish translation update (#357)
Adam Słaboń [Sun, 4 Feb 2018 17:45:20 +0000 (18:45 +0100)]
[TRANSLATION] Polish translation update (#357)

3 years agoMerge branch 'master' of
Alex Ionescu [Sun, 4 Feb 2018 17:34:27 +0000 (09:34 -0800)]
Merge branch 'master' of

3 years ago[RTL]: Document and flesh out Boot Status Data (BSD) API/Structures
Alex Ionescu [Sun, 4 Feb 2018 17:33:32 +0000 (09:33 -0800)]
[RTL]: Document and flesh out Boot Status Data (BSD) API/Structures

[NDK]: Document latest RTL_BSD_DATA as of RS3 based on ext.dll WinDBG
extension "!blackboxbsd" which outputs the entire structure field by
field :).
[NDK]: Update RTL_BSD_ITEM_TYPE thanks to ole32 symbols
[RTL]: Move system volume APIs to sysvol.c
[RTL]: Fill out BsdItemTable based on actual field offsets/sizes and not
hardcoded magic numbers which we won't ask where they came from.
[RTL]: Make RtlCreateBootStatusDataFile use an appropriate structure for
initializing the buffer instead of "UCHAR Buffer[12] = {0xC,0,0,0,
1,0,0,0, 1, 0x1e, 1, 0};" which appears like magic knowledge.
[RTL]: Rename "WriteMode" to "Read" in RtlGetSetBootStatusData since
it's much less confusing.
[RTL]: Some formatting fixes, SAL updates.

3 years ago[SHELL32] Rewrite the wrapping code for shell taskbar notifications.
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 17:02:41 +0000 (18:02 +0100)]
[SHELL32] Rewrite the wrapping code for shell taskbar notifications.

- Introduce the TRAYNOTIFYDATAW structure, as documented by Geoff
  Chappell in "WM_COPYDATA for Taskbar Interface", at
  that is the data structure passed between shell32 and explorer for
  communicating shell notify icon information.

- In Shell_NotifyIcon(), correctly capture the (ANSI and) UNICODE
  structures provided by the caller, properly taking into account for
  the different NOTIFYICONDATA structure sizes existing out there.
  The different strings are now properly null-terminated (especially
  szTip if it needs to be truncated out), and the flags validated.

- Remove the now unneeded "SHELL_NotifyIcon()" helper function.

[EXPLORER] Use TRAYNOTIFYDATAW and adjust the callers.

3 years ago[STOBJECT] Don't hardcode variable type in sizeof.
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 16:21:58 +0000 (17:21 +0100)]
[STOBJECT] Don't hardcode variable type in sizeof.

3 years ago[PSDK] Fix NIF_STATE definition and add NIF_GUID.
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 16:19:40 +0000 (17:19 +0100)]
[PSDK] Fix NIF_STATE definition and add NIF_GUID.

3 years ago[BROWSEUI] Shut a warning down ("windef.h(121) : warning RC4005: 'DECLSPEC_IMPORT...
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 16:18:25 +0000 (17:18 +0100)]
[BROWSEUI] Shut a warning down ("windef.h(121) : warning RC4005: 'DECLSPEC_IMPORT' : redefinition" when compiling the resource).

3 years ago[SETUPAPI] Fix the coding style, add annotations and fix the debug messages.
Eric Kohl [Sun, 4 Feb 2018 14:40:35 +0000 (15:40 +0100)]
[SETUPAPI] Fix the coding style, add annotations and fix the debug messages.

3 years ago[MBEDTLS] Don't link with zlib, we don't use it. CORE-14290
Thomas Faber [Sat, 3 Feb 2018 13:37:22 +0000 (14:37 +0100)]
[MBEDTLS] Don't link with zlib, we don't use it. CORE-14290

3 years ago[USETUP] Use the smaller zlib_solo instead of the full zlib. CORE-14290
Thomas Faber [Sat, 3 Feb 2018 13:36:40 +0000 (14:36 +0100)]
[USETUP] Use the smaller zlib_solo instead of the full zlib. CORE-14290

3 years ago[ROSLOAD] Fix clang-cl build.
Thomas Faber [Sun, 4 Feb 2018 11:54:15 +0000 (12:54 +0100)]
[ROSLOAD] Fix clang-cl build.

3 years ago[SETUPAPI] Update some more functions to the current coding style, add annotations...
Eric Kohl [Sat, 3 Feb 2018 22:16:31 +0000 (23:16 +0100)]
[SETUPAPI] Update some more functions to the current coding style, add annotations and add function names to the TRACE calls.

3 years ago[STOBJECT] Revert b7c3398 because it was not the cause of the original problem I...
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 01:23:28 +0000 (02:23 +0100)]
[STOBJECT] Revert b7c3398 because it was not the cause of the original problem I wanted to fix (notify structure not completely zeroed-out on the receiver side of the notification).

3 years ago[EXPLORER] Don't use deprecated StrNCpy function but use the string-safe StringCchCop...
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 00:56:11 +0000 (01:56 +0100)]
[EXPLORER] Don't use deprecated StrNCpy function but use the string-safe StringCchCopy instead. Also fix a copy-paste error in the _countofs.

3 years ago[STOBJECT] Fully zero-out the full NOTIFYICONDATA structure (it wasn't zeroed out...
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 00:54:55 +0000 (01:54 +0100)]
[STOBJECT] Fully zero-out the full NOTIFYICONDATA structure (it wasn't zeroed out correctly in MSVC build).

3 years ago[NETSHELL] Don't use hardcoded values.
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 00:53:24 +0000 (01:53 +0100)]
[NETSHELL] Don't use hardcoded values.

3 years ago[SHELL32] Fix copy-pasta.
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 00:52:50 +0000 (01:52 +0100)]
[SHELL32] Fix copy-pasta.

3 years ago[PSDK] Fix NOTIFYICONDATA structure; add NOTIFYICONDATA_V3_SIZE definitions.
Hermès Bélusca-Maïto [Sun, 4 Feb 2018 00:51:46 +0000 (01:51 +0100)]
[PSDK] Fix NOTIFYICONDATA structure; add NOTIFYICONDATA_V3_SIZE definitions.

3 years ago[ROSLOAD]: Begin target preparation code. 1/104.
Alex Ionescu [Sat, 3 Feb 2018 23:52:31 +0000 (15:52 -0800)]
[ROSLOAD]: Begin target preparation code. 1/104.

[ROSLOAD]: Stubs for OslFatalErrorEx, OslAbortBoot.
OslpSanitizeLoadOptionsString, OslpSanitizeStringOptions
[ROSLOAD]: Implement OslBlStatusErrorHandler,
[ROSLOAD]: Begin work on OslPrepareTarget. Small misc. fixes.
[BOOTLIB]: Extend BlStatusError to handle a custom status error handler.

3 years ago[RAPPS] Remove trailing spaces.
Hermès Bélusca-Maïto [Sat, 3 Feb 2018 22:42:46 +0000 (23:42 +0100)]
[RAPPS] Remove trailing spaces.

3 years ago[RAPPS] Remove deprecated TODO; use _countof() where needed.
Hermès Bélusca-Maïto [Sat, 3 Feb 2018 22:40:58 +0000 (23:40 +0100)]
[RAPPS] Remove deprecated TODO; use _countof() where needed.

3 years ago[RAPPS] Usability fixes.
Hermès Bélusca-Maïto [Sat, 3 Feb 2018 22:40:11 +0000 (23:40 +0100)]
[RAPPS] Usability fixes.

3 years agoFix Linux Build
jimtabor [Sat, 3 Feb 2018 17:35:08 +0000 (11:35 -0600)]
Fix Linux Build

3 years ago[ROSLOAD]: Continue work on loader
Alex Ionescu [Sat, 3 Feb 2018 17:16:06 +0000 (09:16 -0800)]
[ROSLOAD]: Continue work on loader

[ROSLOAD]: Implement OslExecuteTransition, OslArchKernelSetup,
ArchRestoreProcessorFeatures, OslArchTransferToKernel.
[ROSLOAD]: Factor out the logo code. Clean ups.

3 years ago[CONUTILS] Fix and improve the documentation for "outstream" and "utils", addendum...
Hermès Bélusca-Maïto [Fri, 2 Feb 2018 20:48:18 +0000 (21:48 +0100)]
[CONUTILS] Fix and improve the documentation for "outstream" and "utils", addendum to f982d77.

3 years ago[CONUTILS] Diverse improvements: start doxygenating and add some resource messsage...
Hermès Bélusca-Maïto [Thu, 1 Feb 2018 23:35:08 +0000 (00:35 +0100)]
[CONUTILS] Diverse improvements: start doxygenating and add some resource messsage helper functions.

- Start to doxygenate the library, focusing in great details on the
  functions of the "outstream" module.
- Add a K32LoadStringEx function that expands (K32)LoadString by
  allowing a LanguageId parameter to be able to load strings from other
  languages than the current one.
- Add "ConResMsg*" helper functions to be able to (format and) print
  message strings with inserts that come *NOT* from a message table (as
  usual) *BUT* from resource string tables.
  Will be helpful for CORE-14265 in particular.

[CMD] Fix the call to ConMsgPrintfV().

3 years ago[NTOSKRNL] Add an helper for marking a VACB clean (ie, not dirty).
Pierre Schweitzer [Thu, 1 Feb 2018 07:35:27 +0000 (08:35 +0100)]
[NTOSKRNL] Add an helper for marking a VACB clean (ie, not dirty).


3 years ago[TRANSLATION] Simplified Chinese translations updated. (#348)
Luo Yufan [Thu, 1 Feb 2018 01:50:29 +0000 (09:50 +0800)]
[TRANSLATION] Simplified Chinese translations updated. (#348)

3 years ago[NTOSKRNL] Don't let CcWriteVirtualAddress() deal with VACB dirty status
Pierre Schweitzer [Wed, 31 Jan 2018 20:28:40 +0000 (21:28 +0100)]
[NTOSKRNL] Don't let CcWriteVirtualAddress() deal with VACB dirty status


3 years ago[IPHLPAPI_APITEST] Add tests for IcmpSendEcho
Stanislav Motylkov [Wed, 24 Jan 2018 13:32:51 +0000 (16:32 +0300)]
[IPHLPAPI_APITEST] Add tests for IcmpSendEcho

3 years ago[IPHLPAPI] Fix IcmpSendEcho output when host is not reachable
Stanislav Motylkov [Tue, 23 Jan 2018 21:28:55 +0000 (00:28 +0300)]
[IPHLPAPI] Fix IcmpSendEcho output when host is not reachable

- Add missing error code to DDK/NDIS
- Fix error code in IP driver
- Patch MSAFD to reply correct WSA error code
- Fix IcmpSendEcho function
  - Fix returning error code in ICMP_ECHO_REPLY (see MSDN)
  - Fix returning host address (using GetBestInterface and GetIpAddrTable functions)
- Fix GetBestRoute function (it is used by GetBestInterface)

Relates to #318 and CORE-14241

3 years ago[SHELL32] Fix file and folder properties dialogs
Stanislav Motylkov [Wed, 31 Jan 2018 15:05:45 +0000 (18:05 +0300)]
[SHELL32] Fix file and folder properties dialogs


3 years ago[NTOSKRNL] Fix CcIdleDelay initializer for old msvc versions (#339)
David Quintana [Wed, 31 Jan 2018 17:12:57 +0000 (18:12 +0100)]
[NTOSKRNL] Fix CcIdleDelay initializer for old msvc versions (#339)

[NTOSKRNL] Fix initialization of CcIdleDelay for msvc builds (fixes boot).
* Introduce a macro to initialize LARGE_INTEGERs in a consistent way.

3 years ago[WIN32K:NTGDI] Fix more uses of RtlCreateUnicodeString. CORE-14271
Thomas Faber [Wed, 31 Jan 2018 11:34:41 +0000 (12:34 +0100)]
[WIN32K:NTGDI] Fix more uses of RtlCreateUnicodeString. CORE-14271

Addendum to 7f687154a0fe47826d8047f1a4f9cfd93414d45f. Spotted by Hermès.

3 years ago[TIMEDATE] Correctly set the time when using the "Update now" button. CORE-14167 294/head
Doug Lyons [Tue, 16 Jan 2018 15:40:03 +0000 (16:40 +0100)]
[TIMEDATE] Correctly set the time when using the "Update now" button. CORE-14167

3 years ago[SHELLMENU] Add missing psdk dependency.
Thomas Faber [Wed, 31 Jan 2018 10:47:39 +0000 (11:47 +0100)]
[SHELLMENU] Add missing psdk dependency.

3 years ago[CMAKE] Add some fool-proofing to configure.cmd related to MSVS: 185/head
Trevor Thompson [Sun, 10 Dec 2017 10:35:10 +0000 (11:35 +0100)]
[CMAKE] Add some fool-proofing to configure.cmd related to MSVS:

-VSSolution switch now outputs to a dedicated folder if running from source directory.
-Give an error if the user is trying to mix ninja and VSSolution in the same output directory.
-In a MingW environment, give an error on VSSolution switch and give a warning on RTC switch.
-Fix -DNEW_STYLE_BUILD=0 option.
-Ensure the source path doesn't contain any spaces.
-Issue a warning if passed an invalid switch.
-Don't announce completion if there were errors.
-Make end message specific for VSSolution.
-Replace redundant exit commands with quit label, as suggested by HBelusca.

3 years ago[KMTESTS:TCPIP] Fix ok() messages.
Thomas Faber [Wed, 31 Jan 2018 09:23:44 +0000 (10:23 +0100)]
[KMTESTS:TCPIP] Fix ok() messages.

3 years ago[WIN32K:NTGDI] Correctly interpret RtlCreateUnicodeString return value. CORE-14271
Thomas Faber [Wed, 31 Jan 2018 09:26:24 +0000 (10:26 +0100)]
[WIN32K:NTGDI] Correctly interpret RtlCreateUnicodeString return value. CORE-14271

3 years ago[NTOS:CM] Correctly interpret RtlCreateUnicodeString return value. CORE-14271
Thomas Faber [Sun, 28 Jan 2018 12:42:13 +0000 (13:42 +0100)]
[NTOS:CM] Correctly interpret RtlCreateUnicodeString return value. CORE-14271

3 years ago[CONUTILS] Split stream.c into input and output stream modules.
Hermès Bélusca-Maïto [Mon, 16 Oct 2017 21:58:23 +0000 (23:58 +0200)]
[CONUTILS] Split stream.c into input and output stream modules.

As code grows, this will allow for better maintenance of the console
stream code. In particular the input stream module will contain special
code for handling TTYs, and this is something not all console programs
will need. Having this code in a separate module will allow for the linker
to possibly remove this code when it is unused.

3 years ago[TRANSLATION] Simplified Chinese translation improved. (#346)
Luo Yufan [Tue, 30 Jan 2018 20:49:40 +0000 (04:49 +0800)]
[TRANSLATION] Simplified Chinese translation improved. (#346)

3 years ago[SHIMGVW] Enable zooming
Katayama Hirofumi MZ [Tue, 30 Jan 2018 19:36:59 +0000 (04:36 +0900)]
[SHIMGVW] Enable zooming

* merge ZoomIn and ZoomOut functions
* NULL to hbrBackground

3 years ago[EXPLORER] Pixel-perfect x-margins surrounding the clock
Joachim Henze [Tue, 30 Jan 2018 17:42:21 +0000 (18:42 +0100)]
[EXPLORER] Pixel-perfect x-margins surrounding the clock

To look like XP/2k3.
Relies on d11e7af5f2539c417e980ba1b3a622f8da450603


3 years ago[NETCFGX] Rename 'Network connection' to 'Network Connection'. (#345)
Jared Smudde [Tue, 30 Jan 2018 17:07:09 +0000 (11:07 -0600)]
[NETCFGX] Rename 'Network connection' to 'Network Connection'. (#345)

English capitalization fix. It should look a little better both in the system tray and in the Network Connections folder.

3 years ago[CAROOTS] Update certificates to Mozilla Certdata 28.01.18 (#338)
Daniel Reimer [Mon, 29 Jan 2018 22:43:34 +0000 (23:43 +0100)]
[CAROOTS] Update certificates to Mozilla Certdata 28.01.18 (#338)

3 years agoRevert "[OLEAUT32] Sync with Wine 3.0. CORE-14225"
Timo Kreuzer [Sun, 28 Jan 2018 16:05:15 +0000 (17:05 +0100)]
Revert "[OLEAUT32] Sync with Wine 3.0. CORE-14225"

This reverts commit 13fd286c1840f80c0fca1dbfedd600a0f8a4478b.

The "sync" zapped a lot of fixes, in particular 64 bit compatibility.